Re: [PATCH 1/5] kselftests: dmabuf-heaps: Fix Makefile's inclusion of the kernel's usr/include dir

2021-02-09 Thread Shuah Khan
which then causes the _IOCW macros to give the wrong ioctl numbers, specifically for DMA_BUF_IOCTL_SYNC. This patch simply removes the extra include from the Makefile Cc: Shuah Khan Cc: Brian Starkey Cc: Sumit Semwal Cc: Laura Abbott Cc: Hridya Valsaraju Cc: Suren Baghdasaryan Cc: Sandeep

Re: [PATCH 00/20] Manual replacement of all strlcpy in favor of strscpy

2021-02-22 Thread Shuah Khan
On 2/22/21 8:12 AM, Romain Perier wrote: strlcpy() copy a C-String into a sized buffer, the result is always a valid NULL-terminated that fits in the buffer, howerver it has severals issues. It reads the source buffer first, which is dangerous if it is non NULL-terminated or if the corresponding

Re: [RFC v3 8/8] selftests: Add binder cgroup gpu memory transfer test

2022-03-09 Thread Shuah Khan
On 3/9/22 9:52 AM, T.J. Mercier wrote: This test verifies that the cgroup GPU memory charge is transferred correctly when a dmabuf is passed between processes in two different cgroups and the sender specifies BINDER_BUFFER_FLAG_SENDER_NO_NEED in the binder transaction data containing the dmabuf f

[PATCH] exynos-drm: Fix unsupported GEM memory type error message to be clear

2016-08-05 Thread Shuah Khan
Fix unsupported GEM memory type error message to include the memory type information. Signed-off-by: Shuah Khan --- drivers/gpu/drm/exynos/exynos_drm_fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos

[PATCH v2] exynos-drm: Fix unsupported GEM memory type error message to be clear

2016-08-08 Thread Shuah Khan
Fix unsupported GEM memory type error message to include the memory type information. Signed-off-by: Shuah Khan --- Changes since v1: -- Comment changed to read clearly drivers/gpu/drm/exynos/exynos_drm_fb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu

[PATCH] exynos-drm: Fix unsupported GEM memory type error message to be clear

2016-08-08 Thread Shuah Khan
On 08/08/2016 10:56 AM, Krzysztof Kozlowski wrote: > On Fri, Aug 05, 2016 at 07:50:06PM -0600, Shuah Khan wrote: >> Fix unsupported GEM memory type error message to include the memory type >> information. >> >> Signed-off-by: Shuah Khan >> --- >> dri

[PATCH] exynos-drm: Fix error messages to print flags and size

2016-08-10 Thread Shuah Khan
Fix exynos_drm_gem_create() error messages to include flags and size when flags and size are invalid. Signed-off-by: Shuah Khan --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers

[PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-08-10 Thread Shuah Khan
start. Check if non-contiguous GEM memory is requested without IOMMU. If so, allocate contiguous GEM memory to help display manager start. Signed-off-by: Shuah Khan --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm

[PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-08-10 Thread Shuah Khan
On 08/10/2016 04:59 PM, Inki Dae wrote: > Hi Shuah, > > 2016년 08월 11일 02:30에 Shuah Khan 이(가) 쓴 글: >> Fix exynos_drm_gem_create_ioctl() attempts to allocate non-contiguous GEM >> memory without IOMMU. In this case, there is no point in attempting to > >

[PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-08-12 Thread Shuah Khan
On 08/10/2016 05:05 PM, Shuah Khan wrote: > On 08/10/2016 04:59 PM, Inki Dae wrote: >> Hi Shuah, >> >> 2016년 08월 11일 02:30에 Shuah Khan 이(가) 쓴 글: >>> Fix exynos_drm_gem_create_ioctl() attempts to allocate non-contiguous GEM >>> memory without

[PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-08-12 Thread Shuah Khan
On 08/12/2016 11:28 AM, Shuah Khan wrote: > On 08/10/2016 05:05 PM, Shuah Khan wrote: >> On 08/10/2016 04:59 PM, Inki Dae wrote: >>> Hi Shuah, >>> >>> 2016년 08월 11일 02:30에 Shuah Khan 이(가) 쓴 글: >>>> Fix exynos_drm_gem_create

Re: [Linux-kernel-mentees][PATCH v2] drm/amdkfd: Fix undefined behavior in bit shift

2019-06-26 Thread Shuah Khan
On 6/26/19 9:25 PM, Jiunn Chang wrote: Shifting signed 32-bit value by 31 bits is undefined. Changing most significant bit to unsigned. Changes included in v2: - use subsystem specific subject lines - CC required mailing lists Signed-off-by: Jiunn Chang --- Move version change lines h

Re: [PATCH 02/10] drm: selftest: refactor drm_cmdline_parser

2022-06-17 Thread Shuah Khan
On 6/15/22 7:58 AM, Maíra Canal wrote: From: Arthur Grillo Refactor the tests by modularizing the functions to avoid code repetition. Tell me more about the refactor and how does it help. This patch seems to combine refactor with some other formatting changes that aren't necessary and making

[PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-10-12 Thread Shuah Khan
Hi Inki, On 08/15/2016 10:40 PM, Inki Dae wrote: >> >> okay the very first commit that added IOMMU support >> introduced the code that rejects non-contig gem memory >> type without IOMMU. >> >> commit 0519f9a12d0113caab78980c48a7902d2bd40c2c >> Author: Inki Dae >> Date: Sat Oct 20 07:53:42 201

[PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-10-12 Thread Shuah Khan
On 10/12/2016 05:11 PM, Shuah Khan wrote: + Fixing Krzysztof Kozlowski address. > Hi Inki, > > On 08/15/2016 10:40 PM, Inki Dae wrote: > >>> >>> okay the very first commit that added IOMMU support >>> introduced the code that rejects non-contig gem memory

exynos-drm: display manager fails to start without IOMMU problem

2016-10-17 Thread Shuah Khan
Restarting the thread with a different subject line: I haven't given up on this yet. I am still seeing the following failure: Additional debug messages I added: [ 15.287403] exynos_drm_gem_create_ioctl() 1 [ 15.287419] exynos_drm_gem_create() flags 1 [ 15.311511] [drm:exynos_drm_framebuffe

[PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-10-19 Thread Shuah Khan
On 10/19/2016 08:16 AM, Inki Dae wrote: > Hi Shuah, > > 2016-10-13 8:11 GMT+09:00 Shuah Khan : >> Hi Inki, >> >> On 08/15/2016 10:40 PM, Inki Dae wrote: >> >>>> >>>> okay the very first commit that added IOMMU support >>>> int

exynos-drm: display manager fails to start without IOMMU problem

2016-10-19 Thread Shuah Khan
On 10/19/2016 10:23 AM, Tobias Jakobi wrote: > Hello Shuah, > > just a short note that more misleading comments about default allocation > flags can be found in libdrm. > > https://cgit.freedesktop.org/mesa/drm/tree/exynos/exynos_drm.c > > See e.g. the comment for exynos_bo_create(). > > In my

[PATCH] drm: change connector disconnected debug message to an error

2017-02-02 Thread Shuah Khan
ke it easier to debug. Signed-off-by: Shuah Khan --- drivers/gpu/drm/drm_probe_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c index ac953f0..6472b7f 100644 --- a/drivers/gpu/drm/drm_probe_hel

Re: [PATCH] drm: change connector disconnected debug message to an error

2017-02-02 Thread Shuah Khan
On 02/02/2017 01:32 AM, Jani Nikula wrote: > On Thu, 02 Feb 2017, Shuah Khan wrote: >> Change drm_helper_probe_single_connector_modes() to print an error to >> report connector disconnected status instead of a debug message. >> >> When this condition occurs, applic

Re: [PATCH] drm: change connector disconnected debug message to an error

2017-02-12 Thread Shuah Khan
On 02/03/2017 01:06 AM, Daniel Vetter wrote: > On Thu, Feb 02, 2017 at 10:25:44AM -0700, Shuah Khan wrote: >> On 02/02/2017 01:32 AM, Jani Nikula wrote: >>> On Thu, 02 Feb 2017, Shuah Khan wrote: >>>> Change drm_helper_probe_single_connector_modes() to print an

[PATCH] drm: exynos: dsi: fix to return -ENODEV when DSI_PORT_OUT is not found

2017-06-18 Thread Shuah Khan
Fix exynos_dsi_parse_dt() to return -ENODEV when of_graph_get_remote_node() doesn't find DSI_PORT_OUT. -ENODEV is the correct error code to return and this change makes exynos behavior consistent with rest of the drm drivers. Signed-off-by: Shuah Khan --- drivers/gpu/drm/exynos/exynos_drm_

Re: [PATCH] drm/exynos: dsi: do not try to find bridge

2017-06-18 Thread Shuah Khan
On 06/16/2017 08:16 AM, Shuah Khan wrote: > Hi Inki, > > On Fri, Jun 16, 2017 at 1:50 AM, Inki Dae wrote: >> It doesn't need to try to find a bridge if bridge node doesn't exist. >> >> Signed-off-by: Inki Dae >> --- >> drivers/gpu/drm/exynos/ex

Re: [PATCH] drm/exynos: dsi: do not try to find bridge

2017-06-18 Thread Shuah Khan
return mipi_dsi_host_register(&dsi->dsi_host); > } > -- > 1.9.1 Looks good to me. Reviewed-by: Shuah Khan thanks, -- Shuah ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/exynos: dsi: do not try to find bridge

2017-06-19 Thread Shuah Khan
Hi Inki, On Sun, Jun 18, 2017 at 8:12 PM, Inki Dae wrote: > Hi Shuah, > > 2017년 06월 17일 05:16에 Shuah Khan 이(가) 쓴 글: >> On 06/16/2017 08:16 AM, Shuah Khan wrote: >>> Hi Inki, >>> >>> On Fri, Jun 16, 2017 at 1:50 AM, Inki Dae wrote: >>>>

[PATCH] drm: exynos: dsi: release DSI_PORT_OUT node right after of_drm_find_bridge()

2017-06-25 Thread Shuah Khan
Fix to call of_node_put() right after of_drm_find_bridge() instead of holding on to it until exynos_dsi_remove(). Suggested-by: Inki Dae Signed-off-by: Shuah Khan --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm

Re: [RFC v2 07/11] vb2: dma-contig: Remove redundant sgt_base field

2017-03-27 Thread Shuah Khan
On Thu, Dec 15, 2016 at 6:24 PM, Laurent Pinchart wrote: > From: Sakari Ailus > > The struct vb2_dc_buf contains two struct sg_table fields: sgt_base and > dma_sgt. The former is used by DMA-BUF buffers whereas the latter is used > by USERPTR. > > Unify the two, leaving dma_sgt. I think this pat

Re: [RFC v2 03/11] vb2: Move cache synchronisation from buffer done to dqbuf handler

2017-03-27 Thread Shuah Khan
On Thu, Dec 15, 2016 at 6:24 PM, Laurent Pinchart wrote: > From: Sakari Ailus > > The cache synchronisation may be a time consuming operation and thus not > best performed in an interrupt which is a typical context for > vb2_buffer_done() calls. This may consume up to tens of ms on some > machine

Re: [RFC v2 05/11] v4l2-core: Don't sync cache for a buffer if so requested

2017-03-27 Thread Shuah Khan
On Thu, Dec 15, 2016 at 6:24 PM, Laurent Pinchart wrote: > From: Samu Onkalo > > The user may request to the driver (vb2) to skip the cache maintenance > operations in case the buffer does not need cache synchronisation, e.g. in > cases where the buffer is passed between hardware blocks without i

[PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-10-25 Thread Shuah Khan
On 10/25/2016 11:57 AM, Tobias Jakobi wrote: > Hello Shuah, > > > Shuah Khan wrote: >> On 10/19/2016 04:27 PM, Shuah Khan wrote: >>> On 10/19/2016 08:16 AM, Inki Dae wrote: >>>> Hi Shuah, >>>> >>>> 2016-10-13 8:11 GMT+09:00 Shuah Kha

[PATCH] exynos-drm: Fix display manager failing to start without IOMMU problem

2016-10-25 Thread Shuah Khan
On 10/19/2016 04:27 PM, Shuah Khan wrote: > On 10/19/2016 08:16 AM, Inki Dae wrote: >> Hi Shuah, >> >> 2016-10-13 8:11 GMT+09:00 Shuah Khan : >>> Hi Inki, >>> >>> On 08/15/2016 10:40 PM, Inki Dae wrote: >>> >>>>> >>>

Re: [PATCH] staging: ion: remove from the tree

2020-08-28 Thread Shuah Khan
Laura Abbott Cc: Martijn Coenen Cc: Shuah Khan Cc: Sumit Semwal Cc: Suren Baghdasaryan Cc: Todd Kjos Cc: de...@driverdev.osuosl.org Cc: dri-devel@lists.freedesktop.org Cc: linaro-mm-...@lists.linaro.org Signed-off-by: Greg Kroah-Hartman --- MAINTAINERS

intel_check_page_flip() - WARN_ON(!in_interrupt())

2015-05-28 Thread Shuah Khan
reports on this issue. Has this been fixed? Should I be concerned about this? thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh at osg.samsung.com | (970) 217-8978

[PATCH v2 0/7] Tests for sync infrastructure

2016-12-01 Thread Shuah Khan
On 10/19/2016 06:49 AM, Emilio López wrote: > Hello everyone, > > This is a series of tests to exercise the sync kernel infrastructure. It is > meant to be a test suite for the work Gustavo has been doing to destage it. > > These tests were originally part of a battery of tests shipping with > A

[PATCH v2 0/7] Tests for sync infrastructure

2016-12-02 Thread Shuah Khan
On 12/01/2016 06:17 PM, Shuah Khan wrote: > On 10/19/2016 06:49 AM, Emilio López wrote: >> Hello everyone, >> >> This is a series of tests to exercise the sync kernel infrastructure. It is >> meant to be a test suite for the work Gustavo has been doing to destage

[PATCH v2 1/7] selftest: sync: basic tests for sw_sync framework

2016-12-13 Thread Shuah Khan
Hi Gustavo, On 11/01/2016 10:18 AM, Gustavo Padovan wrote: > Hi Emilio, > > 2016-10-19 Emilio López : > >> These tests are based on the libsync test suite from Android. >> This commit lays the ground for future tests, as well as includes >> tests for a variety of basic allocation commands. >> >

Re: [RFC v2 00/14] kunit: introduce KUnit, the Linux kernel unit testing framework

2018-10-25 Thread Shuah Khan
On 10/23/2018 05:57 PM, Brendan Higgins wrote: > This patch set proposes KUnit, a lightweight unit testing and mocking > framework for the Linux kernel. > > Unlike Autotest and kselftest, KUnit is a true unit testing framework; > it does not require installing the kernel on a test machine or in a

Re: [RFC v2 00/14] kunit: introduce KUnit, the Linux kernel unit testing framework

2018-11-02 Thread Shuah Khan
Hi Brendan, On 10/23/2018 05:57 PM, Brendan Higgins wrote: > This patch set proposes KUnit, a lightweight unit testing and mocking > framework for the Linux kernel. > > Unlike Autotest and kselftest, KUnit is a true unit testing framework; > it does not require installing the kernel on a test ma

Re: [RFC v2 01/14] kunit: test: add KUnit test runner core

2018-11-02 Thread Shuah Khan
On 10/23/2018 05:57 PM, Brendan Higgins wrote: > Add core facilities for defining unit tests; this provides a common way > to define test cases, functions that execute code which is under test > and determine whether the code under test behaves as expected; this also > provides a way to group toget

Re: [RFC v2 01/14] kunit: test: add KUnit test runner core

2018-11-07 Thread Shuah Khan
On 11/06/2018 06:28 PM, Brendan Higgins wrote: > On Fri, Nov 2, 2018 at 11:44 AM Shuah Khan wrote: >> >> On 10/23/2018 05:57 PM, Brendan Higgins wrote: > >>> + * Example: >>> + * >>> + * .. code-block:: c >>&g

Re: [PATCH] include: uapi: drm: drm_mode: fix documentation and coding style issue

2024-08-21 Thread Shuah Khan
__u16 width; + /** @height: Height of the plane in pixels. */ __u16 height; }; Reviewed-by: Shuah Khan thanks, -- Shuah

Re: linux-next: build failure after merge of the kunit-next tree

2024-03-06 Thread Shuah Khan
Hi Stephen, On 3/1/24 15:30, Shuah Khan wrote: Hi Stephen, On 3/1/24 13:46, Stephen Rothwell wrote: Hi Shuah, On Fri, 1 Mar 2024 09:05:57 -0700 Shuah Khan wrote: On 3/1/24 03:43, Stephen Rothwell wrote: Hi all, On Fri, 1 Mar 2024 15:15:02 +0800 David Gow wrote: On Thu, 29 Feb 2024 at

Re: [PATCH] kerneldoc: Fix two missing newlines in drm_connector.c

2024-08-08 Thread Shuah Khan
On 8/8/24 02:40, Daniel Yang wrote: drm_connector.c has two kerneldoc comments that were missing newlines. This results in the following warnings when running make htmldocs: ./Documentation/gpu/drm-kms:538: ./drivers/gpu/drm/drm_connector.c:2344: WARNING: Definition list ends without a blank lin

Re: [PATCH v2] kerneldoc: Fix two missing newlines in drm_connector.c

2024-08-09 Thread Shuah Khan
BT709_YCC: *XVYCC_601: @@ -2378,6 +2381,7 @@ EXPORT_SYMBOL(drm_mode_create_aspect_ratio_property); *DCI-P3_RGB_Theater: *RGB_WIDE_FIXED: *RGB_WIDE_FLOAT: + * *BT601_YCC: *The behavior is undefined. * Reviewed-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v2] gpu: ipu-v3: Add cleanup attribute for prg_node for auto cleanup

2024-08-13 Thread Shuah Khan
On 8/12/24 13:37, Abhinav Jain wrote: Hello, Can this be kindly reviewed? Thanks. You removed all the relevant information for people to be able to review the patch :) thanks, -- Shuah

Re: [PATCH 0/9] kunit: Fix printf format specifier issues in KUnit assertions

2024-02-22 Thread Shuah Khan
On 2/21/24 02:27, David Gow wrote: KUnit has several macros which accept a log message, which can contain printf format specifiers. Some of these (the explicit log macros) already use the __printf() gcc attribute to ensure the format specifiers are valid, but those which could fail the test, and

Re: [PATCH 5/9] rtc: test: Fix invalid format specifier.

2024-02-27 Thread Shuah Khan
On 2/27/24 13:32, Alexandre Belloni wrote: Hello, On 21/02/2024 17:27:18+0800, David Gow wrote: 'days' is a s64 (from div_s64), and so should use a %lld specifier. This was found by extending KUnit's assertion macros to use gcc's __printf attribute. Fixes: 1d1bb12a8b18 ("rtc: Improve performa

Re: [PATCH 7/9] drm: tests: Fix invalid printf format specifiers in KUnit tests

2024-02-27 Thread Shuah Khan
On 2/21/24 14:29, Justin Stitt wrote: Hi, On Wed, Feb 21, 2024 at 05:27:20PM +0800, David Gow wrote: The drm_buddy_test's alloc_contiguous test used a u64 for the page size, which was then updated to be an 'unsigned long' to avoid 64-bit multiplication division helpers. However, the variable i

Re: [PATCH 0/9] kunit: Fix printf format specifier issues in KUnit assertions

2024-02-27 Thread Shuah Khan
On 2/21/24 02:27, David Gow wrote: KUnit has several macros which accept a log message, which can contain printf format specifiers. Some of these (the explicit log macros) already use the __printf() gcc attribute to ensure the format specifiers are valid, but those which could fail the test, and

Re: linux-next: build failure after merge of the kunit-next tree

2024-02-29 Thread Shuah Khan
Hi Stephen, On 2/28/24 21:26, Stephen Rothwell wrote: Hi all, After merging the kunit-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from drivers/gpu/drm/tests/drm_buddy_test.c:7: drivers/gpu/drm/tests/drm_buddy_test.c: In function 'drm_test_buddy

Re: linux-next: build failure after merge of the kunit-next tree

2024-03-01 Thread Shuah Khan
On 3/1/24 03:43, Stephen Rothwell wrote: Hi all, On Fri, 1 Mar 2024 15:15:02 +0800 David Gow wrote: On Thu, 29 Feb 2024 at 23:07, Shuah Khan wrote: I can carry the fix through kselftest kunit if it works for all. I'm happy for this to go in with the KUnit changes if that's th

Re: linux-next: build failure after merge of the kunit-next tree

2024-03-01 Thread Shuah Khan
Hi Stephen, On 3/1/24 13:46, Stephen Rothwell wrote: Hi Shuah, On Fri, 1 Mar 2024 09:05:57 -0700 Shuah Khan wrote: On 3/1/24 03:43, Stephen Rothwell wrote: Hi all, On Fri, 1 Mar 2024 15:15:02 +0800 David Gow wrote: On Thu, 29 Feb 2024 at 23:07, Shuah Khan wrote: I can carry the fix

Re: [PATCH v13 8/8] selftests/udmabuf: Add tests to verify data after page migration

2024-04-04 Thread Shuah Khan
tests comes from a patch by Mike Kravetz. Add Suggested-by for Mike Kravetz Cc: Shuah Khan Cc: David Hildenbrand Cc: Daniel Vetter Cc: Mike Kravetz Cc: Hugh Dickins Cc: Peter Xu Cc: Jason Gunthorpe Cc: Gerd Hoffmann Cc: Dongwon Kim Cc: Junxiao Chang Signed-off-by: Vivek Kasireddy

Re: [PATCH 1/2] selftests: ion: Remove some prints

2018-02-26 Thread Shuah Khan
On 02/15/2018 06:24 PM, Laura Abbott wrote: > There's no need to print messages each time we alloc and free. Remove them. > > Signed-off-by: Laura Abbott > --- > tools/testing/selftests/android/ion/ionutils.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/tools/testing/selftests/

Re: [PATCH 2/2] selftests: ion: Add simple test with the vgem driver

2018-02-26 Thread Shuah Khan
On 02/19/2018 11:33 AM, Daniel Vetter wrote: > On Mon, Feb 19, 2018 at 10:18:21AM -0800, Laura Abbott wrote: >> On 02/19/2018 07:31 AM, Daniel Vetter wrote: >>> On Thu, Feb 15, 2018 at 05:24:45PM -0800, Laura Abbott wrote: Ion is designed to be a framework used by other clients who perform >>>

Re: [PATCH 2/2] selftests: ion: Add simple test with the vgem driver

2018-02-28 Thread Shuah Khan
On 02/26/2018 06:48 PM, Laura Abbott wrote: > On 02/26/2018 09:07 AM, Shuah Khan wrote: >> On 02/19/2018 11:33 AM, Daniel Vetter wrote: >>> On Mon, Feb 19, 2018 at 10:18:21AM -0800, Laura Abbott wrote: >>>> On 02/19/2018 07:31 AM, Daniel Vetter wrote: >>>>

Re: [PATCH 3/3] selftests: sync: add test that closes the fd before fence signal

2017-08-02 Thread Shuah Khan
On 07/31/2017 01:43 PM, Gustavo Padovan wrote: > 2017-07-30 Chris Wilson : > >> Quoting Gustavo Padovan (2017-07-29 16:22:17) >>> From: Gustavo Padovan >>> >>> We found this bug in the sw_sync so adding a test case to prevent it to >>> happen in t

[RFC PATCH v1 9/9] selftest: sync: disable tests that rely on not yet defined behaviour

2016-03-09 Thread Shuah Khan
+= RUN_TEST(test_consumer_stress_multi_producer_single_consumer); > err += RUN_TEST(test_merge_stress_random_merge); > -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh at osg.samsung.com | (970) 217-8978

[RFC PATCH v1 0/9] Tests for sync infrastructure

2016-03-09 Thread Shuah Khan
nc/sync_merge.c > create mode 100644 tools/testing/selftests/sync/sync_stress_consumer.c > create mode 100644 tools/testing/selftests/sync/sync_stress_merge.c > create mode 100644 tools/testing/selftests/sync/sync_stress_parallelism.c > create mode 100644 tools/testing/selftests/sync/s

Re: [PATCH] Documentation/accel/qaic: Fix typo 'phsyical'

2024-05-31 Thread Shuah Khan
On 5/31/24 00:09, Danish Prakash wrote: (as part of LFX Linux Mentorship program) Please add proper commit log for this change. Signed-off-by: Danish Prakash --- Documentation/accel/qaic/qaic.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/accel/q

Re: radeon 0000:02:00.0: GPU lockup CP stall for more than 10000msec

2012-12-26 Thread Shuah Khan
On Sun, Dec 23, 2012 at 6:31 AM, Borislav Petkov wrote: > On Sun, Dec 23, 2012 at 01:22:12PM +0100, Borislav Petkov wrote: >> Right, let me try that and report back. > > Yep, looks like reverting the above commit fixes it - the boston.com > website loads just fine. > > Thanks. > > -- > Regards/Gru

Re: radeon 0000:02:00.0: GPU lockup CP stall for more than 10000msec

2013-01-03 Thread Shuah Khan
On Wed, Jan 2, 2013 at 4:37 PM, Alex Deucher wrote: > On Wed, Jan 2, 2013 at 5:38 PM, Markus Trippelsdorf > wrote: >> On 2013.01.02 at 17:31 -0500, Jerome Glisse wrote: >>> Please affected people can you test if patch : >>> http://people.freedesktop.org/~glisse/0003-drm-radeon-fix-dma-copy-on-r6x

Re: radeon 0000:02:00.0: GPU lockup CP stall for more than 10000msec

2013-01-03 Thread Shuah Khan
On Wed, Jan 2, 2013 at 4:59 PM, Alex Deucher wrote: >>> >> >> Catching up with this thread. I reverted the >> >> drm/radeon: use async dma for ttm buffer moves on 6xx-SI >> commit id: 2d6cc7296d4ee128ab0fa3b715f0afde511f49c2 >> >> Do I need to apply this patch without reverting >> 2d6cc7296d4ee128

Re: radeon 0000:02:00.0: GPU lockup CP stall for more than 10000msec

2013-01-04 Thread Shuah Khan
top.org; Deucher, >> Alexander; Borislav Petkov; Shuah Khan >> Subject: Re: radeon :02:00.0: GPU lockup CP stall for more than >> 1msec >> >> 2013-01-03 00:37 keltezéssel, Alex Deucher írta: >> > On Wed, Jan 2, 2013 at 5:38 PM, Markus Trippelsdorf

[PATCH] drm/radeon: fix NULL pointer dereference in UMS mode

2013-01-16 Thread Shuah Khan
In UMS mode parser->rdev is NULL, so dereferencing will cause an oops. Upstream commit-id: ff4bd0827764e10a428a9d39e6814c5478863f94 Stable tree: 3.7 Signed-off-by: Ilija Hadzic Signed-off-by: Alex Deucher Signed-off-by: Shuah Khan CC: sta...@vger.kernel.org 3.7 --- drivers/gpu/drm/rad

[PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini()

2013-01-16 Thread Shuah Khan
ini() function. Signed-off-by: Shuah Khan CC: sta...@vger.kernel.org 3.7 --- drivers/gpu/drm/radeon/radeon_cs.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c index 469661f..d1c282c 100644 --- a/drivers/gpu/

Re: [PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini()

2013-01-17 Thread Shuah Khan
On Wed, 2013-01-16 at 21:06 -0600, Ilija Hadzic wrote: > Actually, the code path affected by your patch is not executed in UMS mode > at all. Notice that radeon_cs_parser_fini is only called from > radeon_cs_ioctl which is a KMS-only ioctl (see radeon_kms.c). > > The equivalent of the fix you ar

[PATCH] drm/radeon: fix a bogus kfree

2013-01-17 Thread Shuah Khan
able 3.7 Signed-off-by: Ilija Hadzic Signed-off-by: Alex Deucher Signed-off-by: Shuah Khan CC: sta...@vger.kernel.org 3.7 --- drivers/gpu/drm/radeon/r600_cs.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r

[PATCH 1/2] power: add new interface to return pm_transition state

2013-06-23 Thread Shuah Khan
off-by: Shuah Khan --- drivers/base/power/main.c | 17 + include/linux/pm.h|3 +++ 2 files changed, 20 insertions(+) diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c index c2132b8..3e2e09d 100644 --- a/drivers/base/power/main.c +++ b/drivers/base/power/

[PATCH 2/2] drm: Convert drm class driver from legacy pm ops to dev_pm_ops

2013-06-23 Thread Shuah Khan
ss->pm ops for the drm class. Signed-off-by: Shuah Khan --- drivers/gpu/drm/drm_sysfs.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index 0229665..8d94778 100644 --- a/drivers/gpu/drm/drm_sysf

Re: [PATCH 1/2] power: add new interface to return pm_transition state

2013-06-25 Thread Shuah Khan
On 06/22/2013 03:17 PM, Rafael J. Wysocki wrote: > On Saturday, June 22, 2013 02:11:14 PM Shuah Khan wrote: >> Add a new interface get_pm_transition() to return pm_transition state. >> This interface is intended to be used from dev_pm_ops class and type >> suspend interface

[PATCH] drm: Convert drm class driver from legacy pm ops to dev_pm_ops

2013-07-03 Thread Shuah Khan
uspend() is the original suspend hook with a new name. Signed-off-by: Shuah Khan --- drivers/gpu/drm/drm_sysfs.c | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index 0229665..2290b

radeon 0000:02:00.0: GPU lockup CP stall for more than 10000msec

2012-12-24 Thread Shuah Khan
On Sun, Dec 23, 2012 at 6:31 AM, Borislav Petkov wrote: > On Sun, Dec 23, 2012 at 01:22:12PM +0100, Borislav Petkov wrote: >> Right, let me try that and report back. > > Yep, looks like reverting the above commit fixes it - the boston.com > website loads just fine. > > Thanks. > > -- > Regards/Gru

radeon 0000:02:00.0: GPU lockup CP stall for more than 10000msec

2013-01-02 Thread Shuah Khan
On Wed, Jan 2, 2013 at 4:37 PM, Alex Deucher wrote: > On Wed, Jan 2, 2013 at 5:38 PM, Markus Trippelsdorf > wrote: >> On 2013.01.02 at 17:31 -0500, Jerome Glisse wrote: >>> Please affected people can you test if patch : >>> http://people.freedesktop.org/~glisse/0003-drm-radeon-fix-dma-copy-on-r6x

radeon 0000:02:00.0: GPU lockup CP stall for more than 10000msec

2013-01-02 Thread Shuah Khan
On Wed, Jan 2, 2013 at 4:59 PM, Alex Deucher wrote: >>> >> >> Catching up with this thread. I reverted the >> >> drm/radeon: use async dma for ttm buffer moves on 6xx-SI >> commit id: 2d6cc7296d4ee128ab0fa3b715f0afde511f49c2 >> >> Do I need to apply this patch without reverting >> 2d6cc7296d4ee128

radeon 0000:02:00.0: GPU lockup CP stall for more than 10000msec

2013-01-03 Thread Shuah Khan
top.org; Deucher, >> Alexander; Borislav Petkov; Shuah Khan >> Subject: Re: radeon :02:00.0: GPU lockup CP stall for more than >> 1msec >> >> 2013-01-03 00:37 keltez?ssel, Alex Deucher ?rta: >> > On Wed, Jan 2, 2013 at 5:38 PM, Markus Trippelsdorf

[PATCH] drm/radeon: fix NULL pointer dereference in UMS mode

2013-01-16 Thread Shuah Khan
In UMS mode parser->rdev is NULL, so dereferencing will cause an oops. Upstream commit-id: ff4bd0827764e10a428a9d39e6814c5478863f94 Stable tree: 3.7 Signed-off-by: Ilija Hadzic Signed-off-by: Alex Deucher Signed-off-by: Shuah Khan CC: stable at vger.kernel.org 3.7 --- drivers/gpu/drm/rad

[PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini()

2013-01-16 Thread Shuah Khan
ini() function. Signed-off-by: Shuah Khan CC: stable at vger.kernel.org 3.7 --- drivers/gpu/drm/radeon/radeon_cs.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c index 469661f..d1c282c 100644 --- a/drivers/

[PATCH] drm/radeon: fix NULL pointer dereference in UMS mode in radeon_cs_parser_fini()

2013-01-17 Thread Shuah Khan
On Wed, 2013-01-16 at 21:06 -0600, Ilija Hadzic wrote: > Actually, the code path affected by your patch is not executed in UMS mode > at all. Notice that radeon_cs_parser_fini is only called from > radeon_cs_ioctl which is a KMS-only ioctl (see radeon_kms.c). > > The equivalent of the fix you ar

[PATCH] drm/radeon: fix a bogus kfree

2013-01-17 Thread Shuah Khan
able 3.7 Signed-off-by: Ilija Hadzic Signed-off-by: Alex Deucher Signed-off-by: Shuah Khan CC: stable at vger.kernel.org 3.7 --- drivers/gpu/drm/radeon/r600_cs.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/dr

[PATCH] drm: Convert drm class driver from legacy pm ops to dev_pm_ops

2013-07-01 Thread Shuah Khan
uspend() is the original suspend hook with a new name. Signed-off-by: Shuah Khan --- drivers/gpu/drm/drm_sysfs.c | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index 0229665..2290b

[PATCH 1/2] power: add new interface to return pm_transition state

2013-06-22 Thread Shuah Khan
off-by: Shuah Khan --- drivers/base/power/main.c | 17 + include/linux/pm.h|3 +++ 2 files changed, 20 insertions(+) diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c index c2132b8..3e2e09d 100644 --- a/drivers/base/power/main.c +++ b/drivers/base/power/

[PATCH 2/2] drm: Convert drm class driver from legacy pm ops to dev_pm_ops

2013-06-22 Thread Shuah Khan
ss->pm ops for the drm class. Signed-off-by: Shuah Khan --- drivers/gpu/drm/drm_sysfs.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index 0229665..8d94778 100644 --- a/drivers/gpu/drm/drm_sysf

[PATCH 1/2] power: add new interface to return pm_transition state

2013-06-24 Thread Shuah Khan
On 06/22/2013 03:17 PM, Rafael J. Wysocki wrote: > On Saturday, June 22, 2013 02:11:14 PM Shuah Khan wrote: >> Add a new interface get_pm_transition() to return pm_transition state. >> This interface is intended to be used from dev_pm_ops class and type >> suspend interface

Re: [PATCH] drm/atmel_hlcdc: Fix uninitialized variable

2024-10-04 Thread Shuah Khan
On 10/4/24 09:08, Advait Dhamorikar wrote: atmel_hlcdc_plane_update_buffers: may use an uninitialized sr variable when the if condition remains unsatisfied As mentioned in my response to another one of your patches, include how you found the problem in the change log. Signed-off-by: Advait D

Re: [PATCH-next] Fix unintentional integer overflow

2024-10-04 Thread Shuah Khan
On 10/4/24 03:15, Sundararaju, Sathishkumar wrote: All occurrences of this error fix should have been together in a single patch both in _get and _set callbacks corresponding to f0b19b84d391, please avoid separate patch for each occurrence. Sorry Alex, I missed to note this yesterday. Regar

Re: [PATCH] Documentation/CoC: spell out enforcement for unacceptable behaviors

2024-11-11 Thread Shuah Khan
On 11/11/24 13:07, Simona Vetter wrote: On Fri, Nov 08, 2024 at 09:18:53AM -0700, Shuah Khan wrote: The Code of Conduct committee's goal first and foremost is to bring about change to ensure our community continues to foster respectful discussions. In the interest of transparency, th

Re: [PATCH] Documentation/CoC: spell out enforcement for unacceptable behaviors

2024-11-11 Thread Shuah Khan
On 11/11/24 15:35, Laurent Pinchart wrote: Hi Shuah, On Mon, Nov 11, 2024 at 02:50:45PM -0700, Shuah Khan wrote: On 11/11/24 13:07, Simona Vetter wrote: On Fri, Nov 08, 2024 at 09:18:53AM -0700, Shuah Khan wrote: The Code of Conduct committee's goal first and foremost is to bring

Re: [PATCH] Documentation/CoC: spell out enforcement for unacceptable behaviors

2024-11-12 Thread Shuah Khan
On 11/12/24 07:43, Mark Brown wrote: On Mon, Nov 11, 2024 at 02:50:45PM -0700, Shuah Khan wrote: On 11/11/24 13:07, Simona Vetter wrote: Personal take, but I think a forced public apology as the primary or at least initial coc enforcement approach is one of the worst. ... This document

Re: [PATCH] Documentation/CoC: spell out enforcement for unacceptable behaviors

2024-11-12 Thread Shuah Khan
On 11/11/24 22:18, Laurent Pinchart wrote: On Mon, Nov 11, 2024 at 05:35:11PM -0700, Shuah Khan wrote: On 11/11/24 15:35, Laurent Pinchart wrote: On Mon, Nov 11, 2024 at 02:50:45PM -0700, Shuah Khan wrote: On 11/11/24 13:07, Simona Vetter wrote: On Fri, Nov 08, 2024 at 09:18:53AM -0700

Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

2025-03-28 Thread Shuah Khan
On 3/13/25 16:05, Andrew Morton wrote: On Thu, 13 Mar 2025 11:31:12 -0700 Guenter Roeck wrote: On Thu, Mar 13, 2025 at 06:24:25PM +0100, Maxime Ripard wrote: Yeah, as with my prior review, I'm a fan of this. It makes a bunch of my very noisy tests much easier to deal with. And for the reco

Re: [PATCH] drm/amd/display: replace use of msleep(<20) with usleep_range for better accuracy

2025-04-04 Thread Shuah Khan
On 3/26/25 01:00, James Flowers wrote: msleep < 20ms will often sleep for ~20ms (according to Documentation/timers/timers-howto.rst). Can you elaborate and explain why this change is necessary? Signed-off-by: James Flowers --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2

Re: [RFC PATCH] drm/msm: Remove dead code in msm_ioctl_gem_submit()

2025-07-01 Thread Shuah Khan
On 6/23/25 12:47, I Hsin Cheng wrote: According to the report of Coverity Scan [1], "sync_file" is going to be NULL when entering the "if" section after "out_post_unlock", so "fput(sync_file->file)" is never going to be exected in this block. [1]: https://scan5.scan.coverity.com/#/project-view/