29 May 2024 3:42:48 pm Marek Szyprowski :
> On 15.05.2024 22:29, Shresth Prasad wrote:
>> Add __free cleanup handler to some variable initialisations, which
>> ensures that the resource is freed as soon as the variable goes out of
>> scope. Thus removing the need to manually
Lawall
Signed-off-by: Shresth Prasad
---
drivers/video/backlight/sky81452-backlight.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/video/backlight/sky81452-backlight.c
b/drivers/video/backlight/sky81452-backlight.c
index eb18c6eb0ff0..3c5d8125080c 100644
> Please fix the subject line to be "backlight: : ...". I came
> very close to deleting this patch without reading it ;-) .
Really sorry about that, I'll fix it.
> Do we need to get dev->of_node at all? The device, which we are
> borrowing, already owns a reference to the node so I don't see
>
20 Apr 2024 1:13:42 am Dmitry Baryshkov :
> On Sat, Apr 20, 2024 at 12:22:41AM +0530, Shresth Prasad wrote:
>>
>>> Please fix the subject line to be "backlight: : ...". I came
>>> very close to deleting this patch without reading it ;-) .
>>
>>
`dev->of_node` already has a reference to the device_node and calling
of_node_get on it is unnecessary. All conresponding calls to
of_node_put are also removed.
Signed-off-by: Shresth Prasad
---
Changes in v2:
- Change commit header and body to better reflect changes
- Remove call
Hi, any updates on this?
Has this patch been accepted?
Regards,
Shresth
I'll remove the unnecessary braces and resend the patch.
Regards,
Shresth
On Wed, May 1, 2024 at 7:49 PM Julia Lawall wrote:
>
>
>
> On Wed, 1 May 2024, Daniel Thompson wrote:
>
> > On Wed, May 01, 2024 at 06:21:46PM +0530, R Sundar wrote:
> > > Use the new cleanup magic to replace of_node_put()
`dev->of_node` already has a reference to the device_node and calling
of_node_get on it is unnecessary. All conresponding calls to
of_node_put are also removed.
Reviewed-by: Daniel Thompson
Signed-off-by: Shresth Prasad
---
Changes in v3:
- Remove unnecessary braces
drivers/vi
On Thu, May 2, 2024 at 3:06 PM Lee Jones wrote:
>
> On Thu, 02 May 2024, Shresth Prasad wrote:
>
> > `dev->of_node` already has a reference to the device_node and calling
> > of_node_get on it is unnecessary. All conresponding calls to
> > of_node_put are also remove
`dev->of_node` already has a reference to the device_node and calling
of_node_get on it is unnecessary. All conresponding calls to
of_node_put are also removed.
Reviewed-by: Daniel Thompson
Signed-off-by: Shresth Prasad
---
Changes in v3:
- Remove unnecessary braces
drivers/vi
10 matches
Mail list logo
