Re: [RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-04-28 Thread Shashank Sharma
Hello Harry, Many of us in the mail chain have discussed this before, on what is the right way to blend and tone map a SDR and a HDR buffer from same/different color spaces, and what kind of DRM plane properties will be needed. As you can see from the previous comments, that the majority of the

Re: [RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-04-30 Thread Shashank Sharma
Hello Pekka, On 30/04/21 15:13, Pekka Paalanen wrote: > On Wed, 28 Apr 2021 13:24:27 +0530 > Shashank Sharma wrote: > >> Assuming these details, A compositor will look for DRM color properties like >> these: >> >> 1. Degamma plane property : To make buffers

Re: [PATCH v2 0/3] Experimental freesync video mode optimization

2020-12-10 Thread Shashank Sharma
Hello Simon, Hope you are doing well, I was helping out Aurabindo and the team with the design, so I have taken the liberty of adding some comments on behalf of the team, Inline. On 11/12/20 3:31 am, Simon Ser wrote: > Hi, > > (CC dri-devel, Pekka and Martin who might be interested in this as w

[PATCH v2 2/2] drm/amdgpu: add work function for GPU reset event

2022-03-08 Thread Shashank Sharma
From: Shashank Sharma This patch adds a work function, which sends a GPU reset uevent and some contextual infomration, like the PID and some status flags. This work should be scheduled during a GPU reset. The userspace can do some recovery and post-processing work based on this event and

[PATCH v2 1/2] drm: Add GPU reset sysfs event

2022-03-08 Thread Shashank Sharma
From: Shashank Sharma This patch adds a new sysfs event, which will indicate the userland about a GPU reset, and can also provide some information like: - process ID of the process involved with the GPU reset - process name of the involved process - the GPU status info (using flags) This patch

Re: [PATCH v3 2/3] drm/amd/display: Add freesync video modes based on preferred modes

2020-12-14 Thread Shashank Sharma
s(struct drm_connector *connector) > { > struct amdgpu_dm_connector *amdgpu_dm_connector = > @@ -7014,6 +7180,7 @@ static int amdgpu_dm_connector_get_modes(struct > drm_connector *connector) > } else { > amdgpu_dm_connector_ddc_get_modes(connector, edid); >

Re: [PATCH v3 3/3] drm/amd/display: Skip modeset for front porch change

2020-12-14 Thread Shashank Sharma
->stream)) { > @@ -9015,6 +9144,23 @@ static int dm_update_crtc_state(struct > amdgpu_display_manager *dm, > if (!dm_old_crtc_state->stream) > goto skip_modeset; > > + if (dm_new_crtc_state->stream && > + is_timing_unchanged_for_freesync(new_crtc_state, > old_crtc_state) && > + amdgpu_exp_freesync_vid_mode) { same here > + new_crtc_state->mode_changed = false; > + DRM_DEBUG_DRIVER( > + "Mode change not required for front porch > change, " > + "setting mode_changed to %d", > + new_crtc_state->mode_changed); > + > + set_freesync_fixed_config(dm_new_crtc_state); > + > + goto skip_modeset; > + } else if (aconnector && > +is_freesync_video_mode(&new_crtc_state->mode, > aconnector) && > +amdgpu_exp_freesync_vid_mode) > + set_freesync_fixed_config(dm_new_crtc_state); > + > ret = dm_atomic_get_state(state, &dm_state); > if (ret) > goto fail; > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h > b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h > index f5a5f1ad7dba..fd5fb9dafded 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h > @@ -455,6 +455,7 @@ struct dm_crtc_state { > > bool freesync_timing_changed; > bool freesync_vrr_info_changed; > + bool freesync_video_mode; > > bool dsc_force_changed; > bool vrr_supported; With the minor comments fixed/explained above, this patch is Reviewed-by: Shashank Sharma - Shashank ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 0/4]: Picture aspect ratio support in DRM layer

2016-08-03 Thread Shashank Sharma
to handle these new aspect ratios. Shashank Sharma (4): drm: add picture aspect ratio flags drm: Add aspect ratio parsing in DRM layer video: Add new aspect ratios for HDMI 2.0 drm: Add and handle new aspect ratios in DRM layer drivers/gpu/drm/drm_mo

[PATCH 1/4] drm: add picture aspect ratio flags

2016-08-03 Thread Shashank Sharma
This patch adds drm flag bits for aspect ratio information Currently drm flag bits don't have field for mode's picture aspect ratio. This field will help the driver to pick mode with right aspect ratio, and help in setting right VIC field in avi infoframes. Signed-off-by: Shash

[PATCH 2/4] drm: Add aspect ratio parsing in DRM layer

2016-08-03 Thread Shashank Sharma
in DRM's mode conversion and mode comparision functions, to make sure kernel picks mode with right aspect ratio (as per the VIC). Signed-off-by: Shashank Sharma Signed-off-by: Lin, Jia Signed-off-by: Akashdeep Sharma --- drivers/gpu/drm/drm_modes.c | 31 +++

[PATCH 3/4] video: Add new aspect ratios for HDMI 2.0

2016-08-03 Thread Shashank Sharma
HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch adds enumeration for the new aspect ratios in the existing aspect ratio list. Signed-off-by: Shashank Sharma --- drivers/video/hdmi.c | 4 include/linux/hdmi.h | 2 ++ 2 files changed, 6 insertions(+) diff

[PATCH 4/4] drm: Add and handle new aspect ratios in DRM layer

2016-08-03 Thread Shashank Sharma
HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or viseversa. Signed-off-by: Shashank Sharma --- driv

[PATCH v2 0/4] Picture aspect ratio support in DRM layer

2016-08-09 Thread Shashank Sharma
to handle these new aspect ratios. V2: Fixed review comments from Sean, Emil, Daniel Shashank Sharma (4): drm: add picture aspect ratio flags drm: Add aspect ratio parsing in DRM layer video: Add new aspect ratios for HDMI 2.0 drm: Add and handle new aspect ratios in DRM layer drive

[PATCH v2 1/4] drm: add picture aspect ratio flags

2016-08-09 Thread Shashank Sharma
This patch adds drm flag bits for aspect ratio information Currently drm flag bits don't have field for mode's picture aspect ratio. This field will help the driver to pick mode with right aspect ratio, and help in setting right VIC field in avi infoframes. Signed-off-by: Shashank S

[PATCH v2 2/4] drm: Add aspect ratio parsing in DRM layer

2016-08-09 Thread Shashank Sharma
ormation in DRM's mode conversion and mode comparision functions, to make sure kernel picks mode with right aspect ratio (as per the VIC). V2: Addressed review comments from Sean: - Fix spellings/typo - No need to handle aspect ratio none - Add a break, for default case too Signed-off-by: Sh

[PATCH v2 3/4] video: Add new aspect ratios for HDMI 2.0

2016-08-09 Thread Shashank Sharma
HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch adds enumeration for the new aspect ratios in the existing aspect ratio list. V2: rebase Signed-off-by: Shashank Sharma Reviewed-by: Sean Paul Cc: Daniel Vetter Cc: Emil Velikov --- drivers/video/hdmi.c | 4

[PATCH v2 4/4] drm: Add and handle new aspect ratios in DRM layer

2016-08-09 Thread Shashank Sharma
HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise versa. V2: Rebase Signed-off-by: Shashank Sha

[PATCH] amdgpu: add context creation flags in CS IOCTL

2022-08-02 Thread Shashank Sharma
n, so that kernel GPU scheduler can pass this information to GPU FW, which in turn can adjust the GPU characterstics as per the workload type. Signed-off-by: Shashank Sharma Cc: Alex Deucher Cc: Marek Olsak Cc: Christian Koenig Cc: Amarnath Somalapuram --- amdgpu/amdgpu.h | 2

[PATCH 3/3] drm/i915: Handle nearest-neighbor scaling filter

2019-10-22 Thread Shashank Sharma
ntainers can suggest. Signed-off-by: Shashank Sharma --- drivers/gpu/drm/i915/display/intel_display.c | 102 ++ .../drm/i915/display/intel_display_types.h| 3 + drivers/gpu/drm/i915/i915_reg.h | 31 ++ 3 files changed, 136 insertions(+) diff --git a/drivers/

[PATCH 0/3] Add scaling filters in DRM layer

2019-10-22 Thread Shashank Sharma
published for the same, which can be seen here: https://patchwork.freedesktop.org/series/66175/ Shashank Sharma (3): drm: Introduce scaling filter mode property drm/i915: Add support for scaling filters drm/i915: Handle nearest-neighbor scaling filter drivers/gpu/drm/drm_atomic_uapi.c

[PATCH 2/3] drm/i915: Add support for scaling filters

2019-10-22 Thread Shashank Sharma
This patch does the following: - Creates the CRTC property for scaling filter mode (for GEN11 and +). - Applies the chosen filter value while enabling the panel fitter. - Adds CRTC state readouts and comparisons. Signed-off-by: Shashank Sharma --- drivers/gpu/drm/i915/display/intel_display.c

[PATCH 1/3] drm: Introduce scaling filter mode property

2019-10-22 Thread Shashank Sharma
pick filters like Nearest-neighbor applied for non-blurry outputs. There was a RFC patch series published, to discus the request to enable Integer mode scaling by some of the gaming communities, which can be found here: https://patchwork.freedesktop.org/series/66175/ Signed-off-by: Shashank S

[ANNOUNCE] xf86-video-amdgpu 23.0.0

2023-02-22 Thread Shashank Sharma
Use DRM_CAP_CURSOR_WIDTH/HEIGHT if possible Shashank Sharma (2): config: Add hotplug driver name Bump version for the 23.0.0 release tiancyin (1): Fix screen corruption on secondary GPU Łukasz Spintzyk (1): amdgpu: fixup driver for new X server ABI git tag: xf86-video-a

Re: [PATCH 1/3] drm/amdgpu: Add new api to switch on/off power profile mode

2023-08-14 Thread Shashank Sharma
Hey Arvind, On 14/08/2023 09:34, Arvind Yadav wrote: This patch adds a function which will allow to change the GPU power profile based on a submitted job. This can optimize the power performance when the workload is on. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by

Re: [PATCH 3/3] Revert "drm/amd/amdgpu: switch on/off vcn power profile mode"

2023-08-14 Thread Shashank Sharma
api is added to switch on/off profile mode. These new api will allow to change the GPU power profile based on a submitted job. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 14 ++ 1 file change

Re: [PATCH v4 2/4] drm/amdgpu: Rework coredump to use memory dynamically

2023-08-16 Thread Shashank Sharma
On 16/08/2023 11:48, Christian König wrote: Am 15.08.23 um 21:50 schrieb André Almeida: Instead of storing coredump information inside amdgpu_device struct, move if to a proper separated struct and allocate it dynamically. This will make it easier to further expand the logged information. Sig

Re: [PATCH v4 2/4] drm/amdgpu: Rework coredump to use memory dynamically

2023-08-16 Thread Shashank Sharma
Hello Andre, On 15/08/2023 21:50, André Almeida wrote: Instead of storing coredump information inside amdgpu_device struct, move if to a proper separated struct and allocate it dynamically. This will make it easier to further expand the logged information. Signed-off-by: André Almeida --- v4:

Re: [PATCH v4 2/4] drm/amdgpu: Rework coredump to use memory dynamically

2023-08-17 Thread Shashank Sharma
On 17/08/2023 15:45, André Almeida wrote: Hi Shashank, Em 17/08/2023 03:41, Shashank Sharma escreveu: Hello Andre, On 15/08/2023 21:50, André Almeida wrote: Instead of storing coredump information inside amdgpu_device struct, move if to a proper separated struct and allocate it dynamically

Re: [PATCH v4 2/4] drm/amdgpu: Rework coredump to use memory dynamically

2023-08-17 Thread Shashank Sharma
On 17/08/2023 17:17, André Almeida wrote: Em 17/08/2023 12:04, Shashank Sharma escreveu: On 17/08/2023 15:45, André Almeida wrote: Hi Shashank, Em 17/08/2023 03:41, Shashank Sharma escreveu: Hello Andre, On 15/08/2023 21:50, André Almeida wrote: Instead of storing coredump information

Re: [PATCH v4 2/4] drm/amdgpu: Rework coredump to use memory dynamically

2023-08-17 Thread Shashank Sharma
On 17/08/2023 17:38, André Almeida wrote: Em 17/08/2023 12:26, Shashank Sharma escreveu: On 17/08/2023 17:17, André Almeida wrote: Em 17/08/2023 12:04, Shashank Sharma escreveu: On 17/08/2023 15:45, André Almeida wrote: Hi Shashank, Em 17/08/2023 03:41, Shashank Sharma escreveu

Re: [PATCH 0/4] drm/amdgpu: Explicitly add a flexible array at the end of 'struct amdgpu_bo_list' and simplify amdgpu_bo_list_create()

2023-08-21 Thread Shashank Sharma
+ Amar should be able to help. Amar, Can you please check this patch (series if required) with a few IGTs and probably with Xonotic as well ? Regards Shashank On 21/08/2023 13:03, Christian König wrote: Am 20.08.23 um 11:51 schrieb Christophe JAILLET: This serie simplifies amdgpu_bo_list

Re: [PATCH v2 1/7] drm/amdgpu: Added init/fini functions for workload

2023-08-21 Thread Shashank Sharma
Hey Arvind, On 21/08/2023 08:47, Arvind Yadav wrote: The'struct amdgpu_smu_workload' initialization/cleanup functions is added by this patch. v2: - Splitting big patch into separate patches. - Added new fini function. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Sig

Re: [PATCH v2 2/7] drm/amdgpu: Add new function to set GPU power profile

2023-08-21 Thread Shashank Sharma
. - Addressed review comment. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/amdgpu_workload.c | 56 +++ drivers/gpu/drm/amd/include/amdgpu_workload.h | 3 + 2 files changed, 59 insertions(+) diff --git a

Re: [PATCH v2 3/7] drm/amdgpu: Add new function to put GPU power profile

2023-08-21 Thread Shashank Sharma
comes within 100ms then the *_workload_profile_set function will cancel this work and set the GPU power profile based on preferences. v2: - Splitting workload_profile_set and workload_profile_put into two separate patches. - Addressed review comment. Cc: Shashank Sharma Cc: Christian

Re: [PATCH v2 4/7] drm/amdgpu: Add suspend function to clear the GPU power profile.

2023-08-21 Thread Shashank Sharma
On 21/08/2023 08:47, Arvind Yadav wrote: This patch adds a suspend function that will clear the GPU power profile before going into suspend state. v2: - Add the new suspend function based on review comment. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Arvind

Re: [PATCH v2 5/7] drm/amdgpu: Switch on/off GPU workload profile

2023-08-21 Thread Shashank Sharma
On 21/08/2023 08:47, Arvind Yadav wrote: This patch is to switch the GPU workload profile based on the submitted job. The workload profile is reset to default when the job is done. Cc: Shashank Sharma Cc: Christian Koenig Cc: Alex Deucher Signed-off-by: Arvind Yadav --- drivers/gpu/drm

Re: [PATCH v2 6/7] drm/amdgpu: switch workload context to/from compute

2023-08-21 Thread Shashank Sharma
On 21/08/2023 08:47, Arvind Yadav wrote: This patch switches the GPU workload mode to/from compute mode, while submitting compute workload. Cc: Christian Koenig Signed-off-by: Alex Deucher Signed-off-by: Shashank Sharma Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu

Re: [PATCH v2 7/7] Revert "drm/amd/amdgpu: switch on/off vcn power profile mode"

2023-08-21 Thread Shashank Sharma
Someone from MM should also confirm on this, but: Acked-by: Shashank Sharma On 21/08/2023 08:47, Arvind Yadav wrote: This reverts commit 5ce71f59bb9bd3d8a09b96afdbc92975cb6dc303. Reason for revert: New amdgpu_workload_profile* api is added to switch on/off profile mode. These new api will

Re: [PATCH v2 1/7] drm/amdgpu: Added init/fini functions for workload

2023-08-21 Thread Shashank Sharma
On 21/08/2023 15:35, Yadav, Arvind wrote: On 8/21/2023 6:36 PM, Shashank Sharma wrote: Hey Arvind, On 21/08/2023 08:47, Arvind Yadav wrote: The'struct amdgpu_smu_workload' initialization/cleanup functions is added by this patch. v2: - Splitting big patch into separate patches. -

Re: [PATCH v5 2/5] drm/amdgpu: Rework coredump to use memory dynamically

2023-08-21 Thread Shashank Sharma
;job->vm->task_info; - amdgpu_reset_capture_coredumpm(tmp_adev); -#endif + + amdgpu_coredump(tmp_adev, vram_lost, reset_context); + if (vram_lost) { DRM_INFO("VRAM is lost due to GPU reset!\n"); amdgpu_inc_vram_lost(tmp_adev); Reviewed-by: Shashank Sharma - Shashank

Re: [PATCH v5 3/5] drm/amdgpu: Encapsulate all device reset info

2023-08-21 Thread Shashank Sharma
On 17/08/2023 20:20, André Almeida wrote: To better organize struct amdgpu_device, keep all reset information related fields together in a separated struct. Signed-off-by: André Almeida --- v5: new patch, as requested by Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 34

Re: [PATCH v5 4/5] drm/amdgpu: Move coredump code to amdgpu_reset file

2023-08-21 Thread Shashank Sharma
struct timespec64 reset_time; + bool reset_vram_lost; +}; +#endif int amdgpu_reset_init(struct amdgpu_device *adev); int amdgpu_reset_fini(struct amdgpu_device *adev); @@ -126,4 +134,6 @@ void amdgpu_device_lock_reset_domain(struct amdgpu_reset_domain *reset_domain); void amdgpu_device_unlock_reset_domain(struct amdgpu_reset_domain *reset_domain); +void amdgpu_coredump(struct amdgpu_device *adev, bool vram_lost, +struct amdgpu_reset_context *reset_context); #endif Reviewed-by: Shashank Sharma - Shashank

Re: [PATCH v5 5/5] drm/amdgpu: Create version number for coredumps

2023-08-21 Thread Shashank Sharma
09 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h @@ -88,6 +88,9 @@ struct amdgpu_reset_domain { }; #ifdef CONFIG_DEV_COREDUMP + +#define AMDGPU_COREDUMP_VERSION "1" + Reviewed-by: Shashank Sharma - Shashank struct amdgpu_coredump_info { struct amdgpu_device*adev; struct amdgpu_task_info reset_task_info;

Re: [PATCH v2 1/7] drm/amdgpu: Added init/fini functions for workload

2023-08-21 Thread Shashank Sharma
On 21/08/2023 16:12, Yadav, Arvind wrote: On 8/21/2023 7:24 PM, Shashank Sharma wrote: On 21/08/2023 15:35, Yadav, Arvind wrote: On 8/21/2023 6:36 PM, Shashank Sharma wrote: Hey Arvind, On 21/08/2023 08:47, Arvind Yadav wrote: The'struct amdgpu_smu_workload' initializati

[PATCH v3 1/4] drm/i915: Add lspcon resume function

2016-10-17 Thread Shashank Sharma
comments from Imre - move lspcon_resume call to encoder->reset() - use early returns Signed-off-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_dp.c | 7 ++- drivers/gpu/drm/i915/intel_drv.h| 1 + drivers/gpu/drm/i915/intel_lspcon.c | 8 3 files changed,

[PATCH v3 2/4] drm: Add aspect ratio parsing in DRM layer

2016-10-17 Thread Shashank Sharma
ormation in DRM's mode conversion and mode comparision functions, to make sure kernel picks mode with right aspect ratio (as per the VIC). Signed-off-by: Shashank Sharma Signed-off-by: Lin, Jia Signed-off-by: Akashdeep Sharma Reviewed-by: Jim Bride Cc: Daniel Vetter Cc: Emil Velikov

[PATCH v3 3/4] video: Add new aspect ratios for HDMI 2.0

2016-10-17 Thread Shashank Sharma
HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch adds enumeration for the new aspect ratios in the existing aspect ratio list. Signed-off-by: Shashank Sharma Reviewed-by: Sean Paul Cc: Daniel Vetter Cc: Emil Velikov V2: rebase V3: rebase --- drivers/video

[PATCH v3 0/4] Picture aspect ratio support in DRM layer

2016-10-17 Thread Shashank Sharma
to handle these new aspect ratios. V2: Fixed review comments from Sean, Emil, Daniel V3: Fixed review comment from Jim Bride, got r-b for all patches Shashank Sharma (4): drm/i915: Add lspcon resume function drm: Add aspect ratio parsing in DRM layer video: Add new aspect ratios for HDMI

[PATCH v3 4/4] drm: Add and handle new aspect ratios in DRM layer

2016-10-17 Thread Shashank Sharma
HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise versa. Signed-off-by: Shashank Sharma Reviewed

[PATCH v3 0/4]: Picture aspect ratio support in DRM layer

2016-10-17 Thread Shashank Sharma
to handle these new aspect ratios. V2: Fixed review comments from Sean, Emil, Daniel V3: Fixed review comments from Jim Bride, got r-b for all patches Shashank Sharma (4): drm: add picture aspect ratio flags drm: Add aspect ratio parsing in DRM layer video: Add new aspect ratios for HDMI 2.0

[PATCH v3 2/4] drm: Add aspect ratio parsing in DRM layer

2016-10-17 Thread Shashank Sharma
ormation in DRM's mode conversion and mode comparision functions, to make sure kernel picks mode with right aspect ratio (as per the VIC). Signed-off-by: Shashank Sharma Signed-off-by: Lin, Jia Signed-off-by: Akashdeep Sharma Reviewed-by: Jim Bride Cc: Daniel Vetter Cc: Emil Velikov

[PATCH v3 1/4] drm: add picture aspect ratio flags

2016-10-17 Thread Shashank Sharma
This patch adds drm flag bits for aspect ratio information Currently drm flag bits don't have field for mode's picture aspect ratio. This field will help the driver to pick mode with right aspect ratio, and help in setting right VIC field in avi infoframes. Signed-off-by: Shash

[PATCH v3 3/4] video: Add new aspect ratios for HDMI 2.0

2016-10-17 Thread Shashank Sharma
HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch adds enumeration for the new aspect ratios in the existing aspect ratio list. Signed-off-by: Shashank Sharma Reviewed-by: Sean Paul Cc: Daniel Vetter Cc: Emil Velikov V2: rebase V3: rebase --- drivers/video

[PATCH v3 4/4] drm: Add and handle new aspect ratios in DRM layer

2016-10-17 Thread Shashank Sharma
HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise versa. Signed-off-by: Shashank Sharma Reviewed

[PATCH v4 0/4] Picture aspect ratio support in DRM layer

2016-10-17 Thread Shashank Sharma
to handle these new aspect ratios. V2: Fixed review comments from Sean, Emil, Daniel V3: Fixed review comments from Jim Bride, got r-b for all patches V4: Added r-b from Jose for the series, and ack-by from Tomi on patch 3 Shashank Sharma (4): drm: add picture aspect ratio flags drm: Add as

[PATCH v4 2/4] drm: Add aspect ratio parsing in DRM layer

2016-10-17 Thread Shashank Sharma
ormation in DRM's mode conversion and mode comparision functions, to make sure kernel picks mode with right aspect ratio (as per the VIC). Signed-off-by: Shashank Sharma Signed-off-by: Lin, Jia Signed-off-by: Akashdeep Sharma Reviewed-by: Jim Bride Reviewed-by: Jose Abreu Cc: Daniel Vet

[PATCH v4 4/4] drm: Add and handle new aspect ratios in DRM layer

2016-10-17 Thread Shashank Sharma
HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise versa. Signed-off-by: Shashank Sharma Reviewed

[PATCH v4 1/4] drm: add picture aspect ratio flags

2016-10-17 Thread Shashank Sharma
This patch adds drm flag bits for aspect ratio information Currently drm flag bits don't have field for mode's picture aspect ratio. This field will help the driver to pick mode with right aspect ratio, and help in setting right VIC field in avi infoframes. Signed-off-by: Shash

[PATCH v4 3/4] video: Add new aspect ratios for HDMI 2.0

2016-10-17 Thread Shashank Sharma
HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch adds enumeration for the new aspect ratios in the existing aspect ratio list. Signed-off-by: Shashank Sharma Reviewed-by: Sean Paul Reviewed-by: Jose Abreu Acked-by: Tomi Valkeinen Cc: Daniel Vetter Cc: Emil

[PATCH v6] drm: Helper for lspcon in drm_dp_dual_mode

2016-10-17 Thread Shashank Sharma
s/reqd_mode/mode - remove unnecessary void* cast - remove drm_edid.h from includes - Add a comment for _HAS_DPCD - Fix enum description, for lspcon_mode. v5: Rebase v6: Rebase Signed-off-by: Shashank Sharma Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/drm_dp_dual_mode_helper.c | 103 +

[PATCH] drm: Complete CEA modedb(VIC 1-107)

2016-10-20 Thread Shashank Sharma
(VIC=65 onwards). This patch adds: - Timings for existing CEA video modes (from VIC=65 till VIC=92) - Newly added 4k modes (from VIC=93 to VIC=107). Signed-off-by: Shashank Sharma Signed-off-by: Sonika Jindal Cc: Joes Abreu --- drivers/gpu/drm/drm_edid.c | 231

[PATCH 03/11] drm: parse ycbcr 420 vdb block

2017-04-07 Thread Shashank Sharma
tch: https://patchwork.kernel.org/patch/9492327/ so the authorship is maintained. Cc: Ville Syrjala Signed-off-by: Jose Abreu Signed-off-by: Shashank Sharma --- drivers/gpu/drm/drm_edid.c | 54 +++-- drivers/gpu/drm/drm_modes.c | 10 +++-- include/drm/drm_connec

[PATCH 02/11] drm/edid: Complete CEA modedb(VIC 1-107)

2017-04-07 Thread Shashank Sharma
formatting for VIC 93-107 V3: Rebase on drm-tip, added R-B from Jose, Alex. V4: Addressed review comments from Andrzej not to modify the VIC filed for HDMI 1.4b sinks (by adding another patch). Reviewed-by: Jose Abreu Reviewed-by: Alex Deucher Signed-off-by: Shashank Sharma --- drivers

[PATCH 00/11] HDMI YCBCR output handling in DRM layer

2017-04-07 Thread Shashank Sharma
Abreu (1): drm: parse ycbcr 420 vdb block Shashank Sharma (10): drm: Add HDMI 2.0 VIC support for AVI info-frames drm/edid: Complete CEA modedb(VIC 1-107) drm: parse ycbcr420 vcb block drm: parse ycbcr 420 deep color information drm: create hdmi output property drm: set output colorspa

[PATCH 01/11] drm: Add HDMI 2.0 VIC support for AVI info-frames

2017-04-07 Thread Shashank Sharma
dy above 80 char, so checkpatch gives 80 char warning again. - gpu/drm/omapdrm/omap_encoder.c - gpu/drm/i915/intel_sdvo.c Signed-off-by: Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c| 2 +- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c| 2 +- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c

[PATCH 09/11] drm/i915: handle csc for ycbcr HDMI output

2017-04-07 Thread Shashank Sharma
andler, to perform RGB->YCBCR conversion as per recommended spec values. Cc: Ville Syrjala Cc: Daniel Vetter Cc: Ander Conselvan De Oliveira Signed-off-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_color.c | 49 +++- drivers/gpu/drm/i915/intel_displ

[PATCH 10/11] drm/i915: prepare ycbcr420 modeset

2017-04-07 Thread Shashank Sharma
DMI ycbcr420 outputs. - Programs PIPE_MISC register for ycbcr420 output. - Adds a new scaler user "HDMI output" to plug-into existing scaler framework. This output is identified with bit 30 of the scaler users bitmap. Cc: Ville Syrjala Cc: Ander Conselvan De Oliveira Signed-off

[PATCH 08/11] drm/i915: handle ycbcr outputs

2017-04-07 Thread Shashank Sharma
: Ville Syrjala Cc: Daniel Vetter Cc: Ander Conselvan De Oliveira Signed-off-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/gpu/drm/i915/intel_hdmi.c| 161 ++- 3 files changed, 162

[PATCH 07/11] drm: set output colorspace in AVI infoframe

2017-04-07 Thread Shashank Sharma
infoframes. Cc: Ville Syrjala Cc: Jose Abreu Signed-off-by: Shashank Sharma --- drivers/gpu/drm/drm_edid.c | 40 include/drm/drm_edid.h | 5 + 2 files changed, 45 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm

[PATCH 11/11] drm/i915: set colorspace for ycbcr outputs

2017-04-07 Thread Shashank Sharma
When HDMI output is other than RGB, we have to load the corresponding colorspace of output mode. This patch fills the colorspace of AVI infoframe as per the HDMI output mode. Cc: Ville Syrjala Cc: Ander Conselvan De Oliveira Signed-off-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_hdmi.c

[PATCH 04/11] drm: parse ycbcr420 vcb block

2017-04-07 Thread Shashank Sharma
means first video mode in the svd list, can be supported in ycbcr420 output too. Bit 2 means second video mode from svd list, and so on. Cc: Ville Syrjala Cc: Jose Abreu Signed-off-by: Shashank Sharma --- drivers/gpu/drm/drm_edid.c | 80 +++-- includ

[PATCH 05/11] drm: parse ycbcr 420 deep color information

2017-04-07 Thread Shashank Sharma
: Shashank Sharma --- drivers/gpu/drm/drm_edid.c | 15 +++ include/drm/drm_connector.h | 1 + include/drm/drm_edid.h | 5 + 3 files changed, 21 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index d01b7df..828b781 100644 --- a/drivers/gpu

[PATCH 06/11] drm: create hdmi output property

2017-04-07 Thread Shashank Sharma
, so no changes if you dont set the property. Cc: Ville Syrjala Cc: Jose Abreu Cc: Daniel Vetter Signed-off-by: Shashank Sharma --- drivers/gpu/drm/drm_atomic.c| 2 ++ drivers/gpu/drm/drm_atomic_helper.c | 4 drivers/gpu/drm/drm_connector.c | 31

[PATCH] RFC: Design: DRM: Blending pipeline using DRM plane properties

2017-04-24 Thread Shashank Sharma
This patch proposes a RFC design to handle blending of various framebuffers with different color spaces, using the DRM color properties. Signed-off-by: Shashank Sharma --- drivers/gpu/drm/rfc-design-blending.txt | 52 + 1 file changed, 52 insertions(+) create

[PATCH v3] drm/edid: Complete CEA modedb(VIC 1-107)

2017-01-28 Thread Shashank Sharma
formatting for VIC 93-107 V3: Rebase on drm-tip Signed-off-by: Shashank Sharma Signed-off-by: Sonika Jindal Reviewed-by: Jose Abreu Reviewed-by: Alex Deucher --- drivers/gpu/drm/drm_edid.c | 215 + 1 file changed, 215 insertions(+) diff --git a/drivers/gpu

[PATCH 0/6] HDMI 2.0: Scrambling support in DRM layer

2017-02-01 Thread Shashank Sharma
add functions for scrambling detection and scrambling control. - Next two patches use this infrastructure in DRM layer from I915 driver, to enable scrambling on a GLK deivce which sports a native HDMI 2.0 controller. Shashank Sharma (4): drm/edid: detect SCDC support in HF-VSDB drm

[PATCH 2/6] drm/edid: check for HF-VSDB block

2017-02-01 Thread Shashank Sharma
From: Thierry Reding This patch implements a small function that finds if a given CEA db is hdmi-forum vendor specific data block or not. Signed-off-by: Thierry Reding --- drivers/gpu/drm/drm_edid.c | 15 +++ include/linux/hdmi.h | 1 + 2 files changed, 16 insertions(+) dif

[PATCH 1/6] drm: Add SCDC helpers

2017-02-01 Thread Shashank Sharma
From: Thierry Reding SCDC is a mechanism defined in the HDMI 2.0 specification that allows the source and sink devices to communicate. This commit introduces helpers to access the SCDC and provides the symbolic names for the various registers defined in the specification. Signed-off-by: Thierry

[PATCH 6/6] drm/i915: allow HDMI 2.0 clock rates

2017-02-01 Thread Shashank Sharma
Geminilake has a native HDMI 2.0 controller, which is capable of driving clocks upto 594Mhz. This patch updates the max tmds clock limit for the same. Signed-off-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915

[PATCH 5/6] drm/i915: enable scrambling

2017-02-01 Thread Shashank Sharma
. Signed-off-by: Shashank Sharma --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_ddi.c | 5 + drivers/gpu/drm/i915/intel_drv.h | 2 ++ drivers/gpu/drm/i915/intel_hdmi.c | 42 +++ 4 files changed, 51 insertions(+) diff --git a

[PATCH 4/6] drm: scrambling support in drm layer

2017-02-01 Thread Shashank Sharma
using SCDC read. - Two functions to enable/disable scrambling using SCDC read/write. - Few new bools to reflect scrambling support and status. Signed-off-by: Shashank Sharma --- drivers/gpu/drm/drm_edid.c | 131 +++- include/drm/drm_connector.h | 24

[PATCH 3/6] drm/edid: detect SCDC support in HF-VSDB

2017-02-01 Thread Shashank Sharma
, checks if sink is capable of generating scdc read request, and marks it in hdmi_info structure. Signed-off-by: Shashank Sharma --- drivers/gpu/drm/drm_edid.c | 14 ++ include/drm/drm_connector.h | 26 ++ 2 files changed, 40 insertions(+) diff --git a/drivers/gpu

[PATCH v2 3/6] drm/edid: detect SCDC support in HF-VSDB

2017-02-06 Thread Shashank Sharma
set (supported, read request supported) etc in it. Ville: - Change rr -> read_request - Call drm_detect_scrambling function drm_parse_hf_vsdb so that all of HF-VSDB parsing can be kept in same function, in incremental patches. Reviewed-by: Thierry Reding Signed-off-by: Shashank Sharma --- d

[PATCH v2 2/6] drm/edid: check for HF-VSDB block

2017-02-06 Thread Shashank Sharma
From: Thierry Reding This patch implements a small function that finds if a given CEA db is hdmi-forum vendor specific data block or not. Signed-off-by: Thierry Reding Signed-off-by: Shashank Sharma --- drivers/gpu/drm/drm_edid.c | 15 +++ include/linux/hdmi.h | 1 + 2

[PATCH v2 0/6] HDMI 2.0: Scrambling in DRM layer

2017-02-06 Thread Shashank Sharma
signed-off-by:self in first two patches(Jani N) Shashank Sharma (4): drm/edid: detect SCDC support in HF-VSDB drm: scrambling support in drm layer drm/i915: enable scrambling drm/i915: allow HDMI 2.0 clock rates Thierry Reding (2): drm: Add SCDC helpers drm/edid: check for HF-VSDB block

[PATCH v2 5/6] drm/i915: enable scrambling

2017-02-06 Thread Shashank Sharma
. V2: Addressed review comments from Ville: - Do not track scrambling status in DRM layer, track somewhere in driver like in intel_crtc_state. - Don't talk to monitor at such a low layer, set monitor scrambling in intel_enable_ddi() before enabling the port. Signed-off-by: Shashank S

[PATCH v2 1/6] drm: Add SCDC helpers

2017-02-06 Thread Shashank Sharma
: Thierry Reding Signed-off-by: Shashank Sharma --- Documentation/gpu/drm-kms-helpers.rst | 12 drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/drm_scdc_helper.c | 111 include/drm/drm_scdc_helper.h | 132 ++ 4

[PATCH v2 4/6] drm: scrambling support in drm layer

2017-02-06 Thread Shashank Sharma
ock ratio bit also, while enabling scrambling. Dhinakaran: - Add a comment about *5000 while extracting max clock supported. Signed-off-by: Shashank Sharma --- drivers/gpu/drm/drm_edid.c| 33 - drivers/gpu/drm/drm_scdc_helper.c | 100 +

[PATCH v2 6/6] drm/i915: allow HDMI 2.0 clock rates

2017-02-06 Thread Shashank Sharma
Geminilake has a native HDMI 2.0 controller, which is capable of driving clocks upto 594Mhz. This patch updates the max tmds clock limit for the same. V2: rebase Cc: Ander Signed-off-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v3 3/6] drm/edid: detect SCDC support in HF-VSDB

2017-02-10 Thread Shashank Sharma
ter set (supported, read request supported) etc in it. Ville: - Change rr -> read_request - Call drm_detect_scrambling function drm_parse_hf_vsdb so that all of HF-VSDB parsing can be kept in same function, in incremental patches. V3: Rebase. Signed-off-by: Shashank Sharma Revie

[PATCH v3 0/6] HDMI 2.0: Scrambling in DRM layer

2017-02-10 Thread Shashank Sharma
- added signed-off-by:self in first two patches(Jani N) V3: - addressed review comments from Jose and Jani Shashank Sharma (4): drm/edid: detect SCDC support in HF-VSDB drm: scrambling support in drm layer drm/i915: enable scrambling drm/i915: allow HDMI 2.0 clock rates Thierry Reding (2

[PATCH v3 1/6] drm: Add SCDC helpers

2017-02-10 Thread Shashank Sharma
R-B from Jose. Signed-off-by: Thierry Reding Signed-off-by: Shashank Sharma Reviewed-by: Jose Abreu --- Documentation/gpu/drm-kms-helpers.rst | 12 drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/drm_scdc_helper.c | 111 include/drm

[PATCH v3 4/6] drm: scrambling support in drm layer

2017-02-10 Thread Shashank Sharma
ock ratio bit also, while enabling scrambling. Dhinakaran: - Add a comment about *5000 while extracting max clock supported. V3: Addressed review comments from Jose. - Create separate functions to enable scrambling and to set TMDS clock/character rate ratio. Signed-off-by: Shashank Sharma --

[PATCH v3 2/6] drm/edid: check for HF-VSDB block

2017-02-10 Thread Shashank Sharma
From: Thierry Reding This patch implements a small function that finds if a given CEA db is hdmi-forum vendor specific data block or not. V2: Rebase. V3: Added R-B from Jose. Signed-off-by: Thierry Reding Signed-off-by: Shashank Sharma Reviewed-by: Jose Abreu --- drivers/gpu/drm/drm_edid.c

[PATCH v3 5/6] drm/i915: enable scrambling

2017-02-10 Thread Shashank Sharma
from Jani - In comments, function names, use "sink" instead of "monitor", so that the implementation could be close to the language of HDMI spec. Signed-off-by: Shashank Sharma --- drivers/gpu/drm/i915/i915_reg.h | 4 ++ drivers/gpu/drm/i915/intel_ddi.c | 28 +++

[PATCH v3 6/6] drm/i915: allow HDMI 2.0 clock rates

2017-02-10 Thread Shashank Sharma
Geminilake has a native HDMI 2.0 controller, which is capable of driving clocks upto 594Mhz. This patch updates the max tmds clock limit for the same. V2: rebase V3: rebase Cc: Ander Conselvan De Oliveira Signed-off-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ 1 file

[PATCH v4 2/6] drm/edid: check for HF-VSDB block

2017-02-22 Thread Shashank Sharma
From: Thierry Reding This patch implements a small function that finds if a given CEA db is hdmi-forum vendor specific data block or not. V2: Rebase. V3: Added R-B from Jose. V4: Rebase Signed-off-by: Thierry Reding Signed-off-by: Shashank Sharma Reviewed-by: Jose Abreu --- drivers/gpu/drm

[PATCH v4 0/6] HDMI 2.0: Scrambling in DRM layer

2017-02-22 Thread Shashank Sharma
- added signed-off-by:self in first two patches(Jani N) V3: - addressed review comments from Jose and Jani V4: - addressed review comments from Maarten on patch 5, rebase all other patches Shashank Sharma (4): drm/edid: detect SCDC support in HF-VSDB drm: scrambling support in drm layer drm

[PATCH v4 3/6] drm/edid: detect SCDC support in HF-VSDB

2017-02-22 Thread Shashank Sharma
ter set (supported, read request supported) etc in it. Ville: - Change rr -> read_request - Call drm_detect_scrambling function drm_parse_hf_vsdb so that all of HF-VSDB parsing can be kept in same function, in incremental patches. V3: Rebase. V4: Rebase. Signed-off-by: Shashank

[PATCH v4 1/6] drm: Add SCDC helpers

2017-02-22 Thread Shashank Sharma
R-B from Jose. V4: Rebase Signed-off-by: Thierry Reding Signed-off-by: Shashank Sharma Reviewed-by: Jose Abreu --- Documentation/gpu/drm-kms-helpers.rst | 12 drivers/gpu/drm/Makefile | 3 +- drivers/gpu/drm/drm_scdc_helper.c | 111 include

  1   2   3   4   5   >