Re: [PATCH 08/20] drm: set output colorspace in AVI infoframe

2017-07-13 Thread Sharma, Shashank
Regards Shashank On 7/13/2017 6:05 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 10:37:53AM +0530, Sharma, Shashank wrote: Regards Shashank On 7/12/2017 10:47 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:36PM +0530, Shashank Sharma wrote: A source must set output colorspace

Re: [PATCH 16/20] drm: add function to read vendor OUI

2017-07-13 Thread Sharma, Shashank
Regards Shashank On 7/13/2017 6:07 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 10:34:26AM +0530, Sharma, Shashank wrote: Regads Shashank On 7/12/2017 10:45 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:44PM +0530, Shashank Sharma wrote: This patch adds a helper function in

Re: [PATCH 13/20] drm/i915: prepare csc unit for YCBCR420 output

2017-07-13 Thread Sharma, Shashank
Regards Shashank On 7/13/2017 6:20 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 10:44:51AM +0530, Sharma, Shashank wrote: Regards Shashank On 7/12/2017 10:47 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:41PM +0530, Shashank Sharma wrote: To support ycbcr output, we need a

Re: [Intel-gfx] [PATCH 11/20] drm/i915: prepare scaler for YCBCR420 modeset

2017-07-13 Thread Sharma, Shashank
Regards Shashank On 7/13/2017 6:22 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 10:51:04AM +0530, Sharma, Shashank wrote: Regards Shashank On 7/12/2017 10:47 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:39PM +0530, Shashank Sharma wrote: To get a YCBCR420 output from intel

Re: [PATCH 10/20] drm/i915: add config function for YCBCR420 outputs

2017-07-13 Thread Sharma, Shashank
Regards Shashank On 7/13/2017 6:23 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 10:56:06AM +0530, Sharma, Shashank wrote: Regards Shashank On 7/12/2017 10:47 PM, Ville Syrjälä wrote: On Mon, Jul 10, 2017 at 04:48:38PM +0530, Shashank Sharma wrote: This patch checks encoder level

Re: [PATCH 20/20] drm/i915: write AVI infoframes for LSPCON

2017-07-13 Thread Sharma, Shashank
Regards Shashank On 7/13/2017 6:25 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 06:09:53PM +0530, Sharma, Shashank wrote: Regards Shashank On 7/13/2017 5:57 PM, Ville Syrjälä wrote: On Thu, Jul 13, 2017 at 11:11:53AM +0530, Sharma, Shashank wrote: Regards Shashank On 7/12/2017 10

Re: [PATCH 06/20] drm: add helper to validate YCBCR420 modes

2017-07-13 Thread Sharma, Shashank
On 7/13/2017 6:30 PM, Ville Syrjälä wrote: I guess then you just need to add the bitmap already in the validation patch. An alternative would be just squash the patches, but that seems a bit drastic, and probably would mix up too many things in one patch. Ok then, I will introduce this bitmap i

Re: [PATCH 08/20] drm: set output colorspace in AVI infoframe

2017-07-13 Thread Sharma, Shashank
On 7/13/2017 6:33 PM, Ville Syrjälä wrote: If the mode requires pixel repeat to meet the minimum clock requirement, then we can't just not do pixel repeat. That would violate the spec in other ways, and IIRC we couldn't even generate a low enough clock for it. The YCBCR420 modes I am seeing on s

Re: [PATCH 18/20] drm/i915: YCBCR 420 support for LSPCON

2017-07-13 Thread Sharma, Shashank
On 7/13/2017 6:43 PM, Ville Syrjälä wrote: We don't use those clocks with DP. You've just added them here because the function call requires them as parameters. Also the function call is actually doing the wrong thing for DP by halving port_clock. Ah, missed that part. Thanks for letting me kno

Re: [PATCH 20/20] drm/i915: write AVI infoframes for LSPCON

2017-07-13 Thread Sharma, Shashank
On 7/13/2017 6:49 PM, Ville Syrjälä wrote: Yeah something like this perhaps: "We send 4:4:4 data to LSPCON which performs the 4:4:4->4:2:0 downsampling or us, hence we don't need a pipe scaler." Seems good ! Will add this. - Shashank ___ dri-devel m

Re: [PATCH 10/20] drm/i915: add config function for YCBCR420 outputs

2017-07-13 Thread Sharma, Shashank
On 7/13/2017 6:56 PM, Ville Syrjälä wrote: We don't want breaks in the loop. It's meant to go through all the connectors for the crtc. Granted on modern platforms there can only be one, but IMO assuming that just makes the whole thing look confusing. It's much clearer IMO if we do if (420) {

Re: [PATCH v5 4/6] drm/edid: detect SCDC support in HF-VSDB

2017-03-01 Thread Sharma, Shashank
Regards Shashank On 3/1/2017 8:28 PM, Ville Syrjälä wrote: On Tue, Feb 28, 2017 at 02:09:08PM +0530, Shashank Sharma wrote: This patch does following: - Adds a new structure (drm_hdmi_info) in drm_display_info. This structure will be used to save and indicate if sink supports advanced H

Re: [PATCH v5 5/6] drm/i915: enable scrambling

2017-03-01 Thread Sharma, Shashank
Regards Shashank On 3/1/2017 8:41 PM, Ville Syrjälä wrote: On Tue, Feb 28, 2017 at 02:09:09PM +0530, Shashank Sharma wrote: Geminilake platform sports a native HDMI 2.0 controller, and is capable of driving pixel-clocks upto 594Mhz. HDMI 2.0 spec mendates scrambling for these higher clocks, f

Re: [Intel-gfx] [PATCH v6 5/6] drm/i915: enable scrambling

2017-03-03 Thread Sharma, Shashank
Thanks for the review Ander. My comments inline. Shashank On 3/3/2017 3:22 PM, Ander Conselvan De Oliveira wrote: On Fri, 2017-03-03 at 11:59 +0530, Shashank Sharma wrote: Geminilake platform sports a native HDMI 2.0 controller, and is capable of driving pixel-clocks upto 594Mhz. HDMI 2.0 spec

Re: [Intel-gfx] [PATCH v6 5/6] drm/i915: enable scrambling

2017-03-03 Thread Sharma, Shashank
Regards Shashank On 3/3/2017 6:31 PM, Ander Conselvan De Oliveira wrote: On Fri, 2017-03-03 at 17:33 +0530, Sharma, Shashank wrote: Thanks for the review Ander. My comments inline. Shashank On 3/3/2017 3:22 PM, Ander Conselvan De Oliveira wrote: On Fri, 2017-03-03 at 11:59 +0530, Shashank

Re: [PATCH v8 5/6] drm/i915: enable scrambling

2017-03-08 Thread Sharma, Shashank
Regards Shashank On 3/8/2017 7:17 PM, Ville Syrjälä wrote: On Wed, Mar 08, 2017 at 07:07:48PM +0530, Shashank Sharma wrote: Geminilake platform sports a native HDMI 2.0 controller, and is capable of driving pixel-clocks upto 594Mhz. HDMI 2.0 spec mendates scrambling for these higher clo

Re: [PATCH v8 5/6] drm/i915: enable scrambling

2017-03-08 Thread Sharma, Shashank
Regards Shashank On 3/8/2017 7:44 PM, Ville Syrjälä wrote: On Wed, Mar 08, 2017 at 07:26:45PM +0200, Sharma, Shashank wrote: Regards Shashank On 3/8/2017 7:17 PM, Ville Syrjälä wrote: On Wed, Mar 08, 2017 at 07:07:48PM +0530, Shashank Sharma wrote: Geminilake platform sports a native

Re: [PATCH v8 5/6] drm/i915: enable scrambling

2017-03-08 Thread Sharma, Shashank
Regards Shashank On 3/8/2017 7:56 PM, Ville Syrjälä wrote: On Wed, Mar 08, 2017 at 07:50:45PM +0200, Sharma, Shashank wrote: Regards Shashank On 3/8/2017 7:44 PM, Ville Syrjälä wrote: On Wed, Mar 08, 2017 at 07:26:45PM +0200, Sharma, Shashank wrote: Regards Shashank On 3/8/2017 7:17

RE: [PATCH v9] drm/i915: enable scrambling

2017-03-09 Thread Sharma, Shashank
+ intel-gfx + dri-devl (missed in in-reply-to) Regards Shashank -Original Message- From: Sharma, Shashank Sent: Thursday, March 9, 2017 6:02 PM To: ville.syrj...@linux.intel.com; conselv...@gmail.com Cc: Sharma, Shashank Subject: [PATCH v9] drm/i915: enable scrambling Geminilake

Re: DRM Atomic property for color-space conversion

2017-03-16 Thread Sharma, Shashank
Regards Shashank On 3/16/2017 4:07 PM, Ville Syrjälä wrote: On Tue, Jan 31, 2017 at 03:55:41PM +, Brian Starkey wrote: On Tue, Jan 31, 2017 at 05:15:46PM +0200, Ville Syrjälä wrote: On Tue, Jan 31, 2017 at 12:33:29PM +, Brian Starkey wrote: Hi, On Mon, Jan 30, 2017 at 03:35:13PM +0

Re: DRM Atomic property for color-space conversion

2017-03-16 Thread Sharma, Shashank
Regards Shashank On 3/16/2017 4:37 PM, Local user for Liviu Dudau wrote: On Thu, Mar 16, 2017 at 04:30:59PM +0200, Ville Syrjälä wrote: On Thu, Mar 16, 2017 at 04:20:29PM +0200, Sharma, Shashank wrote: Regards Shashank On 3/16/2017 4:07 PM, Ville Syrjälä wrote: On Tue, Jan 31, 2017 at

Re: DRM Atomic property for color-space conversion

2017-03-16 Thread Sharma, Shashank
Regards Shashank On 3/16/2017 5:55 PM, Brian Starkey wrote: Hi, On Thu, Mar 16, 2017 at 05:14:07PM +0200, Sharma Shashank wrote: Regards Shashank On 3/16/2017 4:37 PM, Local user for Liviu Dudau wrote: On Thu, Mar 16, 2017 at 04:30:59PM +0200, Ville Syrjälä wrote: On Thu, Mar 16, 2017

Re: [PATCH] drm/scdc: declare drm_scdc_get_scrambling_status

2017-03-22 Thread Sharma, Shashank
Thanks for this patch, Jani. Reviewed-by: Shashank Sharma Regards Shashank On 3/22/2017 4:33 PM, Jani Nikula wrote: Fix sparse warning: drivers/gpu/drm/drm_scdc_helper.c:138:6: warning: symbol 'drm_scdc_get_scrambling_status' was not declared. Should it be static? Fixes: 62c58af32c93 ("drm/

RE: [RFC 0/5] HDMI 2.0+ video modes handling in DRM core

2017-03-22 Thread Sharma, Shashank
ssage- From: Jose Abreu [mailto:jose.ab...@synopsys.com] Sent: Wednesday, March 22, 2017 8:13 PM To: dri-devel@lists.freedesktop.org Cc: Carlos Palminha ; Vetter, Daniel ; Sharma, Shashank ; ville.syrj...@linux.intel.com Subject: Re: [RFC 0/5] HDMI 2.0+ video modes handling in DRM core ++ D

Re: [RFC 0/5] HDMI 2.0+ video modes handling in DRM core

2017-03-23 Thread Sharma, Shashank
I realized it was too early to search that in dri-devel last night, I guess it takes some time to sync. Now I can see them all :) On 3/23/2017 12:37 PM, Jose Abreu wrote: Hi Shashank, On 22-03-2017 18:57, Sharma, Shashank wrote: Hi Jose, I can't find the other patches of this seri

Re: [RFC 3/5] drm: edid: Add HDMI 2.0 CEA video modes

2017-03-23 Thread Sharma, Shashank
Regards Shashank On 3/23/2017 10:11 AM, Andrzej Hajda wrote: On 22.03.2017 18:35, Jose Abreu wrote: This patch completes CEA table of video modes so that VIC 1-107 are now available. Use the HDMI 2.0+ flag to signal these are modes for HDMI 2.0 onwards. edid_cea_modes array is used in differ

Re: [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

2017-03-23 Thread Sharma, Shashank
Regards Shashank On 3/23/2017 5:17 PM, Ilia Mirkin wrote: On Thu, Mar 23, 2017 at 11:14 AM, Shashank Sharma wrote: HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC 1-64). For any other mode, the VIC filed in AVI infoframes should be 0. HDMI 2.0 sinks, support video modes

Re: [RFC 3/5] drm: edid: Add HDMI 2.0 CEA video modes

2017-03-23 Thread Sharma, Shashank
You guys might wanna use this series, to solve this problem. https://patchwork.freedesktop.org/series/21773/ Patch 1: completes the CEA modes 1-107 Patch 2: Protects HDMI 1.4 monitors from HDMI 2.0 VICs Regards Shashank On 3/23/2017 1:07 PM, Sharma, Shashank wrote: Regards Shashank On 3

Re: [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

2017-03-23 Thread Sharma, Shashank
Regards Shashank On 3/23/2017 5:57 PM, Jose Abreu wrote: Hi Ville, On 23-03-2017 15:45, Ville Syrjälä wrote: On Thu, Mar 23, 2017 at 03:28:29PM +, Jose Abreu wrote: Hi Shashank, On 23-03-2017 15:14, Shashank Sharma wrote: HDMI 1.4b support the CEA video modes as per range of CEA-861

Re: [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

2017-03-23 Thread Sharma, Shashank
Regards Shashank On 3/23/2017 5:52 PM, Jose Abreu wrote: Hi Ville, On 23-03-2017 15:36, Ville Syrjälä wrote: On Thu, Mar 23, 2017 at 05:14:19PM +0200, Shashank Sharma wrote: HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC 1-64). For any other mode, the VIC filed in AVI

Re: [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

2017-03-23 Thread Sharma, Shashank
Regards Shashank On 3/23/2017 5:28 PM, Ilia Mirkin wrote: On Thu, Mar 23, 2017 at 11:22 AM, Sharma, Shashank wrote: On 3/23/2017 5:17 PM, Ilia Mirkin wrote: On Thu, Mar 23, 2017 at 11:14 AM, Shashank Sharma wrote: HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC 1-64

Re: [PATCH v4 2/2] drm: Add HDMI 2.0 VIC support for AVI info-frames

2017-03-23 Thread Sharma, Shashank
Regards Shashank On 3/23/2017 6:33 PM, Jose Abreu wrote: Hi Shashank, On 23-03-2017 16:08, Sharma, Shashank wrote: Regards Shashank On 3/23/2017 5:57 PM, Jose Abreu wrote: Hi Ville, On 23-03-2017 15:45, Ville Syrjälä wrote: On Thu, Mar 23, 2017 at 03:28:29PM +, Jose Abreu wrote

RE: [Intel-gfx] [PATCH v10 3/6] drm/edid: detect SCDC support in HF-VSDB

2017-03-25 Thread Sharma, Shashank
Added description for the variable in this patch: https://patchwork.freedesktop.org/patch/146424/ Regards Shashank -Original Message- From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Friday, March 24, 2017 9:08 PM To: Sharma, Shashank Cc

RE: [Intel-gfx] [PATCH v10 3/6] drm/edid: detect SCDC support in HF-VSDB

2017-03-25 Thread Sharma, Shashank
Please use updated version of the patch [V4]: https://patchwork.freedesktop.org/patch/146426/ (previous one had a merge conflict due to my local patch) Regards Shashank -Original Message- From: Sharma, Shashank Sent: Saturday, March 25, 2017 11:23 AM To: 'Daniel Vetter' C

RE: [PATCH v2] drm: Add description for scdc variable

2017-03-26 Thread Sharma, Shashank
Thanks, V5 will do the trick for sure :-) Regards Shashank -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Saturday, March 25, 2017 11:30 PM To: Sharma, Shashank Cc: dri-devel@lists.freedesktop.org; Daniel Vetter Subject: Re

RE: [PATCH v2] drm: Add description for scdc variable

2017-03-27 Thread Sharma, Shashank
Of Daniel Vetter Sent: Tuesday, March 28, 2017 9:09 AM To: Sharma, Shashank Cc: Daniel Vetter ; dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2] drm: Add description for scdc variable On Sun, Mar 26, 2017 at 08:39:51AM +0000, Sharma, Shashank wrote: > Thanks, V5 will do the trick for sure :

RE: [PATCH v5] drm: Add description for scdc variable

2017-03-28 Thread Sharma, Shashank
V6: https://patchwork.freedesktop.org/patch/146749/ Regards Shashank -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Tuesday, March 28, 2017 9:54 AM To: Sharma, Shashank Cc: dri-devel@lists.freedesktop.org; Daniel Vetter Subject

Re: [PATCH RFC v2 2/2] drm: Add YCBCR_DECODE_CSC and YCBCR_CSC_PREOFFSET properties to drm_plane

2017-05-05 Thread Sharma, Shashank
Regards Shashank On 5/5/2017 12:28 PM, Daniel Vetter wrote: On Thu, May 04, 2017 at 05:51:45PM +0300, Ville Syrjälä wrote: On Thu, May 04, 2017 at 03:22:45PM +0200, Daniel Vetter wrote: On Thu, May 04, 2017 at 10:14:26AM +0300, Jyri Sarha wrote: Add standard optinal property blobs for YCbCr

Re: [PATCH RFC v2 2/2] drm: Add YCBCR_DECODE_CSC and YCBCR_CSC_PREOFFSET properties to drm_plane

2017-05-05 Thread Sharma, Shashank
Regards Shashank On 5/5/2017 12:43 PM, Daniel Vetter wrote: On Fri, May 5, 2017 at 9:06 AM, Sharma, Shashank wrote: On 5/5/2017 12:28 PM, Daniel Vetter wrote: On Thu, May 04, 2017 at 05:51:45PM +0300, Ville Syrjälä wrote: On Thu, May 04, 2017 at 03:22:45PM +0200, Daniel Vetter wrote: On

Re: [PATCH 03/11] drm: parse ycbcr 420 vdb block

2017-05-08 Thread Sharma, Shashank
Regards Shashank On 5/8/2017 9:54 PM, Ville Syrjälä wrote: On Fri, Apr 07, 2017 at 07:39:20PM +0300, Shashank Sharma wrote: From: Jose Abreu HDMI 2.0 spec adds support for ycbcr420 subsampled output. CEA-861-F adds two new blocks in EDID, to provide information about sink's support for ycbc

Re: [PATCH 02/11] drm/edid: Complete CEA modedb(VIC 1-107)

2017-05-08 Thread Sharma, Shashank
Regards Shashank On 5/8/2017 9:52 PM, Ville Syrjälä wrote: On Fri, Apr 07, 2017 at 07:39:19PM +0300, Shashank Sharma wrote: CEA-861-F specs defines new video modes to be used with HDMI 2.0 EDIDs. The VIC range has been extended from 1-64 to 1-107. Our existing CEA modedb contains only 64 mod

Re: [PATCH 04/11] drm: parse ycbcr420 vcb block

2017-05-09 Thread Sharma, Shashank
Regards Shashank On 5/8/2017 10:28 PM, Ville Syrjälä wrote: On Fri, Apr 07, 2017 at 07:39:21PM +0300, Shashank Sharma wrote: HDMI 2.0 spec adds support for ycbcr420 subsampled output. CEA-861-F adds two new blocks in EDID, to provide information about sink's support for ycbcr420 output. One

Re: [PATCH 03/11] drm: parse ycbcr 420 vdb block

2017-05-09 Thread Sharma, Shashank
Regards Shashank On 5/8/2017 10:39 PM, Ville Syrjälä wrote: On Mon, May 08, 2017 at 10:11:53PM +0530, Sharma, Shashank wrote: Regards Shashank On 5/8/2017 9:54 PM, Ville Syrjälä wrote: On Fri, Apr 07, 2017 at 07:39:20PM +0300, Shashank Sharma wrote: From: Jose Abreu HDMI 2.0 spec adds

Re: [PATCH 03/11] drm: parse ycbcr 420 vdb block

2017-05-09 Thread Sharma, Shashank
Regards Shashank On 5/9/2017 8:58 PM, Ville Syrjälä wrote: On Tue, May 09, 2017 at 02:04:55PM +0530, Sharma, Shashank wrote: Regards Shashank On 5/8/2017 10:39 PM, Ville Syrjälä wrote: On Mon, May 08, 2017 at 10:11:53PM +0530, Sharma, Shashank wrote: Regards Shashank On 5/8/2017 9:54

Re: [PATCH v2 02/11] drm/edid: Complete CEA modedb(VIC 1-107)

2017-05-30 Thread Sharma, Shashank
Regards Shashank On 5/30/2017 9:48 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 05:43:41PM +0530, Shashank Sharma wrote: CEA-861-F specs defines new video modes to be used with HDMI 2.0 EDIDs. The VIC range has been extended from 1-64 to 1-107. Our existing CEA modedb contains only 64 mo

Re: [PATCH v2 01/11] drm: Add HDMI 2.0 VIC support for AVI info-frames

2017-05-30 Thread Sharma, Shashank
Regards Shashank On 5/30/2017 9:43 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 05:43:40PM +0530, Shashank Sharma wrote: HDMI 1.4b support the CEA video modes as per range of CEA-861-D (VIC 1-64). For any other mode, the VIC filed in AVI infoframes should be 0. HDMI 2.0 sinks, support vid

Re: [PATCH v2 05/11] drm: create hdmi output property

2017-05-30 Thread Sharma, Shashank
Regards Shashank On 5/30/2017 10:06 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 05:43:44PM +0530, Shashank Sharma wrote: HDMI displays can support various output types, based on the color space and subsampling type. The possible outputs from a HDMI 2.0 monitor could be: - RGB - YCBCR

Re: [PATCH v2 05/11] drm: create hdmi output property

2017-05-31 Thread Sharma, Shashank
Regards Shashank On 5/31/2017 6:16 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 10:18:19PM +0530, Sharma, Shashank wrote: Regards Shashank On 5/30/2017 10:06 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 05:43:44PM +0530, Shashank Sharma wrote: HDMI displays can support various

Re: [PATCH v2 02/11] drm/edid: Complete CEA modedb(VIC 1-107)

2017-05-31 Thread Sharma, Shashank
Regards Shashank On 5/31/2017 6:09 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 09:56:56PM +0530, Sharma, Shashank wrote: Regards Shashank On 5/30/2017 9:48 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 05:43:41PM +0530, Shashank Sharma wrote: CEA-861-F specs defines new video

Re: [PATCH v2 01/11] drm: Add HDMI 2.0 VIC support for AVI info-frames

2017-05-31 Thread Sharma, Shashank
Regards Shashank On 5/31/2017 6:11 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 10:00:12PM +0530, Sharma, Shashank wrote: Regards Shashank On 5/30/2017 9:43 PM, Ville Syrjälä wrote: On Tue, May 30, 2017 at 05:43:40PM +0530, Shashank Sharma wrote: HDMI 1.4b support the CEA video

[RFC] drm: Parse HDMI 2.0 YCbCr 4:2:0 VDB and VCB

2017-01-09 Thread Sharma, Shashank
Regards Shashank On 12/30/2016 10:23 PM, Jose Abreu wrote: > HDMI 2.0 introduces a new sampling mode called YCbCr 4:2:0. > According to the spec the EDID may contain two blocks that > signal this sampling mode: > - YCbCr 4:2:0 Video Data Block > - YCbCr 4:2:0 Video Capability Map Dat

[RFC] drm: Parse HDMI 2.0 YCbCr 4:2:0 VDB and VCB

2017-01-09 Thread Sharma, Shashank
Regards Shashank On 1/9/2017 4:41 PM, Jose Abreu wrote: > Hi Shashank, > > > Thanks for the review. > > > On 09-01-2017 05:22, Sharma, Shashank wrote: >> Regards >> >> Shashank >> >> >> On 12/30/2016 10:23 PM, Jose Abreu wrote: >&

[RFC] drm: Parse HDMI 2.0 YCbCr 4:2:0 VDB and VCB

2017-01-09 Thread Sharma, Shashank
Regards Shashank On 1/9/2017 6:53 PM, Jose Abreu wrote: > Hi Shashank, > > > On 09-01-2017 12:45, Sharma, Shashank wrote: >> Regards >> >> Shashank >> >> >> On 1/9/2017 4:41 PM, Jose Abreu wrote: >>> Hi Shashank, >>> >

[PATCH v2 1/4] drm: Add helper for DP++ adaptors

2016-05-03 Thread Sharma, Shashank
On 5/3/2016 12:38 AM, ville.syrjala at linux.intel.com wrote: > From: Ville Syrjälä > > Add a helper which aids in the identification of DP dual mode > (aka. DP++) adaptors. There are several types of adaptors > specified: type 1 DVI, type 1 HDMI, type 2 DVI, type 2 HDMI > > Type 1 adaptors ha

[PATCH v2 2/4] drm/i915: Respect DP++ adaptor TMDS clock limit

2016-05-04 Thread Sharma, Shashank
Reviewed-by: Shashank Sharma Regards Shashank On 5/3/2016 12:38 AM, ville.syrjala at linux.intel.com wrote: > From: Ville Syrjälä > > Try to detect the max TMDS clock limit for the DP++ adaptor (if any) > and take it into account when checking the port clock. > > Note that as with the sink (HD

[PATCH v3 3/4] drm/i915: Enable/disable TMDS output buffers in DP++ adaptor as needed

2016-05-04 Thread Sharma, Shashank
On 5/3/2016 12:38 AM, ville.syrjala at linux.intel.com wrote: > From: Ville Syrjälä > > To save a bit of power, let's try to turn off the TMDS output buffers > in DP++ adaptors when we're not driving the port. > > v2: Let's not forget DDI, toss in a debug message while at it > v3: Just do the T

[PATCH v2 4/4] drm/i915: Determine DP++ type 1 DVI adaptor presence based on VBT

2016-05-04 Thread Sharma, Shashank
On 5/3/2016 12:38 AM, ville.syrjala at linux.intel.com wrote: > From: Ville Syrjälä > > DP dual mode type 1 DVI adaptors aren't required to implement any > registers, so it's a bit hard to detect them. The best way would > be to check the state of the CONFIG1 pin, but we have no way to > do th

[PATCH v3 3/4] drm/i915: Enable/disable TMDS output buffers in DP++ adaptor as needed

2016-05-04 Thread Sharma, Shashank
On 5/4/2016 5:19 PM, Ville Syrjälä wrote: > On Wed, May 04, 2016 at 03:43:30PM +0530, Sharma, Shashank wrote: >> >> On 5/3/2016 12:38 AM, ville.syrjala at linux.intel.com wrote: >>> From: Ville Syrjälä >>> >>> To save a bit of power, let's tr

[PATCH v3 4/4] drm/i915: Determine DP++ type 1 DVI adaptor presence based on VBT

2016-05-04 Thread Sharma, Shashank
Reviewed-by: Shashank Sharma Regards Shashank On 5/4/2016 5:15 PM, ville.syrjala at linux.intel.com wrote: > From: Ville Syrjälä > > DP dual mode type 1 DVI adaptors aren't required to implement any > registers, so it's a bit hard to detect them. The best way would > be to check the state of t

[REGRESSION] i915: No HDMI output with 4.4

2016-02-24 Thread Sharma, Shashank
: Tuesday, February 23, 2016 8:38 PM To: Oleksandr Natalenko Cc: Vetter, Daniel; intel-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org; linux-kernel at vger.kernel.org; Daniel Vetter; Jindal, Sonika; Sharma, Shashank; Wang, Gary C Subject: Re: [REGRESSION] i915: No HDMI output with

[REGRESSION] i915: No HDMI output with 4.4

2016-02-29 Thread Sharma, Shashank
Please see the latest mail chain, Sonika has already started on it. Regards Shashank -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Monday, February 29, 2016 8:44 PM To: Sharma, Shashank Cc: Ville Syrjälä; Oleksandr Natalenko

[REGRESSION] i915: No HDMI output with 4.4

2016-02-29 Thread Sharma, Shashank
No problems, I guessed the mail situation :) Regards Shashank -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Monday, February 29, 2016 9:12 PM To: Sharma, Shashank Cc: Daniel Vetter; Ville Syrjälä; Oleksandr Natalenko; Vetter

[Intel-gfx] Design review request: DRM color manager

2014-05-15 Thread Sharma, Shashank
Intel platform may not be valid for other. So the atomic modeset should have a clear idea of what is supported on which platforms. Thanks for your time and review. Regards Shashank On 5/14/2014 9:24 PM, Thierry Reding wrote: > On Tue, May 13, 2014 at 09:18:45AM +0530, Sharma, Shashank wrote: &

[Intel-gfx] Design review request: DRM color manager

2014-05-15 Thread Sharma, Shashank
Sounds good to me. Regards Shashank -Original Message- From: Thierry Reding [mailto:thierry.red...@gmail.com] Sent: Thursday, May 15, 2014 12:36 PM To: Sharma, Shashank Cc: Daniel Vetter; intel-gfx; dri-devel; Purushothaman, Vijay A; Mukherjee, Indranil; Shankar, Uma; Jindal, Sonika

[PATCH v2 2/3] drm/edid: Implement SCDC support detection

2016-12-03 Thread Sharma, Shashank
, December 3, 2016 12:54 AM To: dri-devel at lists.freedesktop.org Cc: Jani Nikula ; Sharma, Shashank ; Ville Syrjälä ; Jose Abreu Subject: [PATCH v2 2/3] drm/edid: Implement SCDC support detection From: Thierry Reding Sinks compliant with the HDMI 2.0 specification may support SCDC, a

[PATCH v2 2/3] drm/edid: Implement SCDC support detection

2016-12-19 Thread Sharma, Shashank
h] On Behalf Of Daniel Vetter Sent: Tuesday, December 6, 2016 1:49 PM To: Thierry Reding Cc: Daniel Vetter ; Sharma, Shashank ; Jose Abreu ; dri-devel at lists.freedesktop.org Subject: Re: [PATCH v2 2/3] drm/edid: Implement SCDC support detection On Mon, Dec 05, 2016 at 06:11:44PM +0100, Thierry R

[PATCH v2 1/3] drm: Add SCDC helpers

2016-12-19 Thread Sharma, Shashank
- dri-devel at lists.kernel.org + dri-devel at lists.freedesktop.org Regards Shashank -Original Message- From: Sharma, Shashank [mailto:shashank.sha...@intel.com] Sent: Monday, December 19, 2016 7:00 PM To: Thierry Reding ; dri-devel at lists.kernel.org Cc: Jani Nikula ; Ville SyrjälÃ

[PATCH] drm: parse hf-vsdb

2016-12-19 Thread Sharma, Shashank
Thanks for the review, Thierry. My comments inline. Regards Shashank On 12/5/2016 10:29 PM, Thierry Reding wrote: > On Tue, Nov 29, 2016 at 08:24:39PM +0530, Shashank Sharma wrote: >> HDMI 2.0 / CEA-861-F specs define a new CEA extension data block, >> called hdmi-forum vendor specific data blo

[PATCH 03/18] drm/i915: Add atomic get property interface for CRTC

2015-08-22 Thread Sharma, Shashank
Thanks for the review Matt. Regards Shashank On 8/22/2015 4:10 AM, Matt Roper wrote: > On Thu, Aug 06, 2015 at 10:08:12PM +0530, Shashank Sharma wrote: >> From: Kausal Malladi >> >> This patch adds atomic get property interface for Intel CRTC. This >> interface will be used for get operation on a

[PATCH 05/18] drm/i915: Initialize color manager and add gamma correction

2015-08-22 Thread Sharma, Shashank
Regards Shashank On 8/22/2015 4:10 AM, Matt Roper wrote: > On Thu, Aug 06, 2015 at 10:08:14PM +0530, Shashank Sharma wrote: >> From: Kausal Malladi >> >> As per Color Manager design, each driver is responsible to load its >> palette color correction and enhancement capabilities in the form of >>

[PATCH 06/18] drm: Add color correction blobs in CRTC state

2015-08-22 Thread Sharma, Shashank
Regards Shashank On 8/22/2015 4:10 AM, Matt Roper wrote: > On Thu, Aug 06, 2015 at 10:08:15PM +0530, Shashank Sharma wrote: >> From: Kausal Malladi >> >> This patch adds new variables in CRTC state, to hold respective color >> correction blobs. These blobs will be required during the atomic commi

[PATCH 08/18] drm/i915: Add pipe gamma correction handlers

2015-08-22 Thread Sharma, Shashank
Regards Shashank On 8/22/2015 4:10 AM, Matt Roper wrote: > On Thu, Aug 06, 2015 at 10:08:17PM +0530, Shashank Sharma wrote: >> From: Kausal Malladi >> >> I915 driver registers gamma correction as palette correction >> property with DRM layer. This patch adds set_property() and get_property() >> h

[PATCH 09/18] drm/i915: Pipe level Gamma correction for CHV/BSW

2015-08-22 Thread Sharma, Shashank
Regards Shashank On 8/22/2015 4:11 AM, Matt Roper wrote: > On Thu, Aug 06, 2015 at 10:08:18PM +0530, Shashank Sharma wrote: >> From: Kausal Malladi >> >> CHV/BSW platform supports two different pipe level gamma >> correction modes, which are: >> 1. Legacy 8-bit mode >> 2. 10-bit CGM (Color Gamut

[PATCH 15/18] drm/i915: Initialize Gen8 pipe gamma correction

2015-08-22 Thread Sharma, Shashank
Regards Shashank On 8/22/2015 4:11 AM, Matt Roper wrote: > On Thu, Aug 06, 2015 at 10:08:24PM +0530, Shashank Sharma wrote: >> From: Kausal Malladi >> >> This patch initializes gamma color correction proeprty > >

[PATCH v2 1/2] drm: Create new structure for HDMI info

2016-12-21 Thread Sharma, Shashank
Thanks for the review Jose. My comments, inline. Regards Shashank On 12/20/2016 7:49 PM, Jose Abreu wrote: > Hi Shashank, > > > On 20-12-2016 13:47, Shashank Sharma wrote: >> This patch creates a new structure drm_hdmi_info (inspired from >> drm_display_info). Driver will parse HDMI sink's advanc

[PATCH v2 2/2] drm: parse hf-vsdb

2016-12-21 Thread Sharma, Shashank
Regards Shashank On 12/20/2016 8:05 PM, Jose Abreu wrote: > Hi Shashank, > > > On 20-12-2016 13:47, Shashank Sharma wrote: >> HDMI 2.0 / CEA-861-F specs define a new CEA extension data block, >> called hdmi-forum vendor specific data block (HF-VSDB). This block >> contains information about sink

[PATCH v2 1/2] drm: Create new structure for HDMI info

2016-12-21 Thread Sharma, Shashank
Regards Shashank On 12/21/2016 3:02 PM, Jose Abreu wrote: > Hi Shashank, > > > On 21-12-2016 03:49, Sharma, Shashank wrote: >> Thanks for the review Jose. >> >> My comments, inline. >> >> Regards >> Shashank >> On 12/20/2016 7:49 PM, Jose A

[Intel-gfx] [PATCH v3 1/3] drm: Create new structure for HDMI info

2016-12-23 Thread Sharma, Shashank
Regards Shashank On 12/22/2016 5:26 PM, Ville Syrjälä wrote: > On Thu, Dec 22, 2016 at 10:02:26AM +, Jose Abreu wrote: >> Hi Shashank, >> >> >> On 21-12-2016 15:29, Shashank Sharma wrote: >> >> [snip] >> >>> + >>> + /** >>> +* @edid_yuv420_dc_modes: bpc for deep color yuv420 encoding

[Intel-gfx] [PATCH v3 3/3] drm: clean cached display info

2016-12-29 Thread Sharma, Shashank
Regards Shashank On 12/27/2016 3:07 PM, Daniel Vetter wrote: > On Thu, Dec 22, 2016 at 10:21:25AM +, Jose Abreu wrote: >> Hi Shashank, >> >> >> On 21-12-2016 15:29, Shashank Sharma wrote: >>> This patch adds a small helper function, which clears the cached >>> information about a hot-pluggab

[Intel-gfx] [PATCH v3 3/3] drm: clean cached display info

2016-12-29 Thread Sharma, Shashank
Regards Shashank On 12/29/2016 3:35 PM, Jose Abreu wrote: > Hi Shashank, > > > On 29-12-2016 05:53, Sharma, Shashank wrote: >> Regards >> >> Shashank >> >> >> On 12/27/2016 3:07 PM, Daniel Vetter wrote: >>> On Thu, Dec 22, 201

[PATCH] drm: clean cached display info

2016-12-29 Thread Sharma, Shashank
Thanks for the review, Jose. Regards Shashank -Original Message- From: Jose Abreu [mailto:jose.ab...@synopsys.com] Sent: Thursday, December 29, 2016 11:05 PM To: Sharma, Shashank ; dri-devel at lists.freedesktop.org; intel-gfx at lists.freedesktop.org Cc: Jose Abreu ; Daniel Vetter

PROBLEM: Intel HDMI output busticated on 4.4 (regression)

2016-02-09 Thread Sharma, Shashank
? Regards Shashank -Original Message- From: Nick Bowler [mailto:nbow...@draconx.ca] Sent: Tuesday, February 09, 2016 10:03 PM To: Jindal, Sonika Cc: linux-kernel at vger.kernel.org; dri-devel at lists.freedesktop.org; Daniel Vetter; Sharma, Shashank Subject: Re: PROBLEM: Intel HDMI output

PROBLEM: Intel HDMI output busticated on 4.4 (regression)

2016-02-10 Thread Sharma, Shashank
I checked locally in BDC, Seems we don't have these boards available with us (in working state). Regards Shashank -Original Message- From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] Sent: Tuesday, February 09, 2016 11:53 PM To: Sharma, Shashank Cc: Nick Bowler; D

[PATCH 04/23] drm: Add drm structures for palette color property

2015-09-22 Thread Sharma, Shashank
Regards Shashank On 9/21/2015 10:16 PM, Ville Syrjälä wrote: > On Wed, Sep 16, 2015 at 11:07:01PM +0530, Shashank Sharma wrote: >> From: Kausal Malladi >> >> This patch adds new structures in DRM layer for Palette color >> correction.These structures will be used by user space agents >> to conf

[PATCH 02/23] drm: Add structure for querying palette color capabilities

2015-09-23 Thread Sharma, Shashank
Hi Matt, Daniel Addressing the review comments from both of you here. Regards Shashank On 9/22/2015 6:32 PM, Daniel Vetter wrote: > On Wed, Sep 16, 2015 at 10:51:31AM -0700, Matt Roper wrote: >> On Wed, Sep 16, 2015 at 11:06:59PM +0530, Shashank Sharma wrote: >>> From: Kausal Malladi >>> >>> The

[PATCH 04/23] drm: Add drm structures for palette color property

2015-09-23 Thread Sharma, Shashank
Regards Shashank On 9/22/2015 6:38 PM, Daniel Vetter wrote: > On Wed, Sep 16, 2015 at 11:07:01PM +0530, Shashank Sharma wrote: >> From: Kausal Malladi >> >> This patch adds new structures in DRM layer for Palette color >> correction.These structures will be used by user space agents >> to configu

[Intel-gfx] [PATCH 05/23] drm: Add structure to set/get a CTM color property

2015-09-23 Thread Sharma, Shashank
Regards Shashank On 9/22/2015 6:38 PM, Daniel Vetter wrote: > On Wed, Sep 16, 2015 at 11:07:02PM +0530, Shashank Sharma wrote: >> From: Kausal Malladi >> >> Color Manager framework defines a color correction property for color >> space transformation and Gamut mapping. This property is called CTM

[Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers

2015-09-23 Thread Sharma, Shashank
Regards Shashank On 9/22/2015 6:45 PM, Daniel Vetter wrote: > On Wed, Sep 16, 2015 at 11:07:07PM +0530, Shashank Sharma wrote: >> I915 driver registers gamma correction as palette correction >> property with DRM layer. This patch adds set_property() and get_property() >> handlers for pipe level ga

[Intel-gfx] [PATCH 09/23] drm/i915: Register pipe color capabilities

2015-09-23 Thread Sharma, Shashank
Regards Shashank On 9/22/2015 6:54 PM, Daniel Vetter wrote: > On Wed, Sep 16, 2015 at 11:07:06PM +0530, Shashank Sharma wrote: >> DRM color manager contains these color properties: >> >> 1. "crtc_palette_capabilities_property": to allow a >> core driver to load and showcase its color correction >>

[Intel-gfx] [PATCH 00/23] Color Management for DRM

2015-09-23 Thread Sharma, Shashank
Regards Shashank On 9/22/2015 6:57 PM, Daniel Vetter wrote: > On Wed, Sep 16, 2015 at 11:06:57PM +0530, Shashank Sharma wrote: >> This patch set adds Color Manager implementation in DRM layer. Color Manager >> is an extension in DRM framework to support color correction/enhancement. >> >> Various

[PATCH 01/23] drm: Create Color Management DRM properties

2015-09-23 Thread Sharma, Shashank
Sure Matt, We are planning to add documentation for color properties, as suggested by you and Daniel. Regards Shashank -Original Message- From: Roper, Matthew D Sent: Wednesday, September 16, 2015 11:21 PM To: Sharma, Shashank Cc: Bish, Jim; Bradford, Robert; Smith, Gary K; dri-devel

[PATCH 02/23] drm: Add structure for querying palette color capabilities

2015-09-23 Thread Sharma, Shashank
Sent: Wednesday, September 23, 2015 3:17 PM To: Sharma, Shashank; Daniel Vetter; Roper, Matthew D Cc: Matheson, Annie J; Bradford, Robert; Palleti, Avinash Reddy; intel-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org; Mukherjee, Indranil; Bish, Jim; kausalmalladi at gmail.com; Vetter

[PATCH 04/23] drm: Add drm structures for palette color property

2015-09-23 Thread Sharma, Shashank
Regards Shashank On 9/23/2015 6:19 PM, Daniel Vetter wrote: > On Wed, Sep 23, 2015 at 01:45:16PM +0530, Sharma, Shashank wrote: >> Regards >> Shashank >> >> On 9/22/2015 6:38 PM, Daniel Vetter wrote: >>> On Wed, Sep 16, 2015 at 11:07:01PM +0530, Shashank Sha

[Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers

2015-09-26 Thread Sharma, Shashank
On 9/23/2015 1:52 PM, Sharma, Shashank wrote: >> Since color manager properties are meant as a new standardize KMS >> extension (we put them into the core drm_crtc_state) the get/set support >> should also be in the core. See e.g. how the rotation property is handled >>

[Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers

2015-09-28 Thread Sharma, Shashank
Matt, your opinion about this ? Regards Shashank -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter Sent: Monday, September 28, 2015 12:14 PM To: Sharma, Shashank Cc: Daniel Vetter; Roper, Matthew D; Bish, Jim; Bradford, Robert; Smith, Gary

[Intel-gfx] [PATCH 10/23] drm/i915: Add gamma correction handlers

2015-09-29 Thread Sharma, Shashank
Ok, anyways it was sounding like a good idea. Will do the changes accordingly. Regards Shashank -Original Message- From: Roper, Matthew D Sent: Tuesday, September 29, 2015 3:13 AM To: Sharma, Shashank Cc: Daniel Vetter; Bish, Jim; Bradford, Robert; Smith, Gary K; dri-devel at

[PATCH 21/23] drm/i915: BDW: Pipe level Gamma correction

2015-09-30 Thread Sharma, Shashank
Hey Rob, Thanks for the feedback, and the testing efforts. I will check into your suggestions and get back. Regards Shashank -Original Message- From: Bradford, Robert Sent: Wednesday, September 30, 2015 8:02 PM To: Sharma, Shashank; Roper, Matthew D; Bish, Jim; Smith, Gary K; dri

[PATCH 21/23] drm/i915: BDW: Pipe level Gamma correction

2015-09-30 Thread Sharma, Shashank
Hi Annie, This might add a day or two, but considering this is a long weekend in India, you can expect the patches by mid next week. Regards Shashank -Original Message- From: Matheson, Annie J Sent: Wednesday, September 30, 2015 10:01 PM To: Sharma, Shashank Cc: Bradford, Robert

[Intel-gfx] [PATCH 5/5] drm/i915: Add support for new aspect ratios

2016-04-22 Thread Sharma, Shashank
Thanks for the review Daniel. My comments inline. Regards Shashank On 4/21/2016 8:34 PM, Daniel Vetter wrote: > On Fri, Mar 25, 2016 at 01:47:35PM +0530, Shashank Sharma wrote: >> HDMI 2.0/CEA-861-F introduces two new aspect ratios: >> - 64:27 >> - 256:135 >> >> This patch adds support for these a

Re: [PATCH] drm/edid: VSDB yCBCr420 Deep Color mode bit definitions

2018-10-15 Thread Sharma, Shashank
sing of those before this block, keeping |= required. But we can always do other way around, or will take care of it when we add code for it. Just cross checked with the spec too, Reviewed-by: Shashank Sharma - Shashank PS. It'll be useful to repost this Cc: intel-gfx just to get the CI as

<    1   2   3   4   5   >