Re: [PATCH 0/4] Track exported dma-buffers with memcg

2023-01-11 Thread Shakeel Butt
On Wed, Jan 11, 2023 at 11:56:45PM +0100, Daniel Vetter wrote: > [...] > I think eventually, at least for other "account gpu stuff in cgroups" use > case we do want to actually charge the memory. > > The problem is a bit that with gpu allocations reclaim is essentially "we > pass the error to use

Re: [PATCH 0/4] Track exported dma-buffers with memcg

2023-01-12 Thread Shakeel Butt
On Wed, Jan 11, 2023 at 04:49:36PM -0800, T.J. Mercier wrote: > [...] > > The problem is a bit that with gpu allocations reclaim is essentially "we > > pass the error to userspace and they get to sort the mess out". There are > > some exceptions (some gpu drivers to have shrinkers) would we need t

Re: [PATCH v2 1/4] memcg: Track exported dma-buffers

2023-01-24 Thread Shakeel Butt
On Tue, Jan 24, 2023 at 03:59:58PM +0100, Michal Hocko wrote: > On Mon 23-01-23 19:17:23, T.J. Mercier wrote: > > When a buffer is exported to userspace, use memcg to attribute the > > buffer to the allocating cgroup until all buffer references are > > released. > > Is there any reason why this me

Re: [PATCH 0/4] Track exported dma-buffers with memcg

2023-01-09 Thread Shakeel Butt
Hi T.J., On Mon, Jan 9, 2023 at 1:38 PM T.J. Mercier wrote: > > Based on discussions at LPC, this series adds a memory.stat counter for > exported dmabufs. This counter allows us to continue tracking > system-wide total exported buffer sizes which there is no longer any > way to get without DMABU

Re: [RFC PATCH 1/6] mm/page_counter: Move calculating protection values to page_counter

2024-06-27 Thread Shakeel Butt
ent to the series. Acked-by: Shakeel Butt

Re: [net-next v1 00/16] Device Memory TCP

2023-12-09 Thread Shakeel Butt
On Thu, Dec 07, 2023 at 04:52:31PM -0800, Mina Almasry wrote: [...] > > Today, the majority of the Device-to-Device data transfers the network are 'the network' in above can be removed. > implemented as the following low level operations: Device-to-Host copy, > Host-to-Host network transfer, and

Re: [net-next v1 01/16] net: page_pool: factor out releasing DMA from releasing the page

2023-12-09 Thread Shakeel Butt
> Signed-off-by: Mina Almasry > Reviewed-by: Shakeel Butt

Re: [PATCHv3 02/11] drm/i915/gem: Convert __shmem_writeback() to folios

2025-01-31 Thread Shakeel Butt
On Thu, Jan 30, 2025 at 12:00:40PM +0200, Kirill A. Shutemov wrote: > Use folios instead of pages. > > This is preparation for removing PG_reclaim. > > Signed-off-by: Kirill A. Shutemov > Acked-by: David Hildenbrand > --- > drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 18 +- > 1

Re: [PATCHv3 06/11] mm/vmscan: Use PG_dropbehind instead of PG_reclaim

2025-01-31 Thread Shakeel Butt
On Thu, Jan 30, 2025 at 12:00:44PM +0200, Kirill A. Shutemov wrote: > The recently introduced PG_dropbehind allows for freeing folios > immediately after writeback. Unlike PG_reclaim, it does not need vmscan > to be involved to get the folio freed. > > Instead of using folio_set_reclaim(), use fol

Re: [rfc] drm/ttm/memcg: simplest initial memcg/ttm integration (v2)

2025-05-05 Thread Shakeel Butt
On Fri, May 02, 2025 at 01:35:59PM +1000, Dave Airlie wrote: > Hey all, > > This is my second attempt at adding the initial simple memcg/ttm > integration. > > This varies from the first attempt in two major ways: > > 1. Instead of using __GFP_ACCOUNT and direct calling kmem charges > for pool m

Re: [PATCH 1/2] mm: add gpu active/reclaim per-node stat counters

2025-06-18 Thread Shakeel Butt
On Wed, Jun 18, 2025 at 02:06:17PM +1000, Dave Airlie wrote: > From: Dave Airlie > > While discussing memcg intergration with gpu memory allocations, > it was pointed out that there was no numa/system counters for > GPU memory allocations. > > With more integrated memory GPU server systems turni

Re: [PATCH 1/2] mm: add gpu active/reclaim per-node stat counters (v2)

2025-06-20 Thread Shakeel Butt
at is stored in GPU page pools that can be reclaimed, > by the shrinker. > > Cc: Christian Koenig > Cc: Matthew Brost > Cc: Johannes Weiner > Cc: linux...@kvack.org > Cc: Andrew Morton > Signed-off-by: Dave Airlie With Zi's suggestion, you can add: Acked-by: Shakeel Butt

Re: [PATCH 17/17] amdgpu: add support for memory cgroups

2025-07-03 Thread Shakeel Butt
On Thu, Jul 03, 2025 at 08:15:09PM +0200, Christian König wrote: > On 03.07.25 19:58, Shakeel Butt wrote: > > On Thu, Jul 03, 2025 at 12:53:44PM +1000, David Airlie wrote: > >> On Thu, Jul 3, 2025 at 2:03 AM Shakeel Butt wrote: > >>> > >>> On Mon, Jun

Re: [PATCH 17/17] amdgpu: add support for memory cgroups

2025-07-03 Thread Shakeel Butt
On Thu, Jul 03, 2025 at 12:53:44PM +1000, David Airlie wrote: > On Thu, Jul 3, 2025 at 2:03 AM Shakeel Butt wrote: > > > > On Mon, Jun 30, 2025 at 02:49:36PM +1000, Dave Airlie wrote: > > > From: Dave Airlie > > > > > > This adds support for adding

Re: [PATCH 13/17] ttm/pool: enable memcg tracking and shrinker.

2025-07-02 Thread Shakeel Butt
On Mon, Jun 30, 2025 at 02:49:32PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This enables all the backend code to use the list lru in memcg mode, > and set the shrinker to be memcg aware. > > It adds the loop case for when pooled pages end up being reparented > to a higher memcg group, t

Re: [PATCH 08/17] memcg: add support for GPU page counters.

2025-07-02 Thread Shakeel Butt
On Mon, Jun 30, 2025 at 02:49:27PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This introduces 2 new statistics and 3 new memcontrol APIs for dealing > with GPU system memory allocations. > > The stats corresponds to the same stats in the global vmstat, > for number of active GPU pages, an

Re: [PATCH 02/17] drm/ttm: use gpu mm stats to track gpu memory allocations. (v2)

2025-07-02 Thread Shakeel Butt
On Mon, Jun 30, 2025 at 02:49:21PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This uses the newly introduced per-node gpu tracking stats, > to track GPU memory allocated via TTM and reclaimable memory in > the TTM page pools. > > These stats will be useful later for system information and

Re: [PATCH 17/17] amdgpu: add support for memory cgroups

2025-07-02 Thread Shakeel Butt
On Mon, Jun 30, 2025 at 02:49:36PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This adds support for adding a obj cgroup to a buffer object, > and passing in the placement flags to make sure it's accounted > properly. > > Signed-off-by: Dave Airlie > --- > drivers/gpu/drm/amd/amdgpu/amdg

Re: [PATCH 02/18] drm/ttm: use gpu mm stats to track gpu memory allocations. (v3)

2025-07-14 Thread Shakeel Butt
On Mon, Jul 14, 2025 at 03:18:17PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This uses the newly introduced per-node gpu tracking stats, > to track GPU memory allocated via TTM and reclaimable memory in > the TTM page pools. > > These stats will be useful later for system information and

Re: [PATCH 03/18] mm/list_lru: export list_lru_add.

2025-07-14 Thread Shakeel Butt
Tue Nov 5 01:52:53 2024 +0800 > > mm/list_lru: don't export list_lru_add > > Cc: Kairui Song > Cc: Johannes Weiner > Cc: Shakeel Butt > Signed-off-by: Dave Airlie Instead of a separate patch, please put it in the patch which actually uses list_lru_add.