From: YoungJun Cho
When drm iommu is not supported, buf->pages has to be allocated
and assigned to phys_to_page() result, which type is struct page *.
So it is sufficient to allocate buf->pages with multiple struct
page pointer size.
Signed-off-by: YoungJun Cho
Signed-off-by: Kyungmin Park
---
Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
change from v1:
- adds precedence patch to fix allocation of array as Ville and Inki commented
drivers/gpu/drm/exynos/exynos_drm_buf.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_bu
From: YoungJun Cho
If the type of object is pointer array, the drm_calloc_large() is
more suitable than kzalloc() for its allocation function. And uses
drm_free_large() instead of kfree() also.
Signed-off-by: YoungJun Cho
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers
There were duplicated error handling routines during allocating
pages in lowlevel_buffer_allocate() and g2d_userptr_get_dma_addr().
Also unnecessary NULL assignments for variable used not any more
are removed from g2d_userptr_get_dma_addr() and
g2d_userptr_put_dma_addr().
Signed-off-by: Seung-Woo
NV12, NV12M and NV12MT are added to format list of plane to use these
formats for hdmi vp layer.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_plane.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff
://www.spinics.net/lists/dri-devel/msg21739.html
http://www.spinics.net/lists/dri-devel/msg21746.html
http://www.spinics.net/lists/dri-devel/msg21734.html
Seung-Woo Kim (5):
drm/exynos: fixed wrong pageflip finish event for interlace mode
drm/exynos: enable dvi mode for dvi monitor
Hdmi monitor and dvi monitor can be distinguished with edid.
This patch enables dvi mode if dvi monitor is connected and does
not enable audio feature for dvi mode because dvi has no audio
feature.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos
Pageflip finish event for interlace mode has bug on checking top
field vsync because of comparing between dma address converted
by start coordinates and non-converted dma address.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_mixer.c | 12
1080p at 30Hz mode is added to hdmi display mode.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 65 ++
1 files changed, 65 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
This patch adds vp scaling feature for exynos hdmi. Scaling ratio
between source and destination is used for width and height.
Also meaningless variables to set registers are cleaned.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_mixer.c | 88
Set plane has source size but exynos overlay structure did
not consider it. This patch adds source size to overlay
structure. For set crtc, source size is set from crtc size.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_crtc.c |4
This patch fixes flags passed to dma buf exporting.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin.park
---
I found exynos drm also sends wrong flag for dma buf exporting. So I send this
based on drm-fixes branch.
drivers/gpu/drm/exynos/exynos_drm_dmabuf.c |2 +-
1 files changed, 1
This patch fixes flags passed to dma buf exporting.
Signed-off-by: Seung-Woo Kim
Cc: Rob Clark
---
I found omap drm also sends wrong flag for dma buf exporting. So I send this
based on drm-fixes branch.
drivers/staging/omapdrm/omap_gem_dmabuf.c |2 +-
1 files changed, 1 insertions(+), 1
exynos_drm_display to exynos_drm_display_ops
Joonyoung Shim (1):
drm/exynos: restored kernel_fb_list when reiniting fb_helper
Seung-Woo Kim (6):
drm/exynos: added kms poll for handling hpd event
drm/exynos: fixed connector flag with hpd and interlace scan for hdmi
drm/exynos: fixed converting
missing members are added into converting function between timing and display
mode and refresh rate of display mode is calculated by drm mode function.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_connector.c |9 -
1 files changed
From: Inki Dae
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
include/drm/exynos_drm.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/drm/exynos_drm.h b/include/drm/exynos_drm.h
index 874c4d2..1d161cb 100644
--- a/include/drm/exynos_drm.h
+++ b/incl
From: Joonyoung Shim
during recreating exynos_drm_fbdev as a new display device probes,
fb_helper is reinitialized but kernel fb is not changed
so kernel_fb_list should be restored after fb_helper is reinitialized.
Signed-off-by: Joonyoung Shim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm
hdmi display in exynos supports hotplug event and interlace scan mode
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_connector.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/exynos
crtc dpms is called as destroying attached fb so dpms off sould be processed.
crtc dpms also can be called after crtc is detached from encoder so pipe value
of manager is used to find display controller for this case
Signed-off-by: Seung-Woo Kim
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin
From: Inki Dae
connector contains some contents for display controller so the connector also
should be able to access contoroller through manager.
Signed-off-by: Inki Dae
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_connector.c | 38
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_encoder.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c
b/drivers/gpu/drm/exynos/exynos_drm_encoder.c
index 4092f41
From: Inki Dae
exynos_drm_display has function pointes so exynos_drm_display_ops is better
to describe.
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_connector.c | 29 +
drivers/gpu/drm/exynos/exynos_drm_drv.h |4
drm_framebuffer already has width and height so they are meaningless as
parameters when updating fb_info.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 14 +-
1 files changed, 5 insertions(+), 9 deletions(-)
diff --git
this patch adds kms poll infrastructure to handle hotplug detection event
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_drv.c |5 +
drivers/gpu/drm/exynos/exynos_drm_fb.c | 12
2 files changed, 17 insertions(+), 0
ould be pleased you to give us any comments.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Inki Dae
Signed-off-by: Joonyoung Shim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/Kconfig |7 +
drivers/gpu/drm/exynos/Makefile |2 +
drivers/gpu/drm/exyn
* e.g. NV12 (http://fourcc.org/yuv.php#NV12) is described as:
> + *
> + * YUV 4:2:0 image with a plane of 8 bit Y samples
> + * followed by an interleaved U/V plane containing
> + * 8 bit 2x2 subsampled colour difference samples.
> + *
> + * So it would consist of Y a
ck);
>>>> INIT_LIST_HEAD(&dmabuf->attachments);
>>>> + INIT_LIST_HEAD(&dmabuf->metas);
>>>>
>>> I am not sure I understand the relationship of 'meta data' with
>>> 'dma-buf', or 'attachments
0;
> + dma_addr = win_data->dma_addr;
Basically, you are right and source offset register can be used. But
because of limitation of resolution for mixer up to 1920x1080, I
considered modified soruce dma address to set one frame buffer, which is
bigger than 1920x1080, on to both fimd and hdmi.
Hello Daniel,
On 2014? 05? 07? 23:14, Daniel Kurtz wrote:
> On Wed, May 7, 2014 at 1:14 PM, Seung-Woo Kim
> wrote:
>> Hi Daniel,
>>
>> On 2014? 05? 05? 00:26, Daniel Kurtz wrote:
>>> Mixer hardware supports offsetting dma from start of source buffer u
The i2c drivers for ddc and hdmiphy are already removed from build
and instead, i2c clients registered via devicetree are used. So this
patch removes the unnecessary i2c drivers.
Signed-off-by: Seung-Woo Kim
---
drivers/gpu/drm/exynos/exynos_ddc.c | 63
imported gem come from its own gem into each drivers
having prime_import and prime_export capabilities. With this, only gem ref
count is increased if importing gem exported from gem of same driver.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin.park
Cc: Inki Dae
Cc: Daniel Vetter
Cc: Rob Clark
platform_device_register_simple() never returns NULL, but IS_ERR_OR_NULL macro
is used for checking return value in exynos drm driver.
Signed-off-by: Seung-Woo Kim
---
This patch is based on exynos-drm-next branch.
drivers/gpu/drm/exynos/exynos_drm_drv.c |2 +-
drivers/gpu/drm/exynos
The hdmi common device registration function does not need extern definition
and for error case and unregister case, exynos_drm_hdmi_pdev should be cleared.
Signed-off-by: Seung-Woo Kim
---
This commit is based on exynos-drm-next and my previous commit "drm/exynos: fix
wrong return chec
This patch added exynos-drm-ipp platform device registration to the exynos drm
driver. When DT is enabled, platform devices need to be registered within the
driver code. This patch fits the requirement of both DT and Non DT based drm
drivers.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Donghwa
Allocating scatter table with sg_alloc_table() does not consider
contiguous pages. Because sg_alloc_table_from_pages() merges
contigous pages into a signle scatter entry, this patch fixes to
allocate scatter table with it from drm_prime_pages_to_sg().
Signed-off-by: Seung-Woo Kim
---
drivers
http://www.spinics.net/lists/dri-devel/msg19939.html
Signed-off-by: Seung-Woo Kim
Signed-off-by: Joonyoung Shim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 167 +++
drivers/gpu/drm/exynos/regs-hdmi.h | 182 +++
DRM_HZ and DRM_WAKEUP macros are removed, but they still remained.
So this patch fixes build errors by replacing the macros.
Signed-off-by: Seung-Woo Kim
---
The build errors are only in drm-next branch, so this patch is based on the
branch.
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c |4
If edid of vidi from user is invalid, size calculated from a number
of cea extensions can be wrong. So, validation should be checked.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin.park
---
drivers/gpu/drm/exynos/exynos_drm_vidi.c |6 +++---
1 files changed, 3 insertions(+), 3
Yes, at least for exynos-drm-next tree of Inki. Inki sent pull request
including my patch yesterday.
Best Regards,
- Seung-Woo Kim
Multi buffer plane pixel formats are added as like kernel header.
Signed-off-by: Seung-Woo Kim
---
include/drm/drm_fourcc.h |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h
index 85facb0..7cfd95a 100644
--- a
This patch adds multi buffer plane pixel formats into valid pixel
format list for fb since they are missed from the list.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/drm_crtc.c |3 +++
1 files changed, 3 insertions(+), 0 deletions
Blending for graphic layer 0 of hdmi mixer was not set so video
layer cannot be showed if graphic layer 0 is enabled.
This patch fixes blending values to support blending between
graphic layer 0 and video layer.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
This patch is based
imported gem come from its own gem into
each drivers having prime_import and prime_export capabilities. With
this, only gem ref count is increased if importing gem exported from
gem of same driver.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin.park
Cc: Inki Dae
Cc: Daniel Vetter
Cc: Rob Clark
Becuase of order of headers, there are build warnings and they are
fixed with this patch.
Signed-off-by: Seung-Woo Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
b/drivers/gpu
devm_kfree does not need for fail case of probe function and for
remove function.
Signed-off-by: Seung-Woo Kim
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 --
drivers/gpu/drm/exynos/exynos_drm_rotator.c |2 --
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers
Build warnings of ipp fimc is fixed and device pointer usage is
simplified as directly using dev variable.
devm related fixes are also appiled: meaningless devm_kfree is
removed and request_threaded_irq is replaced to devm function.
Seung-Woo Kim (4):
drm/exynos: cleanup device pointer usages
devm_request_threaded_irq is used instead of request_threaded_irq
and free_irq is removed.
Signed-off-by: Seung-Woo Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c|8 ++--
drivers/gpu/drm/exynos/exynos_drm_gsc.c |8 ++--
drivers/gpu/drm/exynos/exynos_drm_rotator.c
Struct device pointer got from platform device pointer is already
alsigned as variable, but some functions do not use device pointer.
So this patch replaces thoes usages.
Signed-off-by: Seung-Woo Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +-
drivers/gpu/drm/exynos
Signed-off-by: Seung-Woo Kim
---
drivers/gpu/drm/exynos/exynos_drm_hdmi.c |4 ++--
drivers/gpu/drm/exynos/exynos_mixer.c|2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
index 437fb94
importer private data in dma-buf attachment can be used by importer to
reimport same dma-buf.
Seung-Woo Kim (2):
dma-buf: add importer private data to attachment
drm/prime: find gem object from the reimported dma-buf
drivers/base/dma-buf.c | 31
used at reimport time if it is assigned
with drm gem object at first import.
This can also remove remapping dma address for the hardware having
its own iommu.
Signed-off-by: Seung-Woo Kim
---
drivers/gpu/drm/drm_prime.c| 19 ++-
drivers/gpu/drm/exynos
-by: Seung-Woo Kim
---
drivers/base/dma-buf.c | 31 +++
include/linux/dma-buf.h |4
2 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c
index 08fe897..a1eaaf2 100644
--- a/drivers/base/dma-buf.c
> afaiu, stride (and maybe even width?) should be a multiple of the
> block size (but height does not)
>
> BR,
> -R
>
>
>> -Daniel
>>
>>
>>> +#define DRM_FORMAT_MOD_SAMSUNG_64_32_TILE fourcc_mod_code(SAMSUNG, 1)
>>> +
>>> #endif /* DRM_FOURCC_H */
>>> --
>>> Qualcomm Innovation Center, Inc.
>>>
>>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
>>> a Linux Foundation Collaborative Project
>>>
>>
>> --
>> Daniel Vetter
>> Software Engineer, Intel Corporation
>> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
>
--
Seung-Woo Kim
Samsung Software R&D Center
--
ow_ (since the use of 'usleep_range' is just plain wrong while under
> spinlock). When the spinlock setup gets cleaned up later, then we can
> always change back to 'usleep_range' again.
>
> Any thoughts?
In s5p-tv, same patch is already applied by Tomasz, so I
: Seung-Woo Kim
---
drivers/gpu/drm/exynos/exynos_mixer.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
b/drivers/gpu/drm/exynos/exynos_mixer.c
index 6766271..086fe0e 100644
--- a/drivers/gpu/drm/exynos/exynos_mixer.c
+++ b/drivers
Hello Daniel,
On 2015ë
02ì 04ì¼ 00:48, Daniel Vetter wrote:
> So this has been merged originally in
>
> commit 83052d4d5cd518332440bb4ee63d68bb5f744e0f
> Author: Seung-Woo Kim
> Date: Thu Dec 15 15:40:55 2011 +0900
>
> drm: Add multi buffer plane pixel formats
&
This patch series fixes minor code issues including wrong trace point foramts,
meaningless null checking, and possible resource leak in error cases.
This is based drm-next branch.
Seung-Woo Kim (2):
drm: fix print format of sequence in trace point
drm: move edid null check to the first part
seq of a trace point is unsigned int but print format was %d. So
it fixes the format as %u even the format can be not used.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/drm_trace.h |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a
If raw_edid is null, it will crash, so checking in bad label is
meaningless.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/drm_edid.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm
es driver specific per-file private data, then the private
data should be released.
Signed-off-by: YoungJun Cho
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/drm_fops.c | 17 +
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/driver
Hello Chris,
Thank you for reviewing.
On 2013? 07? 01? 19:23, Chris Wilson wrote:
> On Mon, Jul 01, 2013 at 07:06:31PM +0900, Seung-Woo Kim wrote:
>> seq of a trace point is unsigned int but print format was %d. So
>> it fixes the format as %u even the format can be not use
seq of a trace point is unsigned int but print format was %d. So
it fixes the format as %u.
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
change from v1
- remove wrong commit messageas Chris commented
drivers/gpu/drm/drm_trace.h |6 +++---
1 files changed, 3 insertions
es driver specific per-file private data, then the private
data should be released.
Signed-off-by: YoungJun Cho
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
change from v1
- replace error value for failure to find the minor as ENODEV as Chris commented
drivers/gpu/drm/drm_fops
Hello Chris,
On 2013? 07? 01? 19:57, Chris Wilson wrote:
> On Mon, Jul 01, 2013 at 07:49:10PM +0900, Seung-Woo Kim wrote:
>> +
>> +out_close:
>> +if (dev->driver->postclose)
>> +dev->driver->postclose(dev, priv);
>> +out_free:
>>
Hi Daniel,
On 2013? 07? 01? 23:56, Daniel Vetter wrote:
> On Mon, Jul 1, 2013 at 12:21 PM, Chris Wilson
> wrote:
>> On Mon, Jul 01, 2013 at 07:06:32PM +0900, Seung-Woo Kim wrote:
>>> If raw_edid is null, it will crash, so checking in bad label is
>>> meaningless.
led when error happens after their pair functions are
called. If an error occurs after executing dev->driver->open()
which allocates driver specific per-file private data, then the
private data should be released.
Signed-off-by: YoungJun Cho
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyun
If raw_edid of drm_edid_block_vaild() is null, it will crash, so
checking in bad label is removed and instead assertion is added at
the top of the function.
The type of return for the function is bool, so it fixes to return
true and false instead of 1 and 0.
Signed-off-by: Seung-Woo Kim
Signed
led when error happens after their pair functions are
called. If an error occurs after executing dev->driver->open()
which allocates driver specific per-file private data, then the
private data should be released.
Signed-off-by: YoungJun Cho
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyun
Hello Ville,
Thanks for comment.
On 2013? 07? 02? 17:29, Ville Syrj?l? wrote:
> On Tue, Jul 02, 2013 at 09:52:02AM +0900, Seung-Woo Kim wrote:
>> If raw_edid of drm_edid_block_vaild() is null, it will crash, so
>> checking in bad label is removed and instead assertion is added a
If raw_edid of drm_edid_block_vaild() is null, it will crash, so
checking in bad label is removed and instead assertion is added at
the top of the function.
The type of return for the function is bool, so it fixes to return
true and false instead of 1 and 0.
Signed-off-by: Seung-Woo Kim
Signed
From: YoungJun Cho
When drm iommu is not supported, buf->pages has to be allocated
and assigned to phys_to_page() result, which type is struct page *.
So it is sufficient to allocate buf->pages with multiple struct
page pointer size.
Signed-off-by: YoungJun Cho
Signed-off-by: Kyungmin Park
---
Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
change from v1:
- adds precedence patch to fix allocation of array as Ville and Inki commented
drivers/gpu/drm/exynos/exynos_drm_buf.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_bu
From: YoungJun Cho
If the type of object is pointer array, the drm_calloc_large() is
more suitable than kzalloc() for its allocation function. And uses
drm_free_large() instead of kfree() also.
Signed-off-by: YoungJun Cho
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers
There were duplicated error handling routines during allocating
pages in lowlevel_buffer_allocate() and g2d_userptr_get_dma_addr().
Also unnecessary NULL assignments for variable used not any more
are removed from g2d_userptr_get_dma_addr() and
g2d_userptr_put_dma_addr().
Signed-off-by: Seung-Woo
gt;]
> >>>>> Sent: Thursday, June 13, 2013 5:56 PM
> >>>>> To: Rahul Sharma
> >>>>> Cc: Rahul Sharma; Inki Dae; linux-samsung-soc at vger.kernel.org
> <mailto:linux-samsung-soc at vger.kernel.org>;
>
From: YoungJun Cho
When the exynos_drm_subdrv_open() returns error, the file_priv
should be released and file->driver_priv set to NULL.
Signed-off-by: YoungJun Cho
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_drv.c |9 -
1 file changed, 8 insertions(+), 1 del
The definition of regulator_bulk_enable is fixed with __must_check
and this causes following build warning.
warning: ignoring return value of 'regulator_bulk_enable',
declared with attribute warn_unused_result
This patch fixes to check return value of the function.
Signed-off-by: Seu
This patch set removes tracking logs and function name duplications.
This is for the next tree and based on exynos-drm-next branch.
YoungJun Cho (2):
drm/exynos: Remove tracking log functions
drm/exynos: Clean up logs for DRM_ERROR / DRM_DEBUG_KMS
drivers/gpu/drm/exynos/exynos_drm_buf.c
From: YoungJun Cho
This patch removes tracking log functions which were used to debug
in the early development stage and are not so important as were.
So remove them for code clean up.
Signed-off-by: YoungJun Cho
Signed-off-by: Seung-Woo Kim
---
drivers/gpu/drm/exynos/exynos_drm_buf.c
From: YoungJun Cho
This patch cleans up logs for DRM_ERROR / DRM_DEBUG_KMS to avoid
logging duplicated function name because the macros already contain
__func__.
Signed-off-by: YoungJun Cho
Signed-off-by: Seung-Woo Kim
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c| 113
From: YoungJun Cho
The dma_map_sg(), in map_dma_buf callback operation of prime helper,
can return 0 when it fails to map, so it needs to release related
resources.
Signed-off-by: YoungJun Cho
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/drm_prime.c |9
From: YoungJun Cho
Instead of NULL, error value is casted with ERR_PTR() for
drm_prime_pages_to_sg() and IS_ERR_OR_NULL() macro is replaced
with IS_ERR() macro for drm_gem_map_dma_buf().
Signed-off-by: YoungJun Cho
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu
During exporting dma_buf, it can fail after dma_buf is exported. In this case,
exported dma_buf should be release with putting.
Also dma_buf_fd can be failed to get fd, but failure cases are not handled.
Error handling routine is not quite clean, so I send this patch set as RFC.
Seung-Woo Kim (1
From: YoungJun Cho
When drm_prime_add_buf_handle() returns failure for an exported
dma_buf, the dma_buf was already allocated and its refcount was
increased, so it needs to be put.
Signed-off-by: YoungJun Cho
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm
Signed-off-by: Seung-Woo Kim
Signed-off-by: YoungJun Cho
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/drm_prime.c | 32
1 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
index
From: YoungJun Cho
The dma_buf_fd() can return error when it fails to prepare fd,
so the dma_buf needs to be put.
Signed-off-by: YoungJun Cho
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/drm_prime.c | 39 ---
1 files
From: YoungJun Cho
If idr_alloc() is failed, obj->name can be error value. Also
it cleans up duplicated flink processing code.
Signed-off-by: YoungJun Cho
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/drm_gem.c | 18 +++---
1 files changed
-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
CC: Laurent Pinchart
CC: Rob Clark
---
This patch is based on drm-next branch.
drivers/gpu/drm/drm_gem.c |4
drivers/gpu/drm/drm_gem_cma_helper.c |3 +++
drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c |3 +++
3 fi
-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
CC: Laurent Pinchart
CC: Rob Clark
---
This patch is based on drm-next branch.
Changes since v1:
- Use lockdep_assert_held() instead of mutex_is_locked() as Maarten commented
- Fix commit message about assertion
drivers/gpu/drm/drm_ge
to idr_alloc()
Signed-off-by: YoungJun Cho
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
change since v1:
- Add a regression commit information in commit msg as Chris commented
drivers/gpu/drm/drm_gem.c | 18 +++---
1 file changed, 7 insertions(+), 11 deleti
: Seung-Woo Kim
Signed-off-by: Kyungmin Park
---
This patch is based on exynos-drm-next branch.
drivers/gpu/drm/exynos/exynos_drm_gem.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c
b/drivers/gpu/drm/exynos
From: YoungJun Cho
The type of input parameter enable is bool, so it does not need
to check whether true or false.
Signed-off-by: YoungJun Cho
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_vidi.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/exy
From: YoungJun Cho
The buf_num in vp_video_buffer() should be 1 or 2, but it is not
initialized, and only set to 2 in NV12M or NV12MT cases.
So this patch initializes the buf_num with 1 as default.
Signed-off-by: YoungJun Cho
Signed-off-by: Seung-Woo Kim
Signed-off-by: Kyungmin Park
101 - 193 of 193 matches
Mail list logo
