[PATCH libdrm] tests/libkms-test-plane: fix possbile memory leak

The pointer p aquired with drmModeGetPlane() is not free in error path. Fix possible memory leak by calling drmModeFreePlane() in the error path. Signed-off-by: Seung-Woo Kim --- tests/kms/libkms-test-plane.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tests/kms

[PATCH libdrm] xf86drm: Fix possible memory leak with drmModeGetPropertyPtr()

In drmModeGetPropertyPtr(), from upper error path, it calls free but with just next error path, it does not call. Fix the possible memory leak. Signed-off-by: Seung-Woo Kim --- xf86drmMode.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xf86drmMode.c b/xf86drmMode.c

[PATCH libdrm] configure.ac fix build error for config.h in autotools

top.org/show_bug.cgi?id=106561 Signed-off-by: Seung-Woo Kim --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 7e7c8d3..d72e84a 100644 --- a/configure.ac +++ b/configure.ac @@ -541,7 +541,7 @@ else AC_DEFINE(HAV

[RESEND][PATCH libdrm] configure.ac fix build error for config.h in autotools

top.org/show_bug.cgi?id=106561 Signed-off-by: Seung-Woo Kim --- It looks like missed from mailing list, so I resend. --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 7e7c8d3..d72e84a 100644 --- a/configure.ac +++ b/co

[PATCH] drm/exynos: g2d: remove style error

Remove checkpatch error, "foo* bar" should be "foo *bar". Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/ex

[PATCH] dma-buf/sw-sync: Use unsigned type for value of sync_timeline

The value of sync_timeline is only incremented and all reference usage of it is unsigned. Use unsigned type for value of synctimeline. Signed-off-by: Seung-Woo Kim --- drivers/dma-buf/sync_debug.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dma-buf

[PATCH] xf86drm: only include for FreeBSD build case

The header is only required FreeBSD and GNU libc 2.30 starts to warn about Linux specific header deprecation. Only include for FreeBSD. Signed-off-by: Seung-Woo Kim --- xf86drmMode.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/xf86drmMode.c b/xf86drmMode.c index

Re: [PATCH] xf86drm: only include for FreeBSD build case

Hi, On 2020년 01월 10일 00:18, Jani Nikula wrote: > On Thu, 09 Jan 2020, Seung-Woo Kim wrote: >> The header is only required FreeBSD and GNU libc >> 2.30 starts to warn about Linux specific header >> deprecation. Only include for FreeBSD. >> >

Re: [PATCH] xf86drm: only include for FreeBSD build case

Hi On 2020년 01월 10일 00:28, Niclas Zeising wrote: > On 2020-01-09 16:18, Jani Nikula wrote: >> On Thu, 09 Jan 2020, Seung-Woo Kim wrote: >>> The header is only required FreeBSD and GNU libc >>> 2.30 starts to warn about Linux specific header >>> de

[PATCH libdrm] meson.build: Don't detect header for linux

The header is not required for Linux and GNU libc 2.30 starts to warn about Linux specific header deprecation. Don't detect header for linux. Signed-off-by: Seung-Woo Kim --- Fix meson.build script instead of code itself as commented below: https://patchwork.kernel.org/patch/113

[PATCH libdrm 3/3] tests/exynos: remove unused-function build warning

The function g2d_blend_test() is blocked to call because of feature unsafety. This patch blocks with proper feature name and also blocks the function itself to remove build warning. Signed-off-by: Seung-Woo Kim --- tests/exynos/exynos_fimg2d_test.c |4 +++- 1 files changed, 3 insertions

[PATCH libdrm 0/3] remove build warnings for exynos

For exynos module for libdrm, there are some build warnings, so this patch series remove them. Seung-Woo Kim (3): exynos: fix type-punned pointer build warning exynos/fimg2d: remove unused-function build warning tests/exynos: remove unused-function build warning exynos/exynos_drm.c

[PATCH libdrm 1/3] exynos: fix type-punned pointer build warning

s [-Wstrict-aliasing] e = (struct drm_event *) &buffer[i]; ^ Signed-off-by: Seung-Woo Kim --- exynos/exynos_drm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/exynos/exynos_drm.c b/exynos/exynos_drm.c index b961e52..f6204f1 100644 --- a/exynos/e

[PATCH libdrm 2/3] exynos/fimg2d: remove unused-function build warning

The function g2d_reset() is not anymore used after the commit e3c97d1a2473 ("exynos/fimg2d: add g2d_validate_xyz() functions"), so it should be removed. Signed-off-by: Seung-Woo Kim --- exynos/exynos_fimg2d.c | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) di

[PATCH libdrm] libkms/exynos: fix memory leak in error path

This patch fixes memory leak in error path of exynos_bo_create(). Signed-off-by: Seung-Woo Kim --- libkms/exynos.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libkms/exynos.c b/libkms/exynos.c index 5de2e5a..0e97fb5 100644 --- a/libkms/exynos.c +++ b/libkms

[PATCH libdrm] tests/exynos: fix memory issues of error path in g2d test

This patch fixes memory issues including NULL deference and leak in g2d test in error path. Signed-off-by: Seung-Woo Kim --- tests/exynos/exynos_fimg2d_test.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/tests/exynos/exynos_fimg2d_test.c b/tests/exynos

Re: [PATCH libdrm] tests/exynos: fix memory issues of error path in g2d test

Hello Emil, Thanks for comment. On 2017년 03월 20일 09:08, Emil Velikov wrote: > Hi Seung-Woo Kim, > > On 16 March 2017 at 02:00, Seung-Woo Kim wrote: >> This patch fixes memory issues including NULL deference and leak >> in g2d test in error path. >> >

[PATCH] tests/exynos: fix invalid code of error path in g2d test

This patch fixes invalid code of error path including NULL deference and leak in g2d test. Signed-off-by: Seung-Woo Kim --- tests/exynos/exynos_fimg2d_test.c | 39 +++- 1 files changed, 21 insertions(+), 18 deletions(-) diff --git a/tests/exynos

[PATCH libdrm] xf86drm: remove memory leaks in drmGetBusid/drmGetReservedContextList

In error path of drmGetBusid() and drmGetReservedContextList(), there are memory leaks for error path. So this removes them. Signed-off-by: Seung-Woo Kim --- xf86drm.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/xf86drm.c b/xf86drm.c index 88f86ed

[PATCH] drm/exynos: hdmi: add null check for hdmiphy_port

The hdmiphy can be apb and hdmiphy_port can be null. So before accessing hdmiphy_port, it should be checked. Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_hdmi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b

Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

>>>>> Sent: Thursday, June 13, 2013 5:56 PM > >>>>> To: Rahul Sharma > >>>>> Cc: Rahul Sharma; Inki Dae; linux-samsung-...@vger.kernel.org > <mailto:linux-samsung-...@vger.kernel.org>; > >>>>> de

[RESEND][PATCH] libkms/exynos: fix memory leak in error path

This patch fixes memory leak in error path of exynos_bo_create(). Signed-off-by: Seung-Woo Kim --- libkms/exynos.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libkms/exynos.c b/libkms/exynos.c index 5de2e5a..0e97fb5 100644 --- a/libkms/exynos.c +++ b/libkms

[PATCH libdrm] tests/exynos: remove dead condition

There is already condition checking input values between 2 and 4096 so condition checking 0 is always false. Remove the dead condition. Signed-off-by: Seung-Woo Kim --- tests/exynos/exynos_fimg2d_perf.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/tests/exynos

Re: [PATCH libdrm] modetest: Fix to check return value of asprintf()

Hello, On 2018년 01월 22일 21:09, Eric Engestrom wrote: > On Wednesday, 2018-01-10 11:16:41 +0900, Seung-Woo Kim wrote: >> There is warning about ignoring return value of 'asprintf'. Fix to >> check return value of asprintf(). >> >> Signed-off-by: Seung-Woo

[PATCH libdrm] amdgpu: fix not to add amdgpu.ids when building without amdgpu

The amdgpu.ids is only required when building with amdgpu support. Fix not to add it without amdgpu. Signed-off-by: Seung-Woo Kim --- data/Makefile.am |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/data/Makefile.am b/data/Makefile.am index eba915d..897a7f3 100644

[PATCH libdrm] modetest: Fix to check return value of asprintf()

There is warning about ignoring return value of 'asprintf'. Fix to check return value of asprintf(). Signed-off-by: Seung-Woo Kim --- tests/modetest/modetest.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/

[PATCH 0/3] drm/exynos: Kconfig dependency fixes

uired for drm fimc and drm gsc. Best Regards, - Seung-Woo Kim > > drivers/gpu/drm/exynos/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > -- Seung-Woo Kim Samsung Software R&D Center --

[PATCH 0/3] drm/exynos: Kconfig dependency fixes

Hello Javier, On 2016년 03월 29일 11:41, Javier Martinez Canillas wrote: > Hello Seung-Woo, > > Thanks a lot for your feedback. > > On 03/28/2016 09:46 PM, Seung-Woo Kim wrote: >> Hi Javier, >> >> On 2016년 03월 29일 10:28, Javier Martinez Canillas wr

[RESEND][PATCH] drm/prime: drop reference on imported dma-buf come from gem

imported gem come from its own gem into each drivers having prime_import and prime_export capabilities. With this, only gem ref count is increased if importing gem exported from gem of same driver. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin.park Cc: Inki Dae Cc: Daniel Vetter Cc: Rob Clark

[PATCH 1/2] drm/exynos: fix flags in dma buf exporting

This patch fixes flags passed to dma buf exporting. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin.park --- I found exynos drm also sends wrong flag for dma buf exporting. So I send this based on drm-fixes branch. drivers/gpu/drm/exynos/exynos_drm_dmabuf.c |2 +- 1 files changed, 1

[PATCH 2/2] drm/omap: fix flags in dma buf exporting

This patch fixes flags passed to dma buf exporting. Signed-off-by: Seung-Woo Kim Cc: Rob Clark --- I found omap drm also sends wrong flag for dma buf exporting. So I send this based on drm-fixes branch. drivers/staging/omapdrm/omap_gem_dmabuf.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH] drm/exynos: added validation of edid for vidi connection

If edid of vidi from user is invalid, size calculated from a number of cea extensions can be wrong. So, validation should be checked. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin.park --- drivers/gpu/drm/exynos/exynos_drm_vidi.c |6 +++--- 1 files changed, 3 insertions(+), 3

[PATCH] drm/prime: drop reference on imported dma-buf come from gem

imported gem come from its own gem into each drivers having prime_import and prime_export capabilities. With this, only gem ref count is increased if importing gem exported from gem of same driver. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin.park Cc: Inki Dae Cc: Daniel Vetter Cc: Rob Clark

[PATCH 00/10] drm/exynos: prepare multiple display controllers

exynos_drm_display to exynos_drm_display_ops Joonyoung Shim (1): drm/exynos: restored kernel_fb_list when reiniting fb_helper Seung-Woo Kim (6): drm/exynos: added kms poll for handling hpd event drm/exynos: fixed connector flag with hpd and interlace scan for hdmi drm/exynos: fixed converting

[PATCH 04/10] drm/exynos: fixed converting between display mode and timing

missing members are added into converting function between timing and display mode and refresh rate of display mode is calculated by drm mode function. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_connector.c |9 - 1 files changed

[PATCH 01/10] drm/exynos: added padding to be 64-bit align.

From: Inki Dae Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- include/drm/exynos_drm.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/drm/exynos_drm.h b/include/drm/exynos_drm.h index 874c4d2..1d161cb 100644 --- a/include/drm/exynos_drm.h +++ b/incl

[PATCH 07/10] drm/exynos: restored kernel_fb_list when reiniting fb_helper

From: Joonyoung Shim during recreating exynos_drm_fbdev as a new display device probes, fb_helper is reinitialized but kernel fb is not changed so kernel_fb_list should be restored after fb_helper is reinitialized. Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm

[PATCH 03/10] drm/exynos: fixed connector flag with hpd and interlace scan for hdmi

hdmi display in exynos supports hotplug event and interlace scan mode Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_connector.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/exynos

[PATCH 09/10] drm/exynos: added crtc dpms for disable crtc

crtc dpms is called as destroying attached fb so dpms off sould be processed. crtc dpms also can be called after crtc is detached from encoder so pipe value of manager is used to find display controller for this case Signed-off-by: Seung-Woo Kim Signed-off-by: Inki Dae Signed-off-by: Kyungmin

[PATCH 05/10] drm/exynos: added manager object to connector

From: Inki Dae connector contains some contents for display controller so the connector also should be able to access contoroller through manager. Signed-off-by: Inki Dae Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_connector.c | 38

[PATCH 10/10] drm/exynos: checked for null pointer

Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_encoder.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c index 4092f41

[PATCH 06/10] drm/exynos: changed exynos_drm_display to exynos_drm_display_ops

From: Inki Dae exynos_drm_display has function pointes so exynos_drm_display_ops is better to describe. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_connector.c | 29 + drivers/gpu/drm/exynos/exynos_drm_drv.h |4

[PATCH 08/10] drm/exynos: removed meaningless parameter from fbdev update

drm_framebuffer already has width and height so they are meaningless as parameters when updating fb_info. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 14 +- 1 files changed, 5 insertions(+), 9 deletions(-) diff --git

[PATCH 02/10] drm/exynos: added kms poll for handling hpd event

this patch adds kms poll infrastructure to handle hotplug detection event Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_drv.c |5 + drivers/gpu/drm/exynos/exynos_drm_fb.c | 12 2 files changed, 17 insertions(+), 0

Re: [PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format v5

* e.g. NV12 (http://fourcc.org/yuv.php#NV12) is described as: > + * > + * YUV 4:2:0 image with a plane of 8 bit Y samples > + * followed by an interleaved U/V plane containing > + * 8 bit 2x2 subsampled colour difference samples. > + * > + * S

[PATCH] drm/exynos: enable hdmi audio feature

http://www.spinics.net/lists/dri-devel/msg19939.html Signed-off-by: Seung-Woo Kim Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 167 +++ drivers/gpu/drm/exynos/regs-hdmi.h | 182 +++

[PATCH libdrm] libdrm: update drm/drm_fourcc.h from kernel to add multi plane formats

Multi buffer plane pixel formats are added as like kernel header. Signed-off-by: Seung-Woo Kim --- include/drm/drm_fourcc.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h index 85facb0..7cfd95a 100644 --- a

[PATCH] drm: add valid pixel formats for fb

This patch adds multi buffer plane pixel formats into valid pixel format list for fb since they are missed from the list. Signed-off-by: Seung-Woo Kim Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_crtc.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions

[PATCH] drm/exynos: add format list of plane

NV12, NV12M and NV12MT are added to format list of plane to use these formats for hdmi vp layer. Signed-off-by: Seung-Woo Kim Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_plane.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff

[PATCH 0/5] various patches related with hdmi of exynos drm

://www.spinics.net/lists/dri-devel/msg21739.html http://www.spinics.net/lists/dri-devel/msg21746.html http://www.spinics.net/lists/dri-devel/msg21734.html Seung-Woo Kim (5): drm/exynos: fixed wrong pageflip finish event for interlace mode drm/exynos: enable dvi mode for dvi monitor drm

[PATCH 2/5] drm/exynos: enable dvi mode for dvi monitor

Hdmi monitor and dvi monitor can be distinguished with edid. This patch enables dvi mode if dvi monitor is connected and does not enable audio feature for dvi mode because dvi has no audio feature. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos

[PATCH 1/5] drm/exynos: fixed wrong pageflip finish event for interlace mode

Pageflip finish event for interlace mode has bug on checking top field vsync because of comparing between dma address converted by start coordinates and non-converted dma address. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_mixer.c | 12

[PATCH 3/5] drm/exynos: add additional display mode for hdmi

1080p@30Hz mode is added to hdmi display mode. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 65 ++ 1 files changed, 65 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b

[PATCH 5/5] drm/exynos: added vp scaling feature for hdmi

This patch adds vp scaling feature for exynos hdmi. Scaling ratio between source and destination is used for width and height. Also meaningless variables to set registers are cleaned. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_mixer.c | 88

[PATCH 4/5] drm/exynos: added source size to overlay structure

Set plane has source size but exynos overlay structure did not consider it. This patch adds source size to overlay structure. For set crtc, source size is set from crtc size. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_crtc.c |4

[PATCH] drm/exynos: fixed blending for hdmi graphic layer

Blending for graphic layer 0 of hdmi mixer was not set so video layer cannot be showed if graphic layer 0 is enabled. This patch fixes blending values to support blending between graphic layer 0 and video layer. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- This patch is based

[PATCH] drm/exynos: fix wrong return check for platform_device_register_simple

platform_device_register_simple() never returns NULL, but IS_ERR_OR_NULL macro is used for checking return value in exynos drm driver. Signed-off-by: Seung-Woo Kim --- This patch is based on exynos-drm-next branch. drivers/gpu/drm/exynos/exynos_drm_drv.c |2 +- drivers/gpu/drm/exynos

[PATCH] exynos/drm: hdmi: cleanup for hdmi common device registration

The hdmi common device registration function does not need extern definition and for error case and unregister case, exynos_drm_hdmi_pdev should be cleared. Signed-off-by: Seung-Woo Kim --- This commit is based on exynos-drm-next and my previous commit "drm/exynos: fix wrong return chec

[PATCH] drm/exynos: added ipp device registration to drm driver

This patch added exynos-drm-ipp platform device registration to the exynos drm driver. When DT is enabled, platform devices need to be registered within the driver code. This patch fits the requirement of both DT and Non DT based drm drivers. Signed-off-by: Seung-Woo Kim Signed-off-by: Donghwa

[RFC][PATCH] drm/prime: fixed to allocate sg table considering contiguous pages

Allocating scatter table with sg_alloc_table() does not consider contiguous pages. Because sg_alloc_table_from_pages() merges contigous pages into a signle scatter entry, this patch fixes to allocate scatter table with it from drm_prime_pages_to_sg(). Signed-off-by: Seung-Woo Kim --- drivers

[PATCH 2/4] drm/exynos: fix build warnings from ipp fimc

Becuase of order of headers, there are build warnings and they are fixed with this patch. Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu

[PATCH 3/4] drm/exynos: remove unnecessary devm_kfree

devm_kfree does not need for fail case of probe function and for remove function. Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 -- drivers/gpu/drm/exynos/exynos_drm_rotator.c |2 -- 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 0/4] drm/exynos: code cleanups

Build warnings of ipp fimc is fixed and device pointer usage is simplified as directly using dev variable. devm related fixes are also appiled: meaningless devm_kfree is removed and request_threaded_irq is replaced to devm function. Seung-Woo Kim (4): drm/exynos: cleanup device pointer usages

[PATCH 4/4] drm/exynos: replace request_threaded_irq with devm function

devm_request_threaded_irq is used instead of request_threaded_irq and free_irq is removed. Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_drm_fimc.c|8 ++-- drivers/gpu/drm/exynos/exynos_drm_gsc.c |8 ++-- drivers/gpu/drm/exynos/exynos_drm_rotator.c

[PATCH 1/4] drm/exynos: cleanup device pointer usages

Struct device pointer got from platform device pointer is already alsigned as variable, but some functions do not use device pointer. So this patch replaces thoes usages. Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +- drivers/gpu/drm/exynos

[PATCH] drm/exynos: fix checks for valid mixer window

Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c |4 ++-- drivers/gpu/drm/exynos/exynos_mixer.c|2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c index 437fb94

[RFC][PATCH 0/2] dma-buf: add importer private data for reimporting

importer private data in dma-buf attachment can be used by importer to reimport same dma-buf. Seung-Woo Kim (2): dma-buf: add importer private data to attachment drm/prime: find gem object from the reimported dma-buf drivers/base/dma-buf.c | 31

[RFC][PATCH 2/2] drm/prime: find gem object from the reimported dma-buf

used at reimport time if it is assigned with drm gem object at first import. This can also remove remapping dma address for the hardware having its own iommu. Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/drm_prime.c| 19 ++- drivers/gpu/drm/exynos

[RFC][PATCH 1/2] dma-buf: add importer private data to attachment

-by: Seung-Woo Kim --- drivers/base/dma-buf.c | 31 +++ include/linux/dma-buf.h |4 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c index 08fe897..a1eaaf2 100644 --- a/drivers/base/dma-buf.c

[PATCH] drm/exynos: remove ignoring return value warning in hdmi

The definition of regulator_bulk_enable is fixed with __must_check and this causes following build warning. warning: ignoring return value of 'regulator_bulk_enable', declared with attribute warn_unused_result This patch fixes to check return value of the function. Signed-off-by: Seu

[PATCH 0/2] drm/exynos: clean up logs for next tree

This patch set removes tracking logs and function name duplications. This is for the next tree and based on exynos-drm-next branch. YoungJun Cho (2): drm/exynos: Remove tracking log functions drm/exynos: Clean up logs for DRM_ERROR / DRM_DEBUG_KMS drivers/gpu/drm/exynos/exynos_drm_buf.c

[PATCH 2/2] drm/exynos: Clean up logs for DRM_ERROR / DRM_DEBUG_KMS

From: YoungJun Cho This patch cleans up logs for DRM_ERROR / DRM_DEBUG_KMS to avoid logging duplicated function name because the macros already contain __func__. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_drm_fimc.c| 113

[PATCH] drm/prime: fix to check return of dma_map_sg in prime helper

From: YoungJun Cho The dma_map_sg(), in map_dma_buf callback operation of prime helper, can return 0 when it fails to map, so it needs to release related resources. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_prime.c |9

[PATCH] drm/prime: replace NULL with error value in drm_prime_pages_to_sg

From: YoungJun Cho Instead of NULL, error value is casted with ERR_PTR() for drm_prime_pages_to_sg() and IS_ERR_OR_NULL() macro is replaced with IS_ERR() macro for drm_gem_map_dma_buf(). Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu

[PATCH 0/3] fix error routine of exporting dma_buf

During exporting dma_buf, it can fail after dma_buf is exported. In this case, exported dma_buf should be release with putting. Also dma_buf_fd can be failed to get fd, but failure cases are not handled. Error handling routine is not quite clean, so I send this patch set as RFC. Seung-Woo Kim (1

[PATCH 1/3] drm/prime: fix to put an exported dma_buf for adding handle failure

From: YoungJun Cho When drm_prime_add_buf_handle() returns failure for an exported dma_buf, the dma_buf was already allocated and its refcount was increased, so it needs to be put. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm

[PATCH 2/3] drm/prime: reorder drm_prime_add_buf_handle and remove prototype

Signed-off-by: Seung-Woo Kim Signed-off-by: YoungJun Cho Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_prime.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c index

[PATCH 3/3] drm/prime: add return check for dma_buf_fd

From: YoungJun Cho The dma_buf_fd() can return error when it fails to prepare fd, so the dma_buf needs to be put. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_prime.c | 39 --- 1 files

[PATCH] drm/gem: fix not to assign error value to gem name

From: YoungJun Cho If idr_alloc() is failed, obj->name can be error value. Also it cleans up duplicated flink processing code. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_gem.c | 18 +++--- 1 files changed

[PATCH] drm/gem: add mutex lock when using drm_gem_mmap_obj

-by: Seung-Woo Kim Signed-off-by: Kyungmin Park CC: Laurent Pinchart CC: Rob Clark --- This patch is based on drm-next branch. drivers/gpu/drm/drm_gem.c |4 drivers/gpu/drm/drm_gem_cma_helper.c |3 +++ drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c |3 +++ 3 fi

[PATCH v2] drm/gem: add mutex lock when using drm_gem_mmap_obj

-by: Seung-Woo Kim Signed-off-by: Kyungmin Park CC: Laurent Pinchart CC: Rob Clark --- This patch is based on drm-next branch. Changes since v1: - Use lockdep_assert_held() instead of mutex_is_locked() as Maarten commented - Fix commit message about assertion drivers/gpu/drm/drm_ge

[PATCH v2] drm/gem: fix not to assign error value to gem name

to idr_alloc() Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- change since v1: - Add a regression commit information in commit msg as Chris commented drivers/gpu/drm/drm_gem.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deleti

[PATCH] drm/exynos: fix not to remain exynos_gem_obj as a leak

: Seung-Woo Kim Signed-off-by: Kyungmin Park --- This patch is based on exynos-drm-next branch. drivers/gpu/drm/exynos/exynos_drm_gem.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos

[PATCH 1/2] drm/exynos: remove dead code in vidi_power_on

From: YoungJun Cho The type of input parameter enable is bool, so it does not need to check whether true or false. Signed-off-by: YoungJun Cho Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_vidi.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/exy

[PATCH 2/2] drm/exynos: initialize the buf_num in vp_video_buffer

From: YoungJun Cho The buf_num in vp_video_buffer() should be 1 or 2, but it is not initialized, and only set to 2 in NV12M or NV12MT cases. So this patch initializes the buf_num with 1 as default. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park

[PATCH] drm/exynos: add error check routine in exynos_drm_open

From: YoungJun Cho When the exynos_drm_subdrv_open() returns error, the file_priv should be released and file->driver_priv set to NULL. Signed-off-by: YoungJun Cho Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_drv.c |9 - 1 file changed, 8 insertions(+), 1 del

[PATCH 0/3] drm: minor cleanups

This patch series fixes minor code issues including wrong trace point foramts, meaningless null checking, and possible resource leak in error cases. This is based drm-next branch. Seung-Woo Kim (2): drm: fix print format of sequence in trace point drm: move edid null check to the first part

[PATCH 1/3] drm: fix print format of sequence in trace point

seq of a trace point is unsigned int but print format was %d. So it fixes the format as %u even the format can be not used. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_trace.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a

[PATCH 2/3] drm: move edid null check to the first part of drm_edid_block_valid

If raw_edid is null, it will crash, so checking in bad label is meaningless. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_edid.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm

[PATCH 3/3] drm: fix error routines in drm_open_helper

es driver specific per-file private data, then the private data should be released. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_fops.c | 17 + 1 files changed, 13 insertions(+), 4 deletions(-) diff --git a/driver

Re: [PATCH 1/3] drm: fix print format of sequence in trace point

Hello Chris, Thank you for reviewing. On 2013년 07월 01일 19:23, Chris Wilson wrote: > On Mon, Jul 01, 2013 at 07:06:31PM +0900, Seung-Woo Kim wrote: >> seq of a trace point is unsigned int but print format was %d. So >> it fixes the format as %u even the format can be not use

[PATCH v2 1/3] drm: fix print format of sequence in trace point

seq of a trace point is unsigned int but print format was %d. So it fixes the format as %u. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- change from v1 - remove wrong commit messageas Chris commented drivers/gpu/drm/drm_trace.h |6 +++--- 1 files changed, 3 insertions

[PATCH v2 3/3] drm: fix error routines in drm_open_helper

es driver specific per-file private data, then the private data should be released. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- change from v1 - replace error value for failure to find the minor as ENODEV as Chris commented drivers/gpu/drm/drm_fops

Re: [PATCH v2 3/3] drm: fix error routines in drm_open_helper

Hello Chris, On 2013년 07월 01일 19:57, Chris Wilson wrote: > On Mon, Jul 01, 2013 at 07:49:10PM +0900, Seung-Woo Kim wrote: >> + >> +out_close: >> +if (dev->driver->postclose) >> +dev->driver->postclose(dev, priv); >> +out_free: >>

Re: [PATCH 2/3] drm: move edid null check to the first part of drm_edid_block_valid

Hi Daniel, On 2013년 07월 01일 23:56, Daniel Vetter wrote: > On Mon, Jul 1, 2013 at 12:21 PM, Chris Wilson > wrote: >> On Mon, Jul 01, 2013 at 07:06:32PM +0900, Seung-Woo Kim wrote: >>> If raw_edid is null, it will crash, so checking in bad label is >>> meaningless.

[PATCH v3 3/3] drm: fix error routines in drm_open_helper

led when error happens after their pair functions are called. If an error occurs after executing dev->driver->open() which allocates driver specific per-file private data, then the private data should be released. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyun

[PATCH v2 2/3] drm: add assertion for checking null edid to drm_edid_block_valid

If raw_edid of drm_edid_block_vaild() is null, it will crash, so checking in bad label is removed and instead assertion is added at the top of the function. The type of return for the function is bool, so it fixes to return true and false instead of 1 and 0. Signed-off-by: Seung-Woo Kim Signed

[PATCH v4 3/3] drm: fix error routines in drm_open_helper

led when error happens after their pair functions are called. If an error occurs after executing dev->driver->open() which allocates driver specific per-file private data, then the private data should be released. Signed-off-by: YoungJun Cho Signed-off-by: Seung-Woo Kim Signed-off-by: Kyun

Re: [PATCH v2 2/3] drm: add assertion for checking null edid to drm_edid_block_valid

Hello Ville, Thanks for comment. On 2013년 07월 02일 17:29, Ville Syrjälä wrote: > On Tue, Jul 02, 2013 at 09:52:02AM +0900, Seung-Woo Kim wrote: >> If raw_edid of drm_edid_block_vaild() is null, it will crash, so >> checking in bad label is removed and instead assertion is added a

[PATCH v3 2/3] drm: add assertion for checking null edid to drm_edid_block_valid

If raw_edid of drm_edid_block_vaild() is null, it will crash, so checking in bad label is removed and instead assertion is added at the top of the function. The type of return for the function is bool, so it fixes to return true and false instead of 1 and 0. Signed-off-by: Seung-Woo Kim Signed

  1   2   >