Re: [RFC PATCH 1/3] drm/color: Add RGB Color encodings

2021-04-30 Thread Sebastian Wick
On 2021-04-26 20:56, Harry Wentland wrote: On 2021-04-26 2:07 p.m., Ville Syrjälä wrote: On Mon, Apr 26, 2021 at 01:38:50PM -0400, Harry Wentland wrote: From: Bhawanpreet Lakha Add the following color encodings - RGB versions for BT601, BT709, BT2020 - DCI-P3: Used for digital movies Signed-

Re: [RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-05-17 Thread Sebastian Wick
On 2021-05-17 10:57, Pekka Paalanen wrote: On Fri, 14 May 2021 17:05:11 -0400 Harry Wentland wrote: On 2021-04-27 10:50 a.m., Pekka Paalanen wrote: > On Mon, 26 Apr 2021 13:38:49 -0400 > Harry Wentland wrote: ... >> ## Mastering Luminances >> >> Now we are able to use the PQ 2084 EOTF to

Re: [RFC PATCH v2 1/6] drm/doc: Color Management and HDR10 RFC

2021-05-17 Thread Sebastian Wick
On 2021-05-14 23:07, Harry Wentland wrote: Use the new DRM RFC doc section to capture the RFC previously only described in the cover letter at https://patchwork.freedesktop.org/series/89506/ Update the RFC based on feedback received: * don't use color_encoding property to define color space *

Re: [RFC PATCH 0/3] A drm_plane API to support HDR planes

2021-05-18 Thread Sebastian Wick
On 2021-05-18 16:19, Harry Wentland wrote: On 2021-05-18 3:56 a.m., Pekka Paalanen wrote: On Mon, 17 May 2021 15:39:03 -0400 Vitaly Prosyak wrote: On 2021-05-17 12:48 p.m., Sebastian Wick wrote: On 2021-05-17 10:57, Pekka Paalanen wrote: On Fri, 14 May 2021 17:05:11 -0400 Harry Wentland

Re: Handling DRM master transitions cooperatively

2021-09-07 Thread Sebastian Wick
On Tue, 07 Sep 2021 10:19:03 + Simon Ser wrote: > FWIW, I've just hit a case where a compositor leaves a "rotation" KMS > prop set behind, then Xorg tries to startup and fails because it doesn't > reset this prop. So none of this is theoretical. > > I still think a "reset all KMS props to an

Re: How should "max bpc" and "Colorspace" KMS property work?

2022-06-02 Thread Sebastian Wick
On Thu, Jun 2, 2022 at 6:40 PM Ville Syrjälä wrote: > > On Thu, Jun 02, 2022 at 10:47:59AM +0300, Pekka Paalanen wrote: > > On Wed, 1 Jun 2022 17:06:25 +0300 > > Ville Syrjälä wrote: > > > > > On Wed, Jun 01, 2022 at 10:21:26AM +0300, Pekka Paalanen wrote: > > > > On Tue, 31 May 2022 20:37:31 +03

Re: How should "max bpc" KMS property work?

2022-04-27 Thread Sebastian Wick
On Wed, Apr 27, 2022 at 5:41 PM Harry Wentland wrote: > > > > On 2022-04-27 06:52, Pekka Paalanen wrote: > > Hi Ville and Alex, > > > > thanks for the replies. More below. > > > > TL;DR: > > > > My take-away from this is that I should slam 'max bpc' to the max by > > default, and offer a knob for

Re: How should "max bpc" KMS property work?

2022-04-28 Thread Sebastian Wick
On Thu, Apr 28, 2022 at 4:50 PM Ville Syrjälä wrote: > > On Thu, Apr 28, 2022 at 07:52:58AM +, Simon Ser wrote: > > On Thursday, April 28th, 2022 at 09:50, Pekka Paalanen > > wrote: > > > > > > > > Also like Alex said, the kernel does not know if the user prefers > > > > > > high > > > > >

Re: How should "max bpc" KMS property work?

2022-05-23 Thread Sebastian Wick
On Mon, May 23, 2022 at 10:23 AM Pekka Paalanen wrote: > > On Fri, 20 May 2022 17:20:50 +0200 > Hans de Goede wrote: > > > I got pointed to this thread by Jonas Ådahl while asking some questions > > the "max bpc" property related to: > > > > https://gitlab.freedesktop.org/plymouth/plymouth/-/issu

Re: How should "max bpc" and "Colorspace" KMS property work?

2022-06-01 Thread Sebastian Wick
On Wed, Jun 1, 2022 at 4:06 PM Ville Syrjälä wrote: > > On Wed, Jun 01, 2022 at 10:21:26AM +0300, Pekka Paalanen wrote: > > On Tue, 31 May 2022 20:37:31 +0300 > > Ville Syrjälä wrote: > > > > > On Wed, May 25, 2022 at 01:36:47PM +0300, Pekka Paalanen wrote: > > > > On Wed, 25 May 2022 09:23:51 +0

Re: drm: document uAPI page-flip flags

2022-08-26 Thread Sebastian Wick
On Fri, Aug 26, 2022 at 10:58 AM Pekka Paalanen wrote: > > On Wed, 24 Aug 2022 17:45:06 + > Simon Ser wrote: > > > Document flags accepted by the page-flip and atomic IOCTLs. > > > > Signed-off-by: Simon Ser > > Cc: Daniel Vetter > > --- > > include/uapi/drm/drm_mode.h | 44 +++

Re: drm: document uAPI page-flip flags

2022-08-26 Thread Sebastian Wick
On Fri, Aug 26, 2022 at 2:17 PM Simon Ser wrote: > > On Friday, August 26th, 2022 at 11:49, Sebastian Wick > wrote: > > > > > +/* > > > > + * DRM_MODE_ATOMIC_ALLOW_MODESET > > > > + * > > > > + * Allow the update to result in visible

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-09-29 Thread Sebastian Wick
If it is supposed to be a non-linear luminance curve, which one is it? It would be much clearer if user space can control linear luminance and use whatever definition of perceived brightness it wants. The obvious downside of it is that it requires bits to encode changes that users can't perceive. W

Re: [PATCH v3] drm: document uAPI page-flip flags

2022-09-29 Thread Sebastian Wick
On Thu, Sep 29, 2022 at 8:11 PM Simon Ser wrote: > > On Wednesday, September 28th, 2022 at 12:06, Pekka Paalanen > wrote: > > > > +/** > > > + * DRM_MODE_PAGE_FLIP_FLAGS > > > + * > > > + * Bitmask of flags suitable for &drm_mode_crtc_page_flip_target.flags. > > > > Should this mention also drm_

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-09-30 Thread Sebastian Wick
On Fri, Sep 30, 2022 at 9:40 AM Pekka Paalanen wrote: > > On Thu, 29 Sep 2022 20:06:50 +0200 > Sebastian Wick wrote: > > > If it is supposed to be a non-linear luminance curve, which one is it? > > It would be much clearer if user space can control linear lumina

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-09-30 Thread Sebastian Wick
On Fri, Sep 30, 2022 at 5:27 PM Pekka Paalanen wrote: > > On Fri, 30 Sep 2022 17:44:17 +0300 > Ville Syrjälä wrote: > > > On Fri, Sep 30, 2022 at 04:20:29PM +0200, Sebastian Wick wrote: > > > On Fri, Sep 30, 2022 at 9:40 AM Pekka Paalanen > > > wrote: >

Re: [PATCH 00/21] Add Support for Plane Color Lut and CSC features

2021-06-03 Thread Sebastian Wick
On 2021-06-03 10:47, Pekka Paalanen wrote: On Wed, 2 Jun 2021 19:42:19 -0400 Harry Wentland wrote: On 2021-06-02 4:22 p.m., Shankar, Uma wrote: > > >> -Original Message- >> From: Pekka Paalanen >> Sent: Wednesday, June 2, 2021 2:59 PM >> To: Shankar, Uma >> Cc: intel-...@lists.freede

Re: [PATCH v2 18/21] drm/amd/display: Fallback to 2020_YCBCR if the pixel encoding is not RGB

2023-01-25 Thread Sebastian Wick
On Wed, Jan 25, 2023 at 2:00 PM Joshua Ashton wrote: > > > > On 1/23/23 20:30, Sebastian Wick wrote: > > A new property to control YCC and subsampling would be the more > > complete path here. If we actually want to fix this in the short-term > > though, we

Re: [PATCH v2 18/21] drm/amd/display: Fallback to 2020_YCBCR if the pixel encoding is not RGB

2023-01-25 Thread Sebastian Wick
On Tue, Jan 24, 2023 at 7:57 PM Harry Wentland wrote: > > > > On 1/24/23 10:37, Harry Wentland wrote: > > > > > > On 1/23/23 15:30, Sebastian Wick wrote: > >> A new property to control YCC and subsampling would be the more > >> complete path here. I

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Sebastian Wick
nd have one BT.2020 colorspace entry > > that userspace can use. > > > > Note: _CYCC was effectively 'removed' by this change, but that was not > > possible to be taken advantage of anyway, as there is currently no > > pixel_encoding control so it would not

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-03 Thread Sebastian Wick
On Fri, Feb 3, 2023 at 2:35 PM Ville Syrjälä wrote: > > On Fri, Feb 03, 2023 at 01:59:07PM +0100, Sebastian Wick wrote: > > On Fri, Feb 3, 2023 at 11:40 AM Ville Syrjälä > > wrote: > > > > > > On Fri, Feb 03, 2023 at 02:07:44AM +, Joshua Ashton wr

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Sebastian Wick
On Fri, Feb 3, 2023 at 5:00 PM Ville Syrjälä wrote: > > On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: > > > > > > On 2/3/23 10:19, Ville Syrjälä wrote: > > > On Fri, Feb 03, 2023 at 09:39:42AM -0500, Harry Wentland wrote: > > >>

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Sebastian Wick
On Tue, Feb 14, 2023 at 5:57 PM Harry Wentland wrote: > > > > On 2/14/23 10:49, Sebastian Wick wrote: > > On Fri, Feb 3, 2023 at 5:00 PM Ville Syrjälä > > wrote: > >> > >> On Fri, Feb 03, 2023 at 10:24:52AM -0500, Harry Wentland wrote: > >>

Re: [PATCH 3/3] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-02-14 Thread Sebastian Wick
On Tue, Feb 14, 2023 at 9:10 PM Ville Syrjälä wrote: > > On Tue, Feb 14, 2023 at 08:45:00PM +0100, Sebastian Wick wrote: > > On Tue, Feb 14, 2023 at 5:57 PM Harry Wentland > > wrote: > > > > > > > > > > > > On 2/14/23 10:49, Sebastian Wi

Re: [PATCH v2 3/9] drm/vc4: hdmi: Add Broadcast RGB property to allow override of RGB range

2023-02-21 Thread Sebastian Wick
On Mon, Feb 20, 2023 at 4:24 PM Dave Stevenson wrote: > > Hi Hans > > On Sat, 18 Feb 2023 at 11:33, Hans Verkuil wrote: > > > > Hi Maxime, Dave, > > > > On 26/01/2023 14:46, Maxime Ripard wrote: > > > From: Dave Stevenson > > > > > > Copy Intel's "Broadcast RGB" property semantics to add manual

Re: [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-02-21 Thread Sebastian Wick
On Tue, Feb 21, 2023 at 9:38 AM Pekka Paalanen wrote: > > On Mon, 20 Feb 2023 08:14:47 -0800 > Rob Clark wrote: > > > On Mon, Feb 20, 2023 at 12:53 AM Pekka Paalanen wrote: > > > > > > On Sat, 18 Feb 2023 13:15:49 -0800 > > > Rob Clark wrote: > > > > > > > From: Rob Clark > > > > > > > > Allow

Re: [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-02-27 Thread Sebastian Wick
On Mon, Feb 27, 2023 at 11:20 PM Rob Clark wrote: > > On Mon, Feb 27, 2023 at 1:36 PM Rodrigo Vivi wrote: > > > > On Fri, Feb 24, 2023 at 09:59:57AM -0800, Rob Clark wrote: > > > On Fri, Feb 24, 2023 at 7:27 AM Luben Tuikov wrote: > > > > > > > > On 2023-02-24 06:37, Tvrtko Ursulin wrote: > > >

Re: [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-02-28 Thread Sebastian Wick
On Tue, Feb 28, 2023 at 12:48 AM Rob Clark wrote: > > On Mon, Feb 27, 2023 at 2:44 PM Sebastian Wick > wrote: > > > > On Mon, Feb 27, 2023 at 11:20 PM Rob Clark wrote: > > > > > > On Mon, Feb 27, 2023 at 1:36 PM Rodrigo Vivi > > > wrote: &g

Re: [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-03-01 Thread Sebastian Wick
On Tue, Feb 28, 2023 at 11:52 PM Rob Clark wrote: > > On Tue, Feb 28, 2023 at 6:30 AM Sebastian Wick > wrote: > > > > On Tue, Feb 28, 2023 at 12:48 AM Rob Clark wrote: > > > > > > On Mon, Feb 27, 2023 at 2:44 PM Sebastian Wick > > > wrote: >

Re: [ANNOUNCE] pixfmtdb

2023-01-23 Thread Sebastian Wick
Why is the TF defined for GL formats and both the primaries and TF for Vulkan formats? The only exception here should be sRGB formats. Where did you get the information from? On Mon, Jan 23, 2023 at 4:51 PM Laurent Pinchart wrote: > > CC'ing the linux-media mailing list. > > On Mon, Jan 23, 2023

Re: [PATCH v2 18/21] drm/amd/display: Fallback to 2020_YCBCR if the pixel encoding is not RGB

2023-01-23 Thread Sebastian Wick
LRANGE is > requested but the output encoding is YCbCr we should > send COLOR_SPACE_2020_YCBCR. > > Signed-off-by: Joshua Ashton > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Joshua Ash

Re: [ANNOUNCE] pixfmtdb

2023-01-23 Thread Sebastian Wick
On Mon, Jan 23, 2023 at 11:43 PM Simon Ser wrote: > > On Monday, January 23rd, 2023 at 21:25, Sebastian Wick > wrote: > > > Why is the TF defined for GL formats and both the primaries and TF for > > Vulkan formats? The only exception here should be sRGB formats. W

The state of Quantization Range handling

2022-11-14 Thread Sebastian Wick
There are still regular bug reports about monitors (sinks) and sources disagreeing about the quantization range of the pixel data. In particular sources sending full range data when the sink expects limited range. From a user space perspective, this is all hidden in the kernel. We send full range d

Re: The state of Quantization Range handling

2022-11-17 Thread Sebastian Wick
Hi Dave, I noticed that I didn't get the Broadcast RGB property thanks to you (more below) On Tue, Nov 15, 2022 at 2:16 PM Dave Stevenson wrote: > > Hi Sebastian > > Thanks for starting the conversation - it's stalled a number of times > previously. > > On Mon,

Re: The state of Quantization Range handling

2022-11-17 Thread Sebastian Wick
on board. > > Regards > Yussuf > > [1] > https://patchwork.kernel.org/project/dri-devel/cover/20200413214024.46500-1-...@pp3345.net/ > [2] https://github.com/pp3345/linux/commits/rgb-quant-range-v2 > > On 15.11.22 00:11, Sebastian Wick wrote: > > There are still regular bug rep

Re: The state of Quantization Range handling

2022-11-17 Thread Sebastian Wick
On Wed, Nov 16, 2022 at 1:34 PM Pekka Paalanen wrote: > > On Tue, 15 Nov 2022 00:11:56 +0100 > Sebastian Wick wrote: > > > There are still regular bug reports about monitors (sinks) and sources > > disagreeing about the quantization range of the pixel data. In > > p

Re: [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-08 Thread Sebastian Wick
On Tue, Nov 8, 2022 at 7:51 PM Simon Ser wrote: > > cc'ing Pekka and wayland-devel for userspace devs feedback on the new uAPI. > > On Saturday, October 29th, 2022 at 14:08, Dmitry Baryshkov > wrote: > > > On 29/10/2022 01:59, Jessica Zhang wrote: > > > Add support for COLOR_FILL and COLOR_FILL_

Re: [PATCH 16/16] drm/amd/display: Don't restrict bpc to 8 bpc

2023-01-05 Thread Sebastian Wick
On Fri, Dec 23, 2022 at 8:10 PM Harry Wentland wrote: > > > > On 12/14/22 04:01, Pekka Paalanen wrote: > > On Tue, 13 Dec 2022 18:20:59 +0100 > > Michel Dänzer wrote: > > > >> On 12/12/22 19:21, Harry Wentland wrote: > >>> This will let us pass kms_hdr.bpc_switch. > >>> > >>> I don't see any good

Re: [RFC PATCH v2 3/3] drm/msm/dpu: Use color_fill property for DPU planes

2023-01-05 Thread Sebastian Wick
On Wed, Jan 4, 2023 at 2:10 AM Jessica Zhang wrote: > > > > On 12/22/2022 7:12 PM, Dmitry Baryshkov wrote: > > On 23/12/2022 00:14, Jessica Zhang wrote: > >> Initialize and use the color_fill properties for planes in DPU driver. In > >> addition, relax framebuffer requirements within atomic commit

Re: Try to address the DMA-buf coherency problem

2023-01-05 Thread Sebastian Wick
On Fri, Dec 9, 2022 at 11:28 AM Christian König wrote: > > Am 09.12.22 um 09:26 schrieb Tomasz Figa: > > [SNIP] > > Although I think the most common case on mainstream Linux today is > > properly allocating for device X (e.g. V4L2 video decoder or DRM-based > > GPU) and hoping that other devices w

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-05 Thread Sebastian Wick
On Fri, May 5, 2023 at 5:28 PM Daniel Vetter wrote: > > On Thu, May 04, 2023 at 03:22:59PM +, Simon Ser wrote: > > Hi all, > > > > The goal of this RFC is to expose a generic KMS uAPI to configure the color > > pipeline before blending, ie. after a pixel is tapped from a plane's > > framebuffe

Re: [RFC] Plane color pipeline KMS uAPI

2023-05-05 Thread Sebastian Wick
On Fri, May 5, 2023 at 10:40 PM Dave Airlie wrote: > > On Fri, 5 May 2023 at 01:23, Simon Ser wrote: > > > > Hi all, > > > > The goal of this RFC is to expose a generic KMS uAPI to configure the color > > pipeline before blending, ie. after a pixel is tapped from a plane's > > framebuffer and bef

Re: [PATCH v3 02/17] drm/connector: Add enum documentation to drm_colorspace

2023-03-08 Thread Sebastian Wick
ntland > > Hi, > > this effort is really good, but of course I still find things to > nitpick about. If there is no answer to my questions, then I would > prefer the documentation to spell out the unknowns and ambiguities. > > > Cc: Pekka Paalanen > > Cc

Re: [PATCH v3 03/17] drm/connector: Deprecate split for BT.2020 in drm_colorspace enum

2023-03-08 Thread Sebastian Wick
20 colorspace entry > > that userspace can use. > > > > v2: > > - leave CYCC alone for now; it serves a purpose > > - leave BT2020_RGB the new default BT2020 > > > > Signed-off-by: Joshua Ashton > > Signed-off-by: Harry Wentland > > Reviewed

Re: [PATCH v3 05/17] drm/connector: Use common colorspace_names array

2023-03-08 Thread Sebastian Wick
arry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Uma Shankar > Cc: Ville Syrjälä > Cc: Joshua Ashton > Cc: Jani Nikula > Cc: dri-devel@lists.freedesktop.org > Cc: amd-...@lists.freedeskt

Re: [PATCH v3 11/17] drm/amd/display: Send correct DP colorspace infopacket

2023-03-08 Thread Sebastian Wick
d > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Joshua Ashton > Cc: dri-devel@lists.freedesktop.org > Cc: amd-...@lists.freedesktop.org > Reviewed-By: Joshua Ashton > --- > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 38 +++--

Re: [PATCH v3 14/17] drm/amd/display: Add debugfs for testing output colorspace

2023-03-08 Thread Sebastian Wick
ndy when debugging display > issues. > > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Joshua Ashton > Cc: dri-devel@lists.freedesktop.org > Cc: amd-...@lists.freedesktop.org > Reviewed-By: Joshua Ashton

Re: [PATCH v3 02/17] drm/connector: Add enum documentation to drm_colorspace

2023-03-09 Thread Sebastian Wick
On Thu, Mar 9, 2023 at 11:03 AM Pekka Paalanen wrote: > > On Thu, 9 Mar 2023 01:56:11 +0100 > Sebastian Wick wrote: > > > On Wed, Mar 8, 2023 at 9:59 AM Pekka Paalanen wrote: > > > > > > On Tue, 7 Mar 2023 10:10:52 -0500 > > > Harry Wentl

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-15 Thread Sebastian Wick
sed by the driver. Not great at all. Something to remember for the new property. > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Joshua Ashton > Cc: dri-devel@lists.freedesktop.org > Cc: amd-...@lists.freede

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-16 Thread Sebastian Wick
; > > > On Thu, 16 Mar 2023 11:50:27 +0200 > > > > Ville Syrjälä wrote: > > > > > > > > > On Thu, Mar 16, 2023 at 01:37:24AM +0100, Sebastian Wick wrote: > > > > > > On Tue, Mar 7, 2023 at 4:12 PM Harry Wentland > > > >

Re: [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-16 Thread Sebastian Wick
On Thu, Mar 16, 2023 at 5:29 PM Rob Clark wrote: > > On Thu, Mar 16, 2023 at 2:26 AM Jonas Ådahl wrote: > > > > On Wed, Mar 15, 2023 at 09:19:49AM -0700, Rob Clark wrote: > > > On Wed, Mar 15, 2023 at 6:53 AM Jonas Ådahl wrote: > > > > > > > > On Fri, Mar 10, 2023 at 09:38:18AM -0800, Rob Clark

Re: [PATCH v10 01/15] dma-buf/dma-fence: Add deadline awareness

2023-03-17 Thread Sebastian Wick
On Thu, Mar 16, 2023 at 11:59 PM Rob Clark wrote: > > On Thu, Mar 16, 2023 at 3:22 PM Sebastian Wick > wrote: > > > > On Thu, Mar 16, 2023 at 5:29 PM Rob Clark wrote: > > > > > > On Thu, Mar 16, 2023 at 2:26 AM Jonas Ådahl wrote: > > > > &g

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-17 Thread Sebastian Wick
; > > > On Fri, 17 Mar 2023 14:50:40 +0200 > > > > Ville Syrjälä wrote: > > > > > > > > > On Fri, Mar 17, 2023 at 10:53:35AM +0200, Pekka Paalanen wrote: > > > > > > On Fri, 17 Mar 2023 01:01:38 +0200 > > > >

Re: [PATCH v3 09/17] drm/amd/display: Register Colorspace property for DP and HDMI

2023-03-17 Thread Sebastian Wick
On Fri, Mar 17, 2023 at 7:38 PM Ville Syrjälä wrote: > > On Fri, Mar 17, 2023 at 06:40:53PM +0100, Sebastian Wick wrote: > > On Fri, Mar 17, 2023 at 5:34 PM Ville Syrjälä > > wrote: > > > > > > On Fri, Mar 17, 2023 at 05:37:51PM +0200, Pekka Paalanen wrote:

Re: [PATCH v2 00/21] Enable Colorspace connector property in amdgpu

2023-03-21 Thread Sebastian Wick
e the colorspace property > directly to the infoframe and reduce the options to sRGB, BT709, > BT601, and BT2020 (and possibly opRGB). > > v2: > - Tested with DP and HDMI analyzers > - Confirmed driver will fallback to lower bpc when needed > - Dropped hunk to set HDMI AVI infof

Re: [RFC 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-06-21 Thread Sebastian Wick
On Fri, May 26, 2023 at 6:21 PM Aravind Iddamsetty wrote: > > Our hardware supports RAS(Reliability, Availability, Serviceability) by > exposing a set of error counters which can be used by observability > tools to take corrective actions or repairs. Traditionally there were > being exposed via PM

Re: [PATCH RFC v4 2/7] drm: Introduce pixel_source DRM plane property

2023-06-30 Thread Sebastian Wick
On Fri, Jun 30, 2023 at 2:26 AM Jessica Zhang wrote: > > Add support for pixel_source property to drm_plane and related > documentation. > > This enum property will allow user to specify a pixel source for the > plane. Possible pixel sources will be defined in the > drm_plane_pixel_source enum. >

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-30 Thread Sebastian Wick
On Tue, Jun 27, 2023 at 3:23 PM André Almeida wrote: > > Create a section that specifies how to deal with DRM device resets for > kernel and userspace drivers. > > Acked-by: Pekka Paalanen > Signed-off-by: André Almeida > --- > > v4: > https://lore.kernel.org/lkml/20230626183347.55118-1-andreal

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-06-30 Thread Sebastian Wick
On Fri, Jun 30, 2023 at 4:59 PM Alex Deucher wrote: > > On Fri, Jun 30, 2023 at 10:49 AM Sebastian Wick > wrote: > > > > On Tue, Jun 27, 2023 at 3:23 PM André Almeida > > wrote: > > > > > > Create a section that specifies how to deal with DRM

Re: [PATCH RFC v4 2/7] drm: Introduce pixel_source DRM plane property

2023-07-03 Thread Sebastian Wick
On Fri, Jun 30, 2023 at 11:27 PM Jessica Zhang wrote: > > > > On 6/30/2023 7:43 AM, Sebastian Wick wrote: > > On Fri, Jun 30, 2023 at 2:26 AM Jessica Zhang > > wrote: > >> > >> Add support for pixel_source property to drm_plane and related > >&g

Re: [PATCH v2 0/2] doc: uapi: Document dma-buf interop design & semantics

2023-08-03 Thread Sebastian Wick
For what it's worth this series is Reviewed-by: Sebastian Wick On Thu, Aug 3, 2023 at 5:49 PM Daniel Stone wrote: > > Hi all, > This is v2 to the linked patch series; thanks to everyone for reviewing > the initial version. I've moved this out of a pure DRM scope

Re: [PATCH] drm/vkms: avoid race-condition between flushing and destroying

2023-08-03 Thread Sebastian Wick
On Sun, Jul 30, 2023 at 12:51 AM Maíra Canal wrote: > > After we flush the workqueue at the commit tale, we need to make sure > that no work is queued until we destroy the state. Currently, new work > can be queued in the workqueue, even after the commit tale, as the > vblank thread is still runni

Re: [PATCH RFC v5 01/10] drm: Introduce pixel_source DRM plane property

2023-08-04 Thread Sebastian Wick
On Fri, Jul 28, 2023 at 7:03 PM Jessica Zhang wrote: > > Add support for pixel_source property to drm_plane and related > documentation. In addition, force pixel_source to > DRM_PLANE_PIXEL_SOURCE_FB in DRM_IOCTL_MODE_SETPLANE as to not break > legacy userspace. > > This enum property will allow u

Re: [PATCH RFC v5 02/10] drm: Introduce solid fill DRM plane property

2023-08-04 Thread Sebastian Wick
On Mon, Jul 31, 2023 at 6:01 AM Dmitry Baryshkov wrote: > > On 28/07/2023 20:02, Jessica Zhang wrote: > > Document and add support for solid_fill property to drm_plane. In > > addition, add support for setting and getting the values for solid_fill. > > > > To enable solid fill planes, userspace mu

Re: [PATCH RFC v5 02/10] drm: Introduce solid fill DRM plane property

2023-08-04 Thread Sebastian Wick
On Fri, Aug 4, 2023 at 3:27 PM Dmitry Baryshkov wrote: > > On Fri, 28 Jul 2023 at 20:03, Jessica Zhang wrote: > > > > Document and add support for solid_fill property to drm_plane. In > > addition, add support for setting and getting the values for solid_fill. > > > > To enable solid fill planes,

Re: [PATCH v4 00/13] Enable Colorspace connector property in amdgpu

2023-05-26 Thread Sebastian Wick
On Fri, May 26, 2023 at 3:16 PM Pekka Paalanen wrote: > > On Thu, 25 May 2023 15:17:56 -0400 > Harry Wentland wrote: > > > This patchset is based on Joshua's previous patchset [1], as well > > as my previous patchset [2]. > > > > It is > > - enabling support for the colorspace property in amdgpu,

Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Sebastian Wick
CYCC is "constant luminance" > - correct type for BT.601 > > v4: > - drop DP/HDMI clarifications that might create > more questions than answers > > Signed-off-by: Joshua Ashton > Signed-off-by: Harry Wentland > Reviewed-by: Harry Wentland > > Cc: Pekka

Re: [PATCH v4 08/13] drm/amd/display: Register Colorspace property for DP and HDMI

2023-05-26 Thread Sebastian Wick
o support with e.g. the appropriate YCC transform when necessary, independent of the sink support. > Signed-off-by: Harry Wentland > Cc: Pekka Paalanen > Cc: Sebastian Wick > Cc: vitaly.pros...@amd.com > Cc: Joshua Ashton > Cc: Simon Ser > Cc: Ville Syrjälä > Cc: Melissa Wen

Re: [PATCH v4 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-05-26 Thread Sebastian Wick
On Fri, May 26, 2023 at 6:37 PM Simon Ser wrote: > > On Friday, May 26th, 2023 at 18:27, Sebastian Wick > wrote: > > > > + * @DRM_MODE_COLORIMETRY_DEFAULT: > > > + * Driver specific behavior. > > > + * @DRM_MODE_COLORIMETRY_NO_DATA: > > > + * Dri

Re: [PATCH v4 00/13] Enable Colorspace connector property in amdgpu

2023-05-26 Thread Sebastian Wick
With the documentation about RGB and YCC variants added the drm core patches are Reviewed-by: Sebastian Wick On Fri, May 26, 2023 at 6:24 PM Sebastian Wick wrote: > > On Fri, May 26, 2023 at 3:16 PM Pekka Paalanen wrote: > > > > On Thu, 25 May 2023 15:17:56 -0400 > &g

Re: [PATCH 06/36] drm/amd/display: add CRTC driver-specific property for gamma TF

2023-06-06 Thread Sebastian Wick
On Tue, Jun 6, 2023 at 6:19 PM Joshua Ashton wrote: > > > > On 6/1/23 20:17, Harry Wentland wrote: > > > > > > On 5/23/23 18:14, Melissa Wen wrote: > >> Hook up driver-specific atomic operations for managing AMD color > >> properties and create AMD driver-specific color management properties > >>

Re: [PATCH RFC v5 01/10] drm: Introduce pixel_source DRM plane property

2023-08-08 Thread Sebastian Wick
On Mon, Aug 7, 2023 at 7:52 PM Jessica Zhang wrote: > > > > On 8/4/2023 6:15 AM, Sebastian Wick wrote: > > On Fri, Jul 28, 2023 at 7:03 PM Jessica Zhang > > wrote: > >> > >> Add support for pixel_source property to drm_plane and related > >>

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

2023-08-08 Thread Sebastian Wick
On Fri, Aug 4, 2023 at 3:03 PM Daniel Vetter wrote: > > On Tue, Jun 27, 2023 at 10:23:23AM -0300, André Almeida wrote: > > Create a section that specifies how to deal with DRM device resets for > > kernel and userspace drivers. > > > > Acked-by: Pekka Paalanen > > Signed-off-by: André Almeida >

Re: [PATCH v6 5/6] drm: Refuse to async flip with atomic prop changes

2023-08-22 Thread Sebastian Wick
On Tue, Aug 15, 2023 at 03:57:09PM -0300, André Almeida wrote: > Given that prop changes may lead to modesetting, which would defeat the > fast path of the async flip, refuse any atomic prop change for async > flips in atomic API. The only exceptions are the framebuffer ID to flip > to and the mode

Re: [PATCH v7] drm/doc: Document DRM device reset expectations

2023-08-22 Thread Sebastian Wick
EVICE_LOST`` for submissions. > +This error code means, among other things, that a device reset has happened > and > +it needs to recreate the contexts to keep going. > + > +Reporting causes of resets > +-- > + > +Apart from propagating the

Re: [PATCH v4 1/6] drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits

2023-07-04 Thread Sebastian Wick
On Sat, Jul 1, 2023 at 4:09 AM André Almeida wrote: > > From: Simon Ser > > If the driver supports it, allow user-space to supply the > DRM_MODE_PAGE_FLIP_ASYNC flag to request an async page-flip. > Set drm_crtc_state.async_flip accordingly. > > Document that drivers will reject atomic commits if

Re: [PATCH RFC v6 02/10] drm: Introduce solid fill DRM plane property

2023-08-29 Thread Sebastian Wick
On Mon, Aug 28, 2023 at 05:05:08PM -0700, Jessica Zhang wrote: > Document and add support for solid_fill property to drm_plane. In > addition, add support for setting and getting the values for solid_fill. > > To enable solid fill planes, userspace must assign a property blob to > the "solid_fill"

Re: [PATCH RFC v6 00/10] Support for Solid Fill Planes

2023-08-29 Thread Sebastian Wick
color information would have unecessary overhead that > does not reflect the behavior of the solid fill feature. In addition, > assigning the solid fill blob to FB_ID would require loosening some core > drm_property checks that might cause unwanted side effects elsewhere. The cover lette

Re: [RFC 00/33] Add Support for Plane Color Pipeline

2023-08-30 Thread Sebastian Wick
.@lists.freedesktop.org > > Cc: wayland-de...@lists.freedesktop.org; Ville Syrjala > > ; Pekka Paalanen > > ; > > Simon Ser ; Melissa Wen ; Jonas Ådahl > > ; Sebastian Wick ; Shashank > > Sharma ; Alexander Goins ; > > Naseer Ahmed ; Christopher Braga > > >

Re: [RFC 00/33] Add Support for Plane Color Pipeline

2023-09-05 Thread Sebastian Wick
On Tue, Sep 05, 2023 at 02:33:26PM +0300, Pekka Paalanen wrote: > On Mon, 4 Sep 2023 14:29:56 + > "Shankar, Uma" wrote: > > > > -Original Message- > > > From: Sebastian Wick > > > Sent: Thursday, August 31, 2023 2:46 AM > >

Re: [RFC 00/33] Add Support for Plane Color Pipeline

2023-09-05 Thread Sebastian Wick
On Tue, Sep 05, 2023 at 02:33:04PM +0200, Sebastian Wick wrote: > On Tue, Sep 05, 2023 at 02:33:26PM +0300, Pekka Paalanen wrote: > > On Mon, 4 Sep 2023 14:29:56 + > > "Shankar, Uma" wrote: > > > > > > -Original Message- > > > >

Re: [RFC PATCH 01/10] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-09-08 Thread Sebastian Wick
gt; Cc: Simon Ser > Cc: Harry Wentland > Cc: Melissa Wen > Cc: Jonas Ådahl > Cc: Sebastian Wick > Cc: Shashank Sharma > Cc: Alexander Goins > Cc: Joshua Ashton > Cc: Michel Dänzer > Cc: Aleix Pol > Cc: Xaver Hugl > Cc: Victoria Brekenfeld > Cc: Danie

[PATCH v2] drm/drm_connector: Document Colorspace property variants

2024-03-05 Thread Sebastian Wick
rt * Make it clear that drivers can choose between RGB and YCbCr on their own Signed-off-by: Sebastian Wick --- drivers/gpu/drm/drm_connector.c | 79 + include/drm/drm_connector.h | 8 2 files changed, 61 insertions(+), 26 deletions(-) diff --git a/d

Re: [PATCH v2] drm/drm_connector: Document Colorspace property variants

2024-03-06 Thread Sebastian Wick
On Wed, Mar 06, 2024 at 10:27:21AM +0200, Pekka Paalanen wrote: > On Tue, 5 Mar 2024 14:51:49 +0100 > Sebastian Wick wrote: > > > The initial idea of the Colorspace prop was that this maps 1:1 to > > InfoFrames/SDP but KMS does not give user space enough information nor

Re: [PATCH] drm: Document requirements for driver-specific KMS props in new drivers

2024-03-06 Thread Sebastian Wick
On Wed, Mar 06, 2024 at 03:14:15PM +0100, Maxime Ripard wrote: > Hi, > > On Thu, Feb 29, 2024 at 09:28:31PM +0100, Sebastian Wick wrote: > > When extending support for a driver-specific KMS property to additional > > drivers, we should apply all the requirements for new pr

[PATCH v2] drm: Document requirements for driver-specific KMS props in new drivers

2024-03-11 Thread Sebastian Wick
When extending support for a driver-specific KMS property to additional drivers, we should apply all the requirements for new properties and make sure the semantics are the same and documented. v2: devs of the driver which introduced property shall help and ack Signed-off-by: Sebastian Wick

Re: [PATCH v2] drm/drm_connector: Document Colorspace property variants

2024-03-11 Thread Sebastian Wick
On Thu, Mar 07, 2024 at 10:29:22AM +0200, Pekka Paalanen wrote: > On Wed, 6 Mar 2024 17:42:09 +0100 > Sebastian Wick wrote: > > > On Wed, Mar 06, 2024 at 10:27:21AM +0200, Pekka Paalanen wrote: > > > On Tue, 5 Mar 2024 14:51:49 +0100 > > > Sebastian Wick wr

Re: [RFC PATCH 01/10] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-11 Thread Sebastian Wick
> Cc: Simon Ser > > > Cc: Harry Wentland > > > Cc: Melissa Wen > > > Cc: Jonas Ådahl > > > Cc: Sebastian Wick > > > Cc: Shashank Sharma > > > Cc: Alexander Goins > > > Cc: Joshua Ashton > > > Cc: Michel Dänzer >

Re: [PATCH RFC v6 01/10] drm: Introduce pixel_source DRM plane property

2023-10-19 Thread Sebastian Wick
: > > + * No active pixel source. > > + * Committing with a NONE pixel source will disable the plane. > > + * > > + * "FB": > > + * Framebuffer source set by the "FB_ID" property. > > + * > > * Note that all the property extensions described here apply either to the > > * plane or the CRTC (e.g. for the background color, which currently is not > > * exposed and assumed to be black). > > This UAPI: > Acked-by: Pekka Paalanen Thanks Jessica, same for me Acked-by: Sebastian Wick > > > Thanks, > pq

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-20 Thread Sebastian Wick
patibility" section (Sebastian, Pekka) > > Signed-off-by: Harry Wentland > Cc: Ville Syrjala > Cc: Pekka Paalanen > Cc: Simon Ser > Cc: Harry Wentland > Cc: Melissa Wen > Cc: Jonas Ådahl > Cc: Sebastian Wick > Cc: Shashank Sharma > Cc: Alexander

Re: [PATCH v3 3/9] drm/vc4: hdmi: Add Broadcast RGB property to allow override of RGB range

2023-10-23 Thread Sebastian Wick
Honestly, the less time people spend on this property the better. Lift the Intel one into core and be done with it. We'll hopefully be able to remove it in the not-to-distant future with the new color pipeline API and adding a new property which only sets the connector metadata instead of influenci

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-26 Thread Sebastian Wick
anen wrote: > > > > > On Fri, 20 Oct 2023 11:23:28 -0400 > > > Harry Wentland wrote: > > > > > > > On 2023-10-20 10:57, Pekka Paalanen wrote: > > > > > On Fri, 20 Oct 2023 16:22:56 +0200 > > > > > Sebastian Wick wrote:

Re: [RFC PATCH v2 06/17] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-27 Thread Sebastian Wick
On Fri, Oct 27, 2023 at 10:59:25AM +0200, Michel Dänzer wrote: > On 10/26/23 21:25, Alex Goins wrote: > > On Thu, 26 Oct 2023, Sebastian Wick wrote: > >> On Thu, Oct 26, 2023 at 11:57:47AM +0300, Pekka Paalanen wrote: > >>> On Wed, 25 Oct 2023 15:16:08 -0500

[PATCH v2] drm/drm_connector: Document Colorspace property variants

2024-07-02 Thread Sebastian Wick
rt * Make it clear that drivers can choose between RGB and YCbCr on their own Signed-off-by: Sebastian Wick Reviewed-by: Pekka Paalanen --- drivers/gpu/drm/drm_connector.c | 79 + include/drm/drm_connector.h | 8 2 files changed, 61 insertions(+), 26

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-02 Thread Sebastian Wick
I'm very unhappy about how this has played out. We have a new sysfs property that controls a feature of the display path that has been set to a default(!) which changes the color behavior! This broke color management for everyone who is on a device which supports this feature. What should have be

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-02 Thread Sebastian Wick
On Fri, Aug 2, 2024 at 4:37 PM Harry Wentland wrote: > > On 2024-08-02 09:28, Sebastian Wick wrote: > > I'm very unhappy about how this has played out. > > > > We have a new sysfs property that controls a feature of the display > > path that has been set to a

[PATCH 1/2] Revert "drm/amd/display: Don't register panel_power_savings on OLED panels"

2024-08-06 Thread Sebastian Wick
From: Sebastian Wick This reverts commit 76cb763e6ea62e838ccc8f7a1ea4246d690fccc9. Reverting the panel_power_savings sysfs. See next commit. Signed-off-by: Sebastian Wick --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 29 +++ 1 file changed, 4 insertions(+), 25 deletions

[PATCH 2/2] Revert "drm/amd/display: add panel_power_savings sysfs entry to eDP connectors"

2024-08-06 Thread Sebastian Wick
From: Sebastian Wick This reverts commit 63d0b87213a0ba241b3fcfba3fe7b0aed0cd1cc5. The panel_power_savings sysfs entry can be used to change the displayed colorimetry which breaks color managed setups. The "do not break userspace" rule which was violated here is enough reason to r

Re: [PATCH v4 09/32] drm/amd/display: add plane 3D LUT driver-specific properties

2023-10-06 Thread Sebastian Wick
On Thu, Oct 05, 2023 at 04:15:04PM -0100, Melissa Wen wrote: > Add 3D LUT property for plane color transformations using a 3D lookup > table. 3D LUT allows for highly accurate and complex color > transformations and is suitable to adjust the balance between color > channels. It's also more complex

Re: [PATCH v4 00/32] drm/amd/display: add AMD driver-specific properties for color mgmt

2023-10-06 Thread Sebastian Wick
On Thu, Oct 05, 2023 at 04:14:55PM -0100, Melissa Wen wrote: > Hello, > > Just another iteration for AMD driver-specific color properties. > Basically, addressing comments from the previous version. > > Recap: this series extends the current KMS color management API with AMD > driver-specific pro

  1   2   >