Hi all,
I discovered a bug in either imx_i2c or fsl-edma on the LS1046A where no
data is read in i2c_imx_dma_read except for the last two bytes (which
are not read using DMA). This is perhaps best illustrated with the
following example:
# hexdump -C /sys/bus/nvmem/devices/0-00540/nvmem
[ 308.91
On 9/19/22 6:40 PM, Leo Li wrote:
>
>
>> -Original Message-----
>> From: Sean Anderson
>> Sent: Monday, September 19, 2022 5:24 PM
>> To: Oleksij Rempel ; Pengutronix Kernel Team
>> ; linux-...@vger.kernel.org; linux-arm-kernel
>> ; Vinod Koul ;
On 9/20/22 6:07 AM, Robin Murphy wrote:
> On 2022-09-19 23:24, Sean Anderson wrote:
>> Hi all,
>>
>> I discovered a bug in either imx_i2c or fsl-edma on the LS1046A where no
>> data is read in i2c_imx_dma_read except for the last two bytes (which
>> are not read
On 9/20/22 11:24 AM, Sean Anderson wrote:
>
>
> On 9/20/22 6:07 AM, Robin Murphy wrote:
>> On 2022-09-19 23:24, Sean Anderson wrote:
>>> Hi all,
>>>
>>> I discovered a bug in either imx_i2c or fsl-edma on the LS1046A where no
>>> data is rea
On 9/20/22 11:44 AM, Sean Anderson wrote:
>
>
> On 9/20/22 11:24 AM, Sean Anderson wrote:
>>
>>
>> On 9/20/22 6:07 AM, Robin Murphy wrote:
>>> On 2022-09-19 23:24, Sean Anderson wrote:
>>>> Hi all,
>>>>
>>>> I discover
On 9/20/22 6:49 PM, Leo Li wrote:
>
>
>> -Original Message-----
>> From: Sean Anderson
>> Sent: Tuesday, September 20, 2022 11:21 AM
>> To: Robin Murphy ; Oleksij Rempel
>> ; Pengutronix Kernel Team
>> ; linux-...@vger.kernel.org; li
On 9/20/22 7:05 PM, Sean Anderson wrote:
>
>
> On 9/20/22 6:49 PM, Leo Li wrote:
>>
>>
>>> -Original Message-
>>> From: Sean Anderson
>>> Sent: Tuesday, September 20, 2022 11:21 AM
>>> To: Robin Murphy ; Oleksij Rempel
>
differences in includes.
Signed-off-by: Sean Anderson
---
Changes in v3:
- Include io.h for readl/writel
Changes in v2:
- Use BIT_ULL
drivers/gpu/drm/hisilicon/kirin/Kconfig | 2 +-
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c| 10 +-
drivers/gpu/drm/hisilicon/kirin/dw_dsi_reg.h
use component_compare_of (or an
equivalent).
Changes in v3:
- Rebase onto drm/drm-next
Changes in v2:
- Split off conversion from helper addition
- Rebase onto drm/drm-next
Sean Anderson (3):
component: Add helper for device nodes
iommu/sound: Use component_match_add_of helper
drm: Convert
Convert users of component_match_add_release with component_release_of
and component_compare_of to component_match_add_of.
Signed-off-by: Sean Anderson
Acked-by: Mark Brown
---
Changes in v3:
- Rebase onto drm/drm-next
Changes in v2:
- Split off from helper addition
drivers/iommu
There is a common case where component_patch_add_release is called with
component_release_of/component_compare_of and a device node. Add a
helper.
Signed-off-by: Sean Anderson
---
(no changes since v2)
Changes in v2:
- Split off conversion from helper addition
include/linux/component.h | 9
Every user of this function either uses component_compare_of or
something equivalent. Most of them immediately put the device node as
well. Convert these users to component_match_add_of and remove
drm_of_component_match_add.
Signed-off-by: Sean Anderson
Acked-by: Jyri Sarha
Tested-by: Jyri
There is a common case where component_patch_add_release is called with
component_release_of/component_compare_of and a device node. Add a
helper and convert existing users.
Signed-off-by: Sean Anderson
---
drivers/iommu/mtk_iommu.c| 3 +--
drivers/iommu/mtk_iommu_v1.c | 3 +--
include
use component_compare_of (or an
equivalent).
I can split the second commit up if that is easier to review.
Sean Anderson (2):
component: Add helper for device nodes
drm: Convert users of drm_of_component_match_add to
component_match_add_of
.../gpu/drm/arm/display/komeda/komeda_drv.c
Every user of this function either uses component_compare_of or
something equivalent. Most of them immediately put the device node as
well. Convert these users to component_match_add_of and remove
drm_of_component_match_add.
Signed-off-by: Sean Anderson
---
.../gpu/drm/arm/display/komeda
On 11/3/22 14:22, Sean Anderson wrote:
> This series adds a new function component_match_add_of to simplify the
> common case of calling component_match_add_release with
> component_release_of and component_compare_of. There is already
> drm_of_component_match_add, which allows
Hi Robin,
On 12/16/22 12:41, Robin Murphy wrote:
> On 2022-12-16 17:08, Sean Anderson wrote:
>> On 11/3/22 14:22, Sean Anderson wrote:
>>> This series adds a new function component_match_add_of to simplify the
>>> common case of calling component_match_add_release wi
Use macros for 64-bit operations. This allows compile-testing this
driver on 32-bit arches, so enable it.
Signed-off-by: Sean Anderson
---
drivers/gpu/drm/hisilicon/kirin/Kconfig | 2 +-
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 10 +-
2 files changed, 6 insertions(+), 6
use component_compare_of (or an
equivalent).
Changes in v2:
- Split off conversion from helper addition
- Rebased onto drm/drm-next
Sean Anderson (3):
component: Add helper for device nodes
iommu/sound: Use component_match_add_of helper
drm: Convert users of drm_of_component_match_add to
There is a common case where component_patch_add_release is called with
component_release_of/component_compare_of and a device node. Add a
helper.
Signed-off-by: Sean Anderson
---
Changes in v2:
- Split off conversion from helper addition
include/linux/component.h | 9 +
1 file
Convert users of component_match_add_release with component_release_of
and component_compare_of to component_match_add_of.
Signed-off-by: Sean Anderson
Acked-by: Mark Brown
---
Changes in v2:
- Split off from helper addition
drivers/iommu/mtk_iommu.c| 3 +--
drivers/iommu/mtk_iommu_v1.c
Every user of this function either uses component_compare_of or
something equivalent. Most of them immediately put the device node as
well. Convert these users to component_match_add_of and remove
drm_of_component_match_add.
Signed-off-by: Sean Anderson
Acked-by: Jyri Sarha
Tested-by: Jyri
Use macros for 64-bit divisions and shifts. This allows compile-testing
this driver on 32-bit arches, so enable it.
Signed-off-by: Sean Anderson
---
Changes in v2:
- Use BIT_ULL
drivers/gpu/drm/hisilicon/kirin/Kconfig | 2 +-
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c| 10
On 1/3/23 11:15, Maxime Ripard wrote:
> Hi Robin,
>
> On Tue, Jan 03, 2023 at 01:01:07PM +, Robin Murphy wrote:
>> Hi Sean,
>>
>> On 22/12/2022 11:37 pm, Sean Anderson wrote:
>> > Convert users of component_match_add_release with component_release
led at (110): []
srcu_invoke_callbacks+0x158/0x23c
[ 19.432614] ---[ end trace ]---
Fixes: eb2d64bfcc17 ("drm: xlnx: zynqmp_dpsub: Report HPD through the bridge")
Signed-off-by: Sean Anderson
---
drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 6 ++
1 file changed, 2 ins
This series adds debugfs support for the zynqmp_dp driver. The intent is
to enable compliance testing or to help debug signal-integrity issues.
The first three patches are general improvements (and could be applied
independently), while the last three add debugfs support.
Sean Anderson (6
Enable this message for verbose debugging only as it is otherwise
printed after every AUX message, quickly filling the log buffer.
Signed-off-by: Sean Anderson
---
drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xlnx
In preparation for supporting compliance testing, split off several
helper functions. No functional change intended.
Signed-off-by: Sean Anderson
---
drivers/gpu/drm/xlnx/zynqmp_dp.c | 49 +---
1 file changed, 33 insertions(+), 16 deletions(-)
diff --git a/drivers
The feedback we get from the DPRX is per-lane. Make changes using this
information, instead of picking the maximum values from all lanes. This
results in more-consistent training on marginal links.
Signed-off-by: Sean Anderson
---
drivers/gpu/drm/xlnx/zynqmp_dp.c | 23
would be fairly easy to add.
Signed-off-by: Sean Anderson
---
drivers/gpu/drm/xlnx/zynqmp_dp.c | 591 ++-
1 file changed, 590 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
index 040f7b88ee51
Add some locking, since none is provided by the drm subsystem. This will
prevent the IRQ/workers/bridge API calls from stepping on each other's
toes.
Signed-off-by: Sean Anderson
---
drivers/gpu/drm/xlnx/zynqmp_dp.c | 59 +++-
1 file changed, 42 insertions(+
When testing, it's convenient to be able to ignore DPCD errors if there
is test equipment which can't emulate a DPRX connected to the output.
Add some (currently-unused) options to ignore these errors and just
reconfigure our internal registers as we usually would.
Signed-off-by: Sea
kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:
> https://github.com/intel-lab-lkp/linux/commits/Sean-Anderson/drm-zynqmp_dp-Downgrade-log-level-
kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:
> https://github.com/intel-lab-lkp/linux/commits/Sean-Anderson/drm-zynqmp_dp-Downgrade-log-level-
is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:
> https://github.com/intel-lab-lkp/linux/commits/Sean-Anderson/
On 3/16/24 13:56, Dmitry Baryshkov wrote:
> On Sat, 16 Mar 2024 at 01:09, Sean Anderson wrote:
>>
>> Add a debugfs interface for exercising the various test modes supported
>> by the DisplayPort controller. This allows performing compliance
>> testing, or performing si
On 3/18/24 13:16, Laurent Pinchart wrote:
> Hi Sean,
>
> Thank you for the patch.
>
> On Fri, Mar 15, 2024 at 07:09:13PM -0400, Sean Anderson wrote:
>> Add some locking, since none is provided by the drm subsystem. This will
>
> That's not quite right,
On 3/18/24 13:59, Laurent Pinchart wrote:
> Hi Sean,
>
> On Mon, Mar 18, 2024 at 01:29:12PM -0400, Sean Anderson wrote:
>> On 3/18/24 13:16, Laurent Pinchart wrote:
>> > On Fri, Mar 15, 2024 at 07:09:13PM -0400, Sean Anderson wrote:
>> >> Add some lockin
On 3/18/24 13:47, Laurent Pinchart wrote:
> Hi Sean,
>
> Thank you for the patch.
>
> On Fri, Mar 15, 2024 at 07:09:15PM -0400, Sean Anderson wrote:
>> When testing, it's convenient to be able to ignore DPCD errors if there
>> is test equipment which can't e
On 3/18/24 13:50, Laurent Pinchart wrote:
> On Mon, Mar 18, 2024 at 11:06:40AM -0400, Sean Anderson wrote:
>> On 3/16/24 06:14, kernel test robot wrote:
>> > Hi Sean,
>> >
>> > kernel test robot noticed the following build warnings:
>> >
>> >
Fix a few errors in the kerneldoc. Mostly this addresses missing/renamed
members.
Signed-off-by: Sean Anderson
---
Changes in v2:
- New
drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 +++---
drivers/gpu/drm/xlnx/zynqmp_dpsub.h | 1 +
drivers/gpu/drm/xlnx/zynqmp_kms.h | 4 ++--
3 files changed, 6
Enable this message for verbose debugging only as it is otherwise
printed after every AUX message, quickly filling the log buffer.
Signed-off-by: Sean Anderson
Reviewed-by: Laurent Pinchart
---
(no changes since v1)
drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
1 file changed, 1 insertion(+), 1
The feedback we get from the DPRX is per-lane. Make changes using this
information, instead of picking the maximum values from all lanes. This
results in more-consistent training on marginal links.
Signed-off-by: Sean Anderson
---
(no changes since v1)
drivers/gpu/drm/xlnx/zynqmp_dp.c | 23
unreproducable, spurious build warning
- Drop "Optionally ignore DPCD errors" in favor of a debugfs file
directly affecting zynqmp_dp_aux_transfer.
Sean Anderson (8):
drm: xlnx: Fix kerneldoc
drm: zynqmp_dp: Downgrade log level for aux retries message
drm: zynqmp_dp: Adjust training value
In preparation for supporting compliance testing, split off several
helper functions. No functional change intended.
Signed-off-by: Sean Anderson
Reviewed-by: Laurent Pinchart
---
(no changes since v1)
drivers/gpu/drm/xlnx/zynqmp_dp.c | 49 ++--
1 file changed, 34
Sort the members of struct zynqmp_dp to reduce padding necessary for
alignment.
Signed-off-by: Sean Anderson
---
Changes in v2:
- New
drivers/gpu/drm/xlnx/zynqmp_dp.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/xlnx
Retraining the link can take a while, and might involve waiting for
DPCD reads/writes to complete. This is inappropriate for an IRQ handler.
Just schedule this work for later completion. This is racy, but will be
fixed in the next commit.
Signed-off-by: Sean Anderson
---
Actually, on second look
would be fairly easy to add.
Additionally, add some debugfs files for ignoring AUX errors and HPD
events, as this can allow testing with equipment that cannot emulate a
DPRX.
Signed-off-by: Sean Anderson
---
Changes in v2:
- Document debugfs files
- Add ignore_aux_errors and ignore_hpd debugfs
uration changes so we don't have to
do anything tricky. Configuration should never be in the hot path, so I'm
not worried about performance.
Signed-off-by: Sean Anderson
---
Changes in v2:
- Split off the HPD IRQ work into another commit
- Expand the commit message
drivers/gpu/
On 3/19/24 18:51, Sean Anderson wrote:
> This series adds debugfs support for the zynqmp_dp driver. The intent is
> to enable compliance testing or to help debug signal-integrity issues.
>
> The first four patches are general improvements (and could be applied
> independently),
On 3/20/24 02:05, Randy Dunlap wrote:
>
>
> On 3/19/24 22:42, Tomi Valkeinen wrote:
>> On 20/03/2024 00:51, Sean Anderson wrote:
>>> Fix a few errors in the kerneldoc. Mostly this addresses missing/renamed
>>> members.
>>>
>>> Signed-o
On 3/20/24 01:57, Tomi Valkeinen wrote:
> On 20/03/2024 00:51, Sean Anderson wrote:
>> The feedback we get from the DPRX is per-lane. Make changes using this
>> information, instead of picking the maximum values from all lanes. This
>> results in more-consistent train
On 3/20/24 02:14, Tomi Valkeinen wrote:
> On 20/03/2024 00:51, Sean Anderson wrote:
>> Sort the members of struct zynqmp_dp to reduce padding necessary for
>> alignment.
>>
>> Signed-off-by: Sean Anderson
>> ---
>>
>> Changes in v2:
>>
On 3/20/24 02:53, Tomi Valkeinen wrote:
> On 20/03/2024 00:51, Sean Anderson wrote:
>> Retraining the link can take a while, and might involve waiting for
>> DPCD reads/writes to complete. This is inappropriate for an IRQ handler.
>> Just schedule this work for later completi
On 3/20/24 03:49, Tomi Valkeinen wrote:
> On 20/03/2024 00:51, Sean Anderson wrote:
>
>> +/**
>> + * enum test_pattern - Test patterns for test testing
>
> "for test testing"? =)
>
>> @@ -1655,6 +2321,9 @@ static void zynqmp_dp_hpd_irq_work_func(struc
On 3/21/24 12:31, Tomi Valkeinen wrote:
> On 21/03/2024 18:08, Sean Anderson wrote:
>> On 3/20/24 03:49, Tomi Valkeinen wrote:
>>> On 20/03/2024 00:51, Sean Anderson wrote:
>>>
>>>> +/**
>>>> + * enum test_pattern - Test patterns for test testing
On 3/21/24 13:25, Tomi Valkeinen wrote:
> On 21/03/2024 17:52, Sean Anderson wrote:
>> On 3/20/24 02:53, Tomi Valkeinen wrote:
>>> On 20/03/2024 00:51, Sean Anderson wrote:
>>>> Retraining the link can take a while, and might involve waiting for
>>>&
On 3/21/24 15:08, Tomi Valkeinen wrote:
> On 21/03/2024 20:01, Sean Anderson wrote:
>> On 3/21/24 13:25, Tomi Valkeinen wrote:
>>> On 21/03/2024 17:52, Sean Anderson wrote:
>>>> On 3/20/24 02:53, Tomi Valkeinen wrote:
>>>>> On 20/03/2024 00:51, Sean A
On 3/22/24 01:50, Tomi Valkeinen wrote:
> On 21/03/2024 17:33, Sean Anderson wrote:
>> On 3/20/24 02:05, Randy Dunlap wrote:
>>>
>>>
>>> On 3/19/24 22:42, Tomi Valkeinen wrote:
>>>> On 20/03/2024 00:51, Sean Anderson wrote:
>>>>> F
On 3/22/24 01:32, Tomi Valkeinen wrote:
> On 21/03/2024 21:17, Sean Anderson wrote:
>> On 3/21/24 15:08, Tomi Valkeinen wrote:
>>> On 21/03/2024 20:01, Sean Anderson wrote:
>>>> On 3/21/24 13:25, Tomi Valkeinen wrote:
>>>>> On 21/03/2024 17:52, Sean
On 3/22/24 14:09, Tomi Valkeinen wrote:
> On 22/03/2024 18:18, Sean Anderson wrote:
>> On 3/22/24 01:32, Tomi Valkeinen wrote:
>>> On 21/03/2024 21:17, Sean Anderson wrote:
>>>> On 3/21/24 15:08, Tomi Valkeinen wrote:
>>>>> On 21/03/2024 20:01, Sean
On 8/8/24 08:46, Tomi Valkeinen wrote:
> Hi Sean,
>
> On 17/06/2024 17:48, Sean Anderson wrote:
>> On 6/17/24 03:47, Tomi Valkeinen wrote:
>>> Hi Sean,
>>>
>>> On 03/05/2024 22:29, Sean Anderson wrote:
>>>> This series cleans up the zyqnmp_d
oducable, spurious build warning
- Drop "Optionally ignore DPCD errors" in favor of a debugfs file
directly affecting zynqmp_dp_aux_transfer.
Sean Anderson (8):
drm: zynqmp_kms: Unplug DRM device before removal
drm: zynqmp_dp: Add locking
drm: zynqmp_dp: Don't retrain th
for Xilinx ZynqMP DisplayPort
Subsystem")
Closes:
https://lore.kernel.org/dri-devel/4d8f4c9b-2efb-4774-9a37-2f257f79b...@linux.dev/
Signed-off-by: Sean Anderson
---
Thanks to Maxime for pointing out the correct function to use here.
Changes in v6:
- New
drivers/gpu/drm/xlnx/zynqmp_kms.c
uration changes so we don't have to
do anything tricky. Configuration should never be in the hot path, so I'm
not worried about performance.
Signed-off-by: Sean Anderson
---
(no changes since v2)
Changes in v2:
- Split off the HPD IRQ work into another commit
- Expand the commit messa
Retraining the link can take a while, and might involve waiting for
DPCD reads/writes to complete. In preparation for unthreading the IRQ
handler, move this into its own work function.
Signed-off-by: Sean Anderson
---
(no changes since v2)
Changes in v2:
- Document hpd_irq_work
- Split this
Now that all of the sleeping work is done outside of the IRQ, we can
convert it to a hard IRQ. Shared IRQs may be triggered even after
calling disable_irq, so use free_irq instead which removes our callback
altogether.
Signed-off-by: Sean Anderson
---
Changes in v6:
- Fix hang upon driver
Instead of polling the status register for the AUX status, just enable
the IRQs and signal a completion.
Signed-off-by: Sean Anderson
---
(no changes since v3)
Changes in v3:
- New
drivers/gpu/drm/xlnx/zynqmp_dp.c | 35 +++-
1 file changed, 25 insertions(+), 10
In preparation for supporting compliance testing, split off several
helper functions. No functional change intended.
Signed-off-by: Sean Anderson
Reviewed-by: Laurent Pinchart
Reviewed-by: Tomi Valkeinen
---
(no changes since v1)
drivers/gpu/drm/xlnx/zynqmp_dp.c | 49
Add a non-locking version of zynqmp_dp_bridge_detect and use it in
zynqmp_dp_hpd_work_func so we can take the lock explicitly. This will
make it easier to check for hpd_ignore when we add debugfs support.
Signed-off-by: Sean Anderson
---
(no changes since v3)
Changes in v3:
- New
drivers/gpu
would be fairly easy to add.
Additionally, add some debugfs files for ignoring AUX errors and HPD
events, as this can allow testing with equipment that cannot emulate a
DPRX.
Signed-off-by: Sean Anderson
---
(no changes since v2)
Changes in v2:
- Document debugfs files
- Add ignore_aux_errors
+ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> @@ -269,6 +269,7 @@ static int zynqmp_dpsub_probe(struct platform_device
> *pdev)
> return 0;
>
> err_disp:
> + drm_bridge_remove(dpsub->bridge);
> zynqmp_disp_remove(dpsub);
> err_dp:
> zynqmp_dp_remove(dpsub);
Reviewed-by: Sean Anderson
On 6/17/24 03:47, Tomi Valkeinen wrote:
> Hi Sean,
>
> On 03/05/2024 22:29, Sean Anderson wrote:
>> This series cleans up the zyqnmp_dp IRQ and locking situation. Once
>> that's done, it adds debugfs support. The intent is to enable compliance
>> testing or to he
The blend, avbuf, and audio members of zynqmp_disp are anonymous structs
with only one member each. This is rather pointless, so move the members
up a level.
Signed-off-by: Sean Anderson
---
Changes in v3:
- New
drivers/gpu/drm/xlnx/zynqmp_disp.c | 44 +-
1 file
Fix a few errors in the kerneldoc. Mostly this addresses missing/renamed
members.
Signed-off-by: Sean Anderson
---
Changes in v3:
- Split off documentation for base pointers to previous commit
Changes in v2:
- New
drivers/gpu/drm/xlnx/zynqmp_dpsub.h | 1 +
drivers/gpu/drm/xlnx/zynqmp_kms.h
favor of a debugfs file
directly affecting zynqmp_dp_aux_transfer.
Sean Anderson (13):
drm: xlnx: Store base pointers in zynqmp_disp directly
drm: xlnx: Fix kerneldoc
drm: zynqmp_dp: Downgrade log level for aux retries message
drm: zynqmp_dp: Adjust training values per-lane
drm: zynqmp_dp:
Enable this message for verbose debugging only as it is otherwise
printed after every AUX message, quickly filling the log buffer.
Signed-off-by: Sean Anderson
Reviewed-by: Laurent Pinchart
Reviewed-by: Tomi Valkeinen
---
(no changes since v1)
drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
1 file
Retraining the link can take a while, and might involve waiting for
DPCD reads/writes to complete. In preparation for unthreading the IRQ
handler, move this into its own work function.
Signed-off-by: Sean Anderson
---
(no changes since v2)
Changes in v2:
- Document hpd_irq_work
- Split this
The feedback we get from the DPRX is per-lane. Make changes using this
information, instead of picking the maximum values from all lanes. This
results in more-consistent training on marginal links.
Signed-off-by: Sean Anderson
Reviewed-by: Tomi Valkeinen
---
(no changes since v1)
drivers/gpu
Now that all of the sleeping work is done outside of the IRQ, we can
convert it to a hard IRQ.
Signed-off-by: Sean Anderson
---
Changes in v3:
- New
drivers/gpu/drm/xlnx/zynqmp_dp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b
uration changes so we don't have to
do anything tricky. Configuration should never be in the hot path, so I'm
not worried about performance.
Signed-off-by: Sean Anderson
---
(no changes since v2)
Changes in v2:
- Split off the HPD IRQ work into another commit
- Expand the commit messa
Sort the members of struct zynqmp_dp to reduce padding necessary for
alignment.
Signed-off-by: Sean Anderson
---
(no changes since v2)
Changes in v2:
- New
drivers/gpu/drm/xlnx/zynqmp_dp.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a
would be fairly easy to add.
Additionally, add some debugfs files for ignoring AUX errors and HPD
events, as this can allow testing with equipment that cannot emulate a
DPRX.
Signed-off-by: Sean Anderson
---
(no changes since v2)
Changes in v2:
- Document debugfs files
- Add ignore_aux_errors
In preparation for supporting compliance testing, split off several
helper functions. No functional change intended.
Signed-off-by: Sean Anderson
Reviewed-by: Laurent Pinchart
Reviewed-by: Tomi Valkeinen
---
(no changes since v1)
drivers/gpu/drm/xlnx/zynqmp_dp.c | 49
Instead of polling the status register for the AUX status, just enable
the IRQs and signal a completion.
Signed-off-by: Sean Anderson
---
Changes in v3:
- New
drivers/gpu/drm/xlnx/zynqmp_dp.c | 35 +++-
1 file changed, 25 insertions(+), 10 deletions(-)
diff --git
We always call scheduled_delayed_work with no delay, so just use a
non-delayed work_struct instead.
Signed-off-by: Sean Anderson
---
Changes in v3:
- New
drivers/gpu/drm/xlnx/zynqmp_dp.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/xlnx
Add a non-locking version of zynqmp_dp_bridge_detect and use it in
zynqmp_dp_hpd_work_func so we can take the lock explicitly. This will
make it easier to check for hpd_ignore when we add debugfs support.
Signed-off-by: Sean Anderson
---
Changes in v3:
- New
drivers/gpu/drm/xlnx/zynqmp_dp.c
On 4/22/24 14:45, Sean Anderson wrote:
> This series cleans up the zyqnmp_dp IRQ and locking situation. Once
> that's done, it adds debugfs support. The intent is to enable compliance
> testing or to help debug signal-integrity issues.
>
> Last time I discussed converting
On 4/23/24 09:33, Tomi Valkeinen wrote:
> Hi Sean,
>
> On 22/04/2024 21:45, Sean Anderson wrote:
>> This series cleans up the zyqnmp_dp IRQ and locking situation. Once
>> that's done, it adds debugfs support. The intent is to enable compliance
>> testing or to he
On 4/23/24 11:30, Tomi Valkeinen wrote:
> On 23/04/2024 17:59, Sean Anderson wrote:
>> On 4/23/24 09:33, Tomi Valkeinen wrote:
>>> Hi Sean,
>>>
>>> On 22/04/2024 21:45, Sean Anderson wrote:
>>>> This series cleans up the zyqnmp_dp IRQ and locking s
Enable this message for verbose debugging only as it is otherwise
printed after every AUX message, quickly filling the log buffer.
Signed-off-by: Sean Anderson
Reviewed-by: Laurent Pinchart
Reviewed-by: Tomi Valkeinen
---
(no changes since v1)
drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
1 file
The blend, avbuf, and audio members of zynqmp_disp are anonymous structs
with only one member each. This is rather pointless, so move the members
up a level.
Signed-off-by: Sean Anderson
Reviewed-by: Tomi Valkeinen
---
(no changes since v3)
Changes in v3:
- New
drivers/gpu/drm/xlnx
The feedback we get from the DPRX is per-lane. Make changes using this
information, instead of picking the maximum values from all lanes. This
results in more-consistent training on marginal links.
Signed-off-by: Sean Anderson
Reviewed-by: Tomi Valkeinen
---
(no changes since v1)
drivers/gpu
We always call scheduled_delayed_work with no delay, so just use a
non-delayed work_struct instead.
Signed-off-by: Sean Anderson
Reviewed-by: Tomi Valkeinen
---
(no changes since v3)
Changes in v3:
- New
drivers/gpu/drm/xlnx/zynqmp_dp.c | 13 ++---
1 file changed, 6 insertions(+), 7
uration changes so we don't have to
do anything tricky. Configuration should never be in the hot path, so I'm
not worried about performance.
Signed-off-by: Sean Anderson
---
(no changes since v2)
Changes in v2:
- Split off the HPD IRQ work into another commit
- Expand the commit messa
In preparation for supporting compliance testing, split off several
helper functions. No functional change intended.
Signed-off-by: Sean Anderson
Reviewed-by: Laurent Pinchart
Reviewed-by: Tomi Valkeinen
---
(no changes since v1)
drivers/gpu/drm/xlnx/zynqmp_dp.c | 49
Fix a few errors in the kerneldoc. Mostly this addresses missing/renamed
members.
Signed-off-by: Sean Anderson
Reviewed-by: Tomi Valkeinen
---
(no changes since v3)
Changes in v3:
- Split off documentation for base pointers to previous commit
Changes in v2:
- New
drivers/gpu/drm/xlnx
Retraining the link can take a while, and might involve waiting for
DPCD reads/writes to complete. In preparation for unthreading the IRQ
handler, move this into its own work function.
Signed-off-by: Sean Anderson
---
(no changes since v2)
Changes in v2:
- Document hpd_irq_work
- Split this
Instead of polling the status register for the AUX status, just enable
the IRQs and signal a completion.
Signed-off-by: Sean Anderson
---
(no changes since v3)
Changes in v3:
- New
drivers/gpu/drm/xlnx/zynqmp_dp.c | 35 +++-
1 file changed, 25 insertions(+), 10
Now that all of the sleeping work is done outside of the IRQ, we can
convert it to a hard IRQ.
Signed-off-by: Sean Anderson
---
(no changes since v3)
Changes in v3:
- New
drivers/gpu/drm/xlnx/zynqmp_dp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm
1 - 100 of 139 matches
Mail list logo
