Re: [PATCH 3/4] drm: Extend color correction to support 3D-CLU

Hi Laurent and Kieran, Do you forget to attach cubic_lut_property with crtc? drm_object_attach_property(&crtc->base, config->cubic_lut_property, cubic_lut_size); 在 2020/12/21 9:57, Laurent Pinchart 写道: From: Kieran Bingham Extend the existing color management properties to support provision

Re: [PATCH 3/4] drm: Extend color correction to support 3D-CLU

*/ + struct drm_property *cubic_lut_size_property; + /** * @suggested_x_property: Optional connector property with a hint for * the position of the output on the host's screen. -- Sandy Huang Rockchip ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/1] drm: drm_fourcc: add NV20 and NV30 format

' and '30' suffix refers to the optimum effective bits per pixel which is achieved. Signed-off-by: Sandy Huang Change-Id: I84da7e03125e675f274c6307128b4b7b307767cc --- drivers/gpu/drm/drm_fourcc.c | 8 include/uapi/drm/drm_fourcc.h | 2 ++ 2 files changed, 10 inserti

[PATCH] drm/rockchip: rgb: update SPDX license identifier

update SPDX License Identifier from GPL-2.0+ to GPL-2.0 and drop some GPL text. Signed-off-by: Sandy Huang --- drivers/gpu/drm/rockchip/rockchip_rgb.c | 11 +-- drivers/gpu/drm/rockchip/rockchip_rgb.h | 11 +-- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a

Re: [PATCHv7 6/6] drm/rockchip: Add support for afbc

Hi Emil, 在 2020/3/16 下午10:10, Emil Velikov 写道: On Wed, 11 Mar 2020 at 14:56, Andrzej Pietrasiewicz wrote: This patch adds support for afbc handling. afbc is a compressed format which reduces the necessary memory bandwidth. Co-developed-by: Mark Yao Signed-off-by: Mark Yao Signed-off-by: And

Re: [PATCHv7 6/6] drm/rockchip: Add support for afbc

Hi Andrzej , 在 2020/3/19 下午5:54, Andrzej Pietrasiewicz 写道: Hi Sandy, W dniu 19.03.2020 o 03:57, Sandy Huang pisze: Hi Emil, -- 2.17.1 Heiko, Sandy, being the maintainers of the Rockchip driver, can you review/ack this patch? I believe the intention is to merge the series via drm

[PATCH 10/36] drm/arm: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c | 2 +- drivers/gpu/drm/arm/malidp_hw.c | 2 +- drivers/gpu/dr

[PATCH 05/36] drm/sun4i: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 2 +- drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 07/36] drm/gma500: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/gma500/framebuffer.c | 4 ++-- drivers/gpu/drm/gma500/gma_display.c | 4 ++-- drivers/gpu/drm/gma500/mdfld_intel_disp

[PATCH 03/36] drm/i915: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 2 +- drivers/gpu/drm/i915/display/intel_display.c | 28 +++ drivers/gp

[PATCH 02/36] drm/rockchip: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 2 +- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- 2 files changed, 3 insertions(+), 3 dele

[PATCH 01/36] drm/fourcc: Add 2 plane YCbCr 10bit format support

The drm_format_info.cpp[3] unit is BytePerPlane, when we add define 10bit YUV format, here have some problem. So we change cpp to bpp, use unit BitPerPlane to describe the data format. Signed-off-by: Sandy Huang --- drivers/gpu/drm/drm_client.c| 4 +- drivers/gpu/drm/drm_fb_helper.c

[PATCH 04/36] drm: exynos: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 4 ++-- drivers/gpu/drm/exynos/exynos7_drm_decon.c| 6 +++--- drivers/gpu/drm/exynos/exynos_drm_fb

[PATCH 08/36] drm/msm: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 4 ++-- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 2 +- drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c

[PATCH 06/36] drm/amd: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c| 2 +- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c| 2 +- drivers/gpu/drm/amd/amdgpu/dce_v1

[PATCH 18/36] drm/xen: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/xen/xen_drm_front_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xen/xen_drm_front_kms

[PATCH 16/36] drm/tilcdc: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- drivers/gpu/drm/tilcdc/tilcdc_plane.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 19/36] drm/vkms: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/vkms/vkms_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gp

[PATCH 20/36] drm/ast: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/ast/ast_mode.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gp

[PATCH 17/36] drm/zte: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/zte/zx_plane.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_plane.c b/drivers/gpu/dr

[PATCH 09/36] dm/vmwgfx: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 4 ++-- driver

[PATCH 00/36] Add support 10bit yuv format

This series of patches is to add 2 plane YCbCr 10bit format support, but now the drm_format_info.cpp[3] unit is BytePerPlane, when we add define 10bit YUV format, here have some problems. So we change cpp to bpp, use unit BitPerPlane to describe the data format. Sandy Huang (36): drm/fourcc

[PATCH 10/36] drm/arm: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c | 2 +- drivers/gpu/drm/arm/malidp_hw.c | 2 +- drivers/gpu/dr

[PATCH 22/36] drm/atmel-hlcdc: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/atmel-

[PATCH 21/36] drm/vc4: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/vc4/vc4_plane.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/dr

[PATCH 24/36] drm/hisilicon: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/

[PATCH 25/36] drm/imx: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/imx/ipuv3-plane.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/dr

[PATCH 23/36] drm/cirrus: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/cirrus/cirrus.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/cirrus/cirrus.c b/dr

[PATCH 27/36] drm/pl111: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/pl111/pl111_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/dr

[PATCH 29/36] drm/ingenic: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/ingenic/ingenic-drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/dr

[PATCH 26/36] drm/vboxvideo: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/vboxvideo/vbox_mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vboxvideo/vbox_mode.c b/dr

[PATCH 28/36] drm/qxl: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/qxl/qxl_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_draw.c b/drivers/gpu/dr

[PATCH 30/36] drm/sti: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/sti/sti_gdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/dr

[PATCH 31/36] drm/stm: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/stm/ltdc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/l

[PATCH 32/36] drm/mcde: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/mcde/mcde_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mcde/mcde_display.c b/dr

[PATCH 34/36] drm/tve200: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/tve200/tve200_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tve200/tve200_display

[PATCH 33/36] drm/mgag200: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/mgag200/mgag200_mode.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/mg

[PATCH 35/36] drm/udl: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/udl/udl_fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/dr

[PATCH 36/36] drm/omapdrm: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/omapdrm/omap_fb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_fb.c b/dr

[PATCH 15/36] drm/mediatek: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/mediatek/mtk_drm_fb.c| 2 +- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[PATCH 11/36] drm/armada: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/armada/armada_fbdev.c | 2 +- drivers/gpu/drm/armada/armada_plane.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)

[PATCH 12/36] drm/radeon: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/radeon/atombios_crtc.c | 10 +- drivers/gpu/drm/radeon/r100.c | 4 ++-- drivers/gpu/drm/radeon/radeon_disp

[PATCH 14/36] drm/tegra: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/tegra/dc.c | 2 +- drivers/gpu/drm/tegra/drm.c | 2 +- drivers/gpu/drm/tegra/fb.c | 2 +- 3 files changed, 3 insertions(+), 3 dele

[PATCH 13/36] drm/nouveau: use bpp instead of cpp for drm_format_info

cpp[BytePerPlane] can't describe the 10bit data format correctly, So we use bpp[BitPerPlane] to instead cpp. Signed-off-by: Sandy Huang --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 7 --- drivers/gpu/drm/nouveau/dispnv50/base507c.c | 4 ++-- drivers/gpu/drm/nouveau/dispnv50/ovly5

[PATCH 3/3] drm/rockchip: Add support 10bit yuv format

Add support 10bit yuv format display for rockchip some socs, include: RK3288/RK3228/RK3328/RK3368/RK3399 Signed-off-by: Sandy Huang --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 16 drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 + drivers/gpu/drm/rockchip

[PATCH 1/3] drm: Add some new format DRM_FORMAT_NVXX_10

These new format is supported by some rockchip socs: DRM_FORMAT_NV12_10/DRM_FORMAT_NV21_10 DRM_FORMAT_NV16_10/DRM_FORMAT_NV61_10 DRM_FORMAT_NV24_10/DRM_FORMAT_NV42_10 Signed-off-by: Sandy Huang --- drivers/gpu/drm/drm_fourcc.c | 18 ++ include/uapi/drm/drm_fourcc.h | 14

[PATCH 0/3] Add some yuv 10bit support

:0] Sandy Huang (3): drm: Add some new format DRM_FORMAT_NVXX_10 drm/rockchip: Add vop_format_get_bpp to get format bpp drm/rockchip: Add support 10bit yuv format drivers/gpu/drm/drm_fourcc.c| 18 + drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 42

[PATCH 2/3] drm/rockchip: Add vop_format_get_bpp to get format bpp

For 10bit yuv format, we need to get format bpp each plane, so we Add vop_format_get_bpp() to instead of format->cpp[]; Signed-off-by: Sandy Huang --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --gi

[PATCH v2 1/3] drm: Add some new format DRM_FORMAT_NVXX_10

These new format is supported by some rockchip socs: DRM_FORMAT_NV12_10/DRM_FORMAT_NV21_10 DRM_FORMAT_NV16_10/DRM_FORMAT_NV61_10 DRM_FORMAT_NV24_10/DRM_FORMAT_NV42_10 Signed-off-by: Sandy Huang --- drivers/gpu/drm/drm_fourcc.c | 18 ++ include/uapi/drm/drm_fourcc.h | 14

[PATCH v2 0/3] Add some yuv 10bit support

:10:10:10:10 or index 1 = Cr:Cb plane, Cr3:Cb3:Cr2:Cb2:Cr1:Cb1:Cr0:Cb0 10:10:10:10:10:10:10:10 v2: 1. add describe for new format; 2. use block formats to describe new format; Sandy Huang (3): drm: Add some new format DRM_FORMAT_NVXX_10 drm/rockchip: Add vop_format_get_bpp to get format

[PATCH v2 1/3] drm: Add some new format DRM_FORMAT_NVXX_10

These new format is supported by some rockchip socs: DRM_FORMAT_NV12_10/DRM_FORMAT_NV21_10 DRM_FORMAT_NV16_10/DRM_FORMAT_NV61_10 DRM_FORMAT_NV24_10/DRM_FORMAT_NV42_10 Signed-off-by: Sandy Huang --- drivers/gpu/drm/drm_fourcc.c | 18 ++ include/uapi/drm/drm_fourcc.h | 14

[PATCH v2 3/3] drm/rockchip: Add support 10bit yuv format

Add support 10bit yuv format display for rockchip some socs, include: RK3288/RK3228/RK3328/RK3368/RK3399 Signed-off-by: Sandy Huang --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 16 drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 1 + drivers/gpu/drm/rockchip

[PATCH v2 2/3] drm/rockchip: Add rockchip_vop_get_offset to get offset

Add rockchip_vop_get_offset to get offset, this can compatible legacy and block_h/w format describe. Signed-off-by: Sandy Huang --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 61 - 1 file changed, 52 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 0/3] Add some yuv 10bit support

:10:10:10:10 or index 1 = Cr:Cb plane, Cr3:Cb3:Cr2:Cb2:Cr1:Cb1:Cr0:Cb0 10:10:10:10:10:10:10:10 v2: 1. add describe for new format; 2. use block formats to describe new format; Sandy Huang (3): drm: Add some new format DRM_FORMAT_NVXX_10 drm/rockchip: Add rockchip_vop_get_offset to get

Re: [RFC PATCH 3/4] gpu/drm: Add TinyDRM for DSI/DBI panels

Hi paul,     After add this driver, the followinig usage scenarios can be supported?     panel 1. crtc->encoder->connector[edp/hdmi/mipi dsi] -> panel     panel 2. Panel setup/control and framebuffer upload over SPI     the two panel maybe display same/different conctent at same time. 在 2020

[PATCH v2] drm/of: Consider the state in which the ep is disabled

don't mask possible_crtcs if remote-point is disabled. Signed-off-by: Sandy Huang --- drivers/gpu/drm/drm_of.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c index fdb05fbf72a0..565f05f5f11b 100644 --- a/drivers/gpu/drm/drm_of.c

Re: [PATCH] drm/rockchip: vop: call vop_cfg_done() under reg_lock

Cc: Sandy Huang Cc: Heiko Stübner Signed-off-by: Emil Velikov --- Noticed while skimming through the code and thus untested. --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b

[PATCH] drm/rockchip: vop: fix vop full rgb24 r/b color error

RGB888 format msb is red component and the lsb is blue component, at vop full platform this is swapped, and this is different from vop lite and vop next, so add this patch to fix it. Signed-off-by: Sandy Huang --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 8 1 file changed, 8

[PATCH v2] drm/rockchip: vop: fix vop full rgb24 r/b color error

RGB888 format msb is red component and the lsb is blue component, at vop full platform this is swapped, and this is different from vop lite and vop next, so add this patch to fix it. v2: move to has_rb_swapped() function. Signed-off-by: Sandy Huang --- drivers/gpu/drm/rockchip

[PATCH] drm/of: Consider the state in which the ep is disabled

don't mask possible_crtcs if remote-point is disabled. Signed-off-by: Sandy Huang --- drivers/gpu/drm/drm_of.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c index fdb05fbf72a0..f5f250435add 100644 --- a/drivers/gpu/drm/drm

[PATCH] drm: sysfs: Add to get current mode

add this node to get the current true mode. Signed-off-by: Sandy Huang --- drivers/gpu/drm/drm_sysfs.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index 939f0032aab1..f39bcd34853b 100644 --- a

[PATCH] drm/rockchip: fix coding style and incorrect description

Align with other drivers, tab + 2 space key for description. and this option should be enabled on both rk3288 and rk3399. Signed-off-by: Sandy Huang --- drivers/gpu/drm/rockchip/Kconfig | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/rockchip/Kconfig

[PATCH v2] drm/rockchip: fix coding style and incorrect description

Align with other drivers, tab + 2 space key for description. and edp/hdmi/dsi can be used on both rk3288 and rk3399. Signed-off-by: Sandy Huang --- drivers/gpu/drm/rockchip/Kconfig | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/rockchip

Re: [PATCH] drm/rockchip: fix coding style and incorrect description

Hi enric,     thanks, this will be upated at v2 patch. 在 2018/8/27 15:02, Enric Balletbo Serra 写道: Hi Sandy, Just noticed a typo that I think will be good fix also Missatge de Sandy Huang del dia dl., 27 d’ag. 2018 a les 8:31: > > Align with other drivers, tab + 2 space key for descr

[PATCH v5 2/2] drm/rockchip: Add support for Rockchip Soc RGB output interface

Some Rockchip CRTCs, like rv1108 and px30, can directly output parallel and serial RGB data to panel or conversion chip, so we add this driver to probe encoder and connector. Signed-off-by: Sandy Huang Reviewed-by: Sean Paul Reviewed-by: Mark Yao Link: https://patchwork.freedesktop.org/patch

[PATCH v5 1/2] devicetree/bindings: display: Add document for rockchip RGB output

This path add support rv1108 and px30 rgb output interface driver. Signed-off-by: Sandy Huang Link: https://patchwork.freedesktop.org/patch/msgid/1509522765-118759-1-git-send-email-...@rock-chips.com --- .../bindings/display/rockchip/rockchip-rgb.txt | 70 ++ 1 file

Re: [PATCH v4 1/2] devicetree/bindings: display: Add document for rockchip RGB output

在 2018/8/27 15:11, Heiko Stuebner 写道: Hi Sandy, trying to move this forward a bit :-) Hi heiko, update at version5 and add SPDX-License-Identifier tag. Am Mittwoch, 4. Juli 2018, 14:09:56 CEST schrieb Sandy Huang: > Hi Rob Herring, > Thanks for your review. > > 在 2018/7

[PATCH] drm/rockchip: vop: fix some register define error for px30

1. interrupt register define error lead to enable interrupt failed; 2. px30 unsupport hdmi output; 3. there are some hardware designed bug, we must swap win2 gate and enable offset, otherwise will appear vop iommu pagefault. Signed-off-by: Sandy Huang --- drivers/gpu/drm/rockchip

Re: [PATCH v5 2/2] drm/rockchip: Add support for Rockchip Soc RGB output interface

Hi hieko, 在 2018/8/28 16:31, Heiko Stuebner 写道: Hi Sandy, Am Dienstag, 28. August 2018, 10:12:34 CEST schrieb Sandy Huang: Some Rockchip CRTCs, like rv1108 and px30, can directly output parallel and serial RGB data to panel or conversion chip, so we add this driver to probe encoder and

[PATCH v6 2/3] drm/rockchip: Add support for Rockchip Soc RGB output interface

: Sandy Huang Signed-off-by: Heiko Stuebner Reviewed-by: Sean Paul Reviewed-by: Mark Yao --- Changes in v6: 1. Update according to Heiko Stuebner' implemention, rgb output is part of vop's feature, should not register as a independent driver. Changes in v5: 1. add SP

[PATCH v6 1/3] drm/tockchip: add function to check if endpoint is a subdriver

From: Heiko Stuebner To be able to have both internal subdrivers and external bridge drivers as output endpoints of vops, add a function to be able to distinguish these. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 27 +++ drivers/gpu/

[PATCH v6 3/3] drm/rockchip: Add directly output rgb feature for px30

Add this feature bit indicate px30 vop can directly output parallel or serial rgb data. Signed-off-by: Sandy Huang --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip

[PATCH v6 0/3] Add support rockchip RGB output interface

attach to bridge chips or panels. Heiko Stuebner (1): drm/tockchip: add function to check if endpoint is a subdriver Sandy Huang (2): drm/rockchip: Add support for Rockchip Soc RGB output interface drm/rockchip: Add directly output rgb feature for px30 drivers/gpu/drm/rockchip/Kconfig

[PATCH v7 0/3] Add support rockchip RGB output interface

attach to bridge chips or panels. Heiko Stuebner (1): drm/tockchip: add function to check if endpoint is a subdriver Sandy Huang (2): drm/rockchip: Add support for Rockchip Soc RGB output interface drm/rockchip: Add directly output rgb feature for px30 drivers/gpu/drm/rockchip/Kconfig

[PATCH v7 1/3] drm/tockchip: add function to check if endpoint is a subdriver

From: Heiko Stuebner To be able to have both internal subdrivers and external bridge drivers as output endpoints of vops, add a function to be able to distinguish these. Signed-off-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 27 +++ drivers/gpu/

[PATCH v7 3/3] drm/rockchip: Add directly output rgb feature for px30

Add this feature bit indicate px30 vop can directly output parallel or serial rgb data. Signed-off-by: Sandy Huang --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip

[PATCH v7 2/3] drm/rockchip: Add support for Rockchip Soc RGB output interface

: Sandy Huang Signed-off-by: Heiko Stuebner Reviewed-by: Sean Paul Reviewed-by: Mark Yao --- Changes in v7: 1. forget to delete rockchip_rgb_driver and delete it. Changes in v6: 1. Update according to Heiko Stuebner' implemention, rgb output is part of vop's feature,

Re: [PATCH] drm/rockchip: vop: add rk3188 vop definitions

44 +#define RK3188_WIN1_MST            0x4c +#define RK3188_WIN1_DSP_INFO        0x50 +#define RK3188_WIN1_DSP_ST        0x54 +#define RK3188_DSP_HTOTAL_HS_END    0x6c +#define RK3188_DSP_HACT_ST_END        0x70 +#define RK3188_DSP_VTOTAL_VS_END    0x74 +#define RK3188_DSP_VACT_ST

Re: [PATCH v8 1/3] drm/rockchip: add function to check if endpoint is a subdriver

driver; extern struct platform_driver dw_mipi_dsi_driver; Reviewed-by Sandy Huang ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v4 1/2] devicetree/bindings: display: Add document for rockchip RGB output

This path add support rv1108 and px30 rgb output interface driver. Signed-off-by: Sandy Huang Link: https://patchwork.freedesktop.org/patch/msgid/1509522765-118759-1-git-send-email-...@rock-chips.com --- Changes in v4: Add support px30 Changes in v3: None Changes in v2: None .../bindings

[PATCH v4 0/2] Add support rockchip RGB output interface

This patches add support rockchip RGB output, Some Rockchip CRTCs, like rv1108 and px30 can directly output parallel and serial RGB data to panel or to conversion chip. So we add this driver to probe encoder and connector to support this case. Sandy Huang (2): devicetree/bindings: display: Add

[PATCH v4 2/2] drm/rockchip: Add support for Rockchip Soc RGB output interface

Some Rockchip CRTCs, like rv1108 and px30, can directly output parallel and serial RGB data to panel or conversion chip, so we add this driver to probe encoder and connector. Signed-off-by: Sandy Huang Reviewed-by: Sean Paul Reviewed-by: Mark Yao Link: https://patchwork.freedesktop.org/patch

[PATCH] drm/rockchip: vop: fixup linebuffer mode calc error

linebuffer mode should be LB_YUV_3840X5 when width is bigger than 1280 in yuv mode. seperate yuv and rgb case make the scl_vop_cal_lb_mode() logic is clearer. Signed-off-by: Sandy Huang Link: https://patchwork.freedesktop.org/patch/msgid/1523960108-190541-1-git-send-email-...@rock-chips.com

[PATCH 1/2] dt-bindings: display: rockchip: add document for px30 vop

Signed-off-by: Sandy Huang --- Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt

[PATCH 2/2] drm/rockchip: vop: add px30 vop support

PX30 have vop big and vop lite, just like rk3036 and rk3126 the max input and output resolution is 1920x1080, the main difference between the two vop is: vop big: win0 support yuv and rgb format; win1 and win2 support rgb format; vop lit: win1 support rgb format; Signed-off-by: Sandy

[PATCH 0/2] add support rockchip px30 VOP

The following patches add support rockchip px30 VOP, there are two seperate VOP we call VOP big and VOP lite. vop big support win0,win1 and win2; vop lit support win1(same with vop big win1); the max input and output resolution is 1920x1080. Sandy Huang (2): dt-bindings: display: rockchip

[PATCH 0/2] add support rockchip px30 VOP

The following patches add support rockchip px30 VOP, there are two seperate VOP we call VOP big and VOP lite. vop big support win0,win1 and win2; vop lit support win1(same with vop big win1); the max input and output resolution is 1920x1080. Sandy Huang (2): dt-bindings: display: rockchip

Re: [PATCH v4 1/2] devicetree/bindings: display: Add document for rockchip RGB output

Hi Rob Herring, Thanks for your review. 在 2018/7/4 2:25, Rob Herring 写道: On Tue, Jun 26, 2018 at 03:15:39PM +0800, Sandy Huang wrote: This path add support rv1108 and px30 rgb output interface driver. Bindings are for h/w, not drivers. I will update at next version as following: This patch

Re: [PATCH] drm/rockchip: vop: add rk3188 hs_start interrupt as dsp_hold equivalent

Hi heiko, nice solution. Reviewed-by: Sandy Huang 在 2018/9/23 20:37, Heiko Stuebner 写道: The hs_start interrupt on rk3188 fires at the start of a new frame, so serves essentially the same purpose as the dsp_hold_valid irq in checking when the last frame got delivered when going to standby. So

Re: [PATCH] drm/rockchip: vop: add rk3188 hs_start interrupt as dsp_hold equivalent

Hi heiko, nice solution. Reviewed-by: Sandy Huang 在 2018/9/23 20:37, Heiko Stuebner 写道: The hs_start interrupt on rk3188 fires at the start of a new frame, so serves essentially the same purpose as the dsp_hold_valid irq in checking when the last frame got delivered when going to standby. So

Re: [PATCH 0/2] add support rockchip px30 VOP

Thanks heiko, i am planing to send the next version patch :) 在 2018/8/2 18:40, Heiko Stuebner 写道: Hi Sandy, Am Dienstag, 26. Juni 2018, 10:53:33 CEST schrieb Sandy Huang: > The following patches add support rockchip px30 VOP, there are two seperate > VOP we call VOP big and VOP lite. &

Re: [PATCH] drm/rockchip: fix VOP vblank race

Reviewed-by: Sandy huang 在 2018/3/29 0:03, John Keeping 写道: We have seen a case of a bad reference count for vblanks with the Rockchip VOP: [ cut here ] WARNING: CPU: 1 PID: 383 at drivers/gpu/drm/drm_irq.c:1198 drm_vblank_put+0x40/0xcc Modules

Re: [PATCH] drm/rockchip: fix VOP vblank race

Applied to drm-misc-next. Thanks！ 在 2018/4/17 5:43, Heiko Stuebner 写道: Hi John, Am Montag, 16. April 2018, 18:46:56 CEST schrieb John Keeping: Hi Sandy, On Tue, 10 Apr 2018 20:40:06 +0800, Sandy Huang wrote: Reviewed-by: Sandy huang Thanks for the review, but I don't see this i

[PATCH] drm/rockchip: vop: fixup linebuffer mode calc error

When video width is bigger than 3840 the linebuffer mode should be LB_YUV_3840X5. Signed-off-by: Sandy Huang --- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h b/drivers/gpu/drm

Re: [PATCH] drm/rockchip: vop: fixup linebuffer mode calc error

在 2018/4/17 19:14, Heiko Stuebner 写道: Hi Sandy, Am Dienstag, 17. April 2018, 12:15:07 CEST schrieb Sandy Huang: When video width is bigger than 3840 the linebuffer mode should be LB_YUV_3840X5. Can you explain that a bit better? I.e. when looking at the code, the very first check is width

Re: [PATCH] drm/rockchip: vop: fixup linebuffer mode calc error

在 2018/4/17 19:14, Heiko Stuebner 写道: Hi Sandy, Am Dienstag, 17. April 2018, 12:15:07 CEST schrieb Sandy Huang: When video width is bigger than 3840 the linebuffer mode should be LB_YUV_3840X5. Can you explain that a bit better? I.e. when looking at the code, the very first check is width

Re: [PATCH v2 0/3] Add support rockchip RGB output interface

Do you have any suggests for this series of patches? Or apply to drm-misc-next? 在 2017/9/22 11:00, Sandy Huang 写道: This patches add support rockchip RGB output, Some Rockchip CRTCs, like rv1108, can directly output parallel and serial RGB data to panel or to conversion chip. So we add this

Re: [PATCH v2 1/3] dt-bindings: Add document for rockchip RGB output interface

Hi rob, Thanks for your reply. 在 2017/10/4 5:56, Rob Herring 写道: On Fri, Sep 22, 2017 at 11:00:26AM +0800, Sandy Huang wrote: This path add support rv1108 rgb output interface driver. Signed-off-by: Sandy Huang --- Changes in v2: 1. rename rockchip,rgb-mode to rgb-mode; You can&#

[PATCH v3 2/4] devicetree/bindings: display: Add document for rockchip RGB output

This path add support rv1108 rgb output interface driver. Signed-off-by: Sandy Huang --- Changes in v3: move rgb-mode to panel node which describe at: Documentation/devicetree/bindings/display/panel/panel-rgb.txt Changes in v2: 1. rename rockchip,rgb-mode to rgb-mode; 2. delete reg for

[PATCH v3 1/4] devicetree/bindings: display: Add doucument for RGB panels

Describe the panel property rgb-mode for parallel and serial RGB output interface, include the connection relations for each mode. Signed-off-by: Sandy Huang --- .../bindings/display/panel/panel-rgb.txt | 116 + 1 file changed, 116 insertions(+) create mode 100644

  1   2   >