Hi Zheyu,
On Wed, Jul 14, 2021 at 04:09:22AM +, Zheyu Ma wrote:
> The user can pass in any value to the driver through the 'ioctl'
> interface. The driver dost not check, which may cause DoS bugs.
>
> The following log reveals it:
>
> divide error: [#1] PREEMPT SMP KASAN PTI
> RIP: 0010:
Hi Geert,
On Wed, Jul 14, 2021 at 04:58:01PM +0200, Geert Uytterhoeven wrote:
> Simplify the nested loops to handle conversion from linear frame buffer
> to ssd1307 page layout:
> 1. Move last page handling one level up, as the value of "m" is the
> same inside a page,
> 2. array->data[] i
+{
Bikeshedding, but I think a dedicated function for col_range and another
for page_range had been simpler to read.
With or wihout this change:
Acked-by: Sam Ravnborg
Sam
> + u8 col_end = col_start + cols - 1;
> + u8 page_end = page_start + pages - 1;
> + int ret;
Hi Geert,
On Wed, Jul 14, 2021 at 04:58:03PM +0200, Geert Uytterhoeven wrote:
> Currently, each screen update triggers an I2C transfer of all screen
> data, up to 1 KiB of data for a 128x64 display, which takes at least 20
> ms in Fast mode.
>
> Reduce the amount of transferred data by only updat
gt; ssd1307fb_update_display()
> video: fbdev: ssd1307fb: Simplify ssd1307fb_update_display()
> video: fbdev: ssd1307fb: Extract ssd1307fb_set_address_range()
> video: fbdev: ssd1307fb: Optimize screen updates
> video: fbdev: ssd1307fb: Cache address ranges
A few comments left for a coupl
dProperties' support is implemented.
>
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Rob Clark
> Cc: Sean Paul
> Cc: Marek Vasut
> Cc: Krishna Manikandan
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Rob Herring
Acked-by: Sam Ravnborg
Hi Xiyu, Xin,
On Mon, Jul 19, 2021 at 01:59:45PM +0800, Xiyu Yang wrote:
> refcount_t type and corresponding API can protect refcounters from
> accidental underflow and overflow and further use-after-free situations.
>
> Signed-off-by: Xiyu Yang
> Signed-off-by: Xin Tan
Looks like a nice improv
On Tue, Jul 20, 2021 at 11:16:27AM +0200, Geert Uytterhoeven wrote:
> Hi Sam,
>
> On Tue, Jul 20, 2021 at 9:56 AM Geert Uytterhoeven
> wrote:
> > On Mon, Jul 19, 2021 at 9:21 PM Sam Ravnborg wrote:
> > > On Wed, Jul 14, 2021 at 04:58:03PM +0200, Geert Uytterhoev
Hi Geert,
On Tue, Jul 20, 2021 at 09:43:22AM +0200, Geert Uytterhoeven wrote:
> Hi Sam,
>
> On Mon, Jul 19, 2021 at 9:05 PM Sam Ravnborg wrote:
> > On Wed, Jul 14, 2021 at 04:58:01PM +0200, Geert Uytterhoeven wrote:
> > > Simplify the nested loops to handle conversion
Hi Geert,
On Tue, Jul 20, 2021 at 09:33:11AM +0200, Geert Uytterhoeven wrote:
> Hi Sam,
>
> On Mon, Jul 19, 2021 at 9:23 PM Sam Ravnborg wrote:
> > On Wed, Jul 14, 2021 at 04:57:59PM +0200, Geert Uytterhoeven wrote:
> > > This patch series optimizes console operations
ot;)
> Signed-off-by: Maxime Ripard
Reviewed-by: Sam Ravnborg
I did a quick audit (as using grep mostly) to see if other panels had
the same bug, but did not find others.
This patch should be applied to drm-misc-fixes independent of the rest of
the patches.
Sam
> ---
> drivers/g
Hi Maxime,
On Tue, Jul 20, 2021 at 03:45:17PM +0200, Maxime Ripard wrote:
> Display drivers so far need to have a lot of boilerplate to first
> retrieve either the panel or bridge that they are connected to using
> drm_of_find_panel_or_bridge(), and then either deal with each with ad-hoc
> functio
was fixed in a dedicated patch - to avoid
mixing things.
But thats just nitpicking, so:
Reviewed-by: Sam Ravnborg
h bits.
s/separare/separate/
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Sam Ravnborg
> ---
> Documentation/gpu/drm-kms-helpers.rst | 6 ++
> drivers/gpu/drm/drm_bridge.c | 14 +-
> 2 files changed, 15 insertions(+), 5 deletions(-)
>
> diff
On Tue, Jul 20, 2021 at 03:45:20PM +0200, Maxime Ripard wrote:
> In order to make the probe order expectation more consistent between
> bridges, let's create attach and detach hooks for the panels as well to
> match what is there for bridges.
This is a partally revert of:
87154ff86bf6 ("drm: Remov
On Tue, Jul 20, 2021 at 03:45:21PM +0200, Maxime Ripard wrote:
> Now that we have additional attach and detach hooks for panels, make
> sure that the panel bridge driver calls them when relevant.
Combine this with the previous patch as this is again a partial revert of
the same patch.
Sam
Hi Colin,
On Wed, Jul 21, 2021 at 11:26:08AM +0100, Colin King wrote:
> From: Colin Ian King
>
> The variable err is being initialized with a value that is never
> read, the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King
> -
Hi Zheyu,
On Wed, Jul 21, 2021 at 12:43:44PM +, Zheyu Ma wrote:
> The userspace program could pass any values to the driver through
> ioctl() interface. If the driver doesn't check the value of 'pixclock',
> it may cause divide error because of the 'PICOS2KHZ' macro.
>
> Fix this by checking w
ll of them, and that the binding will create an
> error if we add one that isn't.
>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Laurent Pinchart
> Cc: Sam Ravnborg
> Cc: Thierry Reding
> Signed-off-by: Maxime Ripard
> ---
> .../bindings/display/panel/lvds.yaml
On Wed, Jul 21, 2021 at 04:03:41PM +0200, Maxime Ripard wrote:
> The corpro,gm7123 was in use in a DT but was never properly documented,
> let's add it.
>
> Cc: dri-devel@lists.freedesktop.org
> Reviewed-by: Laurent Pinchart
> Signed-off-by: Maxime Ripard
Acked-by: Sam Ravnborg
Hi Linus,
On Wed, Jul 21, 2021 at 04:00:35PM +0200, Linus Walleij wrote:
> On Wed, Jul 21, 2021 at 9:41 AM wrote:
>
> > From: Dillon Min
> >
> > Add documentation for "ilitek,ili9341" panel.
> >
> > Cc: Linus Walleij
> > Signed-off-by: Dillon Min
> > Reviewed-by: Rob Herring
>
> Reviewed-by:
Hi Dillon,
On Wed, Jul 21, 2021 at 03:41:28PM +0800, dillon.min...@gmail.com wrote:
> From: Dillon Min
>
> This driver combine tiny/ili9341.c mipi_dbi_interface driver
> with mipi_dpi_interface driver, can support ili9341 with serial
> mode or parallel rgb interface mode by register configuratio
to use the atomic variants
of drm_bridge_funcs operations. The easy ones are the drivers wihtout
mode_set or mode_fixup.
I have something typed up already, but wanted feedback on this patchset before
sending out additional patches.
Sam
Sam Ravnborg (7):
drm/bridge: ps8640: Use atomic
The atomic variants of enable/disable in drm_bridge_funcs are the
preferred operations - introduce these.
The ps8640 driver used the non-atomic variants of the drm_bridge chain
functions - convert these to the atomic variants.
Signed-off-by: Sam Ravnborg
Cc: Andrzej Hajda
Cc: Neil Armstrong
The drm_bridge_chain_{pre_enable,enable,disable,post_disable} has no
users left and we have atomic variants that should be used.
Drop them so they do not gain new users.
Adjust a few comments to avoid references to the dropped functions.
Signed-off-by: Sam Ravnborg
Cc: Laurent Pinchart
Cc
There are no users left and we do not want to have this function
available.
drm_atomic_bridge_check() is used to call the mode_fixup() operation for
the chained bridges and there is no need for drm_atomic_bridge_check().
Drop it.
Signed-off-by: Sam Ravnborg
Cc: Laurent Pinchart
Cc: Maarten
The atomic variants of enable/disable in drm_bridge_funcs are the
preferred operations - introduce these.
Use of mode_set is deprecated - merge the functionality with
atomic_enable()
Signed-off-by: Sam Ravnborg
Cc: Andrzej Hajda
Cc: Neil Armstrong
Cc: Robert Foss
Cc: Laurent Pinchart
Cc
uld see this call was included in the original
version of the driver so there was no help there to find out why it was
added in the first place. But a lot has changed since the initial driver
were added and is seems safe to remove the call now.
Signed-off-by: Sam Ravnborg
Cc: Chun-Kuang Hu
- deprecated callbacks in drm_bridge_funcs
- move connector creation to display drivers
Signed-off-by: Sam Ravnborg
Cc: Laurent Pinchart
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Thomas Zimmermann
Cc: David Airlie
Cc: Daniel Vetter
---
Documentation/gpu/todo.rst | 47
drm_bridge_new_crtc_state() will be used by bridge drivers to provide
easy access to the mode from the drm_bridge_funcs operations.
The helper will be useful in the atomic operations of
struct drm_bridge_funcs.
Signed-off-by: Sam Ravnborg
Suggested-by: Laurent Pinchart
Cc: Laurent Pinchart
Cc
On Fri, Jul 23, 2021 at 10:57:56AM +0200, Daniel Vetter wrote:
> On Fri, Jul 23, 2021 at 11:12:49AM +0800, lichenyang wrote:
> > From: Chenyang Li
> >
> > This patch adds an initial DRM driver for the Loongson LS7A1000
> > bridge chip(LS7A). The LS7A bridge chip contains two display
> > controlle
Hi Marek,
On Wed, Jul 21, 2021 at 07:12:56PM +0200, Marek Vasut wrote:
> Fix the warning message "missing connector type" by adding connector_type
> for EDT ETM0700G0BDH6 panel.
>
> Signed-off-by: Marek Vasut
> Cc: Biju Das
> Cc: Sam Ravnborg
> ---
> driver
Hi Oleksij,
On Wed, Jul 14, 2021 at 06:53:46AM +0200, Oleksij Rempel wrote:
> Add Logictechno and Multi-Inno panels:
> - Logic Technologies LTTD800x480 L2RT 7" 800x480 TFT Resistive Touch Module
> - Logic Technologies LTTD800480070-L6WH-RT 7” 800x480 TFT Resistive Touch
> Module
> - Multi-Inno Te
Hi Geert,
On Wed, Jul 14, 2021 at 04:51:22PM +0200, Geert Uytterhoeven wrote:
> Convert the Solomon SSD1307 Framebuffer Device Tree binding
> documentation to json-schema.
>
> Fix the spelling of the "pwms" property.
> Document default values.
> Make properties with default values not required.
>
On Tue, Jun 29, 2021 at 07:47:21AM +0800, Nicolas Boichat wrote:
> Many of the DSI flags have names opposite to their actual effects,
> e.g. MIPI_DSI_MODE_EOT_PACKET means that EoT packets will actually
> be disabled. Fix this by including _NO_ in the flag names, e.g.
> MIPI_DSI_MODE_NO_EOT_PACKET.
gt; +required:
> + - compatible
reg?
> + - reset-gpios
> + - iovdd-supply
> + - vddr-supply
> +
> +unevaluatedProperties: false
As I do not see the DT node pull in additional preperties from another
binding the more strict:
additionalProperties: false seems to be the right ch
Hi Alexey,
On Sun, Jul 25, 2021 at 05:03:38PM +0300, Alexey Minnekhanov wrote:
> Samsung S6E3FA2 panel is amoled 1080x1920 command mode DSI
> panel used in Samsung Galaxy S5 phone. There are 2 known
> variations of panel that were shipped in this phone, and
> this driver handles both of them.
>
>
Hi Jagan,
On Sun, Jul 04, 2021 at 02:32:13PM +0530, Jagan Teki wrote:
> This series supports common bridge support for Samsung MIPI DSIM
> which is used in Exynos and i.MX8MM SoC's.
>
> The final bridge supports both the Exynos and i.MX8MM DSI devices.
>
> Right now bridge offers two sets of imp
Hi Jagan,
See a few comments below.
Sam
On Sun, Jul 04, 2021 at 02:32:14PM +0530, Jagan Teki wrote:
> DRM bridge drivers have built-in handling of treating
> all display pipeline components as bridges.
>
> Convert exynos_drm_dsi to a bridge driver with built-in
> encoder support for com
tach function call.
>
> Signed-off-by: Jagan Teki
Acked-by: Sam Ravnborg
Hi Jagan,
On Sun, Jul 04, 2021 at 02:32:18PM +0530, Jagan Teki wrote:
> Now the exynos dsi driver is fully aware of bridge
> handling, so get the display mode from bridge, mode_set
> API instead of legacy encoder crtc.
>
> This makes bridge usage more efficient instead of relying
> on encoder sta
On Sun, Jul 04, 2021 at 02:32:19PM +0530, Jagan Teki wrote:
> Exynos DSI driver is actually a Samsung MIPI DSIM bridge
> IP which is also used in i.MX8MM platforms.
>
> Right now the existing driver has some exynos drm specific
> code bases like te_irq, crtc and component_ops.
>
> In order to swi
Hi Jagan,
On Sun, Jul 04, 2021 at 02:32:29PM +0530, Jagan Teki wrote:
> PMS_P offset value in existing driver is not compatible
> with i.MX8MM.
>
> However the i.MX8M Mini Application Reference manual shows
> the PMS_P offset is the same in the driver, but the i.MX8MM
> downstream driver uses a di
Hi Jagan,
On Sun, Jul 04, 2021 at 02:32:30PM +0530, Jagan Teki wrote:
> Fixing up the mode flags are required in order to correlate
> the correct sync flags in i.MX8MM eLCDIF.
>
> So, handle the mode flags via bridge, mode_fixup.
Please do this in atomic_check.
Check rcar-du for a way to get acce
* include for DRM_FORMAT_MAX_PLANES
>
> Signed-off-by: Thomas Zimmermann
One nit below.
Reviewed-by: Sam Ravnborg
> ---
> drivers/gpu/drm/drm_gem_framebuffer_helper.c | 19 +++
> include/drm/drm_fourcc.h | 13 +
> include/drm/drm
o
> functional changes.
>
> v2:
> * using [static N] for array parameters enables compile-time checks
> * include for DRM_FORMAT_MAX_PLANES (kernel
> test robot)
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Sam Ravnborg
erform unmap operations of certain BOs by themselfes.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Sam Ravnborg
> ---
> drivers/gpu/drm/drm_gem_framebuffer_helper.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_fram
m_writeback_job. Introduce the new type
> struct vkms_writeback_job, which holds the output mappings addresses
> while the writeback job is active.
>
> The patchset also cleans up some internal casting an setup of the
> output addresses. No functional changes.
>
> Signed-off-
l only supports single-plane formats.
>
> No functional changes.
>
> Signed-off-by: Thomas Zimmermann
> Acked-by: Noralf Trønnes
Acked-by: Sam Ravnborg
> ---
> drivers/gpu/drm/gud/gud_pipe.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>
Hi Jagan,
On Sun, Jul 25, 2021 at 11:17:37PM +0530, Jagan Teki wrote:
> ytc700tlag_05_201c panel support 8 bpc not 6 bpc as per
> recent testing in i.MX8MM platform.
>
> Fix it.
>
> Fixes: 7a1f4fa4a629 ("drm/panel: simple: Add YTC700TLAG-05-201C")
> Signed-off-by: Jagan Teki
Thanks, applied to
Hi Zheyu,
On Sun, Jul 25, 2021 at 02:10:51AM +, Zheyu Ma wrote:
> Zheyu Ma (3):
> video: fbdev: kyro: add a check against divide error
> video: fbdev: riva: add a check against divide error
> video: fbdev: asiliantfb: add a check against divide error
I would prefer something a bit more
Hi Artjom,
On Sat, Jul 24, 2021 at 01:33:56PM +0300, Artjom Vejsel wrote:
> Add vendor prefix for Shenzhen QiShenglong Industrialist Co., Ltd.
> QiShenglong is a Chinese manufacturer of handheld gaming consoles, most of
> which run (very old) versions of Linux.
> QiShenglong is known as Hamy.
>
>
On Sat, Jul 24, 2021 at 01:33:58PM +0300, Artjom Vejsel wrote:
> The Gopher 2b LCD panel is used in Gopher 2b handhelds.
> It's simple panel with NewVision NV3047 driver, but SPI lines are not
> connected.
> It has no specific name, since it's unique to that handhelds.
> lot name at AliExpress: 4.
Hi Nicolas,
On Mon, Jul 26, 2021 at 08:38:18AM +0800, Nicolas Boichat wrote:
> On Sun, Jul 25, 2021 at 9:31 PM Sam Ravnborg wrote:
> >
> > On Tue, Jun 29, 2021 at 07:47:21AM +0800, Nicolas Boichat wrote:
> > > Many of the DSI flags have names opposite to their a
Hi,
On Mon, Jul 26, 2021 at 11:32:37AM +, tcs_kernel(腾讯云内核开发者) wrote:
> yres and vyres can be controlled by user mode paramaters, and cause p->vrows
> to become a negative value. While this value be passed to real_y function,
> the ypos will be out of screen range.
> This is an out-of-bounds
Hi Zheyu,
On Mon, Jul 26, 2021 at 10:03:52AM +, Zheyu Ma wrote:
> Zheyu Ma (3):
> video: fbdev: asiliantfb: Error out if 'pixclock' equals zero
> video: fbdev: kyro: Error out if 'pixclock' equals zero
> video: fbdev: riva: Error out if 'pixclock' equals zero
Thanks for the quick respin,
Hi Björn,
On Mon, Jul 26, 2021 at 10:32:59AM -0700, Bjorn Andersson wrote:
> Add bindings for the two AUO panels B133HAN05 and B140HAN06, both
> 1920x1080 panels with 16.7M colors, first being 13.3" and the latter
> 14.0".
>
> Signed-off-by: Bjorn Andersson
Thanks, both patches applied to drm-mi
Hi Paul,
On Mon, Jul 26, 2021 at 10:02:08AM +0100, Paul Cercueil wrote:
> Hi Artjom,
>
> Le lun., juil. 26 2021 at 01:15:27 +0300, Artjom Vejsel
> a écrit :
> > The Gopher 2b LCD panel is used in Gopher 2b handhelds.
> > It's simple panel with NewVision NV3047 driver, but SPI lines are not
> > co
, add log messages to
> drm_framebuffer_remove (Daniel)
>
> Signed-off-by: Simon Ser
> Cc: Daniel Vetter
Looks like some very useful debugging logging.
Acked-by: Sam Ravnborg
Hi Nikita,
On Mon, Jul 26, 2021 at 04:59:52PM +0300, Nikita Shubin wrote:
> From: Alexander Sverdlin
>
> Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch
> to Common Clock Framework.
>
> Signed-off-by: Alexander Sverdlin
> Signed-off-by: Nikita Shubin
Thanks, applied
Hi Nicolas,
On Tue, Jul 27, 2021 at 09:45:21AM +0800, Nicolas Boichat wrote:
> Many of the DSI flags have names opposite to their actual effects,
> e.g. MIPI_DSI_MODE_EOT_PACKET means that EoT packets will actually
> be disabled. Fix this by including _NO_ in the flag names, e.g.
> MIPI_DSI_MODE_NO
- Make the backlight .set_brightness() turn the backlight
> off completely if blank.
> - Fix some dev_err_probe() use cases along the way.
Very nice cleanup - thanks.
One issue below, with that fixed:
Reviewed-by: Sam Ravnborg
I assume you will apply the patch yourself.
Sam
>
Hi Geert,
On Tue, Jul 27, 2021 at 03:47:25PM +0200, Geert Uytterhoeven wrote:
> Hi all,
>
> This patch series optimizes console operations on ssd1307fb, after the
> customary fixes and cleanups.
>
> Currently, each screen update triggers an I2C transfer of all screen
> data, up to 1 KiB of
Hi Chenyang,
I browsed the code on lore and noticed a few things and thought it
better to bring it to your attention now.
The general structure of the drivers seems good and coding style is
fine. The feedback is mostly stuff we have decided to do different over
time, so likely because you based t
Hi Thomas,
On Tue, Jul 27, 2021 at 08:27:07PM +0200, Thomas Zimmermann wrote:
> DRM's IRQ helpers are only helpful for old, non-KMS drivers. Move
> the code behind CONFIG_DRM_LEGACY. Convert KMS drivers to Linux
> IRQ interfaces.
>
> DRM provides IRQ helpers for setting up, receiving and removing
On Mon, Jul 26, 2021 at 09:44:57PM +0200, Marek Vasut wrote:
> In case there is a bridge connected to the LCDIF, use bus_format
> from the bridge, otherwise behave as before and use bus_format
> from the connector. This way, even if there are multiple bridges
> in the display pipeline, the LCDIF wi
^ add space
> + * from the Myriadx tests
>*/
> out_format |= LCD_OUTF_FORMAT_RGB888;
>
> @@ -526,6 +532,11 @@ struct kmb_plane *kmb_plane_init(struct drm_device *drm)
> plane->id = i;
> }
>
> + /* Disable pipeline AXI read transactions for the DMA
> + * prior to setting graphics layers
> + */
> + kmb_clr_bitmask_lcd(kmb, LCD_CONTROL, LCD_CTRL_PIPELINE_DMA);
> +
> return primary;
> cleanup:
> drmm_kfree(drm, plane);
With the two nits fixed:
Acked-by: Sam Ravnborg
t of no use with macros here, as the figures are not used
anywhere else, but whatever.
With s-o-b fixed:
Acked-by: Sam Ravnborg
> ---
> drivers/gpu/drm/kmb/kmb_drv.c | 8
> drivers/gpu/drm/kmb/kmb_drv.h | 5 +
> 2 files changed, 9 insertions(+), 4 deletions(-)
>
>
Hi Anitha,
On Tue, Jul 27, 2021 at 05:31:16PM -0700, Anitha Chrisanthus wrote:
> For B0 silicon, the media driver pads the decoded video dmabufs for 256B
> alignment. This is the backing buffer of the framebuffer and info in the
> drm frame buffer is not correct for these buffers as this is done
>
On Tue, Jul 27, 2021 at 05:31:22PM -0700, Anitha Chrisanthus wrote:
> On KMB, ADV bridge must be programmed and powered on prior to
> MIPI DSI HW initialization.
>
> Fixes: 98521f4d4b4c ("drm/kmb: Mipi DSI part of the display driver")
> Signed-off-by: Anitha Chrisanthus
> ---
> drivers/gpu/drm/k
Hi Anitha,
On Tue, Jul 27, 2021 at 05:31:24PM -0700, Anitha Chrisanthus wrote:
> If kmb_dsi_init() fails the "kmb->kmb_dsi" variable is an error pointer.
> This can potentially result in kernel panic when kmb_dsi_host_unregister is
> called.
>
> Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for Keem
Hi Anitha,
On Tue, Jul 27, 2021 at 05:31:25PM -0700, Anitha Chrisanthus wrote:
> From: Edmund Dea
>
> Enable one additional plane that is alpha blended on top
> of the primary plane.
>
> Signed-off-by: Edmund Dea
Your s-o-b is missing.
With this fixed:
Acked-by: Sam Ravnborg
Hi Anitha,
On Tue, Jul 27, 2021 at 05:31:26PM -0700, Anitha Chrisanthus wrote:
> From: Edmund Dea
>
> Enable support for fbcon (framebuffer console).
> The user can initialize fbcon by loading kmb-drm with the parameter
> console=1.
I do not see the poit of the boot parameter??
Why is it needed
Hi Allen,
On Fri, Jul 16, 2021 at 03:27:32PM +0800, allen wrote:
> This adds support for the iTE IT6505.
> This device can convert DPI signal to DP output.
>
> From: Allen Chen
> Tested-by: Hsin-yi Wang
> Signed-off-by: Hermes Wu
> Signed-off-by: Allen Chen
prompted by Roberts review here are
int ret;
> +
> + if (irq == IRQ_NOTCONNECTED)
> + return -ENOTCONN;
The code above is almost redundandt as request_irq has the same check.
The only benefit of this check is that we avoid calling
hdlcd_irq_preinstall().
And IRQ_NOTCONNECTED is only set for PCI devic
Hi Dan,
I hope you can fine to test this patch from Thomas.
If this works then we can forget about my attempt to do the same.
Hi Thomas,
IRQ_NOTCONNECTED check seems redundant, as mentioned in another patch
already.
With that considered:
Reviewed-by: Sam Ravnborg
We shall wait for testing
ed behind
> CONFIG_DRM_LEGACY.
>
> All callers have been updated.
>
> Signed-off-by: Thomas Zimmermann
Acked-by: Sam Ravnborg
> ---
> drivers/gpu/drm/drm_irq.c | 63 ---
You could have pulled it all into drm_legacy_misc.c.
> drivers/gpu/drm/drm_leg
Hi Dan,
On Wed, Jul 28, 2021 at 03:11:08PM +, dan.sned...@microchip.com wrote:
> On 7/28/21 7:00 AM, Sam Ravnborg wrote:
> > [You don't often get email from s...@ravnborg.org. Learn why this is
> > important at http://aka.ms/LearnAboutSenderIdentification.]
> >
Hi Dan,
thanks for the quick feedback!
On Wed, Jul 28, 2021 at 05:50:34PM +, dan.sned...@microchip.com wrote:
> On 7/28/21 8:44 AM, Sam Ravnborg wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> > content is safe
> >
> > Hi D
Hi Dan,
> >>
> >> Just to be sure...
> >> Can you confirm that vbltest is working OK *before* this patch?
> >
> > Yes, can you please verify that it regressed. If so, this would mean
> > that the driver misses vblank interrupts with the patch applied.
>
> Yes, unfortunately the vbltest works be
Hi Dan,
> >
> > I think I got it - we need to set irq_enabled to true.
> > The documentation says so:
> > "
> > * @irq_enabled:
> > *
> > * Indicates that interrupt handling is enabled, specifically
> > vblank
> > * handling. Drivers which don't use drm_ir
DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE,
> +};
> +
> +static const struct panel_desc eink_vb3300_kca = {
> + .timings = &eink_vb3300_kca_timing,
> + .num_timings = 1,
> + .bpc = 6,
> + .size = {
> + .width = 157,
> +
On Thu, Jul 29, 2021 at 03:20:17PM +0200, Robert Foss wrote:
> Hey Jagan,
>
> On Sun, 4 Jul 2021 at 11:04, Jagan Teki wrote:
> >
> > Now the exynos dsi driver is fully aware of bridge
> > handling, so get the display mode from bridge, mode_set
> > API instead of legacy encoder crtc.
> >
> > This
Hi Laurent,
On Wed, Jul 28, 2021 at 06:37:29PM +0300, Laurent Pinchart wrote:
> Hello,
>
> This patch series stems from subsystem-wide changes I wanted to
> compile-test with an ARM64 cross-compiler. My laziness to fire a 32-bit
> ARM build probably resulted in more time being spent writing these
ded macros for date and version
Fixes: 7f7b96a8a0a1 ("drm/kmb: Add support for KeemBay Display")
Signed-off-by: Edmund Dea
Signed-off-by: Anitha Chrisanthus
Acked-by: Sam Ravnborg
Link:
https://patchwork.freedesktop.org/patch/msgid/20210728003126.1425028-2-ani
Hi Thomas,
>
> Are you sure, you're testing with the latest drm-misc-next or drm-tip?
> Because using irq_enabled is deprecated and the flag was recently replaced
> by commit 1e4cd78ed493 ("drm: Don't test for IRQ support in VBLANK ioctls").
I was looking at drm-misc-fixes which did not have thi
On Thu, Jul 29, 2021 at 04:30:02PM -0600, Rob Herring wrote:
> On Mon, Jul 26, 2021 at 09:51:40AM +0200, Linus Walleij wrote:
> > On Sun, Jul 25, 2021 at 4:04 PM Alexey Minnekhanov
> > wrote:
> >
> > > The Samsung S6E3FA2 AMOLED cmd LCD panel is used on Samsung Galaxy
> > > S5 (klte) phone.
> > >
Hi Douglas,
On Fri, Jul 30, 2021 at 08:45:59AM -0700, Douglas Anderson wrote:
>
> The overall goal of this series is to make the Samsung ATNA33XC20
> panel work more properly. As part of this, we have:
> * A bugfix for the recently abstracted DP AUX backlight code.
> * A bugfix for the sequencing
Hi Douglas,
On Fri, Jul 30, 2021 at 08:45:59AM -0700, Douglas Anderson wrote:
>
> The overall goal of this series is to make the Samsung ATNA33XC20
> panel work more properly. As part of this, we have:
> * A bugfix for the recently abstracted DP AUX backlight code.
> * A bugfix for the sequencing
Hi Alistair,
On Thu, Jul 29, 2021 at 08:33:58PM +1000, Alistair Francis wrote:
> Add support for the 10.3" E Ink panel described at:
> https://www.eink.com/product.html?type=productdetail&id=7
>
> Signed-off-by: Alistair Francis
> Acked-by: Rob Herring
> ---
> v4:
> - Fixup alphebetical sortin
Hi Alistair,
On Fri, Jul 30, 2021 at 10:13:10PM +1000, Alistair Francis wrote:
> Add support for the 10.3" E Ink panel described at:
> https://www.eink.com/product.html?type=productdetail&id=7
>
> Signed-off-by: Alistair Francis
> Acked-by: Rob Herring
> Reviewed-b
Hi Thomas,
On Tue, Jul 27, 2021 at 08:27:07PM +0200, Thomas Zimmermann wrote:
> DRM's IRQ helpers are only helpful for old, non-KMS drivers. Move
> the code behind CONFIG_DRM_LEGACY. Convert KMS drivers to Linux
> IRQ interfaces.
>
> DRM provides IRQ helpers for setting up, receiving and removing
Hi Cai,
On Tue, Jul 27, 2021 at 01:21:07PM +0800, Cai Huoqing wrote:
> Remove including that don't need it.
>
> Signed-off-by: Cai Huoqing
thanks! Applied to drm-misc-next.
The patch will show up in -next is a week or two.
Sam
Hi Alistair,
On Sun, Aug 01, 2021 at 10:47:00AM +1000, Alistair Francis wrote:
> Add support for the 10.3" E Ink panel described at:
> https://www.eink.com/product.html?type=productdetail&id=7
>
> Signed-off-by: Alistair Francis
> Acked-by: Rob Herring
> Reviewed-by
Hi Tuo Li,
On Sat, Jul 31, 2021 at 02:28:39PM +0800, Li Tuo wrote:
> Hello,
>
> Our static analysis tool finds a possible uninitialized-variable access in
> the sis driver in Linux 5.14.0-rc3:
>
> At the beginning of the function SiS_SetCRT2FIFO_300(), the variable
> modeidindex is not initializ
Hi Thomas,
> >
> > 1) IRQ_NOTCONNECTED
> >
> > We do not have this check in drm_irq today and we should avoid spreading
> > it all over. We are either carrying it forever or we wil lsee patches
> > floating in to drop the check again.
> > The current use in the kernel is minimal:
> > https://eli
Hi lichenyang,
On Fri, Jul 30, 2021 at 05:41:47PM +0800, lichenyang wrote:
> Implement use GPIO and I2C driver to detect connector
> and fetch EDID via DDC.
>
> v3:
> - Change some driver log to the drm_ version.
>
> v2:
> - Optimize the error handling process.
> - Delete loongson_i2c_bus_match
Hi Anitha,
On Mon, Aug 02, 2021 at 08:44:26PM +, Chrisanthus, Anitha wrote:
> Hi Sam,
> Thanks. Where should this go, drm-misc-fixes or drm-misc-next?
Looks like a drm-misc-next candidate to me.
I may improve something for existing users, but it does not look like it
fixes an existing bug.
Hi Markuss,
just a random collection of minor things to fix.
Overall the driver looks good.
Sam
On Tue, Aug 03, 2021 at 04:54:18PM +0300, Markuss Broks wrote:
> This adds a driver for Samsung S6D27A1 display controller and panel.
> This panel is found in the Samsung GT-I8160 mobile phone,
Hi Thomas,
On Tue, Aug 03, 2021 at 11:07:01AM +0200, Thomas Zimmermann wrote:
> Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's
> IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers
> don't benefit from using it.
>
> DRM IRQ callbacks are now being called directly
1 - 100 of 3979 matches
Mail list logo
