Thanks, Christophe.
On Sun, Aug 22, 2021 at 11:30:08AM +0200, Christophe JAILLET wrote:
> The wrappers in include/linux/pci-dma-compat.h should go away.
>
> The patch has been generated with the coccinelle script below.
>
> It has been compile tested.
Reviewed-by: Sakari Ail
Instead of constructing the FourCC code manually, use the %p4cc printk
modifier to print it. Also leave a message to avoid using this function.
The next step would be to convert the users to use %p4cc directly instead
and removing the function.
Signed-off-by: Sakari Ailus
---
drivers/gpu/drm
.
Sakari Ailus (3):
lib/vsprintf: Add support for printing V4L2 and DRM fourccs
v4l: ioctl: Use %p4cc printk modifier to print FourCC codes
drm/fourcc: Switch to %p4cc format modifier
Documentation/core-api/printk-formats.rst | 16 +
drivers/gpu/drm/drm_fourcc.c | 16
Now that we can print FourCC codes directly using printk, make use of the
feature in V4L2 core.
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/v4l2-ioctl.c | 85 +++-
1 file changed, 21 insertions(+), 64 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
pixel formats denoted by fourccs. The fourcc encoding is the same for both
so the same implementation can be used.
Suggested-by: Mauro Carvalho Chehab
Signed-off-by: Sakari Ailus
Reviewed-by: Petr Mladek
Reviewed-by
Hi Daniel,
Thanks for the comments.
On Tue, Feb 09, 2021 at 08:27:10AM +0100, Daniel Vetter wrote:
> On Mon, Feb 8, 2021 at 9:20 PM Sakari Ailus
> wrote:
> >
> > Instead of constructing the FourCC code manually, use the %p4cc printk
> > modifier to print it. Also leave
Hi Andy,
On Mon, Feb 08, 2021 at 10:43:30PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 8, 2021 at 10:11 PM Sakari Ailus
> wrote:
> >
> > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
> > pixel formats denoted by fourccs. The fourcc encoding is
Hi Andy,
On Tue, Feb 09, 2021 at 11:58:40AM +0200, Andy Shevchenko wrote:
> On Tue, Feb 09, 2021 at 11:20:32AM +0200, Sakari Ailus wrote:
> > On Mon, Feb 08, 2021 at 10:43:30PM +0200, Andy Shevchenko wrote:
> > > On Mon, Feb 8, 2021 at 10:11 PM Sakari
Hi Petr,
On Thu, Feb 11, 2021 at 05:31:46PM +0100, Petr Mladek wrote:
> On Mon 2021-02-08 22:09:02, Sakari Ailus wrote:
> > Now that we can print FourCC codes directly using printk, make use of the
> > feature in V4L2 core.
> >
> > Signed-off-by: Sakari Ailus
>
Hi Petr,
Thanks for the comments.
On Thu, Feb 11, 2021 at 06:14:28PM +0100, Petr Mladek wrote:
> On Tue 2021-02-09 19:47:55, Sakari Ailus wrote:
> > Hi Andy,
> >
> > On Tue, Feb 09, 2021 at 11:58:40AM +0200, Andy Shevchenko wrote:
> > > On Tue, Feb 09, 2021 at
ll as change the DRM
fourcc printing function to use %p4cc.
- Add missing checkpatch.pl checks for %p4cc modifier.
Sakari Ailus (3):
lib/vsprintf: Add support for printing V4L2 and DRM fourccs
v4l: ioctl: Use %p4cc printk modifier to print FourCC codes
drm: Switch to %p4cc format modifier
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
pixel formats denoted by fourccs. The fourcc encoding is the same for both
so the same implementation can be used.
Suggested-by: Mauro Carvalho Chehab
Signed-off-by: Sakari Ailus
Reviewed-by: Petr Mladek
Reviewed-by
Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a
large number of temporary variables at the same time.
Signed-off-by: Sakari Ailus
---
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c| 5 ++--
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c| 5 ++--
drivers/gpu/drm/amd
Now that we can print FourCC codes directly using printk, make use of the
feature in V4L2 core.
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/v4l2-ioctl.c | 85 +++-
1 file changed, 21 insertions(+), 64 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2
Hi Andy,
On Mon, Feb 15, 2021 at 03:41:14PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 15, 2021 at 01:40:30PM +0200, Sakari Ailus wrote:
> > Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a
> > large number of temporary variables at the same time.
>
&
Hi Andy,
On Mon, Feb 15, 2021 at 03:34:04PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 15, 2021 at 01:40:29PM +0200, Sakari Ailus wrote:
> > Now that we can print FourCC codes directly using printk, make use of the
> > feature in V4L2 core.
>
> Reviewed-by: Andy Shevche
Hi Andy,
On Mon, Feb 15, 2021 at 03:31:29PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 15, 2021 at 01:40:28PM +0200, Sakari Ailus wrote:
> > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
> > pixel formats denoted by fourccs. The fourcc encoding is th
Hi Petr,
On Mon, Feb 15, 2021 at 05:51:40PM +0100, Petr Mladek wrote:
> On Mon 2021-02-15 17:54:47, Andy Shevchenko wrote:
> > On Mon, Feb 15, 2021 at 03:56:50PM +0200, Sakari Ailus wrote:
> > > On Mon, Feb 15, 2021 at 03:31:29PM +0200, Andy Shevchenko wrote:
> > > >
On Mon, Feb 15, 2021 at 06:05:45PM +0100, Mauro Carvalho Chehab wrote:
> Em Mon, 15 Feb 2021 17:56:27 +0100
> Petr Mladek escreveu:
>
> > On Mon 2021-02-15 13:40:29, Sakari Ailus wrote:
> > > Now that we can print FourCC codes directly using printk, make use of the
&g
} else {
> seq_printf();
> }
>
> ?
I could, but it'd repeat a lot of the same format string that is very
complicated right now. Therefore I thought it's better to split.
Or do you mean seq_printf() vs. seq_puts()? checkpatch.pl (rightly) warns
about it.
>
> >fb ? fb->modifier : 0,
> >fb ? fb->width : 0, fb ? fb->height : 0,
> >plane_visibility(plane_state),
--
Sakari Ailus
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Thomas,
Thanks for the review.
On Tue, Feb 16, 2021 at 09:37:45AM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 15.02.21 um 12:40 schrieb Sakari Ailus:
> > Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a
> > large number of temporary varia
ssing checkpatch.pl checks for %p4cc modifier.
Sakari Ailus (4):
lib/vsprintf: Add support for printing V4L2 and DRM fourccs
v4l: ioctl: Use %p4cc printk modifier to print FourCC codes
drm: Switch to %p4cc format modifier
drm: Remove drm_get_format_name()
Documentation/core-a
Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a
large number of temporary variables at the same time.
Signed-off-by: Sakari Ailus
Reviewed-by: Petr Mladek
Reviewed-by: Andy Shevchenko
Acked-by: Thomas Zimmermann
---
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
The %p4cc printk format modifier was recently added to print fourcc codes,
replacing drm_get_format_name(). The function is no longer needed, so
remove it.
Signed-off-by: Sakari Ailus
Reviewed-by: Petr Mladek
Reviewed-by: Andy Shevchenko
---
drivers/gpu/drm/drm_fourcc.c | 25
Now that we can print FourCC codes directly using printk, make use of the
feature in V4L2 core.
Signed-off-by: Sakari Ailus
Acked-by: Mauro Carvalho Chehab
Reviewed-by: Petr Mladek
Reviewed-by: Andy Shevchenko
---
drivers/media/v4l2-core/v4l2-ioctl.c | 85 +++-
1 file
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
pixel formats denoted by fourccs. The fourcc encoding is the same for both
so the same implementation can be used.
Suggested-by: Mauro Carvalho Chehab
Signed-off-by: Sakari Ailus
Reviewed-by: Petr Mladek
Reviewed-by
The %p4cc printk format modifier was recently added to print fourcc codes,
replacing drm_get_format_name(). The function is no longer needed, so
remove it.
Signed-off-by: Sakari Ailus
Reviewed-by: Petr Mladek
Reviewed-by: Andy Shevchenko
---
drivers/gpu/drm/drm_fourcc.c | 25
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
pixel formats denoted by fourccs. The fourcc encoding is the same for both
so the same implementation can be used.
Suggested-by: Mauro Carvalho Chehab
Signed-off-by: Sakari Ailus
Reviewed-by: Petr Mladek
Reviewed-by
- Added V4L2 core conversion to %p4cc, as well as change the DRM
fourcc printing function to use %p4cc.
- Add missing checkpatch.pl checks for %p4cc modifier.
Sakari Ailus (4):
lib/vsprintf: Add support for printing V4L2 and DRM fourccs
v4l: ioctl: Use %p4cc printk modifier to print FourC
Now that we can print FourCC codes directly using printk, make use of the
feature in V4L2 core.
Signed-off-by: Sakari Ailus
Acked-by: Mauro Carvalho Chehab
Reviewed-by: Petr Mladek
Reviewed-by: Andy Shevchenko
---
drivers/media/v4l2-core/v4l2-ioctl.c | 85 +++-
1 file
Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a
large number of temporary variables at the same time.
Signed-off-by: Sakari Ailus
Reviewed-by: Petr Mladek
Reviewed-by: Andy Shevchenko
Acked-by: Thomas Zimmermann
---
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
On Wed, Feb 17, 2021 at 01:14:42PM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 16.02.21 um 16:57 schrieb Sakari Ailus:
> > Hi all,
> >
> > On merging --- it would seem everyone is happy with merging this
> > through the drm-misc tree. The last patch sh
ith references for a long time, looks like from
the very beginning of it, as in patch
8a0662d9ed2968e1186208336a8e1fab3fdfea63 .
If you're expecting an fwnode family of function returning another node,
then that function has to have taken a reference to that node before
retur
Hi Andy,
On Thu, Dec 10, 2020 at 03:05:02PM +0200, Andy Shevchenko wrote:
> On Thu, Dec 10, 2020 at 2:16 PM Petr Mladek wrote:
> > On Fri 2020-11-13 12:54:41, Sakari Ailus wrote:
> > > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
> > > pixel
Hi Rasmus,
Thanks for the review.
On Mon, Apr 27, 2020 at 05:44:00PM +0200, Rasmus Villemoes wrote:
> On 27/04/2020 16.53, Sakari Ailus wrote:
> > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
> > pixel formats denoted by fourccs. The fourcc encoding
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
pixel formats denoted by fourccs. The fourcc encoding is the same for both
so the same implementation can be used.
Suggested-by: Mauro Carvalho Chehab
Signed-off-by: Sakari Ailus
---
Hi folks,
I believe I've addr
Hi Andy,
On Tue, Nov 03, 2020 at 04:47:47PM +0200, Andy Shevchenko wrote:
> On Tue, Nov 03, 2020 at 03:34:00PM +0200, Sakari Ailus wrote:
> > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
> > pixel formats denoted by fourccs. The fourcc encoding is th
Hi Joe,
On Tue, Nov 03, 2020 at 08:49:36AM -0800, Joe Perches wrote:
> On Tue, 2020-11-03 at 16:56 +0200, Sakari Ailus wrote:
> > On Tue, Nov 03, 2020 at 04:47:47PM +0200, Andy Shevchenko wrote:
> > > On Tue, Nov 03, 2020 at 03:34:00PM +0200, Sakari Ailus wrote:
> > &
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
pixel formats denoted by fourccs. The fourcc encoding is the same for both
so the same implementation can be used.
Suggested-by: Mauro Carvalho Chehab
Signed-off-by: Sakari Ailus
---
since v4:
- Use correct destination
ES));
This would be better split on two lines.
Then,
Reviewed-by: Sakari Ailus
--
Sakari Ailus
gt;
> Cc: Jonathan Cameron
> Cc: Dmitry Torokhov
> Cc: Laurent Pinchart
> Cc: Mauro Carvalho Chehab
> Cc: Sakari Ailus
> Cc: Lee Jones
> Cc: Mark Brown
> Cc: Maxime Ripard
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-...@vger.kernel.org
> Cc: linux-in...
: plane index
> + *
> + * Returns:
> + * The size of the plane buffer.
Similarly:
Returns the minimum size of the plane buffer.
With these,
Acked-by: Sakari Ailus
> + */
> +static inline
> +unsigned int image_format_info_plane_size(const struct image_format_info
>
works as expected with all sglists. A new
> iterator type is introduced to provide compile-time safety against wrongly
> mixing accessors and iterators.
>
> Signed-off-by: Jason Gunthorpe
Acked-by: Sakari Ailus (ipu3-cio2)
--
Sakari Ailus
sakari.ai...@linux.intel.com
Let me know what you think,
> Maxime
>
> Changes from v3
> - Rebased on 5.0-rc1
> - Added the fixes suggested by Sakari
Thanks!
For patches 1--3:
Acked-by: Sakari Ailus
--
Sakari Ailus
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
ff-by: Maxime Ripard
Reviewed-by: Sakari Ailus
Could you also send this to the devicetree list, please?
> ---
> Documentation/devicetree/bindings/display/bridge/cdns,dsi.txt | 21 +---
> Documentation/devicetree/bindings/phy/cdns,dphy.txt | 20 +++-
> 2 files changed
e
> the v4l2 drivers are completely missing any phy support. In order to make
> that phy support available to all these drivers, without having to
> duplicate that code three times, let's create a generic phy framework
> driver.
>
> Signed-off-by: Maxime Ripard
Reviewed-
On Thu, Jun 06, 2019 at 12:22:46AM +0200, Paul Cercueil wrote:
> This patch adds MEDIA_BUS_FMT_RGB888_3X8, used for the GiantPlus
> GPM940B0 24-bit TFT panel, where the RGB components are transferred
> sequentially on a 8-bit bus.
>
> Signed-off-by: Paul Cercueil
Acked-b
On Sat, Jun 11, 2022 at 10:14:07PM +0800, Liu Ying wrote:
> Patch 1/14 and 2/14 add bus formats used by pixel combiner.
Thanks!
For these:
Acked-by: Sakari Ailus
--
Sakari Ailus
i2c0 {
> #address-cells = <1>;
The definition doesn't seem to be used here. Is there a need to include
this?
I could drop this chunk while applying. There's just one trivial change
elsewhere in this patch to make.
--
Kind regards,
Sakari Ailus
patch. I can take these all if
people are fine with that.
--
Kind regards,
Sakari Ailus
e DRM_FORMAT_MOD_ALLWINNER_TILED fourcc_mod_code(ALLWINNER, 1)
>
> +/* Mobile Industry Processor Interface (MIPI) modifiers */
> +
> +/*
> + * MIPI CSI-2 packing layout
> + *
> + * The CSI-2 RAW formats (for example Bayer) use a different packing layout
> + * depenindg on
(Christophe de Dinechin)
>
> Cc: Hans Verkuil
> Cc: Andy Walls
> Cc: linux-me...@vger.kernel.org
> Cc: ivtv-de...@ivtvdriver.org
> Reviewed-by: Daniel Vetter
> Signed-off-by: Jani Nikula
Reviewed-by: Sakari Ailus
--
Sakari Ailus
___
s is part a tree-wide conversion, as described in commit fc1d8e7cca2d
> ("mm: introduce put_user_page*(), placeholder versions").
>
> Cc: Mauro Carvalho Chehab
> Cc: Kees Cook
> Cc: Hans Verkuil
> Cc: Sakari Ailus
> Cc: Jan Kara
> Cc: Robin Murphy
>
On Wed, May 26, 2021 at 09:21:10PM +0200, Thomas Zimmermann wrote:
> ping for further a-bs / r-bs
Thanks for the ping.
For the series:
Reviewed-by: Sakari Ailus
>
> Am 16.05.21 um 14:13 schrieb Thomas Zimmermann:
> > This is a cleanup patchset to remove drm_format_name_b
;
> + }
> + }
> + fwnode_handle_put(node);
> +
> node = fwnode_graph_get_remote_port_parent(ep);
> if (!fwnode_device_is_available(node)) {
> fwnode_handle_put(node);
--
Kind regards,
Sakari Ailus
Hi Pin-yen,
On Thu, Feb 09, 2023 at 12:28:33PM +0800, Pin-yen Lin wrote:
> Hi Sakari,
>
> Thanks for the review.
>
> On Mon, Feb 6, 2023 at 5:11 AM Sakari Ailus
> wrote:
> >
> > Hi Pin-yen,
> >
> > On Sat, Feb 04, 2023 at 09:30:32PM +0800, Pin-
>
> Signed-off-by: Prashant Malani
> Signed-off-by: Pin-yen Lin
Reviewed-by: Sakari Ailus
--
Sakari Ailus
+ if (matches)
> + matches[count] = ret;
> + count++;
> + }
> + }
Aren't you missing fwnode_handle-put(node) here??
> +
> node = fwnode_graph_get_remote_port_parent(ep);
> if (!fwnode_device_is_available(node)) {
> fwnode_handle_put(node);
--
Kind regards,
Sakari Ailus
Hi Prashant,
On Thu, Jan 12, 2023 at 02:31:45PM -0800, Prashant Malani wrote:
> HI Sakari,
>
> On Thu, Jan 12, 2023 at 5:32 AM Sakari Ailus
> wrote:
> >
> > Hi Pin-yen,
> >
> > On Thu, Jan 12, 2023 at 12:20:56PM +0800, Pin-yen Li
Hi Laurent,
On Sat, Nov 19, 2022 at 09:15:04PM +0200, Laurent Pinchart wrote:
> Hello,
>
> On Fri, Nov 18, 2022 at 06:23:38PM +0900, Paul Elder wrote:
> > Hi Sakari,
> >
> > Gentle ping.
> >
> > On Sun, Jul 17, 2022 at 06:54:00AM +, Sakari Ailus wro
Hi Laurent,
On Sat, Jul 16, 2022 at 06:12:05PM +0300, Laurent Pinchart wrote:
> Hi Sakari,
>
> On Sat, Jul 16, 2022 at 12:28:45PM +0300, Sakari Ailus wrote:
> > On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> > > Now that a header exists with macros
he series for
> the format definitions.
I think it'd be good to have only one set of definitions.
Can we can sort the endianness question in a reasonable way?
Also new Bayer formats will probably be still needed on V4L2 side but will
they be relevant for DRM? I suppose that would mean new DRM format for
each pixel order, too? Or can we think of something smarter that would
still work reasonably with existing formats?
--
Kind regards,
Sakari Ailus
gt; + * @privacy_led: Privacy LED associated with the sub-device.
> * @enabled_streams: Bitmask of enabled streams used by
> *v4l2_subdev_enable_streams() and
> *v4l2_subdev_disable_streams() helper functions for fallback
I'm not sure how this ever was an issue --- privacy_led field was
documented in the same patch that added it.
--
Kind regards,
Sakari Ailus
Hi Ricky,
On Mon, Dec 26, 2016 at 03:58:07PM +0800, Ricky Liang wrote:
> Hi Laurent,
>
> On Fri, Dec 16, 2016 at 9:24 AM, Laurent Pinchart
> wrote:
> > From: Sakari Ailus
> >
> > The desirable DMA attributes are not generic for all devices using
> > V
Hi Shuah,
On Mon, Mar 27, 2017 at 04:51:40PM -0600, Shuah Khan wrote:
> On Thu, Dec 15, 2016 at 6:24 PM, Laurent Pinchart
> wrote:
> > From: Sakari Ailus
> >
> > The struct vb2_dc_buf contains two struct sg_table fields: sgt_base and
> > dma_sgt. The former is u
The cache synchronisation may be a time consuming operation and thus not
best performed in an interrupt which is a typical context for
vb2_buffer_done() calls. This may consume up to tens of ms on some
machines, depending on the buffer size.
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
drivers specify DMA attrs")
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 90 --
1 file changed, 69 insertions(+), 21 deletions(-)
diff --git a/drivers/media/v4l2-core/videobuf2-dma-contig.c
b/drivers/media/v4l2-core/videobuf2-dma-co
The scatterlist should always be present when the cache would need to be
flushed. Each buffer type has its own means to provide that. Add
WARN_ON_ONCE() to check the scatterist exists.
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 8
Rename __qbuf_*() functions which are specific to a buffer type as
__prepare_*() which matches with what they do. The naming was there for
historical reasons; the purpose of the functions was changed without
renaming them.
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
Reviewed-by: Laurent
-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/media/v4l2-core/videobuf2-dma-contig.c
b/drivers/media/v4l2-core/videobuf2-dma-contig.c
index
The DMA attributes were available for the memop implementation for MMAP
buffers but not for USERPTR buffers. Do the same for USERPTR. This patch
makes no functional changes.
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 3 ++-
drivers/media/v4l2-core/videobuf2
Just move the function up. It'll be soon needed earlier than previously.
Signed-off-by: Sakari Ailus
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 40 +-
1 file changed, 20 insertions(+), 20 deletions(-)
The buffer cache should be synchronised in buffer preparation, not when
the buffer is queued to the device. Fix this.
Mmap buffers do not need cache synchronisation since they are always
coherent.
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
drivers/media/v4l2-core/videobuf2-core.c
finish vb2_mem_ops might not get called
every time the buffer ownership changes between the kernel and the user
space.
Signed-off-by: Samu Onkalo
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
drivers/media/v4l2-core/videobuf2-core.c | 101 +--
drivers/media
: Sakari Ailus
---
drivers/media/v4l2-core/videobuf2-dma-sg.c | 81 +++---
1 file changed, 62 insertions(+), 19 deletions(-)
diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c
b/drivers/media/v4l2-core/videobuf2-dma-sg.c
index 102ddb2..5662f00 100644
--- a/drivers
cache operation
(clean and invalidate, respectively). No user input is required.
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
Documentation/media/uapi/v4l/buffer.rst| 24 --
.../media/uapi/v4l/vidioc-prepare-buf.rst | 5 ++---
include/trace/e
no functional difference because the memory was initialised to
zero anyway.
Fixes: 00085f1e ("dma-mapping: use unsigned long for dma_attrs")
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
tes for USERPTR buffers.
- Unconditionally assign buf->attrs for MMAP buffers.
- Don't call vb2_dc_get_base_sgt() until buf->dev is set.
- Provide {begin,end}_cpu_access() dmabuf ops for cache management.
- Make similar changes to dma-sg memops to support DMA attributes.
Sakari Ailus
vb2_dc_get_base_sgt() which obtains the scatterlist already prints
information on why the scatterlist could not be obtained.
Also, remove the useless warning of a failed kmalloc().
Signed-off-by: Sakari Ailus
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
drivers/media/v4l2-core
The alloc() and put() ops are for MMAP buffers only. Document it.
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
---
include/media/videobuf2-core.h | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/include/media
The DMA attributes were available for the memop implementation for MMAP
buffers but not for USERPTR buffers. Do the same for USERPTR. This patch
makes no functional changes.
Signed-off-by: Sakari Ailus
---
since RFC v1:
- Add missing q->dma_attrs argument to call_ptr_memop(vb, get_user
Hi Marek,
On Thu, Apr 20, 2017 at 01:23:09PM +0200, Marek Szyprowski wrote:
> Hi Laurent,
>
> On 2017-04-20 12:25, Laurent Pinchart wrote:
> >Hi Marek,
> >
> >(CC'ing Sakari Ailus)
> >
> >Thank you for the patches.
> >
> >On Thursday 2
s to dma-sg memops to support DMA attributes.
Sakari Ailus (13):
vb2: Rename confusingly named internal buffer preparation functions
vb2: Move buffer cache synchronisation to prepare from queue
vb2: Move cache synchronisation from buffer done to dqbuf handler
v4l: Unify cache management hi
The buffer cache should be synchronised in buffer preparation, not when
the buffer is queued to the device. Fix this.
Mmap buffers do not need cache synchronisation since they are always
coherent.
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
drivers/media/v4l2-core/videobuf2-core.c
drivers specify DMA attrs")
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 94 --
1 file changed, 72 insertions(+), 22 deletions(-)
diff --git a/drivers/media/v4l2-core/videobuf2-dma-contig.c
b/drivers/media/v4l2-core/videobuf2-dma-co
cache operation
(clean and invalidate, respectively). No user input is required.
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
Documentation/media/uapi/v4l/buffer.rst| 24 --
.../media/uapi/v4l/vidioc-prepare-buf.rst | 5 ++---
include/trace/e
The scatterlist should always be present when the cache would need to be
flushed. Each buffer type has its own means to provide that. Add
WARN_ON_ONCE() to check the scatterist exists.
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 8
vb2_dc_get_base_sgt() which obtains the scatterlist already prints
information on why the scatterlist could not be obtained.
Also, remove the useless warning of a failed kmalloc().
Signed-off-by: Sakari Ailus
Reviewed-by: Laurent Pinchart
Acked-by: Hans Verkuil
---
drivers/media/v4l2-core
finish vb2_mem_ops might not get called
every time the buffer ownership changes between the kernel and the user
space.
Signed-off-by: Samu Onkalo
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
drivers/media/v4l2-core/videobuf2-core.c | 101 +--
drivers/media
Document when should the user specify V4L2_BUF_FLAG_NO_CACHE_SYNC flag.
Signed-off-by: Sakari Ailus
---
Documentation/media/uapi/v4l/buffer.rst | 21 +
1 file changed, 21 insertions(+)
diff --git a/Documentation/media/uapi/v4l/buffer.rst
b/Documentation/media/uapi/v4l
-off-by: Sakari Ailus
Acked-by: Hans Verkuil
---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/media/v4l2-core/videobuf2-dma-contig.c
b/drivers/media/v4l2-core/videobuf2-dma-contig.c
index
no functional difference because the memory was initialised to
zero anyway.
Fixes: 00085f1e ("dma-mapping: use unsigned long for dma_attrs")
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
The scatterlist table is needed in the vast majority of the cases.
Allocate struct sg_table as part of the struct. This has the benefit of
making managing the buffer data structure allocation, setup and release
more simple.
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/videobuf2-dma
en by the device, hence DMA_TO_DEVICE.
If an application can guarantee that it has not written to the buffer, it
can specify the V4L2_BUF_FLAG_NO_CACHE_SYNC flag to omit the sync
operation.
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 2 +-
drivers/media/v4l2
Set DMA_ATTR_NON_CONSISTENT for hardware that uses non-consistent memory.
Signed-off-by: Sakari Ailus
---
drivers/media/platform/omap3isp/ispvideo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/omap3isp/ispvideo.c
b/drivers/media/platform/omap3isp/ispvideo.c
index
The DMA attributes were available for the memop implementation for MMAP
buffers but not for USERPTR buffers. Do the same for USERPTR. This patch
makes no functional changes.
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/videobuf2-core.c | 2 +-
drivers/media/v4l2-core/videobuf2
The alloc() and put() ops are for MMAP buffers only. Document it.
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
Reviewed-by: Laurent Pinchart
---
include/media/videobuf2-core.h | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/include/media
: Sakari Ailus
---
drivers/media/v4l2-core/videobuf2-dma-sg.c | 81 +++---
1 file changed, 62 insertions(+), 19 deletions(-)
diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c
b/drivers/media/v4l2-core/videobuf2-dma-sg.c
index 102ddb2..5662f00 100644
--- a/drivers
There is no need synchronise buffer cache for OUTPUT devices when the
buffer is dequeued as the hardware only reads from the buffer. Only sync
for capture buffers.
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 5 +++--
drivers/media/v4l2-core/videobuf2-dma
Rename __qbuf_*() functions which are specific to a buffer type as
__prepare_*() which matches with what they do. The naming was there for
historical reasons; the purpose of the functions was changed without
renaming them.
Signed-off-by: Sakari Ailus
Acked-by: Hans Verkuil
Reviewed-by: Laurent
1 - 100 of 231 matches
Mail list logo
