Signed-off-by: Sachin Kamat
Fixes the following sparse warning:
drivers/gpu/drm/drm_info.c:238:5:
warning: symbol 'drm_gem_one_name_info' was not declared. Should it be static?
---
drivers/gpu/drm/drm_info.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/d
devm_* functions are device managed functions and make error handling
and cleanup cleaner and simpler.
Signed-off-by: Sachin Kamat
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 36 ++---
1 files changed, 7 insertions(+), 29 deletions
devm_* functions are device managed functions and make error handling
and cleanup cleaner and simpler.
Signed-off-by: Sachin Kamat
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 40 ++
1 files changed, 8 insertions(+), 32 deletions
devm_* functions are device managed functions and make error handling
and cleanup cleaner and simpler.
Signed-off-by: Sachin Kamat
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_mixer.c | 48 +---
1 files changed, 14 insertions(+), 34 deletions
On 27 April 2014 07:20, YoungJun Cho wrote:
> The offset of register DSIM_PLLTMR_REG in Exynos5420 is different
> from the one in Exynos4 SoC.
>
> In case of Exynos5420 SoC, there is no frequency band bit in DSIM_PLLCTRL_REG,
> and it uses DSIM_PHYCTRL_REG and DSIM_PHYTIMING*_REG instead.
> So thi
Hi YoungJun,
On 27 April 2014 07:20, YoungJun Cho wrote:
> To support MIPI DSI command mode interface, FIMD should do followings:
> - Sets LCD block configuration for I80 interface.
> - Uses "lcd_sys" as an IRQ resource and sets relevant IRQ configuration.
> - Implements trigger feature which tra
Hi YoungJun,
On 15 April 2014 11:17, YoungJun Cho wrote:
> This patch adds common part of dsi node.
>
> Signed-off-by: YoungJun Cho
> Signed-off-by: Inki Dae
> Signed-off-by: Kyungmin Park
> ---
> arch/arm/boot/dts/exynos5420.dtsi | 14 ++
> 1 file changed, 14 insertions(+)
>
>
On 15 April 2014 11:17, YoungJun Cho wrote:
> This patch adds exynos5420 SoC support.
This patch just updates binding documentation :)
> Signed-off-by: YoungJun Cho
> Signed-off-by: Inki Dae
> Signed-off-by: Kyungmin Park
> ---
> .../devicetree/bindings/video/exynos_dsim.txt |4 +++-
On 15 April 2014 11:17, YoungJun Cho wrote:
> This patch adds sysreg device node, and sysreg property to fimd device node
> which is required to use I80 interface.
>
> Signed-off-by: YoungJun Cho
> Signed-off-by: Inki Dae
> Signed-off-by: Kyungmin Park
> ---
> arch/arm/boot/dts/exynos5.dtsi |
On 15 April 2014 14:48, Sylwester Nawrocki wrote:
> On 15/04/14 10:41, Sachin Kamat wrote:
>> On 15 April 2014 11:17, YoungJun Cho wrote:
>>> This patch adds sysreg device node, and sysreg property to fimd device node
>>> which is required to use I80 interface.
>
Hi YoungJun,
On 15 April 2014 11:17, YoungJun Cho wrote:
> This patch adds sysreg support for exynos5 SoCs.
The patch title and commit description seem a bit off here. This patch does
not add support per se. It only updates the binding documentaion.
--
With warm regards,
Sachin
On 15 April 2014 11:17, YoungJun Cho wrote:
> This patch adds DT bindings for s6e3fa0 panel.
> The bindings describes panel resources, display timings, delays
> and physical size.
>
> Signed-off-by: YoungJun Cho
> Signed-off-by: Inki Dae
> Signed-off-by: Kyungmin Park
> ---
> .../devicetree/bi
Remove local definitions and use the ones provided by hdmi.h.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 66 ++
1 file changed, 26 insertions(+), 40 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm
On 4 February 2014 05:05, Sean Paul wrote:
> On Mon, Feb 3, 2014 at 7:14 AM, Inki Dae wrote:
>> 2014-01-31 Josh Boyer :
>>> On Fri, Jan 31, 2014 at 1:09 AM, Sachin Kamat
>>> wrote:
>>>> 'hdmi_infoframe' is already defined in include/linux/hd
Hi Andrzej,
On 12 February 2014 17:01, Andrzej Hajda wrote:
> The patch adds power domain for display subsystem.
>
> Signed-off-by: Andrzej Hajda
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/a
+cc Inki Dae
Looks like you missed CCing Exynos DRM maintainers.
On 12 February 2014 17:01, Andrzej Hajda wrote:
> In case fbdev is initialized before any output is connected,
> fb resolution defaults to 1024x768. After that any output with
> bigger resolution is ignored and fbdev is not display
On 1 February 2013 06:57, Inki Dae wrote:
>
> For example,
> If compatible = "samsung,g2d-3.0" is added to exynos4210.dtsi, it'd be
> reasonable. But what if that compatible string is added to exynos4.dtsi?.
> This case isn't considered for exynos4412 SoC with v4.1.
In case of Exynos4 series the
>> In any case please let me know the final preferred one so that I can
>> update the code send the revised patches.
>
> The version with SoC name embedded in it seems most reliable and correct
> to me.
>
> compatible = "samsung,exynos3110-fimg-2d" /* for Exynos3110 (S5PC110,
> S5PV210),
>
On 1 February 2013 17:02, Inki Dae wrote:
>
> How about using like below?
> Compatible = ""samsung,exynos4x12-fimg-2d" /* for Exynos4212,
> Exynos4412 */
> It looks odd to use "samsung,exynos4212-fimg-2d" saying that this ip is for
> exynos4212 and exynos4412.
AFAIK, compatible strings a
On 1 February 2013 18:28, Inki Dae wrote:
>
>
>
>
> 2013. 2. 1. ?? 8:52 Inki Dae ??:
>
>>
>>
>>> -Original Message-
>>> From: linux-media-owner at vger.kernel.org [mailto:linux-media-
>>> owner at vger.kernel.org] On Behalf Of
On 5 February 2013 15:03, Sylwester Nawrocki wrote:
> On 02/05/2013 04:03 AM, Inki Dae wrote:
> [...]
>>> Exynos4210 has same g2d IP (v3.0) as C110 or V210; so the same
>>> comptible string will be used for this one too.
>>>
And please check if exynos4212 and 4412 SoCs have same fimg-2d ip.
>
This patch adds device tree based discovery support to G2D driver
Signed-off-by: Sachin Kamat
---
Based on for_v3.9 branch of below tree:
git://linuxtv.org/snawrocki/samsung.git
Changes since v1:
* Addressed review comments from Sylwester .
* Modified the compatible string as per the
From: Ajay Kumar
This patch adds device tree match table for Exynos G2D controller.
Signed-off-by: Ajay Kumar
Signed-off-by: Sachin Kamat
---
Patch based on exynos-drm-fixes branch of Inki Dae's tree:
git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git
Changes sin
On 6 February 2013 13:02, Inki Dae wrote:
>
> Looks good to me but please add document for it.
Yes. I will. I was planning to send the bindings document patch along
with the dt patches (adding node entries to dts files).
Sylwester had suggested adding this to
Documentation/devicetree/bindings/med
On 6 February 2013 16:53, Sylwester Nawrocki wrote:
> On 02/06/2013 09:51 AM, Inki Dae wrote:
> [...]
> So I propose following classification, which seems less inaccurate:
>
> GPU: g2d, g3d
> Media: mfc, fimc, fimc-lite, fimc-is, mipi-csis, gsc
> Video: fimd, hdmi, eDP, mipi-dsim
Thanks Inki a
On Tuesday, 12 February 2013, Inki Dae wrote:
> Applied and will go to -next.
Thanks.
> And please post the document(in
> Documentation/devicetree/bindings/gpu/) for it later
Already posted (1).
(1) http://patches.linaro.org/14640/
--
With warm regards,
Sachin
-- next part --
Hi Sylwester,
On Wednesday, 6 February 2013, Sachin Kamat wrote:
> This patch adds device tree based discovery support to G2D driver
>
> Signed-off-by: Sachin Kamat
> ---
> Based on for_v3.9 branch of below tree:
> git://linuxtv.org/snawrocki/samsung.git
>
> Changes
On Thursday, 14 February 2013, Sylwester Nawrocki <
sylvester.nawrocki at gmail.com> wrote:
> On 02/12/2013 06:30 PM, Sachin Kamat wrote:
>>
>> Hi Sylwester,
>>
>> On Wednesday, 6 February 2013, Sachin Kamat
wrote:
>>>
>>> This patch add
Hi Vikas,
Some nitpicks inline
Subject: s/Complaint/Compliant
On 2 January 2013 18:47, Vikas C Sajjan wrote:
> From: Vikas Sajjan
>
Please add some description about this patch here.
> Signed-off-by: Vikas Sajjan
> ---
> drivers/video/exynos/exynos_mipi_dsi.c| 46
> +
+CC: ALSA mailing list, Mark Brown
On 13 January 2013 18:22, Rahul Sharma wrote:
> This patch registers hdmi-audio codec to the ALSA framework. This is the
> second
> client to the hdmi panel. Once notified by the CDF Core it proceeds towards
> audio setting and audio control. It also subscribes
Fixes the following warning:
drivers/gpu/drm/exynos/exynos_drm_g2d.c:327:12: warning:
symbol 'g2d_userptr_get_dma_addr' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +-
1 files changed, 1 insertions(+), 1
Fixes the following warning:
drivers/gpu/drm/exynos/exynos_drm_ipp.c:872:6: warning:
symbol 'ipp_handle_cmd_work' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c |2 +-
1 files changed, 1 insertions(+), 1 deletion
atic?
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_rotator.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c
b/drivers/gpu/drm/exynos/exynos_drm_rotator.c
index e9e83ef..f976e29 100644
--- a/dr
Fixes the following warning:
drivers/gpu/drm/exynos/exynos_drm_hdmi.c:111:13: warning:
symbol 'drm_hdmi_get_edid' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
---
Compile tested on exynos-drm-fixes branch of Inki Dae's tree.
---
drivers/gpu/drm/exynos/ex
This patch adds device tree based discovery support to G2D driver
Signed-off-by: Sachin Kamat
---
drivers/media/platform/s5p-g2d/g2d.c | 17 -
1 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/drivers/media/platform/s5p-g2d/g2d.c
b/drivers/media/platform/s5p-g2d
Fixes the following checkpatch warning:
WARNING: sizeof *sgt should be sizeof(*sgt)
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
b/drivers/gpu/drm/exynos
From: Ajay Kumar
This patch adds device tree match table for Exynos G2D controller.
Signed-off-by: Ajay Kumar
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/exynos
Hi Vikas,
This patch should be numbered 0/1 as it is not a patch in itself and
the subsequent patch should be 1/1 so as to show that these 2 together
form a series.
Also, your subject line seems to have been truncated.
On 28 January 2013 11:15, Vikas Sajjan wrote:
> This patch adds display-timi
Hi Vikas,
Changelog mentioning differences between v1 and v2 is generally
preferred as it will help the reviewers.
On 30 January 2013 12:00, Vikas Sajjan wrote:
> This patch adds display-timing node parsing to drm fimd, this depends on
> the display helper patchset at
> http://lists.freedesktop.
Hi Sylwester.
Thank you for the review.
On 31 January 2013 03:08, Sylwester Nawrocki
wrote:
> Hi Sachin,
>
>
> On 01/25/2013 10:55 AM, Sachin Kamat wrote:
>>
>> This patch adds device tree based discovery support to G2D driver
>>
>> Signed-off-by: Sachin Kama
On 16 January 2014 10:51, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Sachin Kamat [mailto:sachin.kamat at linaro.org]
>> Sent: Thursday, January 16, 2014 12:32 PM
>> To: dri-devel at lists.freedesktop.org
>> Cc: inki.dae at samsung.com; jy092
Semicolon after a switch statement is not needed.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
index 7bccedc
Hi Tushar,
On 15 January 2014 17:27, Tushar Behera wrote:
> There is no need to include "plat/map-base.h" in ipp driver. Remove
> this and enable this driver for multi-platform.
>
> Signed-off-by: Tushar Behera
drivers/gpu/drm/exynos/exynos_drm_gsc.c also has this header file included.
If this
Fixes the following errors:
drivers/gpu/drm/exynos/exynos_drm_drv.c:182 exynos_drm_open()
error: double free of 'file_priv'
drivers/gpu/drm/exynos/exynos_drm_drv.c:188 exynos_drm_open()
error: dereferencing freed memory 'file_priv'
Signed-off-by: Sachin Kamat
---
dr
Changed quf -> qbuf.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c
b/drivers/gpu/drm/exynos/exynos_drm_ipp.c
index 824e070..6665f5f 100644
--- a/drivers/
rencing freed memory 'file_priv'
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_drv.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c
b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index 9d096a0..ee84a7b6 10064
Hi Inki,
Does this patch look good now?
On 16 January 2014 11:31, Sachin Kamat wrote:
> Fixes the following errors:
> drivers/gpu/drm/exynos/exynos_drm_drv.c:182 exynos_drm_open()
> error: double free of 'file_priv'
> drivers/gpu/drm/exynos/exynos_drm_drv.c:188 exy
?hdmi_infoframe? is already defined in include/linux/hdmi.h.
Rename the local variable to avoid the following build error:
drivers/gpu/drm/exynos/exynos_hdmi.c:382:8: error: ?hdmi_infoframe? defined as
wrong kind of tag
struct hdmi_infoframe {
Signed-off-by: Sachin Kamat
Reported-by: Josh
Hi Josh,
On 30 January 2014 22:17, Josh Boyer wrote:
> Hi All,
>
> After the DRM merge, the exynos_hdmi.c file fails to build with our
> ARM config. The error is:
>
> drivers/gpu/drm/exynos/exynos_hdmi.c:382:8: error: 'hdmi_infoframe'
> defined as wrong kind of tag
> struct hdmi_infoframe {
>
'frame_size_code' is not used in the function. Remove it.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
ind
'exynos_gem_obj' is not used in the function. Remove it.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_gem.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c
b/drivers/gpu/drm/exynos/exynos_drm_gem.c
index 163a05
From: Sachin Kamat
Makes the code a bit more readable.
Signed-off-by: Sachin Kamat
Signed-off-by: Sachin Kamat
Acked-by: Laurent Pinchart
---
drivers/gpu/drm/drm_gem_cma_helper.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_gem_cma_helper.c
b
ivers/gpu/drm/tilcdc/tilcdc.ko]
undefined!
Signed-off-by: Sachin Kamat
CC: Thomas Wood
CC: David Herrmann
CC: Daniel Vetter
---
Only compile tested.
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c |2 +-
drivers/gpu/drm/tilcdc/tilcdc_slave.c |2 +-
drivers/gpu/drm/tilcdc/tilcdc_tfp410.
This series fixes some checkpatch warnings and errors in drm_fb_helper.c file.
Build tested using the linux-next tree of 20121114.
Sachin Kamat (3):
drm/fb_helper: Fix checkpatch errors
drm/fb_helper: Convert printk to pr_* and dev_*
drm/drm_fb_helper: Remove unnecessary braces
drivers
DIGITAL: s = "ON - dig"; break;
ERROR: trailing statements should be on next line
101: FILE: gpu/drm/drm_fb_helper.c:101:
case DRM_FORCE_ON: s = "ON"; break;
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/drm_fb_helper.c | 12 +---
1 files changed, 9 inser
Converted printks to pr_* and dev_* to silence checkpatch warnings.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/drm_fb_helper.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index
Remove unnecessary braces to silence the following type of
checkpatch warnings:
WARNING: braces {} are not necessary for single statement blocks
WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/drm_fb_helper.c | 23
static?
drivers/gpu/drm/udl/udl_connector.c:106:35: warning:
symbol 'udl_connector_helper_funcs' was not declared. Should it be static?
drivers/gpu/drm/udl/udl_connector.c:112:28: warning:
symbol 'udl_connector_funcs' was not declared. Should it be static?
Signed-off-by
Fixes the following sparse warning:
drivers/gpu/drm/exynos/exynos_drm_fimd.c:65:25: warning:
symbol 'exynos4_fimd_driver_data' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c |2 +-
1 files changed, 1 insertions(+), 1
Fixes the following sparse warning:
drivers/gpu/drm/exynos/exynos_drm_fimd.c:69:25: warning:
symbol 'exynos5_fimd_driver_data' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c |2 +-
1 files changed, 1 insertions(+), 1
Check overlay_ops is not NULL as checked in the previous 'if' condition.
Fixes the following smatch error:
drivers/gpu/drm/exynos/exynos_drm_encoder.c:509
exynos_drm_encoder_plane_disable()
error: we previously assumed 'overlay_ops' could be null (see line 499)
Signed-
kfree() on a NULL input is a no-op. Hence remove the check.
Signed-off-by: Sachin Kamat
---
This series is build tested on the latest linux-next (20121115).
---
drivers/gpu/drm/drm_crtc.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc.c b
error: potential null dereference 'connector->edid_blob_ptr'.
(drm_property_create_blob returns null)
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/drm_crtc.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_c
rs/gpu/drm/drm_fb_helper.c:1272 drm_setup_crtcs() error:
potential null dereference 'crtcs'. (kcalloc returns null)
Signed-off-by: Sachin Kamat
---
Dependent on the following patch series:
http://comments.gmane.org/gmane.comp.video.dri.devel/76605
---
drivers/gpu/drm/drm_fb_helper.c |
kfree on a null argument is a no-op.
Silences the following smatch warning:
drivers/gpu/drm/drm_stub.c:496 drm_put_dev() info:
redundant null check on dev->devname calling kfree()
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/drm_stub.c |5 +
1 files changed, 1 insertions(+)
Hi Inki,
Thanks for your review. My comments inline.
On 19 November 2012 15:14, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Sachin Kamat [mailto:sachin.kamat at linaro.org]
>> Sent: Monday, November 19, 2012 6:21 PM
>> To: dri-devel at lists.free
On 19 November 2012 15:15, Inki Dae wrote:
> Please, combine these patches.
OK. I will re-send.
>
> Thanks,
> Inki Dae
>
>> -Original Message-
>> From: Sachin Kamat [mailto:sachin.kamat at linaro.org]
>> Sent: Monday, November 19, 2012 5:38 PM
>>
Should it be static?
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 130a2b5..e08478f 100644
--- a/dr
On 19 November 2012 15:30, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Sachin Kamat [mailto:sachin.kamat at linaro.org]
>> Sent: Monday, November 19, 2012 6:56 PM
>> To: Inki Dae
>> Cc: dri-devel at lists.freedesktop.org; jy0922.shim at s
nouveau_ttm.h was included twice.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/nouveau/nouveau_drm.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c
b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 0910125..a1e3fed 100644
--- a
core/device.h was included twice.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/nouveau/core/subdev/device/base.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/core/subdev/device/base.c
b/drivers/gpu/drm/nouveau/core/subdev/device/base.c
Use IS_ERR instead of IS_ERR_OR_NULL on clk_get results.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index
Use IS_ERR instead of IS_ERR_OR_NULL on clk_get results.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_mixer.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
b/drivers/gpu/drm/exynos/exynos_mixer.c
index
Use IS_ERR instead of IS_ERR_OR_NULL on clk_get results.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_rotator.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c
b/drivers/gpu/drm/exynos
On 11 March 2013 15:38, Sachin Kamat wrote:
> Hi Rob,
>
> On 2 March 2013 20:40, Rob Clark wrote:
>> On Sat, Mar 2, 2013 at 5:23 AM, Sachin Kamat
>> wrote:
>>> Instead of checking if num_encoders is zero, it is being assigned 0.
>>> Convert the assig
On 25 March 2013 19:06, Rob Clark wrote:
> sorry, was offline for a while (moving), and missed the last email..
No problem :)
>
> I would guess that Tomi would send pull-req for tilcdc and omapdrm.
> Well I suppose I could do it if Tomi can't, although my
> pandas/beagles/beaglebones are not unpa
drm_add_edid_modes() returns 0 upon failure to find any modes.
Hence check for 0 and not less than 0.
Signed-off-by: Sachin Kamat
Cc: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_drm_connector.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos
On 27 March 2013 16:06, Inki Dae wrote:
> 2013/3/21 Sachin Kamat :
>> drm_add_edid_modes() returns 0 upon failure to find any modes.
>> Hence check for 0 and not less than 0.
>>
>> Signed-off-by: Sachin Kamat
>> Cc: Rahul Sharma
>> ---
>> drivers
Hi Wei Yongjun,
On 7 May 2013 18:54, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
> ipp_create_cmd_work() return ERR_PTR() on error and never return
> NULL, so use IS_ERR() instead
'mixer_match_types' is always compiled in. Hence of_match_ptr is not
necessary.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_mixer.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
b/drivers/gpu/
PTR_RET is now deprecated. Use PTR_ERR_OR_ZERO instead.
Signed-off-by: Sachin Kamat
---
Compile tested and based on the following tree:
git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git (PTR_RET)
Dependent on [1]
[1] http://lkml.indiana.edu/hypermail/linux/kernel/1306.2/00010.html
Since Exynos DRM drivers do not support module build,
remove module.h header file inclusion from files that do
not have any users.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_ddc.c |1 -
drivers/gpu/drm/exynos/exynos_drm_fimc.c|1 -
drivers/gpu/drm/exynos
On 26 July 2013 07:00, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Sachin Kamat [mailto:sachin.kamat at linaro.org]
>> Sent: Wednesday, July 24, 2013 1:43 PM
>> To: dri-devel at lists.freedesktop.org
>> Cc: inki.dae at samsung.com; jy0922.sh
Remove module.h header file inclusion from files since they do
not use/refer to any code from that file.
Signed-off-by: Sachin Kamat
---
Modified the commit message.
---
drivers/gpu/drm/exynos/exynos_ddc.c |1 -
drivers/gpu/drm/exynos/exynos_drm_fimc.c|1 -
drivers/gpu/drm
On 26 July 2013 12:51, Inki Dae wrote:
>
>
>> -Original Message-----
>> From: Sachin Kamat [mailto:sachin.kamat at linaro.org]
>> Sent: Friday, July 26, 2013 11:51 AM
>> To: Inki Dae
>> Cc: dri-devel at lists.freedesktop.org; jy0922.shim at samsung.com;
>
'break' after goto statement is redundant. Silences the following
message:
drivers/gpu/drm/exynos/exynos_drm_ipp.c:1067 exynos_drm_ipp_check_valid()
info: ignoring unreachable code.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c |1 -
1 file changed,
Fixes the following sparse warning:
drivers/gpu/drm/exynos/exynos_mixer.c:821:5: warning:
symbol 'mixer_check_timing' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/exynos/exynos_mixer.c |2 +-
1 files changed, 1 insertions(+), 1 deletion
This patch series is only compile tested and based on linux-next
tree of 20130301.
Sachin Kamat (4):
drm/tilcdc: Fix an incorrect condition
drm/tilcdc: Remove unnecessary braces
drm/tilcdc: Remove space before tab
drm/tilcdc: Fix checkpatch error in tilcdc_panel.c
drivers/gpu/drm/tilcdc
Instead of checking if num_encoders is zero, it is being assigned 0.
Convert the assignment to a check.
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
b/drivers
Silences the following checkpatch warning:
WARNING: braces {} are not necessary for any arm of this statement
if (priv->rev == 1) {
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c |5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/driv
Silences the following checkpatch warning:
WARNING: please, no space before tabs
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
b/drivers/gpu/drm/tilcdc
Fixes the following checkpatch error:
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Sachin Kamat
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
b/dr
Hi Rob,
On 2 March 2013 20:40, Rob Clark wrote:
> On Sat, Mar 2, 2013 at 5:23 AM, Sachin Kamat
> wrote:
>> Instead of checking if num_encoders is zero, it is being assigned 0.
>> Convert the assignment to a check.
>>
>> Signed-off-by: Sachin Kamat
>
> Sig
On 19 March 2013 15:29, Vikas Sajjan wrote:
> While migrating to common clock framework (CCF), found that the FIMD clocks
> were pulled down by the CCF.
> If CCF finds any clock(s) which has NOT been claimed by any of the
> drivers, then such clock(s) are PULLed low by CCF.
>
> By calling clk_prep
drm_add_edid_modes() returns 0 upon failure to find any modes.
Hence check for 0 and not less than 0.
Signed-off-by: Sachin Kamat
Cc: Rahul Sharma
---
drivers/gpu/drm/exynos/exynos_drm_connector.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos
301 - 395 of 395 matches
Mail list logo
