[PATCH 4/4] drm/drm_stub: Remove unnecessary null check before kfree.

kfree on a null argument is a no-op. Silences the following smatch warning: drivers/gpu/drm/drm_stub.c:496 drm_put_dev() info: redundant null check on dev->devname calling kfree() Signed-off-by: Sachin Kamat --- drivers/gpu/drm/drm_stub.c |5 + 1 files changed, 1 insertions(+)

Re: [PATCH 1/1] drm/exynos: Fix potential NULL pointer dereference in exynos_drm_encoder.c

Hi Inki, Thanks for your review. My comments inline. On 19 November 2012 15:14, Inki Dae wrote: > > >> -Original Message----- >> From: Sachin Kamat [mailto:sachin.ka...@linaro.org] >> Sent: Monday, November 19, 2012 6:21 PM >> To: dri-devel@lists.freedesktop.o

Re: [PATCH 1/2] drm/exynos: Make exynos4_fimd_driver_data static

On 19 November 2012 15:15, Inki Dae wrote: > Please, combine these patches. OK. I will re-send. > > Thanks, > Inki Dae > >> -Original Message- >> From: Sachin Kamat [mailto:sachin.ka...@linaro.org] >> Sent: Monday, November 19, 2012 5:38 PM >> To

[PATCH Resend] drm/exynos: Make exynos4/5_fimd_driver_data static

Should it be static? Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_fimd.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 130a2b5..e08478f 100644 --- a/dr

Re: [PATCH 1/1] drm/exynos: Fix potential NULL pointer dereference in exynos_drm_encoder.c

On 19 November 2012 15:30, Inki Dae wrote: > > >> -Original Message----- >> From: Sachin Kamat [mailto:sachin.ka...@linaro.org] >> Sent: Monday, November 19, 2012 6:56 PM >> To: Inki Dae >> Cc: dri-devel@lists.freedesktop.org; jy0922.s...@samsung.com;

[PATCH 1/1] drm/nouveau: remove duplicate inclusion of nouveau_ttm.h

nouveau_ttm.h was included twice. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/nouveau/nouveau_drm.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index 0910125..a1e3fed 100644 --- a

[PATCH 1/1] drm/nouveau/device: Remove duplicate inclusion of core/device.h

core/device.h was included twice. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/nouveau/core/subdev/device/base.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/nouveau/core/subdev/device/base.c b/drivers/gpu/drm/nouveau/core/subdev/device/base.c

Re: [PATCH 1/4] drm/crtc: Remove redundant NULL check before kfree

Hi Dave, Please ignore this patch. On 19 November 2012 15:14, Sachin Kamat wrote: > kfree() on a NULL input is a no-op. Hence remove the check. > > Signed-off-by: Sachin Kamat > --- > This series is build tested on the latest linux-next (20121115). > --- > drivers/gpu/

Re: [PATCH 1/4] drm/crtc: Remove redundant NULL check before kfree

On 21 November 2012 20:42, Sachin Kamat wrote: > Hi Dave, > > Please ignore this patch. > > Please ignore this mail. Sorry for the noise. -- With warm regards, Sachin ___ dri-devel mailing list dri-devel@lists.freed

Re: [PATCH 1/1] drm/exynos: Fix potential NULL pointer dereference in exynos_drm_encoder.c

Hi Inki, On 19 November 2012 15:32, Sachin Kamat wrote: > On 19 November 2012 15:30, Inki Dae wrote: >> >> >>> -Original Message- >>> From: Sachin Kamat [mailto:sachin.ka...@linaro.org] >>> Sent: Monday, November 19, 2012 6:56 PM >>> T

Re: [PATCH 1/1] drm/exynos: Fix potential NULL pointer dereference in exynos_drm_encoder.c

[snip] >> >> And NULL pointer checking was already done above like below, >> >> if (overlay_ops && overlay_ops->disable) >> >> overlay_ops->disable(manager->dev, zpos); >> > Correct. But that check is applicable only for that one statement >> > (overlay_ops->disable(manager-

[PATCH 3/5] drm/exynos: Use devm_clk_get in exynos_mixer.c

devm_clk_get is device managed and makes error handling and exit code simpler. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_mixer.c | 20 +--- 1 files changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu

[PATCH 0/5] drm/exynos: Bug fix and devm_* usage

First 4 patches use devm_* APIs for simpler code and cleanup. Last one fixes a potential bug. Series is build tested and based on the exynos-drm-next branch of the following tree: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git Sachin Kamat (5): drm/exynos: Use

[PATCH 1/5] drm/exynos: Use devm_clk_get in exynos_drm_fimd.c

devm_clk_get is device managed and makes error handling and exit code simpler. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_fimd.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm

[PATCH 2/5] drm/exynos: Use devm_gpio_request in exynos_hdmi.c

devm_gpio_request is device managed and makes error handling and exit code simpler. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_hdmi.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos

[PATCH 4/5] drm/exynos: Use devm_clk_get in exynos_drm_g2d.c

devm_clk_get is device managed and makes error handling and exit code simpler. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_g2d.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos

[PATCH 5/5] drm/exynos: Fix potential NULL pointer dereference

Pointer was being dereferenced after freeing. Fixes the following error: drivers/gpu/drm/exynos/exynos_drm_g2d.c:323 g2d_userptr_put_dma_addr() error: dereferencing freed memory 'g2d_userptr' Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +- 1 files

Re: [PATCH 1/5] drm/exynos: Use devm_clk_get in exynos_drm_fimd.c

On 23 November 2012 12:10, Inki Dae wrote: > > >> -Original Message----- >> From: Sachin Kamat [mailto:sachin.ka...@linaro.org] >> Sent: Friday, November 23, 2012 12:42 PM >> To: dri-devel@lists.freedesktop.org >> Cc: inki@samsung.com; jy092

Re: [PATCH 2/5] drm/exynos: Use devm_gpio_request in exynos_hdmi.c

On 23 November 2012 12:21, Inki Dae wrote: [snip] > With cleanup to hdmi_resources_init, we can remove hdmi_resource_cleanup > function. So could you please re-send updated patches? OK. I will update and re-send. > > You've been submitting patches into too small pieces. > Because they are trivi

[PATCH Resend] drm/exynos: Use devm_clk_get in exynos_mixer.c

devm_clk_get is device managed and makes error handling and exit code simpler. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_mixer.c | 59 + 1 files changed, 16 insertions(+), 43 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c

[PATCH Resend] drm/exynos: Use devm_* APIs in exynos_hdmi.c

devm_* functions are device managed and make error handling and exit code simpler. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_hdmi.c | 60 +++-- 1 files changed, 13 insertions(+), 47 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c

[PATCH Resend] drm/exynos: Use devm_clk_get in exynos_drm_fimd.c

devm_clk_get is device managed and makes error handling and exit code simpler. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 31 ++--- 1 files changed, 7 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c

Re: [PATCH Resend] drm/exynos: Use devm_clk_get in exynos_drm_fimd.c

; you send another one? Sorry for inconvenient. :) He he.. no problem.. i will send another patch which just contains removing clk_disable. > > Thanks, > Inki Dae > >> -----Original Message- >> From: Sachin Kamat [mailto:sachin.ka...@linaro.org] >> Sent

[PATCH 1/1] drm/exynos: remove unnecessary clk_disable calls in exynos_drm_fimd.c

Also fixes an error related to returning 'ret' without initialising with error code. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 22 +- 1 files changed, 5 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_

[PATCH Resend] drm/exynos: Use devm_clk_get in exynos_drm_fimd.c

devm_clk_get is device managed and makes error handling and exit code simpler. Also fixes an error related to returning 'ret' without initialising with error code. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 31 ++--- 1 files

Re: [PATCH 1/1] drm/exynos: remove unnecessary clk_disable calls in exynos_drm_fimd.c

Ok. Mailed you the combined patch. On 24 November 2012 11:10, Inki Dae wrote: > > >> -Original Message----- >> From: Sachin Kamat [mailto:sachin.ka...@linaro.org] >> Sent: Friday, November 23, 2012 7:06 PM >> To: dri-devel@lists.freedesktop.org >>

Re: [PATCH 1/1] drm/nouveau: remove duplicate inclusion of nouveau_ttm.h

ping On 20 November 2012 11:23, Sachin Kamat wrote: > nouveau_ttm.h was included twice. > > Signed-off-by: Sachin Kamat > --- > drivers/gpu/drm/nouveau/nouveau_drm.c |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/no

Re: [PATCH 1/1] drm/nouveau/device: Remove duplicate inclusion of core/device.h

ping.. On 20 November 2012 11:35, Sachin Kamat wrote: > core/device.h was included twice. > > Signed-off-by: Sachin Kamat > --- > drivers/gpu/drm/nouveau/core/subdev/device/base.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu

Re: [PATCH 1/1] drm/nouveau: remove duplicate inclusion of nouveau_ttm.h

On 27 November 2012 09:09, Ben Skeggs wrote: > On Tue, 2012-11-27 at 09:04 +0530, Sachin Kamat wrote: >> ping >> >> On 20 November 2012 11:23, Sachin Kamat wrote: >> > nouveau_ttm.h was included twice. > I've queued it in my tree, thanks! Thanks Ben. There

[PATCH 1/1] drm/i915: Remove duplicate inclusion of drm/drm_edid.h

drm/drm_edid.h was included twice. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/i915/intel_modes.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_modes.c b/drivers/gpu/drm/i915/intel_modes.c index b00f1c8..49249bb 100644 --- a/drivers/gpu

[PATCH 1/1] drm/nv50/disp: Remove duplicate inclusion of header file

subdev/bar.h was included twice. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/nouveau/core/engine/disp/nv50.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/nouveau/core/engine/disp/nv50.c b/drivers/gpu/drm/nouveau/core/engine/disp/nv50.c index

[PATCH 1/2] drm/exynos: hdmi: Add CONFIG_OF and use of_match_ptr() macro

Add CONFIG_OF to compile conditionally. of_match_ptr eliminates having an #ifdef returning NULL for the case when OF is disabled. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_ddc.c |4 +++- drivers/gpu/drm/exynos/exynos_hdmi.c|4 +++- drivers/gpu/drm/exynos

[PATCH 2/2] drm/exynos: hdmi: Fix potential NULL pointer dereference error

This is an unlikely case. However to silence the following smatch error add a NULL check: drivers/gpu/drm/exynos/exynos_hdmi.c:2486 hdmi_probe() error: potential NULL dereference 'match'. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_hdmi.c |2 ++ 1 files

[PATCH 00/10] drm/exynos: Cleanup and update IPP drivers

Compile tested against linux-next tree (20121224). Sachin Kamat (10): drm/exynos: Use devm_kzalloc in exynos_drm_ipp.c drm/exynos: Remove explicit freeing using devm_* APIs in exynos_drm_fimc.c drm/exynos: Remove redundant NULL check drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

[PATCH 01/10] drm/exynos: Use devm_kzalloc in exynos_drm_ipp.c

devm_kzalloc makes the code simpler by eliminating the need for explicit freeing. Cc: Eunchul Kim Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_ipp.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b

[PATCH 02/10] drm/exynos: Remove explicit freeing using devm_* APIs in exynos_drm_fimc.c

devm_* APIs are device managed and get freed automatically when the device detaches. Thus explicit freeing is not needed. This saves some code. Cc: Eunchul Kim Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 30 +- 1 files changed, 9

[PATCH 03/10] drm/exynos: Remove redundant NULL check

devm_request_and_ioremap API checks for NULL. Hence explicit NULL check is not necessary. Saves some code. Cc: Eunchul Kim Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_fimc.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 04/10] drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

This eliminates the need for explicit clk_put and makes the cleanup and exit path code simpler. Cc: Eunchul Kim Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 46 ++--- 1 files changed, 10 insertions(+), 36 deletions(-) diff --git a

[PATCH 05/10] drm/exynos: Remove unnecessary devm_* freeing APIs in exynos_drm_rotator.c

devm_* APIs are device managed and get freed automatically when the device detaches. Thus explicit freeing is not needed. This saves some code. Cc: Eunchul Kim Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_rotator.c | 18 -- 1 files changed, 4 insertions

[PATCH 06/10] drm/exynos: Remove redundant NULL check in exynos_drm_rotator.c

devm_request_and_ioremap API checks for NULL. Hence explicit NULL check is not necessary. Saves some code. Cc: Eunchul Kim Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_rotator.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 07/10] drm/exynos: Use devm_clk_get in exynos_drm_rotator.c

This eliminates the need for explicit clk_put and makes the cleanup and exit path code simpler. Cc: Eunchul Kim Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_rotator.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos

[PATCH 08/10] drm/exynos: Remove explicit freeing using devm_* APIs in exynos_drm_gsc.c

devm_* APIs are device managed and get freed automatically when the device detaches. Thus explicit freeing is not needed. This saves some code. Cc: Eunchul Kim Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 15 +++ 1 files changed, 3 insertions(+), 12

[PATCH 09/10] drm/exynos: Remove redundant NULL check in exynos_drm_gsc.c

devm_request_and_ioremap API checks for NULL. Hence explicit NULL check is not necessary. Saves some code. Cc: Eunchul Kim Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_gsc.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 10/10] drm/exynos: Use devm_clk_get in exynos_drm_gsc.c

This eliminates the need for explicit clk_put and makes the cleanup and exit path code simpler. Cc: Eunchul Kim Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/exynos

Re: [PATCH 04/10] drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

On Wednesday, 26 December 2012, Inki Dae wrote: > > > 2012/12/24 Sachin Kamat >> >> This eliminates the need for explicit clk_put and makes the >> cleanup and exit path code simpler. >> >> Cc: Eunchul Kim >> Signed-off-by: Sachin Kamat >> ---

[PATCH 04/10] drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

On Wednesday, 26 December 2012, Inki Dae wrote: > > > 2012/12/24 Sachin Kamat >> >> This eliminates the need for explicit clk_put and makes the >> cleanup and exit path code simpler. >> >> Cc: Eunchul Kim >> Signed-off-by: Sachin Kamat >> ---

Re: [PATCH 04/10] drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

On 27 December 2012 15:43, Inki Dae wrote: > > > 2012/12/26 Sachin Kamat >> >> >> >> On Wednesday, 26 December 2012, Inki Dae wrote: >> > >> > >> > 2012/12/24 Sachin Kamat >> >> >> >> This eliminates

[PATCH 04/10 Resend] drm/exynos: Use devm_clk_get in exynos_drm_fimc.c

This eliminates the need for explicit clk_put and makes the cleanup and exit path code simpler. Cc: Eunchul Kim Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 45 ++ 1 files changed, 9 insertions(+), 36 deletions(-) diff --git a

Re: [PATCH 1/2] [RFC] video: exynos mipi dsi: Making Exynos MIPI Complaint with CDF

Hi Vikas, Some nitpicks inline Subject: s/Complaint/Compliant On 2 January 2013 18:47, Vikas C Sajjan wrote: > From: Vikas Sajjan > Please add some description about this patch here. > Signed-off-by: Vikas Sajjan > --- > drivers/video/exynos/exynos_mipi_dsi.c| 46 > +

Re: [RFC PATCH 4/4] alsa/soc: add hdmi audio codec based on cdf

+CC: ALSA mailing list, Mark Brown On 13 January 2013 18:22, Rahul Sharma wrote: > This patch registers hdmi-audio codec to the ALSA framework. This is the > second > client to the hdmi panel. Once notified by the CDF Core it proceeds towards > audio setting and audio control. It also subscribes

[PATCH 1/3] drm/exynos: Make g2d_userptr_get_dma_addr static

Fixes the following warning: drivers/gpu/drm/exynos/exynos_drm_g2d.c:327:12: warning: symbol 'g2d_userptr_get_dma_addr' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 2/3] drm/exynos: Make ipp_handle_cmd_work static

Fixes the following warning: drivers/gpu/drm/exynos/exynos_drm_ipp.c:872:6: warning: symbol 'ipp_handle_cmd_work' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_ipp.c |2 +- 1 files changed, 1 insertions(+), 1 deletion

[PATCH 3/3] drm/exynos: Add missing static specifiers in exynos_drm_rotator.c

atic? Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_rotator.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c b/drivers/gpu/drm/exynos/exynos_drm_rotator.c index e9e83ef..f976e29 100644 --- a/dr

[PATCH 1/1] drm/exynos: Make 'drm_hdmi_get_edid' static

Fixes the following warning: drivers/gpu/drm/exynos/exynos_drm_hdmi.c:111:13: warning: symbol 'drm_hdmi_get_edid' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- Compile tested on exynos-drm-fixes branch of Inki Dae's tree. --- drivers/gpu/drm/exynos/ex

[PATCH 1/1] drm/exynos: Add missing braces around sizeof

Fixes the following checkpatch warning: WARNING: sizeof *sgt should be sizeof(*sgt) Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos

[PATCH 1/2] [media] s5p-g2d: Add DT based discovery support

This patch adds device tree based discovery support to G2D driver Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-g2d/g2d.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/s5p-g2d/g2d.c b/drivers/media/platform/s5p-g2d

[PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

From: Ajay Kumar This patch adds device tree match table for Exynos G2D controller. Signed-off-by: Ajay Kumar Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/exynos

Re: [PATCH] Adds display-timing node parsing to exynos drm fimd as per

Hi Vikas, This patch should be numbered 0/1 as it is not a patch in itself and the subsequent patch should be 1/1 so as to show that these 2 together form a series. Also, your subject line seems to have been truncated. On 28 January 2013 11:15, Vikas Sajjan wrote: > This patch adds display-timi

Re: [PATCH v2 0/1] Adds display-timing node parsing to exynos drm fimd

Hi Vikas, Changelog mentioning differences between v1 and v2 is generally preferred as it will help the reviewers. On 30 January 2013 12:00, Vikas Sajjan wrote: > This patch adds display-timing node parsing to drm fimd, this depends on > the display helper patchset at > http://lists.freedesktop.

Re: [PATCH 1/2] [media] s5p-g2d: Add DT based discovery support

Hi Sylwester. Thank you for the review. On 31 January 2013 03:08, Sylwester Nawrocki wrote: > Hi Sachin, > > > On 01/25/2013 10:55 AM, Sachin Kamat wrote: >> >> This patch adds device tree based discovery support to G2D driver >> >> Signed-off-by: Sachin Kama

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

On 1 February 2013 06:57, Inki Dae wrote: > > For example, > If compatible = "samsung,g2d-3.0" is added to exynos4210.dtsi, it'd be > reasonable. But what if that compatible string is added to exynos4.dtsi?. > This case isn't considered for exynos4412 SoC with v4.1. In case of Exynos4 series the

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

>> In any case please let me know the final preferred one so that I can >> update the code send the revised patches. > > The version with SoC name embedded in it seems most reliable and correct > to me. > > compatible = "samsung,exynos3110-fimg-2d" /* for Exynos3110 (S5PC110, > S5PV210), >

[PATCH] drm/exynos: Add dependency for G2D in Kconfig

Select Exynos DRM based G2D only if non-DRM based Exynos G2D driver is not selected. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index

Re: [PATCH] drm/usb: select USB_SUPPORT in Kconfig

On 10 August 2012 19:35, Sascha Hauer wrote: > On Fri, Aug 10, 2012 at 11:00:25AM +0530, Sachin Kamat wrote: >> DRM_USB selects USB. However, USB depends on USB_SUPPORT and >> USB_ARCH_HAS_HCD. >> Thus, selecting USB_SUPPORT in Kconfig avoids the following warning >>

Re: [PATCH 1/3] drm: Add missing static storage class specifiers in drm_proc.c file

Hi, Any comments on this series? Regards Sachin On 1 August 2012 17:15, Sachin Kamat wrote: > Fixes the following sparse warning: > drivers/gpu/drm/drm_proc.c:92:5: > warning: symbol 'drm_proc_create_files' was not declared. Should it be static? > drivers/gpu/drm/drm_p

Re: [PATCH] drm/usb: select USB_SUPPORT in Kconfig

Hi Dave, What is your opinion about this patch? On 15 August 2012 01:27, Sascha Hauer wrote: > On Tue, Aug 14, 2012 at 05:12:22PM +0530, Sachin Kamat wrote: >> >> In general what you suggested seems to be the right thing to do. >> However in this particular case, ma

Re: [PATCH 1/3] drm: Add missing static storage class specifiers in drm_proc.c file

Hi, Any comments on this series? On 1 August 2012 17:15, Sachin Kamat wrote: > Fixes the following sparse warning: > drivers/gpu/drm/drm_proc.c:92:5: > warning: symbol 'drm_proc_create_files' was not declared. Should it be static? > drivers/gpu/drm/drm_proc.c:17

[PATCH] drm/exynos: Make g2d_pm_ops static

Fixes the following warning: drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning: symbol 'g2d_pm_ops' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) di

Re: [PATCH] drm/exynos: Make g2d_pm_ops static

On 29 August 2012 12:32, Joonyoung Shim wrote: > On 08/28/2012 05:41 PM, Sachin Kamat wrote: >> >> Fixes the following warning: >> drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning: >> symbol 'g2d_pm_ops' was not declared. Should it be stat

[PATCH 1/2] drm/exynos: Add missing braces around sizeof in exynos_hdmi.c

Fixes the following checkpatch warnings: WARNING: sizeof *res should be sizeof(*res) WARNING: sizeof res->regul_bulk[0] should be sizeof(res->regul_bulk[0]) WARNING: sizeof *res should be sizeof(*res) Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_hdmi.c |6 +++--- 1

[PATCH 2/2] drm/exynos: Add missing braces around sizeof in exynos_mixer.c

Fixes the following checkpatch warnings: WARNING: sizeof filter_y_horiz_tap8 should be sizeof(filter_y_horiz_tap8) WARNING: sizeof filter_y_vert_tap4 should be sizeof(filter_y_vert_tap4) WARNING: sizeof filter_cr_horiz_tap4 should be sizeof(filter_cr_horiz_tap4) Signed-off-by: Sachin Kamat

[PATCH] drm/exynos: Fix potential NULL pointer dereference

drm_mode_create() returns NULL if it fails to create a new display mode. Check the value returned to avoid NULL pointer deferencing later. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_connector.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a

[PATCH] drm/udl: Use NULL instead of 0 for pointers

Fixes the following sparse warnings: drivers/gpu/drm/udl/udl_transfer.c:129:50: drivers/gpu/drm/udl/udl_transfer.c:130:50: drivers/gpu/drm/udl/udl_transfer.c:131:45: drivers/gpu/drm/udl/udl_transfer.c:132:61: warning: Using plain integer as NULL pointer Signed-off-by: Sachin Kamat --- drivers

[PATCH] drm/udl: Add missing static storage class specifiers in udl_fb.c

Fixes the following sparse warnings: drivers/gpu/drm/udl/udl_fb.c:360:6: warning: symbol 'udl_crtc_fb_gamma_set' was not declared. Should it be static? drivers/gpu/drm/udl/udl_fb.c:365:6: warning: symbol 'udl_crtc_fb_gamma_get' was not declared. Should it be static? Signed-

[PATCH] drm/udl: Make udl_enc_destroy() static

Fixes the following sparse warning: drivers/gpu/drm/udl/udl_encoder.c:19:6: warning: symbol 'udl_enc_destroy' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/gpu/drm/udl/udl_encoder.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) di

[PATCH] drm/udl: Make udl_crtc_init() static

Fixes the following sparse warning: drivers/gpu/drm/udl/udl_modeset.c:394:5: warning: symbol 'udl_crtc_init' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/gpu/drm/udl/udl_modeset.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH] drm/exynos: Add missing static storage class specifier

Fixes the following sparse warning: drivers/gpu/drm/exynos/exynos_drm_connector.c:199:20: warning: symbol 'exynos_drm_best_encoder' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_connector.c |3 ++- 1 files changed, 2

[PATCH 1/1] drm: Add missing static storage class specifier

Signed-off-by: Sachin Kamat Fixes the following sparse warning: drivers/gpu/drm/drm_info.c:238:5: warning: symbol 'drm_gem_one_name_info' was not declared. Should it be static? --- drivers/gpu/drm/drm_info.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/d

[PATCH 2/3] drm/exynos: Use devm_* functions in exynos_hdmi.c

devm_* functions are device managed functions and make error handling and cleanup cleaner and simpler. Signed-off-by: Sachin Kamat Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_hdmi.c | 36 ++--- 1 files changed, 7 insertions(+), 29 deletions

[PATCH 1/3] drm/exynos: Use devm_* functions in exynos_drm_fimd.c

devm_* functions are device managed functions and make error handling and cleanup cleaner and simpler. Signed-off-by: Sachin Kamat Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 40 ++ 1 files changed, 8 insertions(+), 32 deletions

[PATCH 3/3] drm/exynos: Use devm_* functions in exynos_mixer.c

devm_* functions are device managed functions and make error handling and cleanup cleaner and simpler. Signed-off-by: Sachin Kamat Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_mixer.c | 48 +--- 1 files changed, 14 insertions(+), 34 deletions

[PATCH 1/3] drm: Add missing static storage class specifiers in drm_proc.c file

Fixes the following sparse warning: drivers/gpu/drm/drm_proc.c:92:5: warning: symbol 'drm_proc_create_files' was not declared. Should it be static? drivers/gpu/drm/drm_proc.c:175:5: warning: symbol 'drm_proc_remove_files' was not declared. Should it be static? Signed-

[PATCH 2/3] drm: Add missing static storage class specifier in drm_irq.c file

Fixes the following sparse warning: drivers/gpu/drm/drm_irq.c:1239:6: warning: symbol 'drm_handle_vblank_events' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/gpu/drm/drm_irq.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 3/3] drm: Add misssing static storage class specifier in drm_fb_helper.c file

Fixes the following sparse warning: drivers/gpu/drm/drm_fb_helper.c:239:6: warning: symbol 'drm_fb_helper_force_kernel_mode' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/gpu/drm/drm_fb_helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletion

[PATCH 0/5] drm/exynos: Use devm_* functions and cleanup

This series adds devm_* functionality in some drivers and cleans up some code that remained when the same was added to other drivers earlier. This series is compile tested against the latest (6 Aug 2012) linux-next code. Sachin Kamat (5): drm/exynos: Remove redundant check in exynos_hdmi.c

[PATCH 1/5] drm/exynos: Remove redundant check in exynos_hdmi.c file

devm_request_and_ioremap function checks the validity of the pointer returned by platform_get_resource. Hence an additional check in the probe function is not necessary. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_hdmi.c |5 - 1 files changed, 0 insertions(+), 5

[PATCH 2/5] drm/exynos: Remove redundant check in exynos_drm_fimd.c file

devm_request_and_ioremap function checks the validity of the pointer returned by platform_get_resource. Hence an additional check in the probe function is not necessary. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_fimd.c |5 - 1 files changed, 0 insertions(+), 5

[PATCH 3/5] drm/exynos: Use devm_kzalloc in exynos_drm_vidi.c file

devm_kzalloc is a device managed function and makes freeing and error handling simpler. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_vidi.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c b/drivers/gpu

[PATCH 4/5] drm/exynos: Use devm_kzalloc in exynos_drm_hdmi.c file

devm_kzalloc is a device managed function and makes freeing and error handling simpler. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c b/drivers/gpu/drm

[PATCH 5/5] drm/exynos: Use devm_* functions in exynos_drm_g2d.c file

devm_* functions are device managed functions and make error handling and cleanup cleaner and simpler. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 50 ++ 1 files changed, 10 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm

[PATCH] drm/usb: select USB_SUPPORT in Kconfig

OWERMATE && INPUT_YEALINK && INPUT_CM109 && RC_ATI_REMOTE && IR_IMON && IR_MCEUSB && IR_REDRAT3 && IR_STREAMZAP && IR_IGUANA && DRM_USB) selects USB which has unmet direct dependencies (USB_SUPPORT && USB_ARCH_HAS_HCD) Signed-off

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

On 1 February 2013 17:02, Inki Dae wrote: > > How about using like below? > Compatible = ""samsung,exynos4x12-fimg-2d" /* for Exynos4212, > Exynos4412 */ > It looks odd to use "samsung,exynos4212-fimg-2d" saying that this ip is for > exynos4212 and exynos4412. AFAIK, compatible strings a

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

On 1 February 2013 18:28, Inki Dae wrote: > > > > > 2013. 2. 1. 오후 8:52 Inki Dae 작성: > >> >> >>> -Original Message- >>> From: linux-media-ow...@vger.kernel.org [mailto:linux-media- >>> ow...@vger.kernel.org] On Behalf Of Sachin

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

On 5 February 2013 15:03, Sylwester Nawrocki wrote: > On 02/05/2013 04:03 AM, Inki Dae wrote: > [...] >>> Exynos4210 has same g2d IP (v3.0) as C110 or V210; so the same >>> comptible string will be used for this one too. >>> And please check if exynos4212 and 4412 SoCs have same fimg-2d ip. >

[PATCH v2 1/2] [media] s5p-g2d: Add DT based discovery support

This patch adds device tree based discovery support to G2D driver Signed-off-by: Sachin Kamat --- Based on for_v3.9 branch of below tree: git://linuxtv.org/snawrocki/samsung.git Changes since v1: * Addressed review comments from Sylwester . * Modified the compatible string as per the

[PATCH v2 2/2] drm/exynos: Add device tree based discovery support for G2D

From: Ajay Kumar This patch adds device tree match table for Exynos G2D controller. Signed-off-by: Ajay Kumar Signed-off-by: Sachin Kamat --- Patch based on exynos-drm-fixes branch of Inki Dae's tree: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git Changes sin

Re: [PATCH v2 2/2] drm/exynos: Add device tree based discovery support for G2D

On 6 February 2013 13:02, Inki Dae wrote: > > Looks good to me but please add document for it. Yes. I will. I was planning to send the bindings document patch along with the dt patches (adding node entries to dts files). Sylwester had suggested adding this to Documentation/devicetree/bindings/med

Re: [PATCH v2 2/2] drm/exynos: Add device tree based discovery support for G2D

On 6 February 2013 16:53, Sylwester Nawrocki wrote: > On 02/06/2013 09:51 AM, Inki Dae wrote: > [...] > So I propose following classification, which seems less inaccurate: > > GPU: g2d, g3d > Media: mfc, fimc, fimc-lite, fimc-is, mipi-csis, gsc > Video: fimd, hdmi, eDP, mipi-dsim Thanks Inki a

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

On Tuesday, 12 February 2013, Inki Dae wrote: > Applied and will go to -next. Thanks. > And please post the document(in > Documentation/devicetree/bindings/gpu/) for it later Already posted (1). (1) http://patches.linaro.org/14640/ -- With warm regards, Sachin ___

Re: [PATCH v2 1/2] [media] s5p-g2d: Add DT based discovery support

Hi Sylwester, On Wednesday, 6 February 2013, Sachin Kamat wrote: > This patch adds device tree based discovery support to G2D driver > > Signed-off-by: Sachin Kamat > --- > Based on for_v3.9 branch of below tree: > git://linuxtv.org/snawrocki/samsung.git > > Changes

<    1   2   3   4   >