[PATCH] drm/qxl: Add drm_panic support

2024-09-12 Thread Ryosuke Yasuoka
QXL supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Ryosuke Yasuoka --- Sorry for sending similar mails again and again. Please ignore the following my mails. Let me add dri-devel mailing list and Jocelyn who developped a drm_panic

[PATCH] drm/virtio: Add drm_panic support

2024-10-30 Thread Ryosuke Yasuoka
From: Jocelyn Falempe Virtio gpu supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Ryosuke Yasuoka Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/virtio/virtgpu_drv.h | 28 + drivers/gpu/drm/virtio/virtgpu_plane.c

[PATCH v4] drm/virtio: Add drm_panic support

2024-11-13 Thread Ryosuke Yasuoka
From: Jocelyn Falempe Virtio gpu supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Ryosuke Yasuoka Signed-off-by: Jocelyn Falempe --- v4: - As per Dmitry's comment, make virtio_panic_buffer private to virtio_gpu_device

[PATCH v3] drm/qxl: Add drm_panic support

2024-09-20 Thread Ryosuke Yasuoka
QXL supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Ryosuke Yasuoka --- v3 Adjust function's arguments indentation. Discussion v2 patch is in [2] [2] https://lore.kernel.org/lkml/20240919071230.840994-1-ryasu...@redhat.com/T

[PATCH v4] drm/qxl: Add drm_panic support

2024-09-22 Thread Ryosuke Yasuoka
QXL supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Ryosuke Yasuoka --- v4 1. Remove unnecessary () and empty lines 2. Remove unlikely() from qxl_panic_bo_create(). This function is only called in panic handler and it does not need

[PATCH v2] drm/qxl: Add drm_panic support

2024-09-19 Thread Ryosuke Yasuoka
QXL supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Ryosuke Yasuoka --- v2 In [1], Jocelyn gives me feedbacks and fix them. 1. Removing qxl_surface_evict(): It takes a mutex and it possibly causes deadlock in panic handler. As the

[PATCH v2] drm/virtio: Add drm_panic support

2024-11-06 Thread Ryosuke Yasuoka
From: Jocelyn Falempe Virtio gpu supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Ryosuke Yasuoka Signed-off-by: Jocelyn Falempe --- v2: - Remove unnecessary virtio_gpu_vbuffer_inline - Remove reclaim_list and just call

[PATCH v3] drm/virtio: Add drm_panic support

2024-11-07 Thread Ryosuke Yasuoka
From: Jocelyn Falempe Virtio gpu supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Ryosuke Yasuoka Signed-off-by: Jocelyn Falempe --- v3: - As per Jocelyn's comment, add a finite timeout 500usec in virtio_gpu_panic_put_vbuf

[PATCH v5] drm/virtio: Add drm_panic support

2024-11-29 Thread Ryosuke Yasuoka
From: Jocelyn Falempe Virtio gpu supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Ryosuke Yasuoka Signed-off-by: Jocelyn Falempe --- v5: Based on Dmitry's comment, fix the followings - Rename virtio_panic_buffer to panic

Re: [PATCH v6] drm/virtio: Add drm_panic support

2025-02-04 Thread Ryosuke Yasuoka
Hi, On Mon, Feb 3, 2025 at 2:18 AM Dmitry Osipenko wrote: > > Hi, > > On 1/30/25 12:05, Ryosuke Yasuoka wrote: > ... > > +static int virtio_drm_get_scanout_buffer(struct drm_plane *plane, > > + struct drm_scanout_buffer *

[PATCH v7] drm/virtio: Add drm_panic support

2025-02-06 Thread Ryosuke Yasuoka
Virtio gpu supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. It is supported where it has vmapped shmem BO. Signed-off-by: Jocelyn Falempe Signed-off-by: Ryosuke Yasuoka --- v7: - Reject no vmapped shmem BO. Also, insert comment and commit log

Re: [PATCH v7] drm/virtio: Add drm_panic support

2025-02-12 Thread Ryosuke Yasuoka
On Mon, Feb 10, 2025 at 8:14 PM Jocelyn Falempe wrote: > > On 09/02/2025 18:45, Dmitry Osipenko wrote: > > On 2/6/25 13:42, Ryosuke Yasuoka wrote: > >> Virtio gpu supports the drm_panic module, which displays a message to > >> the screen when a kernel panic occurs

Re: [PATCH v5] drm/virtio: Add drm_panic support

2024-12-10 Thread Ryosuke Yasuoka
On Mon, Dec 2, 2024 at 11:30 PM Dmitry Osipenko wrote: > > On 11/29/24 15:24, Ryosuke Yasuoka wrote: > > > + } else { > > + iosys_map_set_vaddr(&sb->map[0], bo->base.vaddr); > > + } > > + > > + sb->format = plane->

[PATCH v6] drm/virtio: Add drm_panic support

2025-01-30 Thread Ryosuke Yasuoka
Virtio gpu supports the drm_panic module, which displays a message to the screen when a kernel panic occurs. Signed-off-by: Jocelyn Falempe Signed-off-by: Ryosuke Yasuoka --- v6: Based on Dmitry's comment, fix the followings - Reject external dmabufs backing the GEM object - Allocate vbuf

Re: [PATCH] drm/virtio: Support drm_panic with non-vmapped shmem BO

2025-04-16 Thread Ryosuke Yasuoka
On Wed, Apr 16, 2025 at 4:29 PM Dmitry Osipenko wrote: > > On 4/12/25 16:20, Ryosuke Yasuoka wrote: > > Pass array of pages of the scanout buffer [1] to shmem BO, allowing > > drm_panic to work even if the BO is not vmapped. > > > > [1] https://lore.kernel.org/all

[PATCH drm-next] drm/hyperv: Replace simple-KMS with regular atomic helpers

2025-04-20 Thread Ryosuke Yasuoka
://lore.kernel.org/lkml/dae5089d-e214-4518-b927-5c4149bab...@suse.de/ Signed-off-by: Ryosuke Yasuoka --- drivers/gpu/drm/hyperv/hyperv_drm.h | 4 +- drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 168 2 files changed, 139 insertions(+), 33 deletions(-) diff --git a

[PATCH drm-next v3] drm/hyperv: Replace simple-KMS with regular atomic helpers

2025-04-27 Thread Ryosuke Yasuoka
://lore.kernel.org/lkml/dae5089d-e214-4518-b927-5c4149bab...@suse.de/ Acked-by: Javier Martinez Canillas Signed-off-by: Ryosuke Yasuoka --- v3: - Remove hyperv_crtc_helper_atomic_disable - Use drm_atomic_get_new_plane_state instead of accessing the plane->state directly - Iterate and handle e

[PATCH] drm/virtio: Support drm_panic with non-vmapped shmem BO

2025-04-12 Thread Ryosuke Yasuoka
Pass array of pages of the scanout buffer [1] to shmem BO, allowing drm_panic to work even if the BO is not vmapped. [1] https://lore.kernel.org/all/20250407140138.162383-3-jfale...@redhat.com/ Signed-off-by: Jocelyn Falempe Signed-off-by: Ryosuke Yasuoka --- drivers/gpu/drm/virtio

[PATCH drm-next v2] drm/hyperv: Replace simple-KMS with regular atomic helpers

2025-04-24 Thread Ryosuke Yasuoka
://lore.kernel.org/lkml/dae5089d-e214-4518-b927-5c4149bab...@suse.de/ Signed-off-by: Ryosuke Yasuoka --- v2: - Remove hyperv_crtc_helper_mode_valid - Remove hyperv_format_mod_supported - Call helper_add after {plane,crtc}_init - Move drm_plane_enable_fb_damage_clips to a place close to plane init

Re: [PATCH drm-next v2] drm/hyperv: Replace simple-KMS with regular atomic helpers

2025-04-26 Thread Ryosuke Yasuoka
Hi Javier, On Fri, Apr 25, 2025 at 4:15 PM Javier Martinez Canillas wrote: > > Ryosuke Yasuoka writes: > > Hello Ryosuke, > > > Drop simple-KMS in favor of regular atomic helpers to make the code more > > modular. The simple-KMS helper mix up plane and CRTC state

Re: [PATCH drm-next 1/2] vmalloc: Add atomic_vmap

2025-03-09 Thread Ryosuke Yasuoka
On Fri, Mar 7, 2025 at 4:55 PM Jocelyn Falempe wrote: > > On 06/03/2025 16:52, Simona Vetter wrote: > > On Thu, Mar 06, 2025 at 02:24:51PM +0100, Jocelyn Falempe wrote: > >> On 06/03/2025 05:52, Matthew Wilcox wrote: > >>> On Thu, Mar 06, 2025 at 12:25:

[PATCH drm-next 1/2] vmalloc: Add atomic_vmap

2025-03-05 Thread Ryosuke Yasuoka
Some drivers can use vmap in drm_panic, however, vmap is sleepable and takes locks. Since drm_panic will vmap in panic handler, atomic_vmap requests pages with GFP_ATOMIC and maps KVA without locks and sleep. Signed-off-by: Ryosuke Yasuoka --- include/linux/vmalloc.h | 2 + mm/internal.h

[PATCH drm-next 2/2] drm/virtio: Use atomic_vmap to work drm_panic in GUI

2025-03-05 Thread Ryosuke Yasuoka
virtio drm_panic supports only vmapped shmem BO because there is no atomic vmap feature. Now atomic_vmap is supported, so drm_panic tries to vmap addr if it is not mapped. Signed-off-by: Ryosuke Yasuoka --- drivers/gpu/drm/drm_gem.c | 51 ++ drivers/gpu/drm

[PATCH drm-next 0/2] Enhance drm_panic Support for Virtio-GPU

2025-03-05 Thread Ryosuke Yasuoka
both Gnome and VT environments, and they work correctly. Best regards, Ryosuke [1] https://patchwork.freedesktop.org/patch/635658/ Ryosuke Yasuoka (2): vmalloc: Add atomic_vmap drm/virtio: Use atomic_vmap to work drm_panic in GUI drivers/gpu/drm/drm_gem.c | 51 dr

[PATCH] drm/qxl: Remove unused argument from qxl_alloc_release_reserved

2025-04-04 Thread Ryosuke Yasuoka
The `size` argument in the `qxl_alloc_release_reserved` function is currently unused and has no effect on the function's logic. So remove this argument to clean up the code. No functional changes are expected. Signed-off-by: Ryosuke Yasuoka --- drivers/gpu/drm/qxl/qxl_display.

[PATCH RFC drm-next 1/1] drm/hyperv: Add support for drm_panic

2025-04-02 Thread Ryosuke Yasuoka
Add drm_panic module supports for hyperv drm so that panic screen can be displayed on panic. Signed-off-by: Ryosuke Yasuoka --- drivers/gpu/drm/drm_simple_kms_helper.c | 26 + drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 42 + include/drm

Re: [PATCH RFC drm-next 0/1] Add support for drm_panic

2025-04-02 Thread Ryosuke Yasuoka
On Wed, Apr 2, 2025 at 6:45 PM Thomas Zimmermann wrote: > > Hi > > Am 02.04.25 um 10:43 schrieb Ryosuke Yasuoka: > > This patch adds drm_panic support for hyperv-drm driver. This function > > works but it's still needed to brush up. Let me hear your opinions. > &

[PATCH RFC drm-next 0/1] Add support for drm_panic

2025-04-02 Thread Ryosuke Yasuoka
2022. Ryosuke Yasuoka (1): drm/hyperv: Add support for drm_panic drivers/gpu/drm/drm_simple_kms_helper.c | 26 + drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 42 + include/drm/drm_simple_kms_helper.h | 22 +++ 3 files changed, 90 insertions(+)

[PATCH RFC drm-misc-next v2 0/1] Add support for drm_panic

2025-05-26 Thread Ryosuke Yasuoka
/lkml/20250402084351.1545536-1-ryasu...@redhat.com/ Ryosuke Yasuoka (1): drm/hyperv: Add support for drm_panic drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 36 + 1 file changed, 36 insertions(+) base-commit: c06cb85ad1412c6ff34792b028b2f89495761398 -- 2.49.0

[PATCH RFC drm-misc-next v2 1/1] drm/hyperv: Add support for drm_panic

2025-05-26 Thread Ryosuke Yasuoka
Add drm_panic module for hyperv drm so that panic screen can be displayed on panic. Signed-off-by: Ryosuke Yasuoka --- drivers/gpu/drm/hyperv/hyperv_drm_modeset.c | 36 + 1 file changed, 36 insertions(+) diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_modeset.c b/drivers

Re: [PATCH drm-next] drm/bochs: Add support for drm_panic

2025-06-18 Thread Ryosuke Yasuoka
On Thu, Jun 19, 2025 at 3:12 PM Jocelyn Falempe wrote: > > On 13/06/2025 15:20, Ryosuke Yasuoka wrote: > > Add drm_panic moudle for bochs drm so that panic screen can be displayed > > on panic. > > Thanks for the patch, it's simple and looks good to me. > > Revi

[PATCH drm-next] drm/bochs: Add support for drm_panic

2025-06-13 Thread Ryosuke Yasuoka
Add drm_panic moudle for bochs drm so that panic screen can be displayed on panic. Signed-off-by: Ryosuke Yasuoka --- drivers/gpu/drm/tiny/bochs.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c index