Re: [PATCH libdrm 2/2] modetest: Add a new "-r" option to set a default mode

2019-07-24 Thread Rohan Garg
argv) > } > > if (!args || (args == 1 && use_atomic)) > - encoders = connectors = crtcs = planes = framebuffers = 1; > + set_preferred = encoders = connectors = crtcs = planes = framebuffers = > 1; > > dev.fd = util_open(device, module

Re: Proposal to report GPU private memory allocations with sysfs nodes [plain text version]

2019-12-19 Thread Rohan Garg
x userspace to potentially share the same PID. (2) Specifically in the case of mesa, there isn't a way to (AFAIK) associate a BO with a PID. Cheers Rohan Garg ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Proposal to report GPU private memory allocations with sysfs nodes [plain text version]

2020-01-06 Thread Rohan Garg
to find an Intel or Freedreno setup, but I'd > still like to know is there a development friendly Mali setup? > You should be able to setup a Mali T860 compatible device with this guide [1]. Cheers Rohan Garg [1] https://panfrost.freedesktop.

[PATCH v4] drm/ioctl: Add a ioctl to label GEM objects

2019-10-11 Thread Rohan Garg
- Hoist string copying up into the IOCTL - Fix documentation - Move actual gem labeling into drm_gem_adopt_label Changes in v4: - Refactor IOCTL call to only perform string duplication and move all gem lookup logic into GEM specific call Signed-off-by: Rohan Garg --- drivers/gpu/drm

Re: [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects

2019-10-22 Thread Rohan Garg
Hey Daniel On lunes, 14 de octubre de 2019 10:59:38 (CEST) Daniel Vetter wrote: > On Fri, Oct 11, 2019 at 04:30:09PM +0200, Rohan Garg wrote: > > DRM_IOCTL_DUMB_SET_LABEL lets you label GEM objects, making it > > easier to debug issues in userspace applications. > &g

Re: [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects

2019-10-22 Thread Rohan Garg
Hi Thomas On viernes, 11 de octubre de 2019 19:55:36 (CEST) Thomas Zimmermann wrote: > Hi > > Am 11.10.19 um 19:09 schrieb Daniel Stone: > > Hi Rohan, > > > > On Fri, 11 Oct 2019 at 15:30, Rohan Garg wrote: > >> DRM_IOCTL_DUMB_SET_LABEL lets you label GEM obj

Re: [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects

2019-10-22 Thread Rohan Garg
Hey On viernes, 11 de octubre de 2019 19:09:52 (CEST) Daniel Stone wrote: > Hi Rohan, > > On Fri, 11 Oct 2019 at 15:30, Rohan Garg wrote: > > DRM_IOCTL_DUMB_SET_LABEL lets you label GEM objects, making it > > easier to debug issues in userspace applications. > > I

Re: Proposal to report GPU private memory allocations with sysfs nodes [plain text version]

2020-03-20 Thread Rohan Garg
t the memory tracking requirements tied to a specific PID, but correct me if I'm wrong, would this not possible with gralloc on Android? Cheers Rohan Garg [1] https://patchwork.freedesktop.org/patch/335508/?series=66752&rev=4 On lunes, 6 de enero de 2020 21:47:21 (CET) Yiwei Zhang w

[PATCH] drm/ioctl: Add a ioctl to label GEM objects

2019-09-16 Thread Rohan Garg
DRM_IOCTL_BO_SET_LABEL lets you label GEM objects, making it easier to debug issues in userspace applications. Signed-off-by: Rohan Garg --- drivers/gpu/drm/drm_gem.c | 51 ++ drivers/gpu/drm/drm_internal.h | 2 ++ drivers/gpu/drm/drm_ioctl.c| 1

Re: [PATCH] drm/ioctl: Add a ioctl to label GEM objects

2019-09-17 Thread Rohan Garg
app could also potentially allocate lots of GEM buffers and cause the same situation. Cheers Rohan Garg signature.asc Description: This is a digitally signed message part. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/ioctl: Add a ioctl to label GEM objects

2019-09-17 Thread Rohan Garg
Hi > Might be worth mentioning in the comment here that `len` includes the > trailing NULL. > Ack, I'll address this in v2. Cheers Rohan Garg signature.asc Description: This is a digitally signed message part. ___ dri-devel mailing

[PATCH v2] drm/ioctl: Add a ioctl to label GEM objects

2019-09-19 Thread Rohan Garg
DRM_IOCTL_BO_SET_LABEL lets you label GEM objects, making it easier to debug issues in userspace applications. Changes in v2: - Hoist the IOCTL up into the drm_driver framework Signed-off-by: Rohan Garg --- drivers/gpu/drm/drm_gem.c | 64 ++ drivers/gpu

Re: [PATCH v2] drm/ioctl: Add a ioctl to label GEM objects

2019-09-26 Thread Rohan Garg
On viernes, 20 de septiembre de 2019 17:25:10 (CEST) Thierry Reding wrote: > On Thu, Sep 19, 2019 at 02:53:21PM +0200, Rohan Garg wrote: > > DRM_IOCTL_BO_SET_LABEL lets you label GEM objects, making it > > easier to debug issues in userspace applications. > > > > Chang

Re: [PATCH v2] drm/ioctl: Add a ioctl to label GEM objects

2019-09-26 Thread Rohan Garg
Hi On jueves, 19 de septiembre de 2019 16:02:57 (CEST) Thomas Zimmermann wrote: > Hi > > Am 19.09.19 um 14:53 schrieb Rohan Garg: > > DRM_IOCTL_BO_SET_LABEL lets you label GEM objects, making it > > easier to debug issues in userspace applications. > > > > Chang

[PATCH v3] drm/ioctl: Add a ioctl to label GEM objects

2019-09-26 Thread Rohan Garg
- Hoist string copying up into the IOCTL - Fix documentation - Move actual gem labeling into drm_gem_adopt_label Signed-off-by: Rohan Garg --- drivers/gpu/drm/drm_gem.c | 69 ++ drivers/gpu/drm/drm_internal.h | 3 ++ drivers/gpu/drm/drm_ioctl.c| 1

RFC: IOCTL to label BO in DRM Core

2019-09-10 Thread Rohan Garg
rivers to label BO's? Cheers Rohan Garg signature.asc Description: This is a digitally signed message part. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v5 1/2] drm/ioctl: Add a ioctl to set and get a label on GEM objects

2020-05-14 Thread Rohan Garg
ff-by: Rohan Garg Reported-by: kbuild test robot Reported-by: Dan Carpenter --- drivers/gpu/drm/drm_gem.c | 54 + drivers/gpu/drm/drm_internal.h | 14 +++ drivers/gpu/drm/drm_ioctl.c| 74 ++ include/drm/drm_drv.h

[PATCH v5 0/2] Introducing IOCTL's to set/get label's for a buffer object

2020-05-14 Thread Rohan Garg
ng extension [2]. Cheers Rohan Garg [1] https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/2426/ [2] https://www.khronos.org/registry/OpenGL/extensions/EXT/EXT_debug_label.txt Rohan Garg (2): drm/ioctl: Add a ioctl to set and get a label on GEM objects panfrost: Set default labeling helper

[PATCH v5 2/2] panfrost: Set default labeling helpers

2020-05-14 Thread Rohan Garg
Set the default labeling helpers in order to be able to label the buffers. Signed-off-by: Rohan Garg --- drivers/gpu/drm/panfrost/panfrost_drv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c index

Re: [PATCH v5 1/2] drm/ioctl: Add a ioctl to set and get a label on GEM objects

2020-05-20 Thread Rohan Garg
o aim for. > Yep, the intention is to replace the VC4 specific labeling with a more generic framework that all drivers can use. > A handful of ideas and suggestions below: > > On Thu, 14 May 2020 at 16:05, Rohan Garg wrote: > > Signed-off-by: Rohan Garg > > Reported-by: kb

[PATCH i-g-t] panfrost: Test labeling functionality

2020-05-28 Thread Rohan Garg
Introduce tests to cover the new generic labeling ioctl's being reviewed here [1]. Signed-off-by: Rohan Garg [1] https://patchwork.freedesktop.org/series/77267/ Signed-off-by: Rohan Garg --- include/drm-uapi/drm.h| 23 ++- tests/meson.build | 1 + tests/panfrost_bo_la

[PATCH v6] drm/ioctl: Add a ioctl to set and get a label on GEM objects

2020-05-28 Thread Rohan Garg
e default GEM label'ing function for all drivers using GEM - Do not error out when fetching empty labels - Refactor flags to the u32 type and add documentation - Refactor ioctls to use correct DRM_IOCTL{R,W,WR} macros - Return length of copied label to userspace Signed-off-by: Rohan Garg

Re: [PATCH v6] drm/ioctl: Add a ioctl to set and get a label on GEM objects

2020-05-29 Thread Rohan Garg
Hey Eric! On jueves, 28 de mayo de 2020 20:45:24 (CEST) Eric Anholt wrote: > On Thu, May 28, 2020 at 10:06 AM Rohan Garg wrote: > > DRM_IOCTL_HANDLE_SET_LABEL lets you label buffers associated > > with a handle, making it easier to debug issues in userspace &

Re: [PATCH v6] drm/ioctl: Add a ioctl to set and get a label on GEM objects

2020-06-09 Thread Rohan Garg
On viernes, 29 de mayo de 2020 19:10:29 (CEST) Eric Anholt wrote: > On Fri, May 29, 2020 at 6:44 AM Rohan Garg wrote: > > Hey Eric! > > > > On jueves, 28 de mayo de 2020 20:45:24 (CEST) Eric Anholt wrote: > > > On Thu, May 28, 2020 at 10:06