Re: [PATCH v5 10/15] drm/i915/pxp: interfaces for using protected objects

2021-07-19 Thread Rodrigo Vivi
as developed the addition of this and that function before other changes got squashed] or something like that... That aside, the patch is right as we had agreed and following the new guidance for immutable params. Reviewed-by: Rodrigo Vivi > > v5: squash patches, rebase on proto_ctx, update

Re: [PATCH v5 05/15] drm/i915/pxp: Implement funcs to create the TEE channel

2021-07-21 Thread Rodrigo Vivi
ed-off-by: Daniele Ceraolo Spurio > Cc: Chris Wilson > Reviewed-by: Rodrigo Vivi #v2 rvb still valid > --- > drivers/gpu/drm/i915/Makefile | 3 +- > drivers/gpu/drm/i915/pxp/intel_pxp.c | 13 > drivers/gpu/drm/i915/pxp/intel_pxp_tee.c | 77 ++

Re: [PATCH v5 07/15] drm/i915/pxp: Create the arbitrary session after boot

2021-07-21 Thread Rodrigo Vivi
id to false > on fini (Rodrigo) > v5: handle async component binding > > Signed-off-by: Huang, Sean Z > Signed-off-by: Daniele Ceraolo Spurio > Cc: Chris Wilson > Cc: Rodrigo Vivi > Reviewed-by: Rodrigo Vivi #v4 > --- > drivers/gpu/drm/i915/Makefile

Re: [PATCH v5 03/15] drm/i915/pxp: define PXP device flag and kconfig

2021-07-21 Thread Rodrigo Vivi
in until we add support to query > the caps from the mei device. ack > > Signed-off-by: Daniele Ceraolo Spurio > Reviewed-by: Rodrigo Vivi #v1 rvb still valid > --- > drivers/gpu/drm/i915/Kconfig | 11 +++ > drivers/gpu/drm/i915/i915_drv.h

Re: [PATCH v5 09/15] drm/i915/pxp: Implement PXP irq handler

2021-07-21 Thread Rodrigo Vivi
to common work function. > v4: improve comments, simplify wait logic (Rodrigo) > v5: unconditionally set interrupts, I didn't find this... this looks the same as v4 > rename state_attacked var (Rodrigo) thanks > > Signed-off-by: Huang, Sean Z > Signed-off-by: Daniele Ce

[PULL] drm-intel-fixes

2021-07-22 Thread Rodrigo Vivi
ors on awaiting already signaled fences" drm/i915: Correct the docs for intel_engine_cmd_parser Rodrigo Vivi (1): Merge tag 'gvt-fixes-2021-07-15' of https://github.com/intel/gvt-linux into drm-intel-fixes drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 227 ++---

Re: [Intel-gfx] [PATCH 28/30] drm/i915: rename/remove CNL registers

2021-07-26 Thread Rodrigo Vivi
On Fri, Jul 23, 2021 at 05:11:12PM -0700, Lucas De Marchi wrote: > Remove registers that are not used anymore due to CNL removal and rename > those that are. > > Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_re

Re: [Intel-gfx] [PATCH 27/30] drm/i915: remove GRAPHICS_VER == 10

2021-07-26 Thread Rodrigo Vivi
On Fri, Jul 23, 2021 at 05:11:11PM -0700, Lucas De Marchi wrote: > Replace all remaining handling of GRAPHICS_VER {==,>=} 10 with > {==,>=} 11. With the removal of CNL, there is no platform with graphics > version equals 10. > > Signed-off-by: Lucas De Marchi Revi

Re: [PATCH 29/30] drm/i915: replace random CNL comments

2021-07-26 Thread Rodrigo Vivi
On Fri, Jul 23, 2021 at 05:11:13PM -0700, Lucas De Marchi wrote: > Cleanup remaining cases that we find CNL in the codebase. > > Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/intel_bios.c | 2 +- > drivers/gp

Re: [PATCH 17/30] drm/i915/display: rename CNL references in skl_scaler.c

2021-07-26 Thread Rodrigo Vivi
On Fri, Jul 23, 2021 at 05:11:01PM -0700, Lucas De Marchi wrote: > With the removal of CNL, let's consider GLK as the first platform using > those constants since GLK has DISPLAY_VER == 10. > > Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi > --- > drive

Re: [Intel-gfx] [PATCH 30/30] drm/i915: switch num_scalers/num_sprites to consider DISPLAY_VER

2021-07-26 Thread Rodrigo Vivi
else if (GRAPHICS_VER(dev_priv) >= 11) > + else if (DISPLAY_VER(dev_priv) >= 11) > for_each_pipe(dev_priv, pipe) > runtime->num_sprites[pipe] = 6; > else if (IS_GEMINILAKE(dev_priv)) while at it we could probably change this to DISPLAY_

Re: [Intel-gfx] [PATCH 21/30] drm/i915: remove explicit CNL handling from intel_pch.c

2021-07-26 Thread Rodrigo Vivi
On Fri, Jul 23, 2021 at 05:11:05PM -0700, Lucas De Marchi wrote: > Remove references for CNL from pch detection. for a moment I almost thought you were removing the CNP support... > > Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH 02/30] drm/i915/display: split DISPLAY_VER 9 and 10 in intel_setup_outputs()

2021-07-26 Thread Rodrigo Vivi
On Sat, Jul 24, 2021 at 10:02:15PM -0700, Lucas De Marchi wrote: > On Sat, Jul 24, 2021 at 06:41:21PM +0100, Christoph Hellwig wrote: > > Still tests fine: > > > > Tested-by: Christoph Hellwig > > I just pushed this to drm-intel-next as part of another series and > added your Tested-by. > > Ro

Re: [Intel-gfx] [PATCH 26/30] drm/i915: finish removal of CNL

2021-07-26 Thread Rodrigo Vivi
breakages > due to changing the headers. > > Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_drv.h | 7 +-- > drivers/gpu/drm/i915/i915_pci.c | 23 +-- > drivers/gpu/drm/i915/i915_perf.

Re: [PATCH 20/30] drm/i915: remove explicit CNL handling from intel_mocs.c

2021-07-26 Thread Rodrigo Vivi
On Fri, Jul 23, 2021 at 05:11:04PM -0700, Lucas De Marchi wrote: > Only one reference to CNL that is not needed, but code is the same for > GEN9_BC, so leave the code around and just remove the special > case for CNL. > > Signed-off-by: Lucas De Marchi Reviewed-b

Re: [Intel-gfx] [PATCH 14/30] drm/i915/display: remove explicit CNL handling from skl_universal_plane.c

2021-07-26 Thread Rodrigo Vivi
Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/skl_universal_plane.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c > b/drivers/gpu/drm/i

Re: [PATCH 24/30] drm/i915: rename CNL references in intel_dram.c

2021-07-26 Thread Rodrigo Vivi
On Fri, Jul 23, 2021 at 05:11:08PM -0700, Lucas De Marchi wrote: > With the removal of CNL, let's consider ICL as the first platform using > those constants. > > Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm

Re: [Intel-gfx] [PATCH 15/30] drm/i915/display: remove explicit CNL handling from intel_display_power.c

2021-07-26 Thread Rodrigo Vivi
On Fri, Jul 23, 2021 at 05:10:59PM -0700, Lucas De Marchi wrote: > The only real platform with DISPLAY_VER == 10 is GLK. We don't need to > handle CNL explicitly in intel_display_power.c. > > Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi > --- >

Re: [PATCH 12/30] drm/i915/display: remove explicit CNL handling from intel_dpll_mgr.c

2021-07-26 Thread Rodrigo Vivi
CFLAGS=-Wunused drivers/gpu/drm/i915/display/intel_dpll_mgr.o good idea... > > Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 586 +++--- > drivers/gpu/drm/i915/i915_reg.h | 4 +- > 2 files

Re: [PATCH 25/30] drm/i915/gt: rename CNL references in intel_engine.h

2021-07-26 Thread Rodrigo Vivi
On Fri, Jul 23, 2021 at 05:11:09PM -0700, Lucas De Marchi wrote: > With the removal of CNL, let's consider ICL as the first platform using > that index. > > Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi ( I got myself thinking that some patches like this could

Re: [PATCH 11/30] drm/i915/display: remove explicit CNL handling from intel_dp.c

2021-07-26 Thread Rodrigo Vivi
off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/intel_dp.c | 35 - > 1 file changed, 5 insertions(+), 30 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > b/drivers/gpu/drm/i915/display/intel_dp.c

Re: [Intel-gfx] [PATCH 16/30] drm/i915/display: remove CNL ddi buf translation tables

2021-07-26 Thread Rodrigo Vivi
On Fri, Jul 23, 2021 at 05:11:00PM -0700, Lucas De Marchi wrote: > The only real platform with DISPLAY_VER == 10 is GLK. We don't need to > handle CNL explicitly. > > Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display

Re: [Intel-gfx] [PATCH 22/30] drm/i915: remove explicit CNL handling from intel_wopcm.c

2021-07-26 Thread Rodrigo Vivi
On Fri, Jul 23, 2021 at 05:11:06PM -0700, Lucas De Marchi wrote: > Consider the new WOPCM size as starting in ICL rather than CNL since the > latter is being removed from the driver. > > Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/

Re: [PATCH 18/30] drm/i915: remove explicit CNL handling from i915_irq.c

2021-07-26 Thread Rodrigo Vivi
On Fri, Jul 23, 2021 at 05:11:02PM -0700, Lucas De Marchi wrote: > Remove special handling of PORT_F in i915_irq.c and only do it for > DISPLAY_VER == 11. oh! ignore my previous thought about removing the port F... > > Signed-off-by: Lucas De Marchi Reviewed-by:

Re: [Intel-gfx] [PATCH 08/30] drm/i915/display: remove explicit CNL handling from intel_ddi.c

2021-07-26 Thread Rodrigo Vivi
ver reference to cnl that comes from the struct > intel_ddi_buf_trans. This will be renamed later when we get rid of the > additional CNL tables. > > Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 254 ++---

Re: [Intel-gfx] [PATCH 13/30] drm/i915/display: remove explicit CNL handling from intel_vdsc.c

2021-07-26 Thread Rodrigo Vivi
On Fri, Jul 23, 2021 at 05:10:57PM -0700, Lucas De Marchi wrote: > Only one reference to CNL that is not needed, but code is the same for > DISPLAY_VER >= 11, so leave the code around and just remove the special > case for CNL. > > Signed-off-by: Lucas De Marchi Reviewe

Re: [Intel-gfx] [PATCH 10/30] drm/i915/display: remove explicit CNL handling from intel_dmc.c

2021-07-26 Thread Rodrigo Vivi
On Fri, Jul 23, 2021 at 05:10:54PM -0700, Lucas De Marchi wrote: > Remove DMC firmware for CNL. > > Signed-off-by: Lucas De Marchi Cc: Anusha Srivatsa We need to remove the binary from linux-firmware.git as well > --- > drivers/gpu/drm/i915/display/intel_dmc.c | 9 - > 1 file changed

Re: [Intel-gfx] [PATCH 09/30] drm/i915/display: remove explicit CNL handling from intel_display_debugfs.c

2021-07-26 Thread Rodrigo Vivi
On Fri, Jul 23, 2021 at 05:10:53PM -0700, Lucas De Marchi wrote: > Only one reference to CNL that is not needed, but code is the same for > DISPLAY_VER >= 11, so leave the code around and just remove the special > case for CNL. > > Signed-off-by: Lucas De Marchi Reviewe

Re: [Intel-gfx] [PATCH 19/30] drm/i915: remove explicit CNL handling from intel_pm.c

2021-07-26 Thread Rodrigo Vivi
On Fri, Jul 23, 2021 at 05:11:03PM -0700, Lucas De Marchi wrote: > Remove support for CNL as it's highly untested, probably broken, and > there is no real platform that requires this code. This is part of CNL > removal from i915. > > Signed-off-by: Lucas De Marchi Revie

[PULL] drm-intel-fixes

2021-07-28 Thread Rodrigo Vivi
Lucas De Marchi (2): drm/i915: fix not reading DSC disable fuse in GLK drm/i915/display: split DISPLAY_VER 9 and 10 in intel_setup_outputs() Rodrigo Vivi (1): drm/i915/bios: Fix ports mask drivers/gpu/drm/i915/display

Re: [PATCH] drm/i915: Use Transparent Hugepages when IOMMU is enabled

2021-07-28 Thread Rodrigo Vivi
page allocations ("huge=within_size"). > - * Currently unused due to bandwidth issues (slow reads) on Broadwell+. > + * However, we only do so to offset the overhead of iommu lookups > + * due to bandwidth issues (slow reads) on Broadwell+. >*/ > +

Re: [Intel-gfx] [PATCH 1/1] drm/i915: dgfx cards need to wait on pcode's uncore init done

2021-07-28 Thread Rodrigo Vivi
est side, let's accept this > recommendation, since on the regular case it won't delay or block the > driver initialization and resume flows > > Cc: Rodrigo Vivi > Signed-off-by: Badal Nilawar Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_drv.c

Re: [PATCH v6 10/15] drm/i915/pxp: interfaces for using protected objects

2021-07-29 Thread Rodrigo Vivi
some undesired flags. Apparently not. Am I getting things right? Anything else we should check in here? Thanks, Rodrigo. > > Signed-off-by: Daniele Ceraolo Spurio > Signed-off-by: Bommu Krishnaiah > Cc: Rodrigo Vivi > Cc: Chris Wilson > Cc: Lionel Landwerlin > Cc: Jason

Re: [PATCH 0/4] Remove CNL - for drm-intel-gt-next

2021-07-29 Thread Rodrigo Vivi
On Wed, Jul 28, 2021 at 03:03:22PM -0700, Lucas De Marchi wrote: > This the part of https://patchwork.freedesktop.org/series/93056/ > that should go through drm-intel-gt-next branch. Acked-by: Rodrigo Vivi > > Lucas De Marchi (4): > drm/i915/gt: remove explicit CNL handling fr

Re: [PATCH v6 10/15] drm/i915/pxp: interfaces for using protected objects

2021-07-29 Thread Rodrigo Vivi
On Thu, Jul 29, 2021 at 08:17:44AM -0700, Daniele Ceraolo Spurio wrote: > > > On 7/29/2021 4:10 AM, Rodrigo Vivi wrote: > > On Wed, Jul 28, 2021 at 07:01:01PM -0700, Daniele Ceraolo Spurio wrote: > > > This api allow user mode to create protected buffers and to mark >

Re: [PATCH v6 02/15] mei: pxp: export pavp client to me client bus

2021-07-29 Thread Rodrigo Vivi
t; Signed-off-by: Vitaly Lubart > Signed-off-by: Tomas Winkler > Signed-off-by: Daniele Ceraolo Spurio > Reviewed-by: Rodrigo Vivi #v1 shouldn't we use the 2020-2021 in the other headers as well? anyway, rv-b remains > --- > drivers/misc/mei/Kconfig | 2 + > dr

[PULL] drm-intel-fixes

2021-04-09 Thread Rodrigo Vivi
Hi Dave and Daniel, Only one last minute fix targeting stable to fix a null dereference. Here goes drm-intel-fixes-2021-04-09: - Fix invalid access to ACPI _DSM objects (Takashi) Thanks, Rodrigo. The following changes since commit e49d033bddf5b565044e2abe4241353959bc9120: Linux 5.12-rc6 (202

[PULL] drm-intel-fixes

2021-04-15 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2021-04-15: Display panel & power related fixes: - Backlight fix (Lyude) - Display watermark fix (Ville) - VLV panel power fix (Hans) Thanks, Rodrigo. The following changes since commit d434405aaab7d0ebc516b68a8fc4100922d7f5ef: Linux 5.12-rc7 (2

Re: [Intel-gfx] [PULL] topic/intel-gen-to-ver -> drm-intel-next and drm-intel-gt-next

2021-04-20 Thread Rodrigo Vivi
On Tue, Apr 20, 2021 at 12:47:36PM +0300, Joonas Lahtinen wrote: > Quoting Jani Nikula (2021-04-19 12:53:11) > > > > Hi Joonas and Rodrigo - > > > > Here's the gen to ver conversion topic branch to be merged to both > > drm-intel-next and drm-intel-gt-next. > > Pulled. Pulled, thanks. (Sorry fo

Re: [PATCH] drm/i915: fix an error code in intel_overlay_do_put_image()

2021-04-20 Thread Rodrigo Vivi
n Carpenter Reviewed-by: Rodrigo Vivi and pushed. thanks for the patch. > --- > drivers/gpu/drm/i915/display/intel_overlay.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c > b/drivers/gpu/drm/i915/d

[PULL] drm-intel-fixes

2021-04-22 Thread Rodrigo Vivi
d AUX timeouts (Imre) Imre Deak (1): drm/i915: Fix modesetting in case of unexpected AUX timeouts Rodrigo Vivi (1): Merge tag 'gvt-fixes-2021-04-20' of https://github.com/intel/gvt-linux into drm-intel-fixes Zhenyu Wang (1):

[PULL] drm-intel-fixes

2021-08-04 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2021-08-04: - Call i915_globals_exit if pci_register_device fails (Jason) - Correct SFC_DONE register offset (Matt) Thanks, Rodrigo. The following changes since commit c500bee1c5b2f1d59b1081ac879d73268ab0ff17: Linux 5.14-rc4 (2021-08-01 17:04:17

Re: [Intel-gfx] linux-next: Signed-off-by missing for commit in the drm-intel tree

2021-08-11 Thread Rodrigo Vivi
On Wed, Aug 11, 2021 at 10:16:41AM +0300, Jani Nikula wrote: > On Tue, 10 Aug 2021, Daniel Vetter wrote: > > On Mon, Aug 09, 2021 at 09:19:39AM -0700, Matt Roper wrote: > >> On Mon, Aug 09, 2021 at 04:05:59PM +0200, Daniel Vetter wrote: > >> > On Fri, Aug 06, 2021 at 09:36:56AM +0300, Joonas Lahti

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/hdcp: read RxInfo once when reading RepeaterAuth_Send_ReceiverID_List

2021-08-11 Thread Rodrigo Vivi
On Tue, Aug 10, 2021 at 04:52:11PM -0700, Juston Li wrote: > When reading RepeaterAuth_Send_ReceiverID_List, RxInfo is read by itself > once to retrieve the DEVICE_COUNT to calculate the size of the > ReceiverID list then read a second time as a part of reading ReceiverID > list. > > On some MST d

[PULL] drm-intel-fixes

2021-08-12 Thread Rodrigo Vivi
fused off Rodrigo Vivi (1): Merge tag 'gvt-fixes-2021-08-10' of https://github.com/intel/gvt-linux into drm-intel-fixes Zhenyu Wang (1): drm/i915/gvt: Fix cached atomics setting for Windows VM Documentation/gpu/rfc/i915_gem_lmem.rst | 109 ---

[PULL] drm-intel-fixes

2021-08-18 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2021-08-18: - Expand a tweaked display workaround for all PCHs. (Anshuman) - Fix eDP MSO pipe sanity checks for ADL-P. (Jani) - Remove superfluous EXPORT_SYMBOL(). (Jani) Thanks, Rodrigo. The following changes since commit 7c60610d476766e128cc4284bb

Re: [PATCH] drm/i915/gt: Potential error pointer dereference in pinned_context()

2021-08-20 Thread Rodrigo Vivi
On Fri, Aug 13, 2021 at 04:01:06PM +0200, Thomas Hellström wrote: > > On 8/13/21 1:36 PM, Dan Carpenter wrote: > > If the intel_engine_create_pinned_context() function returns an error > > pointer, then dereferencing "ce" will Oops. Use "vm" instead of > > "ce->vm". > > > > Fixes: cf586021642d (

Re: [PATCH] drm/i915: Actually delete gpu reloc selftests

2021-08-20 Thread Rodrigo Vivi
e need the Fixes: tag? anyway: Reviewed-by: Rodrigo Vivi > > I deleted the gpu relocation code and the selftest include and > enabling, but accidentally forgot about the selftest source code. > > Fix this oversight. > > Signed-off-by: Daniel Vetter > Cc: Jon

Re: [PATCH v3] drm/i915/dp: Use max params for panels < eDP 1.4

2021-08-26 Thread Rodrigo Vivi
On Fri, Aug 20, 2021 at 08:26:14PM +0300, Ville Syrjälä wrote: > On Fri, Aug 20, 2021 at 03:52:59PM +0800, Kai-Heng Feng wrote: > > Users reported that after commit 2bbd6dba84d4 ("drm/i915: Try to use > > fast+narrow link on eDP again and fall back to the old max strategy on > > failure"), the scre

[PULL] drm-intel-fixes

2021-08-26 Thread Rodrigo Vivi
Hi Dave and Daniel, I also had other 2 display patches, but I decided to keep them out for now because CI_DIF_604 returned a bunch of link training errors on TGL when compared to CI_DIF_603 which is based on drm/drm-fixes. Those patches are: d7f213c131ad ("drm/i915/dp: Use max params for panels <

Re: [Intel-gfx] [PATCH] drm/i915/display/vlv_dsi: Do no shut down displays on reboot if a DSI panel is used

2021-03-22 Thread Rodrigo Vivi
On Fri, Mar 19, 2021 at 04:45:32PM +0100, Hans de Goede wrote: > Hi, > > On 3/1/21 4:43 PM, Hans de Goede wrote: > > After the recently added commit fe0f1e3bfdfe ("drm/i915: Shut down > > displays gracefully on reboot"), the DSI panel on a Cherry Trail based > > Predia Basic tablet would no longer

Re: [PATCH 1/2] drm/i915: add gem/gt TODO

2021-03-23 Thread Rodrigo Vivi
ust in their heads. > > This is a different situation here, and the "changes require big audience" > is a feature, not a bug. But it is a very exceptional situation, I think > this is only the 2nd time we're using a formal TODO for a gpu driver. If > we ignore gma500 in st

Re: [PATCH 2/2] drm/doc: Add RFC section

2021-03-23 Thread Rodrigo Vivi
On Tue, Mar 23, 2021 at 09:44:53AM +0100, Daniel Vetter wrote: > Motivated by the pre-review process for i915 gem/gt features, but > probably useful in general for complex stuff. > > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Jason Ekstrand > Cc: D

Re: [PATCH 2/2] drm/doc: Add RFC section

2021-03-23 Thread Rodrigo Vivi
On Tue, Mar 23, 2021 at 02:10:17PM +0100, Daniel Vetter wrote: > On Tue, Mar 23, 2021 at 08:37:07AM -0400, Rodrigo Vivi wrote: > > On Tue, Mar 23, 2021 at 09:44:53AM +0100, Daniel Vetter wrote: > > > Motivated by the pre-review process for i915 gem/gt features, but > > >

[PULL] drm-intel-fixes

2021-03-25 Thread Rodrigo Vivi
Hi Dave and Daniel, with GT fence revocation runtime PM logic targeting 4.12+ stable, here goes drm-intel-fixes-2021-03-25-1: - DisplayPort LTTPR fixes around link training and limiting it according to supported spec version. (Imre) - Fix enabled_planes bitmask to really represent only logicall

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check actual RC6 status

2021-04-01 Thread Rodrigo Vivi
On Wed, Mar 31, 2021 at 11:18:50AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > RC6 support cannot be simply established by looking at the static device > HAS_RC6() flag. There are cases which disable RC6 at driver load time so > use the status of those check when deciding whether to e

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Do not report 100% RC6 if not supported

2021-04-01 Thread Rodrigo Vivi
missed this one... > > Fix by not advancing the estimated RC6 counter when feature is not > supported. either this or the other proposal, consider both as Reviewed-by: Rodrigo Vivi I prefer this, but I don't have strong opinions on which one. you (or Eero) pick one... >

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check actual RC6 status

2021-04-01 Thread Rodrigo Vivi
On Thu, Apr 01, 2021 at 10:38:11AM +0100, Tvrtko Ursulin wrote: > > On 01/04/2021 10:19, Rodrigo Vivi wrote: > > On Wed, Mar 31, 2021 at 11:18:50AM +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > RC6 support cannot be simply esta

[PULL] drm-intel-next

2021-01-27 Thread Rodrigo Vivi
t on DSI transcoder Radhakrishna Sripada (2): drm/framebuffer: Format modifier for Intel Gen 12 render compression with Clear Color drm/i915/tgl: Add Clear Color support for TGL Render Decompression Rodrigo Vivi (1): Merge drm/drm-next into drm-intel-next Ville Syrjälä

[PULL] drm-intel-next

2021-01-29 Thread Rodrigo Vivi
Hi Dave and Daniel, On my last pull request I incorrectly stated that Async flips were enabled for all ilk+ platforms, while it was only on SKL. I'm sorry about that. I hope there's still time to include a few changes including the actual patches that make this statement true for 5.12. Along wit

Re: [RFC v2 4/5] drm/dp: Extract i915's eDP backlight code into DRM helpers

2021-02-03 Thread Rodrigo Vivi
On Mon, Jan 25, 2021 at 07:10:30PM -0500, Lyude Paul wrote: > Since we're about to implement eDP backlight support in nouveau using the > standard protocol from VESA, we might as well just take the code that's > already written for this and move it into a set of shared DRM helpers. > > Note that t

Re: [RFC v3 04/10] drm/i915/dpcd_bl: Handle drm_dpcd_read/write() return values correctly

2021-02-08 Thread Rodrigo Vivi
ust handle the return values from each function > correctly. > > Signed-off-by: Lyude Paul Reviewed-by: Rodrigo Vivi > --- > .../drm/i915/display/intel_dp_aux_backlight.c | 41 +-- > 1 file changed, 19 insertions(+), 22 deletions(-) > > diff --git a/drivers/

Re: [RFC v3 06/10] drm/i915/dpcd_bl: Cache some backlight capabilities in intel_panel.backlight

2021-02-08 Thread Rodrigo Vivi
t exactly match up with what we > actually need to use them for, like DP_EDP_BACKLIGHT_BRIGHTNESS_BYTE_COUNT > for instance). > > Signed-off-by: Lyude Paul Reviewed-by: Rodrigo Vivi > --- > .../drm/i915/display/intel_display_types.h| 2 ++ > .../drm/i915/display/intel_dp

Re: [RFC v3 07/10] drm/i915/dpcd_bl: Move VESA backlight enabling code closer together

2021-02-08 Thread Rodrigo Vivi
On Fri, Feb 05, 2021 at 06:45:11PM -0500, Lyude Paul wrote: > No functional changes, just move set_vesa_backlight_enable() closer to it's > only caller: intel_dp_aux_vesa_enable_backlight(). > > Signed-off-by: Lyude Paul Reviewed-by: Rodrigo Vivi > --- >

Re: [Intel-gfx] [PATCH v5 1/4] drm/i915/gen9_bc: Recognize TGP PCH + CML combos

2021-02-10 Thread Rodrigo Vivi
's own patch - vsyrjala > > Cc: Matt Roper > Cc: Jani Nikula > Cc: Ville Syrjala > [originally from Tejas's work] > Signed-off-by: Tejas Upadhyay > Signed-off-by: Lyude Paul Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_pch.c | 3 ++- >

Re: [PATCH v5 3/4] drm/i915/gen9_bc: Introduce HPD pin mappings for TGP PCH + CML combos

2021-02-10 Thread Rodrigo Vivi
* Introduce skl_hpd_pin() like vsyrjala suggested and use that instead of > sticking our HPD pin mappings in TGP code > > Cc: Matt Roper > Cc: Jani Nikula > Cc: Ville Syrjala > [originally from Tejas's work] > Signed-off-by: Tejas Upadhyay > Signed-off-by: Lyude Pau

Re: [PATCH v5 4/4] drm/i915/gen9_bc: Add W/A for missing STRAP config on TGP PCH + CML combos

2021-02-10 Thread Rodrigo Vivi
On Tue, Feb 09, 2021 at 04:28:31PM -0500, Lyude Paul wrote: > Apparently the new gen9_bc platforms that Intel has introduced don't > provide us with a STRAP config register to read from for initializing DDI > B, C, and D detection. So, workaround this by hard-coding our strap config > in intel_setu

Re: [Intel-gfx] [PATCH v5 2/4] drm/i915/gen9_bc: Introduce TGP PCH DDC pin mappings

2021-02-10 Thread Rodrigo Vivi
struct intel_encoder > *encoder) > ddc_pin = dg1_port_to_ddc_pin(dev_priv, port); > else if (IS_ROCKETLAKE(dev_priv)) > ddc_pin = rkl_port_to_ddc_pin(dev_priv, port); > + else if (IS_GEN9_BC(dev_priv) && HAS_PCH_TGP(dev_priv)) > +

Re: [Intel-gfx] [RFC v4 09/11] drm/i915/dpcd_bl: Print return codes for VESA backlight failures

2021-02-10 Thread Rodrigo Vivi
> us that anyway). > > Signed-off-by: Lyude Paul Reviewed-by: Rodrigo Vivi > --- > .../drm/i915/display/intel_dp_aux_backlight.c | 101 +- > 1 file changed, 52 insertions(+), 49 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_back

Re: [Intel-gfx] [RFC v4 08/11] drm/i915/dpcd_bl: Return early in vesa_calc_max_backlight if we can't read PWMGEN_BIT_COUNT

2021-02-10 Thread Rodrigo Vivi
y > fail on reading DP_EDP_PWMGEN_BIT_COUNT_CAP_MIN. There's not much point in > doing this, so just return early. > > Signed-off-by: Lyude Paul Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deleti

Re: [RFC v4 05/11] drm/i915/dpcd_bl: Cleanup intel_dp_aux_vesa_enable_backlight() a bit

2021-02-10 Thread Rodrigo Vivi
_CONTROL_MODE_MASK - imirkin > > Signed-off-by: Lyude Paul Reviewed-by: Rodrigo Vivi > --- > .../gpu/drm/i915/display/intel_dp_aux_backlight.c | 15 ++- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_

Re: [Intel-gfx] [RFC v4 10/11] drm/dp: Extract i915's eDP backlight code into DRM helpers

2021-02-10 Thread Rodrigo Vivi
On Mon, Feb 08, 2021 at 06:39:00PM -0500, Lyude Paul wrote: > Since we're about to implement eDP backlight support in nouveau using the > standard protocol from VESA, we might as well just take the code that's > already written for this and move it into a set of shared DRM helpers. > > Note that t

Re: [Intel-gfx] [PATCH v5 4/4] drm/i915/gen9_bc: Add W/A for missing STRAP config on TGP PCH + CML combos

2021-02-11 Thread Rodrigo Vivi
On Wed, Feb 10, 2021 at 10:23:58PM -0500, Rodrigo Vivi wrote: > On Tue, Feb 09, 2021 at 04:28:31PM -0500, Lyude Paul wrote: > > Apparently the new gen9_bc platforms that Intel has introduced don't > > provide us with a STRAP config register to read from for initializing

Re: [PATCH v3 2/2] drm/i915/icp+: Use icp_hpd_irq_setup() instead of spt_hpd_irq_setup()

2021-02-17 Thread Rodrigo Vivi
o > be calling icp_hpd_irq_setup() to ensure that CML-S/TGP platforms function > correctly anyway, let's move platforms using PCH_ICP which aren't handled > by gen11_hpd_irq_setup() over to icp_hpd_irq_setup(). > > Cc: Tejas Upadhyay > Signed-off-by: Lyude Paul m

[PULL] drm-intel-next-fixes

2021-02-18 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-next-fixes-2021-02-18: - Restrict DRM_I915_DEBUG to developer builds (Chris) - Fix return and error codes (Dan) - Suspend/Resume fix (Chris) - Disable atomics in L3 for gen9 (Chris) - Flush before changing register state (Chris) - Fix for GLK's HDMI (Ville)

Re: [Intel-gfx] [PATCH 19/30] drm/dp: Pass drm_dp_aux to drm_dp_link_train_clock_recovery_delay()

2021-02-23 Thread Rodrigo Vivi
one already solves the issue... Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +- > drivers/gpu/drm/drm_dp_helper.c | 3 ++- > drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +- > drive

[PULL] drm-intel-next-fixes

2021-02-25 Thread Rodrigo Vivi
drm/i915: Enable -Wuninitialized Rodrigo Vivi (1): Merge tag 'gvt-next-fixes-2021-02-22' of https://github.com/intel/gvt-linux into drm-intel-next-fixes Ville Syrjälä (1): drm/i915: Nuke INTEL_OUTPUT_FORMAT_INVALID Zhi Wang (1): drm/i915/gvt: Introduce per ob

[PULL] drm-intel-fixes

2021-03-11 Thread Rodrigo Vivi
Hi Dave and Daniel, Things are very quiet. Only 1 fix this round. Since I will be out next week, if this trend continues I will accumulate 2 weeks and send when in -rc4. Here goes drm-intel-fixes-2021-03-11: - Wedge the GPU if command parser setup fails (Tvrtko) Thanks, Rodrigo. The following

Re: [PULL] drm-intel-fixes

2021-03-11 Thread Rodrigo Vivi
On Fri, Mar 12, 2021 at 11:36:51AM +1000, Dave Airlie wrote: > On Thu, 11 Mar 2021 at 21:28, Rodrigo Vivi wrote: > > > > Hi Dave and Daniel, > > > > Things are very quiet. Only 1 fix this round. > > Since I will be out next week, if this trend continues I will >

Re: Enabling sample_c optimization for Broadwell GPUs

2021-05-05 Thread Rodrigo Vivi
Hi Andre, I'm not familiar with the sample c message optimization. Probably Ken can comment. However I could check the internal spec here and I saw this bit only exists with this meaning in Haswell. For all the other platforms, including Broadwell it got re-purposed with a different meaning and

[PULL] drm-intel-next

2021-05-19 Thread Rodrigo Vivi
Extend PLANE_WM bits for blocks & lines Mika Kahola (1): drm/i915/adl_p: Enable/disable loadgen sharing Rodrigo Vivi (3): Merge tag 'topic/intel-gen-to-ver-2021-04-19' of git://anongit.freedesktop.org/drm/drm-intel into drm-intel-next drm/i915/dmc: Let's abs

[PULL] drm-intel-fixes

2020-11-25 Thread Rodrigo Vivi
Hi Dave and Daniel, Please notice that commit eb0104ee498d ("drm/i915/gt: Track signaled breadcrumbs outside of the breadcrumb spinlock") is just a dependency of commit 2e6ce8313a53 ("drm/i915/gt: Don't cancel the interrupt shadow too early"). Here goes drm-intel-fixes-2020-11-25: - Fix Perf/OA

Re: Dim blowing up in my face

2020-12-01 Thread Rodrigo Vivi
On Tue, Dec 01, 2020 at 06:24:56PM +0100, Daniel Vetter wrote: > On Tue, Dec 1, 2020 at 6:22 PM Daniel Vetter wrote: > > > > On Tue, Dec 1, 2020 at 5:58 PM Christian König > > wrote: > > > > > > Hi Daniel, > > > > > > I've just pushed a minor TTM cleanup and dim is complaining that > > > drm-int

[PULL] drm-intel-fixes

2020-12-02 Thread Rodrigo Vivi
Hi Dave and Daniel, Fixes for GPU hang, null dereference, suspend-resume, power consumption, and use-after-free. The commit 6db58901c2aa ("drm/i915/display: return earlier from intel_modeset_init() without display") was not actually a crucial fix, but it allowed a clean pick of the use-after-f

Re: [PULL] drm-intel-fixes

2020-12-02 Thread Rodrigo Vivi
On Wed, Dec 02, 2020 at 04:36:24PM -0800, Rodrigo Vivi wrote: > Hi Dave and Daniel, > > Fixes for GPU hang, null dereference, suspend-resume, power consumption, and > use-after-free. > > The commit 6db58901c2aa ("drm/i915/display: return earlier from > intel_mode

[PULL] drm-intel-fixes v2

2020-12-03 Thread Rodrigo Vivi
Hi Dave and Daniel, Please ignore the pull request I had sent yesterday and use only this one. I had missed one patch: 14d1eaf08845 ("drm/i915/gt: Protect context lifetime with RCU"). Also, please notice that the commit 6db58901c2aa ("drm/i915/display: return earlier from +intel_modeset_init()

[PULL] drm-intel-fixes

2020-12-09 Thread Rodrigo Vivi
Hi Dave and Daniel, The commit 7c5c15dffe1e ("drm/i915/gt: Declare gen9 has 64 mocs entries!") should actually be sent last week along with the commit 777a7717d60c ("drm/i915/gt: Program mocs:63 for cache eviction on gen9"), but I had missed that and dim didn't cope with fixes for fixes. Here goe

Re: [PATCH] drm/i915/display/tc: Only WARN once for bogus tc port flag

2020-12-09 Thread Rodrigo Vivi
On Wed, Dec 09, 2020 at 04:16:36PM -0500, Sean Paul wrote: > From: Sean Paul > > No need to spam syslog/console when we can ignore/fix the flag. besides that we are calling from multiple places anyway.. > > Signed-off-by: Sean Paul Reviewed-by: Rodrigo Vivi > ---

[PULL] drm-intel-next-fixes

2021-06-29 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-next-fixes-2021-06-29: The biggest fix is the restoration of mmap ioctl for gen12 integrated parts which lack was breaking ADL-P with media stack. Besides that a small selftest fix and a theoretical overflow on i915->pipe_to_crtc_mapping. Thanks, Rodrigo.

Re: [PULL] drm-intel-next-fixes

2021-06-30 Thread Rodrigo Vivi
On Wed, Jun 30, 2021 at 01:05:35PM +0300, Jani Nikula wrote: > On Tue, 29 Jun 2021, Rodrigo Vivi wrote: > > Hi Dave and Daniel, > > > > Here goes drm-intel-next-fixes-2021-06-29: > > > > The biggest fix is the restoration of mmap ioctl for gen12 integrated parts

Re: [Intel-gfx] [PULL] drm-intel-next-fixes

2021-07-01 Thread Rodrigo Vivi
On Thu, Jul 01, 2021 at 11:57:53AM +0300, Jani Nikula wrote: > On Wed, 30 Jun 2021, Rodrigo Vivi wrote: > > On Wed, Jun 30, 2021 at 01:05:35PM +0300, Jani Nikula wrote: > >> On Tue, 29 Jun 2021, Rodrigo Vivi wrote: > >> > Hi Dave and Daniel, > >> > >

Re: [PATCH 23/53] drm/i915/xehpsdv: Read correct RP_STATE_CAP register

2021-07-01 Thread Rodrigo Vivi
On Thu, Jul 01, 2021 at 01:23:57PM -0700, Matt Roper wrote: > The RP_STATE_CAP register is no longer part of the MCHBAR on XEHPSDV; this > register is now a per-tile register at GTTMMADDR offset 0x250014. > > Cc: Rodrigo Vivi > Signed-off-by: Matt Roper > Signed-off-b

Re: [PATCH 16/53] drm/i915/xehpsdv: add initial XeHP SDV definitions

2021-07-01 Thread Rodrigo Vivi
f this platform. > > Bspec: 44467, 48077 > Cc: Rodrigo Vivi > Signed-off-by: Lucas De Marchi > Signed-off-by: Daniele Ceraolo Spurio > Signed-off-by: José Roberto de Souza > Signed-off-by: Stuart Summers > Signed-off-by: Tomas Winkler > Signed-off-by: Matt Roper Re

[PULL] drm-intel-next-fixes

2021-07-07 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-next-fixes-2021-07-07: One fix targeting stable for display DP VSC, plus DG1 display fix and a bug fix of IRQs usages and cleanup references to the DRM IRQ midlayer. Thanks, Rodrigo. The following changes since commit 8a02ea42bc1d4c448caf1bab0e05899dad503

Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix -EDEADLK handling regression

2021-07-13 Thread Rodrigo Vivi
On Tue, Jul 13, 2021 at 09:59:18PM +0200, Daniel Vetter wrote: > On Tue, Jul 13, 2021 at 9:58 PM Daniel Vetter wrote: > > > > On Thu, Jul 1, 2021 at 9:07 AM Maarten Lankhorst > > wrote: > > > Op 30-06-2021 om 18:44 schreef Ville Syrjala: > > > > From: Ville Syrjälä > > > > > > > > The conversion

[PULL] drm-intel-fixes

2021-07-15 Thread Rodrigo Vivi
Hi Dave and Daniel, I was unsure about the -EDEADLK one based on Daniel's comment on dri-devel, but Ville's response and the patch looks reasonable to me. Also they are in sync with the test cases. So if anything needs to still change on that area I believe it can be a follow-up work. Here goes d

Re: misc vgaarb cleanups

2021-07-16 Thread Rodrigo Vivi
t; drivers/gpu/drm/i915/display/intel_vga.c |9 +- The parts touching i915 looks clean to me Acked-by: Rodrigo Vivi > drivers/gpu/drm/nouveau/nouveau_vga.c |8 - > drivers/gpu/drm/radeon/radeon_device.c | 11 +- > drivers/gpu/vga/vgaarb.c | 67 +++

Re: [PATCH v5 12/15] drm/i915/pxp: Enable PXP power management

2021-07-16 Thread Rodrigo Vivi
odes, simplify rpm ops (Chris), use the new worker func > v4: invalidate the objects on suspend, don't re-create the arb sesson on > resume (delayed to first submission). > v5: move irq changes back to irq patch (Rodrigo) Reviewed-by: Rodrigo Vivi > > Signed-off-by: Huang, Sean

Re: linux-next: build failure after merge of the drm-intel-fixes tree

2020-11-03 Thread Rodrigo Vivi
On Wed, Nov 04, 2020 at 09:37:05AM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the drm-intel-fixes tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/gpu/drm/i915/gt/intel_lrc.c: In function 'gen12_emit_fini_breadcrumb': > drivers/gpu/drm/i915/gt/i

[PULL] drm-intel-fixes

2020-11-05 Thread Rodrigo Vivi
ero out HWSP addr on hws_pga_write drm/i915/gvt: Set SNOOP for PAT3 on BXT/APL to workaround GPU BB hang drm/i915/gvt: Only pin/unpin intel_context along with workload drm/i915/gvt: Fix mmio handler break on BXT/APL. Imre Deak (1): drm/i915: Fix encoder lookup during PSR atomic ch

  1   2   3   4   5   6   7   8   9   10   >