Re: [PATCH 1/2] drm/amd/display: Introduce overlay cursor mode

2024-03-28 Thread Robert Mader
the cursor is visible over this black bars, AMD currently refuses the commit IIUC (see also Michel Dänzers comment at https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3177#note_1924544) Thanks, Robert Mader During DC validation, attempt to enable a separate DCN pipe for the cursor if

Re: [PATCH] drm: drm_fourcc: add 10/12bit software decoder YCbCr formats

2025-04-24 Thread Robert Mader
Chris, Javier, Laurent - sorry for the noise, but given you reviewed changes in the respective files before, maybe you can help me moving this forward? I'd be very happy for any feedback to get this landed, thanks! :) On 07.04.25 21:13, Robert Mader wrote: This adds FOURCCs for 10/

[PATCH v2] drm: drm_fourcc: add 10/12/16bit software decoder YCbCr formats

2025-05-01 Thread Robert Mader
x27; formats. The 'S' stands for 'software' and was selected in order to make remembering easy. The 'Sx16' formats could as well be 'Qx16'. We stick with 'S' as 16bit software decoders are likely much more common than hardware ones for the foreseeab

Re: [PATCH] drm: drm_fourcc: add 10/12bit software decoder YCbCr formats

2025-05-01 Thread Robert Mader
Hi Tomi On 24.04.25 18:49, Tomi Valkeinen wrote: Hi, On 24/04/2025 16:31, Laurent Pinchart wrote: On Thu, Apr 24, 2025 at 02:53:18PM +0200, Robert Mader wrote: Chris, Javier, Laurent - sorry for the noise, but given you reviewed changes in the respective files before, maybe you can help me

Re: [PATCH] drm: drm_fourcc: add 10/12bit software decoder YCbCr formats

2025-05-01 Thread Robert Mader
Hey Laurent, thanks for the feedback! On 24.04.25 15:31, Laurent Pinchart wrote: On Thu, Apr 24, 2025 at 02:53:18PM +0200, Robert Mader wrote: Chris, Javier, Laurent - sorry for the noise, but given you reviewed changes in the respective files before, maybe you can help me moving this forward

Re: [PATCH] drm: drm_fourcc: add 10/12bit software decoder YCbCr formats

2025-05-01 Thread Robert Mader
Hey Javier, thanks for the reply anyway. FTR., the formats are very similar to DRM_FORMAT_Q410, just with different alignment. On 29.04.25 12:47, Javier Martinez Canillas wrote: Robert Mader writes: Hello Robert, Chris, Javier, Laurent - sorry for the noise, but given you reviewed changes

[PATCH] drm: drm_fourcc: add 10/12bit software decoder YCbCr formats

2025-04-10 Thread Robert Mader
suggestions are very welcome. Signed-off-by: Robert Mader --- drivers/gpu/drm/drm_fourcc.c | 18 ++ include/uapi/drm/drm_fourcc.h | 20 2 files changed, 38 insertions(+) diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c index 3a94ca211f9c

[PATCH v3] drm: drm_fourcc: add 10/12/16bit software decoder YCbCr formats

2025-05-09 Thread Robert Mader
G16_B16_R16_3PLANE_420_UNORM - VK_FORMAT_G16_B16_R16_3PLANE_422_UNORM - VK_FORMAT_G16_B16_R16_3PLANE_444_UNORM Signed-off-by: Robert Mader --- Changes in v3: - Changed x to z in the padding annotation to make it clear that the values need to be 0. Also added that to the comments - Added additional links to userspace MRs

Re: [PATCH v3] drm: drm_fourcc: add 10/12/16bit software decoder YCbCr formats

2025-05-16 Thread Robert Mader
Hey Dave, sorry for the noise, I just wanted to quickly ask if with Daniels R-b below this patch is good to go into 6.16 once the window opens? Still new to the process here, therefore want to double-check :) Thanks and best regards, Robert Mader On 12.05.25 16:26, Daniel Stone wrote: Hi

[PATCH v1] drm/vkms: Add writeback encoders as possible clones

2025-07-03 Thread Robert Mader
nes: {0, 1} │ └───Encoder 1 │ ├───Object ID: 50 │ ├───Type: virtual │ ├───CRTCS: {0} │ └───Clones: {0, 1} Signed-off-by: Robert Mader --- drivers/gpu/drm/vkms/vkms_output.c| 12 drivers/gpu/drm/vkms/vkms_writeback.c | 2 ++ 2 files changed, 14 insertions(+) di

Re: [PATCH v1] drm/vkms: Add writeback encoders as possible clones

2025-07-18 Thread Robert Mader
Thanks for the feedback! On 06.07.25 13:29, Dmitry Baryshkov wrote: On Thu, Jul 03, 2025 at 11:03:35AM +0200, Robert Mader wrote: Since commit 41b4b11da0215 ("drm: Add valid clones check") setting the `possible_clones` values is a hard requirement for cloning. `vkms` supports c

[PATCH v2] drm/vkms: Add writeback encoders as possible clones

2025-07-18 Thread Robert Mader
nes: {0, 1} │ └───Encoder 1 │ ├───Object ID: 50 │ ├───Type: virtual │ ├───CRTCS: {0} │ └───Clones: {0, 1} Fixes: dbd9d80c1b2e (drm/vkms: Add support for writeback) Signed-off-by: Robert Mader --- drivers/gpu/drm/vkms/vkms_output.c| 13 + drivers/gpu/drm/vkms/vkms_w

Re: [PATCH v1] drm/vkms: Add writeback encoders as possible clones

2025-07-18 Thread Robert Mader
On 18.07.25 12:23, Louis Chauvet wrote: Le 03/07/2025 à 11:03, Robert Mader a écrit : Since commit 41b4b11da0215 ("drm: Add valid clones check") setting the `possible_clones` values is a hard requirement for cloning. `vkms` supports cloning for writeback connectors in order to ca

Re: [PATCH v2] drm/vkms: Add writeback encoders as possible clones

2025-07-31 Thread Robert Mader
Hey Louis, would you be fine to add your Rb on this one? :) Would love to get it into drm-next / 6.17. On 18.07.25 14:14, Robert Mader wrote: Since commit 41b4b11da0215 ("drm: Add valid clones check") setting the `possible_clones` values is a hard requirement for cloning. `vkms

Re: [PATCH v2] drm/vkms: Add writeback encoders as possible clones

2025-07-31 Thread Robert Mader
On 31.07.25 13:45, Louis Chauvet wrote: Oops, sorry, I just tested it, it works Reviewed-by: Louis Chauvet Nice, thank a lot! Quick follow-up: do you think it could already be included in drm-misc-next? And if so, could you do that? Best regards Le 31/07/2025 à 12:45, Robert Mader a