Pushed to drm-misc-next
Hey Allen,
Sorry about the slow reviewing, let's have a look at this driver.
Running 'checkpatch --strict' reveals a few checks and warnings that
should be fixed.
On Fri, 16 Jul 2021 at 09:38, allen wrote:
>
> This adds support for the iTE IT6505.
> This device can convert DPI signal to DP outp
r power sequencing in data sheet */
> + regmap_update_bits(pdata->regmap, SN_SSC_CONFIG_REG,
> DP_NUM_LANES_MASK, 0);
> + /* disable DP PLL */
> + regmap_write(pdata->regmap, SN_PLL_ENABLE_REG, 0);
> +
> if (!pdata->refclk)
> ti_sn65dsi86_disable_comms(pdata);
>
> --
> 2.32.0.432.gabb21c7263-goog
>
Acked-by: Robert Foss
ruct drm_bridge
> *bridge)
>
> if (!pdata->refclk)
> ti_sn65dsi86_enable_comms(pdata);
> +
> + /* td7: min 100 us after enable before DSI data */
> + usleep_range(100, 110);
> }
>
> static void ti_sn_bridge_post_disable(struct drm_bridge *bridge)
> --
> 2.32.0.432.gabb21c7263-goog
>
Acked-by: Robert Foss
Hey Jagan,
On Sun, 4 Jul 2021 at 11:04, Jagan Teki wrote:
>
> Now the exynos dsi driver is fully aware of bridge
> handling, so get the display mode from bridge, mode_set
> API instead of legacy encoder crtc.
>
> This makes bridge usage more efficient instead of relying
> on encoder stack.
>
> Ad
> Yes, you are right, there are many files reference
> gpiod_set_value_cansleep() and
>
> devm_gpiod_get_optional(). How about add config dependencies for all
> releated
I think this is the way to go and roughly half of the drm bridge
drivers seem to need this change.
Do you mind submitting a ser
Hey Zhang,
On Thu, 8 Apr 2021 at 09:10, zhangjianhua (E) wrote:
>
> Hello Robert
>
> I am sorry that I make a mistake about the compiling error of lt8912b,
>
> the reason is that lt8912b miss the header file .
>
> Although there are many files reference gpiod_set_value_cansleep() and
>
> devm_gpi
bridge/lontium-lt8912b.c
> index 61491615bad0..79845b3b19e1 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt8912b.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c
> @@ -3,6 +3,7 @@
> * Copyright (c) 2018, The Linux Foundation. All rights reserved.
> */
>
> +#inc
1: error: ‘GPIOD_OUT_HIGH’
> undeclared (first use in this function); did you mean ‘GPIOF_INIT_HIGH’?
> gp_reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
>^~
>
ned-off-by: Robert Foss
Reported-by: kernel test robot
---
Changes since v1:
- Fix typo on comment
drivers/gpu/drm/bridge/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 22a467abd3e9..2289b44613af 10
te_and(ctx, ctx->i2c.tx_p2_client, 0x08, 0x7f);
>
> ret |= anx7625_video_mute_control(ctx, 1);
> +
> + DRM_DEV_DEBUG_DRIVER(dev, "notify downstream enter into standby\n");
> +
> + /* Downstream monitor enter into standby mode */
> + data = 2;
> + ret |= anx7625_aux_dpcd_write(ctx, 0x00, 0x06, 0x00, 1, &data);
> if (ret < 0)
> DRM_DEV_ERROR(dev, "IO error : mute video fail\n");
> +
> + return;
> }
Reviewed-by: Robert Foss
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Merged series.
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=6a3608eae6d33a478a29348eb5e9ca330a528ae6
On Sat, 10 Apr 2021 at 20:14, Parshuram Thombare wrote:
>
> This patch series enables HDCP in Cadence MHDP DPI/DP bridge driver.
>
> Changes since v1:
> - Move sapb reg block right after
Hey Randy,
Thanks for looking at this!
On Fri, 9 Apr 2021 at 18:38, Randy Dunlap wrote:
>
> On 4/8/21 6:07 AM, Robert Foss wrote:
> > The DRM_SIL_SII8620 kconfig has a weak `imply` dependency
> > on EXTCON, which causes issues when sii8620 is built
> > as a builtin
'
#27: FILE: MAINTAINERS:9537:
+F:drivers/gpu/drm/bridge/ite-it66121.c
+T:git git://anongit.freedesktop.org/drm/drm-misc
With this warning silenced, feel free to add my r-b.
Reviewed-by: Robert Foss
> > +F: Documentation/devicetree/bindings/display/bridge/ite,i
Hey Neil & Phong,
Thanks for submitting this series!
> +
> +static const struct drm_bridge_funcs it66121_bridge_funcs = {
> + .attach = it66121_bridge_attach,
> + .enable = it66121_bridge_enable,
> + .disable = it66121_bridge_disable,
> + .mode_set = it66121_bridge_mode_se
On Wed, 14 Apr 2021 at 08:13, Neil Armstrong wrote:
>
> Hi Rob,
>
> Le 13/04/2021 à 22:21, Robert Foss a écrit :
> > Hey Neil & Phong,
> >
> > Thanks for submitting this series!
> >
> >> +
> >> +static const struct drm_
Thanks Randy!
Reviewed-by: Robert Foss
On Thu, 15 Apr 2021 at 20:36, Randy Dunlap wrote:
>
> The Analogix DRM ANX7625 bridge driver uses mips_dsi_() function
> interfaces so it should select DRM_MIPI_DSI to prevent build errors.
>
>
> ERROR: modpost: "mipi_dsi_atta
fe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge")
> > Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC
> > bridge")
> > Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> > Signed-off-by: R
Merged for 5.13 in drm-misc-next-fixes
On Fri, 16 Apr 2021 at 10:41, Robert Foss wrote:
>
> Thanks Randy!
>
> Reviewed-by: Robert Foss
>
> On Thu, 15 Apr 2021 at 20:36, Randy Dunlap wrote:
> >
> > The Analogix DRM ANX7625 bridge driver uses mips_dsi_() functi
Hey Adrien,
On Fri, 16 Apr 2021 at 14:02, Adrien Grassein wrote:
>
> Hi Robert,
>
> Could you please have a look at this patch?
> It has been reviewed by the bug reporter and another person.
>
> I don't receive any "merged" message.
>
> Thanks a lot,
> Adrien
>
> Le mer. 31 mars 2021 à 16:42, Dan
er.
Fixes: 688838442147 ("drm/bridge/sii8620: use micro-USB cable detection logic
to detect MHL")
Signed-off-by: Robert Foss
Reported-by: kernel test robot
---
LKP reported issue:
https://lore.kernel.org/lkml/202104040604.sste2cxf-...@intel.com/
Changes since v1:
- Fix typo on comment
Change
Hey Neil,
Thanks for the quick respin.
Reviewed-by: Robert Foss
On Mon, 19 Apr 2021 at 09:12, Neil Armstrong wrote:
>
> From: Phong LE
>
> This commit is a simple driver for bridge HMDI it66121.
> The input format is RBG and there is no color conversion.
> Audio, HD
On Mon, Apr 19, 2021, 19:11 Randy Dunlap wrote:
> On 4/19/21 2:01 AM, Robert Foss wrote:
> > The DRM_SIL_SII8620 kconfig has a weak `imply` dependency
> > on EXTCON, which causes issues when sii8620 is built
> > as a builtin and EXTCON is built as a module.
> >
>
data from the I2S input.
>
> Signed-off-by: Sia Jee Heng
> Reviewed-by: Robert Foss
> ---
> drivers/gpu/drm/bridge/adv7511/adv7511.h | 1 +
> drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 6 ++
> 2 files changed, 7 insertions(+)
>
> diff --git a/driv
d-off-by: Randy Dunlap
> > Cc: Andrzej Hajda
> > Cc: Neil Armstrong
> > Cc: Robert Foss
> > Cc: David Airlie
> > Cc: Daniel Vetter
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: Icenowy Zheng
> > Cc: Vasily Khoruzhick
> > Cc: Torsten Duwe
ing word "power" in Kconfig help text.
> >> >
> >> > Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")
> >> > Signed-off-by: Randy Dunlap rdun...@infradead.org>>
> >> > Cc: Andrzej Hajda a.ha
Merged.
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=1fcf24fb07e254ca69001ab14adc8cf567127c44
On Wed, 28 Apr 2021 at 13:51, Hsin-Yi Wang wrote:
> From anx7625 spec, the delay between powering on power supplies and gpio
> should be larger than 10ms.
>
> Fixes: 6c744983004e ("drm/bridge:
Hey Tian,
Thanks for having a look at cleanup patches.
On Thu, 8 Apr 2021 at 04:06, Tian Tao wrote:
> Use devm_add_action_or_reset() instead of devres_alloc() and
> devres_add(), which works the same. This will simplify the
> code. There is no functional changes.
>
> Signed-off-by: Tian Tao
>
deset is needed by the up-coming patch which gets MIPI DSI
> controller and PHY ready in ->mode_set(), because it makes sure
> ->mode_set() and ->atomic_disable() are called in pairs.
>
> Cc: Andrzej Hajda
> Cc: Neil Armstrong
> Cc: Robert Foss
> Cc: Laurent Pinchart
Even better :)
On Fri, Apr 30, 2021, 13:46 Liu Ying wrote:
> Hi Robert,
>
> On Fri, 2021-04-30 at 11:56 +0200, Robert Foss wrote:
> > Hey Liu,
> >
> > This patch does not apply on upstream-drm-misc/drm-misc-next. When it
> > passes local testing & building,
Hey Nikolaus,
Thanks for submitting this series.
On Thu, 5 Aug 2021 at 16:08, H. Nikolaus Schaller wrote:
>
> From: Paul Boddie
>
> The platform-specific configuration structure is augmented with
> mode_fixup and timings members so that specialisations of the
> Synopsys driver can introduce mod
The return value of drm_bridge_attach() is ignored during
the it66121_bridge_attach() call, which is incorrect.
Fixes: 988156dc2fc9 ("drm: bridge: add it66121 driver")
Signed-off-by: Robert Foss
---
drivers/gpu/drm/bridge/ite-it66121.c | 2 ++
1 file changed, 2 insertions(+)
di
u/drm/bridge/analogix/anx7625.h
> @@ -210,7 +210,9 @@
> #define MIPI_VIDEO_STABLE_CNT 0x0A
>
> #define MIPI_LANE_CTRL_10 0x0F
> -#define MIPI_DIGITAL_ADJ_1 0x1B
> +#define MIPI_DIGITAL_ADJ_1 0x1B
> +#define IVO_MID0 0x26
> +#define IVO_MID1 0xCF
>
> #define MIPI_PLL_M_NUM_23_16 0x1E
> #define MIPI_PLL_M_NUM_15_80x1F
> --
> 2.25.1
>
LGTM with the above fix.
Reviewed-by: Robert Foss
On Thu, 5 Aug 2021 at 22:37, Jernej Škrabec wrote:
>
> Hi!
>
> Dne četrtek, 05. avgust 2021 ob 20:50:39 CEST je Robert Foss napisal(a):
> > The return value of drm_bridge_attach() is ignored during
> > the it66121_bridge_attach() call, which is incorrect.
> >
> &g
Hey Xin,
Thanks for implementing the suggestion so quickly.
Can you send this version of the patch out as v2? Versioning is
important and both tools and processes break if different versions
aren't submitted in different emails.
On Fri, 6 Aug 2021 at 11:35, Xin Ji wrote:
>
> IVO panel require l
Applied to drm-misc-next
Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP")
Reported-by: kernel test robot
Signed-off-by: Robert Foss
---
drivers/gpu/drm/bridge/analogix/anx7625.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c
b/
Hey Sam,
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index 14d73fb1dd15b..3471785915c45 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -771,7 +771,7 @@ static
The return value of sp_tx_rst_aux() is not propagated, which means
both compiler warnings and potential errors not being handled.
Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP")
Reported-by: kernel test robot
Signed-off-by: Robert Foss
---
Change
During the sp_tx_edid_read() call the return value of sp_tx_edid_read()
is ignored, which could cause potential errors to go unhandled.
All errors which are returned by sp_tx_edid_read() are handled in
anx7625_get_edid().
Signed-off-by: Robert Foss
---
drivers/gpu/drm/bridge/analogix/anx7625.c
Thanks Sam!
On Wed, 18 Aug 2021 at 19:40, Sam Ravnborg wrote:
>
> Hi Robert,
>
> On Wed, Aug 18, 2021 at 07:13:18PM +0200, Robert Foss wrote:
> > During the sp_tx_edid_read() call the return value of sp_tx_edid_read()
> > is ignored, which could cause potentia
in hw
catalog")
Signed-off-by: Robert Foss
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
index 2e482cdd7b3c5..420d78cfce8af 10
Hey Lyude,
Thanks for the patch,
On Fri, 19 Feb 2021 at 22:59, Lyude Paul wrote:
>
> Since we're about to move drm_dp_helper.c over to drm_dbg_*(), we'll want
> to make sure that we can also add ratelimited versions of these macros in
> order to retain some of the previous debugging output behav
Hey Lyude,
Thanks for the patch.
On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote:
>
> Since this is one of the few functions in drm_dp_mst_topology.c that
> doesn't have any way of getting access to a drm_device, let's pass the
> drm_dp_mst_topology_mgr down to this function so that it can use
>
Hey Lyude,
Thanks for the patch.
On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote:
>
> Now that we've added a back-pointer to drm_device to drm_dp_aux, made
> drm_dp_aux available to any functions in drm_dp_helper.c which need to
> print to the kernel log, and ensured all of our logging uses a con
Hey Lyude,
Thanks for the patch
On Fri, 19 Feb 2021 at 23:03, Lyude Paul wrote:
>
> And finally, convert all of the code in drm_dp_mst_topology.c over to using
> drm_err() and drm_dbg*(). Note that this refactor would have been a lot
> more complicated to have tried writing a coccinelle script f
Hey Lyude,
This patch looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote:
>
> Since this is a bridge, we don't start out with a respective DRM device.
> Likewise this means we don't have a connector, which also means that we
&g
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote:
>
> Surprisingly, this bridge actually registers it's AUX adapter at the
> correct time already. Nice job! However, it does forget to actually
> u
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote:
>
> Since encoder mappings for connectors are exposed to userspace, we should
> be attaching the encoder before exposing the connector to userspace. Just a
&
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:56, Lyude Paul wrote:
>
> Just another issue I noticed while correcting usages of
> drm_dp_aux_init()/drm_dp_aux_register() around the tree. If any of the
> steps in anx78xx_b
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote:
>
> Another driver I found that seems to forget to unregister it's DP AUX
> device. Let's fix this by adding anx6345_bridge_detach().
>
>
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote:
>
> Another case of linking an encoder to a connector after the connector's
> been registered. The proper place to do this is before connector
>
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote:
>
> Another drive-by fix I found when fixing DP AUX adapter across the kernel
> tree - make sure we don't leak resources (and by proxy-AUX adapters) on
Hey Lyude,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Feb 2021 at 22:58, Lyude Paul wrote:
>
> Just another drive-by fix I noticed while going through the tree to cleanup
> DP aux adapter registration - make sure we unregister the DP A
Hey Sia,
Thanks for the patch, it looks good to me.
Reviewed-by: Robert Foss
On Fri, 12 Mar 2021 at 10:09, Sia Jee Heng wrote:
>
> Support IEC958 encoded PCM format for ADV7511 so that ADV7511 HDMI
> audio driver can accept the IEC958 data from the I2S input.
>
> Signed-off-b
Hey Xin,
This patch looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Mar 2021 at 07:33, Xin Ji wrote:
>
> At some time, the original code may return non zero value, force return 0
> if operation finished.
>
> Signed-off-by: Xin Ji
> ---
> drivers/gpu/drm/bridge/a
Hey Adrien,
Sorry about the slow reply, but I just received the documentation from
the vendor. So let's dig in to the HPD issue.
> +static enum drm_connector_status lt8912_check_cable_status(struct lt8912 *lt)
> +{
> + int ret;
> + unsigned int reg_val;
> +
> + ret = regmap_read
On Tue, 23 Mar 2021 at 11:01, Adrien Grassein wrote:
>
> Hey Robert,
>
> Thanks for the update.
>
> Le mar. 23 mars 2021 à 10:10, Robert Foss a écrit :
> >
> > Hey Adrien,
> >
> > Sorry about the slow reply, but I just received the documentation from
> > > >
> > > > > +static enum drm_connector_status lt8912_check_cable_status(struct
> > > > > lt8912 *lt)
> > > > > +{
> > > > > + int ret;
> > > > > + unsigned int reg_val;
> > > > > +
> > > > > + ret = regmap_read(lt->regmap[I2C_MAIN], 0xC1, ®_val);
> > > > > + if (ret)
> > Are you saying that pin 63 never is high, or that an irq/isr routine
> > isn't getting executed?
> >
> > > When reading the value of the HPD pin, I always get 1 (and no
> > > transition occurs when plugging / unplugging a cable).
> > > The HPD IRQ is done on the HDMI connector driver [5].
> > >
Alright, I think the best way forward is to remove the polled HPD support.
Don't forget to update flags and function pointers.
With that, feel free to add my r-b.
Reviewed-by: Robert Foss
___
dri-devel mailing list
dri-devel@lists.freedeskto
-off-by: Robert Foss
Acked-by: Neil Armstrong
Acked-by: Maxime Ripard
Acked-by: Laurent Pinchart
Acked-by: Andrzej Hajda
---
Add maintainer Acks.
Submitted to follow proper dim workflow.
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
Pushed to drm-misc-next
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=fffa69aa6b1c89853cd00dea969e4754633596d7
On Sun, 7 Feb 2021 at 10:12, Jiapeng Chong
wrote:
>
> Fix the following coccicheck warning:
>
> drivers/gpu/drm/bridge/lontium-lt9611uxc.c:858:8-16: WARNING: use
> scnprintf or s
al input and
> produces RGB565, RGB666, RGB888 output format.
>
> Add dt-bingings for it.
>
> Signed-off-by: Jagan Teki
> Reviewed-by: Robert Foss
> Reviewed-by: Rob Herring
> ---
> Changes for v5:
> - rebase drm-misc-next
> - collect Rob, Robert review tags
Pushed:
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=3aa6031deefa9a2c056af2182af02d3dc5df1067
On Fri, 26 Mar 2021 at 13:20, Adrien Grassein wrote:
>
> Hi,
> this patch set adds the support of the Lontium lt8912 MIPI to HDMI
> bridge in the kernel.
>
> It's only support the video part, no
Hey Liu,
checkpatch --strict had some complaints, with those fixed feel free to
add my r-b.
Reviewed-by: Robert Foss
On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote:
>
> This patch adds a drm bridge driver for i.MX8qxp pixel link to display
> pixel interface(PXL2DPI). The PXL2DPI inter
Hey Liu,
checkpatch --strict is listing some nits for this patch, with those
fixed feel free to add my r-b.
Reviewed-by: Robert Foss
On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote:
>
> This patch adds a helper to support LDB drm bridge drivers for
> i.MX SoCs. Helper functions sup
Hey Liu,
Reviewed-by: Robert Foss
On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote:
>
> Add myself as the maintainer of DRM bridge drivers for i.MX SoCs.
>
> Signed-off-by: Liu Ying
> ---
> v5->v6:
> * No change.
>
> v4->v5:
> * No change.
>
> v3->
Hey Liu,
checkpatch --strict lists some nit and a warning. With those fixed
feel free to add my r-b.
On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote:
>
> This patch adds a drm bridge driver for i.MX8qxp LVDS display bridge(LDB)
> which is officially named as pixel mapper. The LDB has two channels.
Hey Liu,
checkpatch --strict lists some nits and a warning. I think the kconfig
warning can be ignored. With the rest fixed, feel free to add my r-b.
Reviewed-by: Robert Foss
On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote:
>
> This patch adds a drm bridge driver for i.MX8qxp LVDS display
Hey Liu,
checkpatch --strict lists some nits for this patch with those and the
below warning fixed, feel free to add my r-b.
On Wed, 17 Mar 2021 at 04:57, Liu Ying wrote:
>
> This patch adds a drm bridge driver for i.MX8qm LVDS display bridge(LDB)
> which is officially named as pixel mapper. Th
Hey Lyude,
I'm seeing no issues with this patch and the reasoning behind the
patch is sound to me.
Reviewed-by: Robert Foss
On Fri, 26 Mar 2021 at 21:39, Lyude Paul wrote:
>
> Since we're about to move drm_dp_helper.c over to drm_dbg_*(), we'll want
> to make s
Hey Lyude,
Looks good to me.
Reviewed-by: Robert Foss
On Fri, 26 Mar 2021 at 21:40, Lyude Paul wrote:
>
> Now that we've added a back-pointer to drm_device to drm_dp_aux, made
> drm_dp_aux available to any functions in drm_dp_helper.c which need to
> print to the kernel log
Hey Lyude,
This patch looks good to me.
Reviewed-by: Robert Foss
On Fri, 26 Mar 2021 at 21:40, Lyude Paul wrote:
>
> Checkpatch was complaining about this - there's no need for us to print
> errors when kzalloc() fails, as kzalloc() will already WARN for us. So,
> let&
Hey Lyude,
This patch looks good, but I have one question below. With it
addressed, feel free to add my r-b.
Reviewed-by: Robert Foss
>
> -static bool drm_dp_sideband_parse_req(struct drm_dp_sideband_msg_rx *raw,
> +static bool drm_dp_sideband_parse_req(const struct drm_dp_mst_top
Hey Dafna,
Thanks for submitting a cleanup patch, it is much appreciated. It
looks good to me, feel free to add my r-b.
I'm not going to merge this right away, but will let this patch soak
for a while to let other people have a look at it.
On Tue, 30 Mar 2021 at 13:52, Dafna Hirschfeld
wrote:
>
On Wed, 31 Mar 2021 at 08:41, Liu Ying wrote:
>
> Hi Robert,
>
> On Tue, 2021-03-30 at 12:05 +0200, Robert Foss wrote:
> > Hey Liu,
> >
> > checkpatch --strict lists some nits for this patch with those and the
> > below warning fixed, feel free to add my r-b.
Hsin-Yi Wang
> Reviewed-by: Rob Herring
> Reviewed-by: Robert Foss
> ---
> v3->v4: rebase to drm-misc/for-linux-next
> ---
> .../bindings/display/bridge/analogix,anx7625.yaml | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git
> a/Documentation/device
Hey Xin,
This series no longer applies to drm-misc/drm-misc-next, please rebase it.
On Wed, 24 Mar 2021 at 08:52, Xin Ji wrote:
>
> On Sun, Mar 21, 2021 at 02:00:38PM +0200, Laurent Pinchart wrote:
> > Hi Xin,
> >
> > Thank you for the patch.
> >
> > On Fri, Mar 19, 2021 at 02:32:39PM +0800, Xin
Hey Xin,
This patch looks good to me, feel free to add my r-b.
Reviewed-by: Robert Foss
On Fri, 19 Mar 2021 at 07:34, Xin Ji wrote:
>
> Add MIPI rx DPI input support.
>
> Reported-by: kernel test robot
> Signed-off-by: Xin Ji
> ---
> drivers/gpu/drm/bridge/ana
Hey Xin,
This patch looks good to me.
Reviewed-by: Robert Foss
On Fri, 19 Mar 2021 at 07:35, Xin Ji wrote:
>
> Add audio HDMI codec function support, enable it through device true flag
> "analogix,audio-enable".
>
> Reported-by: kernel test robot
> Signed-off-by:
Hey Julian,
Nice catch, this patch looks good to me. I've pushed it to drm-misc-next.
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=62066d3164467167fc27b2383f67d097e39bf176
On Mon, 22 Feb 2021 at 22:56, Julian Braha wrote:
>
> When DRM_TOSHIBA_TC358762 is enabled and DRM_KMS_HELPER is di
ned-off-by: Robert Foss
Reported-by: kernel test robot
---
LKP reported issue:
https://lore.kernel.org/lkml/202104040604.sste2cxf-...@intel.com/
drivers/gpu/drm/bridge/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/brid
Reviewed-by: Robert Foss
On Tue, 30 Mar 2021 at 14:28, Robert Foss wrote:
>
> Hey Dafna,
>
> Thanks for submitting a cleanup patch, it is much appreciated. It
> looks good to me, feel free to add my r-b.
>
> I'm not going to merge this right away, but will let this p
Hey Zhang
On Tue, 6 Apr 2021 at 11:07, Zhang Jianhua wrote:
>
> If CONFIG_DRM_LONTIUM_LT8912B=y, the following errors will be seen while
> compiling lontium-lt8912b.c
>
> drivers/gpu/drm/bridge/lontium-lt8912b.c: In function
> ‘lt8912_hard_power_on’:
> drivers/gpu/drm/bridge/lontium-lt8912b.c:252
Hi,
+Sam Ravnborg
I think this patch is ready to get pulled into the drm-misc tree.
On Thu, 17 Dec 2020 at 15:09, Robert Foss wrote:
>
> 4k requires two dsi pipes, so don't report MODE_OK when only a
> single pipe is configured. But rather report MODE_PANEL to
> signal that re
Hey Xin,
On Thu, 28 Jan 2021 at 04:10, Xin Ji wrote:
>
> Add 'bus-type' and 'data-lanes' define for port0, add HDCP support
> flag and DP tx lane0 and lane1 swing register array define.
>
> Signed-off-by: Xin Ji
> ---
> .../bindings/display/bridge/analogix,anx7625.yaml | 54
>
Hey Bernard,
Thanks for the patch.
With the below fixed, feel free to add my r-b.
Reviewed-by: Robert Foss
On Tue, 2 Feb 2021 at 13:09, Bernard Zhao wrote:
>
> Line 1590 DRM_ERROR is redundant because devm_kzalloc() already
> prints an error.
The line number will not be so he
Hi Xin,
Thanks for the patch.
On Thu, 28 Jan 2021 at 12:17, Xin Ji wrote:
>
> Enable DSI EOTP feature for fixing some panel screen constance
> shift issue.
> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP.
I don't think I quite understand how removing the
MIPI_DSI_MODE_EOT_PACKE
Hi Xin,
On Thu, 28 Jan 2021 at 04:12, Xin Ji wrote:
>
> At some time, the original code may return non zero value, force return 0
> if operation finished
Missing "." at end of line.
Other than that, this patch looks fine. Feel free to add my r-b.
Reviewed-by: Robert Foss
On Thu, 4 Feb 2021 at 23:25, Nicolas Boichat wrote:
>
> On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda wrote:
> >
> >
> > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze:
> > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote:
> > >> Hi Xin,
> &g
Hey Xin,
On Thu, 28 Jan 2021 at 04:12, Xin Ji wrote:
>
> Add MIPI rx DPI input support
>
> Reported-by: kernel test robot
> Signed-off-by: Xin Ji
> ---
> drivers/gpu/drm/bridge/analogix/anx7625.c | 326
> --
> drivers/gpu/drm/bridge/analogix/anx7625.h | 20 +-
> 2
Hey Jiapeng,
Thanks for the patch. Feel free to add my r-b.
Reviewed-by: Robert Foss
On Sun, 7 Feb 2021 at 10:12, Jiapeng Chong
wrote:
>
> Fix the following coccicheck warning:
>
> drivers/gpu/drm/bridge/lontium-lt9611uxc.c:858:8-16: WARNING: use
> scnprintf or sprintf.
>
&g
Hey Nicolas,
Thanks for submitting this, making these flags more intuitive is really nice.
This looks good to me, feel free to add my r-b.
Reviewed-by: Robert Foss
On Thu, 11 Feb 2021 at 04:34, Nicolas Boichat wrote:
>
> Many of the DSI flags have names opposite to their actual effects,
Hey Jagan,
Thanks for submitting this.
checkpatch.pl threw some typ-o warnings, and I listed them below. I
think either spelling is correct, but 'spelling.txt' does list this as
a typ-o explicitly, so I would suggest conforming to that just to
silence the checkpatch warning.
This patch also pass
d my r-b.
Reviewed-by: Robert Foss
On Sun, 14 Feb 2021 at 18:55, Jagan Teki wrote:
>
> ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone.
WARNING: 'Convertor' may be misspelled - perhaps 'Converter'?
#6:
ICN6211 is MIPI-DSI to
Hey Adrien,
Thanks for submitting this!
On Mon, 15 Feb 2021 at 00:31, Adrien Grassein wrote:
>
> Lontium Lt8912 is a DSI to HDMI bridge.
>
> Signed-off-by: Adrien Grassein
> ---
> MAINTAINERS | 1 +
> drivers/gpu/drm/bridge/Kconfig | 14 +
> drivers/gpu/
On Thu, 18 Feb 2021 at 21:36, Adrien Grassein wrote:
>
> Hey Robert,
>
> Thank you for your time and for your review.
>
> Le mer. 17 févr. 2021 à 18:32, Robert Foss a écrit :
> >
> > Hey Adrien,
> >
> > Thanks for submitting this!
> >
> > On
Hey Adrien,
Thanks for the quick update.
On Thu, 18 Feb 2021 at 22:05, Adrien Grassein wrote:
>
> Lontium Lt8912 is a DSI to HDMI bridge.
>
> Signed-off-by: Adrien Grassein
> ---
> MAINTAINERS | 1 +
> drivers/gpu/drm/bridge/Kconfig | 14 +
> drivers/gp
On Fri, 19 Feb 2021 at 16:01, Adrien Grassein wrote:
>
> Hey Robert,
>
> Le ven. 19 févr. 2021 à 14:27, Robert Foss a écrit :
> >
> > Hey Adrien,
> >
> >
> > Thanks for the quick update.
> No problem, I have some free time at the moment.
> >
1 - 100 of 916 matches
Mail list logo
