[PATCH] drm/msm: Don't use autosuspend for display

2021-12-15 Thread Rob Clark
From: Rob Clark No functional change, as we only actually enable autosuspend for the GPU device. But lets not encourage thinking that autosuspend is a good idea for anything display related. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/dsi/dsi_host.c | 8 drivers/gpu/drm/msm

Re: [PATCH] drm/msm: Don't use autosuspend for display

2021-12-15 Thread Rob Clark
On Wed, Dec 15, 2021 at 11:10 AM Stephen Boyd wrote: > > Quoting Rob Clark (2021-12-15 09:59:02) > > From: Rob Clark > > > > No functional change, as we only actually enable autosuspend for the GPU > > device. But lets not encourage thinking that autosuspend i

Re: [PATCH v2 1/3] drm/msm/disp: Tweak display snapshot to match gpu snapshot

2021-12-15 Thread Rob Clark
On Wed, Dec 15, 2021 at 11:17 AM Dmitry Baryshkov wrote: > > On Wed, 15 Dec 2021 at 20:49, Rob Clark wrote: > > > > From: Rob Clark > > > > Add UTS_RELEASE and show timestamp the same way for consistency. > > > > Signed-off-by: Ro

Re: [PATCH] drm/msm: drop dbgname argument from msm_ioremap*()

2021-12-15 Thread Rob Clark
On Wed, Dec 15, 2021 at 8:45 AM Dmitry Baryshkov wrote: > > Hi, > > On 09/12/2021 00:23, Rob Clark wrote: > > On Wed, Dec 8, 2021 at 10:01 AM Dmitry Baryshkov > > wrote: > >> > >> msm_ioremap() functions take additional argument dbgname used to outp

[pull] drm/msm: drm-msm-next-2021-12-26 for 5.17

2021-12-26 Thread Rob Clark
nruo (1): btrfs: fix a out-of-bound access in copy_compressed_data_to_page() Radhakrishna Sripada (2): drm/i915: Update memory bandwidth formulae drm/i915: Fix Memory BW formulae for ADL-P Raed Salem (1): net/mlx5: E-Switch, return error if encap isn't supported Rafael

[PATCH 0/2] drm/msm/gpu: System suspend fixes

2022-01-06 Thread Rob Clark
From: Rob Clark Because system suspend uses pm_runtime_force_suspend() we can't rely runpm refcnt's to protect us if the GPU is active, etc. Fortunately *usually* the GPU is idle when system suspend is triggered. But that isn't quite good enough. The first patch attempts to blo

[PATCH 1/2] drm/msm/gpu: Wait for idle before suspending

2022-01-06 Thread Rob Clark
From: Rob Clark System suspend uses pm_runtime_force_suspend(), which cheekily bypasses the runpm reference counts. This doesn't actually work so well when the GPU is active. So add a reasonable delay waiting for the GPU to become idle. Alternatively we could just return -EBUSY in this

[PATCH 2/2] drm/msm/gpu: Cancel idle/boost work on suspend

2022-01-06 Thread Rob Clark
From: Rob Clark With system suspend using pm_runtime_force_suspend() we can't rely on the pm_runtime_get_if_in_use() trick to deal with devfreq callbacks after (or racing with) suspend. So flush any pending idle or boost work in the suspend path. Signed-off-by: Rob Clark --- drivers/gp

Re: [PATCH 1/2] drm/msm/gpu: Wait for idle before suspending

2022-01-08 Thread Rob Clark
On Fri, Jan 7, 2022 at 4:27 PM Stephen Boyd wrote: > > Quoting Rob Clark (2022-01-06 10:14:46) > > From: Rob Clark > > > > System suspend uses pm_runtime_force_suspend(), which cheekily bypasses > > the runpm reference counts. This doesn't actually work so w

[PATCH v2 0/2] drm/msm/gpu: System suspend fixes

2022-01-08 Thread Rob Clark
From: Rob Clark Because system suspend uses pm_runtime_force_suspend() we can't rely runpm refcnt's to protect us if the GPU is active, etc. Fortunately *usually* the GPU is idle when system suspend is triggered. But that isn't quite good enough. The first patch attempts to blo

[PATCH v2 2/2] drm/msm/gpu: Cancel idle/boost work on suspend

2022-01-08 Thread Rob Clark
From: Rob Clark With system suspend using pm_runtime_force_suspend() we can't rely on the pm_runtime_get_if_in_use() trick to deal with devfreq callbacks after (or racing with) suspend. So flush any pending idle or boost work in the suspend path. v2: s/ret/remaining [sboyd], and swit

[PATCH v2 1/2] drm/msm/gpu: Wait for idle before suspending

2022-01-08 Thread Rob Clark
From: Rob Clark System suspend uses pm_runtime_force_suspend(), which cheekily bypasses the runpm reference counts. This doesn't actually work so well when the GPU is active. So add a reasonable delay waiting for the GPU to become idle. Alternatively we could just return -EBUSY in this

[PATCH v3 0/2] drm/msm/gpu: System suspend fixes

2022-01-08 Thread Rob Clark
From: Rob Clark Because system suspend uses pm_runtime_force_suspend() we can't rely runpm refcnt's to protect us if the GPU is active, etc. Fortunately *usually* the GPU is idle when system suspend is triggered. But that isn't quite good enough. The first patch attempts to blo

[PATCH v3 1/2] drm/msm/gpu: Wait for idle before suspending

2022-01-08 Thread Rob Clark
From: Rob Clark System suspend uses pm_runtime_force_suspend(), which cheekily bypasses the runpm reference counts. This doesn't actually work so well when the GPU is active. So add a reasonable delay waiting for the GPU to become idle. Alternatively we could just return -EBUSY in this

[PATCH v3 2/2] drm/msm/gpu: Cancel idle/boost work on suspend

2022-01-08 Thread Rob Clark
From: Rob Clark With system suspend using pm_runtime_force_suspend() we can't rely on the pm_runtime_get_if_in_use() trick to deal with devfreq callbacks after (or racing with) suspend. So flush any pending idle or boost work in the suspend path. Signed-off-by: Rob Clark --- drivers/gp

Re: [PATCH 1/4] drm/msm/adreno: Add support for Adreno 8c Gen 3

2022-01-11 Thread Rob Clark
On Tue, Jan 11, 2022 at 1:31 PM Akhil P Oommen wrote: > > Add support for "Adreno 8c Gen 3" gpu along with the necessary speedbin > support. > > Signed-off-by: Akhil P Oommen > --- > > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 21 + > drivers/gpu/drm/msm/adreno/adreno_devi

Re: [PATCH 3/4] drm/msm/adreno: Expose speedbin to userspace

2022-01-12 Thread Rob Clark
On Tue, Jan 11, 2022 at 1:31 PM Akhil P Oommen wrote: > > Expose speedbin through MSM_PARAM_CHIP_ID parameter to help userspace > identify the sku. > > Signed-off-by: Akhil P Oommen > --- > > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-)

[PATCH] drm/msm/a6xx: Add missing suspend_count increment

2022-01-13 Thread Rob Clark
From: Rob Clark Reported-by: Danylo Piliaiev Fixes: 3ab1c5cc3939 ("drm/msm: Add param for userspace to query suspend count") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6x

[RFC v2 5/8] drm/fence: add in-fences support

2016-04-28 Thread Rob Clark
On Wed, Apr 27, 2016 at 2:39 AM, Daniel Vetter wrote: > On Tue, Apr 26, 2016 at 01:48:02PM -0700, Greg Hackmann wrote: >> On 04/26/2016 01:05 PM, Daniel Vetter wrote: >> >On Tue, Apr 26, 2016 at 09:55:06PM +0300, Ville Syrjälä wrote: >> >>On Tue, Apr 26, 2016 at 08:23:46PM +0200, Daniel Vetter w

[nexus7-flo] backlight brightness

2016-04-29 Thread Rob Clark
On Fri, Apr 29, 2016 at 1:32 AM, Vinay Simha wrote: > hi, > > In nx7, backlight brightness control is controlled by dcs commands of > MIPI_DCS_SET_DISPLAY_BRIGHTNESS. > there is no PWM going to panel interface directly as we have in ifc6410/nx5 afaiu it is not uncommon to need to control backligh

[RFC v2 5/8] drm/fence: add in-fences support

2016-04-29 Thread Rob Clark
On Fri, Apr 29, 2016 at 3:48 AM, Daniel Stone wrote: > Hi, > > On 28 April 2016 at 23:28, Rob Clark wrote: >> On Wed, Apr 27, 2016 at 2:39 AM, Daniel Vetter wrote: >>> On Tue, Apr 26, 2016 at 01:48:02PM -0700, Greg Hackmann wrote: >>>> A (per-CRTC?) array of

virglrenderer regression in commit ad4f0f1941677c

2016-08-01 Thread Rob Clark
On Mon, Aug 1, 2016 at 1:30 AM, Marc-André Lureau wrote: > > Hi > > - Original Message - >> On Fri, Jul 29, 2016 at 3:57 PM, Rob Herring wrote: >> > Hi, >> > >> > This commit in virglrenderer causes a regression in Android for me. >> > The parameters that get passed in are last_level =

RFC: hardware accelerated bitblt using dma engine

2016-08-02 Thread Rob Clark
On Tue, Aug 2, 2016 at 5:43 PM, Enrico Weigelt, metux IT consult wrote: > On 02.08.2016 16:04, Daniel Vetter wrote: > >> If you mean "add a generic hw-accelerated bitblt operation": This is not >> hw drm works. The generic kms stuff is about display only, with just very >> basic (hence "dumb") buf

[PATCH libdrm] Make sure the second argument to container_of() is initialized

2016-08-03 Thread Rob Clark
On Wed, Aug 3, 2016 at 4:56 AM, Michel Dänzer wrote: > On 03.08.2016 02:49, Nicolai Hähnle wrote: >> On 02.08.2016 12:08, Michel Dänzer wrote: >>> From: Michel Dänzer >>> >>> Fixes warnings and miscompilation resulting in crashes with clang. >> >> How annoying. Seems like this would affect mo

Use of copy_from_user in msm_gem_submit.c while holding a spin_lock

2016-08-17 Thread Rob Clark
On Wed, Aug 17, 2016 at 7:40 AM, Vaishali Thakkar wrote: > Hello, > > I was wondering about the call to copy_from_user in function > submit_lookup_objects for drive > /gpu/drm/msm/msm_gem_submit.c It calls copy_from_user[1] in a spin_lock, > which is not normally > allowed, due to the possibili

Use of copy_from_user in msm_gem_submit.c while holding a spin_lock

2016-08-17 Thread Rob Clark
On Wed, Aug 17, 2016 at 1:08 PM, Al Viro wrote: > On Wed, Aug 17, 2016 at 11:08:46AM -0400, Rob Clark wrote: >> On Wed, Aug 17, 2016 at 7:40 AM, Vaishali Thakkar >> wrote: >> > Hello, >> > >> > I was wondering about the call to copy_from_user in func

Use of copy_from_user in msm_gem_submit.c while holding a spin_lock

2016-08-17 Thread Rob Clark
On Wed, Aug 17, 2016 at 2:49 PM, Rob Clark wrote: > On Wed, Aug 17, 2016 at 1:08 PM, Al Viro wrote: >> On Wed, Aug 17, 2016 at 11:08:46AM -0400, Rob Clark wrote: >>> On Wed, Aug 17, 2016 at 7:40 AM, Vaishali Thakkar >>> wrote: >>> > Hello, >&g

Use of copy_from_user in msm_gem_submit.c while holding a spin_lock

2016-08-17 Thread Rob Clark
On Wed, Aug 17, 2016 at 3:15 PM, Al Viro wrote: > On Wed, Aug 17, 2016 at 02:49:32PM -0400, Rob Clark wrote: > >> I'm not saying that I shouldn't fix it (although not quite sure how >> yet.. taking/dropping the spinlock inside the loop is not a good >> option fro

Use of copy_from_user in msm_gem_submit.c while holding a spin_lock

2016-08-17 Thread Rob Clark
On Wed, Aug 17, 2016 at 3:15 PM, Al Viro wrote: > On Wed, Aug 17, 2016 at 02:49:32PM -0400, Rob Clark wrote: >> If there is a copy_from_user() variant that will return an error >> instead of blocking, I think that is really what I want so I can >> implement a slow-path tha

Use of copy_from_user in msm_gem_submit.c while holding a spin_lock

2016-08-18 Thread Rob Clark
On Thu, Aug 18, 2016 at 4:36 AM, Daniel Vetter wrote: > On Wed, Aug 17, 2016 at 05:29:31PM -0400, Rob Clark wrote: >> diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c >> index 6cd4af4..4502e4b 100644 >> --- a/drivers/gpu/drm/msm/msm_gem.c >>

Use of copy_from_user in msm_gem_submit.c while holding a spin_lock

2016-08-18 Thread Rob Clark
On Thu, Aug 18, 2016 at 9:08 AM, Daniel Vetter wrote: > On Thu, Aug 18, 2016 at 06:55:12AM -0400, Rob Clark wrote: >> On Thu, Aug 18, 2016 at 4:36 AM, Daniel Vetter wrote: >> > On Wed, Aug 17, 2016 at 05:29:31PM -0400, Rob Clark wrote: >> >> diff --git a/drivers/g

XDC 2016 : Call for paper

2016-08-19 Thread Rob Clark
On Thu, May 12, 2016 at 6:56 PM, Martin Peres wrote: > Hello, > > I have the pleasure to announce that the X.org Developer Conference 2016 > will be held in Helsinki from September 21 to September 23. The venue is > located at Haaga-Helia university[0], next to the Pasila station. > > The official

XDC 2016 : Call for paper

2016-08-19 Thread Rob Clark
On Thu, May 12, 2016 at 6:56 PM, Martin Peres wrote: > Hello, > > I have the pleasure to announce that the X.org Developer Conference 2016 > will be held in Helsinki from September 21 to September 23. The venue is > located at Haaga-Helia university[0], next to the Pasila station. > > The official

[PATCH] reservation: fix small comment typo

2016-08-19 Thread Rob Clark
Signed-off-by: Rob Clark --- drivers/dma-buf/reservation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/reservation.c b/drivers/dma-buf/reservation.c index b528edb..1461b51 100644 --- a/drivers/dma-buf/reservation.c +++ b/drivers/dma-buf/reservation.c

[PATCH 0/6] mesa: support for EGL_ANDROID_native_fence_sync

2016-08-19 Thread Rob Clark
yone else working on their drivers all the bits they need to get started on fence-fd support. BR, -R On Fri, Apr 1, 2016 at 4:29 PM, Rob Clark wrote: > From: Rob Clark > > This patchset implements support for EGL_ANDROID_native_fence_sync[1] > for egl and gallium. This extension

[PATCH 0/6] mesa: support for EGL_ANDROID_native_fence_sync

2016-08-19 Thread Rob Clark
On Fri, Aug 19, 2016 at 5:57 PM, Rob Clark wrote: > Ok, quick update on state of explicit fence fd's / > EGL_ANDROID_native_fence_sync: > > For folks working on other drivers wishing to add support, we don't > have a "real" userspace yet. But Gustavo has ad

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-19 Thread Rob Clark
On Fri, Aug 19, 2016 at 6:54 PM, Emil Velikov wrote: > On 19 August 2016 at 15:26, Christian König > wrote: >> Am 19.08.2016 um 15:50 schrieb Marek Olšák: >>> >>> From: Marek Olšák >>> >>> This reverts commit 2ce9dde0d47f2f94ab25c73a30596a7328bcdf1f. >>> >>> See the comment in the code. B

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-19 Thread Rob Clark
On Fri, Aug 19, 2016 at 9:23 PM, Ken Phillis Jr wrote: > On Fri, Aug 19, 2016 at 6:32 PM, Rob Clark wrote: >> >> tbh, I'm all in favor of making it easier to sync kernel headers to >> libdrm, etc. >> >> But kernel *does* have stdint types. Just (for som

[PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from "

2016-08-20 Thread Rob Clark
On Sat, Aug 20, 2016 at 1:58 PM, Mikko Rapeli wrote: > Cc'ing lkml too. > > On Fri, Aug 19, 2016 at 11:54:21PM +0100, Emil Velikov wrote: >> Story time: >> I was dreaming of a day were we can stop installing these headers, >> thus making deprecation a bit easier process. >> Yet after failing to co

[PATCH] drm/doc: Document uapi requirements in DRM

2016-08-19 Thread Rob Clark
Yeh > Cc: Lucas Stach > Cc: Benjamin Gaignard > Cc: Mark Yao > Cc: Laurent Pinchart > Cc: Ben Skeggs > Cc: Rob Clark > Cc: CK Hu > Cc: Xinliang Liu > Cc: Philipp Zabel > Cc: Stefan Agner > Cc: Inki Dae > Cc: Maxime Ripard > Cc: Boris Brezillon

[RFC] Using C99 stdint vs kernel __uX types in kernel drmUAPI (was Re: [PATCH 1/2] Revert "include/uapi/drm/amdgpu_drm.h: use __u32 and __u64 from ")

2016-08-22 Thread Rob Clark
On Mon, Aug 22, 2016 at 4:48 AM, Emil Velikov wrote: > On 20 August 2016 at 23:31, Rob Clark wrote: >> On Sat, Aug 20, 2016 at 1:58 PM, Mikko Rapeli wrote: >>> Cc'ing lkml too. >>> >>> On Fri, Aug 19, 2016 at 11:54:21PM +0100, Emil Velikov wrote: >

[RFC 0/2] New feature: Framebuffer processors

2016-08-22 Thread Rob Clark
On Mon, Aug 22, 2016 at 5:59 AM, Christian König wrote: > Am 22.08.2016 um 11:44 schrieb Marek Szyprowski: >> >> Dear all, >> >> This is the initial proposal for extending DRM API with generic support >> for >> hardware modules, which can be used for processing image data from the one >> memory b

[PATCH 1/2] drm/msm: fix use of copy_from_user() while holding spinlock

2016-08-22 Thread Rob Clark
Use instead __copy_from_user_inatomic() and fallback to slow-path where we drop and re-aquire the lock in case of fault. Cc: stable at vger.kernel.org Reported-by: Vaishali Thakkar Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_submit.c | 27 ++- 1 file

[PATCH 2/2] drm/msm: protect against faults from copy_from_user() in submit ioctl

2016-08-22 Thread Rob Clark
el.org Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.h| 6 ++ drivers/gpu/drm/msm/msm_gem.c| 9 + drivers/gpu/drm/msm/msm_gem_submit.c | 3 +++ 3 files changed, 18 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h index a

[PATCH 16/18] drm/etnaviv: handle MMU exception in IRQ handler

2016-08-23 Thread Rob Clark
On Mon, Aug 22, 2016 at 7:01 AM, Lucas Stach wrote: > Bit 30 of the interrupt status signals an MMU exception. Handle this > condition properly and dump some useful registers. > > Signed-off-by: Lucas Stach > --- > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 12 > drivers/gpu/drm/etnav

Re: [RFC][PATCH 0/3] mesa: Initial build fixups for AOSP/master

2019-05-02 Thread Rob Clark
nsuprizingly found mesa/master has a few >> build issues when trying to build w/ freedreno. >> >> So this patch set provides only some very basic build fixes >> that are needed to get mesa/master building w/ AOSP/master >> (minus the build restrictions on external tools)

Re: [RFC][PATCH 0/3] mesa: Initial build fixups for AOSP/master

2019-05-02 Thread Rob Clark
On Thu, May 2, 2019 at 2:57 PM Dan Willemsen wrote: > > On Thu, May 2, 2019 at 1:52 PM John Stultz wrote: > > > > We need solutions for the xgettext and the python-mako usage. > > Android doesn't support translations at this level, so you may be > able to just skip xgettext altogether. > from q

[PATCH] drm/msm/a6xx: No zap shader is not an error

2019-05-08 Thread Rob Clark
From: Rob Clark Depending on platform firmware, a zap shader may not be required to take the GPU out of secure mode on boot, in which case we can just write RBBM_SECVID_TRUST_CNTL directly. Which we *mostly* handled, but missed clearing 'ret' resulting that hw_init() returned an erro

[PATCH 0/5] drm/msm: mdp5+dpu interconnect support

2019-05-08 Thread Rob Clark
From: Rob Clark Most of this is a resend of things that have already been posted to list. I've rebased the DPU patches, which was somewhat conflicty due to other changes and refactoring in the DPU code. Probably wouldn't hurt for someone to look over my rebases of the first two

[PATCH 4/5] drm/msm/dpu: add icc voting in dpu_mdss_init

2019-05-08 Thread Rob Clark
balanced add a minimum vote in dpu_mdss_init() to avoid any unclocked access. This change depends on the following patch which introduces interconnect binding to MDSS driver: https://patchwork.codeaurora.org/patch/708155/ Signed-off-by: Abhinav Kumar Reviewed-by: Sean Paul Signed-off-by: Rob Clark

[PATCH 3/5] dt-bindings: msm/disp: Introduce interconnect bindings for MDSS on SDM845

2019-05-08 Thread Rob Clark
definitions (Rob Herring) Changes in v4: - Use port macros and change port string names (Georgi Djakov) Changes in v5-v7: - None Signed-off-by: Sravanthi Kollukuduru Signed-off-by: Jayant Shekhar Reviewed-by: Rob Herring Signed-off-by: Rob Clark --- Documentation/devicetree

[PATCH 5/5] drm/msm/mdp5: Use the interconnect API

2019-05-08 Thread Rob Clark
From: Georgi Djakov Signed-off-by: Georgi Djakov Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c index 97179bec8902

[PATCH 2/5] drm/msm/dpu: Integrate interconnect API in MDSS

2019-05-08 Thread Rob Clark
Djakov) Changes in v6: - Change to new icc_set API's (Doug Anderson) Changes in v7: - Fixed a typo Signed-off-by: Sravanthi Kollukuduru Signed-off-by: Jayant Shekhar Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 49 ++-- 1 file ch

[PATCH 1/5] drm/msm/dpu: clean up references of DPU custom bus scaling

2019-05-08 Thread Rob Clark
(Sean Paul) Changes in v4-v7: - None Signed-off-by: Sravanthi Kollukuduru Signed-off-by: Jayant Shekhar Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 174 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 4 +- drivers/gpu/drm/msm/disp

Re: [PATCH RFC 4/6] ARM: dts: msm8974: add display support

2019-05-08 Thread Rob Clark
On Wed, May 8, 2019 at 7:16 PM Brian Masney wrote: > > On Mon, May 06, 2019 at 11:39:02PM -0700, Bjorn Andersson wrote: > > On Sun 05 May 06:04 PDT 2019, Brian Masney wrote: > > > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi > > > b/arch/arm/boot/dts/qcom-msm8974.dtsi > > [..] > > > +

Re: [PATCH RFC 4/6] ARM: dts: msm8974: add display support

2019-05-09 Thread Rob Clark
On Thu, May 9, 2019 at 12:12 AM Brian Masney wrote: > > On Wed, May 08, 2019 at 08:00:47PM -0700, Bjorn Andersson wrote: > > On Wed 08 May 19:25 PDT 2019, Rob Clark wrote: > > > > > On Wed, May 8, 2019 at 7:16 PM Brian Masney wrote: > > > > > > > &

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2019-05-10 Thread Rob Clark
On Tue, Dec 4, 2018 at 2:29 PM Rob Herring wrote: > > On Sat, Dec 1, 2018 at 10:54 AM Rob Clark wrote: > > > > This solves a problem we see with drm/msm, caused by getting > > iommu_dma_ops while we attach our own domain and manage it directly at

Re: [PATCH 1/2] drm/msm/dpu: Use provided drm_minor to initialize debugfs

2019-05-24 Thread Rob Clark
On Fri, May 24, 2019 at 1:43 PM Stephen Boyd wrote: > > Quoting Sean Paul (2019-05-24 10:32:18) > > From: Sean Paul > > > > Instead of reaching into dev->primary for debugfs_root, use the minor > > passed into debugfs_init. > > > > This avoids creating the debug directory under /sys/kernel/debug/

Re: [Freedreno] [PATCH v2] drm/msm/dpu: Use provided drm_minor to initialize debugfs

2019-05-28 Thread Rob Clark
Link to v1: > https://patchwork.freedesktop.org/patch/msgid/20190524173231.5040-1-s...@poorly.run > > Cc: Rob Clark > Reported-by: Stephen Boyd > Reviewed-by: Abhinav Kumar > Signed-off-by: Sean Paul nice! Reviewed-by: Rob Clark > --- > drivers/gpu/drm/msm/disp/dp

Re: [PATCH RFC v2 0/6] ARM: qcom: initial Nexus 5 display support

2019-05-28 Thread Rob Clark
On Tue, May 28, 2019 at 6:17 PM Brian Masney wrote: > > On Tue, May 28, 2019 at 03:46:14PM +0200, Linus Walleij wrote: > > On Thu, May 9, 2019 at 4:04 AM Brian Masney wrote: > > > > > Here is a patch series that adds initial display support for the LG > > > Nexus 5 (hammerhead) phone. It's not fu

Re: [PATCH libdrm] headers: Sync with drm-next

2019-04-10 Thread Rob Clark
On Tue, Apr 9, 2019 at 8:27 AM Eric Engestrom wrote: > > On Tuesday, 2019-04-09 12:59:13 +0100, Eric Engestrom wrote: > > On Tuesday, 2019-04-09 11:35:14 +, Ayan Halder wrote: > > > Generated using make headers_install from the drm-next > > > tree - git://anongit.freedesktop.org/drm/drm > > >

[PATCH 0/3] drm/msm: uabi updates for KHR_robustness

2019-04-16 Thread Rob Clark
er-context pagetables yet without some iommu work landing first. But it can otherwise be tested for the fault detection part of things with a small hack. Jordan Crouse (1): drm/msm/gpu: Add submit queue queries Rob Clark (2): drm/msm/gpu: add per-process pagetables param drm/msm: add param t

[PATCH 3/3] drm/msm/gpu: Add submit queue queries

2019-04-16 Thread Rob Clark
of faults to see if it is responsible for any and if so it can invalidate itself. This is also helpful for testing by confirming to the user driver if a particular command stream caused a fault (or not as the case may be). Signed-off-by: Jordan Crouse Signed-off-by: Rob Clark --- drivers/gpu

[PATCH 1/3] drm/msm/gpu: add per-process pagetables param

2019-04-16 Thread Rob Clark
From: Rob Clark For now it always returns '0' (false), but once the iommu work is in place to enable per-process pagetables we can update the value returned. Userspace needs to know this to make an informed decision about exposing KHR_robustness. Signed-off-by: Rob Clark --- drive

[PATCH 2/3] drm/msm: add param to retrieve # of GPU faults (global)

2019-04-16 Thread Rob Clark
From: Rob Clark For KHR_robustness, userspace wants to know two things, the count of GPU faults globally, and the count of faults attributed to a given context. This patch providees the former, and the next patch provides the latter. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno

[pull] drm/msm: msm-next for 5.2

2019-04-21 Thread Rob Clark
() drm/msm: Split submit_lookup_objects() into two loops Luca Weiss (1): drm/msm: Fix NULL pointer dereference Lucas Stach (1): drm/msm: don't allocate pages from the MOVABLE zone Rob Clark (2): drm/msm/gpu: add per-process pagetables param drm/msm: add param to retrieve #

Re: [PATCH] drm/msm: check for equals 0 only

2019-04-25 Thread Rob Clark
On Thu, Apr 25, 2019 at 7:09 AM Nicholas Mc Guire wrote: > > wait_for_completion_timeout() returns 0 on timeout and aleast 1 otherwise > so checking for < makes no sense here. > > Signed-off-by: Nicholas Mc Guire > --- > > Problem located with an experimental coccinelle script > > While this chec

Re: [PATCH 0/3] drm/panfrost: Expose HW counters to userspace

2019-04-30 Thread Rob Clark
On Tue, Apr 30, 2019 at 5:42 AM Boris Brezillon wrote: > > +Rob, Eric, Mark and more > > Hi, > > On Fri, 5 Apr 2019 16:20:45 +0100 > Steven Price wrote: > > > On 04/04/2019 16:20, Boris Brezillon wrote: > > > Hello, > > > > > > This patch adds new ioctls to expose GPU counters to userspace. > > >

[pull] drm/msm: drm-msm-fixes-2018-01-22 for 5.0

2019-01-22 Thread Rob Clark
): drm/msm: Add __printf verification Jordan Crouse (2): drm/msm/gpu: Remove hardcoded interrupt name drm/msm: drop interrupt-names Kristian H. Kristensen (1): drm/msm: Unblock writer if reader closes file Rob Clark (1): drm/msm: honor GPU_READONLY flag .../devicetree

Re: [PATCH 2/2] drm/msm: Use DRM_DEV_INFO_RATELIMITED for shrinker messages

2019-01-23 Thread Rob Clark
On Mon, Jan 21, 2019 at 4:36 AM Jani Nikula wrote: > > On Fri, 18 Jan 2019, "Kristian H. Kristensen" wrote: > > Otherwise we get hard to track down "Purging: 123123 bytes" messages in > > the log. > > > > Signed-off-by: Kristian H. Kristensen > > --- > > drivers/gpu/drm/msm/msm_gem_shrinker.c |

[resend pull] drm/msm: drm-msm-fixes-2019-01-24 for 5.0

2019-01-24 Thread Rob Clark
): drm/msm: Add __printf verification Jordan Crouse (2): drm/msm/gpu: Remove hardcoded interrupt name drm/msm: drop interrupt-names Kristian H. Kristensen (1): drm/msm: Unblock writer if reader closes file Rob Clark (1): drm/msm: honor GPU_READONLY flag .../devicetree

Re: [PATCH] fbdev: make FB_BACKLIGHT a tristate

2018-12-18 Thread Rob Clark
On Fri, Oct 26, 2018 at 10:09 AM Rob Clark wrote: > > BACKLIGHT_CLASS_DEVICE is already tristate, but a dependency > FB_BACKLIGHT prevents it from being built as a module. There > doesn't seem to be any particularly good reason for this, so > switch FB_BACKLIGHT over to tris

Re: [PATCH 2/2] drm/msm/gpu: fix building without debugfs

2019-01-08 Thread Rob Clark
On Tue, Jan 8, 2019 at 9:16 AM Ioana Ciornei wrote: > > > > Subject: [PATCH 2/2] drm/msm/gpu: fix building without debugfs > > > > When debugfs is disabled, but coredump is turned on, the adreno driver > > fails to > > build: > > > > drivers/gpu/drm/msm/adreno/a3xx_gpu.c:460:4: error: 'struct msm

Re: [PATCH v7 0/6] arm64: dts: Add sdm845 GPU/GMU and SMMU

2019-01-09 Thread Rob Clark
On Wed, Jan 9, 2019 at 1:20 PM Doug Anderson wrote: > > Hi Rob, > > On Tue, Dec 18, 2018 at 10:32 AM Jordan Crouse wrote: > > > > Now that more of the sdm845 bindings are headed upstream this a refresh of > > of https://patchwork.freedesktop.org/series/39308/ to add bindings and nodes > > for the

[PATCH] drm/cirrus: fix connector leak at unload

2019-01-11 Thread Rob Clark
This fixes an '*ERROR* connector VGA-2 leaked!' splat at driver unload. Signed-off-by: Rob Clark --- Similar case to the issue that was fixed recently in drm/ast drivers/gpu/drm/cirrus/cirrus_fbdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/cirrus/cirrus_

Re: [PATCH v4 2/3] locking: Implement an algorithm choice for Wound-Wait mutexes

2019-01-16 Thread Rob Clark
So, I guess this is to do w/ the magic of merge commits, but it looks like the hunk changing the crtc_ww_class got lost:  ~/src/linux   master  git show --pretty=short 08295b3b5beec9aac0f7a9db86f0fc3792039da3 drivers/gpu/drm/drm_modeset_lock.c commit 08295b3b5beec9aac0f7a9db86f0fc3792039da3 Au

Re: [PATCH v2 1/2] drm/msm: Fix A6XX support for opp-level

2019-01-16 Thread Rob Clark
s On Wed, Jan 16, 2019 at 1:46 PM Douglas Anderson wrote: > > The bindings for Qualcomm opp levels changed after being Acked but > before landing. Thus the code in the GPU driver that was relying on > the old bindings is now broken. > > Let's change the code to match the new bindings by adjustin

Re: [PATCH v4 2/3] locking: Implement an algorithm choice for Wound-Wait mutexes

2019-01-17 Thread Rob Clark
On Wed, Jan 16, 2019 at 11:49 AM Thomas Hellstrom wrote: > > Hi, > > On Wed, 2019-01-16 at 09:24 -0500, Rob Clark wrote: > > So, I guess this is to do w/ the magic of merge commits, but it looks > > like the hunk changing the crtc_ww_class got lost: > > So what hap

Re: [PATCH v3 1/3] drm/msm/a6xx: Add support for an interconnect path

2019-01-18 Thread Rob Clark
On Fri, Jan 18, 2019 at 1:06 PM Doug Anderson wrote: > > Hi, > > On Thu, Dec 20, 2018 at 9:30 AM Jordan Crouse wrote: > > > > Try to get the interconnect path for the GPU and vote for the maximum > > bandwidth to support all frequencies. This is needed for performance. > > Later we will want to s

Re: [v1] drm/msm: Remove clock and bandwidth votes in mdss pm suspend

2019-02-17 Thread Rob Clark
On Wed, Jan 23, 2019 at 6:12 AM Jayant Shekhar wrote: > > MDSS PM suspend is dependent on runtime suspend for disabling > clocks and removing bandwidth votes. In case of pm_suspend > triggered, dpm_prepare hold a refcount on power usage of device > and hence runtime suspend is never triggered duri

Re: [PATCH v1 2/6] dt-bindings: drm/msm/a6xx: Add GX power-domain for GMU bindings

2019-02-17 Thread Rob Clark
On Sun, Feb 17, 2019 at 4:08 PM Rob Herring wrote: > > On Mon, Feb 4, 2019 at 10:15 AM Jordan Crouse wrote: > > > > The GMU should have two power domains defined: "cx" and "gx". "cx" is the > > actual power domain for the device and "gx" will be attached at runtime > > to manage reference countin

Re: freedreno header uses not installed xf86atomic.h

2019-02-19 Thread Rob Clark
e: > > > > On Fri, 15 Feb 2019 at 15:06, Rob Clark via dri-devel > > > > wrote: > > > > > > > > > > On Fri, Feb 15, 2019 at 8:42 AM Eric Engestrom > > > > > wrote: > > > > > > > > > &

[pull] drm/msm: msm-next for 5.1

2019-02-19 Thread Rob Clark
s dt-bindings: drm/msm/a6xx: Document GMU bindings drm/msm: Truncate the buffer object name if the copy from user failed Kristian H. Kristensen (1): drm/msm: Unblock writer if reader closes file Rob Clark (2): drm/msm: honor GPU_READONLY flag MAINTAINERS: update ent

Re: [RFC PATCH v1 15/15] drm/msm/a5xx: Support per-instance pagetables

2019-03-01 Thread Rob Clark
On Fri, Mar 1, 2019 at 2:39 PM Jordan Crouse wrote: > > Add support for per-instance pagetables for 5XX targets. Create a support > buffer for preemption to hold the SMMU pagetable information for a > preempted ring, enable TTBR1 to support split pagetables and add the > necessary PM4 commands to

Re: [PATCH v3 2/2] drm/lima: driver for ARM Mali4xx GPUs

2019-03-02 Thread Rob Clark
On Fri, Mar 1, 2019 at 9:32 PM Qiang Yu wrote: > > On Thu, Feb 28, 2019 at 5:41 AM Rob Herring wrote: > > > > On Wed, Feb 27, 2019 at 7:42 AM Qiang Yu wrote: > > > diff --git a/drivers/gpu/drm/lima/lima_drv.c > > > b/drivers/gpu/drm/lima/lima_drv.c> > > new file mode 100644 > > > index

Re: [PATCH v2 1/2] a5xx: Define HLSQ_DBG_ECO_CNTL

2019-05-29 Thread Rob Clark
thanks, I've pushed this one to envytools tree BR, -R On Wed, May 29, 2019 at 8:20 AM Jeffrey Hugo wrote: > > --- > rnndb/adreno/a5xx.xml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/rnndb/adreno/a5xx.xml b/rnndb/adreno/a5xx.xml > index ae654eeb..16203512 100644 > --- a/rnndb/adreno

Re: [PATCH v3 3/5] drm/msm: fix fb references in async update

2019-05-31 Thread Rob Clark
page in how things work on kernel/display side after spending most of my time in userspace/mesa), but I don't want to hold this up.. Acked-by: Rob Clark > > > > --- > > Hello, > > > > As mentioned in the cover letter, > > But I couldn't test on MSM because

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-02 Thread Rob Clark
On Fri, May 10, 2019 at 7:35 AM Rob Clark wrote: > > On Tue, Dec 4, 2018 at 2:29 PM Rob Herring wrote: > > > > On Sat, Dec 1, 2018 at 10:54 AM Rob Clark wrote: > > > > > > This solves a problem we see with drm/msm, caused by getting > > > iommu_dma_

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-03 Thread Rob Clark
On Mon, Jun 3, 2019 at 12:57 AM Vivek Gautam wrote: > > > > On 6/3/2019 11:50 AM, Tomasz Figa wrote: > > On Mon, Jun 3, 2019 at 4:40 AM Rob Clark wrote: > >> On Fri, May 10, 2019 at 7:35 AM Rob Clark wrote: > >>> On Tue, Dec 4, 2018 at 2:29 PM Rob Herrin

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-03 Thread Rob Clark
On Sun, Jun 2, 2019 at 11:25 PM Tomasz Figa wrote: > > On Mon, Jun 3, 2019 at 4:40 AM Rob Clark wrote: > > > > On Fri, May 10, 2019 at 7:35 AM Rob Clark wrote: > > > > > > On Tue, Dec 4, 2018 at 2:29 PM Rob Herring wrote: > > > > > >

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-03 Thread Rob Clark
On Mon, Jun 3, 2019 at 4:14 AM Robin Murphy wrote: > > On 03/06/2019 11:47, Rob Clark wrote: > > On Sun, Jun 2, 2019 at 11:25 PM Tomasz Figa wrote: > >> > >> On Mon, Jun 3, 2019 at 4:40 AM Rob Clark wrote: > >>> > >>> So, another case I'

Re: [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-03 Thread Rob Clark
On Mon, Jun 3, 2019 at 6:54 AM Thierry Reding wrote: > > On Mon, Jun 03, 2019 at 06:20:57AM -0700, Rob Clark wrote: > > On Mon, Jun 3, 2019 at 4:14 AM Robin Murphy wrote: > > > > > > On 03/06/2019 11:47, Rob Clark wrote: > > > > On Sun,

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-05 Thread Rob Clark
On Tue, Jun 4, 2019 at 11:58 PM Tomasz Figa wrote: > > But first of all, I remember Marek already submitted some patches long > ago that extended struct driver with some flag that means that the > driver doesn't want the IOMMU to be attached before probe. Why > wouldn't that work? Sounds like a pe

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-05 Thread Rob Clark
On Wed, Jun 5, 2019 at 6:18 AM Marek Szyprowski wrote: > > Hi Rob, > > On 2019-06-05 14:57, Rob Clark wrote: > > On Tue, Jun 4, 2019 at 11:58 PM Tomasz Figa wrote: > >> But first of all, I remember Marek already submitted some patches long > >> ago that extend

Re: Cleanup of -Wunused-const-variable in drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c

2019-06-13 Thread Rob Clark
so, for dpu_format_map_tile, I'd like to define a fourcc modifier for tiled formats (we currently have a workaround in userspace w/ a private modifier in the gallium driver).. I think the problem is defining the layout of the tiled format(s) (there are at least two per generation and I can't guaran

Re: [PATCH 5/6] soc: qcom: add OCMEM driver

2019-06-17 Thread Rob Clark
On Mon, Jun 17, 2019 at 7:02 PM Brian Masney wrote: > > Hi Rob Clark, > > On Sun, Jun 16, 2019 at 10:41:06AM -0700, Bjorn Andersson wrote: > > > diff --git a/drivers/soc/qcom/ocmem.xml.h b/drivers/soc/qcom/ocmem.xml.h > > > > I would prefer that these lived at t

[PATCH 0/5] drm/msm: mdp5+dpu interconnect support

2019-06-18 Thread Rob Clark
From: Rob Clark Most of this is a resend of things that have already been posted to list. I've rebased the DPU patches, which was somewhat conflicty due to other changes and refactoring in the DPU code. Abhinav Kumar (1): drm/msm/dpu: add icc voting in dpu_mdss_init Georgi Djakov (1):

[PATCH 3/5] dt-bindings: msm/disp: Introduce interconnect bindings for MDSS on SDM845

2019-06-18 Thread Rob Clark
definitions (Rob Herring) Changes in v4: - Use port macros and change port string names (Georgi Djakov) Changes in v5-v7: - None Signed-off-by: Sravanthi Kollukuduru Signed-off-by: Jayant Shekhar Reviewed-by: Rob Herring Signed-off-by: Rob Clark --- Documentation/devicetree

[PATCH 2/5] drm/msm/dpu: Integrate interconnect API in MDSS

2019-06-18 Thread Rob Clark
bably best for clarity to keep num_paths=0 in this case. Signed-off-by: Sravanthi Kollukuduru Signed-off-by: Jayant Shekhar Signed-off-by: Rob Clark Acked-by: Georgi Djakov --- drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 49 ++-- 1 file changed, 45 insertions(+), 4

[PATCH 4/5] drm/msm/dpu: add icc voting in dpu_mdss_init

2019-06-18 Thread Rob Clark
balanced add a minimum vote in dpu_mdss_init() to avoid any unclocked access. This change depends on the following patch which introduces interconnect binding to MDSS driver: https://patchwork.codeaurora.org/patch/708155/ Signed-off-by: Abhinav Kumar Reviewed-by: Sean Paul Signed-off-by: Rob Clark

<    2   3   4   5   6   7   8   9   10   11   >