Re: [PATCH] drm/stm: ltdc: improve pm_runtime to stop clocks

2021-08-17 Thread Raphael Gallais-Pou
On 7/2/21 8:07 PM, Marek Vasut wrote: > On 7/2/21 11:23 AM, Raphael Gallais-Pou wrote: >> Hello Marek, > > Hi, > >> Sorry for the late answer. > > No worries, take your time > >> On 6/30/21 2:35 AM, Marek Vasut wrote: >>> On 6

Re: [PATCH] drm/stm: ltdc: improve pm_runtime to stop clocks

2021-07-02 Thread Raphael Gallais-Pou
Hello Marek, Sorry for the late answer. On 6/30/21 2:35 AM, Marek Vasut wrote: On 6/29/21 1:58 PM, Raphael GALLAIS-POU - foss wrote: [...] +++ b/drivers/gpu/drm/stm/ltdc.c @@ -425,10 +425,17 @@ static void ltdc_crtc_atomic_enable(struct drm_crtc *crtc,   {   struct ltdc_device *ldev

Re: [PATCH 0/2] Add "BACKGROUND_COLOR" drm property

2021-07-09 Thread Raphael Gallais-Pou
On 7/7/21 1:42 PM, Daniel Vetter wrote: On Wed, Jul 07, 2021 at 09:03:03AM +, Simon Ser wrote: Hi, Thanks for working on this. Do you have plans for user-space implementations and IGT? Note that these parts are mandatory, and there's a patch floating around further clarifying what's all

Re: [PATCH 1/2] drm: add crtc background color property

2021-07-09 Thread Raphael Gallais-Pou
On 7/9/21 10:04 AM, Pekka Paalanen wrote: On Wed, 7 Jul 2021 08:48:47 + Raphael GALLAIS-POU - foss wrote: Some display controllers can be programmed to present non-black colors for pixels not covered by any plane (or pixels covered by the transparent regions of higher planes

Re: [PATCH 0/2] Add "BACKGROUND_COLOR" drm property

2021-07-12 Thread Raphael Gallais-Pou
On 7/9/21 11:23 AM, Simon Ser wrote: > On Friday, July 9th, 2021 at 11:09, Raphael Gallais-Pou > wrote: > >> We don't usually test with piglit and igt-gpu-tools. Instead, modetest >> utility of the libdrm is used quite often (as is it the case in order to >> tes

Re: [PATCH] stm: ltdc: fix two incorrect NULL checks on list iterator

2022-03-28 Thread Raphael Gallais-Pou
er > to point to the found element. > > Cc: sta...@vger.kernel.org > Fixes: 99e360442f223 ("drm/stm: Fix bus_flags handling") > Signed-off-by: Xiaomeng Tong > --- > drivers/gpu/drm/stm/ltdc.c | 16 ++------ > 1 file changed, 10 insertions(+), 6 deletions(-) Thanks for your fix Acked-by: Raphael Gallais-Pou Raphaël Gallais-Pou

[PATCH] drm/stm: ltdc: add layer alpha support

2021-09-07 Thread Raphael Gallais-Pou
Android Hardware Composer supports alpha values applied to layers. Enabling non-opaque layers for the STM CRTC could help offload GPU resources for screen composition. Signed-off-by: Raphael Gallais-Pou --- drivers/gpu/drm/stm/ltdc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

[PATCH v2] drm/stm: ltdc: attach immutable zpos property to planes

2021-09-07 Thread Raphael Gallais-Pou
layer. This patch helps to remove a warning message from the Android Hardware Composer. Signed-off-by: Raphael Gallais-Pou Acked-by: Yannick Fertre Reviewed-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/stm/ltdc.c b

[PATCH v2] drm/stm: ltdc: add layer alpha support

2021-09-07 Thread Raphael Gallais-Pou
Android Hardware Composer supports alpha values applied to layers. Enabling non-opaque layers for the STM CRTC could help offload GPU resources for screen composition. Signed-off-by: Raphael Gallais-Pou Acked-by: Yannick Fertre Reviewed-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 4

Re: [PATCH] drm/stm: ltdc: support of new hardware version

2021-12-13 Thread Raphael Gallais-Pou
Hello Yannick, Thank you for this patch. Tested-by: Raphael Gallais-Pou mailto:raphael.gallais-...@foss.st.com>> Reviewed-by: Raphael Gallais-Pou mailto:raphael.gallais-...@foss.st.com>> Regards, Raphaël Gallais-Pou On 12/3/21 9:56 AM, Yannick Fertre wrote: > Add support

Re: [PATCH] drm/stm: ltdc: support of new hardware version

2021-12-13 Thread Raphael Gallais-Pou
Hello Yannick, Thank you for this patch. Tested-by: Raphael Gallais-Pou mailto:raphael.gallais-...@foss.st.com>> Reviewed-by: Raphael Gallais-Pou mailto:raphael.gallais-...@foss.st.com>> Regards, Raphaël Gallais-Pou On 12/3/21 9:56 AM, Yannick Fertre wrote: > Add support

Re: [PATCH 1/5] drm/stm: ltdc: switch to regmap

2022-01-13 Thread Raphael Gallais-Pou
68 insertions(+), 71 deletions(-) Hello Yannick, Reviewed-by: Raphael Gallais-Pou Tested-by: Raphael Gallais-Pou Thanks for the patch, Raphaël

Re: [PATCH 2/5] drm/stm: ltdc: add YCbCr 422 output support

2022-01-13 Thread Raphael Gallais-Pou
+++- > drivers/gpu/drm/stm/ltdc.h | 1 + > 2 files changed, 44 insertions(+), 1 deletion(-) Hello Yannick, Reviewed-by: Raphael Gallais-Pou Thanks, Raphaël

Re: [PATCH 3/5] drm/stm: ltdc: add per plane update support

2022-01-13 Thread Raphael Gallais-Pou
ivers/gpu/drm/stm/ltdc.c | 26 +++--- > drivers/gpu/drm/stm/ltdc.h | 1 + > 2 files changed, 24 insertions(+), 3 deletions(-) Hello Yannick, Reviewed-by: Raphael Gallais-Pou Thank you for this patch, Raphaël

Re: [PATCH 4/5] drm/stm: ltdc: add support of flexible pixel formats

2022-01-13 Thread Raphael Gallais-Pou
> Signed-off-by: Yannick Fertre > --- > drivers/gpu/drm/stm/ltdc.c | 196 ++--- > drivers/gpu/drm/stm/ltdc.h | 5 +- > 2 files changed, 145 insertions(+), 56 deletions(-) Hello Yannick, Reviewed-by: Raphael Gallais-Pou Tested-by: Raphael Gall

Re: [PATCH 2/2] MAINTAINERS: update drm/stm drm/sti and cec/sti maintainers

2022-01-14 Thread Raphael Gallais-Pou
On 1/13/22 6:19 PM, Philippe Cornu wrote: > Add Alain as sti maintainer for both drm/sti & cec/sti. > Add Raphaël as stm maintainer for drm/stm. > > Signed-off-by: Philippe Cornu > --- > MAINTAINERS | 3 +++ > 1 file changed, 3 insertions(+) Hi Philippe, Reviewe

Re: [PATCH] drm/stm: ltdc: remove error message about scaling

2022-06-09 Thread Raphael Gallais-Pou
Hi, Thanks Acked-by: Raphael Gallais-Pou Cheers, Raphaël On 6/3/22 15:42, Yannick Fertre wrote: > Remove error message about scaling & replace it by a debug > message to avoid too much error. > > Signed-off-by: Yannick Fertre > --- > drivers/gpu/drm/stm/ltdc.c | 3 ++

Re: [PATCH] drm/stm: ltdc: fix various coding-style warnings

2022-06-09 Thread Raphael Gallais-Pou
Hi, Thanks Acked-by: Raphael Gallais-Pou Cheers, Raphaël On 6/3/22 15:43, Yannick Fertre wrote: > Fix issues reported by checkpatch.pl: > - Braces {} should be used on all arms > - Blank lines > > Signed-off-by: Yannick Fertre > --- > drivers/gpu/drm/stm/ltdc.

Re: [PATCH] drm/stm: Avoid using val uninitialized in ltdc_set_ycbcr_config()

2022-02-08 Thread Raphael Gallais-Pou
cr pixel formats") > Link: https://github.com/ClangBuiltLinux/linux/issues/1575 > Signed-off-by: Nathan Chancellor > --- > drivers/gpu/drm/stm/ltdc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Raphael Gallais-Pou Thanks, Raphaël

Re: [PATCH 1/2] Revert "drm: of: Properly try all possible cases for bridge/panel detection"

2022-04-22 Thread Raphael Gallais-Pou
Hi On 4/21/22 09:13, Paul Kocialkowski wrote: > Hi, > > On Wed 20 Apr 22, 16:19, Bjorn Andersson wrote: >> On Wed 20 Apr 16:12 PDT 2022, Bjorn Andersson wrote: >> >> Sorry, I missed Jagan and Linus, author and reviewer of the reverted >> patch 2, among the recipients. > I'd be curious to have Jaga

[PATCH] drm: fix typo in comment

2022-04-26 Thread Raphael Gallais-Pou
Fix typo in a doxygen comment (replaced green by blue) in drm_color_mgmt.c Signed-off-by: Raphael Gallais-Pou --- drivers/gpu/drm/drm_color_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c index

Re: [PATCH] drm/stm: dsi: Enable wrapper glue regulator early

2022-05-04 Thread Raphael Gallais-Pou
fy this requirement. The D0 data > lane is in LP-11 mode when the TC358767 bridge chip is brought up and > the chip is not confused anymore. > > Signed-off-by: Marek Vasut > Cc: Alexandre Torgue > Cc: Antonio Borneo > Cc: Philippe Cornu > Cc: Raphael Gallais-Pou > Cc: R

Re: [PATCH] drm/stm: dsi: Enable wrapper glue regulator early

2022-05-10 Thread Raphael Gallais-Pou
On 5/5/22 19:40, Marek Vasut wrote: > On 5/4/22 09:59, Raphael Gallais-Pou wrote: >> Hi Marek, > > Hi, > > [...] > >>> @@ -499,8 +512,16 @@ static int dw_mipi_dsi_stm_probe(struct platform_device >>> *pdev) >>>   } >>>  

[PATCH] drm/stm: ltdc: fix unchecked dereferenced pointer

2022-05-10 Thread Raphael Gallais-Pou
Pointer of struct *drm_crtc was dereferenced before checking it was non NULL. This could potentially create a kernel panic. Fixes: 79b44684a14e ("drm/stm: ltdc: add support for CRC hashing feature") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Raphael G

Re: [PATCH -next] drm/stm: dsi: Use devm_platform_ioremap_resource()

2023-04-25 Thread Raphael Gallais-Pou
_ioremap_resource(pdev, 0); > if (IS_ERR(dsi->base)) { > ret = PTR_ERR(dsi->base); > DRM_ERROR("Unable to get dsi registers %d\n", ret); Thanks for the patch. Acked-by: Raphael Gallais-Pou

[PATCH] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER

2023-07-02 Thread Raphael Gallais-Pou
Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This ultimately causes the module to an early exit at probe time. In addition the MODULE_ALIASes can be dropped. Signed-off-by: Raphael Gallais-Pou --- drivers/staging/fbtft/fb_ili9341.c | 7 +-- 1 file changed, 1

[PATCH RESEND] drm/stm: ltdc: fix late dereference check

2023-05-15 Thread Raphael Gallais-Pou
line 1119) Reported-by: kernel test robot Reported-by: Dan Carpenter Link: https://lore.kernel.org/lkml/202212241802.zelfzcxb-...@intel.com/ Signed-off-by: Raphael Gallais-Pou --- drivers/gpu/drm/stm/ltdc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/st

Re: [PATCH 42/53] drm/stm: Convert to platform remove callback returning void

2023-05-15 Thread Raphael Gallais-Pou
Hi Uwe, On 5/7/23 18:26, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically resul

[PATCH 0/3] STM32 warning cleanup

2023-05-17 Thread Raphael Gallais-Pou
that needed - unnecessary #address-cells and #size-cells properties - residual 'reg' field on single endpoints Raphael Gallais-Pou (3): ARM: dts: stm32: fix warnings on stm32f469-disco board dt-bindings: display: st,stm32-dsi: Remove unnecessary fields ARM: dts: stm32: fix

[PATCH 3/3] ARM: dts: stm32: fix several DT warnings on stm32mp15

2023-05-17 Thread Raphael Gallais-Pou
'panel@0' according to st,stm32-dsi.yaml Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/stm32mp151.dtsi | 5 - arch/arm/boot/dts/stm32mp157.dtsi | 7 --- .../dts/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts| 6 -- ..

[PATCH 2/3] dt-bindings: display: st, stm32-dsi: Remove unnecessary fields

2023-05-17 Thread Raphael Gallais-Pou
warning at build time. Signed-off-by: Raphael Gallais-Pou --- Documentation/devicetree/bindings/display/st,stm32-dsi.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/st,stm32-dsi.yaml b/Documentation/devicetree/bindings/display/st,stm

[PATCH 1/3] ARM: dts: stm32: fix warnings on stm32f469-disco board

2023-05-17 Thread Raphael Gallais-Pou
-disco.dtb: dsi@40016c00: Unevaluated properties are not allowed ('panel-dsi@0' was unexpected) From schema: .../Documentation/devicetree/bindings/display/st,stm32-dsi.yaml Fix those. Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/stm32f469-disco.dts | 4 ++-- 1 file

[PATCH v3 1/3] ARM: dts: stm32: fix warnings on stm32f469-disco board

2023-05-17 Thread Raphael Gallais-Pou
-disco.dtb: dsi@40016c00: Unevaluated properties are not allowed ('panel-dsi@0' was unexpected) From schema: .../Documentation/devicetree/bindings/display/st,stm32-dsi.yaml Fix those. Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/stm32f469-disco.dts | 4 ++-- 1 file

[PATCH v3 3/3] ARM: dts: stm32: fix several DT warnings on stm32mp15

2023-05-17 Thread Raphael Gallais-Pou
x27;panel@0' according to dsi-controller.yaml Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/stm32mp151.dtsi | 5 - arch/arm/boot/dts/stm32mp157.dtsi | 7 --- .../dts/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts| 6 -- ..

[PATCH v3 0/3] STM32 warning cleanup

2023-05-17 Thread Raphael Gallais-Pou
* device-trees. Changes since v2: * Added changelog * Enhanced commit descriptions Changes since v1: * Added DSI subnode name change * Included stm32f469-disco DT in the cleanup * Included YAML fix to prevent regression Raphael Gallais-Pou (3): ARM: dts: st

[PATCH v3 2/3] dt-bindings: display: st, stm32-dsi: Remove unnecessary fields

2023-05-17 Thread Raphael Gallais-Pou
warning at build time. Signed-off-by: Raphael Gallais-Pou --- Documentation/devicetree/bindings/display/st,stm32-dsi.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/st,stm32-dsi.yaml b/Documentation/devicetree/bindings/display/st,stm

Re: [PATCH 0/3] STM32 warning cleanup

2023-05-17 Thread Raphael Gallais-Pou
On 5/17/23 16:06, Marek Vasut wrote: > On 5/17/23 15:22, Raphael Gallais-Pou wrote: >> This serie aims to reduce the number of device-tree warnings of >> following boards : >> >>    - STM32F429-DISCO >>    - STM32MP15* >> >> Those warnings were a

Re: [PATCH v3 3/3] ARM: dts: stm32: fix several DT warnings on stm32mp15

2023-05-17 Thread Raphael Gallais-Pou
Hi Marek On 5/17/23 17:41, Marek Vasut wrote: > On 5/17/23 16:35, Raphael Gallais-Pou wrote: > > Hi, > >> diff --git a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi >> b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi >> index 0f1110e42c93..a6e2e20f12fa 100644 >> --- a/ar

Re: [PATCH v3 3/3] ARM: dts: stm32: fix several DT warnings on stm32mp15

2023-05-25 Thread Raphael Gallais-Pou
On 5/18/23 01:33, Marek Vasut wrote: > On 5/17/23 19:04, Raphael Gallais-Pou wrote: >> Hi Marek > > Hi, > >> On 5/17/23 17:41, Marek Vasut wrote: >>> On 5/17/23 16:35, Raphael Gallais-Pou wrote: >>> >>> Hi, >>> >>>> diff

Re: [PATCH v3 3/3] ARM: dts: stm32: fix several DT warnings on stm32mp15

2023-05-29 Thread Raphael Gallais-Pou
On 5/26/23 18:55, Marek Vasut wrote: > On 5/25/23 10:14, Raphael Gallais-Pou wrote: > > Hi, Hi Marek, > >>> I think if you retain the stm32mp151.dtsi <dc { port { #address-cells = >>> <1>; >>> #size-cells = <0>; }; }; part, then you wouldn&

[PATCH v4 0/4] STM32 warning cleanup

2023-05-29 Thread Raphael Gallais-Pou
g * Enhanced commit descriptions Changes since v1: * Added DSI subnode name change * Included stm32f469-disco DT in the cleanup * Included YAML fix to prevent regression Raphael Gallais-Pou (4): ARM: dts: stm32: fix warnings on stm32f469-disco board dt-bindings: d

[PATCH v4 2/4] dt-bindings: display: st, stm32-dsi: Remove unnecessary fields

2023-05-29 Thread Raphael Gallais-Pou
warning at build time. Signed-off-by: Raphael Gallais-Pou Acked-by: Conor Dooley Reviewed-by: Marek Vasut --- Documentation/devicetree/bindings/display/st,stm32-dsi.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/st,stm32-dsi.yaml b/Doc

[PATCH v4 1/4] ARM: dts: stm32: fix warnings on stm32f469-disco board

2023-05-29 Thread Raphael Gallais-Pou
-disco.dtb: dsi@40016c00: Unevaluated properties are not allowed ('panel-dsi@0' was unexpected) From schema: .../Documentation/devicetree/bindings/display/st,stm32-dsi.yaml Fix those. Signed-off-by: Raphael Gallais-Pou Reviewed-by: Marek Vasut --- arch/arm/boot/dts/stm32f469-dis

[PATCH v4 4/4] ARM: dts: stm32: fix ltdc warnings in stm32mp15 boards

2023-05-29 Thread Raphael Gallais-Pou
Those concern: * "#size-cells" and "#address-cells" wrongly used * residual "reg" property appearing on endpoints where it could be avoided Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/stm32mp151.dtsi | 5 -

[PATCH v4 3/4] ARM: dts: stm32: fix dsi warnings on stm32mp15 boards

2023-05-29 Thread Raphael Gallais-Pou
Fixes DSI related warnings: * "#size-cells" and "#address-cells" wrongly used * Changed 'panel-dsi@0' to 'panel@0' according to dsi-controller.yaml Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/stm32mp157.dtsi | 7

Re: [PATCH v4 2/4] dt-bindings: display: st,stm32-dsi: Remove unnecessary fields

2023-05-30 Thread Raphael Gallais-Pou
On 5/30/23 15:30, Alexandre TORGUE wrote: > On 5/30/23 14:27, Krzysztof Kozlowski wrote: >> On Mon, 29 May 2023 11:13:57 +0200, Raphael Gallais-Pou wrote: >>> "#address-cells" and "#size-cells" are two properties that are not >>> mandatory. For in

Re: [PATCH] drm/stm: ltdc: check memory returned by devm_kzalloc()

2023-05-31 Thread Raphael Gallais-Pou
return NULL; > > for (i = 0; i < ldev->caps.pix_fmt_nb; i++) { > drm_fmt = ldev->caps.pix_fmt_drm[i]; Acked-by: Raphael Gallais-Pou Thanks for your patch. Cheers, Raphaël G.-P.

Re: [PATCH v2 0/6] Add display support on the stm32f746-disco board

2023-06-05 Thread Raphael Gallais-Pou
Hi Dario, Thanks for this serie. I'll look at it shortly. In the meantime, would it be possible to send it again as I think it is not complete. patchwork and lore.kernel.org both prompt incomplete parts of your serie. https://patchwork.freedesktop.org/series/118814/?_sm_au_=iVVrkQQkv5r1r0rQcLp

Re: [RESEND PATCH v2 4/6] dt-bindings: display: simple: add Rocktech RK043FN48H

2023-06-07 Thread Raphael Gallais-Pou
On 6/7/23 08:31, Dario Binacchi wrote: > Add compatible to panel-simple for Rocktech Displays Limited > RK043FN48H 4.3" 480x272 LCD-TFT panel. > > Signed-off-by: Dario Binacchi > Acked-by: Conor Dooley Reviewed-by: Raphael Gallais-Pou Thanks, Raphaël

Re: [PATCH v3 4/4] drm/stm: add an option to change FB bpp

2023-06-13 Thread Raphael Gallais-Pou
On 6/13/23 16:52, Michael Nazzareno Trimarchi wrote: > Hi > > On Tue, Jun 13, 2023 at 4:41 PM Philippe CORNU > wrote: >> >> >> On 6/9/23 08:20, Dario Binacchi wrote: >>> Boards that use the STM32F{4,7} series have limited amounts of RAM. The >>> added parameter allows users to size, within certa

Re: [PATCH 13/18] drm/stm: ltdc: Convert to devm_platform_ioremap_resource()

2023-07-07 Thread Raphael Gallais-Pou
Hi On 7/7/23 09:20, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/gpu/drm/stm/ltdc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Acked-by: Raphaël Gallais-Pou Thanks for your contribution, Raphaël

[PATCH v2] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER

2023-07-18 Thread Raphael Gallais-Pou
Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This ultimately causes a warning when the module probes. Fixes it. Signed-off-by: Raphael Gallais-Pou --- drivers/staging/fbtft/fb_ili9341.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH RESEND v2] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER

2023-07-18 Thread Raphael Gallais-Pou
Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This ultimately causes a warning when the module probes. Fixes it. Changes in v2: - dropped MODULE_ALIAS changes - changed commit log for more accurate description Signed-off-by: Raphael Gallais-Pou

[PATCH v3] staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER

2023-07-18 Thread Raphael Gallais-Pou
Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This ultimately causes a warning when the module probes. Fixes it. Signed-off-by: Raphael Gallais-Pou --- Changes in v3: - added changelog Changes in v2: - dropped MODULE_ALIAS changes - changed commit

Re: [PATCH 40/86] drm/stm: Run DRM default client setup

2024-08-20 Thread Raphael Gallais-Pou
k Fertre > Cc: Raphael Gallais-Pou > Cc: Philippe Cornu > Cc: Maxime Coquelin > Cc: Alexandre Torgue Hi Thomas, Thanks, Acked-by: Raphael Gallais-Pou Regards, Raphaël

Re: [PATCH v2 40/86] drm/stm: Run DRM default client setup

2024-08-22 Thread Raphael Gallais-Pou
fourcc() > > Signed-off-by: Thomas Zimmermann > Cc: Yannick Fertre > Cc: Raphael Gallais-Pou > Cc: Philippe Cornu > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Acked-by: Raphael Gallais-Pou Hi Thomas, Thanks for this work. Again for v2: Acked-by: Raphael Gallais-Pou Regards, Raphaël

Re: dw_mipi_dsi-stm.c:(.text+0x8db9a3): undefined reference to `clk_hw_unregister'

2024-09-09 Thread Raphael Gallais-Pou
On 9/5/24 10:19, Borislav Petkov wrote: > Hi all, > > this fires in my randbuilds here: > > vmlinux.o: warning: objtool: adis16400_write_raw() falls through to next > function adis16400_show_serial_number() > ld: vmlinux.o: in function `dw_mipi_dsi_stm_remove': > dw_mipi_dsi-stm.c:(.text+0x8db9a

Re: STM32 DSI controller driver: mode_valid clock tolerance

2024-03-20 Thread Raphael Gallais-Pou
On 3/8/24 09:35, Sean Nyekjaer wrote: > Hi, Hi Sean, Sorry for not responding earlier. I've also added Antonio Borneo, which is the author of the implementation of the mode_valid() hook. > I’m using a stm32mp157 with a sn65dsi83 DSI2LVDS bridge. > The LVDS display is having a minimum clock

Re: [PATCH] drm/stm: Avoid use-after-free issues with crtc and plane

2023-10-23 Thread Raphael Gallais-Pou
Hello Katya, Thanks for your submission. Please see drivers/gpu/drm/cr On 10/20/23 12:29, Katya Orlova wrote: > ltdc_load() calls functions drm_crtc_init_with_planes() and > drm_universal_plane_init(). These functions should not be called with > parameters allocated with devm_kzalloc() to avoi

Re: [PATCH] drm/stm: Fix an error handling path in stm_drm_platform_probe()

2024-07-09 Thread Raphael Gallais-Pou
On 1/6/24 17:54, Christophe JAILLET wrote: > If drm_dev_register() fails, a call to drv_load() must be undone, as > already done in the remove function. > > Fixes: b759012c5fa7 ("drm/stm: Add STM32 LTDC driver") > Signed-off-by: Christophe JAILLET Hi Christophe, After some delay: applied on d

[PATCH] MAINTAINERS: add myself to DRM/STi maintainers

2024-07-09 Thread Raphael Gallais-Pou
In lights of recent events and my will to participate in the Linux kernel development I see this opportunity to add myself, and help Alain as maintainer for the DRM/STi drivers. Signed-off-by: Raphael Gallais-Pou --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b

Re: [PATCH] drm/stm: ltdc: check memory returned by devm_kzalloc()

2024-07-15 Thread Raphael Gallais-Pou
On 5/31/23 09:28, Claudiu Beznea wrote: > devm_kzalloc() can fail and return NULL pointer. Check its return status. > Identified with Coccinelle (kmerr.cocci script). > > Fixes: 484e72d3146b ("drm/stm: ltdc: add support of ycbcr pixel formats") > Signed-off-by: Claudiu Beznea > --- > > Hi, > > T

Re: [PATCH] drm/stm: ltdc: Remove unused function plane_to_ltdc

2024-07-15 Thread Raphael Gallais-Pou
On 6/24/24 04:41, Jiapeng Chong wrote: > The function are defined in the ltdc.c file, but not called > anywhere, so delete the unused function. > > drivers/gpu/drm/stm/ltdc.c:494:35: warning: unused function 'encoder_to_ltdc'. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn

Re: [PATCH v4] drm/stm: Avoid use-after-free issues with crtc and plane

2024-07-15 Thread Raphael Gallais-Pou
On 2/16/24 13:50, Katya Orlova wrote: > ltdc_load() calls functions drm_crtc_init_with_planes(), > drm_universal_plane_init() and drm_encoder_init(). These functions > should not be called with parameters allocated with devm_kzalloc() > to avoid use-after-free issues [1]. > > Use allocations mana

Re: [PATCH] drm/stm: ltdc: remove reload interrupt

2024-07-19 Thread Raphael Gallais-Pou
On 7/12/24 15:14, Yannick Fertre wrote: > The reload interrupt is not used by the driver. To avoid > unnecessary calls of the interrupt routine, don't enable it. > Solve small typo and add mask to simplify the driver. > > Signed-off-by: Yannick Fertre Hi Yannick, Applied on drm-misc-next. Th

Re: [PATCH] drm/stm: ltdc: add mask for lxcr register

2024-07-19 Thread Raphael Gallais-Pou
On 7/12/24 15:14, Yannick Fertre wrote: > The purpose of this mask is to simplify writing to the lxcr > register and not to forget any fields. > > Signed-off-by: Yannick Fertre Hi Yannick, Applied on drm-misc-next. Thanks, Raphaël

Re: [PATCH] drm/stm: ltdc: reset plane transparency after plane disable

2024-07-19 Thread Raphael Gallais-Pou
On 7/12/24 15:13, Yannick Fertre wrote: > The plane's opacity should be reseted while the plane > is disabled. It prevents from seeing a possible global > or layer background color set earlier. > > Signed-off-by: Yannick Fertre Hi Yannick, Applied on drm-misc-next. Thanks, Raphaël

Re: [PATCH] drm/stm: add COMMON_CLK dependency

2024-07-19 Thread Raphael Gallais-Pou
On 7/19/24 09:54, Arnd Bergmann wrote: > From: Arnd Bergmann > > The added lvds driver and a change in the dsi driver resulted in failed > builds when COMMON_CLK is disabled: > > x86_64-linux-ld: drivers/gpu/drm/stm/dw_mipi_dsi-stm.o: in function > `dw_mipi_dsi_stm_remove': > dw_mipi_dsi-stm.c:

[PATCH 2/3] drm/stm: dsi: expose DSI PHY internal clock

2023-10-30 Thread Raphael Gallais-Pou
phy' is not implemented. Since the DSI kernel clock is based on the internal DSI pll. The common clock driver can not directly expose this 'ck_dsi_phy' clock because it does not contain any common registers with the DSI. Thus it needs to be done directly within the DSI phy driver. Signed-o

[PATCH 3/3] arm: dts: st: fix DSI peripheral clock on stm32mp15 boards

2023-10-30 Thread Raphael Gallais-Pou
In RCC driver, 'DSI_K' is a kernel clock while 'DSI' has pclk4 as parent clock, which means that it is an APB peripheral clock. Swap the clocks in the DSI peripheral clock reference. Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/st/stm32mp157.dtsi | 2 +

[PATCH 0/3] Update STM DSI PHY driver

2023-10-30 Thread Raphael Gallais-Pou
introduced previously. Since 'dsi' and 'dsi_k' are gated by the same bit on the same register, both reference work as peripheral clock in the device-tree. Raphael Gallais-Pou (2): drm/stm: dsi: expose DSI PHY internal clock arm: dts: st: fix DSI peripheral clock on stm32mp15 boa

[PATCH 1/3] drm/stm: dsi: add pm runtime ops

2023-10-30 Thread Raphael Gallais-Pou
From: Yannick Fertre Update control of clocks and supply thanks to the PM runtime mechanism to avoid kernel crash during a system suspend. Signed-off-by: Yannick Fertre Signed-off-by: Raphael Gallais-Pou --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 28 +++ 1 file

Re: [PATCH v2 4/4] dt-bindings: display: simple: hardware can use several properties

2024-02-23 Thread Raphael Gallais-Pou
On 2/23/24 01:09, Rob Herring wrote: > On Sat, Feb 17, 2024 at 12:02:58PM +0100, Raphael Gallais-Pou wrote: >> Setting a panel-timing in the device-tree overwrite the one specified in >> the driver and set it as preferred. In that case 'height-mm', >> &#

[PATCH v3 1/4] ARM: dts: stm32: add LTDC support for STM32MP13x SoC family

2024-02-23 Thread Raphael Gallais-Pou
additional interrupt set * Interrupts based on 7 different events * AXI master interface with long efficient bursts (64 or 128 bytes) Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- arch/arm/boot/dts/st/stm32mp135.dtsi | 11 +++ 1 file changed, 11 insertions

[PATCH v3 0/4] Add display support for stm32mp135f-dk board

2024-02-23 Thread Raphael Gallais-Pou
lore.kernel.org/lkml/17072972.1647630.4818786052103823648.b4...@linaro.org/ https://lore.kernel.org/lkml/170729755662.1647630.425379349649657352.b4...@linaro.org/ - Fixed CHECK_DTBS warnings - Added missing properties in panel-simple.yaml Signed-off-by: Raphael Gallais-Pou --- Raphael Gallai

[PATCH v3 3/4] ARM: dts: stm32: enable display support on stm32mp135f-dk board

2024-02-23 Thread Raphael Gallais-Pou
Link panel and display controller. Enable panel, backlight and display controller. Signed-off-by: Raphael Gallais-Pou --- Changes in v2: - Fixed dtbs_check warnings : arch/arm/boot/dts/st/stm32mp135f-dk.dtb: panel-backlight: 'default-brightness-level' does not match any of t

[PATCH v3 4/4] dt-bindings: display: simple: allow panel-common properties

2024-02-23 Thread Raphael Gallais-Pou
This device inherits properties from panel-common. Those should be allowed to use, instead of specifying properties to true for each specific use. Signed-off-by: Raphael Gallais-Pou --- Changes in v3: - Allow every properties instead of adding each properties to true as Rob suggested

[PATCH v3 2/4] ARM: dts: stm32: add LTDC pinctrl on STM32MP13x SoC family

2024-02-23 Thread Raphael Gallais-Pou
Adds LTDC pinctrl support and assigns dedicated GPIO pins. Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/st/stm32mp13-pinctrl.dtsi | 57 + 1 file changed, 57 insertions(+) diff --git a/arch/arm/boot/dts/st/stm32mp13-pinctrl.dtsi b/arch/arm/boot/dts/st

[PATCH v6 1/3] dt-bindings: display: add STM32 LVDS device

2024-02-26 Thread Raphael Gallais-Pou
Add "st,stm32mp25-lvds" compatible. Signed-off-by: Raphael Gallais-Pou Reviewed-by: Conor Dooley --- Depends on: "dt-bindings: stm32: add clocks and reset binding for stm32mp25 platform" by Gabriel Fernandez Changes in v6: - Added Conor's R

[PATCH v6 0/3] Introduce STM32 LVDS driver

2024-02-26 Thread Raphael Gallais-Pou
ed hard to read debug log - [3/6]: Fixed my address - [3/6]: Fixed smatch warning - [5/6]: Move changes to stm32mp255.dtsi Signed-off-by: Raphael Gallais-Pou --- Raphael Gallais-Pou (3): dt-bindings: display: add STM32 LVDS device drm/stm: lvds: add new STM

[PATCH v6 3/3] drm/stm: ltdc: add lvds pixel clock

2024-02-26 Thread Raphael Gallais-Pou
clock framework, this would allow to use the LVDS. Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- Changes in v2: - Fixed my address - Fixed smatch warning --- drivers/gpu/drm/stm/ltdc.c | 19 +++ drivers/gpu/drm/stm/ltdc.h | 1 + 2 files

[PATCH v6 2/3] drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver

2024-02-26 Thread Raphael Gallais-Pou
input pixel per clock cycle Signed-off-by: Raphael Gallais-Pou --- Changes in v6: - Fixes sparse symbols detected by kernel test robot Changes in v5: - Align compatible Changes in v4: - Explicitly include linux/platform_device.h, dependency introduced by

Re: [PATCH v4] drm/stm: Avoid use-after-free issues with crtc and plane

2024-02-26 Thread Raphael Gallais-Pou
On 2/16/24 13:50, Katya Orlova wrote: > ltdc_load() calls functions drm_crtc_init_with_planes(), > drm_universal_plane_init() and drm_encoder_init(). These functions > should not be called with parameters allocated with devm_kzalloc() > to avoid use-after-free issues [1]. > > Use allocations mana

[PATCH RESEND v3 1/3] drm/stm: dsi: use new SYSTEM_SLEEP_PM_OPS() macro

2024-01-29 Thread Raphael Gallais-Pou
Use RUNTIME_PM_OPS() instead of the old SET_SYSTEM_SLEEP_PM_OPS(). This means we don't need __maybe_unused on the functions. Signed-off-by: Raphael Gallais-Pou --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gp

[PATCH RESEND v3 2/3] drm/stm: dsi: add pm runtime ops

2024-01-29 Thread Raphael Gallais-Pou
From: Yannick Fertre Update control of clocks and supply thanks to the PM runtime mechanism to avoid kernel crash during a system suspend. Signed-off-by: Yannick Fertre Signed-off-by: Raphael Gallais-Pou --- Changes in v2: - Changed SET_RUNTIME_PM_OPS to RUNTIME_PM_OPS and removed

[PATCH RESEND v3 3/3] drm/stm: dsi: expose DSI PHY internal clock

2024-01-29 Thread Raphael Gallais-Pou
phy' is not implemented. Since the DSI kernel clock is based on the internal DSI pll. The common clock driver can not directly expose this 'ck_dsi_phy' clock because it does not contain any common registers with the DSI. Thus it needs to be done directly within the DSI phy driver. Signed-o

[PATCH RESEND v3 0/3] Update STM DSI PHY driver

2024-01-29 Thread Raphael Gallais-Pou
- Changed SET_RUNTIME_PM_OPS to RUNTIME_PM_OPS Raphael Gallais-Pou (3): drm/stm: dsi: use new SYSTEM_SLEEP_PM_OPS() macro drm/stm: dsi: expose DSI PHY internal clock Yannick Fertre (1): drm/stm: dsi: add pm runtime ops drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 279 ++---

[PATCH 1/5] ARM: dts: stm32: add LTDC support for STM32MP13x SoC family

2024-02-05 Thread Raphael Gallais-Pou
additional interrupt set * Interrupts based on 7 different events * AXI master interface with long efficient bursts (64 or 128 bytes) Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- arch/arm/boot/dts/st/stm32mp135.dtsi | 11 +++ 1 file changed, 11 insertions

[PATCH 3/5] ARM: dts: stm32: enable display support on stm32mp135f-dk board

2024-02-05 Thread Raphael Gallais-Pou
Link panel and display controller. Enable panel, backlight and display controller. Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/st/stm32mp135f-dk.dts | 55 + 1 file changed, 55 insertions(+) diff --git a/arch/arm/boot/dts/st/stm32mp135f-dk.dts b

[PATCH 4/5] drm/panel: simple: fix flags on RK043FN48H

2024-02-05 Thread Raphael Gallais-Pou
. Signed-off-by: Raphael Gallais-Pou --- drivers/gpu/drm/panel/panel-simple.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 2214cb09678c..7b286382ffb4 100644 --- a/drivers/gpu/drm/panel/panel

[PATCH 0/5] Add display support for stm32mp135f-dk board

2024-02-05 Thread Raphael Gallais-Pou
panel. [1] commit 1726cee3d053 ("drm/stm: ltdc: support of new hardware version") Signed-off-by: Raphael Gallais-Pou --- Raphael Gallais-Pou (5): ARM: dts: stm32: add LTDC support for STM32MP13x SoC family ARM: dts: stm32: add LTDC pinctrl on STM32MP13x SoC family ARM

[PATCH 2/5] ARM: dts: stm32: add LTDC pinctrl on STM32MP13x SoC family

2024-02-05 Thread Raphael Gallais-Pou
Adds LTDC pinctrl support and assigns dedicated GPIO pins. Signed-off-by: Raphael Gallais-Pou --- arch/arm/boot/dts/st/stm32mp13-pinctrl.dtsi | 57 + 1 file changed, 57 insertions(+) diff --git a/arch/arm/boot/dts/st/stm32mp13-pinctrl.dtsi b/arch/arm/boot/dts/st

[PATCH 5/5] drm/panel: simple: push blanking limit on RK32FN48H

2024-02-05 Thread Raphael Gallais-Pou
Push horizontal front porch and vertical back porch blanking limit. This allows to get a 60 fps sharp. Signed-off-by: Raphael Gallais-Pou --- drivers/gpu/drm/panel/panel-simple.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b

[PATCH v4 3/3] drm/stm: ltdc: add lvds pixel clock

2024-02-06 Thread Raphael Gallais-Pou
clock framework, this would allow to use the LVDS. Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- Changes in v2: - Fixed my address - Fixed smatch warning --- drivers/gpu/drm/stm/ltdc.c | 19 +++ drivers/gpu/drm/stm/ltdc.h | 1 + 2 files

[PATCH v4 0/3] Introduce STM32 LVDS driver

2024-02-06 Thread Raphael Gallais-Pou
- [2/6]: Removed CamelCase macros - [2/6]: Removed hard to read debug log - [3/6]: Fixed my address - [3/6]: Fixed smatch warning - [5/6]: Move changes to stm32mp255.dtsi Signed-off-by: Raphael Gallais-Pou --- Raphael Gallais-Pou (3): dt-bindings: display: add

[PATCH v4 1/3] dt-bindings: display: add STM32 LVDS device

2024-02-06 Thread Raphael Gallais-Pou
Add "st,stm32mp25-lvds" compatible. Signed-off-by: Raphael Gallais-Pou --- Depends on: "dt-bindings: stm32: add clocks and reset binding for stm32mp25 platform" by Gabriel Fernandez Changes in v4: - Align filename to compatible - Fix compa

[PATCH v4 2/3] drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver

2024-02-06 Thread Raphael Gallais-Pou
input pixel per clock cycle Signed-off-by: Raphael Gallais-Pou --- Changes in v4: - Explicitly include linux/platform_device.h, dependency introduced by ef175b29a242 of: Stop circularly including of_device.h and of_platform.h Changes in v3: - s/regroups/is composed of/ in

[PATCH v5 0/3] Introduce STM32 LVDS driver

2024-02-06 Thread Raphael Gallais-Pou
ned-off-by: Raphael Gallais-Pou --- Raphael Gallais-Pou (3): dt-bindings: display: add STM32 LVDS device drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver drm/stm: ltdc: add lvds pixel clock .../bindings/display/st,stm32mp25-lvds.yaml| 119 ++ M

[PATCH v5 3/3] drm/stm: ltdc: add lvds pixel clock

2024-02-06 Thread Raphael Gallais-Pou
clock framework, this would allow to use the LVDS. Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- Changes in v2: - Fixed my address - Fixed smatch warning --- drivers/gpu/drm/stm/ltdc.c | 19 +++ drivers/gpu/drm/stm/ltdc.h | 1 + 2 files

[PATCH v5 1/3] dt-bindings: display: add STM32 LVDS device

2024-02-06 Thread Raphael Gallais-Pou
Add "st,stm32mp25-lvds" compatible. Signed-off-by: Raphael Gallais-Pou --- Depends on: "dt-bindings: stm32: add clocks and reset binding for stm32mp25 platform" by Gabriel Fernandez Changes in v5: - Fixed path in MAINTAINERS Changes in v4:

  1   2   3   >