Re: [Intel-gfx] [PATCH v3 1/3] drm/i915/hdcp: update cp_irq_count_cached in intel_dp_hdcp2_read_msg()

2021-08-10 Thread Ramalingam C
iting for a new > CP_IRQ. LGTM. Reviewed-by: Ramalingam C > > Signed-off-by: Juston Li > Acked-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/g

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/hdcp: read RxInfo once when reading RepeaterAuth_Send_ReceiverID_List

2021-08-10 Thread Ramalingam C
in v2: > - remove unnecessary moving of drm_i915_private from patch 1 Looks good to me Reviewed-by: Ramalingam C > > Signed-off-by: Juston Li > Acked-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 30 ++-- > include/drm/drm_dp_helpe

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/hdcp: reuse rx_info for mst stream type1 capability check

2021-08-10 Thread Ramalingam C
t; that as well. > > Changes since v2: > - Remove no longer used variables in _intel_hdcp2_enable() LGTM. Reviewed-by: Ramalingam C > > Signed-off-by: Juston Li > --- > .../drm/i915/display/intel_display_types.h| 2 + > drivers/gpu/drm/i915/display/intel_dp_hdcp

Re: [PATCH v5 07/17] drm/i915/hdcp: Enable HDCP 1.4 stream encryption

2020-11-24 Thread Ramalingam C
ue less comment. [Uma] > v4: > - Split the Gen12 HDCP enablement patch. [Ram] > - Add connector details in drm_err. > > Cc: Ramalingam C > Reviewed-by: Uma Shankar > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/display/intel_hdcp.c | 45 ---

Re: [PATCH v5 08/17] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-11-24 Thread Ramalingam C
On 2020-11-11 at 11:50:42 +0530, Anshuman Gupta wrote: > Enable HDCP 1.4 over DP MST for Gen12. > > Cc: Ramalingam C > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) >

Re: [PATCH v5 08/17] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-11-24 Thread Ramalingam C
On 2020-11-24 at 20:32:43 +0530, Anshuman Gupta wrote: > On 2020-11-24 at 19:50:17 +0530, Ramalingam C wrote: > > On 2020-11-11 at 11:50:42 +0530, Anshuman Gupta wrote: > > > Enable HDCP 1.4 over DP MST for Gen12. > > > > > > Cc: Ramalingam C

Re: [PATCH v5 13/17] drm/i915/hdcp: MST streams support in hdcp port_data

2020-11-24 Thread Ramalingam C
s. [Uma] > v4: > - 's/port_auth/hdcp_port_auth'. [Ram] > - Commit log improvement. > > Cc: Ramalingam C > Reviewed-by: Uma Shankar > Signed-off-by: Anshuman Gupta > --- > .../drm/i915/display/intel_display_types.h| 4 +- > drivers/gpu/drm/i915/display/in

Re: [PATCH v5 14/17] drm/i915/hdcp: Pass connector to check_2_2_link

2020-11-24 Thread Ramalingam C
> with same dig_port. Reviewed-by: Ramalingam C > > Cc: Ramalingam C > Reviewed-by: Uma Shankar > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++- > drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 3 ++- > dr

Re: [PATCH v6 04/18] drm/i915/hdcp: No HDCP when encoder is't initialized

2020-12-04 Thread Ramalingam C
request on MST connector without encoder initialized(modeset). But userspace are not supposed to request hdcp at such scenario right?. Ram > Don't enable HDCP in such cases to prevent any crash. > > Cc: Ramalingam C > Cc: Juston Li > Signed-off-by: Anshuman Gupta &g

Re: [PATCH v7 04/18] drm/i915/hdcp: No HDCP when encoder is't initialized

2020-12-10 Thread Ramalingam C
ch cases to prevent any crash. LGTM.. Reviewed-by: Ramalingam C > > Cc: Ramalingam C > Cc: Juston Li > Tested-by: Karthik B S > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/display/intel_hdcp.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff -

Re: [PATCH v7 08/18] drm/i915/hdcp: Enable HDCP 1.4 stream encryption

2020-12-10 Thread Ramalingam C
DMESG. [Ram] > - comments improvement. [Ram] > Patch LGTM. Reviewed-by: Ramalingam C > Cc: Ramalingam C > Reviewed-by: Uma Shankar > Tested-by: Karthik B S > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/display/intel_hdcp.c | 38 +++ &g

Re: [PATCH v7 09/18] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-12-10 Thread Ramalingam C
On 2020-12-10 at 11:56:31 +0530, Anshuman Gupta wrote: > Enable HDCP 1.4 over DP MST for Gen12. > > v2: > - Enable HDCP for <= Gen12 platforms. [Ram] > > Cc: Ramalingam C > Tested-by: Karthik B S > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/dr

Re: [PATCH v7 14/18] drm/i915/hdcp: MST streams support in hdcp port_data

2020-12-10 Thread Ramalingam C
d should support RepeaterAuthStreamManage msg and m' validation > whenever required. > > v2: > - Init the hdcp port data k for HDMI/DP SST stream. > v3: > - Cosmetic changes. [Uma] > v4: > - 's/port_auth/hdcp_port_auth'. [Ram] > - Commit log improvement. &g

Re: [PATCH v7 17/18] drm/i915/hdcp: Support for HDCP 2.2 MST shim callbacks

2020-12-10 Thread Ramalingam C
tead of drm_err. [Uma] > - Cosmetic changes. [Uma] > v3: > - 's/port_data/hdcp_port_data' [Ram] > - skip redundant link check. [Ram] > v4: > - use pipe instead of port to access HDCP2_STREAM_STATUS How this missed the functional test till now? Always true because port's stream

Re: [PATCH v7 18/18] drm/i915/hdcp: Enable HDCP 2.2 MST support

2020-12-10 Thread Ramalingam C
the stream encryptions status for 2.2 another one for enabling the HDCP2.2 MST support. Ram > v2: > - Add connector details in drm_err. [Ram] > - 's/port_auth/hdcp_auth_status'. [Ram] > - Added a debug print for stream enc. > v3: > - uniformity for connector detail

Re: [PATCH 1/2] drm/i915/selftests: fix smatch warning in igt_check_blocks

2021-07-06 Thread Ramalingam C
} > > - if (block) { > - pr_err("bad block, dump:\n"); > - igt_dump_block(mm, block); > - } > + pr_err("bad block, dump:\n"); > + igt_dump_block(mm, block); LGTM. Reviewed-by: Ramalingam C > > return err; > } > -- > 2.26.3 >

Re: [PATCH 2/2] drm/i915/selftests: fix smatch warning in mock_reserve

2021-07-06 Thread Ramalingam C
region */ > @@ -224,9 +224,10 @@ static int igt_mock_reserve(void *arg) > } > > out_close: > - kfree(order); > close_objects(mem, &objects); > intel_memory_region_put(mem); > +out_free_order: > + kfree(order); LGTM. Reviewed-by: Ramalingam C > return err; > } > > -- > 2.26.3 >

Re: [PATCH v3 1/5] drm/i915: use consistent CPU mappings for pin_map users

2021-07-06 Thread Ramalingam C
ew rules for discrete. > > Suggested-by: Thomas Hellström > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > Cc: Maarten Lankhorst > Cc: Daniel Vetter > Cc: Ramalingam C > --- > drivers/gpu/drm/i915/gem/i915_gem_object.c | 34 ++ > drive

Re: [PATCH v3 2/5] drm/i915/uapi: convert drm_i915_gem_caching to kernel doc

2021-07-06 Thread Ramalingam C
On 2021-07-05 at 14:53:07 +0100, Matthew Auld wrote: > Convert all the drm_i915_gem_caching bits to proper kernel doc. > > Suggested-by: Daniel Vetter > Signed-off-by: Matthew Auld LGTM. Reviewed-by: Ramalingam C > Cc: Thomas Hellström > Cc: Maarten Lankhorst > Cc:

Re: [PATCH v3 3/5] drm/i915/uapi: reject caching ioctls for discrete

2021-07-06 Thread Ramalingam C
ew gem_create_ext extension. > > v2: add some kernel doc for the discrete changes, and document the > implicit rules LGTM Reviewed-by: Ramalingam C > > Suggested-by: Daniel Vetter > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > Cc: Maarten Lankhorst > C

Re: [PATCH v3 4/5] drm/i915/uapi: convert drm_i915_gem_set_domain to kernel doc

2021-07-06 Thread Ramalingam C
On 2021-07-05 at 14:53:09 +0100, Matthew Auld wrote: > Convert all the drm_i915_gem_set_domain bits to proper kernel doc. LGTM. Reviewed-by: Ramalingam C > > Suggested-by: Daniel Vetter > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > Cc: Maarten Lankhorst > Cc:

Re: [PATCH v3 5/5] drm/i915/uapi: reject set_domain for discrete

2021-07-06 Thread Ramalingam C
o adding a whole new flag is likely overkill. > > v2: add some more kernel doc, also add the implicit rules with caching LGTM Reviewed-by: Ramalingam C > > Suggested-by: Daniel Vetter > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > Cc: Maarten Lankhorst > Cc: Tvr

Re: [PATCH v4 01/16] drm/i915/hdcp: Update CP property in update_pipe

2020-11-05 Thread Ramalingam C
disable HDCP on another MST > stream on same DP MST topology. > > v2: > Fix WARN_ON(connector->base.registration_state == DRM_CONNECTOR_REGISTERED) > v3: > Commit log improvement. [Uma] > Added a comment before scheduling prop_work. [Uma] > > Fixes: 33f9a623bfc6 (&

Re: [Intel-gfx] [PATCH v4 01/16] drm/i915/hdcp: Update CP property in update_pipe

2020-11-05 Thread Ramalingam C
On 2020-11-05 at 18:48:02 +0530, Ramalingam C wrote: > On 2020-10-27 at 22:11:53 +0530, Anshuman Gupta wrote: > > When crtc state need_modeset is true it is not necessary > > it is going to be a real modeset, it can turns to be a > > fastset instead of modeset. > > Th

Re: [PATCH v4 02/16] drm/i915/hdcp: Get conn while content_type changed

2020-11-05 Thread Ramalingam C
against disappearing > connectors") > Cc: Sean Paul > Cc: Ramalingam C > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/display/intel_hdcp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c > b/drivers

Re: [Intel-gfx] [PATCH v4 01/16] drm/i915/hdcp: Update CP property in update_pipe

2020-11-05 Thread Ramalingam C
On 2020-11-05 at 18:51:57 +0530, Ramalingam C wrote: > On 2020-11-05 at 18:48:02 +0530, Ramalingam C wrote: > > On 2020-10-27 at 22:11:53 +0530, Anshuman Gupta wrote: > > > When crtc state need_modeset is true it is not necessary > > > it is going to be a real mo

Re: [PATCH v4 04/16] drm/i915/hdcp: DP MST transcoder for link and stream

2020-11-05 Thread Ramalingam C
transcoder for stream encryption > separately. > > This will be used for both HDCP 1.4 and HDCP 2.2 over DP MST > on Gen12. Reviewed-by: Ramalingam C > > Cc: Ramalingam C > Reviewed-by: Uma Shankar > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/displa

Re: [PATCH v4 05/16] drm/i915/hdcp: Move HDCP enc status timeout to header

2020-11-05 Thread Ramalingam C
tream status too, > it requires to move the macro to a header. > It will be used by both HDCP{1.x,2.x} stream status timeout. Reviewed-by: Ramalingam C > > Related: 'commit 7e90e8d0c0ea ("drm/i915: Increase timeout for Encrypt > status change")' > Cc: Ramalin

Re: [PATCH v4 06/16] drm/i915/hdcp: HDCP stream encryption support

2020-11-05 Thread Ramalingam C
name, error msg print and > stream typo fixes. [Uma] > > Cc: Ramalingam C > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 10 +-- > drivers/gpu/drm/i915/display/intel_ddi.h | 6 +- > .../drm/i915/display/intel_display_types.h

Re: [PATCH v4 07/16] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-11-05 Thread Ramalingam C
g print for stream encryption. > - Disable the hdcp on port after disabling last stream > encryption. > v3: > - Cosmetic change, removed the value less comment. [Uma] > > Cc: Ramalingam C > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/display/intel_dp_mst

Re: [PATCH v4 10/16] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len

2020-11-05 Thread Ramalingam C
hdcp_cmd_header size annotation nitpick. [Tomas] > > Cc: Tomas Winkler > Cc: Ramalingam C > Acked-by: Tomas Winkler > Reviewed-by: Uma Shankar > Signed-off-by: Anshuman Gupta > --- > drivers/misc/mei/hdcp/mei_hdcp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 dele

Re: [PATCH v4 11/16] drm/hdcp: Max MST content streams

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:12:03 +0530, Anshuman Gupta wrote: > Let's define Maximum MST content streams up to four > generically which can be supported by modern display > controllers. > > Cc: Sean Paul > Cc: Ramalingam C > Acked-by: Maarten Lankhorst > Reviewed-by:

Re: [PATCH v4 12/16] drm/i915/hdcp: MST streams support in hdcp port_data

2020-11-05 Thread Ramalingam C
> v3: > Cosmetic changes. [Uma] > > Cc: Ramalingam C > Signed-off-by: Anshuman Gupta > --- > .../drm/i915/display/intel_display_types.h| 4 +- > drivers/gpu/drm/i915/display/intel_hdcp.c | 103 +++--- > 2 files changed, 92 insertions(+), 1

Re: [PATCH v4 08/16] drm/i915/hdcp: Pass dig_port to intel_hdcp_init

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:12:00 +0530, Anshuman Gupta wrote: > Pass dig_port as an argument to intel_hdcp_init() > and intel_hdcp2_init(). > This will be required for HDCP 2.2 stream encryption. > > Cc: Ramalingam C > Reviewed-by: Uma Shankar > Signed-off-by: Anshuman Gupta >

Re: [PATCH v4 13/16] drm/i915/hdcp: Pass connector to check_2_2_link

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:12:05 +0530, Anshuman Gupta wrote: > This requires for HDCP 2.2 MST check link. > > Cc: Ramalingam C > Reviewed-by: Uma Shankar > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++- > driv

Re: [PATCH v4 14/16] drm/i915/hdcp: Add HDCP 2.2 stream register

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:12:06 +0530, Anshuman Gupta wrote: > Add HDCP 2.2 DP MST HDCP2_STREAM_STATUS > and HDCP2_AUTH_STREAM register in i915_reg header. Reviewed-by: Ramalingam C > > Cc: Ramalingam C > Reviewed-by: Uma Shankar > Signed-off-by: Anshuman Gupta > --- &g

Re: [PATCH v4 08/16] drm/i915/hdcp: Pass dig_port to intel_hdcp_init

2020-11-05 Thread Ramalingam C
On 2020-11-06 at 10:20:35 +0530, Anshuman Gupta wrote: > On 2020-11-05 at 22:09:12 +0530, Ramalingam C wrote: > > On 2020-10-27 at 22:12:00 +0530, Anshuman Gupta wrote: > > > Pass dig_port as an argument to intel_hdcp_init() > > > and intel_hdcp2_init(). > > >

Re: [PATCH v4 06/16] drm/i915/hdcp: HDCP stream encryption support

2020-11-05 Thread Ramalingam C
On 2020-11-06 at 10:52:03 +0530, Anshuman Gupta wrote: > On 2020-11-05 at 21:04:03 +0530, Ramalingam C wrote: > > On 2020-10-27 at 22:11:58 +0530, Anshuman Gupta wrote: > > > Both HDCP_{1.x,2.x} requires to select/deselect Multistream HDCP bit > > > in TRANS_DDI_FUNC_CTL

Re: [PATCH v4 12/16] drm/i915/hdcp: MST streams support in hdcp port_data

2020-11-06 Thread Ramalingam C
On 2020-11-06 at 12:05:14 +0530, Anshuman Gupta wrote: > On 2020-11-05 at 22:04:15 +0530, Ramalingam C wrote: > > On 2020-10-27 at 22:12:04 +0530, Anshuman Gupta wrote: > > > Add support for multiple mst stream in hdcp port data > > > which will be used by Repea

Re: [PATCH v4 09/16] drm/i915/hdcp: Encapsulate hdcp_port_data to dig_port

2020-11-06 Thread Ramalingam C
On 2020-10-27 at 22:12:01 +0530, Anshuman Gupta wrote: > hdcp_port_data is specific to a port on which HDCP > encryption is getting enabled, so encapsulate it to > intel_digital_port. > This will be required to enable HDCP 2.2 stream encryption. > > Cc: Ramalingam C > Rev

Re: [PATCH v4 16/16] drm/i915/hdcp: Enable HDCP 2.2 MST support

2020-11-06 Thread Ramalingam C
on on this port. > > Similarly disable the stream encryption for each encrypted > stream, once all encrypted stream encryption is disabled, > disable the port HDCP encryption and deauthenticate the port. > > Cc: Ramalingam C > Reviewed-by: Uma Shankar > Signed-off-by: Anshum

Re: [PATCH v4 03/16] drm/i915/hotplug: Handle CP_IRQ for DP-MST

2020-11-06 Thread Ramalingam C
On 2020-10-27 at 22:11:55 +0530, Anshuman Gupta wrote: > Handle CP_IRQ in DEVICE_SERVICE_IRQ_VECTOR_ESI0 > It requires to call intel_hdcp_handle_cp_irq() in case > of CP_IRQ is triggered by a sink in DP-MST topology. > > Cc: "Ville Syrjälä" > Cc: Ramalingam C

[PATCH 0/8] Patches for selftest_lrc

2022-03-08 Thread Ramalingam C
Patches that fix and enhance the selftest_lrc Akeem G Abodunrin (1): drm/i915/xehpsdv/dg1/tgl: Fix issue with LRI relative addressing Chris Wilson (7): drm/i915/selftests: Exercise relative mmio paths to non-privileged registers drm/i915/selftests: Exercise cross-process context isolati

[PATCH 1/8] drm/i915/selftests: Exercise relative mmio paths to non-privileged registers

2022-03-08 Thread Ramalingam C
From: Chris Wilson Verify that context isolation is also preserved when accessing context-local registers with relative-mmio commands. Signed-off-by: Chris Wilson Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 88 -- 1 file changed, 67

[PATCH 2/8] drm/i915/selftests: Exercise cross-process context isolation

2022-03-08 Thread Ramalingam C
From: Chris Wilson Verify that one context running on engine A cannot manipulate another client's context concurrently running on engine B using unprivileged access. Signed-off-by: Chris Wilson Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_lrc.c

[PATCH 6/8] drm/i915/selftest: Clear the output buffers before GPU writes

2022-03-08 Thread Ramalingam C
POISON_INUSE (0x5a) so that is both non-zero and distinct from the poison values used during the test. Reported-by: CQ Tang Signed-off-by: Chris Wilson cc: Joonas Lahtinen Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 32 ++ 1 file changed, 28

[PATCH 3/8] drm/i915/selftests: Flush the submission for lrc_isolation

2022-03-08 Thread Ramalingam C
force the preemption. Signed-off-by: Chris Wilson Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c index

[PATCH 5/8] drm/i915/selftests: Check for incomplete LRI from the context image

2022-03-08 Thread Ramalingam C
emit an invalid zero-length LRI. Reported-by: Daniele Ceraolo Spurio Signed-off-by: Chris Wilson Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 63 ++ 1 file changed, 55 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/gt

[PATCH 4/8] drm/i915/gt: Explicitly clear BB_OFFSET for new contexts

2022-03-08 Thread Ramalingam C
: Mika Kuoppala Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_lrc.c | 17 + drivers/gpu/drm/i915/gt/selftest_lrc.c | 5 + 3 files changed, 23 insertions(+) diff --git a/drivers/gpu/drm/i915/gt

[PATCH 7/8] drm/i915/selftest: Always cancel semaphore on error

2022-03-08 Thread Ramalingam C
: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c index d8face764ee4..63fd508fea49 100644 --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c

[PATCH 8/8] drm/i915/xehpsdv/dg1/tgl: Fix issue with LRI relative addressing

2022-03-08 Thread Ramalingam C
45728 Cc: Kumar Valsan, Prathap Signed-off-by: Akeem G Abodunrin Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 36 +- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/g

[PATCH 0/4] lrc selftest fixes

2022-03-14 Thread Ramalingam C
Few bug fixes for lrc selftest. Chris Wilson (4): drm/i915/gt: Explicitly clear BB_OFFSET for new contexts drm/i915/selftests: Check for incomplete LRI from the context image drm/i915/selftest: Clear the output buffers before GPU writes drm/i915/selftest: Always cancel semaphore on error

[PATCH 0/4] lrc selftest fixes

2022-03-14 Thread Ramalingam C
Few bug fixes for lrc selftest. Chris Wilson (4): drm/i915/gt: Explicitly clear BB_OFFSET for new contexts drm/i915/selftests: Check for incomplete LRI from the context image drm/i915/selftest: Clear the output buffers before GPU writes drm/i915/selftest: Always cancel semaphore on error

[PATCH 1/4] drm/i915/gt: Explicitly clear BB_OFFSET for new contexts

2022-03-14 Thread Ramalingam C
: Mika Kuoppala Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_engine_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_lrc.c | 17 + drivers/gpu/drm/i915/gt/selftest_lrc.c | 5 + 3 files changed, 23 insertions(+) diff --git a/drivers/gpu/drm/i915/gt

[PATCH 2/4] drm/i915/selftests: Check for incomplete LRI from the context image

2022-03-14 Thread Ramalingam C
emit an invalid zero-length LRI. Reported-by: Daniele Ceraolo Spurio Signed-off-by: Chris Wilson Cc: Daniele Ceraolo Spurio Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 61 +++--- 1 file changed, 54 insertions(+), 7 deletions(-) diff --git a

[PATCH 3/4] drm/i915/selftest: Clear the output buffers before GPU writes

2022-03-14 Thread Ramalingam C
POISON_INUSE (0x5a) so that is both non-zero and distinct from the poison values used during the test. Reported-by: CQ Tang Signed-off-by: Chris Wilson Cc: CQ Tang cc: Joonas Lahtinen Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 32 ++ 1 file changed

[PATCH 4/4] drm/i915/selftest: Always cancel semaphore on error

2022-03-14 Thread Ramalingam C
-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c index b9cc89de01bf..ae16668dd9d4 100644 --- a/drivers/gpu/drm/i915/gt

[PATCH v4 0/8] drm/i915/ttm: Evict and restore of compressed object

2022-03-19 Thread Ramalingam C
Test-with: 20220314051432.15785-1-ramalinga...@intel.com Ramalingam C (8): drm/i915/gt: Use XY_FASR_COLOR_BLT to clear obj on graphics ver 12+ drm/i915/gt: Clear compress metadata for Flat-ccs objects drm/i915/selftest_migrate: Consider the possible roundup of size drm/i915/selftest_migrate:

[PATCH v4 1/8] drm/i915/gt: Use XY_FASR_COLOR_BLT to clear obj on graphics ver 12+

2022-03-19 Thread Ramalingam C
XY_FAST_COLOR_BLT cmd is faster than the older XY_COLOR_BLT. Hence for clearing (Zero out) the pages of the newly allocated object, faster cmd is used. Signed-off-by: Ramalingam C Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 5 +++ drivers/gpu/drm/i915/gt

[PATCH v4 3/8] drm/i915/selftest_migrate: Consider the possible roundup of size

2022-03-19 Thread Ramalingam C
At obj allocation size could be rounded up by min_page_size. So please update the size as per the obj size allocated. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/selftest_migrate.c b

[PATCH v4 2/8] drm/i915/gt: Clear compress metadata for Flat-ccs objects

2022-03-19 Thread Ramalingam C
] mocs fix [Matt] Comments Fix [Matt] Flush address programming [Ram] v6: FLUSH_DW is fixed Few coding style fix v7: Adopting the XY_FAST_COLOR_BLT (Thomas] v8: XY_CTRL_SURF_COPY_BLT for ccs clearing. Signed-off-by: Ramalingam C Signed-off-by: Ayaz A Siddiqui --- drivers/gpu/drm

[PATCH v4 5/8] drm/i915/gt: Optimize the migration loop

2022-03-19 Thread Ramalingam C
Move the static calculations out of the loop. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 34 - 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt

[PATCH v4 4/8] drm/i915/selftest_migrate: Check CCS meta data clear

2022-03-19 Thread Ramalingam C
While clearing the Flat-CCS capable lmem object, we need to clear the CCS meta data corresponding to the memory. As part of live_migrate_clear add check for the ccs meta data clear for the Flat-CCS capable lmem object. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c

[PATCH v4 6/8] drm/ttm: Add a parameter to add extra pages into ttm_tt

2022-03-19 Thread Ramalingam C
Add a parameter called "extra_pages" for ttm_tt_init, to indicate that driver needs extra pages in ttm_tt. v2: Used imperative wording [Thomas and Christian] Signed-off-by: Ramalingam C cc: Christian Koenig cc: Hellstrom Thomas Reviewed-by: Thomas Hellstrom Reviewed-by: Chris

[PATCH v4 7/8] drm/i915/gem: Add extra pages in ttm_tt for ccs data

2022-03-19 Thread Ramalingam C
when obj's placement is lmem only Signed-off-by: Ramalingam C cc: Christian Koenig cc: Hellstrom Thomas Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH v4 8/8] drm/i915/migrate: Evict and restore the flatccs capable lmem obj

2022-03-19 Thread Ramalingam C
op as main memory [Thomas] v4: changes for emit_copy_ccs Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 163 +++- 1 file changed, 159 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i9

[PATCH v5 0/9] drm/i915/ttm: Evict and restore of compressed object

2022-03-21 Thread Ramalingam C
ta is done through a special cmd called XY_CTRL_SURF_COPY_BLT v5: Correct locating of ccs data [Thomas] Reuse of emit_copy_ccs. R-bs picked. Test-with: 20220314051432.15785-1-ramalinga...@intel.com Ramalingam C (9): drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+ drm

[PATCH v5 2/9] drm/i915/gt: Optimize the migration and clear loop

2022-03-21 Thread Ramalingam C
Move the static calculations out of the loops for copy and clear. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 44 - 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm

[PATCH v5 1/9] drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+

2022-03-21 Thread Ramalingam C
Use faster XY_FAST_COLOR_BLT cmd on graphics version of 12 and more, for clearing (Zero out) the pages of the newly allocated object. XY_FAST_COLOR_BLT is faster than the older XY_COLOR_BLT. v2: Typo fix at title [Thomas] Signed-off-by: Ramalingam C Signed-off-by: Chris Wilson Reviewed-by

[PATCH v5 5/9] drm/i915/selftest_migrate: Check CCS meta data clear

2022-03-21 Thread Ramalingam C
Extend the live migrate selftest, to verify the ccs surface clearing during the Flat-CCS capable lmem obj clear. v2: Look at right places for ccs data [Thomas] Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 250 ++--- 1 file changed, 222

[PATCH v5 3/9] drm/i915/gt: Clear compress metadata for Flat-ccs objects

2022-03-21 Thread Ramalingam C
] mocs fix [Matt] Comments Fix [Matt] Flush address programming [Ram] v6: FLUSH_DW is fixed Few coding style fix v7: Adopting the XY_FAST_COLOR_BLT (Thomas] v8: XY_CTRL_SURF_COPY_BLT for ccs clearing. v9: emit_copy_ccs is used. Signed-off-by: Ramalingam C Signed-off-by: Ayaz A

[PATCH v5 4/9] drm/i915/selftest_migrate: Consider the possible roundup of size

2022-03-21 Thread Ramalingam C
Consider the possible round up happened at obj size alignment to min_page_size during the obj allocation. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/selftest_migrate.c b/drivers/gpu

[PATCH v5 6/9] drm/i915/gt: offset handling for multiple copy engines

2022-03-21 Thread Ramalingam C
Handle the src and dst chunk offsets for different instances of the copy engines. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c

[PATCH v5 7/9] drm/ttm: Add a parameter to add extra pages into ttm_tt

2022-03-21 Thread Ramalingam C
Add a parameter called "extra_pages" for ttm_tt_init, to indicate that driver needs extra pages in ttm_tt. v2: Used imperative wording [Thomas and Christian] Signed-off-by: Ramalingam C cc: Christian Koenig cc: Hellstrom Thomas Reviewed-by: Thomas Hellstrom Reviewed-by: Chris

[PATCH v5 8/9] drm/i915/gem: Add extra pages in ttm_tt for ccs data

2022-03-21 Thread Ramalingam C
when obj's placement is lmem only Signed-off-by: Ramalingam C cc: Christian Koenig cc: Hellstrom Thomas Reviewed-by: Thomas Hellstrom Reviewed-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 29 - 1 file changed, 28 insertions(+), 1 deletion(-)

[PATCH v5 9/9] drm/i915/migrate: Evict and restore the flatccs capable lmem obj

2022-03-21 Thread Ramalingam C
op as main memory [Thomas] v4: changes for emit_copy_ccs Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 163 +++- 1 file changed, 159 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i9

Re: [PATCH v4 4/8] drm/i915/selftest_migrate: Check CCS meta data clear

2022-03-21 Thread Ramalingam C
On 2022-03-21 at 16:09:08 +0530, Hellstrom, Thomas wrote: > On Sun, 2022-03-20 at 02:12 +0530, Ramalingam C wrote: > > While clearing the Flat-CCS capable lmem object, we need to clear the > > CCS > > meta data corresponding to the memory. > > > > As part of liv

Re: [Intel-gfx] [PATCH v4 6/8] drm/ttm: Add a parameter to add extra pages into ttm_tt

2022-03-21 Thread Ramalingam C
On 2022-03-21 at 11:11:33 +0100, Das, Nirmoy wrote: > In the previous version I replied only to the mailing list email so probably > my email slipped through. Sorry for the miss. Thank so much for the review. Ram > > Reviewed-by: Nirmoy Das for patch 6-7 > > On 3/19/2022 9:4

Re: [PATCH v4 1/8] drm/i915/gt: Use XY_FASR_COLOR_BLT to clear obj on graphics ver 12+

2022-03-21 Thread Ramalingam C
On 2022-03-21 at 14:19:01 +0530, Hellstrom, Thomas wrote: > On Sun, 2022-03-20 at 02:12 +0530, Ramalingam C wrote: > > XY_FAST_COLOR_BLT cmd is faster than the older XY_COLOR_BLT. Hence > > for > > clearing (Zero out) the pages of the newly allocated object, faster > >

[PATCH v2 3/4] drm/i915/selftest: Clear the output buffers before GPU writes

2022-03-21 Thread Ramalingam C
POISON_INUSE (0x5a) so that is both non-zero and distinct from the poison values used during the test. v2: Use i915_gem_object_pin_map_unlocked Reported-by: CQ Tang Signed-off-by: Chris Wilson Cc: CQ Tang cc: Joonas Lahtinen Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 32

[PATCH v6 9/9] drm/i915/migrate: Evict and restore the flatccs capable lmem obj

2022-03-22 Thread Ramalingam C
op as main memory [Thomas] v4: changes for emit_copy_ccs v5: handle non-flat-ccs scenario Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 164 +++- 1 file changed, 160 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate

Re: [Intel-gfx] [PATCH v5 6/9] drm/i915/gt: offset handling for multiple copy engines

2022-03-28 Thread Ramalingam C
On 2022-03-24 at 17:20:28 +0100, Thomas Hellström (Intel) wrote: > > On 3/21/22 23:44, Ramalingam C wrote: > > Handle the src and dst chunk offsets for different instances of the copy > > engines. > > > > Signed-off-by: Ramalingam C > > --- > > d

Re: [PATCH v5 8/9] drm/i915/gem: Add extra pages in ttm_tt for ccs data

2022-03-28 Thread Ramalingam C
On 2022-03-24 at 17:28:08 +0100, Thomas Hellström wrote: > > On 3/21/22 23:44, Ramalingam C wrote: > > On Xe-HP and later devices, dedicated compression control state (CCS) > > stored in local memory is used for each surface, to support the > > 3D and media compressi

Re: [Intel-gfx] [PATCH v5 3/9] drm/i915/gt: Clear compress metadata for Flat-ccs objects

2022-03-28 Thread Ramalingam C
On 2022-03-24 at 17:14:53 +0100, Thomas Hellström (Intel) wrote: > Hi, Ram > > On 3/21/22 23:44, Ramalingam C wrote: > > Xe-HP and latest devices support Flat CCS which reserved a portion of > > the device memory to store compression metadata, during the clearing of >

[PATCH v7 0/9] drm/i915/ttm: Evict and restore of compressed object

2022-03-28 Thread Ramalingam C
Test-with: 20220314051432.15785-1-ramalinga...@intel.com Ramalingam C (9): drm/i915/gt: use engine instance directly for offset drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+ drm/i915/gt: Optimize the migration and clear loop drm/i915/gt: Clear compress metadata for Fla

[PATCH v7 2/9] drm/i915/gt: Use XY_FAST_COLOR_BLT to clear obj on graphics ver 12+

2022-03-28 Thread Ramalingam C
-off-by: Ramalingam C Signed-off-by: Chris Wilson Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 5 +++ drivers/gpu/drm/i915/gt/intel_migrate.c | 43 +--- 2 files changed, 43 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915

[PATCH v7 1/9] drm/i915/gt: use engine instance directly for offset

2022-03-28 Thread Ramalingam C
To make it uniform across copy and clear, use the engine offset directly to calculate the offset in the cmd forming for emit_clear. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/gpu

[PATCH v7 4/9] drm/i915/gt: Clear compress metadata for Flat-ccs objects

2022-03-28 Thread Ramalingam C
] only one ctrl surf cmd is used as size of lmem is <=8M [Thomas] Signed-off-by: Ramalingam C Signed-off-by: Ayaz A Siddiqui --- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 16 +++ drivers/gpu/drm/i915/gt/intel_migrate.c | 137 ++- 2 files changed, 152 inserti

[PATCH v7 5/9] drm/i915/selftest_migrate: Consider the possible roundup of size

2022-03-28 Thread Ramalingam C
Consider the possible round up happened at obj size alignment to min_page_size during the obj allocation. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/selftest_migrate.c b/drivers/gpu

[PATCH v7 6/9] drm/i915/selftest_migrate: Check CCS meta data clear

2022-03-28 Thread Ramalingam C
Extend the live migrate selftest, to verify the ccs surface clearing during the Flat-CCS capable lmem obj clear. v2: Look at right places for ccs data [Thomas] Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 250 ++--- 1 file changed, 222

[PATCH v7 8/9] drm/i915/gem: Add extra pages in ttm_tt for ccs data

2022-03-28 Thread Ramalingam C
when obj's placement is lmem only v4: GEM_BUG_ON if the ttm->num_pages > obj page size [Thomas] Signed-off-by: Ramalingam C cc: Christian Koenig cc: Hellstrom Thomas Reviewed-by: Thomas Hellstrom Reviewed-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem

[PATCH v7 7/9] drm/ttm: Add a parameter to add extra pages into ttm_tt

2022-03-28 Thread Ramalingam C
Add a parameter called "extra_pages" for ttm_tt_init, to indicate that driver needs extra pages in ttm_tt. v2: Used imperative wording [Thomas and Christian] Signed-off-by: Ramalingam C cc: Christian Koenig cc: Hellstrom Thomas Reviewed-by: Thomas Hellstrom Reviewed-by: Chris

[PATCH v7 9/9] drm/i915/migrate: Evict and restore the flatccs capable lmem obj

2022-03-28 Thread Ramalingam C
op as main memory [Thomas] v4: changes for emit_copy_ccs v5: handle non-flat-ccs scenario Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/gt/intel_migrate.c | 164 +++- 1 file changed, 160 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_migrate

[PATCH v7 3/9] drm/i915/gt: Optimize the migration and clear loop

2022-03-28 Thread Ramalingam C
Move the static calculations out of the loops for copy and clear. Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/gt/intel_migrate.c | 44 - 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i915/gt

Re: [PATCH v8 5/5] drm/i915/uapi: document behaviour for DG2 64K support

2022-02-18 Thread Ramalingam C
> > various reasons, so try to document the new implicit uapi for this. > > > > v3: fix typos and less emphasis > > v2: Fixed suggestions on formatting [Daniel] > > > > Signed-off-by: Matthew Auld > > Signed-off-by: Ramalingam C > > Signed-off-

[PATCH 00/15] drm/i915: Enable DG2

2022-02-18 Thread Ramalingam C
cards drm/i915: support 64K GTT pages for discrete cards drm/i915/gtt: allow overriding the pt alignment drm/i915/gtt: add xehpsdv_ppgtt_insert_entry drm/i915/migrate: add acceleration support for DG2 drm/i915/uapi: document behaviour for DG2 64K support Ramalingam C (1): drm/i915: add

[PATCH 01/15] drm/i915/dg2: Define GuC firmware version for DG2

2022-02-18 Thread Ramalingam C
From: John Harrison First release of GuC for DG2. Signed-off-by: John Harrison CC: Tomasz Mistat CC: Ramalingam C CC: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c b/drivers

[PATCH 02/15] drm/i915: Fix for PHY_MISC_TC1 offset

2022-02-18 Thread Ramalingam C
available. Just correct the offset of the last phy to 0x64C14 as the rest of the support for it is coming on next commits. Signed-off-by: Matt Roper Signed-off-by: Jouni Högander Signed-off-by: Ramalingam C Reviewed-by: Uma Shankar Reviewed-by: Lucas De Marchi Acked-by: Ville Syrjälä Signed-off-by

[PATCH 03/15] drm/i915/dg2: Drop 38.4 MHz MPLLB tables

2022-02-18 Thread Ramalingam C
Roper Signed-off-by: Ramalingam C Reviewed-by: Lucas De Marchi Reviewed-by: Uma Shankar Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_snps_phy.c | 208 +- 1 file changed, 1 insertion(+), 207 deletions(-) diff --git a/drivers/gpu/drm/i915/di

[PATCH 05/15] drm/i915: add needs_compact_pt flag

2022-02-18 Thread Ramalingam C
Suggested-by: Matthew Auld Signed-off-by: Ramalingam C Signed-off-by: Robert Beckett Reviewed-by: Thomas Hellström --- drivers/gpu/drm/i915/i915_drv.h | 11 --- drivers/gpu/drm/i915/i915_pci.c | 2 ++ drivers/gpu/drm/i915/intel_device_info.h | 1 + 3 files changed

  1   2   3   4   5   6   7   8   9   10   >