[PATCH] drm, i915: Fix memory leak in i915_gem_busy_ioctl().

2011-11-15 Thread Rakib Mullick
A call to i915_add_request() has been made in function i915_gem_busy_ioctl(). i915_add_request can fail, so in it's exit path previously allocated memory needs to be freed. Signed-off-by: Rakib Mullick --- diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c

Re: [PATCH] drm, i915: Fix memory leak in i915_gem_busy_ioctl().

2011-11-25 Thread Rakib Mullick
On Mon, Nov 21, 2011 at 11:16 PM, Keith Packard wrote: > On Mon, 21 Nov 2011 17:23:06 +0100, Daniel Vetter wrote: > >> Indeed, nice catch (albeit totally unlikely to be hit, because the error >> only happens when the gpu ceases to progress in the ring, so imo not >> stable material). Keith, pleas

Re: [PATCH] drm, i915: Fix memory leak in i915_gem_busy_ioctl().

2011-11-26 Thread Rakib Mullick
On Sat, Nov 26, 2011 at 4:57 PM, Chris Wilson wrote: > On Sat, 26 Nov 2011 10:44:17 +0600, Rakib Mullick > wrote: >> On Mon, Nov 21, 2011 at 11:16 PM, Keith Packard wrote: >> > On Mon, 21 Nov 2011 17:23:06 +0100, Daniel Vetter wrote: >> > >> >> Inde

Re: [PATCH] drm, i915: Fix memory leak in i915_gem_busy_ioctl().

2011-11-27 Thread Rakib Mullick
On Sat, Nov 26, 2011 at 10:53 PM, Chris Wilson wrote: > On Sat, 26 Nov 2011 22:29:12 +0600, Rakib Mullick > wrote: >> Yes, no real problem with current code. I was just thinking from code >> cleanup's pov. Is BUG_ON really needed in i915_add_request() ? > > No, jus

Re: [PATCH] drivers: Use kzalloc instead of 'kmalloc+memset', where possible.

2011-05-25 Thread Rakib Mullick
On Tue, May 24, 2011 at 11:09 PM, Joe Perches wrote: > On Tue, 2011-05-24 at 22:59 +0600, Rakib Mullick wrote: > > On 5/23/11, Joe Perches wrote: > > > On Mon, 2011-05-23 at 23:40 +0600, Rakib Mullick wrote: > > >> Following patch removes the uses of 'kmalloc+

[PATCH v1] drivers: Use kzalloc instead of 'kmalloc+memset', where possible

2011-05-27 Thread Rakib Mullick
. Signed-off-by: Rakib Mullick --- diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c index 1c4b3aa..168b78f 100644 --- a/drivers/ata/sata_dwc_460ex.c +++ b/drivers/ata/sata_dwc_460ex.c @@ -1638,13 +1638,12 @@ static int sata_dwc_probe(struct platform_device *ofdev) const

[PATCH] drm, i915: Fix memory leak in i915_gem_busy_ioctl().

2011-11-26 Thread Rakib Mullick
On Mon, Nov 21, 2011 at 11:16 PM, Keith Packard wrote: > On Mon, 21 Nov 2011 17:23:06 +0100, Daniel Vetter wrote: > >> Indeed, nice catch (albeit totally unlikely to be hit, because the error >> only happens when the gpu ceases to progress in the ring, so imo not >> stable material). Keith, pleas

[PATCH] drm, i915: Fix memory leak in i915_gem_busy_ioctl().

2011-11-26 Thread Rakib Mullick
On Sat, Nov 26, 2011 at 4:57 PM, Chris Wilson wrote: > On Sat, 26 Nov 2011 10:44:17 +0600, Rakib Mullick gmail.com> wrote: >> On Mon, Nov 21, 2011 at 11:16 PM, Keith Packard wrote: >> > On Mon, 21 Nov 2011 17:23:06 +0100, Daniel Vetter >> > wrote: >>

[PATCH] drm, i915: Fix memory leak in i915_gem_busy_ioctl().

2011-11-28 Thread Rakib Mullick
On Sat, Nov 26, 2011 at 10:53 PM, Chris Wilson wrote: > On Sat, 26 Nov 2011 22:29:12 +0600, Rakib Mullick gmail.com> wrote: >> Yes, no real problem with current code. I was just thinking from code >> cleanup's pov. Is BUG_ON really needed in i915_add_request() ? > >

[PATCH] drivers: Use kzalloc instead of 'kmalloc+memset', where possible.

2011-05-24 Thread Rakib Mullick
On Tue, May 24, 2011 at 11:09 PM, Joe Perches wrote: > On Tue, 2011-05-24 at 22:59 +0600, Rakib Mullick wrote: > > On 5/23/11, Joe Perches wrote: > > > On Mon, 2011-05-23 at 23:40 +0600, Rakib Mullick wrote: > > >> Following patch removes the uses of 'kmalloc+

[PATCH v1] drivers: Use kzalloc instead of 'kmalloc+memset', where possible

2011-05-26 Thread Rakib Mullick
. Signed-off-by: Rakib Mullick --- diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c index 1c4b3aa..168b78f 100644 --- a/drivers/ata/sata_dwc_460ex.c +++ b/drivers/ata/sata_dwc_460ex.c @@ -1638,13 +1638,12 @@ static int sata_dwc_probe(struct platform_device *ofdev) const

[PATCH] drm, i915: Fix memory leak in i915_gem_busy_ioctl().

2011-11-16 Thread Rakib Mullick
A call to i915_add_request() has been made in function i915_gem_busy_ioctl(). i915_add_request can fail, so in it's exit path previously allocated memory needs to be freed. Signed-off-by: Rakib Mullick --- diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c