[PATCH] drm/exynos: remove hardware overlays disable from fimd probe

2014-06-02 Thread Rahul Sharma
On 2 June 2014 14:41, Andrzej Hajda wrote: > Hi Rahul, > > On 05/28/2014 08:11 AM, Rahul Sharma wrote: >> System hangs when FIMD registers are accessed to disable >> hardware overlays. This is because of the clocks which are >> not enabled before register access. >

[PATCH 0/5] drm/exynos: fix for misc issues related to exynos mixer

2014-06-18 Thread Rahul Sharma
Fixes for various issues which are to Power On/Off sequence, Layer update, waiting for vblank in exynos mixer driver. This series is based on exynos-drm-fixes branch in Inki dae's tree. Rahul Sharma (5): drm/exynos: set power state variable after enabling clocks and power drm/exynos:

[PATCH 1/5] drm/exynos: set power state variable after enabling clocks and power

2014-06-18 Thread Rahul Sharma
device power enabled. Similar logic for poweroff sequence. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_mixer.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos

[PATCH 4/5] drm/exynos: soft reset mixer before reconfigure after power-on

2014-06-18 Thread Rahul Sharma
Mixer soft reset is a recommended step before reconfiguring the mixer after power on. Mixer looses the previous state of DMAs if soft reset. This is the recommendation from the hardware team. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_mixer.c |2 ++ 1 file changed, 2

[PATCH] drm/exynos: defer hdmi probe when fail to get regulators

2014-06-18 Thread Rahul Sharma
HDMI probe proceeds with dummy regulators when the regulators are not provided in DT node or regulator provider has not get probed or failed to register the regulators. This patch modify hdmi driver to defer the probe in case the regulators are not available. Signed-off-by: Rahul Sharma

[PATCH 3/5] drm/exynos: allow mulitple layer updates per vsync for mixer

2014-06-18 Thread Rahul Sharma
Allowing only one layer update per vsync can cause issues while there are update available for both layers. There is a good amount of possibility to loose updates if we allow single update per vsync. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_mixer.c |7 +-- 1 file

[PATCH 5/5] drm/exynos: enable vsync interrupt while waiting for vblank

2014-06-18 Thread Rahul Sharma
mixer_wait_for_vblank function expects that the upcoming vsync interrupt handler routine will clear the wait_vsync_event atomic variable. For this to happen, interrupts should be enabled and disabled properly. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_mixer.c |4 1

[PATCH 2/5] drm/exynos: stop mixer before gating clocks during poweroff

2014-06-18 Thread Rahul Sharma
Mixer should be power gated only after it is gracefully stopped. The recommended sequence is to Stop the mixer and wait till it enters to IDLE state before gating the clocks and power to the mixer. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_mixer.c | 15

[PATCH] drm/exynos: defer hdmi probe when fail to get regulators

2014-06-19 Thread Rahul Sharma
Thanks Inki, On 19 June 2014 09:34, Inki Dae wrote: > On 2014? 06? 18? 22:42, Rahul Sharma wrote: >> HDMI probe proceeds with dummy regulators when the regulators >> are not provided in DT node or regulator provider has not get >> probed or failed to register the regulat

[RFC] drm/exynos: abort commit when framebuffer is removed from plane

2014-06-19 Thread Rahul Sharma
crashes the system. Signed-off-by: Rahul Sharma --- This works fine but I am not confident on the correctness of the solution. drivers/gpu/drm/exynos/exynos_drm_crtc.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos

[PATCH 5/5] drm/exynos: enable vsync interrupt while waiting for vblank

2014-06-20 Thread Rahul Sharma
Hi All, On 18 June 2014 17:04, Rahul Sharma wrote: > mixer_wait_for_vblank function expects that the upcoming > vsync interrupt handler routine will clear the > wait_vsync_event atomic variable. > > For this to happen, interrupts should be enabled and > disabled properly.

[PATCH V4 00/10] drm: exynos: few patches to enhance bridge chip support

2014-06-23 Thread Rahul Sharma
: Tested-by: Rahul Sharma Regards, Rahul Sharma. On 20 June 2014 21:21, Inki Dae wrote: > 2014-06-20 17:06 GMT+09:00 Ajay kumar : >> ping. > > I will have a review soon but I'm afraid that I cannot have a test yet > because I have no any board with panel based on eDP and L

[PATCH 2/5 v2] drm/exynos: stop mixer before gating clocks during poweroff

2014-06-23 Thread Rahul Sharma
Mixer should be power gated only after it is gracefully stopped. The recommended sequence is to Stop the mixer and wait till it enters to IDLE state before gating the clocks and power to the mixer. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_mixer.c | 15

[PATCH 1/5 v2] drm/exynos: set power state variable after enabling clocks and power

2014-06-23 Thread Rahul Sharma
device power enabled. Similar logic for poweroff sequence. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_mixer.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos

[PATCH 0/5 v2] drm/exynos: fix for misc issues related to exynos mixer

2014-06-23 Thread Rahul Sharma
Fixes for various issues which are to Power On/Off sequence, Layer update, waiting for vblank in exynos mixer driver. v2: 1) Repalce mixer_enable_vblank with drm_vblank_get. This series is based on exynos-drm-fixes branch in Inki dae's tree. Rahul Sharma (5): drm/exynos: set power

[PATCH 3/5 v2] drm/exynos: allow mulitple layer updates per vsync for mixer

2014-06-23 Thread Rahul Sharma
Allowing only one layer update per vsync can cause issues while there are update available for both layers. There is a good amount of possibility to loose updates if we allow single update per vsync. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_mixer.c |7 +-- 1 file

[PATCH 4/5 v2] drm/exynos: soft reset mixer before reconfigure after power-on

2014-06-23 Thread Rahul Sharma
Mixer soft reset is a recommended step before reconfiguring the mixer after power on. Mixer looses the previous state of DMAs if soft reset. This is the recommendation from the hardware team. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_mixer.c |2 ++ 1 file changed, 2

[PATCH v2] drm/exynos: defer hdmi probe when fail to get regulators

2014-06-23 Thread Rahul Sharma
HDMI probe proceeds with dummy regulators when the regulators are not provided in DT node or regulator provider has not get probed or failed to register the regulators. This patch modify hdmi driver to defer the probe in case the regulators are not available. Signed-off-by: Rahul Sharma --- v2

[PATCH 5/5 v2] drm/exynos: enable vsync interrupt while waiting for vblank

2014-06-23 Thread Rahul Sharma
mixer_wait_for_vblank function expects that the upcoming vsync interrupt handler routine will clear the wait_vsync_event atomic variable. For this to happen, interrupts should be enabled and disabled properly. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_mixer.c |4 1

[PATCH V4 00/10] drm: exynos: few patches to enhance bridge chip support

2014-06-24 Thread Rahul Sharma
Hi Tomasz, On 23 June 2014 20:08, Tomasz Figa wrote: > Hi Rahul, > > On 23.06.2014 15:58, Rahul Sharma wrote: >> Hi Ajay, Inki, >> >> I tested this series for Exynos5420 based peach-pit board, >> Exynos5800 based Peach-pi board and Exynos5250 based >> Snow

[PATCH 3/5 v2] drm/exynos: allow mulitple layer updates per vsync for mixer

2014-06-25 Thread Rahul Sharma
Thanks Inki, One more thing. mixer_layer_update is only called on for mixer version; MXR_VER_16_0_33_0, MXR_VER_128_0_0_184. This condition should have taken care of Exynos4 scenarios. What you say? Regards, Rahul Sharma. On 24 June 2014 20:20, Inki Dae wrote: > 2014-06-24 20:38 GMT+09

[PATCH 1/3] drm/exynos: Control DISP1BLK system register in FIMD

2014-06-26 Thread Rahul Sharma
timing_base = 0x0, > .has_shadowcon = 1, > + .sysreg_disp1blk_offset = 0x210, offset should be defined as Macros in reg file. > }; > > static struct fimd_driver_data exynos5_fimd_driver_data = { > .timing_base = 0x2, > .has_shadowcon = 1, &

Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

2013-07-29 Thread Rahul Sharma
On Tue, Jun 18, 2013 at 5:07 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 18 June 2013 03:33 PM, Rahul Sharma wrote: > > Thanks all, > > > > On Fri, Jun 14, 2013 at 11:39 AM, 김승우 wrote: > >> Hello Kishon, > >> > >> On 2013년

Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

2013-07-29 Thread Rahul Sharma
On Tue, Jul 30, 2013 at 10:37 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Tuesday 30 July 2013 09:12 AM, Rahul Sharma wrote: > > > > > > On Tue, Jun 18, 2013 at 5:07 PM, Kishon Vijay Abraham I > <mailto:kis...@ti.com>> wrote: > > > > Hi,

Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

2013-07-30 Thread Rahul Sharma
Thanks Seung-Woo, On Tue, Jul 30, 2013 at 11:36 AM, Seung-Woo Kim wrote: > Hi Rahul, > > On 2013년 07월 30일 12:42, Rahul Sharma wrote: >> >> >> On Tue, Jun 18, 2013 at 5:07 PM, Kishon Vijay Abraham I > <mailto:kis...@ti.com>> wrote: >> >> Hi

Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

2013-07-31 Thread Rahul Sharma
On Tue, Jul 30, 2013 at 2:21 PM, Rahul Sharma wrote: > Thanks Seung-Woo, > > On Tue, Jul 30, 2013 at 11:36 AM, Seung-Woo Kim > wrote: >> Hi Rahul, >> >> On 2013년 07월 30일 12:42, Rahul Sharma wrote: >>> >>> >>> On Tue, Jun 18, 2013 at

Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

2013-07-31 Thread Rahul Sharma
Thanks Sylwester, On Wed, Jul 31, 2013 at 5:41 PM, Sylwester Nawrocki wrote: > Hi Rahul, > > On 07/31/2013 01:23 PM, Rahul Sharma wrote: >>>> I think your hdmiphy pmu patch is good enough just if dt binding for pmu >>>> >> is in hdmiphy binding instead of

Re: [PATCH 0/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-08-30 Thread Rahul Sharma
mp;hdmiphy_i2c_driver); > ... > } else { > ret = platform_driver_register(&hdmiphy_platform_driver); > ... > } > Here i2c_hdmiphy flag helps in avoiding registering both i2c and platform drivers for phy. But is it a

[PATCH 1/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-09-01 Thread Rahul Sharma
Exynos hdmiphy operations and configs are kept inside the hdmi driver. Hdmiphy related code is tightly coupled with hdmi IP driver. This patche moves hdmiphy related code to hdmiphy driver. It will help in cleanly supporting the hdmiphy variations in further SoCs. Signed-off-by: Rahul Sharma

[PATCH 2/7] drm/exynos: remove dummy hdmiphy clock

2013-09-01 Thread Rahul Sharma
hdmiphy is a dummy clock which actually controls the PMU bit to enable/disbale hdmiphy (before CCF). This clock is cleaned from the hdmi driver. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_hdmi.c |8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 0/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-09-01 Thread Rahul Sharma
.html Rahul Sharma (7): drm/exynos: move hdmiphy related code to hdmiphy driver drm/exynos: remove dummy hdmiphy clock drm/exynos: add hdmiphy pmu bit control in hdmiphy driver drm/exynos: add support for exynos5420 hdmiphy exynos/drm: fix ddc i2c device probe failure ARM: dts: update

[PATCH 3/7] drm/exynos: add hdmiphy pmu bit control in hdmiphy driver

2013-09-01 Thread Rahul Sharma
Before hdmiphy operation like config, start etc, hdmiphy bit in PMU block should be enabled. Earlier this happens in hdmi drvier through a dummy "hdmiphy" clock. Signed-off-by: Rahul Sharma --- .../devicetree/bindings/video/exynos_hdmiphy.txt |6 ++ drivers/gpu/

[PATCH 4/7] drm/exynos: add support for exynos5420 hdmiphy

2013-09-01 Thread Rahul Sharma
Exynos5420 hdmiphy device is a platform device, unlike predecessor SoCs where it used to be a I2C device. This support is added to the hdmiphy driver. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_hdmiphy.c | 224 ++- 1 file changed, 221 insertions

[PATCH 5/7] exynos/drm: fix ddc i2c device probe failure

2013-09-01 Thread Rahul Sharma
Exynos hdmi ddc is a I2C device and if we register hdmi ddc driver with id_table as NULL, cause failure in probing. id_table field should not be NULL for i2c_driver registeration. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_ddc.c |5 + 1 file changed, 5 insertions

[PATCH 6/7] ARM: dts: update hdmiphy dt node for exynos5250

2013-09-01 Thread Rahul Sharma
hdmiphy dt node needs a child node called 'phy-power-control' which represents the PMU register for power controlling the hdmiphy. hdmi driver dt node provides phy property which points to the hdmiphy dt node. Signed-off-by: Rahul Sharma --- arch/arm/boot/dts/exynos5250-smdk5250.

[PATCH 7/7] ARM: dts: update hdmiphy dt node for exynos5420

2013-09-01 Thread Rahul Sharma
hdmiphy dt node needs a child node called 'phy-power-control' which represents the PMU register for power controlling the hdmiphy. hdmi driver dt node provides phy property which points to the hdmiphy dt node. Signed-off-by: Rahul Sharma --- arch/arm/boot/dts/exynos5420.d

Re: [PATCH 0/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-09-01 Thread Rahul Sharma
On 2 September 2013 10:38, Inki Dae wrote: > Hi Rahul, > >> -Original Message- >> From: linux-samsung-soc-ow...@vger.kernel.org [mailto:linux-samsung-soc- >> ow...@vger.kernel.org] On Behalf Of Rahul Sharma >> Sent: Friday, August 30, 2013 7:06 PM >&

Re: [PATCH 0/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-09-02 Thread Rahul Sharma
On 2 September 2013 12:52, Inki Dae wrote: > > >> -Original Message----- >> From: Rahul Sharma [mailto:r.sh.o...@gmail.com] >> Sent: Monday, September 02, 2013 3:28 PM >> To: Inki Dae >> Cc: Rahul Sharma; linux-samsung-soc; dri-devel@lists.freedesktop.org;

Re: [PATCH 1/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-09-03 Thread Rahul Sharma
Thanks Sean, On 3 September 2013 20:15, Sean Paul wrote: > A few comments. > > On Fri, Aug 30, 2013 at 2:59 AM, Rahul Sharma > wrote: >> Exynos hdmiphy operations and configs are kept inside >> the hdmi driver. Hdmiphy related code is tightly coupled >> with hdm

Re: [PATCH 1/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-09-05 Thread Rahul Sharma
On 5 September 2013 09:46, Inki Dae wrote: > > >> -Original Message- >> From: linux-samsung-soc-ow...@vger.kernel.org [mailto:linux-samsung-soc- >> ow...@vger.kernel.org] On Behalf Of Sean Paul >> Sent: Wednesday, September 04, 2013 11:52 PM >> To:

Re: [PATCH 1/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-09-05 Thread Rahul Sharma
SEL which seems like it would be >> >> board-specific, same with TX_* registers. >> >> >> > >> > And we can select HDMI Tx PHY internal PLL input clock by setting >> CLK_SEL. >> > Ok, Shirish's patch set is reasona

Re: [PATCH 1/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-09-06 Thread Rahul Sharma
On 5 September 2013 19:20, Inki Dae wrote: > > >> -Original Message- >> From: Sean Paul [mailto:seanp...@chromium.org] >> Sent: Thursday, September 05, 2013 10:20 PM >> To: Inki Dae >> Cc: Rahul Sharma; Rahul Sharma; linux-samsung-soc; dri-devel; k

Re: [PATCH 1/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-09-10 Thread Rahul Sharma
On 6 September 2013 19:21, Sean Paul wrote: > On Thu, Sep 5, 2013 at 11:37 PM, Rahul Sharma wrote: >> On 5 September 2013 19:20, Inki Dae wrote: >>> >>> >>>> -Original Message- >>>> From: Sean Paul [mailto:seanp...@chromium.org] >&

Re: [PATCH 1/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-09-26 Thread Rahul Sharma
On 16 September 2013 18:10, Inki Dae wrote: > CCing devicetree, > >> -Original Message----- >> From: Rahul Sharma [mailto:r.sh.o...@gmail.com] >> Sent: Tuesday, September 10, 2013 5:28 PM >> To: Sean Paul >> Cc: Inki Dae; Rahul Sharma; linux-samsung-soc;

[PATCH v4 0/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Rahul Sharma
From: Rahul Sharma Changelog: v4: * Rename files to follow "phy-exynos-simple" names. * Rename Macros to this convention PHY_EXYNOS_SIMPLE_. * Added list of phy specifier values to documentation file. * Removed of_match_ptr from driver probe.

[PATCH v4 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Rahul Sharma
From: Tomasz Stanislawski Add exynos-simple-phy driver to support a single register PHY interfaces present on Exynos4 SoC. Signed-off-by: Tomasz Stanislawski Signed-off-by: Rahul Sharma --- .../devicetree/bindings/phy/samsung-phy.txt| 57 ++ drivers/phy/Kconfig

[PATCH v4 2/3] drm: exynos: hdmi: use hdmiphy as PHY

2014-05-15 Thread Rahul Sharma
awski Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_hdmi.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 9a6d652..ef1cdd0 100644 --- a/drivers/gpu/drm/exynos/exynos_h

[PATCH v4 3/3] s5p-tv: hdmi: use hdmiphy as PHY

2014-05-15 Thread Rahul Sharma
awski Signed-off-by: Rahul Sharma --- drivers/media/platform/s5p-tv/hdmi_drv.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/s5p-tv/hdmi_drv.c b/drivers/media/platform/s5p-tv/hdmi_drv.c index 534722c..8013e52 100644 --- a/drivers/media/pla

[PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Rahul Sharma
On 16 May 2014 03:14, Tomasz Figa wrote: > On 15.05.2014 06:01, Rahul Sharma wrote: >> Thanks Tomasz, >> >> On 15 May 2014 01:31, Tomasz Figa wrote: >>> Hi Rahul, Tomasz, >> [snip] >>>> + simplephys: simple-phys at 1004 { >>>&g

[PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Rahul Sharma
On 16 May 2014 15:12, Rahul Sharma wrote: > On 16 May 2014 03:14, Tomasz Figa wrote: >> On 15.05.2014 06:01, Rahul Sharma wrote: [snip] >>>> the PHY provider. >>>> >>> >>> Please correct me if I got you wrong. You want somthing like this:

[PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Rahul Sharma
On 16 May 2014 16:20, Tomasz Figa wrote: > On 16.05.2014 12:35, Rahul Sharma wrote: >> On 16 May 2014 15:12, Rahul Sharma wrote: >>> On 16 May 2014 03:14, Tomasz Figa wrote: >>>> On 15.05.2014 06:01, Rahul Sharma wrote: >> [snip] >>>>>> the

[PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-19 Thread Rahul Sharma
On 16 May 2014 20:19, Tomasz Figa wrote: > On 16.05.2014 16:30, Rahul Sharma wrote: >> On 16 May 2014 16:20, Tomasz Figa wrote: >>> On 16.05.2014 12:35, Rahul Sharma wrote: >>>> On 16 May 2014 15:12, Rahul Sharma wrote: >>>>> On 16 May 2014 03:14, T

[PATCH 2/5] drm/exynos: use regmap interface to set hdmiphy control bit in pmu

2014-05-19 Thread Rahul Sharma
On 11 April 2014 07:22, Rahul Sharma wrote: > Thanks Tomasz, > > This patch is not longer required after rebasing to Tomasz Stanislawski's > Simple Phy patches. > Hi All, We had further discussion on the "Simple Phy Driver" at http://www.spinics.net/lists/linux-

[PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-20 Thread Rahul Sharma
On 19 May 2014 16:24, Tomasz Figa wrote: > On 19.05.2014 09:10, Rahul Sharma wrote: >> On 16 May 2014 20:19, Tomasz Figa wrote: >>> On 16.05.2014 16:30, Rahul Sharma wrote: >>>> On 16 May 2014 16:20, Tomasz Figa wrote: >>>>> On 16.05.2014 12:35, Ra

[PATCH v2] drm/exynos: use regmap interface to set hdmiphy control bit in pmu

2014-05-20 Thread Rahul Sharma
driver is modified to control the phy enable bit inside PMU using regmap interfaces. Devicetree binding document for hdmi is also updated. Signed-off-by: Rahul Sharma --- V2: 1) Squashed hdmiphy clock cleanup patch. 2) Addressed comments related to indentation, using BIT macro while

[PATCH v2] drm/exynos: use regmap interface to set hdmiphy control bit in pmu

2014-05-21 Thread Rahul Sharma
Hi Inki, Tomasz, Any comment on this patch? Regards, Rahul Sharma On 20 May 2014 10:36, Rahul Sharma wrote: > Exynos drm hdmi driver used to get dummy hdmiphy clock to > control the PMU bit for hdmiphy. This bit needs to be set > before setting any resolution to hdmi hardware.

[PATCH] drm/exynos: use 4WORD dma burst length for small fbs

2014-05-22 Thread Rahul Sharma
Hi Inki, On 21 May 2014 16:43, Inki Dae wrote: > > Hi Rahul, > > On 2014? 05? 07? 20:25, Rahul Sharma wrote: >> From: Rahul Sharma >> >> In case of exynos, setting dma-burst to 16Word causes permanent >> tearing for very small buffers, e.g. cursor buffer. Bur

[PATCH] drm/exynos: allocate non-contigous buffers when iommu is enabled

2014-05-22 Thread Rahul Sharma
Hi Inki, The below fix doesn't affect the FB dev buffer allocation. IMO the scenario where u-boot allocates the buffer is not disturbed. Please review the implementation. Regards, Rahul Sharma. On 7 May 2014 17:21, Rahul Sharma wrote: > From: Rahul Sharma > > Allow to allocate

[PATCH] drm/exynos: allocate non-contigous buffers when iommu is enabled

2014-05-22 Thread Rahul Sharma
Thanks Sachin. On 22 May 2014 11:38, Sachin Kamat wrote: > Hi Rahul, > > On 7 May 2014 17:21, Rahul Sharma wrote: >> From: Rahul Sharma >> >> Allow to allocate non-contigous buffers when iommu is enabled. >> Currently, it tries to allocates contigous buffer whi

[PATCH V2] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-22 Thread Rahul Sharma
On 22 May 2014 11:51, Sachin Kamat wrote: > Hi Rahul, [snip] >> >> + clk_prepare_enable(ctx->bus_clk); > > Probably a check for its success? > >> + clk_prepare_enable(ctx->lcd_clk); > Generally we don't check this in any of the driver. I

[PATCH] drm/exynos: use 4WORD dma burst length for small fbs

2014-05-22 Thread Rahul Sharma
On 22 May 2014 12:25, Inki Dae wrote: > On 2014? 05? 22? 13:36, Rahul Sharma wrote: >> Hi Inki, >> >> On 21 May 2014 16:43, Inki Dae wrote: >>> >>> Hi Rahul, >>> >>> On 2014? 05? 07? 20:25, Rahul Sharma wrote: >>>> From: R

[PATCH V2] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-22 Thread Rahul Sharma
On 22 May 2014 13:33, Thierry Reding wrote: > On Thu, May 22, 2014 at 12:06:16PM +0530, Rahul Sharma wrote: >> On 22 May 2014 11:51, Sachin Kamat wrote: >> > Hi Rahul, >> [snip] >> >> >> >> + clk_prepare_enable(ctx->b

[PATCH 5/7] drm/exynos: add hdmiphy power on/off sequence

2014-05-22 Thread Rahul Sharma
Hi Inki, Please review this patch. Regards, Rahul Sharma On 3 April 2014 20:41, Rahul Sharma wrote: > From: Shirish S > > This patch implements the power on/off sequence > of HDMI PHY in exynos5420 and exynos5250 as provided > by the hardware team. > > This has been

[PATCH] drm/exynos: fix nested calls to lock mutex in drm resume

2014-05-22 Thread Rahul Sharma
Hi Inki, This is another one which has not got reviewed. Please review. Regards, Rahul Sharma On 30 April 2014 19:11, Rahul Sharma wrote: > From: Rahul Sharma > > While testing S2R on exynos board, system is hanging and > rebooting due to nested mutex_lock calls in exynos

[PATCH V2] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-22 Thread Rahul Sharma
From: Rahul Sharma Fimd probe is accessing fimd Registers without enabling the fimd gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled during kernel boottime, the system hangs during boottime. This issue got surfaced when verifying with sysmmu enabled. Probe of fimd Sysmmu

[PATCH v2] drm:exynos: allocate non-contigous buffer when iommu is enabled

2014-05-22 Thread Rahul Sharma
From: Rahul Sharma Allow to allocate non-contigous buffers when iommu is enabled. Currently, it tries to allocates contigous buffer which consistently fail for large buffers and then fall back to non contigous. Apart from being slow, this implementation is also very noisy and fills the screen

[PATCH v3] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-22 Thread Rahul Sharma
before accessing sysmmu regs and then disables. Later fimd probe tries to read the register without enabling the clock which is wrong and hangs the system. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 17 - 1 file changed, 16 insertions(+), 1

[PATCH] drm/exynos: fix nested calls to lock mutex in drm resume

2014-05-23 Thread Rahul Sharma
On 22 May 2014 23:26, Sachin Kamat wrote: > Hi Rahul, > > On 22 May 2014 19:46, Rahul Sharma wrote: >> Hi Inki, >> >> This is another one which has not got reviewed. Please review. > > Inki has applied a similar patch from Takashi [1]. Thanks Sachin, Good

[PATCH v4] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-23 Thread Rahul Sharma
ntime_get_sync should > be called as well, to wake up display pm domain. > You are right. I have added pm runtime get sync and put sync. Regards, Rahul Sharma. > > Regards > Andrzej > > >> >> } >> >

[PATCH v4] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-23 Thread Rahul Sharma
From: Rahul Sharma Fimd probe is accessing fimd Registers without enabling the fimd gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled during kernel boottime, the system hangs during boottime. This issue got surfaced when verifying with sysmmu enabled. Probe of fimd Sysmmu

[PATCH v5] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-23 Thread Rahul Sharma
From: Rahul Sharma Fimd probe is accessing fimd Registers without enabling the fimd gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled during kernel boottime, the system hangs during boottime. This issue got surfaced when verifying with sysmmu enabled. Probe of fimd Sysmmu

[PATCH v5] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-26 Thread Rahul Sharma
Hi Inki, Please review this patch. Regards, Rahul Sharma On 23 May 2014 17:17, Rahul Sharma wrote: > From: Rahul Sharma > > Fimd probe is accessing fimd Registers without enabling the fimd > gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled > during kerne

[PATCH v5] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-26 Thread Rahul Sharma
Hi Daniel, On 26 May 2014 13:11, Daniel Kurtz wrote: > On Mon, May 26, 2014 at 2:59 PM, Rahul Sharma > wrote: >> >> Hi Inki, >> >> Please review this patch. [snip] >> > + >> > + ret = clk_prepare_enable(ctx->lcd_clk); > > Hi Rahul,

[PATCH v5] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-27 Thread Rahul Sharma
On 26 May 2014 14:21, Rahul Sharma wrote: > Hi Daniel, > > On 26 May 2014 13:11, Daniel Kurtz wrote: >> On Mon, May 26, 2014 at 2:59 PM, Rahul Sharma >> wrote: >>> >>> Hi Inki, >>> >>> Please review this patch. > [snip] >>&g

[PATCH v5] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-28 Thread Rahul Sharma
, Rahul Sharma. On 27 May 2014 18:28, Inki Dae wrote: > On 2014? 05? 27? 18:55, Rahul Sharma wrote: >> >> >> On 26 May 2014 14:21, Rahul Sharma wrote: >>> Hi Daniel, >>> >>> On 26 May 2014 13:11, Daniel Kurtz wrote: >>>> On Mon,

[PATCH] drm/exynos: remove hardware overlays disable from fimd probe

2014-05-28 Thread Rahul Sharma
System hangs when FIMD registers are accessed to disable hardware overlays. This is because of the clocks which are not enabled before register access. 'Hardware overlay disable' is cleaned from the FIMD probe. Signed-off-by: Rahul Sharma --- Based on exynos-drm-next branch. drive

[PATCH 0/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-08-30 Thread Rahul Sharma
mp;hdmiphy_i2c_driver); > ... > } else { > ret = platform_driver_register(&hdmiphy_platform_driver); > ... > } > Here i2c_hdmiphy flag helps in avoiding registering both i2c and platform drivers for phy. But is it a

[PATCH 2/2] drm: exynos: compose and send avi and aui info frames

2012-11-21 Thread Rahul Sharma
Hi Seung Woo, Thanks for your inputs. Please find my response below. On Wed, Nov 21, 2012 at 2:12 PM, ??? wrote: > Hi Rahul, > > Control part seems good, and my comment is below. > > On 2012? 11? 10? 01:21, Rahul Sharma wrote: >> This patch adds code for composing AVI and A

[PATCH 2/2] drm: exynos: compose and send avi and aui info frames

2012-11-22 Thread Rahul Sharma
On Thu, Nov 22, 2012 at 12:06 PM, ??? wrote: > On 2012? 11? 21? 20:36, Rahul Sharma wrote: >> Hi Seung Woo, >> >> Thanks for your inputs. Please find my response below. >> >> On Wed, Nov 21, 2012 at 2:12 PM, ??? wrote: >>> Hi Rahul, >>> &

[PATCH] drm: exynos: hdmi: sending AVI and AUI info frames

2012-11-22 Thread Rahul Sharma
This patch adds code for composing AVI and AUI info frames and send them every VSYNC. This patch is important for hdmi certification. Based on exynos-drm-fixes branch of git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git Signed-off-by: Rahul Sharma Signed-off-by: Fahad

[PATCH 0/2] drm: exynos: hdmi: sending AVI and AUI info frames

2012-11-23 Thread Rahul Sharma
Thanks Thierry, It is good idea to use generic code. I would like to see your patches. regards, Rahul Sharma On Fri, Nov 23, 2012 at 11:45 AM, Inki Dae wrote: > > > 2012/11/10 Rahul Sharma >> >> This patch set adds provision for composing and sending AVI and AUI >&g

[PATCH] drm: exynos: hdmi: sending AVI and AUI info frames

2012-11-23 Thread Rahul Sharma
This patch adds code for composing AVI and AUI info frames and send them every VSYNC. This patch is important for hdmi certification. Signed-off-by: Rahul Sharma Signed-off-by: Fahad Kunnathadi Signed-off-by: Shirish S Based on exynos-drm-next branch of http://git.kernel.org/?p=linux/kernel

[PATCH] drm: exynos: hdmi: sending AVI and AUI info frames

2012-11-23 Thread Rahul Sharma
Hi Mr. Dae, On Fri, Nov 23, 2012 at 3:38 PM, Inki Dae wrote: > Sorry but could you re-send this one more time? below is my comment. > > Thanks, > Inki Dae > >> -Original Message- >> From: Rahul Sharma [mailto:rahul.sharma at samsung.com] >> Sent: Friday

[PATCH v2] drm: exynos: hdmi: sending AVI and AUI info frames

2012-11-23 Thread Rahul Sharma
x27;s Complement calculation for check sum. Signed-off-by: Rahul Sharma Signed-off-by: Fahad Kunnathadi Signed-off-by: Shirish S --- Based on exynos-drm-next branch of http://git.kernel.org/?p=linux/kernel/git/daeinki/drm-exynos.git drivers/gpu/drm/exynos/exynos_hdmi.c |

[PATCH v2] drm: exynos: hdmi: sending AVI and AUI info frames

2012-11-26 Thread Rahul Sharma
Hi Mr. Dae, On Sat, Nov 24, 2012 at 11:34 AM, Inki Dae wrote: > Let's update one more time. Below is my comments. > >> -Original Message----- >> From: Rahul Sharma [mailto:rahul.sharma at samsung.com] >> Sent: Friday, November 23, 2012 9:04 PM >> To: dri-d

[PATCH v3] drm: exynos: hdmi: sending AVI and AUI info frames

2012-11-26 Thread Rahul Sharma
x27;s Complement calculation for check sum. v3: - Moved enums, macros to exynos_hdmi.c. - Corrected hex format. - Added static to hdmi_reg_infoframe. Signed-off-by: Rahul Sharma Signed-off-by: Fahad Kunnathadi Signed-off-by: Shirish S --- Based on exynos-drm-next branch of http://git.kernel.o

[PATCH 0/3] drm/exynos: add runtime pm support for hdmi and mixer.

2012-11-28 Thread Rahul Sharma
Rahul Sharma (3): drm/exynos: added runtime pm support for hdmi drm/exynos: add runtime pm support for mixer drm/exynos: add support for hdmiphy power control for exynos5 drivers/gpu/drm/exynos/exynos_hdmi.c | 81 +--- drivers/gpu/drm/exynos/exynos_mixer.c

[PATCH 1/3] drm/exynos: added runtime pm support for hdmi

2012-11-28 Thread Rahul Sharma
This patch adds runtime power management support for exynos drm hdmi driver. Signed-off-by: Rahul Sharma Signed-off-by: Shirish S --- drivers/gpu/drm/exynos/exynos_hdmi.c | 60 + 1 files changed, 52 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 2/3] drm/exynos: add runtime pm support for mixer

2012-11-28 Thread Rahul Sharma
This patch adds support for runtime power management for drm mixer driver. Signed-off-by: Rahul Sharma Signed-off-by: Shirish S --- drivers/gpu/drm/exynos/exynos_mixer.c | 65 + 1 files changed, 58 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 3/3] drm/exynos: add support for hdmiphy power control for exynos5

2012-11-28 Thread Rahul Sharma
hence not added. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_hdmi.c | 21 + drivers/gpu/drm/exynos/regs-hdmi.h |5 + 2 files changed, 26 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos

[PATCH v1 01/14] media: s5p-hdmi: add HPD GPIO to platform data

2012-10-04 Thread Rahul Sharma
From: Tomasz Stanislawski This patch extends s5p-hdmi platform data by a GPIO identifier for Hot-Plug-Detection pin. Signed-off-by: Tomasz Stanislawski Signed-off-by: Kyungmin Park --- include/media/s5p_hdmi.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/m

[PATCH v1 05/14] drm: exynos: hdmi: turn off HPD interrupt in HDMI chip

2012-10-04 Thread Rahul Sharma
From: Tomasz Stanislawski The plug/unplug interrupt are handled by a separate interrupt. So there is no need to replicate this mechanism in HDMI core. Signed-off-by: Tomasz Stanislawski Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c |5 + 1 files changed, 1 inse

[PATCH v1 04/14] drm: exynos: hdmi: use s5p-hdmi platform data

2012-10-04 Thread Rahul Sharma
From: Tomasz Stanislawski The 'exynos-drm-hdmi' driver makes use of s5p-tv platform devices. Therefore the driver should use the same platform data to prevent crashes caused by dereferencing incorrect types. This patch corrects the exynos-drm-hdmi driver to the platform data from s5p-hdmi. Sign

[PATCH v1 10/14] drm: exynos: hdmi: add support to disable video processor in mixer

2012-10-04 Thread Rahul Sharma
This patch adds support for disabling the video processor code based on the platform type. This is done based on a field in the mixer driver data which changes with the platform variant. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_mixer.c | 151

[PATCH v1 13/14] drm: exynos: hdmi: add support for exynos5 hdmi

2012-10-04 Thread Rahul Sharma
This patch adds support for exynos5 hdmi with device tree enabled. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_hdmi.c | 83 -- 1 files changed, 79 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu

[PATCH v1 06/14] drm: exynos: remove drm hdmi platform data struct

2012-10-04 Thread Rahul Sharma
This patch removes the drm hdmi platform data structure which is no longer in use by drm hdmi driver after this patch set get merged. s5p hdmi platform data structure is used instead. Signed-off-by: Rahul Sharma --- include/drm/exynos_drm.h | 13 - 1 files changed, 0 insertions

[PATCH v1 08/14] drm: exynos: hdmi: add support for exynos5 hdmiphy

2012-10-04 Thread Rahul Sharma
This patch adds support for exynos5 hdmi phy with device tree enabled. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_hdmiphy.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmiphy.c b/drivers/gpu/drm/exynos

[PATCH v1 14/14] drm: exynos: hdmi: remove drm common hdmi platform data struct

2012-10-04 Thread Rahul Sharma
exynos-drm-hdmi need context pointers from hdmi and mixer. These pointers were expected from the plf data. Cleaned this dependency by exporting i/f which are called by hdmi, mixer driver probes for setting their context. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c

[PATCH v1 12/14] drm: exynos: hdmi: replace is_v13 with version check in hdmi

2012-10-04 Thread Rahul Sharma
This patch removed the is_v13 variable from the hdmi driver context. It is replaced with condition check for the hdmi version. This cleans the way for handling further hdmi versions. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_hdmi.c | 40

[PATCH v1 00/14] drm: exynos: hdmi: add dt based support for exynos5 hdmi

2012-10-04 Thread Rahul Sharma
et is based on branch exynos-drm-next at git://git.infradead.org/users/kmpark/linux-samsung (linux v3.6-rc4) v2: - removed MXR_VER_INVALID - moved layer update from vsync ISR to mixer_graph_buffer - stopped enabling vsync interrupt after poweron Rahul Sharma (9): drm: exynos: remove drm hdmi pla

  1   2   3   4   5   6   7   >