RE: [Intel-gfx] [PATCH] drm/i915/irq: Improve error logging for unexpected DE Misc interrupts

On Thursday, November 23rd, 2023 at 11:54 PM, Borah, Chaitanya Kumar wrote: > > -Original Message- > > From: Intel-gfx On Behalf Of Rahul > > Rameshbabu > > Sent: Thursday, November 23, 2023 11:27 PM > > To: intel-...@lists.freedesktop.org &g

[PATCH v2] drm/i915/irq: Improve error logging for unexpected DE Misc interrupts

Dump the iir value in hex when the interrupt is unexpected. Link: https://gitlab.freedesktop.org/drm/intel/-/issues/9652#note_2178501 Cc: Jani Nikula Signed-off-by: Rahul Rameshbabu Reviewed-by: Chaitanya Kumar Borah --- Notes: Changes: v1->v2: - Change format specif

Re: [PATCH RFC 0/3] Initial work for Rust abstraction for HID device driver development

On Thu, 13 Mar, 2025 17:31:53 +0100 "Benjamin Tissoires" wrote: > Hi, > > [quick reply because I am completely under the water for the next 2 > weeks] > > On Mar 13 2025, Rahul Rameshbabu wrote: >> Hello, >> >> I am a hobbyist developer who has been

Re: [PATCH RFC 3/3] rust: hid: demo the core abstractions for probe and remove

On Thu, 13 Mar, 2025 18:05:36 +0100 "Benjamin Tissoires" wrote: > On Mar 13 2025, Rahul Rameshbabu wrote: >> This is a very basic "hello, world!" implementation to illustrate that the >> probe and remove callbacks are working as expected. I chose an ar

Re: [PATCH RFC 1/3] rust: core abstractions for HID drivers

On Thu, 13 Mar, 2025 20:25:23 +0100 "Danilo Krummrich" wrote: > On Thu, Mar 13, 2025 at 04:03:35PM +, Rahul Rameshbabu wrote: >> These abstractions enable the development of HID drivers in Rust by binding >> with the HID core C API. They provide Rust types that map t

Re: [PATCH RFC 2/3] rust: hid: USB Monitor Control Class driver

hose macros. > > (In general, we try to use `Documentation/` for things that do not fit > as documentation for any of the code "items".) > > Cheers, > Miguel In general, I will add a lot more documentation in my next revision. For example, I have a bunch of unsafe usage right now without any SAFETY comments. Thanks for the review, Rahul Rameshbabu

Re: [PATCH RFC 1/3] rust: core abstractions for HID drivers

On Thu, 13 Mar, 2025 17:54:57 +0100 "Benjamin Tissoires" wrote: > On Mar 13 2025, Rahul Rameshbabu wrote: >> These abstractions enable the development of HID drivers in Rust by binding >> with the HID core C API. They provide Rust types that map to the >> equivale

[PATCH RFC 0/3] Initial work for Rust abstraction for HID device driver development

in and add more SAFETY comments. Thanks, Rahul Rameshbabu Rahul Rameshbabu (3): rust: core abstractions for HID drivers rust: hid: USB Monitor Control Class driver rust: hid: demo the core abstractions for probe and remove drivers/hid/Kconfig| 16 ++ drivers/hid/Makefile

[PATCH RFC 3/3] rust: hid: demo the core abstractions for probe and remove

uct: 29204 using Rust! [ +0.000108] monitor_control: Removing HID device vendor: 2389 product: 29204 using Rust! Signed-off-by: Rahul Rameshbabu --- drivers/hid/hid_monitor_control.rs | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid_monitor_control.rs

[PATCH RFC 1/3] rust: core abstractions for HID drivers

module_hid_driver! macro does not use Pin semantics for passing the ID_TABLE. I could not get Pin semantics to work in a const fn. I get a feeling this might be safe but need help reviewing this. Signed-off-by: Rahul Rameshbabu --- drivers/hid/Kconfig | 8 ++ rust/bindings

[PATCH RFC 2/3] rust: hid: USB Monitor Control Class driver

/linux_usb_monitor_control/ Link: https://www.usb.org/sites/default/files/usbmon11.pdf Signed-off-by: Rahul Rameshbabu --- drivers/hid/Kconfig| 8 +++ drivers/hid/Makefile | 1 + drivers/hid/hid_monitor_control.rs | 37 ++ 3 files