[next][PATCH 4/5] drm/radeon/kms: keep HDMI state in separated variable

2012-04-28 Thread Rafał Miłecki
If we want hdmi_offset to be relative to the first block, zero value can be used also for enabled block. Signed-off-by: Rafał Miłecki --- drivers/gpu/drm/radeon/r600_hdmi.c | 16 +--- drivers/gpu/drm/radeon/radeon_mode.h |1 + 2 files changed, 10 insertions(+), 7 deletions

[next][PATCH 5/5] drm/radeon/kms/hdmi: use relative offsets, official regs

2012-04-28 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki --- drivers/gpu/drm/radeon/r600.c | 28 ++-- drivers/gpu/drm/radeon/r600_hdmi.c | 90 +++- drivers/gpu/drm/radeon/r600_reg.h | 39 --- drivers/gpu/drm/radeon/r600d.h |7 ++- 4 files changed, 66

[next][PATCH 0/3] radeon HDMI: next minor improvements

2012-04-30 Thread Rafał Miłecki
set I sent yesterday. Again, tested on RV620 and HD6320. Unfortunately I don't have DCE32 card or sth to test code in r600_hdmi_enable/r600_hdmi_disable (pre DCE3). P.S. I'm leaving civilization for the rest of this week. Rafał Miłecki (3): drm/radeon/kms/hdmi: enable audio packets at

[next][PATCH 1/3] drm/radeon/kms/hdmi: enable audio packets at one place

2012-04-30 Thread Rafał Miłecki
--- drivers/gpu/drm/radeon/r600_hdmi.c | 26 -- 1 files changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c b/drivers/gpu/drm/radeon/r600_hdmi.c index c6de0022..69839df 100644 --- a/drivers/gpu/drm/radeon/r600_hdmi.c +++ b/drivers/

[next][PATCH 2/3] drm/radeon/kms/hdmi: clean&improve handling HDMI mode

2012-04-30 Thread Rafał Miłecki
--- drivers/gpu/drm/radeon/r600_hdmi.c | 42 +++ 1 files changed, 27 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c b/drivers/gpu/drm/radeon/r600_hdmi.c index 69839df..7d24753 100644 --- a/drivers/gpu/drm/radeon/r600_hdmi.c +++ b/

[next][PATCH 3/3] drm/radeon/kms/hdmi: helper getting ready ACR entry

2012-04-30 Thread Rafał Miłecki
--- drivers/gpu/drm/radeon/r600_hdmi.c | 61 drivers/gpu/drm/radeon/radeon.h| 14 2 files changed, 41 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c b/drivers/gpu/drm/radeon/r600_hdmi.c index 7d24753..0319619 1

[next][PATCH 0/3] drm/radeon/hdmi: separate Evergreen, update modesetting

2012-05-06 Thread Rafał Miłecki
This patch finally separates Evergreen code and applies changes published as WIP by Alex. Alex: I think we should add your Signed-o-b in PATCH 2, can you take a look at this? Rafał Miłecki (3): drm/radeon/hdmi: separate evergreen code drm/radeon/hdmi: update modesetting drm/radeon/hdmi

[next][PATCH 1/3] drm/radeon/hdmi: separate evergreen code

2012-05-06 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki --- drivers/gpu/drm/radeon/Makefile|5 +- drivers/gpu/drm/radeon/atombios_encoders.c |5 +- drivers/gpu/drm/radeon/evergreen_hdmi.c| 187 drivers/gpu/drm/radeon/r600_hdmi.c |9 +-- drivers/gpu/drm

[next][PATCH 2/3] drm/radeon/hdmi: update modesetting

2012-05-06 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki --- drivers/gpu/drm/radeon/evergreen_hdmi.c | 43 ++-- drivers/gpu/drm/radeon/r600_hdmi.c | 53 ++- 2 files changed, 70 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/radeon/evergreen_hdmi.c b

[next][PATCH 3/3] drm/radeon/hdmi: fix some coding style

2012-05-06 Thread Rafał Miłecki
Use defined macros by the way. Signed-off-by: Rafał Miłecki --- drivers/gpu/drm/radeon/r600_hdmi.c | 47 --- 1 files changed, 32 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c b/drivers/gpu/drm/radeon/r600_hdmi.c index 30e616a

[RFC][PATCH] drm/radeon/hdmi: define struct for AVI infoframe

2012-05-06 Thread Rafał Miłecki
--- drivers/gpu/drm/radeon/r600_hdmi.c | 81 ++- drivers/gpu/drm/radeon/radeon.h| 41 ++ 2 files changed, 55 insertions(+), 67 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c b/drivers/gpu/drm/radeon/r600_hdmi.c index c308432..

Re: [RFC][PATCH] drm/radeon/hdmi: define struct for AVI infoframe

2012-05-06 Thread Rafał Miłecki
2012/5/6 Rafał Miłecki : > diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c > b/drivers/gpu/drm/radeon/r600_hdmi.c > index c308432..b14c90a 100644 > --- a/drivers/gpu/drm/radeon/r600_hdmi.c > +++ b/drivers/gpu/drm/radeon/r600_hdmi.c > @@ -134,78 +134,22 @@ static void r600_hdmi_

Re: [RFC][PATCH] drm/radeon/hdmi: define struct for AVI infoframe

2012-05-06 Thread Rafał Miłecki
2012/5/6 Dave Airlie : > On Sun, May 6, 2012 at 5:19 PM, Rafał Miłecki wrote: >> 2012/5/6 Rafał Miłecki : >>> diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c >>> b/drivers/gpu/drm/radeon/r600_hdmi.c >>> index c308432..b14c90a 100644 >>> --- a/drivers

Re: [RFC][PATCH] drm/radeon/hdmi: define struct for AVI infoframe

2012-05-06 Thread Rafał Miłecki
2012/5/6 Daniel Vetter : > On Sun, May 06, 2012 at 05:22:59PM +0100, Dave Airlie wrote: >> On Sun, May 6, 2012 at 5:19 PM, Rafał Miłecki wrote: >> > 2012/5/6 Rafał Miłecki : >> >> diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c >> >> b/drivers/gpu/

[PATCH 1/2] drm/radeon/hdmi: store info about all AFMT blocks

2012-05-14 Thread Rafał Miłecki
From: Alex Deucher Introduce special struct radeon_afmt for this purpose. Signed-off-by: Alex Deucher Signed-off-by: Rafał Miłecki --- drivers/gpu/drm/radeon/r600_reg.h |6 ++ drivers/gpu/drm/radeon/r600d.h |6 -- drivers/gpu/drm/radeon/radeon_asic.h|1

[PATCH 2/2] drm/radeon/hdmi: use new AFMT structs

2012-05-14 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki --- drivers/gpu/drm/radeon/atombios_encoders.c | 11 ++- drivers/gpu/drm/radeon/evergreen_hdmi.c| 16 ++- drivers/gpu/drm/radeon/r600_audio.c| 25 + drivers/gpu/drm/radeon/r600_hdmi.c | 151 +++- drivers/gpu/drm

[PATCH] drm/radeon/hdmi: compile audio status in 1 function

2012-05-14 Thread Rafał Miłecki
This optmizes calls, registers reads and assignments. Signed-off-by: Rafał Miłecki --- This should be applied on top of: [PATCH 1/2] drm/radeon/hdmi: store info about all AFMT blocks [PATCH 2/2] drm/radeon/hdmi: use new AFMT structs --- drivers/gpu/drm/radeon/r600_audio.c | 133

Re: [next][PATCH 2/3] drm/radeon/hdmi: update modesetting

2012-05-26 Thread Rafał Miłecki
2012/5/6 Rafał Miłecki : > +               WREG32(HDMI0_AUDIO_PACKET_CONTROL + offset, > +                      HDMI0_AUDIO_SAMPLE_SEND | /* send audio packets */ > +                      HDMI0_AUDIO_DELAY_EN(1) | /* default audio delay */ > +                      HDMI0_AUDIO_SEND

Re: [next][PATCH 2/3] drm/radeon/hdmi: update modesetting

2012-05-26 Thread Rafał Miłecki
2012/5/26 Rafał Miłecki : > 2012/5/6 Rafał Miłecki : >> +               WREG32(HDMI0_AUDIO_PACKET_CONTROL + offset, >> +                      HDMI0_AUDIO_SAMPLE_SEND | /* send audio packets */ >> +                      HDMI0_AUDIO_DELAY_EN(1) | /

Re: [next][PATCH 2/3] drm/radeon/hdmi: update modesetting

2012-05-26 Thread Rafał Miłecki
2012/5/26 Rafał Miłecki : > 2012/5/26 Rafał Miłecki : >> 2012/5/6 Rafał Miłecki : >>> +               WREG32(HDMI0_AUDIO_PACKET_CONTROL + offset, >>> +                      HDMI0_AUDIO_SAMPLE_SEND | /* send audio packets */ >>> +                      HDMI0_

Re: [next][PATCH 2/3] drm/radeon/hdmi: update modesetting

2012-05-27 Thread Rafał Miłecki
2012/5/27 Alex Deucher : > On Sat, May 26, 2012 at 5:40 PM, Rafał Miłecki wrote: >> 2012/5/26 Rafał Miłecki : >>> 2012/5/26 Rafał Miłecki : >>>> 2012/5/6 Rafał Miłecki : >>>>> +               WREG32(HDMI0_AUDIO_PACKET_CONTROL + offset, >>

Re: [PATCH] drm: Add downclock quirk for Samsung LTN121AT10-301

2012-05-29 Thread Rafał Miłecki
2012/5/30 Sean Paul : > On Tue, May 29, 2012 at 5:23 PM, Alex Deucher wrote: >> On Tue, May 29, 2012 at 4:33 PM, Sean Paul wrote: >>> On Tue, May 29, 2012 at 10:43 AM, Alex Deucher >>> wrote: On Mon, May 28, 2012 at 1:20 PM, Sean Paul wrote: > On Wed, Jan 18, 2012 at 10:06 AM, Sean Pa

[FIX][STABLE 3.3+][PATCH] drm/radeon/audio: don't hardcode CRTC id

2012-06-04 Thread Rafał Miłecki
This is based on info released by AMD, should allow using audio in much more cases. Signed-off-by: Rafał Miłecki Cc: --- drivers/gpu/drm/radeon/r600_audio.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_audio.c b/drivers/gpu/drm

[drm-fixes][PATCH 3.5] drm/radeon/hdmi: don't set SEND_MAX_PACKETS bit

2012-06-04 Thread Rafał Miłecki
t bit in any of the above cases. This fixes a regression introduced by 3.5-rc1. Signed-off-by: Rafał Miłecki --- drivers/gpu/drm/radeon/r600_hdmi.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c b/drivers/gpu/drm/radeon/r600_hdmi.

Re: [PATCH] drm/radeon: make audio_init consistent across asics

2012-06-05 Thread Rafał Miłecki
2012/6/4 : > From: Alex Deucher > > Call it in the asic startup callback on all asics. > Previously r600 and rv770 called it in the startup > and resume callbacks while all the other asics called > it in the startup callback. Reviewed-by: Rafał M

Re: [FIX][STABLE 3.3+][PATCH] drm/radeon/audio: don't hardcode CRTC id

2012-06-05 Thread Rafał Miłecki
2012/6/5 Christian König : > On 04.06.2012 18:49, Alex Deucher wrote: >> >> On Mon, Jun 4, 2012 at 12:36 PM, Rafał Miłecki  wrote: >>> >>> This is based on info released by AMD, should allow using audio in much >>> more cases. >>> >>>

[PATCH][drm-fixes?] drm/radeon: enable HDMI on DCE5 (AKA NI excluding Aruba)

2012-06-10 Thread Rafał Miłecki
After recent changes HDMI code is ready to be enabled on DCE5. This patch just changes conditions to execute already present code on DCE5. Signed-off-by: Rafał Miłecki --- Dave: I know it's common to accept patches adding IDs even while merge window's closed. Is this OK for you to

Re: [PATCH][drm-fixes?] drm/radeon: enable HDMI on DCE5 (AKA NI excluding Aruba)

2012-06-10 Thread Rafał Miłecki
2012/6/10 Rafał Miłecki : > After recent changes HDMI code is ready to be enabled on DCE5. This > patch just changes conditions to execute already present code on DCE5. > > Signed-off-by: Rafał Miłecki > --- > Dave: I know it's common to accept patches adding IDs even

Re: [PATCH][drm-fixes?] drm/radeon: enable HDMI on DCE5 (AKA NI excluding Aruba)

2012-06-10 Thread Rafał Miłecki
2012/6/10 Christian König : > On 10.06.2012 21:22, Alex Deucher wrote: >> >> On Sun, Jun 10, 2012 at 11:59 AM, Rafał Miłecki  wrote: >>> >>> After recent changes HDMI code is ready to be enabled on DCE5. This >>> patch just changes conditions to execute al

Re: [PATCH][drm-fixes?] drm/radeon: enable HDMI on DCE5 (AKA NI excluding Aruba)

2012-06-11 Thread Rafał Miłecki
2012/6/11 Rafał Miłecki : > 2012/6/10 Christian König : >> Unfortunately testing it with my Cayman based card shows that it plays with >> the correct speed, audio registers seems to be ok, but unfortunately I don't >> hear any sound at all :( > > If you can easily

[RFT][PATCH] drm/radeon/hdmi: enable audio on Cayman

2012-06-11 Thread Rafał Miłecki
--- drivers/gpu/drm/radeon/ni.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/radeon/ni.c b/drivers/gpu/drm/radeon/ni.c index 3df4efa..b65fcae 100644 --- a/drivers/gpu/drm/radeon/ni.c +++ b/drivers/gpu/drm/radeon/ni.c @@ -1290,6 +1290,10 @@ static int

[PATCH V2][drm-fixes?] drm/radeon: enable HDMI on DCE5 (AKA NI excluding Aruba)

2012-06-11 Thread Rafał Miłecki
After recent changes HDMI code is ready to be enabled on DCE5. This patch just changes conditions to execute already present code on DCE5. Signed-off-by: Rafał Miłecki Reviewed-by: Alex Deucher --- V2: enable audio engine on Cayman (it uses different startup function). --- drivers/gpu/drm

No screens after (WW) Falling back to old probe method for modesetting

2012-06-11 Thread Rafał Miłecki
I'm trying to switch from fbdev to modesetting for my AMD Southern Islands VERDE card. Of course I've KMS running just fine, radeon module loads and sets correct resolution, dmesg looks alright Unfortunately Xorg doesn't start after forcing "modesetting", AFAIU the driver doesn't provide any scree

Re: No screens after (WW) Falling back to old probe method for modesetting

2012-06-11 Thread Rafał Miłecki
2012/6/11 Rafał Miłecki : > I'm trying to switch from fbdev to modesetting for my AMD Southern > Islands VERDE card. Of course I've KMS running just fine, radeon > module loads and sets correct resolution, dmesg looks alright > > Unfortunately Xorg doesn't start afte

Re: No screens after (WW) Falling back to old probe method for modesetting

2012-06-12 Thread Rafał Miłecki
2012/6/12 David Airlie : > - Original Message - >> From: "Rafał Miłecki" >> To: xorg-de...@lists.x.org, "dri-devel" , >> "Dave Airlie" >> Cc: "Alex Deucher" >> Sent: Monday, 11 June, 2012 8:55:56 PM &

Re: No screens after (WW) Falling back to old probe method for modesetting

2012-06-12 Thread Rafał Miłecki
2012/6/11 Rafał Miłecki : > I'm trying to switch from fbdev to modesetting for my AMD Southern > Islands VERDE card. Of course I've KMS running just fine, radeon > module loads and sets correct resolution, dmesg looks alright > > Unfortunately Xorg doesn't start afte

Re: No screens after (WW) Falling back to old probe method for modesetting

2012-06-12 Thread Rafał Miłecki
2012/6/12 Rafał Miłecki : > 2012/6/11 Rafał Miłecki : >> I'm trying to switch from fbdev to modesetting for my AMD Southern >> Islands VERDE card. Of course I've KMS running just fine, radeon >> module loads and sets correct resolution, dmesg looks alright >>

Re: [PATCH 00/10] Start documenting the radeon drm better

2012-06-29 Thread Rafał Miłecki
2012/6/29 : > From: Alex Deucher > > This is something I've been wanting to do for a while and > I finally spent a little time getting a start on it.  There > is still a lot to do and not all of my descriptions are great, > but I think we can document the rest in bits and pieces. I > also added a

Re: nouveau shuts the machine down with v3.9-rc1 (temperature (72 C) hit the 'shutdown' threshold).

2013-03-22 Thread Rafał Miłecki
2013/3/15 Martin Peres > As a follow up, Konrad sent me in private his vbios and the issue turned out > to be trivial. > The reason why it behaved this way was that his vbios didn't have sensor > calibration values. > The fix is available here: > http://gitorious.org/linux-nouveau-pm/linux-nouv

Is there IGP DCE5?

2013-04-06 Thread Rafał Miłecki
I was surprised that my BARTS in a Samsung notebook doesn't have a RADEON_IS_IGP flag. Are there any DCE5 devices that are IGP? Btw. who does set that "flags" anyway? Flags are passed to the radeon_driver_load_kms function from drm_pci.c: dev->driver->load(dev, ent->driver_data); (so driver_data

[RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Rafał Miłecki
Some devices (ATI/AMD cards) don't want passing ELD struct to the hardware but just require filling specific registers and then hardware/firmware does the rest. In such a cases we need to read info from SAD blocks and put them in the correct registers. --- drivers/gpu/drm/drm_edid.c | 55 +++

Re: [RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Rafał Miłecki
2013/4/7 Boszormenyi Zoltan : > will there be a followup patch where this function is actually used? Sure :) It's just early patch post, with RFC, to see if I'm doing it the right way. -- Rafał ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Rafał Miłecki
2013/4/7 Rafał Miłecki : > Some devices (ATI/AMD cards) don't want passing ELD struct to the > hardware but just require filling specific registers and then > hardware/firmware does the rest. In such a cases we need to read info > from SAD blocks and put them in the correct regist

Re: [RFC][PATCH] drm: add helper extracting SADs from EDID

2013-04-07 Thread Rafał Miłecki
Thanks for comments! 2013/4/7 Paul Menzel : > Am Sonntag, den 07.04.2013, 12:52 +0200 schrieb Rafał Miłecki: >> +struct cea_sad *drm_edid_to_sad(struct edid *edid) >> +{ >> + struct cea_sad *sads = NULL; > > No need to set it NULL, as it gets assigned later on? Lo

[RFC][PATCH] drm/radeon: add helpers for masking and setting bits in regs

2013-04-07 Thread Rafał Miłecki
--- drivers/gpu/drm/radeon/r600_hdmi.c | 16 ++-- drivers/gpu/drm/radeon/radeon.h|2 ++ 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c b/drivers/gpu/drm/radeon/r600_hdmi.c index 21ecc0e..91582a5 100644 --- a/drivers/gpu/drm

[RFC][PATCH V2 1/2] drm: add drm_edid_to_eld helper extracting SADs from EDID

2013-04-07 Thread Rafał Miłecki
Some devices (ATI/AMD cards) don't support passing ELD struct to the hardware but just require filling specific registers and then the hardware/firmware does the rest. In such cases we need to read the info from SAD blocks and put them in the correct registers. --- V2: fix commit message return

[PROOF][TESTING ONLY][PATCH 2/2] drm/radeon/evergreen: set ELD registers

2013-04-07 Thread Rafał Miłecki
--- drivers/gpu/drm/radeon/evergreen_hdmi.c | 63 +++ 1 file changed, 63 insertions(+) diff --git a/drivers/gpu/drm/radeon/evergreen_hdmi.c b/drivers/gpu/drm/radeon/evergreen_hdmi.c index ed46dad..81db8b9 100644 --- a/drivers/gpu/drm/radeon/evergreen_hdmi.c +++ b/dr

Re: [RFC][PATCH V2 1/2] drm: add drm_edid_to_eld helper extracting SADs from EDID

2013-04-08 Thread Rafał Miłecki
2013/4/8 Ville Syrjälä : >> + *sads = kzalloc(count * sizeof(*sads), GFP_KERNEL); > > Still looks a bit wrong. > > kcalloc(count, sizeof(**sads), GFP_KERNEL); > > Also a minor nit, but the scope of some variables is needlessly large. > db and dbl are only needed inside the outer

[PATCH 0/6] drm/radeon: minor HDMI improvements

2013-04-13 Thread Rafał Miłecki
5) No regressions noticed, I can still play audio, including LPCM, AC3 and DTS. Unfortunately I don't have any DCE4 hardware to test this, but that changes shouldn't cause any regressions. I hope that with such improvements we will finally able to enable audio by default. Rafał Miłecki (6):

[PATCH 1/6] drm/radeon: add helpers for masking and setting bits in regs

2013-04-13 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki Reviewed-by: Michel Dänzer --- drivers/gpu/drm/radeon/r600_hdmi.c | 16 ++-- drivers/gpu/drm/radeon/radeon.h|2 ++ 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600_hdmi.c b/drivers/gpu/drm/radeon

[PATCH 2/6] drm/radeon: remove HDMI interrupts on Evergreen

2013-04-13 Thread Rafał Miłecki
We need interrupts on format change for R6xx only, where hardware seems to be somehow bugged and requires setting audio info manually. Signed-off-by: Rafał Miłecki --- drivers/gpu/drm/radeon/evergreen.c | 127 +--- 1 file changed, 1 insertion(+), 126 deletions

[PATCH 3/6] drm/radeon: add some HDMI comments

2013-04-13 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki --- drivers/gpu/drm/radeon/evergreen_hdmi.c | 14 ++ drivers/gpu/drm/radeon/radeon_display.c |5 + 2 files changed, 19 insertions(+) diff --git a/drivers/gpu/drm/radeon/evergreen_hdmi.c b/drivers/gpu/drm/radeon/evergreen_hdmi.c index 4fdecc2

[PATCH 4/6] drm/radeon/evergreen: setup HDMI before enabling it

2013-04-13 Thread Rafał Miłecki
Closed source driver fglrx seems to enable infoframes and audio packets at the end, which makes sense, do the same. Signed-off-by: Rafał Miłecki --- drivers/gpu/drm/radeon/evergreen_hdmi.c | 15 +++ drivers/gpu/drm/radeon/evergreend.h |1 + 2 files changed, 12 insertions

[PATCH 5/6] drm/radeon/evergreen: reorder HDMI setup

2013-04-13 Thread Rafał Miłecki
Driver fglrx setups audio and ACR packets after basic initialization, which sounds sane, do the same. Signed-off-by: Rafał Miłecki --- drivers/gpu/drm/radeon/evergreen_hdmi.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 6/6] drm/radeon/evergreen: write default channel numbers

2013-04-13 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki --- drivers/gpu/drm/radeon/evergreen_hdmi.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/radeon/evergreen_hdmi.c b/drivers/gpu/drm/radeon/evergreen_hdmi.c index 24d13ac..ed46dad 100644 --- a/drivers/gpu/drm/radeon

Re: [PATCH 2/6] drm/radeon: remove HDMI interrupts on Evergreen

2013-04-14 Thread Rafał Miłecki
2013/4/14 Paul Menzel : > Am Sonntag, den 14.04.2013, 01:26 +0200 schrieb Rafał Miłecki: >> We need interrupts on format change for R6xx only, where hardware seems >> to be somehow bugged and requires setting audio info manually. > > How should this be tested? Just play some

Re: [PATCH 4/6] drm/radeon/evergreen: setup HDMI before enabling it

2013-04-14 Thread Rafał Miłecki
2013/4/14 Paul Menzel : > Am Sonntag, den 14.04.2013, 01:26 +0200 schrieb Rafał Miłecki: >> Closed source driver fglrx seems to enable infoframes and audio packets >> at the end, which makes sense, do the same. > > Any functionality change? Does not sound like it, but being un

Re: [PATCH 3/6] drm/radeon: add some HDMI comments

2013-04-14 Thread Rafał Miłecki
2013/4/14 Paul Menzel : > Am Sonntag, den 14.04.2013, 01:26 +0200 schrieb Rafał Miłecki: > > Maybe for a more descriptive summary: > > drm/radeon: Add some HDMI (audio) comments about fglrx’ reg reads I also comment sth in radeon_displa

[PATCH V2 3/6] drm/radeon: add some HDMI audio comments

2013-04-14 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki --- V2: fix typo and add extra \n --- drivers/gpu/drm/radeon/evergreen_hdmi.c | 14 ++ drivers/gpu/drm/radeon/radeon_display.c |6 ++ 2 files changed, 20 insertions(+) diff --git a/drivers/gpu/drm/radeon/evergreen_hdmi.c b/drivers/gpu/drm

Re: [PATCH 5/6] drm/radeon/evergreen: reorder HDMI setup

2013-04-14 Thread Rafał Miłecki
2013/4/14 Paul Menzel : > Am Sonntag, den 14.04.2013, 01:26 +0200 schrieb Rafał Miłecki: > > Maybe use the following for a more descriptive summary: > > drm/radeon/evergreen: Set up audio and ACR packets after basic init That extra message you can see in my patch: > Driver fglr

[PATCH V2 5/6] drm/radeon/evergreen: reorder HDMI setup

2013-04-14 Thread Rafał Miłecki
Driver fglrx setups audio and ACR packets after basic initialization, which sounds sane, do the same. Signed-off-by: Rafał Miłecki --- V2: typo in "sufficient" --- drivers/gpu/drm/radeon/evergreen_hdmi.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletion

Re: [PATCH 2/6] drm/radeon: remove HDMI interrupts on Evergreen

2013-04-14 Thread Rafał Miłecki
2013/4/14 Alex Deucher : > On Sat, Apr 13, 2013 at 7:26 PM, Rafał Miłecki wrote: >> We need interrupts on format change for R6xx only, where hardware seems >> to be somehow bugged and requires setting audio info manually. > > Can you confirm that this is actually needed o

Re: [PATCH 3/6] drm/radeon: add some HDMI comments

2013-04-14 Thread Rafał Miłecki
2013/4/14 Alex Deucher : >> + /* >> +* According to the commens above we should use !DCE41 || >> DCE5, >> +* condition, however there isn't any DCE5 that is DCE41, so >> +* DCE5 check is not needed. >> +*/ > > It would p

Re: [PATCH 2/6] drm/radeon: remove HDMI interrupts on Evergreen

2013-04-14 Thread Rafał Miłecki
2013/4/14 Alex Deucher : > On Sun, Apr 14, 2013 at 11:55 AM, Rafał Miłecki wrote: >> 2013/4/14 Alex Deucher : >>> On Sat, Apr 13, 2013 at 7:26 PM, Rafał Miłecki wrote: >>>> We need interrupts on format change for R6xx only, where hardware seems >>>>

Re: [PATCH 2/6] drm/radeon: remove HDMI interrupts on Evergreen

2013-04-15 Thread Rafał Miłecki
2013/4/15 Alex Deucher : > On Mon, Apr 15, 2013 at 4:08 AM, Christian König > wrote: >> Am 14.04.2013 20:02, schrieb Rafał Miłecki: >> >>> 2013/4/14 Alex Deucher : >>>> >>>> On Sun, Apr 14, 2013 at 11:55 AM, Rafał Miłecki wrote: >>>&g

Re: [PATCH 0/6] drm/radeon: minor HDMI improvements

2013-04-18 Thread Rafał Miłecki
2013/4/18 Alex Deucher : > On Sat, Apr 13, 2013 at 7:26 PM, Rafał Miłecki wrote: >> I've managed to track fglrx operations on HDMI regs, so we can finally setup >> everything in (hopefully) the correct way and order. >> >> This changes HDMI setup on Evergreen to m

Re: [PATCH 2/3] drm/radeon: clean up audio dto programming

2013-04-18 Thread Rafał Miłecki
2013/4/18 : > - switch (radeon_encoder->encoder_id) { > - case ENCODER_OBJECT_ID_INTERNAL_KLDSCP_TMDS1: > - case ENCODER_OBJECT_ID_INTERNAL_LVTM1: > - WREG32_P(R600_AUDIO_TIMING, 0, ~0x301); > - break; > - case ENCODER_OBJECT_ID_INTERNAL_UNIPHY:

Re: [PATCH 1/3] drm/radeon: clean up audio supported check

2013-04-18 Thread Rafał Miłecki
2013/4/18 : > From: Alex Deucher > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/radeon/r600_audio.c |5 + > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/r600_audio.c > b/drivers/gpu/drm/radeon/r600_audio.c > index cb03fe2..72561e4 10

[PATCH 1/2] drm: add drm_edid_to_eld helper extracting SADs from EDID

2013-04-19 Thread Rafał Miłecki
Some devices (ATI/AMD cards) don't support passing ELD struct to the hardware but just require filling specific registers and then the hardware/firmware does the rest. In such cases we need to read the info from SAD blocks and put them in the correct registers. Signed-off-by: Rafał Mi

[PATCH 2/2] drm/radeon/evergreen: set SAD registers

2013-04-19 Thread Rafał Miłecki
This allows audio (alsa) driver to read them and have a clue about audio capabilities of connected receiver. This has been verified to be compatible with fglrx behaviour for Onkyo TX-SR605 and Denon 1912. Signed-off-by: Rafał Miłecki --- drivers/gpu/drm/radeon/evergreen_hdmi.c | 63

Re: [PATCH 2/6] drm/radeon: remove HDMI interrupts on Evergreen

2013-04-21 Thread Rafał Miłecki
2013/4/14 Alex Deucher : > On Sat, Apr 13, 2013 at 7:26 PM, Rafał Miłecki wrote: >> We need interrupts on format change for R6xx only, where hardware seems >> to be somehow bugged and requires setting audio info manually. > > Can you confirm that this is actually needed o

Re: [PATCH 2/6] drm/radeon: remove HDMI interrupts on Evergreen

2013-04-21 Thread Rafał Miłecki
2013/4/21 Rafał Miłecki : > 2013/4/14 Alex Deucher : >> On Sat, Apr 13, 2013 at 7:26 PM, Rafał Miłecki wrote: >>> We need interrupts on format change for R6xx only, where hardware seems >>> to be somehow bugged and requires setting audio info manually. >> >>

Re: [PATCH 2/6] drm/radeon: remove HDMI interrupts on Evergreen

2013-04-21 Thread Rafał Miłecki
2013/4/21 Alex Deucher : > On Sun, Apr 21, 2013 at 3:15 PM, Rafał Miłecki wrote: >> 2013/4/21 Rafał Miłecki : >>> 2013/4/14 Alex Deucher : >>>> On Sat, Apr 13, 2013 at 7:26 PM, Rafał Miłecki wrote: >>>>> We need interrupts on format change for R6xx o

Re: [PATCH 3/3] drm/radeon: switch audio handling to use callbacks

2013-04-21 Thread Rafał Miłecki
2013/4/18 : > From: Alex Deucher > > Register audio callbacks for asic where we support > audio. Cleans up the code and makes it easier to > add support for newer asics. Ack -- Rafał ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://

Re: [PATCH 2/3] drm/radeon: clean up audio dto programming

2013-04-21 Thread Rafał Miłecki
2013/4/19 Alex Deucher : > On Fri, Apr 19, 2013 at 2:10 AM, Rafał Miłecki wrote: >> 2013/4/18 : >>> - switch (radeon_encoder->encoder_id) { >>> - case ENCODER_OBJECT_ID_INTERNAL_KLDSCP_TMDS1: >>> - case ENCODER_OBJECT_ID_INTER

Re: drm_edid_to_sad: (drm-next-3.10) compiler warnings

2013-04-21 Thread Rafał Miłecki
2013/4/22 Dieter Nützel : > CC [M] drivers/gpu/drm/drm_edid.o > drivers/gpu/drm/drm_edid.c: In Funktion »drm_edid_to_sad«: > drivers/gpu/drm/drm_edid.c:2550:4: Warnung: ISO-C90 verbietet gemischte > Deklarationen und Code [-Wdeclaration-after-statement] I'm glad you're not using Chinese LANG... ;

[PATCH] drm: drm_edid_to_sad: fix declaration warning

2013-04-21 Thread Rafał Miłecki
CC [M] drivers/gpu/drm/drm_edid.o drivers/gpu/drm/drm_edid.c: In function ‘drm_edid_to_sad’: drivers/gpu/drm/drm_edid.c:2549:4: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] Reported-by: Dieter Nützel Signed-off-by: Rafał Miłecki --- drivers/gpu/drm

Re: [PATCH 2/3] drm/radeon: clean up audio dto programming

2013-04-21 Thread Rafał Miłecki
2013/4/19 Alex Deucher : > On Fri, Apr 19, 2013 at 2:10 AM, Rafał Miłecki wrote: >> 2013/4/18 : >>> - switch (radeon_encoder->encoder_id) { >>> - case ENCODER_OBJECT_ID_INTERNAL_KLDSCP_TMDS1: >>> - case ENCODER_OBJECT_ID_INTER

Re: [PATCH 1/2] drm: add drm_edid_to_eld helper extracting SADs from EDID

2013-04-22 Thread Rafał Miłecki
2013/4/22 Christian König : > Found one more minor nitpick in this patch: > > >> + if (cea_db_tag(db) == AUDIO_BLOCK) { >> + dbl = cea_db_payload_len(db); >> + int j; >> + > > > That's code after declaration and so complained on by the compi

Re: [PATCH] drm/radeon: fix AVI infoframe generation

2013-06-08 Thread Rafał Miłecki
2013/6/7 : > From: Alex Deucher > > - remove adding 2 to checksum, this breaks certain monitors > - properly emit the AVI infoframe version, not emitting > the version breaks some monitors. > > This should fix blank screen when HDMI audio is enabled on > certain monitors. Err, nack. I believe th

Re: [PATCH] drm/radeon: fix AVI infoframe generation

2013-06-27 Thread Rafał Miłecki
2013/6/10 Alex Deucher : > On Sat, Jun 8, 2013 at 7:46 AM, Rafał Miłecki wrote: >> 2013/6/7 : >>> From: Alex Deucher >>> >>> - remove adding 2 to checksum, this breaks certain monitors >>> - properly emit the AVI infoframe version, not emitting >&

Re: [PATCH] bugfix and cleanup patches in the TTM code for 3.1.

2011-06-08 Thread Rafał Miłecki
Hi Konrad, 2011/6/8 Konrad Rzeszutek Wilk : > The bug-fix "ttm: Do not increment the amount of pages in a pool by the > current amount" > I never observed, but found while looking at the code. The cleanup patch: > "ttm: Fix spelling mistakes and remove unused #ifdef", I had posted earlier > and

Re: [PATCH] drm/radeon/kms: fix regression in hotplug

2011-07-11 Thread Rafał Miłecki
2011/7/11 Alex Deucher : > Skip connectors that do not have an HPD pin. > > Should fix: > https://bugs.freedesktop.org/show_bug.cgi?id=39027 > > Signed-off-by: Alex Deucher Tested-by: Rafał Miłecki Fixes the regression. -- Rafał ___

Re: [Feature request] Multiple X servers on one graphics card?

2011-08-02 Thread Rafał Miłecki
2011/8/2 Alan Cox : >> But I believe this is a problem of all approaches which provide >> multiple hardware-accelerated (or Xv-enabled) seats on a single GPU, >> no matter if based on multiple DRM devices, on Xephyr or Xnest >> with some kind of OpenGL or DRI passthrough, or on Wayland: >> If one h

Re: [PATCH] vgaarb: use bridges to control VGA routing where possible.

2010-12-16 Thread Rafał Miłecki
2010/12/16 Mark Marshall : > On 16/12/2010 05:54, Dave Airlie wrote: >> >> From: Dave Airlie >>  int pci_set_vga_state(struct pci_dev *dev, bool decode, >> -                     unsigned int command_bits, bool change_bridge) >> +                     unsigned int command_bits, u32 flags) >>  { >>  

Re: [PATCH] drm/radeon/kms: only enable underscan by default if the monitor supports audio

2010-12-17 Thread Rafał Miłecki
2010/12/17 Alex Deucher : > Users with TVs or monitors that don't overscan by default would prefer > to not have underscan enabled, while users with overscanning TVs prefer > underscan.  This should hopefully make everyone happy as most monitors > with audio tend to be TVs which overscan by default

Re: [PATCH] drm/radeon/kms: reorder display resume to avoid problems

2010-12-20 Thread Rafał Miłecki
2010/12/20 Alex Deucher : > On resume, we were attemping to unblank the displays before the > timing and plls had be reprogrammed which led to atom timeouts > waiting for things that are not yet programmed.  Re-program > the mode first, then reset the dpms state. > > This fixes the infamous atombio

Re: [PATCH] drm/radeon/kms: disable underscan by default

2011-01-09 Thread Rafał Miłecki
2011/1/5 Alex Deucher : > Lots of HDMI TVs overscan the incoming image by default. > The underscan option was added as a way to compensate for > that by underscanning the image so that the edges would > not be cut off on an overscanning TV.  However, the TV > provides no way of knowing whether it i

Re: [git pull] drm fixes

2011-02-18 Thread Rafał Miłecki
2011/2/18 Anca Emanuel : > Nouveau OpenGL regresion > > Tools used: http://packages.ubuntu.com/maverick/misc/glmark2 > > With 2.6.38-rc5 latest git: > nv50_screen_get_param:162 -  Unknown PIPE_CAP 11 > === >    glmark2 10.07.1 > ==

Re: [PATCH] drm radeon: Return -EINVAL on wrong pm sysfs access

2011-03-26 Thread Rafał Miłecki
2011/3/23 Thomas Renninger : > drm radeon: Return -EINVAL on wrong pm sysfs access > > Throw an error if someone tries to fill this with > wrong data, instead of simply ignoring the input. > Now you get: > > echo hello >/sys/../power_method > -bash: echo: write error: Invalid argument > > Signed-of

Re: [PATCH] drm radeon: Return -EINVAL on wrong pm sysfs access

2011-03-26 Thread Rafał Miłecki
W dniu 26 marca 2011 16:38 użytkownik Rafał Miłecki napisał: > 2011/3/23 Thomas Renninger : >> drm radeon: Return -EINVAL on wrong pm sysfs access >> >> Throw an error if someone tries to fill this with >> wrong data, instead of simply ignoring the input. >> No

Re: [PATCH] drm/ttm: fix, avoid iomapping system memory

2010-05-05 Thread Rafał Miłecki
2010/5/5 Jerome Glisse : > If the memory is not iomem we should not try to > ioremap it. Should fix : > > https://bugs.freedesktop.org/show_bug.cgi?id=27822 > > Signed-off-by: Jerome Glisse Tested-by: Rafał Miłecki Thanks! -- Rafał ___

Re: linux-next - drm/ttm versus nouveau - WARNING and dead driver.

2010-05-06 Thread Rafał Miłecki
2010/5/6 : > Bisected down to: > > 82c5da6bf8b55a931b042fb531083863d26c8020 is the first bad commit > commit 82c5da6bf8b55a931b042fb531083863d26c8020 > Author: Jerome Glisse > Date:   Fri Apr 9 14:39:23 2010 +0200 > >    drm/ttm: ttm_fault callback to allow driver to handle bo placement V6 Can t

Re: [PATCH 0/9] drm/radeon/kms: update pm code

2010-05-10 Thread Rafał Miłecki
2010/5/10 Andy Furniss : >> The module parameter is obsolete. you can enable it dynamically via >> sysfs (power_method).  The default pm method is profile. > > OK, I know dynpm was removed - but this is dynclks are the two the same? dynclks is for disabling clocking unused blocks. It means you don

Re: [PATCH 1/2] drm/radeon/kms: reset ddc_bus in object header parsing

2010-05-18 Thread Rafał Miłecki
2010/5/19 Alex Deucher : > Some LVDS connectors don't have a ddc bus, so reset the > ddc bus to invalid before parsing the next connector > to avoid using stale ddc bus data.  Should fix > fdo bug 28164. It does, thanks :) Tested-by: Rafał Mi

Re: [PATCH] drm/radeon/kms/pm: voltage fixes

2010-06-03 Thread Rafał Miłecki
2010/5/27 Alex Deucher : > diff --git a/drivers/gpu/drm/radeon/radeon_combios.c > b/drivers/gpu/drm/radeon/radeon_combios.c > index 7b5e10d..102c744 100644 > --- a/drivers/gpu/drm/radeon/radeon_combios.c > +++ b/drivers/gpu/drm/radeon/radeon_combios.c > @@ -2454,7 +2454,12 @@ default_mode: >      

Re: [PATCH] drm/radeon/kms/pm: add support for SetVoltage cmd table (V2)

2010-06-03 Thread Rafał Miłecki
2010/5/28 Alex Deucher : > diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c > index dac2534..d84d7cf 100644 > --- a/drivers/gpu/drm/radeon/r600.c > +++ b/drivers/gpu/drm/radeon/r600.c > @@ -475,6 +475,12 @@ void r600_pm_init_profile(struct radeon_device *rdev) > >  void r6

Re: [PATCH] drm/radeon/kms: r600 dump last 64 dwords of ring.

2010-06-04 Thread Rafał Miłecki
2010/6/4 Jerome Glisse : > Instead of dumping unprocessed dwords, dump the last 64 > dwords of the ring. This make debugging of some case easier. > > Signed-off-by: Jerome Glisse > --- >  drivers/gpu/drm/radeon/r600.c |    6 +++--- >  1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH] drm/radeon/kms: r600 dump last 64 dwords of ring.

2010-06-04 Thread Rafał Miłecki
W dniu 4 czerwca 2010 21:55 użytkownik Jerome Glisse napisał: > On Fri, Jun 04, 2010 at 02:54:42PM +0200, Rafał Miłecki wrote: >> 2010/6/4 Jerome Glisse : >> > Instead of dumping unprocessed dwords, dump the last 64 >> > dwords of the ring. This make de

[PATCH] drm/radeon/kms/r600+: use voltage from requested clock mode

2010-06-06 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki --- This fixes FDO bug #28375, must have for .35 --- drivers/gpu/drm/radeon/r600.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c index d84d7cf..94c27d0 100644 --- a

<    1   2   3   4   5   6   >