Re: [PATCH v6] drm/i915/hwmon: expose fan speed

2024-08-20 Thread Raag Jadav
On Tue, Aug 20, 2024 at 01:23:35PM +0300, Andy Shevchenko wrote: > On Tue, Aug 20, 2024 at 11:50:10AM +0530, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-20 Thread Raag Jadav
On Tue, Aug 20, 2024 at 05:49:23PM -0400, Rodrigo Vivi wrote: > On Tue, Aug 20, 2024 at 12:00:27PM +0300, Raag Jadav wrote: > > On Fri, Aug 09, 2024 at 12:57:54PM +0100, Andi Shyti wrote: > > > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > > > >

Re: [PATCH v6] drm/i915/hwmon: expose fan speed

2024-08-22 Thread Raag Jadav
On Tue, Aug 20, 2024 at 05:06:39PM +0300, Andy Shevchenko wrote: > On Tue, Aug 20, 2024 at 04:12:46PM +0300, Raag Jadav wrote: > > On Tue, Aug 20, 2024 at 01:23:35PM +0300, Andy Shevchenko wrote: > > > On Tue, Aug 20, 2024 at 11:50:10AM +0530, Raag Jadav wrote: > > >

[PATCH v7] drm/i915/hwmon: expose fan speed

2024-08-22 Thread Raag Jadav
redundant overflow logic (Andy) Split fan_input_read() into dedicated helper (Badal) v7: Fix undefined reference to __udivdi3 for i386 (Andy) Signed-off-by: Raag Jadav Reviewed-by: Riana Tauro Reviewed-by: Andi Shyti --- .../ABI/testing/sysfs-driver-intel-i915-hwmon | 8 ++ drivers/gpu/drm

[PATCH v3 0/3] Introduce DRM device wedged event

2024-09-02 Thread Raag Jadav
uevent for all device wedged cases (Aravind) v3: Generic re-implementation in DRM subsystem (Lucas) Himal Prasad Ghimiray (1): drm/xe: Use device wedged event Raag Jadav (2): drm: Introduce device wedged event drm/i915: Use device wedged event drivers/gpu/drm/drm_drv.c | 21

[PATCH v3 1/3] drm: Introduce device wedged event

2024-09-02 Thread Raag Jadav
vendor agnostic. Userspace consumers (sysadmin) can define udev rules to parse this event and take respective action to recover the device. Consumer expectations: -- 1) Unbind driver 2) Reset bus device 3) Re-bind driver Signed-off-by: Raag Jadav --- drivers/gpu/drm/drm_drv.c

[PATCH v3 2/3] drm/xe: Use device wedged event

2024-09-02 Thread Raag Jadav
veloped-by: Raag Jadav Signed-off-by: Raag Jadav --- drivers/gpu/drm/xe/xe_device.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c index 1a0d7fdd094b..82b1583ada30 100644 --- a/drivers/gpu/drm/xe/xe_devi

[PATCH v3 3/3] drm/i915: Use device wedged event

2024-09-02 Thread Raag Jadav
Now that we have device wedged event supported by DRM core, make use of it. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav --- drivers/gpu/drm/i915/gt/intel_reset.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu

Re: [PATCH v3 3/3] drm/i915: Use device wedged event

2024-09-03 Thread Raag Jadav
On Mon, Sep 02, 2024 at 02:22:21PM +0530, Aravind Iddamsetty wrote: > > On 02/09/24 13:18, Raag Jadav wrote: > > Now that we have device wedged event supported by DRM core, make use > > of it. With this in place, userspace will be notified of wedged device > > on gt reset

Re: [PATCH v3 1/3] drm: Introduce device wedged event

2024-09-03 Thread Raag Jadav
On Mon, Sep 02, 2024 at 02:44:21PM +0530, Aravind Iddamsetty wrote: > > On 02/09/24 13:18, Raag Jadav wrote: > > Introduce device wedged event, which will notify userspace of wedged > > (hanged/unusable) state of the DRM device through a uevent. This is > > useful espec

[PATCH v4 0/3] Introduce DRM device wedged event

2024-09-06 Thread Raag Jadav
uevent for all device wedged cases (Aravind) v3: Generic re-implementation in DRM subsystem (Lucas) v4: s/drm_dev_wedged/drm_dev_wedged_event Use drm_info() (Jani) Kernel doc adjustment (Aravind) Change authorship to Raag (Aravind) Raag Jadav (3): drm: Introduce device wedged event

[PATCH v4 1/3] drm: Introduce device wedged event

2024-09-06 Thread Raag Jadav
drm_info() (Jani) Kernel doc adjustment (Aravind) Signed-off-by: Raag Jadav --- drivers/gpu/drm/drm_drv.c | 20 include/drm/drm_drv.h | 1 + 2 files changed, 21 insertions(+) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 93543071a500

[PATCH v4 2/3] drm/xe: Use device wedged event

2024-09-06 Thread Raag Jadav
dged cases (Aravind) v3: Generic re-implementation in DRM subsystem (Lucas) v4: Change authorship to Raag (Aravind) Signed-off-by: Raag Jadav --- drivers/gpu/drm/xe/xe_device.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/

[PATCH v4 3/3] drm/i915: Use device wedged event

2024-09-06 Thread Raag Jadav
Now that we have device wedged event supported by DRM core, make use of it. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav --- drivers/gpu/drm/i915/gt/intel_reset.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu

[PATCH v1] drm/i915/hwmon: expose fan speed

2024-07-12 Thread Raag Jadav
kJ Signed-off-by: Raag Jadav --- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 2 + drivers/gpu/drm/i915/i915_hwmon.c | 71 + 2 files changed, 73 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_gt_regs.h b/drivers/gpu/drm/i915/gt/intel_gt_regs.h index

Re: [PATCH v1] drm/i915/hwmon: expose fan speed

2024-07-23 Thread Raag Jadav
On Mon, Jul 22, 2024 at 04:20:51PM +0530, Riana Tauro wrote: > Hi Raag > > On 7/12/2024 5:53 PM, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > &

Re: [PATCH v1] drm/i915/hwmon: expose fan speed

2024-07-26 Thread Raag Jadav
On Wed, Jul 24, 2024 at 02:11:40PM +0530, Nilawar, Badal wrote: > > > On 12-07-2024 17:53, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > >

[PATCH v2] drm/i915/hwmon: expose fan speed

2024-07-29 Thread Raag Jadav
kJ v2: - Add mutex protection - Handle overflow - Add ABI documentation - Aesthetic adjustments Signed-off-by: Raag Jadav --- .../ABI/testing/sysfs-driver-intel-i915-hwmon | 8 ++ drivers/gpu/drm/i915/gt/intel_gt_regs.h | 2 + drivers/gpu/drm/i915/i915_hwmon.c | 87

[PATCH v1] drm/xe/uapi: Bring back reset uevent

2024-08-05 Thread Raag Jadav
=8086:1210 PCI_SLOT_NAME=:03:00.0 MODALIAS=pci:v8086d56B1sv8086sd1210bc03sc00i00 SEQNUM=6104 Signed-off-by: Lucas De Marchi Signed-off-by: Raag Jadav --- drivers/gpu/drm/xe/xe_gt.c | 27 +-- include/uapi/drm/xe_drm.h | 17 + 2 files

[PATCH v3] drm/i915/hwmon: expose fan speed

2024-08-07 Thread Raag Jadav
kJ v3: - Declare rotations as "long" and drop redundant casting - Change date and version in ABI documentation - Add commenter name in changelog (Riana) v2: - Add mutex protection - Handle overflow - Add ABI documentation - Aesthetic adjustments (Riana) Signed-off-by: Raag Jadav R

Re: [PATCH v3] drm/i915/hwmon: expose fan speed

2024-08-07 Thread Raag Jadav
On Wed, Aug 07, 2024 at 02:24:27PM +0100, Andi Shyti wrote: > Hi Raag, > > > +static umode_t > > +hwm_fan_is_visible(const struct hwm_drvdata *ddat, u32 attr) > > +{ > > + struct i915_hwmon *hwmon = ddat->hwmon; > > + > > + switch (attr) { > > + case hwmon_fan_input: > > + return i

[PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-08 Thread Raag Jadav
witch case and simplify hwm_fan_xx() (Andi) Signed-off-by: Raag Jadav Reviewed-by: Riana Tauro --- .../ABI/testing/sysfs-driver-intel-i915-hwmon | 8 ++ drivers/gpu/drm/i915/gt/intel_gt_regs.h | 2 + drivers/gpu/drm/i915/i915_hwmon.c | 81 +++ 3 files c

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Raag Jadav
On Fri, Aug 09, 2024 at 03:03:20PM +0530, Nilawar, Badal wrote: > > > On 09-08-2024 11:45, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using lm-sensors tool. > >

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-09 Thread Raag Jadav
On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using

[PATCH v2] drm/xe/uapi: Bring back reset uevent

2024-08-12 Thread Raag Jadav
horship to Himal (Aravind) Add uevent for all device wedged cases (Aravind) Signed-off-by: Himal Prasad Ghimiray Signed-off-by: Raag Jadav --- drivers/gpu/drm/xe/xe_device.c | 10 +- drivers/gpu/drm/xe/xe_device.h | 2 +- drivers/gpu/drm/xe/xe_gt.c

[PATCH v5] drm/i915/hwmon: expose fan speed

2024-08-12 Thread Raag Jadav
ework time calculation, aesthetic adjustments (Andy) Signed-off-by: Raag Jadav Reviewed-by: Riana Tauro --- .../ABI/testing/sysfs-driver-intel-i915-hwmon | 8 ++ drivers/gpu/drm/i915/gt/intel_gt_regs.h | 2 + drivers/gpu/drm/i915/i915_hwmon.c | 85 +++ 3 files c

Re: [PATCH v5] drm/i915/hwmon: expose fan speed

2024-08-12 Thread Raag Jadav
On Mon, Aug 12, 2024 at 04:15:14PM +0300, Andy Shevchenko wrote: > On Mon, Aug 12, 2024 at 01:45:38PM +0530, Raag Jadav wrote: > > Add hwmon support for fan1_input attribute, which will expose fan speed > > in RPM. With this in place we can monitor fan speed using

Re: [PATCH v5] drm/i915/hwmon: expose fan speed

2024-08-12 Thread Raag Jadav
On Mon, Aug 12, 2024 at 03:50:47PM +0200, Andi Shyti wrote: > Hi Raag, > > > +static int > > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val) > > +{ > > + struct i915_hwmon *hwmon = ddat->hwmon; > > + struct hwm_fan_info *fi = &ddat->fi; > > + u64 rotations, time_now, time; > > +

Re: [PATCH v5] drm/i915/hwmon: expose fan speed

2024-08-13 Thread Raag Jadav
On Tue, Aug 13, 2024 at 11:27:22AM +0300, Andy Shevchenko wrote: > On Tue, Aug 13, 2024 at 08:45:19AM +0300, Raag Jadav wrote: > > On Mon, Aug 12, 2024 at 04:15:14PM +0300, Andy Shevchenko wrote: > > > On Mon, Aug 12, 2024 at 01:45:38PM +0530, Raag Jadav wrote: > > ..

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-13 Thread Raag Jadav
On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > > > + /* > > +* HW register value is accumulated count of pulses from > > +* PWM fan with the scale of 2 pulses per rotation. >

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-13 Thread Raag Jadav
On Tue, Aug 13, 2024 at 02:47:27PM +0300, Andy Shevchenko wrote: > On Tue, Aug 13, 2024 at 02:23:13PM +0300, Raag Jadav wrote: > > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > > > On Fri, Aug 09, 2024 at 11:45:25AM +0530

Re: [PATCH v2] drm/xe/uapi: Bring back reset uevent

2024-08-13 Thread Raag Jadav
On Mon, Aug 12, 2024 at 03:08:14PM +0530, Aravind Iddamsetty wrote: > > On 12/08/24 13:18, Raag Jadav wrote: > > From: Himal Prasad Ghimiray > > > > This was dropped in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset > > uevent for now") as part of refa

Re: [PATCH v2] drm/xe/uapi: Bring back reset uevent

2024-08-14 Thread Raag Jadav
On Wed, Aug 14, 2024 at 12:16:41PM +0530, Aravind Iddamsetty wrote: > >On 13/08/24 22:24, Rodrigo Vivi wrote: >> On Tue, Aug 13, 2024 at 04:28:32PM +0300, Raag Jadav wrote: >>> On Mon, Aug 12, 2024 at 03:08:14PM +0530, Aravind Iddamsetty wrote: >>>> On 12/08/24 13

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-18 Thread Raag Jadav
On Wed, Aug 14, 2024 at 02:07:44PM +0530, Nilawar, Badal wrote: > > Hi Andi, > > On 09-08-2024 15:46, Andi Shyti wrote: > > Hi Badal, > > > > > > +static int > > > > +hwm_fan_read(struct hwm_drvdata *ddat, u32 attr, long *val) > > > > +{ > > > > + struct i915_hwmon *hwmon = ddat->hwmon; >

[PATCH v6] drm/i915/hwmon: expose fan speed

2024-08-19 Thread Raag Jadav
overflow logic (Andy) Aesthetic adjustments (Badal) Signed-off-by: Raag Jadav Reviewed-by: Riana Tauro --- .../ABI/testing/sysfs-driver-intel-i915-hwmon | 8 ++ drivers/gpu/drm/i915/gt/intel_gt_regs.h | 2 + drivers/gpu/drm/i915/i915_hwmon.c | 88 +++ 3 files

Re: [PATCH v4] drm/i915/hwmon: expose fan speed

2024-08-20 Thread Raag Jadav
On Fri, Aug 09, 2024 at 12:57:54PM +0100, Andi Shyti wrote: > On Fri, Aug 09, 2024 at 02:48:08PM +0300, Andy Shevchenko wrote: > > On Fri, Aug 09, 2024 at 11:45:25AM +0530, Raag Jadav wrote: > > > Add hwmon support for fan1_input attribute, which will expose fan speed > >

[PATCH for-next v2 00/10] Fix symbol export for _SIMPLE_ variants of _PM_OPS()

2023-09-18 Thread Raag Jadav
ds on CONFIG_PM and CONFIG_PM_SLEEP respectively. Changes since v1: - Update drivers to new set of macros Raag Jadav (10): PM: Introduce export macros for _SIMPLE_ variants of _PM_OPS() PM: Update EXPORT_*_DEV_PM_OPS() to EXPORT_*_RUNTIME_PM_OPS() iio: accel: fxls8962af: conve

[PATCH for-next v2 01/10] PM: Introduce export macros for _SIMPLE_ variants of _PM_OPS()

2023-09-18 Thread Raag Jadav
Introduce a new set of export macros for _SIMPLE_ variants of _PM_OPS(), which export dev_pm_ops symbol only in case CONFIG_PM_SLEEP=y and discard it otherwise. Fixes: 34e1ed189fab ("PM: Improve EXPORT_*_DEV_PM_OPS macros") Signed-off-by: Raag Jadav --- include/linux

[PATCH for-next v2 02/10] PM: Update EXPORT_*_DEV_PM_OPS() to EXPORT_*_RUNTIME_PM_OPS()

2023-09-18 Thread Raag Jadav
more distinguishable and self explanatory. Signed-off-by: Raag Jadav --- include/linux/pm.h | 5 - include/linux/pm_runtime.h | 13 + 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/include/linux/pm.h b/include/linux/pm.h index 6e7ab6950ad1..9ab051f3a351

[PATCH for-next v2 03/10] iio: accel: fxls8962af: convert to EXPORT_NS_GPL_RUNTIME_PM_OPS()

2023-09-18 Thread Raag Jadav
With original macro being renamed to EXPORT_NS_GPL_RUNTIME_PM_OPS(), use the new macro. Signed-off-by: Raag Jadav --- drivers/iio/accel/fxls8962af-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/accel/fxls8962af-core.c b/drivers/iio/accel/fxls8962af

[PATCH for-next v2 04/10] iio: gyro: fxas21002c: convert to EXPORT_NS_GPL_RUNTIME_PM_OPS()

2023-09-18 Thread Raag Jadav
With original macro being renamed to EXPORT_NS_GPL_RUNTIME_PM_OPS(), use the new macro. Signed-off-by: Raag Jadav --- drivers/iio/gyro/fxas21002c_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/gyro/fxas21002c_core.c b/drivers/iio/gyro/fxas21002c_core.c

[PATCH for-next v2 05/10] iio: imu: inv_icm42600: convert to EXPORT_NS_GPL_RUNTIME_PM_OPS()

2023-09-18 Thread Raag Jadav
With original macro being renamed to EXPORT_NS_GPL_RUNTIME_PM_OPS(), use the new macro. Signed-off-by: Raag Jadav --- drivers/iio/imu/inv_icm42600/inv_icm42600_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_core.c b/drivers

[PATCH for-next v2 06/10] iio: imu: inv_mpu: convert to EXPORT_NS_GPL_RUNTIME_PM_OPS()

2023-09-18 Thread Raag Jadav
With original macro being renamed to EXPORT_NS_GPL_RUNTIME_PM_OPS(), use the new macro. Signed-off-by: Raag Jadav --- drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu

[PATCH for-next v2 07/10] drm/imx/dcss: convert to EXPORT_GPL_RUNTIME_PM_OPS()

2023-09-18 Thread Raag Jadav
With original macro being renamed to EXPORT_GPL_RUNTIME_PM_OPS(), use the new macro. Signed-off-by: Raag Jadav --- drivers/gpu/drm/imx/dcss/dcss-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/dcss/dcss-dev.c b/drivers/gpu/drm/imx/dcss/dcss-dev.c

[PATCH for-next v2 08/10] mfd: arizona: convert to EXPORT_GPL_RUNTIME_PM_OPS()

2023-09-18 Thread Raag Jadav
With original macro being renamed to EXPORT_GPL_RUNTIME_PM_OPS(), use the new macro. Signed-off-by: Raag Jadav --- drivers/mfd/arizona-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index 19a0adf8ce3d

[PATCH for-next v2 09/10] mfd: cs42l43: convert to EXPORT_NS_GPL_RUNTIME_PM_OPS()

2023-09-18 Thread Raag Jadav
With original macro being renamed to EXPORT_NS_GPL_RUNTIME_PM_OPS(), use the new macro. Signed-off-by: Raag Jadav --- drivers/mfd/cs42l43.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c index 37b23e9bae82..b84adde9f89e 100644

[PATCH for-next v2 10/10] ASoC: cs35l41: convert to EXPORT_GPL_RUNTIME_PM_OPS()

2023-09-18 Thread Raag Jadav
With original macro being renamed to EXPORT_GPL_RUNTIME_PM_OPS(), use the new macro. Signed-off-by: Raag Jadav --- sound/soc/codecs/cs35l41.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/cs35l41.c b/sound/soc/codecs/cs35l41.c index 4bc64ba71cd6

Re: [PATCH for-next v2 02/10] PM: Update EXPORT_*_DEV_PM_OPS() to EXPORT_*_RUNTIME_PM_OPS()

2023-09-18 Thread Raag Jadav
On Mon, Sep 18, 2023 at 10:20:29AM +0200, Paul Cercueil wrote: > Le lundi 18 septembre 2023 à 13:39 +0530, Raag Jadav a écrit : > > Rename EXPORT_*_DEV_PM_OPS() macros to EXPORT_*_RUNTIME_PM_OPS() > > and while at it, move them to pm_runtime.h. > > This is done in conjunction

Re: [PATCH v4 1/3] drm: Introduce device wedged event

2024-09-10 Thread Raag Jadav
On Mon, Sep 09, 2024 at 02:53:23PM -0700, Matt Roper wrote: > On Fri, Sep 06, 2024 at 03:12:23PM +0530, Raag Jadav wrote: > > Introduce device wedged event, which will notify userspace of wedged > > (hanged/unusable) state of the DRM device through a uevent. This is > > usefu

Re: [PATCH v4 1/3] drm: Introduce device wedged event

2024-09-10 Thread Raag Jadav
On Mon, Sep 09, 2024 at 03:01:50PM -0500, Lucas De Marchi wrote: > On Sun, Sep 08, 2024 at 11:08:39PM GMT, Asahi Lina wrote: > > On 9/8/24 12:07 AM, Lucas De Marchi wrote: > > > On Sat, Sep 07, 2024 at 08:38:30PM GMT, Asahi Lina wrote: > > > > On 9/

[PATCH v5 0/4] Introduce DRM device wedged event

2024-09-16 Thread Raag Jadav
supported recovery methods via sysfs (Lucas) Raag Jadav (4): drm: Introduce device wedged event drm: Expose wedge recovery methods drm/xe: Use device wedged event drm/i915: Use device wedged event drivers/gpu/drm/drm_drv.c | 37 +++ drivers/gpu/drm

[PATCH v5 1/4] drm: Introduce device wedged event

2024-09-16 Thread Raag Jadav
tem v4: s/drm_dev_wedged/drm_dev_wedged_event Use drm_info() (Jani) Kernel doc adjustment (Aravind) v5: Send recovery method with uevent (Lina) Signed-off-by: Raag Jadav --- drivers/gpu/drm/drm_drv.c | 37 + include/drm/drm_device.h | 24 i

[PATCH v5 2/4] drm: Expose wedge recovery methods

2024-09-16 Thread Raag Jadav
/drm/card0/wedge_recovery rebind bus-reset reboot Signed-off-by: Raag Jadav --- drivers/gpu/drm/drm_sysfs.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index fb3bbb6adcd1..b88cdbfa3b5e 100644 --- a/drivers/gpu

[PATCH v5 3/4] drm/xe: Use device wedged event

2024-09-16 Thread Raag Jadav
all device wedged cases (Aravind) v3: Generic re-implementation in DRM subsystem (Lucas) v4: Change authorship to Raag (Aravind) Signed-off-by: Raag Jadav --- drivers/gpu/drm/xe/xe_device.c | 17 +++-- drivers/gpu/drm/xe/xe_device.h | 1 + drivers/gpu/drm/xe/xe_pci.c| 2 ++ 3 files c

[PATCH v5 4/4] drm/i915: Use device wedged event

2024-09-16 Thread Raag Jadav
Now that we have device wedged event supported by DRM core, make use of it. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav --- drivers/gpu/drm/i915/gt/intel_reset.c | 2 ++ drivers/gpu/drm/i915/i915_driver.c| 10 ++ 2

Re: [PATCH v5 3/4] drm/xe: Use device wedged event

2024-09-16 Thread Raag Jadav
On Tue, Sep 17, 2024 at 10:11:05AM +0530, Ghimiray, Himal Prasad wrote: > On 17-09-2024 09:32, Raag Jadav wrote: > > This was previously attempted as xe specific reset uevent but dropped > > in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset uevent for now") &

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-08 Thread Raag Jadav
On Thu, Oct 03, 2024 at 03:23:22PM +0300, Raag Jadav wrote: > On Tue, Oct 01, 2024 at 02:20:29PM +0200, Michal Wajdeczko wrote: > > On 30.09.2024 09:38, Raag Jadav wrote: > > > > > > +/** > > > + * enum drm_wedge_recovery - Recovery method for wedged device i

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-11 Thread Raag Jadav
On Thu, Oct 10, 2024 at 08:02:10AM -0500, Lucas De Marchi wrote: > On Tue, Oct 08, 2024 at 06:02:43PM +0300, Raag Jadav wrote: > > On Thu, Oct 03, 2024 at 03:23:22PM +0300, Raag Jadav wrote: > > > On Tue, Oct 01, 2024 at 02:20:29PM +0200, Michal Wajdeczko wrote: > > >

[PATCH v7 2/5] drm: Expose wedge recovery methods

2024-09-30 Thread Raag Jadav
/drm/card/wedge_recovery rebind bus-reset reboot Signed-off-by: Raag Jadav --- drivers/gpu/drm/drm_sysfs.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index fb3bbb6adcd1..bd77b35ceb8a 100644 --- a

[PATCH v7 1/5] drm: Introduce device wedged event

2024-09-30 Thread Raag Jadav
ery method with uevent (Lina) v6: Access wedge_recovery_opts[] using helper function (Jani) Use snprintf() (Jani) v7: Convert recovery helpers into regular functions (Andy, Jani) Aesthetic adjustments (Andy) Handle invalid method cases Signed-off-by: Raag Jadav --- drivers/gpu/drm

[PATCH v7 4/5] drm/xe: Use device wedged event

2024-09-30 Thread Raag Jadav
v2: Change authorship to Himal (Aravind) Add uevent for all device wedged cases (Aravind) v3: Generic re-implementation in DRM subsystem (Lucas) v4: Change authorship to Raag (Aravind) Signed-off-by: Raag Jadav --- drivers/gpu/drm/xe/xe_device.c | 17 +++-- drivers/gpu/drm/xe/xe_dev

[PATCH v7 3/5] drm/doc: Document device wedged event

2024-09-30 Thread Raag Jadav
Add documentation for device wedged event along with its consumer expectations. For now it is amended to 'Device reset' chapter, but with extended functionality in the future it can be refactored into its own chapter. Signed-off-by: Raag Jadav --- Documentation/gpu/drm-uap

[PATCH v7 5/5] drm/i915: Use device wedged event

2024-09-30 Thread Raag Jadav
Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav --- drivers/gpu/drm/i915/gt/intel_reset.c | 2

[PATCH v7 0/5] Introduce DRM device wedged event

2024-09-30 Thread Raag Jadav
-uapi.rst (Sima) Raag Jadav (5): drm: Introduce device wedged event drm: Expose wedge recovery methods drm/doc: Document device wedged event drm/xe: Use device wedged event drm/i915: Use device wedged event Documentation/gpu/drm-uapi.rst| 42 +++ drivers/gpu/drm

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-18 Thread Raag Jadav
On Fri, Oct 18, 2024 at 12:58:09PM +0200, Christian König wrote: > Am 17.10.24 um 18:43 schrieb Rodrigo Vivi: > > On Thu, Oct 17, 2024 at 09:59:10AM +0200, Christian König wrote: > > > > > Purpose of this implementation is to provide drivers a generic way to > > > > > recover with the help of users

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-18 Thread Raag Jadav
On Fri, Oct 18, 2024 at 02:54:38PM +0200, Christian König wrote: > Am 18.10.24 um 14:46 schrieb Raag Jadav: > > > As far as I can see this makes the enum how to recover the device > > > superfluous because you will most likely always need a bus reset to get > > > out

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-19 Thread Raag Jadav
On Thu, Oct 17, 2024 at 04:16:09PM -0300, André Almeida wrote: > Hi Raag, > > Em 30/09/2024 04:38, Raag Jadav escreveu: > > Introduce device wedged event, which will notify userspace of wedged > > (hanged/unusable) state of the DRM device through a uevent. This is > >

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-16 Thread Raag Jadav
On Mon, Sep 30, 2024 at 01:08:41PM +0530, Raag Jadav wrote: > Introduce device wedged event, which will notify userspace of wedged > (hanged/unusable) state of the DRM device through a uevent. This is > useful especially in cases where the device is no longer operating as > expected

[PATCH v8 4/4] drm/i915: Use device wedged event

2024-10-25 Thread Raag Jadav
Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav --- drivers/gpu/drm/i915/gt/intel_reset.c | 3

[PATCH v8 3/4] drm/xe: Use device wedged event

2024-10-25 Thread Raag Jadav
v2: Change authorship to Himal (Aravind) Add uevent for all device wedged cases (Aravind) v3: Generic re-implementation in DRM subsystem (Lucas) v4: Change authorship to Raag (Aravind) Signed-off-by: Raag Jadav --- drivers/gpu/drm/xe/xe_device.c | 9 +++-- 1 file changed, 7 insert

[PATCH v8 2/4] drm/doc: Document device wedged event

2024-10-25 Thread Raag Jadav
Add documentation for device wedged event in a new 'Device wedging' chapter. The describes basic definitions and consumer expectations along with an example. v8: Improve documentation (Christian, Rodrigo) Signed-off-by: Raag Jadav --- Documentation/gpu/drm-uap

Re: [PATCH v8 1/4] drm: Introduce device wedged event

2024-10-26 Thread Raag Jadav
On Fri, Oct 25, 2024 at 05:45:59PM +0300, Andy Shevchenko wrote: > On Fri, Oct 25, 2024 at 12:08:50PM +0300, Jani Nikula wrote: > > On Fri, 25 Oct 2024, Raag Jadav wrote: > > ... > > > > +/* > > > + * Available recovery methods for wedged device.

Re: [PATCH v8 2/4] drm/doc: Document device wedged event

2024-10-31 Thread Raag Jadav
On Tue, Oct 29, 2024 at 10:51:34AM +0100, Christian König wrote: > Am 25.10.24 um 10:48 schrieb Raag Jadav: > > Add documentation for device wedged event in a new 'Device wedging' > > chapter. The describes basic definitions and consumer expectations > > along with a

Re: [PATCH v5 2/4] drm: Expose wedge recovery methods

2024-09-18 Thread Raag Jadav
On Tue, Sep 17, 2024 at 10:49:07AM +0300, Jani Nikula wrote: > On Tue, 17 Sep 2024, Raag Jadav wrote: > > Now that we have device wedged event in place, add wedge_recovery sysfs > > attribute which will expose recovery methods supported by the DRM device. > > This is

[PATCH v6 2/4] drm: Expose wedge recovery methods

2024-09-22 Thread Raag Jadav
/drm/card0/wedge_recovery rebind bus-reset reboot Signed-off-by: Raag Jadav --- drivers/gpu/drm/drm_sysfs.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index fb3bbb6adcd1..99767de9e685 100644 --- a/drivers/gpu

[PATCH v6 3/4] drm/xe: Use device wedged event

2024-09-22 Thread Raag Jadav
all device wedged cases (Aravind) v3: Generic re-implementation in DRM subsystem (Lucas) v4: Change authorship to Raag (Aravind) Signed-off-by: Raag Jadav --- drivers/gpu/drm/xe/xe_device.c | 17 +++-- drivers/gpu/drm/xe/xe_device.h | 1 + drivers/gpu/drm/xe/xe_pci.c| 2 ++ 3 files c

[PATCH v6 1/4] drm: Introduce device wedged event

2024-09-22 Thread Raag Jadav
tem v4: s/drm_dev_wedged/drm_dev_wedged_event Use drm_info() (Jani) Kernel doc adjustment (Aravind) v5: Send recovery method with uevent (Lina) v6: Access wedge_recovery_opts[] using helper function (Jani) Use snprintf() (Jani) Signed-off-by: Raag Jadav --- drivers/gpu/drm/drm_

[PATCH v6 0/4] Introduce DRM device wedged event

2024-09-22 Thread Raag Jadav
supported recovery methods via sysfs (Lucas) v6: Access wedge_recovery_opts[] using helper function (Jani) Use snprintf() (Jani) Raag Jadav (4): drm: Introduce device wedged event drm: Expose wedge recovery methods drm/xe: Use device wedged event drm/i915: Use device wedged event

[PATCH v6 4/4] drm/i915: Use device wedged event

2024-09-22 Thread Raag Jadav
Now that we have device wedged event supported by DRM core, make use of it. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav --- drivers/gpu/drm/i915/gt/intel_reset.c | 2 ++ drivers/gpu/drm/i915/i915_driver.c| 10 ++ 2

Re: [PATCH v6 1/4] drm: Introduce device wedged event

2024-09-23 Thread Raag Jadav
On Mon, Sep 23, 2024 at 11:38:55AM +0300, Andy Shevchenko wrote: > On Mon, Sep 23, 2024 at 09:28:23AM +0530, Raag Jadav wrote: > > Introduce device wedged event, which will notify userspace of wedged > > (hanged/unusable) state of the DRM device through a uevent. This is > >

Re: [PATCH v6 1/4] drm: Introduce device wedged event

2024-09-24 Thread Raag Jadav
On Tue, Sep 24, 2024 at 01:23:13PM +0200, Simona Vetter wrote: > On Mon, Sep 23, 2024 at 09:28:23AM +0530, Raag Jadav wrote: > > Introduce device wedged event, which will notify userspace of wedged > > (hanged/unusable) state of the DRM device through a uevent. This is > >

Re: [PATCH v5 2/4] drm: Expose wedge recovery methods

2024-09-20 Thread Raag Jadav
On Thu, Sep 19, 2024 at 04:45:28PM +0300, Andy Shevchenko wrote: > On Thu, Sep 19, 2024 at 11:38:50AM +0300, Raag Jadav wrote: > > On Thu, Sep 19, 2024 at 10:38:51AM +0300, Jani Nikula wrote: > > ... > > > Anyway, would you prefer strlcat instead? > > FYI: strl*

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-09-30 Thread Raag Jadav
On Mon, Sep 30, 2024 at 03:59:59PM +0300, Andy Shevchenko wrote: > On Mon, Sep 30, 2024 at 01:08:41PM +0530, Raag Jadav wrote: > > Introduce device wedged event, which will notify userspace of wedged > > (hanged/unusable) state of the DRM device through a uevent. This is > >

Re: [PATCH v7 2/5] drm: Expose wedge recovery methods

2024-09-30 Thread Raag Jadav
On Mon, Sep 30, 2024 at 04:01:38PM +0300, Andy Shevchenko wrote: > On Mon, Sep 30, 2024 at 01:08:42PM +0530, Raag Jadav wrote: > > Now that we have device wedged event in place, add wedge_recovery sysfs > > attribute which will expose recovery methods supported by the DRM devi

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-01 Thread Raag Jadav
On Tue, Oct 01, 2024 at 05:54:46PM +0300, Andy Shevchenko wrote: > On Tue, Oct 01, 2024 at 05:18:33PM +0300, Raag Jadav wrote: > > On Tue, Oct 01, 2024 at 03:07:59PM +0300, Andy Shevchenko wrote: > > > On Tue, Oct 01, 2024 at 08:08:18AM +0300, Raag Jadav wrote: > > > &

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-01 Thread Raag Jadav
On Tue, Oct 01, 2024 at 03:07:59PM +0300, Andy Shevchenko wrote: > On Tue, Oct 01, 2024 at 08:08:18AM +0300, Raag Jadav wrote: > > On Mon, Sep 30, 2024 at 03:59:59PM +0300, Andy Shevchenko wrote: > > > On Mon, Sep 30, 2024 at 01:08:41PM +0530, Raag Jadav wrote: > > ...

Re: [PATCH v5 2/4] drm: Expose wedge recovery methods

2024-09-19 Thread Raag Jadav
On Thu, Sep 19, 2024 at 12:24:09PM +0300, Jani Nikula wrote: > On Thu, 19 Sep 2024, Raag Jadav wrote: > > On Thu, Sep 19, 2024 at 10:38:51AM +0300, Jani Nikula wrote: > >> On Thu, 19 Sep 2024, Raag Jadav wrote: > >> > On Tue, Sep 17, 2024 at 10:49:07AM +0300, Jan

Re: [PATCH v5 2/4] drm: Expose wedge recovery methods

2024-09-19 Thread Raag Jadav
On Thu, Sep 19, 2024 at 10:38:51AM +0300, Jani Nikula wrote: > On Thu, 19 Sep 2024, Raag Jadav wrote: > > On Tue, Sep 17, 2024 at 10:49:07AM +0300, Jani Nikula wrote: > >> On Tue, 17 Sep 2024, Raag Jadav wrote: > >> > Now that we have device wedged event in p

Re: [PATCH v7 1/5] drm: Introduce device wedged event

2024-10-03 Thread Raag Jadav
On Tue, Oct 01, 2024 at 02:20:29PM +0200, Michal Wajdeczko wrote: > Hi, > > sorry for late comments, Sure, no problem. > On 30.09.2024 09:38, Raag Jadav wrote: > > Introduce device wedged event, which will notify userspace of wedged > > (hanged/unusable) state of the DRM

[PATCH v8 1/4] drm: Introduce device wedged event

2024-10-25 Thread Raag Jadav
Handle invalid method cases v8: Allow sending multiple methods with uevent (Lucas, Michal) static_assert() globally (Andy) Signed-off-by: Raag Jadav --- drivers/gpu/drm/drm_drv.c | 51 +++ include/drm/drm_device.h | 7 ++ include/drm/drm_drv.h

[PATCH v8 0/4] Introduce DRM device wedged event

2024-10-25 Thread Raag Jadav
functions (Andy, Jani) Aesthetic adjustments (Andy) Handle invalid method cases Add documentation to drm-uapi.rst (Sima) v8: Drop sysfs and allow sending multiple methods with uevent (Lucas, Michal) Improve documentation (Christian, Rodrigo) static_assert() globally (Andy) Raag Jadav

Re: [PATCH v9 1/4] drm: Introduce device wedged event

2024-11-21 Thread Raag Jadav
On Mon, Nov 18, 2024 at 08:26:37PM +0530, Aravind Iddamsetty wrote: > On 15/11/24 10:37, Raag Jadav wrote: > > Introduce device wedged event, which notifies userspace of 'wedged' > > (hanged/unusable) state of the DRM device through a uevent. This is > > useful espec

[PATCH v10 2/4] drm/doc: Document device wedged event

2024-11-28 Thread Raag Jadav
leanup and consumer prerequisites (Christian, Aravind) Signed-off-by: Raag Jadav Reviewed-by: Christian König --- Documentation/gpu/drm-uapi.rst | 112 - 1 file changed, 109 insertions(+), 3 deletions(-) diff --git a/Documentation/gpu/drm-uapi.rst b/Documentati

[PATCH v10 3/4] drm/xe: Use device wedged event

2024-11-28 Thread Raag Jadav
v2: Change authorship to Himal (Aravind) Add uevent for all device wedged cases (Aravind) v3: Generic re-implementation in DRM subsystem (Lucas) v4: Change authorship to Raag (Aravind) Signed-off-by: Raag Jadav Reviewed-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_device.c | 9 +++

[PATCH v10 1/4] drm: Introduce device wedged event

2024-11-28 Thread Raag Jadav
globally (Andy) v9: Provide 'none' method for reset cases (Christian) Provide recovery opts using switch cases Signed-off-by: Raag Jadav --- drivers/gpu/drm/drm_drv.c | 66 +++ include/drm/drm_device.h | 8 + include/drm/drm_drv.h | 1 +

[PATCH v10 4/4] drm/i915: Use device wedged event

2024-11-28 Thread Raag Jadav
Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav Reviewed-by: Aravind Iddamsetty --- drivers/gpu

[PATCH v10 0/4] Introduce DRM device wedged event

2024-11-28 Thread Raag Jadav
(Andy) v9: Document prerequisites section (Christian) Provide 'none' method for reset cases (Christian) Provide recovery opts using switch cases v10: Clarify mmap cleanup and consumer prerequisites (Christian, Aravind) Raag Jadav (4): drm: Introduce device wedged event

Re: [PATCH v9 3/4] drm/xe: Use device wedged event

2024-11-19 Thread Raag Jadav
On Tue, Nov 19, 2024 at 10:25:10AM +0530, Ghimiray, Himal Prasad wrote: > On 15-11-2024 10:37, Raag Jadav wrote: > > This was previously attempted as xe specific reset uevent but dropped > > in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset uevent for now") &

[PATCH v9 1/4] drm: Introduce device wedged event

2024-11-14 Thread Raag Jadav
Aesthetic adjustments (Andy) Handle invalid method cases v8: Allow sending multiple methods with uevent (Lucas, Michal) static_assert() globally (Andy) v9: Provide 'none' method for reset cases (Christian) Provide recovery opts using switch cases Signed-off-by: Raag Jadav

[PATCH v9 4/4] drm/i915: Use device wedged event

2024-11-14 Thread Raag Jadav
Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav --- drivers/gpu/drm/i915/gt/intel_reset.c | 3

  1   2   3   >