[PATCH] drm/i915/display: Only fail fastset on PSR2

2023-11-01 Thread Paz Zcharya
. Accordingly, do not fail fastset if PSR2 is not enabled. Signed-off-by: Paz Zcharya --- drivers/gpu/drm/i915/display/intel_dp.c | 4 ++-- drivers/gpu/drm/i915/display/intel_psr.c | 2 +- drivers/gpu/drm/i915/display/intel_psr.h | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a

Re: [PATCH] drm/i915/display: Only fail fastset on PSR2

2023-11-02 Thread Paz Zcharya
On Wed, Nov 01, 2023 at 06:26:47AM +, Hogander, Jouni wrote: > On Tue, 2023-10-31 at 23:21 +0000, Paz Zcharya wrote: > > Currently, i915 fails fastset if both the sink and the source support > > any version of PSR and regardless of the configuration setting of the > &g

[PATCH] drm/i915/display: Fix phys_base to be relative not absolute

2023-11-06 Thread Paz Zcharya
_i915_gem_object_create_region i915_gem_object_create_region_at initial_plane_vma intel_alloc_initial_plane_obj intel_find_initial_plane_obj intel_crtc_initial_plane_config [drm:_i915_gem_object_stolen_init] creating preallocated stolen object: stolen_offset=0x, size=0x000000

[PATCH] drm/i915/display: Include debugfs.h in intel_display_debugfs_params.c

2024-01-31 Thread Paz Zcharya
file is breaking the ChromeOS build -- add an explicit include to fix that. Signed-off-by: Paz Zcharya --- drivers/gpu/drm/i915/display/intel_display_debugfs_params.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs_params.c b/drivers/

Re: [PATCH] drm/i915/display: Include debugfs.h in intel_display_debugfs_params.c

2024-02-01 Thread Paz Zcharya
On Thu, Feb 01, 2024 at 11:22:16AM +0200, Jani Nikula wrote: > On Wed, 31 Jan 2024, Paz Zcharya wrote: > > Commit 8015bee0bfec ("drm/i915/display: Add framework to add parameters > > specific to display") added the file intel_display_debugfs_params.c, >

Re: [Intel-gfx] [PATCH] drm/i915/display: Fix phys_base to be relative not absolute

2023-11-17 Thread Paz Zcharya
On Tue, Nov 14, 2023 at 10:13:59PM -0500, Rodrigo Vivi wrote: > On Sun, Nov 05, 2023 at 05:27:03PM +0000, Paz Zcharya wrote: > > Fix the value of variable `phys_base` to be the relative offset in > > stolen memory, and not the absolute offset of the GSM. > > to me it loo

Re: [Intel-gfx] [PATCH] drm/i915/display: Fix phys_base to be relative not absolute

2023-11-27 Thread Paz Zcharya
On Wed, Nov 22, 2023 at 02:26:55PM +0100, Andrzej Hajda wrote: > > > On 21.11.2023 13:06, Andrzej Hajda wrote: > > On 18.11.2023 00:01, Paz Zcharya wrote: > > > On Tue, Nov 14, 2023 at 10:13:59PM -0500, Rodrigo Vivi wrote: > > > > On Sun, Nov 05, 2023 at

Re: [Intel-gfx] [PATCH] drm/i915/display: Fix phys_base to be relative not absolute

2023-11-27 Thread Paz Zcharya
On Mon, Nov 27, 2023 at 8:20 PM Paz Zcharya wrote: > > On 21.11.2023 13:06, Andrzej Hajda wrote: > > On 18.11.2023 00:01, Paz Zcharya wrote: > > > On Tue, Nov 14, 2023 at 10:13:59PM -0500, Rodrigo Vivi wrote: > > > > On Sun, Nov 05, 2023 at 05:27:03PM +,

Re: [Intel-gfx] [PATCH] drm/i915/display: Fix phys_base to be relative not absolute

2023-11-28 Thread Paz Zcharya
On Tue, Nov 28, 2023 at 12:12:08PM +0100, Andrzej Hajda wrote: > On 28.11.2023 04:47, Paz Zcharya wrote: > > > > On Mon, Nov 27, 2023 at 8:20 PM Paz Zcharya wrote: > > > > Hey Andrzej, > > > > On a second thought, what do you think about something l

[PATCH] drm/i915/display: Check GGTT to determine phys_base

2023-11-30 Thread Paz Zcharya
tarting at 0 - on DG2, it uses lmem region which starts at 0 as well - on MTL, stolen_region points to stolen-local which starts at 0x80 Signed-off-by: Paz Zcharya --- .../drm/i915/display/intel_plane_initial.c| 45 +-- 1 file changed, 22 insertions(+), 23 deletions(-) dif

Re: [Intel-gfx] [PATCH] drm/i915/display: Fix phys_base to be relative not absolute

2023-11-30 Thread Paz Zcharya
On Tue, Nov 28, 2023 at 12:12:08PM +0100, Andrzej Hajda wrote: > On 28.11.2023 04:47, Paz Zcharya wrote: > > > > On Mon, Nov 27, 2023 at 8:20 PM Paz Zcharya wrote: > > > > > > On 21.11.2023 13:06, Andrzej Hajda wrote: > > > > > > > The sim

[PATCH] [v2] drm/i915/display: Check GGTT to determine phys_base

2023-12-06 Thread Paz Zcharya
n points to system memory, starting at 0 - on DG2, it uses lmem region which starts at 0 as well - on MTL, stolen_region points to stolen-local which starts at 0x80 Changes from v1: - Add an if statement for gen7-, where there is a 1:1 mapping Signed-off-by: Paz Zcharya -

[PATCH] drm/vkms: Add support for ABGR8888 pixel format

2024-10-07 Thread Paz Zcharya
Add support for pixel format ABGR, which is the default format on Android devices. This will allow us to use VKMS as the default display driver in Android Emulator (Cuttlefish) and increase VKMS adoption. Signed-off-by: Paz Zcharya --- drivers/gpu/drm/vkms/vkms_formats.c | 20

Re: [PATCH] drm/vkms: Add support for ABGR8888 pixel format

2024-10-09 Thread Paz Zcharya
On Mon, Oct 07, 2024 at 06:51:16PM +0200, Louis Chauvet wrote: > On 07/10/24 - 14:27, Paz Zcharya wrote: > > Add support for pixel format ABGR, which is the default format > > on Android devices. This will allow us to use VKMS as the default > > display driver in Android

[PATCH v2] drm/vkms: Add support for ABGR8888 pixel format

2025-01-29 Thread Paz Zcharya
From: Paz Zcharya Add support for pixel format ABGR, which is the default format on Android devices. This will allow us to use VKMS as the default display driver in Android Emulator (Cuttlefish) and increase VKMS adoption. Signed-off-by: Paz Zcharya --- Changes in v2: - Rebased on top of

Re: [PATCH] drm/vkms: Add support for ABGR8888 pixel format

2025-01-29 Thread Paz Zcharya
gt; drm/vkms: Add support for ABGR pixel format > > Add support for [...] adoption. > > Signed-off-by: Paz Zcharya > > --- > > Changes in v2: > [...] > > Can you send a "real" v2 with the correct commit message

[PATCH] drm/vkms: Add support for ABGR8888 pixel format

2025-01-27 Thread Paz Zcharya
functional changes. Signed-off-by: Paz Zcharya --- drivers/gpu/drm/vkms/vkms_formats.c | 32 +++ drivers/gpu/drm/vkms/vkms_plane.c | 1 + drivers/gpu/drm/vkms/vkms_writeback.c | 1 + 3 files changed, 34 insertions(+) diff --git a/drivers/gpu/drm/vkms/vkms_formats.c b

Re: [PATCH] drm/vkms: Add support for ABGR8888 pixel format

2025-01-28 Thread Paz Zcharya
On Tue, Jan 28, 2025 at 11:04:33AM +0100, Louis Chauvet wrote: > On 27/01/25 - 23:59, Paz Zcharya wrote: > > Add support for pixel format ABGR, which is the default format > > on Android devices. This will allow us to use VKMS as the default > > display driver in Android