Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Paul Menzel
Dear Arunpravin, Am 14.03.22 um 20:40 schrieb Arunpravin: handle a situation in the condition order-- == min_order, when order = 0, leading to order = -1, it now won't exit the loop. To avoid this problem, added a order check in the same condition, (i.e) when order is 0, we return -ENOSPC Sign

Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Paul Menzel
Dear Arunpravin, Am 15.03.22 um 10:01 schrieb Arunpravin: On 15/03/22 1:49 pm, Paul Menzel wrote: Am 14.03.22 um 20:40 schrieb Arunpravin: handle a situation in the condition order-- == min_order, when order = 0, leading to order = -1, it now won't exit the loop. To avoid this pr

[PATCH] drm/amdgpu: Use ternary operator in `vcn_v1_0_start()`

2022-03-15 Thread Paul Menzel
Remove the boilerplate of declaring a variable and using an if else statement by using the ternary operator. Signed-off-by: Paul Menzel --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b

Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Paul Menzel
Dear Arunpravin, Am 15.03.22 um 16:42 schrieb Arunpravin: On 15/03/22 2:35 pm, Paul Menzel wrote: Am 15.03.22 um 10:01 schrieb Arunpravin: On 15/03/22 1:49 pm, Paul Menzel wrote: Am 14.03.22 um 20:40 schrieb Arunpravin: handle a situation in the condition order-- == min_order, when

Re: [PATCH] drm: Fix a infinite loop condition when order becomes 0

2022-03-15 Thread Paul Menzel
Dear Arunprivin, Am 16.03.22 um 07:49 schrieb Arunpravin Paneer Selvam: On 15/03/22 9:14 pm, Paul Menzel wrote: Am 15.03.22 um 16:42 schrieb Arunpravin: On 15/03/22 2:35 pm, Paul Menzel wrote: Am 15.03.22 um 10:01 schrieb Arunpravin: On 15/03/22 1:49 pm, Paul Menzel wrote: Am

Re: [PATCH] drm/amd/display: Fixed the unused-but-set-variable warning

2022-03-17 Thread Paul Menzel
Dear Aashish, Am 17.03.22 um 15:01 schrieb Aashish Sharma: Thank you for your patch. If you are going to send a v2, please use imperative mood. Maybe: drm/amd/display: Fix unused-but-set-variable warning Fixed this kernel test robot warning: Maybe: Fix the kernel test robot warning bel

Re: [PATCH] drm: add a check to verify the size alignment

2022-03-20 Thread Paul Menzel
Dear Arunpravin, Am 21.03.22 um 06:59 schrieb Arunpravin Paneer Selvam: add a simple check to reject any size not aligned to the min_page_size. Nit: I’d start sentences with a capital letter. Could you please add a summary of the discussion to the commit message, so the question “Why?” is a

Re: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu

2022-03-22 Thread Paul Menzel
Dear Arunprivin, Thank you for your patch. Am 23.03.22 um 07:25 schrieb Arunpravin Paneer Selvam: - Remove drm_mm references and replace with drm buddy functionalities The commit message summary to me suggested, you can somehow use both allocators now. Two suggestions below: 1. Switch to

Commit messages (was: [PATCH v11] drm/amdgpu: add drm buddy support to amdgpu)

2022-03-23 Thread Paul Menzel
Dear Christian, Am 23.03.22 um 08:42 schrieb Christian König: Am 23.03.22 um 07:42 schrieb Paul Menzel: Am 23.03.22 um 07:25 schrieb Arunpravin Paneer Selvam: - Remove drm_mm references and replace with drm buddy functionalities The commit message summary to me suggested, you can

Re: Commit messages

2022-03-25 Thread Paul Menzel
Dear Christian, dear Daniel, dear Alex, Am 23.03.22 um 16:32 schrieb Christian König: Am 23.03.22 um 16:24 schrieb Daniel Stone: On Wed, 23 Mar 2022 at 15:14, Alex Deucher wrote: On Wed, Mar 23, 2022 at 11:04 AM Daniel Stone wrote: That's not what anyone's saying here ... No-one's demandi

Re: [PATCH] fbdev: defio: fix the pagelist corruption

2022-03-26 Thread Paul Menzel
Dear Chuansheng, Am 17.03.22 um 06:46 schrieb Chuansheng Liu: Easily hit the below list corruption: == list_add corruption. prev->next should be next (c0ceb090), but was ec604507edc8. (prev=ec604507edc8). WARNING: CPU: 65 PID: 3959 at lib/list_debug.c:26 __list_add_valid+0x53/0x

Re: [PATCH] fbdev: defio: fix the pagelist corruption

2022-03-27 Thread Paul Menzel
Dear Chuansheng, Am 28.03.22 um 02:58 schrieb Liu, Chuansheng: -Original Message- Sent: Saturday, March 26, 2022 4:11 PM Am 17.03.22 um 06:46 schrieb Chuansheng Liu: Easily hit the below list corruption: == list_add corruption. prev->next should be next (c0ceb090), but w

Re: [PATCH] drm/amdgpu: resolve s3 hang for r7340

2022-03-28 Thread Paul Menzel
Dear Zhenneng, Thank you for your patch. Am 28.03.22 um 06:05 schrieb Zhenneng Li: This is a workaround for s3 hang for r7340(amdgpu). Is it hanging when resuming from S3? Maybe also use the line below for the commit message summary: drm/amdgpu: Add 1 ms delay to init handler to fix s3 re

Re: [PATCH] drm/amdgpu: resolve s3 hang for r7340

2022-03-28 Thread Paul Menzel
[Cc: -Jack Zhang (invalid address) Am 28.03.22 um 09:36 schrieb Paul Menzel: Dear Zhenneng, Thank you for your patch. Am 28.03.22 um 06:05 schrieb Zhenneng Li: This is a workaround for s3 hang for r7340(amdgpu). Is it hanging when resuming from S3? Maybe also use the line below for the

Re: 回复: Re: [PATCH] drm/amdgpu: resolve s3 hang for r7340

2022-03-28 Thread Paul Menzel
:38 *发件人:*Paul Menzel […] Am 28.03.22 um 09:36 schrieb Paul Menzel: > Dear Zhenneng, > > > Thank you for your patch. > > Am 28.03.22 um 06:05 schrieb Zhenneng Li: >> This is a workaround for s3 hang for r7340(amdgpu). > > Is it hanging when resuming

Re: [PATCH v2] drm/amdgpu: fix that issue that the number of the crtc of the 3250c is not correct

2022-03-29 Thread Paul Menzel
Dear Tsung-Hua, Thank you for your patch. Am 30.03.22 um 04:46 schrieb Ryan Lin: The commit message summary is quite long and confusing. Maybe: Use 3 CRTC for 3250c to get internal display working [Why] External displays take priority over internal display when there are fewer display contr

Re: [PATCH v2] drm/amdgpu: fix that issue that the number of the crtc of the 3250c is not correct

2022-03-29 Thread Paul Menzel
[Cc: Remove undeliverable Chun Ming Zhou <mailto:david1.z...@amd.com>] Am 30.03.22 um 08:34 schrieb Paul Menzel: Dear Tsung-Hua, Thank you for your patch. Am 30.03.22 um 04:46 schrieb Ryan Lin: The commit message summary is quite long and confusing. Maybe: Use 3 CRTC for 3250c

Re: [PATCH] fbdev: defio: fix the pagelist corruption

2022-03-30 Thread Paul Menzel
[Cc: -jay...@intworks.biz as it bounces] Dear Chuansheng, Am 29.03.22 um 01:58 schrieb Liu, Chuansheng: -Original Message- From: Paul Menzel Sent: Monday, March 28, 2022 2:15 PM Am 28.03.22 um 02:58 schrieb Liu, Chuansheng: -Original Message- Sent: Saturday, March 26

[PATCH] drm/amdgpu: Fix typo in *whether* in comment

2022-02-18 Thread Paul Menzel
Signed-off-by: Paul Menzel --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 63a089992645..430e56583751 100644 --- a/drivers/gpu/drm/amd/amdgpu

Re: [PATCH] drm/amdgpu: check vm ready by evicting

2022-02-21 Thread Paul Menzel
Dear Qiang Yu, Am 21.02.22 um 11:12 schrieb Qiang Yu: Thank you for your patch. Reading the commit message summary, I have no idea what “check vm ready by evicting” means. Can you please rephrase it? Workstation application ANSA/META get this error dmesg: What version, and how can this b

Re: [PATCH v2] drm/amdgpu: check vm ready by amdgpu_vm->evicting flag

2022-02-22 Thread Paul Menzel
{ - return list_empty(&vm->evicted); + bool ret; + + amdgpu_vm_eviction_lock(vm); + ret = !vm->evicting; + amdgpu_vm_eviction_unlock(vm); + return ret; } /** Acked-by: Paul Menzel Kind regards, Paul

[PATCH 2/2] drm/amdgpu: Demote TMZ unsupported log message from warning to info

2021-09-13 Thread Paul Menzel
As the user cannot do anything about the unsupported Trusted Memory Zone (TMZ) feature, do not warn about it, but make it informational, so demote the log level from warning to info. Signed-off-by: Paul Menzel --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 1/2] drm/amdgpu: Clarify that TMZ unsupported message is due to hardware

2021-09-13 Thread Paul Menzel
: Trusted Memory Zone (TMZ) feature not supported by hardware Signed-off-by: Paul Menzel --- drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c index c7797eac83c3

Re: [PATCH 1/2] drm: Add Gamma and Degamma LUT sizes props to drm_crtc to validate.

2021-10-26 Thread Paul Menzel
+ + /** +* @gamma_lut_size: Size of Gamma LUT. Not used by legacy userspace such as +* X, which doesn't support large lut sizes. + */ + uint32_t gamma_lut_size; + /** * @gamma_size: Size of legacy gamma ramp reported to userspace. Set up * by calling drm_mode_crtc_set_gamma_size(). Acked-by: Paul Menzel Kind regards, Paul

Re: [PATCH v3 2/3] drm: Add Gamma and Degamma LUT sizes props to drm_crtc to validate.

2021-10-29 Thread Paul Menzel
Dear Mark, On 26.10.21 21:21, Mark Yacoub wrote: From: Mark Yacoub [Why] 1. drm_atomic_helper_check doesn't check for the LUT sizes of either Gamma or Degamma props in the new CRTC state, allowing any invalid size to be passed on. 2. Each driver has its own LUT size, which could also be diffe

Re: [PATCH] drm/amdgpu:Fixed the wrong macro definition in amdgpu_trace.h

2020-12-24 Thread Paul Menzel
Dear Chenyang, Am 23.12.20 um 02:19 schrieb Chenyang Li: In line 24 "_AMDGPU_TRACE_H" is missing an underscore. Nice catch. Could you please update the commit message summary, by adding a space after the prefix (colon), and using imperative mood [1]? drm/amdgpu: Fix macro name _AMDGPU_TRA

Unable to unselect VGA_ARB (VGA Arbitration)

2022-01-11 Thread Paul Menzel
Dear Linux folks, I am using Linux 5.16, and I am unable to unset `VGA_ARB` in Kconfig (`make menuconfig`). I have an Asus F2A85-M PRO with an AMD A6-6400K APU (integrated Radeon graphics device), so no legacy stuff. From `drivers/gpu/vga/Kconfig`: ``` config VGA_ARB bool "VGA Arbit

Re: [PATCH] drm: Require PCI for selecting VGA_ARB.

2019-01-09 Thread Paul Menzel
Dear Maarten, Thank you very much for the quick response. On 01/08/19 16:37, Maarten Lankhorst wrote: > Op 08-01-2019 om 16:07 schreef Paul Menzel: >> Building Linux 5.0-rc1 fails with the errors below. Please find the >> configuration file attached. >> >> ``` >&g

5.0-rc1 fails to build with vga/vgaarb.c:286:14: error: ‘PCI_VGA_STATE_CHANGE_DECODES’ undeclared

2019-01-09 Thread Paul Menzel
Dear Linux folks, Building Linux 5.0-rc1 fails with the errors below. Please find the configuration file attached. ``` $ make -j120 […] drivers/gpu/vga/vgaarb.c: In function ‘__vga_tryget’: drivers/gpu/vga/vgaarb.c:286:14: error: ‘PCI_VGA_STATE_CHANGE_DECODES’ undeclared (first use in this func

Re: randr: Virtual monitor not present with MST display

2019-03-06 Thread Paul Menzel
Dear Alex, On 03/05/19 20:07, Alex Deucher wrote: > On Tue, Mar 5, 2019 at 1:16 PM Paul Menzel wrote: >> Using the MST display Dell UP3214Q (two panels) with an AMD system, >> the virtual monitor object is not created. GDM and Xfce consider both >> panels as sepa

Re: randr: Virtual monitor not present with MST display

2019-03-18 Thread Paul Menzel
Dear Harry, On 18.03.19 21:55, Wentland, Harry wrote: On 2019-03-08 4:11 a.m., Michel Dänzer wrote: On 2019-03-06 5:35 p.m., Paul Menzel wrote: On 03/06/19 15:55, Michel Dänzer wrote: On 2019-03-06 1:41 p.m., Paul Menzel wrote: On 03/05/19 20:07, Alex Deucher wrote: On Tue, Mar 5, 2019

Re: [PATCH 3/4] drm/amd/display: In VRR mode, do DRM core vblank handling at end of vblank.

2019-03-19 Thread Paul Menzel
Dear Mario, On 18.03.19 18:19, Mario Kleiner wrote: In VRR mode, proper vblank/pageflip timestamps can only be computed after the display scanout position has left front-porch. Therefore delay calls to drm_crtc_handle_vblank(), and thereby calls to drm_update_vblank_count() and pageflip event d

Re: [PATCH linux-next] video: fbdev: fbmem: fix pointer reference to null device field

2022-02-11 Thread Paul Menzel
rm_device(device)); } else { Looks reasonable. Acked-by: Paul Menzel Kind regards, Paul PS: Please note, this should be unrelated to my problem though, as I didn’t use linux-next. (Let’s continue in the other thread though.)

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-20 Thread Paul Menzel
Dear Richard, Am 19.04.22 um 23:46 schrieb Gong, Richard: On 4/14/2022 2:52 AM, Paul Menzel wrote: [Cc: -kernel test robot ] […] Am 13.04.22 um 15:00 schrieb Alex Deucher: On Wed, Apr 13, 2022 at 3:43 AM Paul Menzel wrote: Thank you for sending out v4. Am 12.04.22 um 23:50 schrieb

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-20 Thread Paul Menzel
Dear Alex, Am 20.04.22 um 22:40 schrieb Alex Deucher: On Wed, Apr 20, 2022 at 4:29 PM Paul Menzel wrote: Am 19.04.22 um 23:46 schrieb Gong, Richard: On 4/14/2022 2:52 AM, Paul Menzel wrote: [Cc: -kernel test robot ] […] Am 13.04.22 um 15:00 schrieb Alex Deucher: On Wed, Apr 13

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-20 Thread Paul Menzel
Dear Richard, Am 20.04.22 um 22:56 schrieb Gong, Richard: On 4/20/2022 3:48 PM, Paul Menzel wrote: Am 20.04.22 um 22:40 schrieb Alex Deucher: On Wed, Apr 20, 2022 at 4:29 PM Paul Menzel wrote: Am 19.04.22 um 23:46 schrieb Gong, Richard: On 4/14/2022 2:52 AM, Paul Menzel wrote: [Cc

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-20 Thread Paul Menzel
Dear Richard, Am 21.04.22 um 03:12 schrieb Gong, Richard: On 4/20/2022 3:29 PM, Paul Menzel wrote: Am 19.04.22 um 23:46 schrieb Gong, Richard: On 4/14/2022 2:52 AM, Paul Menzel wrote: [Cc: -kernel test robot ] […] Am 13.04.22 um 15:00 schrieb Alex Deucher: On Wed, Apr 13, 2022 at 3

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-05-01 Thread Paul Menzel
Dear Richard, Sorry for the late reply. Am 26.04.22 um 15:53 schrieb Gong, Richard: On 4/21/2022 12:35 AM, Paul Menzel wrote: Am 21.04.22 um 03:12 schrieb Gong, Richard: On 4/20/2022 3:29 PM, Paul Menzel wrote: Am 19.04.22 um 23:46 schrieb Gong, Richard: On 4/14/2022 2:52 AM, Paul

Re: [PATCHv5] drm/amdgpu: vi: disable ASPM on Intel Alder Lake based systems

2022-05-01 Thread Paul Menzel
Dear Richard, Am 29.04.22 um 18:06 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD Volcanic Islands (VI) GFX cards, such as the WX3200 and RX640, that do not work with ASPM-enabled Intel Alder Lake based systems. Using these GF

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-05-03 Thread Paul Menzel
Dear Daniel, Am 03.05.22 um 14:25 schrieb Daniel Stone: On Sun, 1 May 2022 at 08:08, Paul Menzel wrote: Am 26.04.22 um 15:53 schrieb Gong, Richard: I think so. We captured dmesg log. Then the (whole) system did *not* freeze, if you could still log in (maybe over network) and execute

Re: [PATCH] fbdev: defio: fix the pagelist corruption

2022-03-31 Thread Paul Menzel
Dear Chuansheng, Am 31.03.22 um 02:06 schrieb Liu, Chuansheng: -Original Message- From: Paul Menzel Sent: Thursday, March 31, 2022 12:47 AM […] Am 29.03.22 um 01:58 schrieb Liu, Chuansheng: -Original Message- From: Paul Menzel Sent: Monday, March 28, 2022 2:15 PM Am

Re: [PATCH 1/1] drm: add PSR2 support and capability definition as per eDP 1.5

2022-03-31 Thread Paul Menzel
Dear David, Thank you for your patch. Am 31.03.22 um 19:26 schrieb David Zhang: [why & how] In eDP 1.5 spec, some new DPCD bit fileds are defined for PSR-SU support. You could be specific by using the exact number two. Maybe: As per eDP 1.5 specification, add the two DPCD bit fields below f

Re: [PATCH] drm/amdgpu/vcn: remove Unneeded semicolon

2022-03-31 Thread Paul Menzel
Dear Haowen, Thank you for your patch. Am 31.03.22 um 07:56 schrieb Haowen Bai: In the commit message summary, please use: Remove unneeded semicolon report by coccicheck: drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c:1951:2-3: Unneeded semicolon fixed c543dcb ("drm/amdgpu/vcn: Add VCN ras error qu

Public patches but non-public development branch (Re: [PATCH 1/1] drm/amdkfd: Add missing NULL check in svm_range_map_to_gpu)

2022-04-05 Thread Paul Menzel
Dear Christian, Am 05.04.22 um 08:54 schrieb Christian König: Am 05.04.22 um 08:45 schrieb Paul Menzel: Am 04.04.22 um 23:42 schrieb Philip Yang: bo_adev is NULL for system memory mapping to GPU. Fixes: 05fe8eeca92 (drm/amdgpu: fix TLB flushing during eviction) Sorry, where can I find

Re: Public patches but non-public development branch

2022-04-05 Thread Paul Menzel
Dear Alex, Am 05.04.22 um 15:14 schrieb Alex Deucher: On Tue, Apr 5, 2022 at 3:02 AM Paul Menzel wrote: Am 05.04.22 um 08:54 schrieb Christian König: Am 05.04.22 um 08:45 schrieb Paul Menzel: Am 04.04.22 um 23:42 schrieb Philip Yang: bo_adev is NULL for system memory mapping to GPU

Re: Public patches but non-public development branch

2022-04-05 Thread Paul Menzel
Dear Alex, Am 05.04.22 um 16:13 schrieb Alex Deucher: On Tue, Apr 5, 2022 at 10:03 AM Paul Menzel wrote: Am 05.04.22 um 15:14 schrieb Alex Deucher: On Tue, Apr 5, 2022 at 3:02 AM Paul Menzel wrote: Am 05.04.22 um 08:54 schrieb Christian König: Am 05.04.22 um 08:45 schrieb Paul Menzel

Re: [PATCH v12] drm/amdgpu: add drm buddy support to amdgpu

2022-04-07 Thread Paul Menzel
Dear Arunpravin, Thank you for your patch. Am 07.04.22 um 07:46 schrieb Arunpravin Paneer Selvam: - Switch to drm buddy allocator - Add resource cursor support for drm buddy I though after the last long discussion, you would actually act on the review comments. Daniel wrote a good summary,

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-08 Thread Paul Menzel
Dear Richard, Thank you for your patch. Am 08.04.22 um 21:05 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD GFX cards (such as WX3200 and RX640) that cannot be used with Intel AlderLake based systems to enable ASPM. Using the

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread Paul Menzel
Dear Richard, Thank you for your response, but please reply to your own reply next time. Am 11.04.22 um 02:37 schrieb Gong, Richard: On 4/8/2022 7:19 PM, Paul Menzel wrote: Thank you for your patch. Am 08.04.22 um 21:05 schrieb Richard Gong: Active State Power Management (ASPM) feature

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread Paul Menzel
[Cc: +] Dear Richard, Am 11.04.22 um 02:27 schrieb Gong, Richard: On 4/8/2022 7:19 PM, Paul Menzel wrote: Am 08.04.22 um 21:05 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD GFX cards (such as WX3200 and RX640) that

Re: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-11 Thread Paul Menzel
Dear Richard, Am 11.04.22 um 13:38 schrieb Gong, Richard: On 4/11/2022 2:41 AM, Paul Menzel wrote: [Cc: +] Am 11.04.22 um 02:27 schrieb Gong, Richard: On 4/8/2022 7:19 PM, Paul Menzel wrote: Am 08.04.22 um 21:05 schrieb Richard Gong: Active State Power Management (ASPM) feature is

AMD Display Core (DC) patches (was: [PATCH 13/16] drm/amd/display: Revert FEC check in validation)

2022-04-11 Thread Paul Menzel
[Cc: +dri-devel@lists.freedesktop.org, +Daniel Vetter, +Alexander Deucher, +Greg KH] Dear Alex, I am a little confused and upset about how Display Core patches are handled in the Linux kernel. Am 25.03.22 um 23:53 schrieb Alex Hung: From: Martin Leung git puts a line “This reverts com

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-13 Thread Paul Menzel
Dear Richard, Thank you for sending out v4. Am 12.04.22 um 23:50 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD GFX cards (such as WX3200 and RX640) that won't work with ASPM-enabled Intel Alder Lake based systems. Using thes

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-14 Thread Paul Menzel
[Cc: -kernel test robot ] Dear Alex, dear Richard, Am 13.04.22 um 15:00 schrieb Alex Deucher: On Wed, Apr 13, 2022 at 3:43 AM Paul Menzel wrote: Thank you for sending out v4. Am 12.04.22 um 23:50 schrieb Richard Gong: Active State Power Management (ASPM) feature is enabled since kernel

Re: [PATCH 1/2] Documentation/gpu: Add entries to amdgpu glossary

2022-04-16 Thread Paul Menzel
Dear Tales, Thank you for your patch. Am 15.04.22 um 21:50 schrieb Tales Lelo da Aparecida: Add missing acronyms to the amdgppu glossary. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1939#note_1309737 Signed-off-by: Tales Lelo da Aparecida --- Documentation/gpu/amdgpu/amdgpu-glo

[Regression drm-tip] Internal audio device missing

2019-12-26 Thread Paul Menzel
Dear Linux folks, With $ git describe --tags drm-tip/drm-tip v5.5-rc3-1481-ga20d8cd6901a the internal audio device is not available, and just a dummy device. Running `alsa-info.sh` [1], the messages below are shown with the problematic Linux kernel. alsactl: get_controls:567: s

Re: [Regression drm-tip] Internal audio device missing

2019-12-27 Thread Paul Menzel
Dear Takashi, Am 26.12.19 um 11:03 schrieb Takashi Iwai: On Thu, 26 Dec 2019 10:47:18 +0100, Paul Menzel wrote: With $ git describe --tags drm-tip/drm-tip v5.5-rc3-1481-ga20d8cd6901a the internal audio device is not available, and just a dummy device. Running `alsa-info.sh` [1

[PATCH] Initialize ATA before graphics

2020-02-24 Thread Paul Menzel
From: Arjan van de Ven Date: Thu, 2 Jun 2016 23:36:32 -0500 ATA init is the long pole in the boot process, and its asynchronous. Move the graphics init after it, so that ATA and graphics initialize in parallel. Signed-off-by: Paul Menzel --- 1. Taken from Clear Linux: https://github.com

[PATCH] matroxfb: G200eW: Increase max memory from 1 MB to 16 MB

2023-01-02 Thread Paul Menzel
set maxvram of vbG200eW to the same as vbG200 to avoid black screen") Link: https://lore.kernel.org/linux-fbdev/972999d3-b75d-5680-fcef-6e6905c52...@suse.de/T/#mb6953a9995ebd18acc8552f99d6db39787aec775 Cc: it+linux-fb...@molgen.mpg.de Cc: Z. Liu Cc: Rich Felker Cc: sta...@vger.kernel.org

[PATCH v2] matroxfb: G200eW: Increase max memory from 1 MB to 16 MB

2023-01-02 Thread Paul Menzel
set maxvram of vbG200eW to the same as vbG200 to avoid black screen") Link: https://lore.kernel.org/linux-fbdev/972999d3-b75d-5680-fcef-6e6905c52...@suse.de/T/#mb6953a9995ebd18acc8552f99d6db39787aec775 Cc: it+linux-fb...@molgen.mpg.de Cc: Z. Liu Cc: Rich Felker Cc: sta...@vger.kernel.org

Problems with delivery to dal...@libc.org (was: [PATCH v2] matroxfb: G200eW: Increase max memory from 1 MB to 16 MB)

2023-01-02 Thread Paul Menzel
[Cc: Back to dal...@libc.org] Dear Linux folks, Please ignore version 2. Am 02.01.23 um 15:02 schrieb Paul Menzel: […] --- Update Rich’s address. I should have read the undelivered message better: ``` : host brightrain.aerifal.cx[216.12.86.13] said: 550-Message blocked for policy

[PATCH] drm/amdgpu: Log if device is unsupported

2023-06-05 Thread Paul Menzel
r the individual device is supported by the driver or not. Log that case, so users looking at the logs know what is going on. Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2608 Signed-off-by: Paul Menzel --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 +++- 1 file changed, 3 insertions(

mt8183 (google/krane): Resolution over USB-C adapter limited to 1280x720

2023-08-17 Thread Paul Menzel
Dear Linux folks, Using the ten inch tablet Lenovo IdeaPad Duet Chromebook 2in1 with recent ChromeOS, connecting a Dell DA200 (strange display chip inside) or Dell DA300z the available resolutions are limited to 1280x720 and not the supported 1920x1080. The Dell monitor is connected over HDMI

drm: BUG: unable to handle page fault for address: 17ec6000

2020-07-09 Thread Paul Menzel
Dear Linux folks, Building Linux v5.8-rc4-25-gbfe91da29bfad with Clang/LLD 1:11~++20200701093119+ffee8040534-1~exp1 from Debian experimental for 32-bit (`ARCH=i386`), starting Weston (Wayland) or X.Org Server results in non-working screen, and Linux shows the trace below [1]. [ 502.044997

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-26 Thread Paul Menzel
Dear Kees, Am 24.07.20 um 00:32 schrieb Kees Cook: On Thu, Jul 23, 2020 at 09:10:15PM +, Mazin Rezk wrote: When amdgpu_dm_atomic_commit_tail is running in the workqueue, drm_atomic_state_put will get called while amdgpu_dm_atomic_commit_tail is running, causing a race condition where state

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-26 Thread Paul Menzel
Dear Kees, Am 24.07.20 um 19:33 schrieb Kees Cook: On Fri, Jul 24, 2020 at 09:45:18AM +0200, Paul Menzel wrote: Am 24.07.20 um 00:32 schrieb Kees Cook: On Thu, Jul 23, 2020 at 09:10:15PM +, Mazin Rezk wrote: As Linux 5.8-rc7 is going to be released this Sunday, I wonder, if commit

Re: [PATCH] amdgpu_dm: fix nonblocking atomic commit use-after-free

2020-07-28 Thread Paul Menzel
Dear Linux folks, Am 25.07.20 um 07:20 schrieb Mazin Rezk: On Saturday, July 25, 2020 12:59 AM, Duncan wrote: On Sat, 25 Jul 2020 03:03:52 + Mazin Rezk wrote: Am 24.07.20 um 19:33 schrieb Kees Cook: There was a fix to disable the async path for this driver that worked around the bug t

[PATCH 1/3] gpu/drm: Fix spelling of *sequence* and *frequency*

2020-05-11 Thread Paul Menzel
Fix all occurrences with the commands below. $ git grep -l equnce drivers/gpu/ | xargs sed -i 's/equnce/equence/g' Cc: Alex Deucher Cc: Christian König Cc: David (ChunMing) Zhou Cc: amd-...@lists.freedesktop.org Signed-off-by: Paul Menzel --- drivers/gpu/drm/amd/amdgpu/gfx_v

[PATCH 2/3] gpu/drm: Fix spelling of *frequency*

2020-05-11 Thread Paul Menzel
u Cc: amd-...@lists.freedesktop.org Signed-off-by: Paul Menzel --- drivers/gpu/drm/amd/include/atombios.h | 4 ++-- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- drivers/gpu/drm/radeon/atombios.h | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/include/ato

Re: [regression 5.7-rc1] System does not power off, just halts

2020-04-14 Thread Paul Menzel
Dear Prike, dear Alex, dear Linux folks, Am 13.04.20 um 10:44 schrieb Paul Menzel: A regression between causes a system with the AMD board MSI B350M MORTAR (MS-7A37) with an AMD Ryzen 3 2200G not to power off any more but just to halt. The regression is introduced in 9ebe5422ad6c

General protection fault: RIP: 0010:free_block+0xdc/0x1f0

2020-09-15 Thread Paul Menzel
Dear Andrew folks, dear Linux folks, With Linux 5.9-rc4 on a Dell OptiPlex 5080 with Intel Core i7-10700 CPU @ 2.90GHz, and external 01:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Oland [Radeon HD 8570 / R7 240/340 OEM] [1002:6611] (rev 87) running gra

drm fixes for 3.11: Tag more patches for stable? (was: [git pull] drm fixes)

2013-08-09 Thread Paul Menzel
Dear Dave, Am Freitag, den 09.08.2013, 05:53 +0100 schrieb Dave Airlie: […] > The following changes since commit c095ba7224d8edc71dcef0d655911399a8bd4a3f: > > Linux 3.11-rc4 (2013-08-04 13:46:46 -0700) > > are available in the git repository at: > > git://people.freedesktop.org/~airlied/

Re: [4.17-rc4+ regression] X server does not start anymore with segmentation fault in `r600_dri.so`

2018-05-15 Thread Paul Menzel
Dear Michel, Am 15.05.2018 um 10:41 schrieb Michel Dänzer: On 2018-05-15 08:38 AM, Paul Menzel wrote: On 2018-05-14 10:44, Michel Dänzer wrote: On 2018-05-13 11:01 AM, Paul Menzel wrote: There is a regression introduced by a commit after Linux 4.17-rc4 causing the X.Org X server start to

Re: [PATCH v3 03/13] fbdev: add kerneldoc do remove_conflicting_framebuffers()

2018-09-05 Thread Paul Menzel
oved. > + */ > int remove_conflicting_framebuffers(struct apertures_struct *a, > const char *name, bool primary) > { Acked-by: Paul Menzel Kind regards, Paul smime.p7s Description: S/MIME Cryptographic Signature ___ dri-devel m

Decrease boot time by not probing unconnected ports to improve desktop user experience

2018-07-30 Thread Paul Menzel
Dear Linux folks, It looks like, that loading a graphics driver, the DRM methods probe each connector. For example, the Asus F2A85-M PRO has four monitor ports, but only one monitor is connected over DVI. Here is the log excerpt with Linux 4.18-rc6+. [0.200631] [drm] DFP2: INTERNA

[PATCH] drm/i915/fbc: Add sizes to info message about reducing fb size

2024-05-13 Thread Paul Menzel
useful to the user, add the sizes to the message. Signed-off-by: Paul Menzel --- drivers/gpu/drm/i915/display/intel_fbc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c index b453fcbd67da

Powered off Philips TV sends corrupt EDID causing flickering

2023-11-21 Thread Paul Menzel
Dear Linux folks, Connecting a USB Type-C port replicator [1] to the only USB Type-C port of the Dell XPS 13 9360 with Debian sid/unstable and Debian’s Linux kernel 6.10.5, and then connecting a Philips 40PFL5206H/12 TV device, that is powered off or in standby, to the HDMI port, Linux logs:

Re: Powered off Philips TV sends corrupt EDID causing flickering

2023-11-23 Thread Paul Menzel
Dear Jani, Thank you for your reply. Am 22.11.23 um 11:38 schrieb Jani Nikula: On Tue, 21 Nov 2023, Paul Menzel wrote: Connecting a USB Type-C port replicator [1] to the only USB Type-C port of the Dell XPS 13 9360 with Debian sid/unstable and Debian’s Linux kernel 6.10.5, and then

Re: [PATCH v2] drm/vc4: Fix sleeps during the IRQ handler for DSI transactions.

2017-10-14 Thread Paul Menzel
Dear Eric, Some nit picks where stuff contradicts the coding style. Am Freitag, den 13.10.2017, 17:12 -0700 schrieb Eric Anholt: > VC4's DSI1 has a bug where the AXI connection is broken for 32-bit > writes from the CPU, so we use the DMA engine to DMA 32-bit values > into registers instead. Th

Re: dix/dispatch.c:4049: AttachOffloadGPU: Assertion `new->current_master == pScreen' failed.

2017-08-14 Thread Paul Menzel
Dear Michel, Thank you for your reply. On 08/14/17 03:15, Michel Dänzer wrote: On 11/08/17 01:02 AM, Paul Menzel wrote: On 08/10/17 15:14, Paul Menzel wrote: Getting Dell Precision 3620 systems with an Intel Skylake system i7-6700K, and an external AMD graphics card, the X.Org server

Re: dix/dispatch.c:4049: AttachOffloadGPU: Assertion `new->current_master == pScreen' failed.

2017-08-15 Thread Paul Menzel
Dear Michel, On 2017-08-15 03:19, Michel Dänzer wrote: On 15/08/17 02:48 AM, Paul Menzel wrote: On 08/14/17 03:15, Michel Dänzer wrote: On 11/08/17 01:02 AM, Paul Menzel wrote: On 08/10/17 15:14, Paul Menzel wrote: Xorg: /dev/shm/bee-root/xorg-server/xorg-server-1.19.3-0/source/dix

Please use HTTPS URLs for Patchwork references

2017-07-16 Thread Paul Menzel
Dear Linux folks, Currently commits contain non HTTPS URLs like below. ``` Link: http://patchwork.freedesktop.org/patch/msgid/20170601143619.27840-7-ville.syrj...@linux.intel.com ``` I guess these are generated by scripts. Could you please update them to generate HTTPS URLs, as that’s where th

Re: [PATCH] dim: Switch Link: tags to https://

2017-07-16 Thread Paul Menzel
Dear Daniel, Am Sonntag, den 16.07.2017, 12:26 +0200 schrieb Daniel Vetter: > http: gets a "301 moved permanently" reply. > > Reported-by: Paul Menzel > Cc: Paul Menzel > Signed-off-by: Daniel Vetter Reviewed-by: Paul Menzel Thanks, Paul signature.asc Descrip

Re: [PATCH 11/14] drm/mgag200: Consolidate depth/bpp handling

2017-07-20 Thread Paul Menzel
Dear Takashi, Thank you for posting these patches for review. Am Dienstag, den 18.07.2017, 16:43 +0200 schrieb Takashi Iwai: > From: Egbert Eich > > The depth/bpp handling for chips with limited memory in commit > 918be888d613 ("drm/mgag200: on cards with < 2MB VRAM default to > 16-bit") was

OT: Patches for Chromium browser to use VAAPI available

2017-07-31 Thread Paul Menzel
Dear Linux folks, Just a small note, that Intel pushed patches for the Chromium browser for review [1] to use VAAPI [2] along with vaapi-driver to run all supported media use cases with hardware acceleration. This will hopefully let GNU/Linux systems desktop to catch up further to Microsoft Wind

dix/dispatch.c:4049: AttachOffloadGPU: Assertion `new->current_master == pScreen' failed.

2017-08-12 Thread Paul Menzel
Dear Linux folks, Getting Dell Precision 3620 systems with an Intel Skylake system i7-6700K, and an external AMD graphics card, the X.Org server does not start and hits an assert. The software stack is Linux 4.9.38 and 4.12.5, X.Org server 1.19.3 and xf86-video-amdgpu 1.3.0. ``` $ lspci -nn

Re: dix/dispatch.c:4049: AttachOffloadGPU: Assertion `new->current_master == pScreen' failed.

2017-08-12 Thread Paul Menzel
Dear Linux folks, On 08/10/17 15:14, Paul Menzel wrote: Getting Dell Precision 3620 systems with an Intel Skylake system i7-6700K, and an external AMD graphics card, the X.Org server does not start and hits an assert. The software stack is Linux 4.9.38 and 4.12.5, X.Org server 1.19.3 and

[PATCH] Documentation: kernel-parameters.txt Add drm_kms_helper.poll

2012-10-04 Thread Paul Menzel
you also add advises what people should do? Like, if it is disabled people can still enable the external monitor by running ?. > > dscc4.setup=[NET] > > > > dyndbg[="val"] [KNL,DYNAMIC_DEBUG] > > -- > > 1.7.9.5 Acked-by: Paul Menzel

Using Linux 3.2.23, GNOME 3.4 fallback, `evolution --component=mail mailto:i...@example.net` hangs

2012-10-07 Thread Paul Menzel
Dear Linux folks, using Debian Sid/unstable, clicking on a mail address in Iceweasel (Firefox) a composer window is opened in Evolution 3.4.3-1. But then the windows are only gray and hang and the only way to fix this is to kill the process. I reported this issue to the GNOME Bugzilla as 685640 a

[PATCH] drm/radeon: check if pcie gen 2 is already enabled

2012-10-09 Thread Paul Menzel
Am Montag, den 08.10.2012, 17:48 -0400 schrieb alexdeucher at gmail.com: > From: Alex Deucher > > If so, skip enabling it. Does that fix any error/problem or is it just for speed reasons? > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/radeon/evergreen.c |8 ++-- > drivers/gpu/d

[PATCH] radeon: fix tile_split of 128-bit surface formats with 8x MSAA

2012-10-16 Thread Paul Menzel
Dear Marek, Am Dienstag, den 16.10.2012, 02:21 +0200 schrieb Marek Ol??k: > The calculation led to the number 8192, which is too high. what is the reason it is limited to 4096? Hardware limitation? What are the ramifications? GPU hangs, rendering errors? > --- > radeon/radeon_surface.c |2

Linux 3.2.23: Flickering when logging into GNOME Shell or Unity

2012-10-17 Thread Paul Menzel
Dear Linux folks, setting up an ASUS M2A-VM after some months with [3.178337] [drm] initializing kernel modesetting (RS690 0x1002:0x791E 0x1043:0x826D). logging in into GNOME Shell (GNOME 3) or for testing with Ubuntu 12.04 and Unity, the image flickers for a second and then works

Linux 3.x: Flickering when logging into GNOME Shell or Unity

2012-10-17 Thread Paul Menzel
Dear Linux folks, Am Mittwoch, den 17.10.2012, 16:49 +0200 schrieb Paul Menzel: > setting up an ASUS M2A-VM after some months with > > [3.178337] [drm] initializing kernel modesetting (RS690 > 0x1002:0x791E 0x1043:0x826D). > > logging in into GNOME Shell (GNOME

Linux 3.x: Flickering when logging into GNOME Shell or Unity

2012-10-17 Thread Paul Menzel
Am Mittwoch, den 17.10.2012, 16:25 -0400 schrieb Alex Deucher: > On Wed, Oct 17, 2012 at 11:26 AM, Paul Menzel wrote: > > Am Mittwoch, den 17.10.2012, 16:49 +0200 schrieb Paul Menzel: > > > >> setting up an ASUS M2A-VM after some months with > >> > >>

Linux 3.x: Flickering when logging into GNOME Shell or Unity

2012-10-19 Thread Paul Menzel
Am Donnerstag, den 18.10.2012, 18:14 -0400 schrieb Alex Deucher: > On Wed, Oct 17, 2012 at 4:48 PM, Paul Menzel wrote: > > Am Mittwoch, den 17.10.2012, 16:25 -0400 schrieb Alex Deucher: > >> On Wed, Oct 17, 2012 at 11:26 AM, Paul Menzel wrote: > > > >> > Am M

[edid-decode] [PATCH] extract_string: Replace `isalnum()` with `isprint()` to allow underscores

2012-10-29 Thread Paul Menzel
-off-by: Paul Menzel -- 1. I do not know if the X server or the Intel DDX driver(?) writes the value to `Xorg.0.log`. 2. Also I did not check the EDID specification if underscores are actually allowed. 3. `isascii()` cannot be used as it returns true also for '\n'. --- edid-decode.c |

call for help: Test of Intel 915/915GM with 1920x1080 monitor

2012-10-29 Thread Paul Menzel
Dear Linux folks, TLDR; I am interested if connecting an Intel 915 based device over VGA to a 1920x1080 monitor works for someone out of the box. I am experiencing a problem with 915GM based ASUS Eee PC 701 4G laptop, where `xrandr --output VGA1 --auto` does not give a proper image on a 1920x108

[PATCH v4 3/3] drm: Add EDID quirk for LG L246WP

2012-09-04 Thread Paul Menzel
e test if the monitor is sending the same EDID information over VGA and HDMI? Unfortunately I do not have the means (for HDMI) for the TVs here, so it would be great, if you could test that. > Signed-off-by: Ian Pilcher > Acked-by: Paul Menzel > --- > drivers/gpu/drm/drm_edi

[PATCH] drm/exynos: fix double call of drm_prime_(init/destroy)_file_private

2012-09-06 Thread Paul Menzel
Dear Inki Dae, Am Donnerstag, den 06.09.2012, 11:35 +0900 schrieb InKi Dae: > 2012/9/6 Mandeep Singh Baines : > > The double invocations are incorrect but seem to be safe so I don't > > think this will fix any bugs. > > > > Before: > > > > [7.639366] drm_prime_init_file ee3675d0 > > [7.6

[PATCH V6] drm: edid: add support for E-DDC

2012-09-08 Thread Paul Menzel
Dear Shirish, thank you for your answers and patience. Please just sent plain text message to mailings lists and adhere to the netiquette (inline quoting) [1]. That would be awesome. Am Samstag, den 08.09.2012, 08:49 -0700 schrieb Shirish S: > On Sat, Sep 8, 2012 at 3:35 AM, Dave Airlie wrote

  1   2   3   4   >