[PATCH 16/30] drm/gma500/psb: Convert to gma_crtc_dpms()

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 104 + 1 file changed, 1 insertion(+), 103 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c index 940c6f2..b52bde2

[PATCH 19/30] drm/gma500/psb: Convert to generic crtc->destroy

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 23 +-- 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c index b52bde2..f4d308f 100644 --- a

[PATCH 17/30] drm/gma500/oak: Use identical generic crtc funcs

2013-07-16 Thread Patrik Jakobsson
Use the generic gma functions instead of the oaktrail functions where they are identical. Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/oaktrail_crtc.c | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/gma500

[PATCH 20/30] drm/gma500: Add generic cursor functions

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gma_display.c | 151 +++ drivers/gpu/drm/gma500/gma_display.h | 5 ++ 2 files changed, 156 insertions(+) diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c index

[PATCH 21/30] drm/gma500/cdv: Convert to generic cursor funcs

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_display.c | 130 + 1 file changed, 2 insertions(+), 128 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500/cdv_intel_display.c index e30761a..2351f42

[PATCH 22/30] drm/gma500/psb: Convert to generic cursor funcs

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 157 + 1 file changed, 2 insertions(+), 155 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c index f4d308f..1e6a357

[PATCH 23/30] drm/gma500: Add generic encoder functions

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gma_display.c | 41 ++ drivers/gpu/drm/gma500/gma_display.h | 4 drivers/gpu/drm/gma500/psb_intel_drv.h | 10 + 3 files changed, 55 insertions(+) diff --git a/drivers/gpu/drm/gma500

[PATCH 24/30] drm/gma500: Convert to generic encoder funcs

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_crt.c | 13 drivers/gpu/drm/gma500/cdv_intel_display.c | 4 +-- drivers/gpu/drm/gma500/cdv_intel_dp.c| 17 +- drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 19 ++- drivers/gpu/drm

[PATCH 25/30] drm/gma500: Add generic crtc save/restore funcs

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gma_display.c | 105 +++ drivers/gpu/drm/gma500/gma_display.h | 3 + 2 files changed, 108 insertions(+) diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c index

[PATCH 26/30] drm/gma500/psb: Convert to generic save/restore

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 109 + 1 file changed, 2 insertions(+), 107 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c index a419e79..317c585

[PATCH 27/30] drm/gma500/cdv: Convert to generic save/restore

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_display.c | 172 + 1 file changed, 2 insertions(+), 170 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500/cdv_intel_display.c index 257e0e8..b84912f

[PATCH 29/30] drm/gma500/psb: Convert to generic set_config()

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c index 317c585..05faf1c 100644 --- a

[PATCH 28/30] drm/gma500: Add generic set_config() function

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/gma_display.c | 16 drivers/gpu/drm/gma500/gma_display.h | 3 +++ 2 files changed, 19 insertions(+) diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c index cca40c0..2a3e925

[PATCH 30/30] drm/gma500/cdv: Convert to generic set_config()

2013-07-16 Thread Patrik Jakobsson
Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_display.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500/cdv_intel_display.c index b84912f..6bca1fe 100644 --- a

[PATCH v3 2/4] drm/gem: convert to new unified vma manager

2013-07-18 Thread Patrik Jakobsson
s exactly the same as before with an > additional lock inside of the vma-manager, which strictly wouldn't be > needed for gem. > > v2: > - rebase on drm-next > - init nodes via drm_vma_node_reset() in drm_gem.c > v3: > - fix tegra > > Cc: Inki Dae > Cc: P

[PATCH 1/3] drm/gma500: Rename psb_intel_crtc to gma_crtc

2013-07-30 Thread Patrik Jakobsson
The psb_intel_crtc is generic and should be named appropriately Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_crt.c | 7 +- drivers/gpu/drm/gma500/cdv_intel_display.c | 28 +++ drivers/gpu/drm/gma500/cdv_intel_dp.c| 10 +-- drivers/gpu/drm/gma500

[PATCH 2/3] drm/gma500: Rename psb_intel_connector to gma_connector

2013-07-30 Thread Patrik Jakobsson
The psb_intel_connector is generic and should be named appropriately Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_crt.c | 14 +++--- drivers/gpu/drm/gma500/cdv_intel_dp.c | 16 drivers/gpu/drm/gma500/cdv_intel_hdmi.c| 12

[PATCH 3/3] drm/gma500: Rename psb_intel_encoder to gma_encoder

2013-07-30 Thread Patrik Jakobsson
The psb_intel_encoder is generic and should be named appropriately Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_crt.c | 31 --- drivers/gpu/drm/gma500/cdv_intel_display.c | 10 +-- drivers/gpu/drm/gma500/cdv_intel_dp.c| 130

[Intel-gfx] [PATCH 1/3] drm/gma500: Remove useless define

2013-07-31 Thread Patrik Jakobsson
- > struct cdv_intel_limit_t { > struct cdv_intel_range_t dot, vco, n, m, m1, m2, p, p1; > struct cdv_intel_p2_t p2; > -- > 1.8.3 Hi St?phane I have already removed that define in my gma500-next branch. You can check the official repo at: git://github.com/patjak/drm-gma500 gma500-next Thanks Patrik Jakobsson

[PATCH 1/3] drm/gma500: Unpin framebuffer when destroying it

2013-06-05 Thread Patrik Jakobsson
On Sun, May 26, 2013 at 11:00 PM, Daniel Vetter wrote: > On Sun, May 26, 2013 at 10:31 PM, Patrik Jakobsson > wrote: >> On Sun, May 26, 2013 at 9:07 PM, Daniel Vetter wrote: >>> On Sun, May 26, 2013 at 08:03:53PM +0200, Patrik Jakobsson wrote: >>>> A framebuffe

[PATCH 1/2] drm/gma500/psb: Unpin framebuffer on crtc disable

2013-06-08 Thread Patrik Jakobsson
com/show_bug.cgi?id=889511 Bugzilla: https://bugzilla.novell.com/show_bug.cgi?id=812113 Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/psb_intel_display.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma

[PATCH 2/2] drm/gma500/cdv: Unpin framebuffer on crtc disable

2013-06-08 Thread Patrik Jakobsson
com/show_bug.cgi?id=889511 Bugzilla: https://bugzilla.novell.com/show_bug.cgi?id=812113 Signed-off-by: Patrik Jakobsson --- drivers/gpu/drm/gma500/cdv_intel_display.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma

[PATCH 1/2] drm/gma500/psb: Unpin framebuffer on crtc disable

2013-06-08 Thread Patrik Jakobsson
On Sat, Jun 8, 2013 at 9:01 PM, Patrik Jakobsson wrote: > The framebuffer needs to be unpinned in the crtc->disable callback > because of previous pinning in psb_intel_pipe_set_base(). This will fix > a memory leak where the framebuffer was released but not unpinned > properly.

[GIT PULL] gma500-fixes for 3.10-rc6

2013-06-09 Thread Patrik Jakobsson
for you to fetch changes up to 70b1304eeedf211fc9fa185b43350bd9ab4c119c: drm/gma500/cdv: Fix cursor gem obj referencing on cdv (2013-06-09 18:03:57 +0200) -------- Patrik Jakobsson (5): drm/gma500: Add fb gtt offset to fb base

[patch] drm/gma500: missing error codes in psb_driver_load()

2015-04-17 Thread Patrik Jakobsson
On Fri, Apr 17, 2015 at 2:24 PM, Dan Carpenter wrote: > We should return an error code here. In the current code they can only > fail if there is an allocation error so -ENOMEM is appropriate. > > Signed-off-by: Dan Carpenter Reviewed-by: Patrik Jakobsson > diff --git a/

Remove Code in psb_drb.h

2014-11-22 Thread Patrik Jakobsson
On Sat, Nov 22, 2014 at 2:45 PM, nick wrote: > Greetings again David and other maintainers, > I am wondering if I can remove the following code below my message in > psb_drv.h as you state it's unneeded in a TODO. > Cheers Nick > /* TODO: To get rid of */ > #define PSB_TT_PRIV0_LIMIT (256*1

[PATCH] drivers:gpu:drm Remove unneeded struct of type psb_intel_i2c_chan in the header file psb_drv.h

2014-11-30 Thread Patrik Jakobsson
On Sun, Nov 30, 2014 at 3:24 AM, Nicholas Krause wrote: > Removes unneeeded struct *lvds_i2c_bus of type, psb_intel_i2c_chan as this > struct > is no needed due to never being used in the header file, psb_drv.h and > therefore > should be removed from this header file. > > Signed-off-by: Nichola

[PATCH] drm/dp-helper: Move the legacy helpers to gma500

2014-10-22 Thread Patrik Jakobsson
them. Since no one seems to work on converting gma500 let's > just move the code away so that new drivers don't end up accidentally > using this. Thanks for doing this! I'll CC Alan as well. Reviewed-by: Patrik Jakobsson > Cc: Patrik Jakobsson > Signed-off-by:

[PATCH] drivers: gpu: drm: gma500: Replaced calls kzalloc & memcpy with kmemdup

2013-03-11 Thread Patrik Jakobsson
s_bl = kmemdup(vbt_lvds_bl, sizeof(*vbt_lvds_bl), GFP_KERNEL); > if (!lvds_bl) { > dev_err(dev_priv->dev->dev, "out of memory for backlight > data\n"); > return; > } > - memcpy(lvds_bl, vbt_lvds_bl, sizeof(*vbt_lvds_bl)); > dev_priv->lvds_bl = lvds_bl; > } > > -- > 1.7.9.5 Reviewed-by: Patrik Jakobsson

Re: [PATCH 9/9] drm/udl: Support adapters without firmware descriptor

2025-04-05 Thread Patrik Jakobsson
On Tue, Apr 1, 2025 at 6:23 PM Thomas Zimmermann wrote: > > Set default limit on the number of pixels for adapters without > vendor firmware descriptor. The devices work as expected, they > just don't provide any description. > > If parsing the vendor firmware descriptor fails, the device falls >

Re: [PATCH v2] drm/gma500: Remove unused mrst_clock_funcs

2025-03-07 Thread Patrik Jakobsson
On Thu, Mar 6, 2025 at 4:52 PM wrote: > > From: "Dr. David Alan Gilbert" > > The mrst_clock_funcs const was added in 2013 by > commit ac6113ebb70d ("drm/gma500/mrst: Add SDVO clock calculation") > and commented as 'Not used yet'. > > It's not been used since, so remove it. > The helper functions

Re: [PATCH] drm/gma500: Remove unused mrst_helper_funcs

2025-03-06 Thread Patrik Jakobsson
On Sat, Feb 1, 2025 at 2:14 AM wrote: > > From: "Dr. David Alan Gilbert" > > The mrst_helper_funcs const was added in 2013 by > commit ac6113ebb70d ("drm/gma500/mrst: Add SDVO clock calculation") > and commented as 'Not used yet'. > > It's not been used since, so remove it. You talk about mrst_h

Re: [PATCH] drm/gma500: Replace deprecated strncpy() with strscpy()

2025-03-06 Thread Patrik Jakobsson
On Tue, Feb 25, 2025 at 9:39 PM Thorsten Blum wrote: > > strncpy() is deprecated for NUL-terminated destination buffers. Use > strscpy() instead and remove the manual NUL-termination. > > Compile-tested only. > > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-harden...@vger.kernel.org >

Re: [PATCH] drm/gma500: fix inconsistent indenting warning

2025-03-06 Thread Patrik Jakobsson
On Wed, Mar 5, 2025 at 9:49 AM Charles Han wrote: > > Fix below inconsistent indenting smatch warning. > smatch warnings: > drivers/gpu/drm/gma500/cdv_device.c:218 cdv_errata() warn: inconsistent > indenting > > Signed-off-by: Charles Han Thanks for the patch. Applied to drm-misc-next -Patrik

Re: [PATCH] drm/gma500: Add NULL check for pci_gfx_root in mid_get_vbt_data()

2025-03-06 Thread Patrik Jakobsson
On Wed, Mar 5, 2025 at 12:20 PM Ivan Abramov wrote: > > Since pci_get_domain_bus_and_slot() can return NULL, add NULL check for > pci_gfx_root in the mid_get_vbt_data(). > > This change is similar to the checks implemented in mid_get_fuse_settings() > and mid_get_pci_revID(), which were introduced

Re: [PATCH v2] drm/gma500: Add NULL check for pci_gfx_root in mid_get_vbt_data()

2025-03-06 Thread Patrik Jakobsson
On Thu, Mar 6, 2025 at 12:21 PM Ivan Abramov wrote: > > Since pci_get_domain_bus_and_slot() can return NULL, add NULL check for > pci_gfx_root in the mid_get_vbt_data(). > > This change is similar to the checks implemented in mid_get_fuse_settings() > and mid_get_pci_revID(), which were introduced

Re: [PATCH] drm/gma500: Remove unused psb_mmu_virtual_to_pfn

2025-03-10 Thread Patrik Jakobsson
On Sun, Mar 9, 2025 at 12:44 AM wrote: > > From: "Dr. David Alan Gilbert" > > psb_mmu_virtual_to_pfn() was added in 2011 by > commit 8c8f1c958ab5 ("gma500: introduce the GTT and MMU handling logic") > but hasn't been used. > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert Applied to drm-

Re: [PATCH] drm/gma500/psb_intel_modes: Remove unused psb_intel_ddc_probe

2025-03-10 Thread Patrik Jakobsson
On Sun, Mar 9, 2025 at 12:44 AM wrote: > > From: "Dr. David Alan Gilbert" > > psb_intel_ddc_probe() was added in 2011 by > commit 89c78134cc54 ("gma500: Add Poulsbo support") > but has remained unused (probably because drm_get_edid is used > instead). > > Remove it. > > Signed-off-by: Dr. David A

Re: [PATCH 1/3] drm/udl: Unregister device before cleaning up on disconnect

2025-03-12 Thread Patrik Jakobsson
> been marked as unplugged. > > Signed-off-by: Thomas Zimmermann > Fixes: b1a981bd5576 ("drm/udl: drop drm_driver.release hook") > Cc: dri-devel@lists.freedesktop.org > Cc: # v5.8+ Hi Thomas, Looks good. Reviewed-by: Patrik Jakobsson > --- > drivers/gpu/drm/udl/udl_

Re: [PATCH 3/3] drm/probe-helper: Do not fail from drmm_kms_helper_poll_init()

2025-03-12 Thread Patrik Jakobsson
; already never fails with an error. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson > --- > drivers/gpu/drm/ast/ast_mode.c | 5 + > drivers/gpu/drm/drm_probe_helper.c | 11 ++- > include/drm/drm_probe_helper.h | 2 +- > 3 fi

Re: [PATCH 2/3] drm/udl: Switch poll helpers to managed cleanup

2025-03-12 Thread Patrik Jakobsson
On Mon, Mar 3, 2025 at 4:00 PM Thomas Zimmermann wrote: > > Call drmm_kms_helper_poll_init() to set up managed cleanup for > connector polling. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Patrik Jakobsson > --- > drivers/gpu/drm/udl/udl_drv.c | 1 - > driver

Re: [PATCH 6/9] drm/udl: Return error if vendor descriptor is too short

2025-04-04 Thread Patrik Jakobsson
On Tue, Apr 1, 2025 at 6:23 PM Thomas Zimmermann wrote: > > There need to be least 5 bytes in the vendor descriptor. Return > an error otherwise. Also change the branching to early-out on > the error. Adjust indention of the rest of the parser function. > > Signed-off-by: Thomas Zimmermann > ---

Re: [PATCH 6/9] drm/udl: Return error if vendor descriptor is too short

2025-04-03 Thread Patrik Jakobsson
On Thu, Apr 3, 2025 at 9:28 AM Thomas Zimmermann wrote: > > Hi > > Am 02.04.25 um 15:16 schrieb Patrik Jakobsson: > > On Tue, Apr 1, 2025 at 6:23 PM Thomas Zimmermann > > wrote: > >> There need to be least 5 bytes in the vendor descriptor. Return > &g

Re: [PATCH v2 12/19] drm/gma500: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct()

2025-07-01 Thread Patrik Jakobsson
; is needed. > > Cc: Patrik Jakobsson > Reviewed-by: Thomas Zimmermann > Signed-off-by: Ville Syrjälä Acked-by: Patrik Jakobsson > --- > drivers/gpu/drm/gma500/fbdev.c | 5 - > drivers/gpu/drm/gma500/framebuffer.c | 14 +++--- > drivers/gpu/drm

<    2   3   4   5   6   7