On Wed, Mar 17, 2021 at 9:27 AM Yang Li wrote:
>
> This fixes the following sparse warnings:
> drivers/gpu/drm/gma500/psb_drv.c:303:56: warning: Using plain integer as
> NULL pointer
>
> Reported-by: Abaci Robot
> Signed-off-by: Yang Li
Applied to drm-misc-next
Thanks
Patrik
> ---
> drivers/
Linus Walleij
Both patches look good. Do you want me to take them through drm-misc? Otherwise:
Acked-by: Patrik Jakobsson
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Fri, Jan 22, 2021 at 3:51 PM Andy Shevchenko
wrote:
>
> On Fri, Jan 22, 2021 at 03:16:55PM +0100, Patrik Jakobsson wrote:
> > On Fri, Jan 22, 2021 at 12:39 PM Andy Shevchenko
> > wrote:
> > >
> > > Convert the GMA500 driver to use the new SCU IPC API. Th
On Tue, Jan 26, 2021 at 1:37 PM Andy Shevchenko
wrote:
>
> Hi guys,
>
> This is first part of Intel MID outdated platforms removal. It's collected
> into
> immutable branch with a given tag, please pull to yours subsystems.
Hi Andy,
Do you plan on eventually removing X86_INTEL_MID completely? If
On Tue, Jan 26, 2021 at 4:51 PM Andy Shevchenko
wrote:
>
> On Tue, Jan 26, 2021 at 5:25 PM Patrik Jakobsson
> wrote:
> > On Tue, Jan 26, 2021 at 1:37 PM Andy Shevchenko
> > wrote:
> > >
> > > Hi guys,
> > >
> > > This is first part of In
On Tue, Jan 26, 2021 at 9:53 PM Andy Shevchenko
wrote:
>
> On Tue, Jan 26, 2021 at 8:33 PM Hans de Goede wrote:
> > On 1/26/21 6:14 PM, Andy Shevchenko wrote:
> > > On Tue, Jan 26, 2021 at 6:55 PM Patrik Jakobsson
> > > wrote:
> > >> On Tue, Jan 26, 202
On Fri, Jan 29, 2021 at 10:56 AM Thomas Zimmermann wrote:
>
> Support for Moorestown and Medfield platforms is being removed from
> the kernel. So here's a patch to remove the related code from the
> gma500 driver. On top of that I also cleaned up the configuration
> a bit.
>
> Note that Poulsbo a
On Fri, Jan 29, 2021 at 10:56 AM Thomas Zimmermann wrote:
>
> Medfield is an outdated mobile platform with apparently no users left.
> Remove it from gma500.
>
> Signed-off-by: Thomas Zimmermann
Great, finally we get rid of that DSI code :)
Signed-off-by: P
On Fri, Jan 29, 2021 at 10:56 AM Thomas Zimmermann wrote:
>
> Moorestown is an outdated mobile platform with apparently no users
> left. Remove it from gma500. The MID chip-setup code in mid_bios.c
> is now unused, so remove it as well.
>
> Signed-off-by: Thomas Zimmermann
As stated earlier. Thi
On Fri, Jan 29, 2021 at 10:56 AM Thomas Zimmermann wrote:
>
> With support for the MID-related chips removed, only support for
> desktop chips is left in the driver. So just build the complete
> driver if DRM_GMA500 has been selected. Anyone who wants to enable
> the Poulsbo code would probably al
On Fri, Jan 29, 2021 at 10:56 AM Thomas Zimmermann wrote:
>
> The gma500 driver does not use TTM.
>
> Signed-off-by: Thomas Zimmermann
Thanks!
Signed-off-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> d
t; noticed that drm_ttm_cache_flush() doesn't exist.
>
> Signed-off-by: Thomas Zimmermann
Thanks!
Signed-off-by: Patrik Jakobsson
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Fri, Jan 29, 2021 at 4:12 PM Thomas Zimmermann wrote:
>
> Hi Patrik
>
> Am 29.01.21 um 15:33 schrieb Patrik Jakobsson:
> > On Fri, Jan 29, 2021 at 10:56 AM Thomas Zimmermann
> > wrote:
> >>
> >> With support for the MID-related chips removed, only
e change for v3d got
lost.
Fixes: ("drm/scheduler: Job timeout handler returns status (v3)")
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/v3d/v3d_sched.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/v3d/v3d_sched.c b/drivers/gpu/dr
On Sat, Jan 30, 2021 at 7:47 PM Joe Perches wrote:
>
> On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> > Use semicolons and braces.
>
> Ping?
This entire file is going away so perhaps just drop the patch to avoid
a conflict.
-Patrik
>
> > Signed-off-by: Joe Perches
> > ---
> > drivers
On Mon, Feb 1, 2021 at 9:23 AM Thomas Zimmermann wrote:
>
> Hi Patrik
>
> Am 29.01.21 um 15:25 schrieb Patrik Jakobsson:
> > On Fri, Jan 29, 2021 at 10:56 AM Thomas Zimmermann
> > wrote:
> >>
> >> Medfield is an outdated mobile platform with apparently
Clearly never been used so just remove it.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_intel_crt.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/gma500/cdv_intel_crt.c
b/drivers/gpu/drm/gma500/cdv_intel_crt.c
index
DPST never got enabled so remove it. We keep the reg save/restore code
just for safety.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_drv.h | 4 -
drivers/gpu/drm/gma500/psb_intel_reg.h | 32 ---
drivers/gpu/drm/gma500/psb_irq.c | 110
Afaik tv out is not available on Cedarview and the code isn't doing
anything so remove it.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_intel_display.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/gma500/cdv_intel_display
CDV crtc helpers are identical to other chips so use gma_ prefix for the
crtc helper struct and remove the CDV copy.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_device.c| 2 +-
drivers/gpu/drm/gma500/cdv_device.h| 1 -
drivers/gpu/drm/gma500
Blits cannot happen anymore since we removed the 2d accel code. Stop
checking for a busy blitter and remove the remaining blitter code.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/Makefile | 1 -
drivers/gpu/drm/gma500/blitter.c | 43
drivers
Since everything else in accel_2d.c got removed we can move psb_spank()
into psb_drv.c where it is used.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/Makefile | 1 -
drivers/gpu/drm/gma500/accel_2d.c | 60 ---
drivers/gpu/drm/gma500/psb_drv.c | 31
On Wed, Feb 3, 2021 at 4:54 PM Christian König wrote:
>
> Am 03.02.21 um 16:51 schrieb Luben Tuikov:
> > On 2021-02-03 5:36 a.m., Daniel Vetter wrote:
> >> On Fri, Jan 29, 2021 at 04:54:39PM +0100, Patrik Jakobsson wrote:
> >>> The commit a6a1f036c74e ("drm/
On Wed, Feb 3, 2021 at 1:00 PM Andy Shevchenko
wrote:
>
> On Tue, Jan 26, 2021 at 5:25 PM Patrik Jakobsson
> wrote:
> > On Tue, Jan 26, 2021 at 1:37 PM Andy Shevchenko
> > wrote:
> > >
> > > Hi guys,
> > >
> > > This is first part of In
On Fri, Feb 5, 2021 at 12:07 PM Andy Shevchenko
wrote:
>
> On Thu, Feb 4, 2021 at 11:04 AM Andy Shevchenko
> wrote:
> >> Today's linux-next merge of the drivers-x86 tree got a conflict in:
> >
> > Thanks. I already asked Patrik yesterday day if DRM missed to pull an
> > immutable tag I provided.
ned-off-by: Thomas Zimmermann
> Fixes: 837f23bb4b60 ("drm/gma500: Drop DRM_GMA3600 config option")
> Cc: Patrik Jakobsson
> Cc: dri-devel@lists.freedesktop.org
Applied to drm-misc-next
Thanks
___
dri-devel mailing list
On Thu, Dec 3, 2020 at 9:41 AM Dan Carpenter wrote:
>
> The main problem with this error handling was that it didn't clean up if
> i2c_add_numbered_adapter() failed. This code is pretty old, and doesn't
> match with today's checkpatch.pl standards so I took the opportunity to
> tidy it up a bit.
On Tue, Jun 29, 2021 at 1:52 PM Jing Xiangfeng wrote:
>
> psb_user_framebuffer_create() misses to call drm_gem_object_put() in an
> error path. Add the missed function call to fix it.
>
Sorry for the delay, I'm currently on vacation.
Looks good. Thanks for the patch.
Applied to drm-misc-next
-P
On Fri, Nov 6, 2020 at 1:42 PM Thomas Zimmermann wrote:
>
> Apparently, the function was never used at all.
>
> Signed-off-by: Thomas Zimmermann
Thanks Thomas,
As agreed, please apply to drm-misc-next
-Patrik
> ---
> drivers/gpu/drm/gma500/gem.c | 6 --
> drivers/gpu/drm/gma500/psb_d
2D acceleration is only available on PSB and MRST and very slow on both
platforms. CPU acceleration is faster so don't bother with 2D accel
anymore.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/accel_2d.c| 292 ---
drivers/gpu/drm/gma500/cdv_dev
On Sun, Nov 15, 2020 at 7:32 PM Sam Ravnborg wrote:
>
> Hi Patrik.
> On Sun, Nov 15, 2020 at 06:54:20PM +0100, Patrik Jakobsson wrote:
> > 2D acceleration is only available on PSB and MRST and very slow on both
> > platforms. CPU acceleration is faster so don't bother
On Sun, Nov 15, 2020 at 8:08 PM Sam Ravnborg wrote:
>
> Hi Patrik,
> On Sun, Nov 15, 2020 at 07:51:27PM +0100, Patrik Jakobsson wrote:
> > On Sun, Nov 15, 2020 at 7:32 PM Sam Ravnborg wrote:
> > >
> > > Hi Patrik.
> > > On Sun, Nov 15, 2020 at 06:54:20PM
On Tue, Mar 8, 2022 at 9:48 AM Thomas Zimmermann wrote:
>
> Hi Sam and Patrik
>
> Am 07.03.22 um 22:02 schrieb Patrik Jakobsson:
> > On Mon, Mar 7, 2022 at 8:07 PM Sam Ravnborg wrote:
> >>
> >> Hi Thomas,
> >>
> >> One comment below.
>
On Tue, Mar 8, 2022 at 8:52 PM Thomas Zimmermann wrote:
>
> Move the setup code for GTT/GATT memory ranges into a new helper and
> call the function from psb_gtt_init() and psb_gtt_resume(). Removes
> code duplication.
LGTM
Acked-by: Patrik Jakobsson
>
> Signed-off-by:
On Tue, Mar 8, 2022 at 8:52 PM Thomas Zimmermann wrote:
>
> Move the code for enabling and disabling the GTT into helpers and call
> the functions in psb_gtt_init(), psb_gtt_fini() and psb_gtt_resume().
> Removes code duplication.
That makes it much more readable. Thanks.
Acke
E)
> |
> - memcpy(mode, E, S)
> + drm_mode_copy(mode, E)
> )
>
> @depends on !is_mode_copy@
> struct drm_display_mode mode;
> expression E;
> @@
> (
> - mode = E
> + drm_mode_copy(&mode, &E)
> |
> - memcpy(&mode, E, S)
> + drm_mode_copy(
On Tue, Mar 8, 2022 at 8:52 PM Thomas Zimmermann wrote:
>
> Refactor and simplify various parts of the memory management. This
> includes locking, initialization and finalizer functions, and code
> organization.
>
> Tested on Atom N2800 hardware.
>
> v2:
> * put common code in psb_gtt_{ini
Most of these are old leftovers from one of the driver merges. This is
all dead code.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_drv.h | 75 +---
1 file changed, 1 insertion(+), 74 deletions(-)
diff --git a/drivers/gpu/drm/gma500/psb_drv.h b
All functions live in gma_display.c already so move the vtable. Also
shorten the name to gma_crtc_funcs.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_device.c| 2 +-
drivers/gpu/drm/gma500/gma_display.c | 12
drivers/gpu/drm/gma500/gma_display.h
Use the gma_ prefix instead of psb_ since the code is common for all
chips. Various coding style fixes. Removal of unused code. Removal of
duplicate function declarations.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/gma_display.c | 8 +--
drivers/gpu/drm/gma500/opregion.c
The drm_crtc_funcs are all generic and no chip specific functions are
necessary. We can therefore directly put gma_crtc_funcs into the
drm_crtc.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_device.c| 1 -
drivers/gpu/drm/gma500/oaktrail_device.c | 1 -
drivers/gpu
On Thu, Mar 17, 2022 at 12:02 PM Daniel Vetter wrote:
>
> On Thu, Mar 17, 2022 at 10:25:55AM +0100, Patrik Jakobsson wrote:
> > Use the gma_ prefix instead of psb_ since the code is common for all
> > chips. Various coding style fixes. Removal of unused code. Removal of
>
On Thu, Mar 17, 2022 at 8:44 PM Thomas Zimmermann wrote:
>
> Hi Patrik
Hi Thomas and Sam,
I have already pushed this series with Daniels ack so I'll address any
issues in follow-up patches.
Thanks for the extra eyes
>
> Am 17.03.22 um 10:25 schrieb Patrik Jakobsson:
> >
On Thu, Mar 17, 2022 at 8:57 PM Thomas Zimmermann wrote:
>
> Hi Patrik
>
> Am 17.03.22 um 10:25 schrieb Patrik Jakobsson:
> > Use the gma_ prefix instead of psb_ since the code is common for all
> > chips. Various coding style fixes. Removal of unused code. Removal o
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/framebuffer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/gma500/framebuffer.c
b/drivers/gpu/drm/gma500/framebuffer.c
index 45df9de22007..2b99c996fdc2 100644
--- a/drivers/gpu/drm/gma500
This makes sure we're using proper locking when iterating the list of
connectors.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_device.c| 10 ++--
drivers/gpu/drm/gma500/cdv_intel_display.c | 9 +--
drivers/gpu/drm/gma500/framebuffer.c | 6 +++--
dr
According to docs we should only register connectors that are
hotpluggable. No connectors in gma500 are hotpluggable.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_intel_crt.c | 3 ---
drivers/gpu/drm/gma500/cdv_intel_dp.c | 3 ---
drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2
Reloading the driver revealed that the interrupt handler never got
uninstalled.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/psb_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
index 82d51e9821ad
The allocation is made for the gma_connector object so we must use the
same address when free()ing the object.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/cdv_intel_crt.c | 3 ++-
drivers/gpu/drm/gma500/cdv_intel_dp.c | 3 ++-
drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 3
These functions are not used outside of their file scope so can be
declared as static.
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/gma_display.c | 15 +++
drivers/gpu/drm/gma500/psb_drv.c | 2 +-
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a
These functions operate on a crtc and should be prefixed properly.
Suggested-by: Thomas Zimmermann
Signed-off-by: Patrik Jakobsson
---
drivers/gpu/drm/gma500/gma_display.c | 6 +++---
drivers/gpu/drm/gma500/psb_irq.c | 6 +++---
drivers/gpu/drm/gma500/psb_irq.h | 6 +++---
3 files
On Tue, Mar 22, 2022 at 3:39 PM Daniel Vetter wrote:
>
> On Tue, Mar 22, 2022 at 02:17:38PM +0100, Patrik Jakobsson wrote:
> > This makes sure we're using proper locking when iterating the list of
> > connectors.
> >
> > Signed-off-by: Patrik Jakobsson
>
&
On Tue, Mar 22, 2022 at 8:32 PM Thomas Zimmermann wrote:
>
>
>
> Am 22.03.22 um 20:30 schrieb Thomas Zimmermann:
> > Hi Patrik
> >
> > Am 22.03.22 um 14:17 schrieb Patrik Jakobsson:
> >> Signed-off-by: Patrik Jakobsson
> >> ---
> >> dr
On Tue, Mar 22, 2022 at 8:36 PM Thomas Zimmermann wrote:
>
> Hi
>
> Am 22.03.22 um 14:17 schrieb Patrik Jakobsson:
> > These functions operate on a crtc and should be prefixed properly.
> >
> > Suggested-by: Thomas Zimmermann
> > Signed-off-by: Patrik J
On Thu, Mar 24, 2022 at 10:16 AM Haowen Bai wrote:
>
> WARNING: Statements should start on a tabstop
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Haowen Bai
Hi, thanks for the patch.
> ---
> drivers/gpu/drm/gma500/mid_bios.c | 5 +++--
> 1 file changed, 3 insertions(
On Sun, Mar 27, 2022 at 7:20 AM Xiaomeng Tong wrote:
>
> The bug is here:
> return crtc;
>
> The list iterator value 'crtc' will *always* be set and non-NULL by
> list_for_each_entry(), so it is incorrect to assume that the iterator
> value will be NULL if the list is empty or no element i
patches are:
Acked-by: Patrik Jakobsson
>
> Thomas Zimmermann (10):
> drm/gma500: Remove struct psb_gem_object.npage
> drm/gma500: Acquire reservation lock for GEM objects
> drm/gma500: Move GTT locking into GTT helpers
> drm/gma500: Remove struct psb_gtt.sem sempahor
On Mon, Mar 7, 2022 at 8:07 PM Sam Ravnborg wrote:
>
> Hi Thomas,
>
> One comment below.
>
> On Sun, Mar 06, 2022 at 09:36:15PM +0100, Thomas Zimmermann wrote:
> > The current implementation of psb_gtt_init() also does resume
> > handling. Move the resume code into its own helper.
> >
> > Signed-o
nt for getting rid of psb_gtt_kref_put();
Acked-by: Patrik Jakobsson
> Signed-off-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/gma500/framebuffer.c | 1 -
> drivers/gpu/drm/gma500/gem.c | 144 ++--
> drivers/gpu/drm/gma500/gem.h
leanup the resulting code.
>
> v2:
> * unlock gtt_mutex in pin-error handling (Patrik)
>
> Signed-off-by: Thomas Zimmermann
Acked-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/gem.c | 94
> 1 file changed, 42 insertions(
On Tue, Oct 5, 2021 at 10:11 AM Thomas Zimmermann wrote:
>
> psb_gtt_alloc_range() allocates struct gtt_range, create the GTT resource
> and performs some half-baked initialization. Inline the function into its
> only caller psb_gem_create(). For creating the GTT resource, introduce a
> new helper
On Tue, Oct 5, 2021 at 10:11 AM Thomas Zimmermann wrote:
>
> Caching of the GEM object's backing pages are unrelated to GTT
> management. Move the respective calls from GTT code to GEM code.
>
I gave suspend/resume a try and it seems fine so
Acked-by: Patrik Jakobsson
> S
On Tue, Oct 5, 2021 at 10:11 AM Thomas Zimmermann wrote:
>
> struct gtt_range represents a GEM object and should not be used for GTT
> setup. Change psb_gtt_insert() and psb_gtt_remove() to receive all
> necessary parameters from their caller. This also eliminates possible
> failure from psb_gtt_i
by
> drm_gem_object_release().
>
> v3:
> * replace offset[static 1] with pointer notation (Patrik)
>
Acked-by: Patrik Jakobsson
> Signed-off-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/gma500/gem.c | 94
> drivers/gp
om the GTT resource.
>
> Rename the functions to psb_gtt_insert_pages() and psb_gtt_remove_pages()
> to reflect their similarity to MMU interfaces.
>
> v3:
> * restore the comments about locking rules (Patrik)
>
That should be the last of them. Nice cleanups! Thanks.
Acked-by
On Fri, Sep 10, 2021 at 3:10 PM Maxime Ripard wrote:
>
> Display drivers so far need to have a lot of boilerplate to first
> retrieve either the panel or bridge that they are connected to using
> drm_of_find_panel_or_bridge(), and then either deal with each with ad-hoc
> functions or create a drm
On Wed, Sep 22, 2021 at 10:23 AM Maxime Ripard wrote:
>
> Hi Patrik,
>
> On Tue, Sep 21, 2021 at 02:47:49PM +0200, Patrik Jakobsson wrote:
> > On Fri, Sep 10, 2021 at 3:10 PM Maxime Ripard wrote:
> > >
> > > Display drivers so far need to have a lot of boiler
ber of drivers, the PCI remove callback contains
> only a single call to drm_device_unregister(). In a later patchset,
> this could be implemented as another shared helper within DRM.
>
> Tested on Atom N2800 hardware.
Thanks for the patches!
For the entire series:
Reviewed-by: Patrik Jako
On Mon, Sep 27, 2021 at 10:16 AM Dan Carpenter wrote:
>
> The error code is stored in "dev_priv", not "dev". The "dev" pointer
> isn't initialized yet.
>
Hi Dan,
This is already addressed in:
https://patchwork.kernel.org/project/dri-devel/patch/20210924094040.3631675-1-yangyingli...@huawei.com/
On Tue, Sep 28, 2021 at 10:44 AM Thomas Zimmermann wrote:
>
> Allocation and pinning helpers for struct gtt_range are GEM functions,
> so move them to gem.c. No functional changes.
>
> Signed-off-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/gma500/framebuffer.c | 1 -
> drivers/gpu/drm/
On Tue, Sep 28, 2021 at 10:44 AM Thomas Zimmermann wrote:
>
> Convert upcasts from struct drm_gem_object to struct gtt_range to
> to_gtt_range(). Some places used container_of() directly.
>
> Signed-off-by: Thomas Zimmermann
Acked-by: Patrik Jakobsson
> ---
> drivers
() to make it more readable.
>
> Signed-off-by: Thomas Zimmermann
Acked-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/gem.c | 93 ++--
> drivers/gpu/drm/gma500/gem.h | 4 +-
> 2 files changed, 59 insertions(+), 38 deletions(-)
>
> d
t_func are not required any longer. Declare them as
> static inline.
>
> Signed-off-by: Thomas Zimmermann
Acked-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/framebuffer.c | 44 ++
> drivers/gpu/drm/gma500/gem.c | 22 ++-
>
On Tue, Sep 28, 2021 at 10:44 AM Thomas Zimmermann wrote:
>
> Rename psb_gtt_pin() to psb_gem_pin() to reflect the semantics of the
> function. Same for psb_gtt_unpin(). No functional changes.
Acked-by: Patrik Jakobsson
>
> Signed-off-by: Thomas Zimmermann
> ---
> d
On Tue, Sep 28, 2021 at 10:44 AM Thomas Zimmermann wrote:
>
> psb_gtt_attach_pages() are not GTT functions but deal with the GEM
> object's SHMEM pages. The only callers of psb_gtt_attach_pages() and
> psb_gtt_detach_pages() are the GEM pin helpers. Inline the calls and
> cleanup the resulting cod
On Tue, Sep 28, 2021 at 10:44 AM Thomas Zimmermann wrote:
>
> psb_gtt_alloc_range() allocates struct gtt_range, create the GTT resource
> and performs some half-baked initialization. Inline the function into its
> only caller psb_gem_create(). For creating the GTT resource, introduce a
> new helpe
On Tue, Sep 28, 2021 at 10:44 AM Thomas Zimmermann wrote:
>
> Caching of the GEM object's backing pages are unrelated to GTT
> management. Move the respective calls from GTT code to GEM code.
>
> Signed-off-by: Thomas Zimmermann
> ---
> drivers/gpu/drm/gma500/gem.c | 9 -
> drivers/gpu/
On Tue, Sep 28, 2021 at 10:44 AM Thomas Zimmermann wrote:
>
> struct gtt_range represents a GEM object and should not be used for GTT
> setup. Change psb_gtt_insert() and psb_gtt_remove() to receive all
> necessary parameters from their caller. This also eliminates possible
> failure from psb_gtt_
On Tue, Sep 28, 2021 at 10:44 AM Thomas Zimmermann wrote:
>
> struct gtt_range represents a GEM object. Rename the structure to struct
> psb_gem_object and update all users. No functional changes.
>
> Signed-off-by: Thomas Zimmermann
Acked-by: Patrik Jakobsson
> ---
> d
On Wed, Dec 1, 2021 at 4:29 PM Zhou Qingyang wrote:
>
> In cdv_intel_dp_get_modes(), the third return value of
> drm_mode_duplicate() is assigned to mode and used in
> drm_mode_probed_add(). drm_mode_probed_add() passes mode->head to
> list_add_tail(). list_add_tail() will further call __list_add(
On Tue, Nov 30, 2021 at 2:30 PM Zhou Qingyang wrote:
>
> In psb_intel_lvds_get_modes(), the return value of drm_mode_duplicate()
> is assigned to mode and used in drm_mode_probed_add().
> drm_mode_probed_add() passes mode->head to list_add_tail().
> list_add_tail() will further call __list_add() a
On Tue, Nov 30, 2021 at 2:26 PM Zhou Qingyang wrote:
>
> In cdv_intel_lvds_get_modes(), the return value of drm_mode_duplicate()
> is assigned to mode and used in drm_mode_probed_add().
> drm_mode_probed_add() passes mode->head to list_add_tail().
> list_add_tail() will further call __list_add() a
On Wed, Jan 12, 2022 at 9:25 AM wrote:
>
> From: Minghao Chi
>
> Return value directly instead of taking this in another redundant
> variable.
>
> Reported-by: Zeal Robot
> Signed-off-by: Minghao Chi
> Signed-off-by: CGEL ZTE
Thanks for the patch. I'll apply this to drm-misc-next
-Patrik
>
On Aug 2, 2016 3:25 AM, wrote:
>
> Remove comment for non-existent parameter in psbfb_alloc().
>
> Signed-off-by: Jiang Biao
Thanks for the patch. Will have a look when in back from vacation.
-Patrik
> ---
> drivers/gpu/drm/gma500/framebuffer.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff
gt; Patchset made on top of drm-misc-next
>
> Nice series! On the entire pile:
>
> Acked-by: Daniel Vetter
>
> Since gma500 is defacto unmaintained I think that's good enough, as long
> as you don't break anything. Maybe wait a bit before merging it all.
"Odd Fix
On Sat, May 25, 2019 at 10:43 PM Sam Ravnborg wrote:
>
> Just a quick (final) probe. If there are no further feedback I will
> commit this set sunday.
> Added intel-...@lists.freedesktop.org just to get a bit more coverage.
Hi Sam
v2 of this series is already applied to drm-misc-next
Thanks
Patr
On Tue, Apr 9, 2019 at 8:51 AM Hans de Goede wrote:
>
> Some CedarView VBT-s claim that there is a LVDS panel, while there is none.
> Specifically this happens on the Thecus N2800 / N5550 NAS models.
>
> This commit adds a LVDS blacklist to deal with this and adds an entry for
> the Thecus NAS-es.
On Tue, Apr 9, 2019 at 12:20 PM Hans de Goede wrote:
>
> Hi,
>
> On 09-04-19 11:47, Patrik Jakobsson wrote:
> > On Tue, Apr 9, 2019 at 8:51 AM Hans de Goede wrote:
> >>
> >> Some CedarView VBT-s claim that there is a LVDS panel, while there is none.
> >
On Wed, Apr 10, 2019 at 9:27 AM Hans de Goede wrote:
>
> Hi,
>
> On 09-04-19 21:31, Dominik 'Rathann' Mierzejewski wrote:
> > Hello,
> >
> > On Tuesday, 09 April 2019 at 16:44, Hans de Goede wrote:
> >> Hi,
> >>
> >> On 09-04-19 1
On Wed, Apr 10, 2019 at 1:18 PM Dominik 'Rathann' Mierzejewski
wrote:
>
> On Wednesday, 10 April 2019 at 11:08, Hans de Goede wrote:
> > On 10-04-19 11:00, Patrik Jakobsson wrote:
> > > On Wed, Apr 10, 2019 at 9:27 AM Hans de Goede wrote:
> > > > On 09-
On Wed, Apr 10, 2019 at 12:43 PM Ville Syrjälä
wrote:
>
> On Wed, Apr 10, 2019 at 11:00:23AM +0200, Patrik Jakobsson wrote:
> > On Wed, Apr 10, 2019 at 9:27 AM Hans de Goede wrote:
> > >
> > > Hi,
> > >
> > > On 09-04-19 21:31, Dom
On Wed, Apr 10, 2019 at 11:09 AM Hans de Goede wrote:
>
> Hi,
>
> On 10-04-19 11:00, Patrik Jakobsson wrote:
> > On Wed, Apr 10, 2019 at 9:27 AM Hans de Goede wrote:
> >>
> >> Hi,
> >>
> >> On 09-04-19 21:31, Dominik 'Rathann' M
Some machines have an lvds child device in vbt even though a panel is
not attached. To make detection more reliable we now also check the lvds
config bits available in the vbt.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1665766
Signed-off-by: Patrik Jakobsson
Cc: Hans de Goede
Cc
On Wed, Apr 10, 2019 at 1:51 PM Dominik 'Rathann' Mierzejewski
wrote:
>
> On Wednesday, 10 April 2019 at 13:33, Patrik Jakobsson wrote:
> > On Wed, Apr 10, 2019 at 1:18 PM Dominik 'Rathann' Mierzejewski
> > wrote:
> > >
> > > On Wednesday,
On Sun, Apr 21, 2019 at 8:46 PM Hans de Goede wrote:
>
> Hi,
>
> On 16-04-19 13:46, Patrik Jakobsson wrote:
> > Some machines have an lvds child device in vbt even though a panel is
> > not attached. To make detection more reliable we now also check the lvds
> > co
if (bDPExecute)
> - ast->tx_chip_type = AST_TX_ASTDP;
> + ast->tx_chip_types |= BIT(AST_TX_ASTDP);
Hi Thomas,
Just a matter of taste but an alternative to using the BIT macro
everywhere is to just defi
d consider removing _vga
from the name.
Either way:
Reviewed-by: Patrik Jakobsson
> {
> - struct ast_vga_connector *ast_vga_connector =
> to_ast_vga_connector(connector);
> struct drm_device *dev = connector->dev;
> struct ast_private *ast = to_
On Tue, May 31, 2022 at 1:15 PM Thomas Zimmermann wrote:
>
> Enable output polling for all connectors. VGA always uses EDID for this. As
> there's currently no interrupt handling for the ast devices, we have to use
> that trick for the various DP and DVI ports as well.
>
> Signed-off-by: Thomas Zi
On Tue, May 31, 2022 at 1:15 PM Thomas Zimmermann wrote:
>
> Expect the hardware to provide a DDC channel. Fail probing if its
> initialization fails.
>
> Signed-off-by: Thomas Zimmermann
It's funny how I just did the same thing to gma500. Great minds think alike ;)
On Tue, May 31, 2022 at 1:15 PM Thomas Zimmermann wrote:
>
> Both, struct ast_vga_connector and struct ast_sil164_connector, are
> now wrappers around struct drm_connector. Remove them.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Patrik Jakobsson
> ---
> drivers/
1 - 100 of 640 matches
Mail list logo
