[Intel-gfx] [RFC 0/7] drm/i915: Convert WARN* to use device-specific variants

2020-01-06 Thread Pankaj Bharadiya
of WARN* with dev_WARN*, but there are still cases where device pointer is not readily available in some functions (or I missed them somehow) having warning hence some manual churning is needed. Handle such remaining cases separately later. Pankaj Bharadiya (7): treewide: device: add condition

[Intel-gfx] [RFC 7/7] drm/i915: Make WARN* device specific for various cases.

2020-01-06 Thread Pankaj Bharadiya
Device specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific dev_WARN* variants in functions where any one of intel_pm, intel_encoder, i915_perf_stream or intel_crtc_state struct poin

[Intel-gfx] [RFC 2/7] drm/i915/i915_utils: add dev_WARN_ON and dev_WARN_ON_ONCE macros

2020-01-06 Thread Pankaj Bharadiya
It's quite useful to print the device name on the stack dump caused by WARN_ON*. Introduce dev_WARN_ON and dev_WARN_ON_ONCE macros for the same. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/i915_utils.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gp

[Intel-gfx] [RFC 6/7] drm/i915: Make WARN* device specific where dev_priv can be extracted.

2020-01-06 Thread Pankaj Bharadiya
Device specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific dev_WARN* variants in functions where first function argument is a struct pointer and has drm_i915_private struct pointer

[Intel-gfx] [RFC 1/7] treewide: device: add condition support to dev_WARN

2020-01-06 Thread Pankaj Bharadiya
ile. Signed-off-by: Pankaj Bharadiya --- arch/x86/platform/intel-mid/pwr.c | 3 ++- drivers/base/core.c | 2 +- drivers/base/dd.c | 3 ++- drivers/dax/bus.c | 2 +- drive

[Intel-gfx] [RFC 3/7] drm/i915: add helper functions to get device ptr

2020-01-06 Thread Pankaj Bharadiya
We will need struct device pointer to pass it to dev_WARN* calls. Add helper functions to exract device pointer from various structs. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_display_types.h | 14 ++ drivers/gpu/drm/i915/gvt/gvt.h

[Intel-gfx] [RFC 4/7] drm/i915: Make WARN* device specific where drm_device ptr available

2020-01-06 Thread Pankaj Bharadiya
Device specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific dev_WARN* variants in functions where drm_device struct pointer is readily available. The conversion was done automatical

[Intel-gfx] [PATCH v7 1/8] drm/i915/display/cdclk: Make WARN* drm specific where drm_priv ptr is available

2020-02-20 Thread Pankaj Bharadiya
T->drm, ...) | -WARN_ON_ONCE( +drm_WARN_ON_ONCE(&T->drm, ...) ) ...+> } Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_cdclk.c | 84 -- 1 file changed, 48 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdcl

[Intel-gfx] [PATCH v7 2/8] drm/i915/display/ddi: Make WARN* drm specific where drm_device ptr is available

2020-02-20 Thread Pankaj Bharadiya
er func, T; @@ func(struct drm_i915_private *T,...) { <+... ( -WARN( +drm_WARN(&T->drm, ...) | -WARN_ON( +drm_WARN_ON(&T->drm, ...) | -WARN_ONCE( +drm_WARN_ONCE(&T->drm, ...) | -WARN_ON_ONCE( +drm_WARN_ON_ONCE(&T->drm, ...) ) ...+> } Signed-off-by: Pankaj Bharadiya --- drivers/gp

[Intel-gfx] [PATCH v7 3/8] drm/i915/display/display: Make WARN* drm specific where drm_device ptr is available

2020-02-20 Thread Pankaj Bharadiya
er func, T; @@ func(struct drm_i915_private *T,...) { <+... ( -WARN( +drm_WARN(&T->drm, ...) | -WARN_ON( +drm_WARN_ON(&T->drm, ...) | -WARN_ONCE( +drm_WARN_ONCE(&T->drm, ...) | -WARN_ON_ONCE( +drm_WARN_ON_ONCE(&T->drm, ...) ) ...+> } Signed-off-by: Pankaj Bharadiya --- drivers/gpu

[Intel-gfx] [PATCH v7 0/8] drm: Introduce struct drm_device based WARN* and use them in i915

2020-02-20 Thread Pankaj Bharadiya
m and Jani - Get rid of extra local variables [1] https://patchwork.freedesktop.org/series/71668/ Pankaj Bharadiya (8): drm/i915/display/cdclk: Make WARN* drm specific where drm_priv ptr is available drm/i915/display/ddi: Make WARN* drm specific where drm_device ptr is available drm/i9

[Intel-gfx] [PATCH v7 5/8] drm/i915/display/dp: Make WARN* drm specific where drm_device ptr is available

2020-02-20 Thread Pankaj Bharadiya
er func, T; @@ func(struct drm_i915_private *T,...) { <+... ( -WARN( +drm_WARN(&T->drm, ...) | -WARN_ON( +drm_WARN_ON(&T->drm, ...) | -WARN_ONCE( +drm_WARN_ONCE(&T->drm, ...) | -WARN_ON_ONCE( +drm_WARN_ON_ONCE(&T->drm, ...) ) ...+> } Signed-off-by: Pankaj Bharadiya --- drivers/gp

[Intel-gfx] [PATCH v7 4/8] drm/i915/display/power: Make WARN* drm specific where drm_priv ptr is available

2020-02-20 Thread Pankaj Bharadiya
T->drm, ...) | -WARN_ON_ONCE( +drm_WARN_ON_ONCE(&T->drm, ...) ) ...+> } Signed-off-by: Pankaj Bharadiya --- .../drm/i915/display/intel_display_power.c| 181 ++ 1 file changed, 105 insertions(+), 76 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display

[Intel-gfx] [PATCH v7 6/8] drm/i915/display/hdcp: Make WARN* drm specific where drm_priv ptr is available

2020-02-20 Thread Pankaj Bharadiya
T->drm, ...) | -WARN_ON_ONCE( +drm_WARN_ON_ONCE(&T->drm, ...) ) ...+> } Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_hdcp.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/driver

[Intel-gfx] [PATCH v7 7/8] drm/i915/gvt: Make WARN* drm specific where drm_priv ptr is available

2020-02-20 Thread Pankaj Bharadiya
T->drm, ...) | -WARN_ON_ONCE( +drm_WARN_ON_ONCE(&T->drm, ...) ) ...+> } Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/gvt/aperture_gm.c | 6 +++--- drivers/gpu/drm/i915/gvt/cmd_parser.c | 4 ++-- drivers/gpu/drm/i915/gvt/display.c | 3 ++- drivers/gpu/drm/i915/gvt/dmabuf.c

[Intel-gfx] [PATCH v7 8/8] drm/i915/gvt: Make WARN* drm specific where vgpu ptr is available

2020-02-20 Thread Pankaj Bharadiya
;drm, ...) | -WARN_ONCE( +drm_WARN_ONCE(&i915->drm, ...) | -WARN_ON_ONCE( +drm_WARN_ON_ONCE(&i915->drm, ...) ) ...+> } Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/gvt/cfg_space.c| 23 +++ drivers/gpu/drm/i915/gvt/display.c | 3 ++- driv

[RFC][PATCH 0/5] Introduce drm scaling filter property

2020-02-24 Thread Pankaj Bharadiya
lanes and new API helpers for drivers to setup this property. - rewrote code to enable integer scaling and NN filter for i915 Pankaj Bharadiya (5): drm: Introduce scaling filter property drm/drm-kms.rst: Add Scaling filter property documentation drm/i915: Enable scaling filter for plan

[RFC][PATCH 1/5] drm: Introduce scaling filter property

2020-02-24 Thread Pankaj Bharadiya
es to deliver their distinctive look. Signed-off-by: Pankaj Bharadiya Signed-off-by: Shashank Sharma Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/drm_atomic_uapi.c | 8 +++ drivers/gpu/drm/drm_crtc.c| 16 ++ drivers/gpu/drm/drm_mode_config.c | 13 driver

[RFC][PATCH 2/5] drm/drm-kms.rst: Add Scaling filter property documentation

2020-02-24 Thread Pankaj Bharadiya
Add documentation for newly introduced KMS scaling filter property. Signed-off-by: Pankaj Bharadiya --- Documentation/gpu/drm-kms.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst index 906771e03103..7b71a1e3edda 100644

[RFC][PATCH 3/5] drm/i915: Enable scaling filter for plane and pipe

2020-02-24 Thread Pankaj Bharadiya
Attach scaling filter property for crtc and plane and program the scaler control register for the selected filter type. This is preparatory patch to enable Nearest-neighbor integer scaling. Signed-off-by: Pankaj Bharadiya Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display

[RFC][PATCH 4/5] drm/i915: Introduce scaling filter related registers and bit fields.

2020-02-24 Thread Pankaj Bharadiya
Introduce scaler registers and bit fields needed to configure the scaling filter in prgrammed mode and configure scaling filter coefficients. Signed-off-by: Pankaj Bharadiya Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/i915_reg.h | 20 1 file changed, 20

[RFC][PATCH 5/5] drm/i915/display: Add Nearest-neighbor based integer scaling support

2020-02-24 Thread Pankaj Bharadiya
set to DRM_SCALING_FILTER_NEAREST_NEIGHBOR and enable integer scaling. Bspec: 49247 Signed-off-by: Pankaj Bharadiya Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display.c | 83 +++- drivers/gpu/drm/i915/display/intel_display.h | 2 + drivers/gpu/drm

[Intel-gfx][PATCH 00/10] drm/i915: Introduce i915 based i915_MISSING_CASE macro and us it in i915

2020-02-25 Thread Pankaj Bharadiya
convert the MISSING_CASE with i915 specific i915_MISSING_CASE variant using coccinelle semantic patch scripts. i915_MISSING_CASE macro should be preferred over MISSING_CASE, wherever possible. Pankaj Bharadiya (10): drm/i915: Add i915 device based MISSING_CASE macro drm/i915/display/cdclk

[Intel-gfx][PATCH 02/10] drm/i915/display/cdclk: Make MISSING_CASE backtrace i915 specific

2020-02-25 Thread Pankaj Bharadiya
NG_CASE(T, ...) ...> } Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_cdclk.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c index

[Intel-gfx][PATCH 05/10] drm/i915/dp: Make MISSING_CASE backtrace i915 specific

2020-02-25 Thread Pankaj Bharadiya
NG_CASE(T, ...) ...> } Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_dp.c | 28 - 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index

[Intel-gfx][PATCH 01/10] drm/i915: Add i915 device based MISSING_CASE macro

2020-02-25 Thread Pankaj Bharadiya
-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/i915_utils.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h index b0ade76bec90..f8db1eb9c1cc 100644 --- a/drivers/gpu/drm/i915/i915_utils.h +++ b/drivers/gpu/drm/i915

[Intel-gfx][PATCH 04/10] drm/i915/display/display: Make MISSING_CASE backtrace i915 specific

2020-02-25 Thread Pankaj Bharadiya
NG_CASE(T, ...) ...> } Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_display.c | 29 ++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index

[Intel-gfx][PATCH 03/10] drm/i915/display/ddi: Make MISSING_CASE backtrace i915 specific

2020-02-25 Thread Pankaj Bharadiya
NG_CASE(T, ...) ...> } Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_ddi.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 9f7d1d7189ae..

[Intel-gfx][PATCH 06/10] drm/i915/display/hdmi: Make MISSING_CASE backtrace i915 specific

2020-02-25 Thread Pankaj Bharadiya
NG_CASE(T, ...) ...> } Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_hdmi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c index bdbb5ce3fa81..5914813

[Intel-gfx][PATCH 07/10] drm/i915/display: Make MISSING_CASE backtrace i915 specific

2020-02-25 Thread Pankaj Bharadiya
NG_CASE(T, ...) ...> } Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/icl_dsi.c | 8 +--- drivers/gpu/drm/i915/display/intel_bios.c | 4 ++-- drivers/gpu/drm/i915/display/intel_bw.c| 6 +++--- drivers/gpu/drm/i915/display/intel_combo_phy.c | 6 +++

[Intel-gfx][PATCH 09/10] drm/i915/gt: Make MISSING_CASE backtrace i915 specific

2020-02-25 Thread Pankaj Bharadiya
NG_CASE(T, ...) ...> } Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c index 887e0dc701f7..8a80a13

[Intel-gfx][PATCH 10/10] drm/i915: Make MISSING_CASE backtrace i915 specific

2020-02-25 Thread Pankaj Bharadiya
NG_CASE(T, ...) ...> } Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i915_gem_fence_reg.c | 2 +- drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- drivers/gpu/drm/i915/intel_d

[Intel-gfx][PATCH 08/10] drm/i915/gem: Make MISSING_CASE backtrace i915 specific

2020-02-25 Thread Pankaj Bharadiya
NG_CASE(T, ...) ...> } Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c index

[PATCH 0/9] drm: drm_fb_helper cleanup.

2020-03-02 Thread Pankaj Bharadiya
be removed: drm_fb_helper_single_add_all_connectors(), drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector(). Pankaj Bharadiya (9): drm: Remove unused arg from drm_fb_helper_init drm/radeon: remove radeon_fb_{add,remove}_connector functions drm/amdgpu: Remove drm_fb_helper_{add,remove}_one_connector c

[PATCH 3/9] drm/amdgpu: Remove drm_fb_helper_{add, remove}_one_connector calls

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya --- .../drm/amd/display

[PATCH 1/9] drm: Remove unused arg from drm_fb_helper_init

2020-03-02 Thread Pankaj Bharadiya
The max connector argument for drm_fb_helper_init() isn't used anymore hence remove it. All the drm_fb_helper_init() calls are modified with below sementic patch. @@ expression E1, E2, E3; @@ - drm_fb_helper_init(E1,E2, E3) + drm_fb_helper_init(E1,E2) Signed-off-by: Pankaj Bhar

[PATCH 8/9] drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_single_add_all_connectors(), drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector() doesn't keep an array of connectors anymore and are just dummy. Now we have no callers to these functions hence remove them. Signed-off-by: Pankaj Bharadiya --- includ

[PATCH 7/9] drm/bridge: remove unused variable warning in tc358764_detach

2020-03-02 Thread Pankaj Bharadiya
= bridge->dev; ^~~ Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/bridge/tc358764.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358764.c b/drivers/gpu/drm/bridge/tc358764.c index 530342dd4a34..5ac1430fab04 100644 --- a/drivers/gpu/

[PATCH 2/9] drm/radeon: remove radeon_fb_{add, remove}_connector functions

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/radeon

[PATCH 4/9] drm/i915/display: Remove drm_fb_helper_{add, remove}_one_connector calls

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915

[PATCH 9/9] drm/todo: Update drm_fb_helper tasks

2020-03-02 Thread Pankaj Bharadiya
Remove completed drm_fb_helper tasks from todo list. Signed-off-by: Pankaj Bharadiya --- Documentation/gpu/todo.rst | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index ccf5e8e34222..98d8782e1440

[PATCH 5/9] drm: Remove drm_fb_helper add, add all and remove connector calls

2020-03-02 Thread Pankaj Bharadiya
: Pankaj Bharadiya --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c| 2 -- drivers/gpu/drm/armada/armada_fbdev.c | 6 -- drivers/gpu/drm/bridge/tc358764.c | 2 -- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1 - drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 8

[PATCH 6/9] drm/nouveau: Fix unused variable warning

2020-03-02 Thread Pankaj Bharadiya
sed-variable] struct nouveau_drm *drm = nouveau_drm(connector->dev); ^~~ Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/di

[PATCH v2 0/7] drm: drm_fb_helper cleanup.

2020-03-02 Thread Pankaj Bharadiya
be removed: drm_fb_helper_single_add_all_connectors(), drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector(). Changes since v1: - Squashed warning fixes into the patch that introduced the warnings (into 5/7) (Laurent) - Fixed reflow in in 9/9 (Laurent) Pankaj Bharadiya (7): drm: Remove unuse

[PATCH v2 1/7] drm: Remove unused arg from drm_fb_helper_init

2020-03-02 Thread Pankaj Bharadiya
The max connector argument for drm_fb_helper_init() isn't used anymore hence remove it. All the drm_fb_helper_init() calls are modified with below sementic patch. @@ expression E1, E2, E3; @@ - drm_fb_helper_init(E1,E2, E3) + drm_fb_helper_init(E1,E2) Signed-off-by: Pankaj Bhar

[PATCH v2 2/7] drm/radeon: remove radeon_fb_{add, remove}_connector functions

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/radeon

[PATCH v2 3/7] drm/amdgpu: Remove drm_fb_helper_{add, remove}_one_connector calls

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya --- .../drm/amd/display

[PATCH v2 4/7] drm/i915/display: Remove drm_fb_helper_{add, remove}_one_connector calls

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915

[PATCH v2 7/7] drm/todo: Update drm_fb_helper tasks

2020-03-02 Thread Pankaj Bharadiya
Remove completed drm_fb_helper tasks from todo list. Signed-off-by: Pankaj Bharadiya --- Documentation/gpu/todo.rst | 7 --- 1 file changed, 7 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index ccf5e8e34222..302180b76c4f 100644 --- a/Documentation/gpu

[PATCH v2 5/7] drm: Remove drm_fb_helper add, add all and remove connector calls

2020-03-02 Thread Pankaj Bharadiya
(...); @@ @@ - drm_fb_helper_remove_one_connector(...); Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c| 2 -- drivers/gpu/drm/armada/armada_fbdev.c | 6 -- drivers/gpu/drm/bridge/tc358764.c | 3 --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1

[PATCH v2 6/7] drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions

2020-03-02 Thread Pankaj Bharadiya
drm_fb_helper_single_add_all_connectors(), drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector() don't keep an array of connectors anymore and are just dummy. Now we have no callers to these functions hence remove them. Signed-off-by: Pankaj Bharadiya --- includ

[RESEND PATCH v2 3/7] drm/amdgpu: Remove drm_fb_helper_{add, remove}_one_connector calls

2020-03-05 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya Reviewed-by: Emil Velikov

[RESEND PATCH v2 1/7] drm: Remove unused arg from drm_fb_helper_init

2020-03-05 Thread Pankaj Bharadiya
The max connector argument for drm_fb_helper_init() isn't used anymore hence remove it. All the drm_fb_helper_init() calls are modified with below sementic patch. @@ expression E1, E2, E3; @@ - drm_fb_helper_init(E1,E2, E3) + drm_fb_helper_init(E1,E2) Signed-off-by: Pankaj Bharadiya Rev

[RESEND PATCH v2 2/7] drm/radeon: remove radeon_fb_{add, remove}_connector functions

2020-03-05 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya Reviewed-by: Emil Velikov

[RESEND PATCH v2 0/7] drm: drm_fb_helper cleanup.

2020-03-05 Thread Pankaj Bharadiya
mil, Lyude) - Remove entire drm_fb_helper tasks from todo list. Daniel's "64914da24ea9 drm/fbdev-helper: don't force restores" fixes first one (Daniel) Pankaj Bharadiya (7): drm: Remove unused arg from drm_fb_helper_init drm/radeon: remove radeon_fb_{add,remove}_connector

[RESEND PATCH v2 6/7] drm/fb-helper: Remove drm_fb_helper add, add_all and remove connector functions

2020-03-05 Thread Pankaj Bharadiya
drm_fb_helper_single_add_all_connectors(), drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector() don't keep an array of connectors anymore and are just dummy. Now we have no callers to these functions hence remove them. Signed-off-by: Pankaj Bharadiya Reviewed-by: La

[RESEND PATCH v2 4/7] drm/i915/display: Remove drm_fb_helper_{add, remove}_one_connector calls

2020-03-05 Thread Pankaj Bharadiya
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya Reviewed-by: Emil Velikov

[RESEND PATCH v2 5/7] drm: Remove drm_fb_helper add, add all and remove connector calls

2020-03-05 Thread Pankaj Bharadiya
(...); @@ @@ - drm_fb_helper_remove_one_connector(...); Changes since v1: * Squashed warning fixes into the patch that introduced the warnings (into 5/7) (Laurent, Emil, Lyude) Signed-off-by: Pankaj Bharadiya Reviewed-by: Laurent Pinchart Reviewed-by: Emil Velikov Reviewed-by: Alex Deucher Reviewed-by

[RESEND PATCH v2 7/7] drm/todo: Update drm_fb_helper tasks

2020-03-05 Thread Pankaj Bharadiya
drm_fb_helper tasks are completed now hence remove them from todo list. Changes since v1: * remove entire drm_fb_helper tasks from todo list. Daniel's "64914da24ea9 drm/fbdev-helper: don't force restores" already fixes first one (Daniel) Signed-off-by: Pankaj Bharadiya

[PATCH 2/5] drm: Remove dp mst register connector callbacks

2020-03-07 Thread Pankaj Bharadiya
(...){...} Signed-off-by: Pankaj Bharadiya Suggested-by: Emil Velikov Suggested-by: Lyude Paul --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c| 6 -- drivers/gpu/drm/i915/display/intel_dp_mst.c| 6 -- drivers/gpu/drm/nouveau/dispnv50/disp.c| 7

[PATCH 0/5] Cleanup drm_dp_mst_topology_cbs hooks

2020-03-07 Thread Pankaj Bharadiya
ing up the connector((drm_connector_unregister()/drm_connector_put())) except for amdgpu_dm driver where some amdgpu_dm specific code in there. This series aims to cleaup these drm_dp_mst_topology_mgr_cbs hooks. Pankaj Bharadiya (5): drm: Register connector instead of calling register_connecto

[PATCH 3/5] drm/dp_mst: Remove register_connector callback

2020-03-07 Thread Pankaj Bharadiya
Now drm_dp_mst_topology_cbs.register_connector callback is not getting used anymore hence remove it. Signed-off-by: Pankaj Bharadiya Suggested-by: Emil Velikov Suggested-by: Lyude Paul --- include/drm/drm_dp_mst_helper.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/drm

[PATCH 4/5] drm: Add drm_dp_destroy_connector helper and use it

2020-03-07 Thread Pankaj Bharadiya
if it should stay or not. Create and use a helper which calls driver's destroy_connector hook if available otherwise does cleanup internally. This is the step towards removing identical hooks from every driver. Signed-off-by: Pankaj Bharadiya Suggested-by: Emil Velikov Suggested-by:

[PATCH 1/5] drm: Register connector instead of calling register_connector callback

2020-03-07 Thread Pankaj Bharadiya
g the drm_dp_mst_topology_mgr_cbs.register_connector callback hook. Signed-off-by: Pankaj Bharadiya Suggested-by: Emil Velikov Suggested-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/driver

[PATCH 5/5] drm: Remove drm dp mst destroy_connector callbacks

2020-03-07 Thread Pankaj Bharadiya
func }; @delete depends on r1@ identifier r1.func; @@ - static void func(...){...} Signed-off-by: Pankaj Bharadiya Suggested-by: Emil Velikov Suggested-by: Lyude Paul --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 10 -- drivers/gpu/drm/nouveau/dispnv50/disp.c | 12 driver

[PATCH 3/5] drm/i915: Introduce scaling filter related registers and bit fields.

2020-03-12 Thread Pankaj Bharadiya
ned-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/i915_reg.h | 48 + 1 file changed, 48 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index ee4a75ac9186..c64213755296 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++

[PATCH 1/5] drm: Introduce plane and CRTC scaling filter properties

2020-03-12 Thread Pankaj Bharadiya
sharp, blocky images to deliver their distinctive look. changes since RFC: * Add separate properties for plane and CRTC (Ville) Signed-off-by: Shashank Sharma Signed-off-by: Ankit Nautiyal Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/drm_atomic_uapi.c | 8 drivers/gpu/drm/drm_c

[PATCH 2/5] drm/drm-kms.rst: Add plane and CRTC scaling filter property documentation

2020-03-12 Thread Pankaj Bharadiya
Add documentation for newly introduced KMS plane and CRTC scaling filter properties. changes since RFC: * Add seperate documention for plane and CRTC. Signed-off-by: Pankaj Bharadiya --- Documentation/gpu/drm-kms.rst | 12 1 file changed, 12 insertions(+) diff --git a

[PATCH 0/5] Introduce drm scaling filter property

2020-03-12 Thread Pankaj Bharadiya
plane. - Implements and enable integer scaling for i915 Userspace patch series link: TBD. Thanks to Shashank for initiating this work. His initial work can be found here [2] [2] https://patchwork.freedesktop.org/patch/337082/ Pankaj Bharadiya (5): drm: Introduce plane and CRTC scaling filter properties

[PATCH 4/5] drm/i915/display: Add Nearest-neighbor based integer scaling support

2020-03-12 Thread Pankaj Bharadiya
filter coefficients to enable nearest-neighbor filtering. Bspec: 49247 changes since RFC: * Refine the skl_scaler_setup_nearest_neighbor_filter() logic (Ville) Signed-off-by: Shashank Sharma Signed-off-by: Ankit Nautiyal Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display

[PATCH 5/5] drm/i915: Enable scaling filter for plane and CRTC

2020-03-12 Thread Pankaj Bharadiya
e crtc co-ordinate (Danial Stone, Ville) * Add new functions to handle scaling filter setup (Ville) * Remove coefficient set 0 hardcoding. Signed-off-by: Shashank Sharma Signed-off-by: Ankit Nautiyal Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_displ

[PATCH v2 0/5] Introduce drm scaling filter property

2020-03-19 Thread Pankaj Bharadiya
nk to this cover letter. * 4/5 - Rearrange skl_scaler_setup_nearest_neighbor_filter() to iterate the registers directly instead of the phases and taps (Ville) Pankaj Bharadiya (5): drm: Introduce plane and CRTC scaling filter properties drm/drm-kms.rst: Add plane and CRTC scaling filter pro

[PATCH v2 3/5] drm/i915: Introduce scaling filter related registers and bit fields.

2020-03-19 Thread Pankaj Bharadiya
-by: Ankit Nautiyal Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/i915_reg.h | 48 + 1 file changed, 48 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 9c53fe918be6..d40f12d2a6b5 100644 --- a/drivers/gp

[PATCH v2 2/5] drm/drm-kms.rst: Add plane and CRTC scaling filter property documentation

2020-03-19 Thread Pankaj Bharadiya
Add documentation for newly introduced KMS plane and CRTC scaling filter properties. changes since v1: * None changes since RFC: * Add separate documentation for plane and CRTC. Signed-off-by: Pankaj Bharadiya --- Documentation/gpu/drm-kms.rst | 12 1 file changed, 12 insertions

[PATCH v2 1/5] drm: Introduce plane and CRTC scaling filter properties

2020-03-19 Thread Pankaj Bharadiya
sharp, blocky images to deliver their distinctive look. changes since v1: * None changes since RFC: * Add separate properties for plane and CRTC (Ville) Signed-off-by: Shashank Sharma Signed-off-by: Ankit Nautiyal Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/drm_atomic_uapi.c

[PATCH v2 4/5] drm/i915/display: Add Nearest-neighbor based integer scaling support

2020-03-19 Thread Pankaj Bharadiya
(Ville) Signed-off-by: Shashank Sharma Signed-off-by: Ankit Nautiyal Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_display.c | 72 drivers/gpu/drm/i915/display/intel_display.h | 2 + 2 files changed, 74 insertions(+) diff --git a/drivers/gpu/drm

[PATCH v2 5/5] drm/i915: Enable scaling filter for plane and CRTC

2020-03-19 Thread Pankaj Bharadiya
lle) * Do not round off the crtc co-ordinate (Danial Stone, Ville) * Add new functions to handle scaling filter setup (Ville) * Remove coefficient set 0 hardcoding. Signed-off-by: Shashank Sharma Signed-off-by: Ankit Nautiyal Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i91

[Intel-gfx] [PATCH 0/6]: drm: Introduce struct drm_device based WARN* and use them in i915

2020-01-13 Thread Pankaj Bharadiya
* macros and use them as suggested by Sam and Jani - Get rid of extra local variables [1] https://patchwork.freedesktop.org/series/71668/ Pankaj Bharadiya (6): drm/print: introduce new struct drm_device based WARN* macros drm/i915: add helper functions to get device ptr drm/i915: Make WARN* drm

[Intel-gfx] [PATCH 1/6] drm/print: introduce new struct drm_device based WARN* macros

2020-01-13 Thread Pankaj Bharadiya
. Knowing the device specific information in the backtrace would be helpful in development all around. Signed-off-by: Pankaj Bharadiya --- include/drm/drm_print.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h

[Intel-gfx] [PATCH 2/6] drm/i915: add helper functions to get device ptr

2020-01-13 Thread Pankaj Bharadiya
We will need struct drm_device pointer to pass it to drm_WARN* calls. Add helper functions to exract drm_device pointer from various structs. Signed-off-by: Pankaj Bharadiya --- drivers/gpu/drm/i915/display/intel_display_types.h | 14 ++ drivers/gpu/drm/i915/gvt/gvt.h

[Intel-gfx] [PATCH 3/6] drm/i915: Make WARN* drm specific where drm_device ptr available

2020-01-13 Thread Pankaj Bharadiya
Drm specific drm_WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_device struct pointer is readily available. The conversion was done automatica

[Intel-gfx] [PATCH 5/6] drm/i915: Make WARN* drm specific where dev_priv can be extracted.

2020-01-13 Thread Pankaj Bharadiya
Drm specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where first function argument is a struct pointer and has drm_i915_private struct pointer mem

[Intel-gfx] [PATCH 6/6] drm/i915: Make WARN* drm specific for various cases.

2020-01-13 Thread Pankaj Bharadiya
Drm specific drm_WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where any one of intel_pm, intel_encoder, i915_perf_stream or intel_crtc_state struct poi

[[Intel-gfx] [PATCH v2 00/10] drm: Introduce struct drm_device based WARN* and use them in i915

2020-01-14 Thread Pankaj Bharadiya
71668/ Pankaj Bharadiya (10): drm/print: introduce new struct drm_device based WARN* macros drm/i915/display: Make WARN* drm specific where drm_device ptr is available drm/i915/display: Make WARN* drm specific where drm_priv ptr is available drm/i915/display: Make WARN* drm specific where en

[[Intel-gfx] [PATCH v2 01/10] drm/print: introduce new struct drm_device based WARN* macros

2020-01-14 Thread Pankaj Bharadiya
. Knowing the device specific information in the backtrace would be helpful in development all around. Signed-off-by: Pankaj Bharadiya --- include/drm/drm_print.h | 29 + 1 file changed, 29 insertions(+) diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h

[[Intel-gfx] [PATCH v2 01/10] drm/print: introduce new struct drm_device based WARN* macros

2020-01-14 Thread Pankaj Bharadiya
. Knowing the device specific information in the backtrace would be helpful in development all around. Signed-off-by: Pankaj Bharadiya --- include/drm/drm_print.h | 29 + 1 file changed, 29 insertions(+) diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h

[[Intel-gfx] [PATCH v2 00/10] drm: Introduce struct drm_device based WARN* and use them in i915

2020-01-14 Thread Pankaj Bharadiya
71668/ Pankaj Bharadiya (10): drm/print: introduce new struct drm_device based WARN* macros drm/i915/display: Make WARN* drm specific where drm_device ptr is available drm/i915/display: Make WARN* drm specific where drm_priv ptr is available drm/i915/display: Make WARN* drm specific where en

[[Intel-gfx] [PATCH v2 02/10] drm/i915/display: Make WARN* drm specific where drm_device ptr is available

2020-01-14 Thread Pankaj Bharadiya
Drm specific drm_WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_device struct pointer is readily available. The conversion was done automatica

[[Intel-gfx] [PATCH v2 02/10] drm/i915/display: Make WARN* drm specific where drm_device ptr is available

2020-01-14 Thread Pankaj Bharadiya
Drm specific drm_WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_device struct pointer is readily available. The conversion was done automatica

[[Intel-gfx] [PATCH v2 04/10] drm/i915/display: Make WARN* drm specific where encoder ptr is available

2020-01-14 Thread Pankaj Bharadiya
Drm specific drm_WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where intel_encoder struct pointer is available. The conversion was done automatically w

[[Intel-gfx] [PATCH v2 03/10] drm/i915/display: Make WARN* drm specific where drm_priv ptr is available

2020-01-14 Thread Pankaj Bharadiya
drm specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_i915_private struct pointer is readily available. The conversion was done automati

[[Intel-gfx] [PATCH v2 05/10] drm/i915/gem: Make WARN* drm specific where drm_priv ptr is available

2020-01-14 Thread Pankaj Bharadiya
drm specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_i915_private struct pointer is readily available. The conversion was done automati

[[Intel-gfx] [PATCH v2 10/10] drm/i915: Make WARN* drm specific where uncore or stream ptr is available

2020-01-14 Thread Pankaj Bharadiya
drm specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where intel_uncore/i915_perf_stream struct pointer is readily available. The conversion was

[[Intel-gfx] [PATCH v2 07/10] drm/i915/gvt: Make WARN* drm specific where drm_priv ptr is available

2020-01-14 Thread Pankaj Bharadiya
drm specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_i915_private struct pointer is readily available. The conversion was done automati

[[Intel-gfx] [PATCH v2 08/10] drm/i915/gvt: Make WARN* drm specific where vgpu ptr is available

2020-01-14 Thread Pankaj Bharadiya
Drm specific drm_WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_device struct pointer is readily available. The conversion was done automatica

[[Intel-gfx] [PATCH v2 06/10] drm/i915/gt: Make WARN* drm specific where drm_priv ptr is available

2020-01-14 Thread Pankaj Bharadiya
drm specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_i915_private struct pointer is readily available. The conversion was done automati

[[Intel-gfx] [PATCH v2 09/10] drm/i915: Make WARN* drm specific where drm_priv ptr is available

2020-01-14 Thread Pankaj Bharadiya
drm specific WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_i915_private struct pointer is readily available. The conversion was done automati

[Intel-gfx] [PATCH v3 1/4] drm/i915/display: Make WARN* drm specific where drm_device ptr is available

2020-01-23 Thread Pankaj Bharadiya
Drm specific drm_WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_device struct pointer is readily available. The conversion was done automatica

[Intel-gfx] [PATCH v3 0/4] drm: Introduce struct drm_device based WARN* and use them in i915

2020-01-23 Thread Pankaj Bharadiya
local variables [1] https://patchwork.freedesktop.org/series/71668/ Pankaj Bharadiya (4): drm/i915/display: Make WARN* drm specific where drm_device ptr is available drm/i915/display: Make WARN* drm specific where drm_priv ptr is available drm/i915/gvt: Make WARN* drm specific where drm_pri

[Intel-gfx] [PATCH v3 4/4] drm/i915/gvt: Make WARN* drm specific where vgpu ptr is available

2020-01-23 Thread Pankaj Bharadiya
Drm specific drm_WARN* calls include device information in the backtrace, so we know what device the warnings originate from. Covert all the calls of WARN* with device specific drm_WARN* variants in functions where drm_device struct pointer is readily available. The conversion was done automatica

  1   2   >