Reviewed-by: Nirmoy Das
On 4/16/21 4:37 PM, Lee Jones wrote:
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c:73: warning: expecting prototype for
amdgpu_dummy_page_init(). Prototype was for amdgpu_gart_dummy_page_init()
instead
drivers/gpu/drm
Tested-by: Nirmoy Das
On 4/19/21 11:28 AM, Christian König wrote:
vmwgfx is the only driver actually using this. Move the handling into
the driver instead.
Signed-off-by: Christian König
---
drivers/gpu/drm/ttm/ttm_bo.c | 11 ---
drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 10
Reviewed-by: Nirmoy Das
On 4/26/21 2:13 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a pr_debug message. Fix it.
Signed-off-by: Colin Ian King
---
drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
/drm/ttm/ttm_device.h
@@ -297,6 +297,8 @@ struct ttm_device {
struct delayed_work wq;
};
+long ttm_global_swapout(struct ttm_operation_ctx *ctx, gfp_t gfp_flags);
There is a typo here, long -> int.
Thanks,
Nirmoy
+
static inline struct ttm_resource_mana
On 3/18/21 4:26 PM, Christian König wrote:
Am 18.03.21 um 15:43 schrieb Nirmoy:
Hi Christian,
On 3/18/21 1:47 PM, Christian König wrote:
/**
* ttm_bo_uses_embedded_gem_object - check if the given bo uses the
diff --git a/include/drm/ttm/ttm_device.h
b/include/drm/ttm/ttm_device.h
Reviewed-by: Nirmoy Das
On 3/25/21 9:53 AM, Bhaskar Chowdhury wrote:
s/acccess/access/
s/inferface/interface/
s/sequnce/sequence/ .two different places.
s/retrive/retrieve/
s/sheduling/scheduling/
s/independant/independent/
s/wether/whether/ ..two different places.
s/emmit/emit/
s
ce_needed = roundup_pow_of_two(adev->gmc.real_vram_size);
| ^~~~
Introduced by commit
453f617a30aa ("drm/amdgpu: Resize BAR0 to the maximum available size, even if it
doesn't cover VRAM")
We have a fix already merged in drm-misc-next for this.
Thanks,
Nirmoy
_
ix typo in KFD and avoid 64bit divide
v3: fix init order in VMWGFX
v4: use pdev sysfs reference instead of drm
Signed-off-by: Christian König
Reviewed-by: Zack Rusin (v3)
Tested-by: Nirmoy Das
---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 16 ++---
drivers/gpu/drm/amd/amdgpu/amdgp
Reviewed-by: Nirmoy Das
On 2/9/21 2:17 PM, Christian König wrote:
Only a zombie leftover from rebasing.
Signed-off-by: Christian König
Fixes: 3763d635deaa ("drm/ttm: add debugfs directory v2")
---
drivers/gpu/drm/ttm/ttm_device.c | 2 --
include/drm/ttm/ttm_device.h | 1 -
On 3/5/21 2:08 PM, Christian König wrote:
Am 05.03.21 um 13:56 schrieb Nirmoy Das:
This flag is only needed for BOs created by amdgpu_gem_object_create(),
so we can remove tiling_flags from the base class.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 19
->mm_node = kmalloc(sizeof(*mem), GFP_KERNEL);
- if (!mem->mm_node)
+ *res = kmalloc(sizeof(*res), GFP_KERNEL);
This should be sizeof(**res) or sizeof(struct ttm_resource).
Regards,
Nirmoy
+ if (!*res)
return -ENOMEM;
- ttm_resource_init(bo, plac
On 5/3/21 7:39 PM, Christian König wrote:
Am 03.05.21 um 19:26 schrieb Nirmoy Das:
TTM BO resource need to be freed before calling ttm_bo_assign_mem().
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu
Hi Christian,
Can you please pick this up for drm-misc-next?
Thanks,
Nirmoy
On 12/9/20 12:51 PM, Nirmoy Das wrote:
BO created with amdgpu_bo_create_reserved() wasn't clean
properly before, which causes:
[ 21.056218] WARNING: CPU: 0 PID: 7 at drivers/gpu/drm/ttm/ttm_bo.
Tested-by: Nirmoy Das Tested on commit 96fb3cbef165db97c999a02efe2287ba4b8c1ceb (HEAD,
drm-misc/drm-misc-next)
On 11/16/20 8:14 PM, Christian König wrote:
Reorder the code to fix checking if blitting is available.
Signed-off-by: Christian König
Fixes: f5a89a5cae81 drm/amdgpu/ttm: use
On 10/4/19 12:44 PM, Koenig, Christian wrote:
> First of all please send mails regarding amdgpu to the amd-gfx mailing
> list and not lkml/dri-devel.
Okay.
> Am 04.10.19 um 12:17 schrieb Nirmoy Das:
>> In amdgpu_bo_list_ioctl when idr_alloc fails
>> don't return wit
ct are freed when amdgpu_bo_list_put() is
> called, but the temporary info array with the handles needs to be freed
> as well.
>
> And it looks like that is indeed leaked here.
I am talking about the `info` array created by
amdgpu_bo_create_list_entry_array().
> Regards,
> Christ
On 10/4/19 1:30 PM, Koenig, Christian wrote:
> Am 04.10.19 um 13:26 schrieb Das, Nirmoy:
>> On 10/4/19 1:13 PM, Koenig, Christian wrote:
>>>>> NAK, that is a double free. The bo list entries are freed by
>>>>> amdgpu_bo_list_put().
>>>> Thanks, d
ugh radeon_bo_gpu_offset.
If yes then the change is much smaller than I thought i needs to be.
Christian.
Regards,
Nirmoy
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 2/13/20 2:00 PM, Christian König wrote:
Am 13.02.20 um 13:31 schrieb Nirmoy:
On 2/13/20 1:18 PM, Christian König wrote:
Looks like most of the patch is missing?
We should have quite a number of uses of the BO offset in radeon or
do all of those go through radeon_bo_gpu_offset
he AMD (or public) servers I can
give it at least a quick round of testing.
Thanks,
Nirmoy
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 2/13/20 3:30 PM, Gerd Hoffmann wrote:
@@ -311,10 +311,8 @@ qxl_bo_physical_address(struct qxl_device *qdev, struct
qxl_bo *bo,
(bo->tbo.mem.mem_type == TTM_PL_VRAM)
? &qdev->main_slot : &qdev->surfaces_slot;
- WARN_ON_ONCE((bo->tbo.offset & slot->gpu_offset
On 2/14/20 10:19 AM, Thomas Zimmermann wrote:
Hi
Am 13.02.20 um 13:01 schrieb Nirmoy Das:
With this patch series I am trying to remove GPU address dependency in
TTM and moving GPU address calculation to individual drm drivers.
This is required[1] to continue the work started by Brian Welty
On 2/14/20 10:08 AM, Gerd Hoffmann wrote:
- if (bo->mem.mm_node)
- bo->offset = (bo->mem.start << PAGE_SHIFT) +
- bdev->man[bo->mem.mem_type].gpu_offset;
- else
- bo->offset = 0;
-
My assumption is
(bo->tbo.offset - slot->gpu_offset
On 2/17/20 12:09 PM, Christian König wrote:
Am 17.02.20 um 11:18 schrieb Nirmoy Das:
Calculate GPU offset within vmwgfx driver itself without depending on
bo->offset
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 4 ++--
drivers/gpu/drm/vmwgfx/vmwgfx_execbu
On 2/17/20 1:41 PM, Gerd Hoffmann wrote:
On Mon, Feb 17, 2020 at 11:18:40AM +0100, Nirmoy Das wrote:
Calculate GPU offset within bochs driver itself without depending on
bo->offset
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/bochs/bochs_kms.c | 3 ++-
drivers/gpu/
On 2/17/20 4:57 PM, Alex Deucher wrote:
On Mon, Feb 17, 2020 at 10:02 AM Nirmoy Das wrote:
Store ttm bo->offset in struct nouveau_bo instead.
Signed-off-by: Nirmoy Das
Christian König
Missing Acked or Reviewed prefix for Christian.
:facepalm: Thanks Alex.
Nirmoy
Alex
---
driv
On 2/18/20 1:42 PM, Thomas Zimmermann wrote:
Hi,
the email's subject line should contain the version of the patchset
(e.g, v2, v3, etc). git send-mail adds this with the -v switch
Thanks Thomas. I over looked that, will add version tag from my next
emails.
Nirmoy
Best regards
T
On 2/18/20 1:44 PM, Christian König wrote:
Am 18.02.20 um 13:40 schrieb Thomas Zimmermann:
Hi
Am 17.02.20 um 16:04 schrieb Nirmoy Das:
GPU address handling is device specific and should be handle by its
device
driver.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/ttm/ttm_bo.c | 7
On 2/18/20 7:16 PM, Thomas Zimmermann wrote:
Hi
Am 18.02.20 um 18:13 schrieb Nirmoy:
On 2/18/20 1:44 PM, Christian König wrote:
Am 18.02.20 um 13:40 schrieb Thomas Zimmermann:
Hi
Am 17.02.20 um 16:04 schrieb Nirmoy Das:
GPU address handling is device specific and should be handle by its
On 2/18/20 8:06 PM, Daniel Vetter wrote:
On Tue, Feb 18, 2020 at 07:37:44PM +0100, Christian König wrote:
Am 18.02.20 um 19:28 schrieb Thomas Zimmermann:
Hi
Am 18.02.20 um 19:23 schrieb Christian König:
Am 18.02.20 um 19:16 schrieb Thomas Zimmermann:
Hi
Am 18.02.20 um 18:13 schrieb Nirmoy
On 2/20/20 7:09 PM, Daniel Vetter wrote:
On Wed, Feb 19, 2020 at 02:53:20PM +0100, Nirmoy Das wrote:
Calculate GEM VRAM bo's offset within vram-helper without depending on
bo->offset
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/drm_gem_vram_helper.c | 17 -
On 2/21/20 9:48 AM, Thomas Hellström (VMware) wrote:
Hi,
On 2/19/20 2:53 PM, Nirmoy Das wrote:
With this patch series I am trying to remove GPU address dependency in
TTM and moving GPU address calculation to individual drm drivers.
For future reference, could you please add a motivation for
On 2/21/20 2:19 AM, Luben Tuikov wrote:
On 2020-02-19 08:53, Nirmoy Das wrote:
Calculate GPU offset in radeon_bo_gpu_offset without depending on
bo->offset
Signed-off-by: Nirmoy Das
Reviewed-and-tested-by: Christian König
---
drivers/gpu/drm/radeon/radeon.h| 1 +
drivers/gpu/
Hi Gerd,
This is old one can you please review v3
https://lists.freedesktop.org/archives/dri-devel/2020-February/255760.html
Regards,
Nirmoy
On 2/24/20 9:01 AM, Gerd Hoffmann wrote:
On Mon, Feb 17, 2020 at 04:04:25PM +0100, Nirmoy Das wrote:
Calculate GPU offset within vram-helper
On 2/24/20 9:04 AM, Gerd Hoffmann wrote:
Hi,
2 unfortunately I can't say the same for bochs but it works with this patch
series so I think bochs is fine as well.
bochs needs the offset only to scanout framebuffers, which in turn
requires framebuffers being pinned to vram. So all green he
On 3/5/20 3:07 PM, Gerd Hoffmann wrote:
On Thu, Mar 05, 2020 at 02:29:08PM +0100, Nirmoy Das wrote:
Calculate GEM VRAM bo's offset within vram-helper without depending on
bo->offset.
Signed-off-by: Nirmoy Das
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/drm_gem_vram_help
On 4/28/20 6:18 PM, Chris Wilson wrote:
Quoting Nirmoy Das (2020-04-28 17:04:23)
Userspace can severely fragment rb_hole_addr rbtree by manipulating
alignment while allocating buffers. Fragmented rb_hole_addr rbtree would
result in large delays while allocating buffer object for a userspace
On 4/30/20 12:15 PM, Chris Wilson wrote:
Quoting Nirmoy Das (2020-04-30 10:58:39)
+void insert_hole_addr(struct rb_root *root, struct drm_mm_node *node)
^ static
Ah I forgot!
(sparse [make C=1] or make W=1 will spot this)
Thanks for the tip :)
Nirmoy
Looks good, I'll check
On 5/4/20 3:35 PM, Christian König wrote:
Am 04.05.20 um 12:42 schrieb Nirmoy Das:
Userspace can severely fragment rb_hole_addr rbtree by manipulating
alignment while allocating buffers. Fragmented rb_hole_addr rbtree
would result in large delays while allocating buffer object for a
userspace
Reviewed-by: Nirmoy Das
On 6/15/20 4:54 PM, Christian König wrote:
Just some code cleanup.
Signed-off-by: Christian König
---
drivers/gpu/drm/drm_mm.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
index 82d2888eb7fe
Reviewed-by: Nirmoy Das
On 6/15/20 4:54 PM, Christian König wrote:
Skipping just one branch of the tree is not the most
effective approach.
Instead use a macro to define the traversal functions and
sort out both branch sides.
This improves the performance of the unit tests by
a factor of
Acked-by: Nirmoy Das
On 6/15/20 4:54 PM, Christian König wrote:
Abort early if there isn't enough space to allocate from a subtree.
Signed-off-by: Christian König
---
drivers/gpu/drm/drm_mm.c| 11 +++
drivers/gpu/drm/selftests/test-drm_mm.c | 11 --
if ((s64)insert_time1 < 0)
goto err;
The error codes in this function seem pretty messed up.
Speaking of error codes, what the heck is going on with
prepare_igt_frag().
This is on me. I will send a patch to correct this mistake.
Thanks,
Nirmoy
1037 static int prep
Acked-by: Nirmoy Das
Thanks,
Nirmoy
On 6/24/20 4:14 PM, Colin King wrote:
From: Colin Ian King
Currently the goto statement is skipping over a lot of setup code
because it is outside of an if-block and should be inside it. Fix
this by adding missing if statement braces.
Addresses
On 9/17/20 2:29 PM, Thomas Zimmermann wrote:
Hi Christian
Am 17.09.20 um 13:12 schrieb Christian König:
Hi Thomas,
Am 17.09.20 um 12:51 schrieb Thomas Zimmermann:
Hi
Am 24.06.20 um 20:26 schrieb Nirmoy Das:
Calculate GEM VRAM bo's offset within vram-helper without depending on
bo-&g
Tested-by: Nirmoy Das
On 9/22/20 3:32 PM, Christian König wrote:
Stop using TTM_PL_FLAG_NO_EVICT.
Signed-off-by: Christian König
---
.../gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
Tested-by: Nirmoy Das
On 9/25/20 4:55 PM, Christian König wrote:
Implement the fault handler ourself using the provided TTM functions.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 20 +--
drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2
Tested this on GeForce GT 710
Tested-by: Nirmoy Das
On 9/25/20 4:55 PM, Christian König wrote:
We already implemented the fault handler ourself,
just open code what is necessary here.
Signed-off-by: Christian König
---
drivers/gpu/drm/nouveau/nouveau_bo.c | 50
Acked-by: Nirmoy Das
On 9/7/20 2:05 PM, Christian König wrote:
This is used by TTM to communicate the physical address
which should be used with ioremap(), ioremap_wc(). We don't
need to separate the base and offset in any way here.
Signed-off-by: Christian König
---
drivers/gpu/dr
Hi Chris,
On 5/20/20 12:56 AM, Chris Wilson wrote:
Quoting Nirmoy Das (2020-05-19 09:44:36)
+#define DRM_MM_ALIGN_SHIFT 6
#define HOLE_SIZE(NODE) ((NODE)->hole_size)
#define HOLE_ADDR(NODE) (__drm_mm_hole_node_start(NODE))
+#define HOLE_SIZE_ALIGN(NODE) ((NODE->hol
On 5/20/20 6:35 PM, Chris Wilson wrote:
Quoting Nirmoy (2020-05-20 17:28:04)
Hi Chris,
On 5/20/20 12:56 AM, Chris Wilson wrote:
Quoting Nirmoy Das (2020-05-19 09:44:36)
+#define DRM_MM_ALIGN_SHIFT 6
#define HOLE_SIZE(NODE) ((NODE)->hole_size)
#define HOLE_ADDR(N
On 5/28/20 6:04 PM, Chris Wilson wrote:
Quoting Nirmoy Das (2020-05-28 14:05:56)
This patch introduces fragmentation in the address range
and measures time taken by 10k insertions for each modes.
ig_frag() will fail if one of the mode takes more than 1 sec.
Output:
[ 37.326723] drm_mm
On 5/28/20 8:49 PM, Christian König wrote:
Am 28.05.20 um 15:05 schrieb Nirmoy Das:
This patch introduces fragmentation in the address range
and measures time taken by 10k insertions for each modes.
ig_frag() will fail if one of the mode takes more than 1 sec.
Output:
[ 37.326723] drm_mm
This works correctly most of the times but sometimes
20k insertions can take more than 8 times of 10k insertion time.
Regards,
Nirmoy
On 5/29/20 6:33 PM, Nirmoy Das wrote:
This patch introduces fragmentation in the address range
and measures time taken by 10k and 20k insertions. ig_frag
On 5/29/20 5:52 PM, Chris Wilson wrote:
Quoting Nirmoy (2020-05-29 16:40:53)
This works correctly most of the times but sometimes
I have to take my word back. In another machine, 20k insertions in
best mode takes 6-9 times more than 10k insertions, all most all the time.
evict, bottom-up
Hi Christian,
On 6/2/20 2:47 PM, Christian König wrote:
Nirmoy please keep in mind that your current implementation doesn't
fully solve the issue the test case is exercising.
In other words what you have implement is fast skipping of fragmented
address space for bottom-up and top-down.
On 6/2/20 4:25 PM, Christian König wrote:
Am 02.06.20 um 16:13 schrieb Nirmoy:
Hi Christian,
On 6/2/20 2:47 PM, Christian König wrote:
Nirmoy please keep in mind that your current implementation doesn't
fully solve the issue the test case is exercising.
In other words what you
On 6/5/20 9:45 AM, Christian König wrote:
Am 03.06.20 um 12:32 schrieb Nirmoy Das:
This patch introduces fragmentation in the address range
and measures time taken by 10k and 20k insertions. ig_frag()
will fail if the time taken by 20k insertions takes more than
4 times of 10k insertions as we
testing with 8k alignment. So this was
biased to optimize my test case.
Signed-off-by: Christian König
Reviewed-by: Nirmoy Das
---
drivers/gpu/drm/drm_mm.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
Releasing pinned BOs is illegal now.
UVD 6 was missing from:
commit 2f40801dc553 ("drm/amdgpu: make sure we unpin the UVD BO")
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
Remove unused adev variable
Fixes: 8f66090b7bb7 ("drm/amdgpu: Remove references to struct
drm_device.pdev")
Reported-by: Stephen Rothwell
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/
Fix two typos in struct drm_sched_entity doc
Signed-off-by: Nirmoy Das
---
include/drm/gpu_scheduler.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
index 1c815e0a14ed..3782a49568b0 100644
--- a/include/drm
Implement a new struct amdgpu_bo_user as subclass of
struct amdgpu_bo and a function to created amdgpu_bo_user
bo with a flag to identify the owner.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 44 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_object.h
This flag is only needed for BOs created by amdgpu_gem_object_create(),
so we can remove tiling_flags from the base class.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 19 +--
drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 1 -
2 files changed, 17
GEM objects encapsulate amdgpu_bo for userspace applications.
Now that we have a new amdgpu_bo_user subclass for that purpose,
let's use that instead.
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --
TTM BO resource need to be freed before calling ttm_bo_assign_mem().
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
index
Use ttm_bo_move_null() instead of ttm_bo_assign_mem().
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c
index
+0x11/0x30 [amdgpu]
[ 21.057030] process_one_work+0x1df/0x370
[ 21.057033] worker_thread+0x46/0x340
[ 21.057034] ? process_one_work+0x370/0x370
[ 21.057037] kthread+0x11b/0x140
[ 21.057039] ? __kthread_bind_mask+0x60/0x60
[ 21.057043] ret_from_fork+0x22/0x30
Signed-off-by: Nirmo
Be more defensive and raise error on wrong mem_type
argument in amdgpu_gtt_mgr_has_gart_addr().
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c
b
Return early for non-TTM_PL_TT BOs so that we don't pass
wrong pointer to amdgpu_gtt_mgr_has_gart_addr() which assumes
ttm_resource argument to be TTM_PL_TT type BO's.
v2: merge if-conditions
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 3 ++-
1 file
On 6/29/2021 1:05 PM, Christian König wrote:
Am 29.06.21 um 09:36 schrieb Nirmoy Das:
Return early for non-TTM_PL_TT BOs so that we don't pass
wrong pointer to amdgpu_gtt_mgr_has_gart_addr() which assumes
ttm_resource argument to be TTM_PL_TT type BO's.
v2: merge if-conditions
Sig
On 6/29/2021 1:06 PM, Christian König wrote:
Am 29.06.21 um 09:36 schrieb Nirmoy Das:
Be more defensive and raise error on wrong mem_type
argument in amdgpu_gtt_mgr_has_gart_addr().
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 6 +-
1 file changed, 5
Return early for non-TTM_PL_TT BOs so that we don't pass
wrong pointer to amdgpu_gtt_mgr_has_gart_addr() which assumes
ttm_resource argument to be TTM_PL_TT type BO's.
v3: remove extra braces.
v2: merge if-conditions.
Signed-off-by: Nirmoy Das
Reviewed-by: Christian König
---
drive
Hi Christian,
Could you please pick this up for drm-misc-next or fixes ?
Regards,
Nirmoy
On 6/29/2021 1:44 PM, Nirmoy Das wrote:
Return early for non-TTM_PL_TT BOs so that we don't pass
wrong pointer to amdgpu_gtt_mgr_has_gart_addr() which assumes
ttm_resource argument to be TTM_
LGTM
Acked-by: Nirmoy Das
On 6/29/2021 3:58 PM, Thomas Zimmermann wrote:
Print the name of the DRM driver when taking over fbdev devices. Makes
the output to dmesg more consistent. Note that the driver name is only
used for printing a string to the kernel log. No UAPI is affected by this
Hi Christian,
This issue looks similar to the one Mikel Rychliski fixed recently :
https://patchwork.freedesktop.org/patch/440791. Let us know if this helps.
Regards,
Nirmoy
On 7/3/2021 9:30 AM, Christian Zigotzky wrote:
Hi All,
Xorg doesn't work anymore after the latest DRM up
Happy to help, Christian :)
Nirmoy
On 7/6/2021 5:33 PM, Christian Zigotzky wrote:
Hi Nirmoy,
This patch works! Thanks a lot! We tested it on an A-EON AmigaOne
X5000/20 today.
Screenshot:
https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.skateman.nl%2Fwp-content
|Acked-by: Nirmoy Das |
On 03/03/2022 11:02, Matthew Auld wrote:
Currently this will enforce both 2M alignment and padding for any LMEM
pages inserted into the GGTT. However, this was only meant to be applied
to the compact-pt layout with the ppGTT. For the GGTT we can reduce the
alignment and
The series is Acked-by: Nirmoy Das
On 10/03/2022 13:27, Matthew Auld wrote:
The leftover bits around dealing with stolen-local memory + small BAR, plus
some related fixes.
v2: some tweaks based on feedback from Ville
|This seems more natural to me than the previous version. Acked-by:
Nirmoy Das |
Nirmoy
On 14/03/2022 12:28, Matthew Auld wrote:
On integrated it looks like the GGTT base should always 1:1 maps to
somewhere within DSM. On discrete the base seems to be pre-programmed with
a normal lmem
looks good to me overall but I would get others r-b.
Patches 1-3 Reviewed-by: Nirmoy Das
Patches 4-7 Acked-by: Nirmoy Das
On 03/03/2022 19:00, Balasubramani Vivekanandan wrote:
drm_memcpy_from_wc() performs fast copy from WC memory type using
non-temporal instructions. Now there are two
In the previous version I replied only to the mailing list email so
probably my email slipped through.
Reviewed-by: Nirmoy Das for patch 6-7
On 3/19/2022 9:42 PM, Ramalingam C wrote:
Add a parameter called "extra_pages" for ttm_tt_init, to indicate that
driver needs extra pages
Reviewed-by: Nirmoy Das
On 3/24/2022 1:04 AM, Daniele Ceraolo Spurio wrote:
On error the "new" allocation is not freed, so add the required kfree.
Fixes: 247f8071d5893 ("drm/i915/guc: Pre-allocate output nodes for extraction")
Signed-off-by: Daniele Ceraolo Spurio
Cc: A
by: Matthew Auld
Cc: Nirmoy Das
---
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
index e4a06fcf741a..97e648fa76bd 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
+
On 3/25/2022 11:03 AM, Das, Nirmoy wrote:
Reviewed-by: Nirmoy Das
Sorry, I meant this r-b for the 2nd patch and for this one Acked-by:
Nirmoy Das
;
Should the last flush_submission() be "if ( timeout > 0
&&flush_submission(gt, timeout))" ?
Nirmoy
return active_count ? timeout : 0;
}
On 3/25/2022 9:33 PM, Ceraolo Spurio, Daniele wrote:
On 3/25/2022 11:37 AM, Das, Nirmoy wrote:
On 3/25/2022 6:58 PM, Daniele Ceraolo Spurio wrote:
In intel_gt_wait_for_idle, we use the remaining timeout returned from
intel_gt_retire_requests_timeout to wait on the GuC being idle.
However
I finally managed to find a machine and tested this series. If it is not
too late
The series is Tested-by: Nirmoy Das
On 3/29/2022 9:00 AM, Christian König wrote:
When the array is empty because everything is signaled we can't use
add_fence() to add something because that would filte
On 23/02/2022 12:08, Balasubramani Vivekanandan wrote:
On 23.02.2022 10:02, Das, Nirmoy wrote:
On 22/02/2022 15:51, Balasubramani Vivekanandan wrote:
drm_memcpy_from_wc() performs fast copy from WC memory type using
non-temporal instructions. Now there are two similar implementations of
this
as I don't see any other usages left after this series,
may be I
am missing something?
Regards,
Nirmoy
Cc: Jani Nikula
Cc: Lucas De Marchi
Cc: David Airlie
Cc: Daniel Vetter
Cc: Chris Wilson
Cc: Thomas Hellstr_m
Cc: Joonas Lahtinen
Cc: Rodrigo Vivi
Cc: Tvrtko Ursulin
Bala
t
CC: Maxime Ripard
CC: Thomas Zimmermann
CC: David Airlie
CC: Daniel Vetter
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/drm_debugfs.c | 25 +++--
drivers/gpu/drm/drm_drv.c | 16 ++--
drivers/gpu/drm/drm_internal.h | 7 +++
3 files changed, 36 inser
Return early if dri minor root dentry is NULL.
CC: Alex Deucher
CC: "Christian König"
CC: "Pan, Xinhui"
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/radeon/r100.c | 9 +
drivers/gpu/drm/radeon/r300.c | 3 +++
drivers/gpu/drm/radeon/r420.c
Return early if dri minor root dentry is NULL.
CC: Russell King
CC: David Airlie
CC: Daniel Vetter
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/armada/armada_debugfs.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/armada/armada_debugfs.c
b/drivers/gpu/drm
Return early if dri minor root dentry is NULL.
CC: Zhenyu Wang
CC: Zhi Wang
CC: Jani Nikula
CC: Joonas Lahtinen
CC: Rodrigo Vivi
CC: David Airlie
CC: Daniel Vetter
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/i915/gvt/debugfs.c | 3 +++
drivers/gpu/drm/i915/i915_debugfs.c | 3 +++
2
Return early if crtc or connector's debugfs root dentries are NULL.
CC: Thierry Reding
CC: David Airlie
CC: Daniel Vetter
CC: Jonathan Hunter
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/tegra/dc.c | 5 +
drivers/gpu/drm/tegra/dsi.c | 4
drivers/gpu/drm/tegra/hdmi.
[AMD Official Use Only]
I sent all the patches to dr-devel. I think there is an issue with our email
server. Thunderbird is asking for a password every few minutes.
https://patchwork.freedesktop.org/series/95603/
Nirmoy
[sending this from my browser]
From
[AMD Official Use Only]
Thanks, Greg and Jani. So I have to do the exact opposite.
We do have some NULL dentry check in the drm code. I will remove those instead.
Regards,
Nirmoy
From: Greg KH
Sent: Friday, October 8, 2021 1:07 PM
To: Jani Nikula
Cc: Das
[AMD Official Use Only]
Trying with Christian's Gmail, as he still didn't receive previous emails.
From: Das, Nirmoy
Sent: Friday, October 8, 2021 2:17 PM
To: Koenig, Christian
Cc: dri-devel@lists.freedesktop.org ;
intel-...@lists.freedesktop.org
On 10/11/2021 4:19 PM, Christian König wrote:
Am 08.10.21 um 17:11 schrieb Greg KH:
On Fri, Oct 08, 2021 at 04:22:06PM +0200, Christian König wrote:
Hi guys,
thanks Nirmoy for forwarding this, there is seriously something
wrong with
the AMD mail servers.
On 10/8/2021 1:07 PM, Greg KH
for NULL, as saved dentry pointers will either contain a
valid pointer or an error code.
CC: Maarten Lankhorst
CC: Maxime Ripard
CC: Thomas Zimmermann
CC: David Airlie
CC: Daniel Vetter
Signed-off-by: Nirmoy Das
---
drivers/gpu/drm/drm_debugfs.c | 9 -
1 file changed, 9 deletions
1 - 100 of 584 matches
Mail list logo
