Re: [PATCH v2 1/2] drm/i915/hdcp: Add DP HDCP2.2 timeout to read entire msg

LGTM. Reviewed-by: Ankit Nautiyal On 3/24/2021 5:00 PM, Anshuman Gupta wrote: As documented in HDCP 2.2 DP Errata spec transmitter should abort the authentication protocol in case transmitter has not received the entire {AKE_Send_Cert, AKE_Send_H_prime, AKE_Send_Paring_Info} msg within {110,7,

Re: [PATCH v7 09/15] drm/i915: Add support for starting FRL training for HDMI2.1 via PCON

Hi Ville, Please find my responses inline. On 2/2/2021 2:08 AM, Ville Syrjälä wrote: On Fri, Dec 18, 2020 at 04:07:17PM +0530, Ankit Nautiyal wrote: This patch adds functions to start FRL training for an HDMI2.1 sink, connected via a PCON as a DP branch device. This patch also adds a new struc

Re: [PATCH v7 09/15] drm/i915: Add support for starting FRL training for HDMI2.1 via PCON

On 2/2/2021 12:17 PM, Ville Syrjälä wrote: On Tue, Feb 02, 2021 at 12:09:47PM +0530, Nautiyal, Ankit K wrote: Hi Ville, Please find my responses inline. On 2/2/2021 2:08 AM, Ville Syrjälä wrote: On Fri, Dec 18, 2020 at 04:07:17PM +0530, Ankit Nautiyal wrote: This patch adds functions to

Re: [PATCH 1/3] i915/display/intel_dp: Read PCON DSC ENC caps only for DPCD rev >= 1.4

On 2/8/2021 4:45 PM, Jani Nikula wrote: On Thu, 04 Feb 2021, Ankit Nautiyal wrote: DP-HDMI2.1 PCON has DSC encoder caps defined in registers 0x92-0x9E. Do not read the registers if DPCD rev < 1.4. Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/2868 Please use Fixes: to reference c

Re: [PATCH 2/3] drm/dp_helper: Define options for FRL training for HDMI2.1 PCON

On 2/6/2021 1:30 AM, Ville Syrjälä wrote: On Thu, Feb 04, 2021 at 12:18:41PM +0530, Ankit Nautiyal wrote: Currently the FRL training mode (Concurrent, Sequential) and training type (Normal, Extended) are not defined properly and are passed as bool values in drm_helpers for pcon configuration fo

Re: [PATCH 1/3] i915/display/intel_dp: Read PCON DSC ENC caps only for DPCD rev >= 1.4

been 0, instead of timeout. I will drop this patch for now, from the series and revisit it later. Thanks & Regards, Ankit On 2/8/2021 5:14 PM, Nautiyal, Ankit K wrote: On 2/8/2021 4:45 PM, Jani Nikula wrote: On Thu, 04 Feb 2021, Ankit Nautiyal wrote: DP-HDMI2.1 PCON has DSC encoder

Re: [PATCH v2 12/13] drm/i915: Add helper functions for calculating DSC parameters for HDMI2.1

Hi Uma, Thanks for the comments and spotting the errors. I agree to most of the comments and will address them in the next version. Please find my responses inline: On 11/26/2020 1:58 AM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Sunday, November 1

Re: [PATCH v2 13/13] drm/i915: Configure PCON for DSC1.1 to DSC1.2 encoding

Thanks Uma for the comments. Please find my responses inline: On 11/26/2020 2:15 AM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Sunday, November 1, 2020 3:37 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; Kulkarni

Re: [PATCH v4 07/16] drm/dp_helper: Add helpers to configure PCONs RGB-YCbCr Conversion

Hi Dan, Thanks for the mail. As rightly mentioned, the intention was && instead of ||. I will fix the issue in the next version of the patch. Thanks & Regards, Ankit On 12/9/2020 11:20 PM, Dan Carpenter wrote: Hi Ankit, url: https://github.com/0day-ci/linux/commits/Ankit-Nautiyal/Add-s

Re: [PATCH 1/3] drm/i915_hdmi: Fix the definition of intel_hdmi_dsc_get_bpp

On 1/25/2022 3:15 PM, Jani Nikula wrote: On Tue, 25 Jan 2022, Ankit Nautiyal wrote: Fix the data-type of the argument output_format to enum, for the function intel_hdmi_dsc_get_bpp. The subject prefix should be "drm/i915/hdmi:". Thanks for pointing it out. Will fix this. Fixes: 6e6cb758e

Re: [PATCH 2/3] drm/drm_edid: Add helper to get max FRL rate for an HDMI sink

On 1/25/2022 3:22 PM, Jani Nikula wrote: On Tue, 25 Jan 2022, Ankit Nautiyal wrote: Move the common function for getting the max FRL rate for an HDMI sink, from intel_dp.c to drm/drm_edid. The subject prefix should be "drm/edid:" But I'm not sure these functions belong in drm_edid.c though.

Re: [PATCH v4 07/16] drm/dp_helper: Add helpers to configure PCONs RGB-YCbCr Conversion

Hi Uma Shankar, Thanks for the comments and suggestions. Please find my response inline. On 12/13/2020 12:40 PM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Tuesday, December 8, 2020 1:22 PM To: intel-...@lists.freedesktop.org Cc: dri-devel

Re: [PATCH v4 15/16] drm/i915: Let PCON convert from RGB to YUV if it can

On 12/13/2020 12:53 PM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Tuesday, December 8, 2020 1:22 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; airl...@linux.ie; jani.nik...@linux.intel.com; ville.syrj

Re: [PATCH v4 16/16] drm/i915: Enable PCON configuration for Color Conversion for TGL

On 12/13/2020 12:59 PM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Tuesday, December 8, 2020 1:22 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; airl...@linux.ie; jani.nik...@linux.intel.com; ville.syrj

Re: [PATCH] drm/drm_edid: Refactor HFVSDB parsing for DSC1.2

On 8/2/2022 8:19 PM, Jani Nikula wrote: On Fri, 22 Jul 2022, Ankit Nautiyal wrote: DSC capabilities are given in bytes 11-13 of VSDB (i.e. bytes 8-10 of SCDS). Since minimum length of Data block is 7, all bytes greater than 7 must be read only after checking the length of the data block. Thi

Re: [PATCH 05/25] drm/edid: keep propagating drm_edid to display info

On 5/6/2022 3:46 PM, Jani Nikula wrote: On Fri, 06 May 2022, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. I seem to have copy-pasted a TAB in some of the commit messages, in a way that does not show up in git log. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edi

Re: [PATCH 03/25] drm/edid: add struct drm_edid container

LGTM. Reviewed-by: Ankit Nautiyal On 5/6/2022 3:40 PM, Jani Nikula wrote: Introduce new opaque type struct drm_edid to encapsulate the EDID data and the size allocated for it. The contents will be private to drm_edid.c. There are a number of reasons for adding a container around struct edid:

Re: [PATCH v2 05/25] drm/edid: keep propagating drm_edid to display info

On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Use drm_edid_legacy_init() Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 48 +++--- 1 file changed, 29 insertions(+), 19 deletions(-) diff --git a/driver

Re: [Intel-gfx] [PATCH v2 04/25] drm/edid: start propagating drm_edid to lower levels

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. This is a clunky start, but a start nonetheless. We'll eventually convert all of the EDID parsing to struct drm_edid. Initially, we'll just create the struct

Re: [Intel-gfx] [PATCH v2 03/25] drm/edid: add struct drm_edid container

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: Introduce new opaque type struct drm_edid to encapsulate the EDID data and the size allocated for it. The contents will be private to drm_edid.c. There are a number of reasons for adding a container aro

Re: [PATCH v2 06/25] drm/edid: propagate drm_edid to drm_edid_to_eld()

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/driv

Re: [Intel-gfx] [PATCH v2 07/25] drm/edid: convert drm_edid_connector_update() to drm_edid fully

On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 95 ++ 1 file changed, 46 insertions(+), 49 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/g

Re: [PATCH v2 08/25] drm/edid: convert struct detailed_mode_closure to drm_edid

LGTM, The subject perhaps can be modified to suggest drm_edid being added to detailed_mode_closure. In any case: Reviewed-by: Ankit Nautiyal On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 2

Re: [Intel-gfx] [PATCH v2 09/25] drm/edid: convert drm_mode_detailed() to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm

Re: [Intel-gfx] [PATCH v2 10/25] drm/edid: convert drm_dmt_modes_for_range() to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/

Re: [PATCH v2 11/25] drm/edid: convert drm_gtf_modes_for_range() to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/

Re: [Intel-gfx] [PATCH v2 12/25] drm/edid: convert drm_cvt_modes_for_range() to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/dr

Re: [Intel-gfx] [PATCH v2 13/25] drm/edid: convert drm_mode_std() and children to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 52 -- 1 file changed, 27 insertions(+), 25 deletions(-)

Re: [Intel-gfx] [PATCH v2 14/25] drm/edid: convert mode_in_range() and drm_monitor_supports_rb() to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git

Re: [PATCH v2 15/25] drm/edid: convert get_monitor_name() to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Drop incorrect NULL name check (Dan Carpenter) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 24 1 file chang

Re: [PATCH v2 16/25] drm/edid: convert drm_for_each_detailed_block() to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Fix checkpatch warning on superfluous parens Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 36 ++-- 1

Re: [PATCH v2 17/25] drm/edid: add drm_edid helper for drm_edid_to_sad()

On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit --- drivers/gpu/drm/drm_edid.c | 34 +- 1 file

Re: [Intel-gfx] [PATCH v2 18/25] drm/edid: add drm_edid helper for drm_edid_to_speaker_allocation()

LGTM Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere.' v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 37 +++-- 1 file ch

Re: [Intel-gfx] [PATCH v2 19/25] drm/edid: add drm_edid helper for drm_detect_hdmi_monitor()

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 33 - 1 file change

Re: [Intel-gfx] [PATCH v2 20/25] drm/edid: add drm_edid helper for drm_detect_monitor_audio()

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 37 ++--- 1 file ch

Re: [PATCH v2 21/25] drm/edid: convert cea_db_iter_edid_begin() to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Handle NULL drm_edid Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 21 +++-- 1 file changed, 11 insertions(+), 10 dele

Re: [PATCH v2 22/25] drm/edid: convert drm_edid_iter_begin() to drm_edid

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Rebase Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) dif

Re: [Intel-gfx] [PATCH v2 23/25] drm/edid: add drm_edid helper for drm_update_tile_info()

LGTM. Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Handle NULL EDID pointer (Ville, CI) Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 14 +++--- 1 file changed, 11 insertions(+)

Re: [PATCH v2 24/25] drm/displayid: convert to drm_edid

LGTM Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. v2: Rebase Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_displayid.c | 16 drivers/gpu/drm/drm_edid.c | 17 ++---

Re: [PATCH v2 25/25] drm/edid: convert version_greater() to drm_edid

LGTM Reviewed-by: Ankit Nautiyal Regards, Ankit On 5/9/2022 5:33 PM, Jani Nikula wrote: We'll need to propagate drm_edid everywhere. Also make version_greater() a function for type safety. Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_edid.c | 29 + 1 fi

Re: [PATCH 2/2] drm/i915/hdmi: Prune unsupported modes as per HDMI2.1 spec

On 5/10/2022 12:31 PM, Ville Syrjälä wrote: On Mon, May 09, 2022 at 03:01:30PM +0530, Ankit Nautiyal wrote: As per Sec 7.8.1 of HDMI2.1 spec, sources that support modes: 4K100, 4K120, 8K50, 8K60 must support these modes in at least one of the below formats: i) uncompressed FRL, 420 format and

Re: [PATCH 4/4] drm/edid: Avoid multiple log lines for HFVSDB parsing

Thanks Jani for the review and suggestions. I agree with the suggestions and will make changes in next version. Please find my response inline: On 9/13/2022 7:24 PM, Jani Nikula wrote: On Thu, 11 Aug 2022, Ankit Nautiyal wrote: Replace multiple log lines with a single log line at the end of

Re: [PATCH 02/16] drm/i915/dp: Avoid forcing DSC BPC for MST case

On 1/24/2023 9:53 PM, Jani Nikula wrote: On Fri, 20 Jan 2023, Ankit Nautiyal wrote: For MST the bpc is hardcoded to 8, and pipe bpp to 24. So avoid forcing DSC bpc for MST case. It's likely better to warn and ignore the debug flag than to bail out. Hmm..but then the test using this flag wi

Re: [Intel-gfx] [PATCH 1/2] drm/dsc: fix drm_edp_dsc_sink_output_bpp() DPCD high byte usage

LGTM. Reviewed-by: Ankit Nautiyal On 4/6/2023 7:16 PM, Jani Nikula wrote: The operator precedence between << and & is wrong, leading to the high byte being completely ignored. For example, with the 6.4 format, 32 becomes 0 and 24 becomes 8. Fix it, and remove the slightly confusing and unneces

Re: [PATCH 2/2] drm/dsc: fix DP_DSC_MAX_BPP_DELTA_* macro values

LGTM. Reviewed-by: Ankit Nautiyal On 4/6/2023 7:16 PM, Jani Nikula wrote: The macro values just don't match the specs. Fix them. Fixes: 1482ec00be4a ("drm: Add missing DP DSC extended capability definitions.") Cc: Vinod Govindapillai Cc: Stanislav Lisovskiy Signed-off-by: Jani Nikula ---

Re: [Intel-gfx] [PATCH v2] drm/i915/display/lspcon: Increase LSPCON mode settle timeout

On 6/15/2023 5:24 AM, Pablo Ceballos wrote: This is to eliminate all cases of "*ERROR* LSPCON mode hasn't settled", followed by link training errors. Intel engineers recommended increasing this timeout and that does resolve the issue. On some CometLake-based device designs the Parade PS175 tak

Re: [PATCH 05/13] drm/i915/intel_cdclk: Add vdsc with bigjoiner constraints on min_cdlck

Thanks Ville and Stan for the comments. I agree with the changes in _plane_min_cdclk and intel_pixel_rate_to_cdclk regarding PPC. But I am a little confused for about the pixel clock. Please find my comments inline: On 5/16/2023 3:41 PM, Lisovskiy, Stanislav wrote: On Mon, May 15, 2023 at

Re: [PATCH 04/13] drm/i915/dp: Update Bigjoiner interface bits for computing compressed bpp

On 5/15/2023 7:21 PM, Ville Syrjälä wrote: On Fri, May 12, 2023 at 11:54:08AM +0530, Ankit Nautiyal wrote: In Bigjoiner check for DSC, bigjoiner interface bits for DP for DISPLAY > 13 is 36 (Bspec: 49259). v2: Corrected Display ver to 13. v3: Follow convention for conditional statement. (Vil

Re: [PATCH 12/13] drm/i915/dp: Get optimal link config to have best compressed bpp

Thanks Stan and Ville for the review comments. I agree can have some documentation about the values used, instead of magic numbers. Also, Ville's approach for dsc_{sink,source}_{min,max}_bpp() seems good, and that can be used as helpers in MST case too. Will add the changes in the next vers

Re: [PATCH 05/19] drm/i915/dp: Update Bigjoiner interface bits for computing compressed bpp

Hi Stan, Thanks for the reviews ans suggestions. Please my response inline: On 7/20/2023 2:59 PM, Lisovskiy, Stanislav wrote: On Thu, Jul 13, 2023 at 04:03:32PM +0530, Ankit Nautiyal wrote: In Bigjoiner check for DSC, bigjoiner interface bits for DP for DISPLAY > 13 is 36 (Bspec: 49259). v2:

Re: [PATCH 06/19] drm/i915/display: Account for DSC not split case while computing cdclk

On 7/20/2023 2:46 PM, Lisovskiy, Stanislav wrote: On Thu, Jul 13, 2023 at 04:03:33PM +0530, Ankit Nautiyal wrote: Currently we assume 2 Pixels Per Clock (PPC) while computing plane cdclk and min_cdlck. In cases where DSC single engine is used the throughput is 1 PPC. So account for the above

Re: [PATCH 07/19] drm/i915/intel_cdclk: Add vdsc with bigjoiner constraints on min_cdlck

On 7/20/2023 2:54 PM, Lisovskiy, Stanislav wrote: On Thu, Jul 13, 2023 at 04:03:34PM +0530, Ankit Nautiyal wrote: As per Bsepc:49259, Bigjoiner BW check puts restriction on the compressed bpp for a given CDCLK, pixelclock in cases where Bigjoiner + DSC are used. Currently compressed bpp is co

Re: [PATCH 05/19] drm/i915/dp: Update Bigjoiner interface bits for computing compressed bpp

On 7/25/2023 3:43 PM, Lisovskiy, Stanislav wrote: On Mon, Jul 24, 2023 at 05:49:11PM +0530, Nautiyal, Ankit K wrote: Hi Stan, Thanks for the reviews ans suggestions. Please my response inline: On 7/20/2023 2:59 PM, Lisovskiy, Stanislav wrote: On Thu, Jul 13, 2023 at 04:03:32PM +0530

Re: [PATCH 06/19] drm/i915/display: Account for DSC not split case while computing cdclk

On 7/25/2023 3:40 PM, Lisovskiy, Stanislav wrote: On Tue, Jul 25, 2023 at 11:22:52AM +0530, Nautiyal, Ankit K wrote: On 7/20/2023 2:46 PM, Lisovskiy, Stanislav wrote: On Thu, Jul 13, 2023 at 04:03:33PM +0530, Ankit Nautiyal wrote: Currently we assume 2 Pixels Per Clock (PPC) while computing

Re: [PATCH 05/19] drm/i915/dp: Update Bigjoiner interface bits for computing compressed bpp

On 7/25/2023 4:49 PM, Nautiyal, Ankit K wrote: On 7/25/2023 3:43 PM, Lisovskiy, Stanislav wrote: On Mon, Jul 24, 2023 at 05:49:11PM +0530, Nautiyal, Ankit K wrote: Hi Stan, Thanks for the reviews ans suggestions. Please my response inline: On 7/20/2023 2:59 PM, Lisovskiy, Stanislav wrote

Re: [PATCH 10/20] drm/i915/dp: Add functions to get min/max src input bpc with DSC

On 8/2/2023 5:35 PM, Lisovskiy, Stanislav wrote: On Fri, Jul 28, 2023 at 09:41:40AM +0530, Ankit Nautiyal wrote: Separate out functions for getting maximum and minimum input BPC based on platforms, when DSC is used. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c

Re: [PATCH 00/20] DSC misc fixes

On 8/17/2023 3:19 PM, Jani Nikula wrote: On Thu, 10 Aug 2023, Ankit Nautiyal wrote: This series is an attempt to address multiple issues with DSC, scattered in separate existing series. I think it's a good idea to have one person manage the series, and combine it all together, because it tou

Re: [Intel-gfx] [PATCH 2/2] drivers/drm/i915: Honor limits->max_bpp while computing DSC max input bpp

Thanks Stan for the review. Regards, Ankit On 8/24/2023 2:59 PM, Lisovskiy, Stanislav wrote: On Wed, Aug 23, 2023 at 05:24:25PM +0530, Ankit Nautiyal wrote: Edid specific BPC constraints are stored in limits->max_bpp. Honor these limits while computing the input bpp for DSC. Signed-off-by: A

Re: [Intel-gfx] [PATCH 2/2] drivers/drm/i915: Honor limits->max_bpp while computing DSC max input bpp

On 8/24/2023 3:14 PM, Jani Nikula wrote: On Wed, 23 Aug 2023, Ankit Nautiyal wrote: Edid specific BPC constraints are stored in limits->max_bpp. Honor these limits while computing the input bpp for DSC. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 4 +++- 1

Re: [PATCH 1/2] drm/display/dp: Default 8 bpc support when DSC is supported

Thanks Jani for the corrections and suggestions. I agree to them and will fix them in next version. Now that I see the commit subject line also should have been "Assume 8 bpc support when DSC is supported", will change that too. Regards, Ankit On 8/24/2023 3:15 PM, Jani Nikula wrote: On Th

Re: [Intel-gfx] [PATCH v2] drm/i915/display/lspcon: Increase LSPCON mode settle timeout

On 7/8/2023 1:04 AM, Pablo Ceballos wrote: On Wed, Jun 14, 2023 at 9:35 PM Nautiyal, Ankit K wrote: I was wondering if trying to set LS/PCON mode multiple time will have any effect. Unfortunately I do not have access to machine with Parade LSPCON chip, had suggested in yet another git lab

Re: [RFC 01/13] drm/edid: Add additional HFVSDB fields for HDMI2.1

- From: Nautiyal, Ankit K Sent: Thursday, October 15, 2020 4:23 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; Kulkarni, Vandita ; ville.syrj...@linux.intel.com; Sharma, Swati2 Subject: [RFC 01/13] drm/edid: Add additional HFVSDB fields for HDMI2.1 From

Re: [RFC 02/13] drm/edid: Parse MAX_FRL field from HFVSDB block

On 10/19/2020 2:17 AM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Thursday, October 15, 2020 4:23 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; Kulkarni, Vandita ; ville.syrj...@linux.intel.com; Sharma, Swati2

Re: [RFC 03/13] drm/dp_helper: Add FRL training support for a DP-HDMI2.1 PCON

On 10/19/2020 3:03 AM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Thursday, October 15, 2020 4:23 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; Kulkarni, Vandita ; ville.syrj...@linux.intel.com; Sharma, Swati2

Re: [RFC 04/13] drm/i915: Capture max frl rate for PCON in dfp cap structure

On 10/19/2020 3:11 AM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Thursday, October 15, 2020 4:23 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; Kulkarni, Vandita ; ville.syrj...@linux.intel.com; Sharma, Swati2

Re: [RFC 05/13] drm/i915: Add support for starting FRL training for HDMI2.1 via PCON

On 10/19/2020 3:44 AM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Thursday, October 15, 2020 4:23 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; Kulkarni, Vandita ; ville.syrj...@linux.intel.com; Sharma, Swati2

Re: [RFC 06/13] drm/i915: Check for FRL training before DP Link training

On 10/19/2020 3:51 AM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Thursday, October 15, 2020 4:23 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; Kulkarni, Vandita ; ville.syrj...@linux.intel.com; Sharma, Swati2

Re: [RFC 07/13] drm/dp_helper: Add support for link status and link recovery

On 10/19/2020 4:07 AM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Thursday, October 15, 2020 4:23 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; Kulkarni, Vandita ; ville.syrj...@linux.intel.com; Sharma, Swati2

Re: [RFC 08/13] drm/i915: Add support for enabling link status and recovery

On 10/19/2020 4:19 AM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Thursday, October 15, 2020 4:23 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; Kulkarni, Vandita ; ville.syrj...@linux.intel.com; Sharma, Swati2

Re: [RFC 09/13] drm/edid: Parse DSC1.2 cap fields from HFVSDB block

On 10/19/2020 4:31 AM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Thursday, October 15, 2020 4:23 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; Kulkarni, Vandita ; ville.syrj...@linux.intel.com; Sharma, Swati2

Re: [RFC 10/13] drm/dp_helper: Add support for Configuring DSC for HDMI2.1 Pcon

On 10/19/2020 4:49 AM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Thursday, October 15, 2020 4:23 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; Kulkarni, Vandita ; ville.syrj...@linux.intel.com; Sharma, Swati2

Re: [RFC 11/13] drm/i915: Read DSC capabilities of the HDMI2.1 PCON encoder

On 10/19/2020 5:02 AM, Shankar, Uma wrote: -Original Message- From: Nautiyal, Ankit K Sent: Thursday, October 15, 2020 4:23 PM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; Kulkarni, Vandita ; ville.syrj...@linux.intel.com; Sharma, Swati2

Re: [RFC 11/13] drm/i915: Read DSC capabilities of the HDMI2.1 PCON encoder

On 10/19/2020 5:04 AM, Shankar, Uma wrote: -Original Message- From: Shankar, Uma Sent: Monday, October 19, 2020 5:02 AM To: Nautiyal, Ankit K ; intel- g...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Kulkarni, Vandita ; ville.syrj...@linux.intel.com; Sharma, Swati2

Re: [PATCH] drm: fix drm_dp_mst_port refcount leaks in drm_dp_mst_allocate_vcpi

Hi Xin Xong, I have seen insufficient vcpi ports issues with MST daisy chain. While running the IGT tests on MST, some times the vcpi ports are all used up. Due to this the atomic check fails and the flips start failing with ENOSPC. htt

[PATCH v12 02/10] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy

From: Ville Syrjälä Use drm_mode_equal_no_clocks_no_stereo() in drm_match_hdmi_mode_clock_tolerance() for consistency as we also use it in drm_match_hdmi_mode() and the cea mode matching functions. This doesn't actually change anything since the input mode comes from detailed timings and we matc

[PATCH v12 06/10] drm: Add DRM client cap for aspect-ratio

From: Ankit Nautiyal To enable aspect-ratio support in DRM, blindly exposing the aspect ratio information along with mode, can break things in existing non-atomic user-spaces which have no intention or support to use this aspect ratio information. To avoid this, a new drm client cap is required

[PATCH v12 05/10] video/hdmi: Reject illegal picture aspect ratios

From: Ville Syrjälä AVI infoframe can only carry none, 4:3, or 16:9 picture aspect ratios. Return an error if the user asked for something different. Cc: Shashank Sharma Cc: "Lin, Jia" Cc: Akashdeep Sharma Cc: Jim Bride Cc: Jose Abreu Cc: Daniel Vetter Cc: Emil Velikov Cc: Thierry Reding

[PATCH v12 07/10] drm: Handle aspect ratio info in legacy modeset path

From: Ankit Nautiyal If the user-space does not support aspect-ratio, and requests for a modeset with mode having aspect ratio bits set, then the given user-mode must be rejected. Secondly, while preparing a user-mode from kernel mode, the aspect-ratio info must not be given, if aspect-ratio is n

[PATCH v12 01/10] drm/modes: Introduce drm_mode_match()

From: Ville Syrjälä Make mode matching less confusing by allowing the caller to specify which parts of the modes should match via some flags. Signed-off-by: Ville Syrjälä Reviewed-by: Shashank Sharma --- drivers/gpu/drm/drm_modes.c | 134 ++-- include/d

[PATCH v12 09/10] drm: Add aspect ratio parsing in DRM layer

From: "Sharma, Shashank" Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due to wrong VIC. This patch add

[PATCH v12 08/10] drm: Expose modes with aspect ratio, only if requested

From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, regadless of whether user space requested this information or not. This patch prunes the modes with aspect-ratio information, from a connector's modeli

[PATCH v12 00/10] Aspect ratio support in DRM layer

From: Ankit Nautiyal This patch series is a re-attempt to enable aspect ratio support in DRM layer. Currently the aspect ratio information gets lost in translation during a user->kernel mode or vice versa. The old patch series (https://pw-emeril.freedesktop.org/series/10850/) had 4 patches, out

[PATCH v12 03/10] drm/edid: Fix cea mode aspect ratio handling

From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add aspect ratio handing back we need to be more careful. Let's handle this by considering the aspect

[PATCH v12 04/10] drm/edid: Don't send bogus aspect ratios in AVI infoframes

From: Ville Syrjälä If the user mode would specify an aspect ratio other than 4:3 or 16:9 we now silently ignore it. Maybe a better apporoach is to return an error? Let's try that. Also we must be careful that we don't try to send illegal picture aspect in the infoframe as it's only capable of s

[PATCH v12 10/10] drm: Add and handle new aspect ratios in DRM layer

From: "Sharma, Shashank" HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise versa. This patch was once

Re: [PATCH v12 07/10] drm: Handle aspect ratio info in legacy modeset path

On 4/27/2018 7:24 PM, Ville Syrjälä wrote: On Fri, Apr 27, 2018 at 05:44:53PM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal If the user-space does not support aspect-ratio, and requests for a modeset with mode having aspect ratio bits set, then the given user-mode must be rejected

Re: [PATCH v12 08/10] drm: Expose modes with aspect ratio, only if requested

On 4/27/2018 7:35 PM, Ville Syrjälä wrote: On Fri, Apr 27, 2018 at 05:44:54PM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, regadless of whether user

[PATCH v13 01/10] drm/modes: Introduce drm_mode_match()

From: Ville Syrjälä Make mode matching less confusing by allowing the caller to specify which parts of the modes should match via some flags. Signed-off-by: Ville Syrjälä Reviewed-by: Shashank Sharma --- drivers/gpu/drm/drm_modes.c | 134 ++-- include/d

[PATCH v13 03/10] drm/edid: Fix cea mode aspect ratio handling

From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add aspect ratio handing back we need to be more careful. Let's handle this by considering the aspect

[PATCH v13 04/10] drm/edid: Don't send bogus aspect ratios in AVI infoframes

From: Ville Syrjälä If the user mode would specify an aspect ratio other than 4:3 or 16:9 we now silently ignore it. Maybe a better apporoach is to return an error? Let's try that. Also we must be careful that we don't try to send illegal picture aspect in the infoframe as it's only capable of s

[PATCH v13 02/10] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy

From: Ville Syrjälä Use drm_mode_equal_no_clocks_no_stereo() in drm_match_hdmi_mode_clock_tolerance() for consistency as we also use it in drm_match_hdmi_mode() and the cea mode matching functions. This doesn't actually change anything since the input mode comes from detailed timings and we matc

[PATCH v13 06/10] drm: Add DRM client cap for aspect-ratio

From: Ankit Nautiyal To enable aspect-ratio support in DRM, blindly exposing the aspect ratio information along with mode, can break things in existing non-atomic user-spaces which have no intention or support to use this aspect ratio information. To avoid this, a new drm client cap is required

[PATCH v13 00/10] Aspect ratio support in DRM layer

From: Ankit Nautiyal This patch series is a re-attempt to enable aspect ratio support in DRM layer. Currently the aspect ratio information gets lost in translation during a user->kernel mode or vice versa. The old patch series (https://pw-emeril.freedesktop.org/series/10850/) had 4 patches, out

[PATCH v13 07/10] drm: Handle aspect ratio info in legacy modeset path

From: Ankit Nautiyal If the user-space does not support aspect-ratio, and requests for a modeset with mode having aspect ratio bits set, then the given user-mode must be rejected. Secondly, while preparing a user-mode from kernel mode, the aspect-ratio info must not be given, if aspect-ratio is n

[PATCH v13 08/10] drm: Expose modes with aspect ratio, only if requested

From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, regardless of whether user space requested this information or not. This patch: -prunes the modes with aspect-ratio information, from a connector's mo

[PATCH v13 05/10] video/hdmi: Reject illegal picture aspect ratios

From: Ville Syrjälä AVI infoframe can only carry none, 4:3, or 16:9 picture aspect ratios. Return an error if the user asked for something different. Cc: Shashank Sharma Cc: "Lin, Jia" Cc: Akashdeep Sharma Cc: Jim Bride Cc: Jose Abreu Cc: Daniel Vetter Cc: Emil Velikov Cc: Thierry Reding

[PATCH v13 09/10] drm: Add aspect ratio parsing in DRM layer

From: "Sharma, Shashank" Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due to wrong VIC. This patch add

[PATCH v13 10/10] drm: Add and handle new aspect ratios in DRM layer

From: "Sharma, Shashank" HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise versa. This patch was once

Re: [PATCH v13 08/10] drm: Expose modes with aspect ratio, only if requested

On 5/5/2018 1:49 AM, Ville Syrjälä wrote: On Thu, May 03, 2018 at 08:26:26AM +0200, Daniel Vetter wrote: On Wed, May 02, 2018 at 12:20:20PM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes

Re: [PATCH v13 08/10] drm: Expose modes with aspect ratio, only if requested

On 5/7/2018 5:58 PM, Ville Syrjälä wrote: On Mon, May 07, 2018 at 10:34:53AM +0530, Nautiyal, Ankit K wrote: On 5/5/2018 1:49 AM, Ville Syrjälä wrote: On Thu, May 03, 2018 at 08:26:26AM +0200, Daniel Vetter wrote: On Wed, May 02, 2018 at 12:20:20PM +0530, Nautiyal, Ankit K wrote: From

  1   2   3   4   >