RE: [Intel-gfx] [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-04-29 Thread Murthy, Arun R
> +static int output_bpc_show(struct seq_file *m, void *data) { Can we have a meaningful name instead of 'm' ? Upon changing this parameter name, you can have my Reviewed-By: Arun R Murthy Thanks and Regards, Arun R Murthy

RE: [Intel-gfx] [V2 3/3] drm/amd/display: Move connector debugfs to drm

2022-04-29 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of > Bhanuprakash Modem > Sent: Monday, April 11, 2022 3:21 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; amd- > g...@lists.freedesktop.org; jani.nik...@linux.intel.com; > ville.syrj...@linux.intel.com; harry.

RE: [Intel-gfx] [PATCH 1/2] drm/i915/hpd: postpone HPD cancel work after last user suspension

2022-06-28 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of > Andrzej Hajda > Sent: Thursday, June 23, 2022 10:08 PM > To: Jani Nikula ; Ville Syrjälä > > Cc: Hajda, Andrzej ; intel- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Vivi, Rodrigo > > Subject: [Intel-gfx] [PATCH 1

RE: [Intel-gfx] [PATCH 2/2] drm/i915/fbdev: suspend HPD before fbdev unregistration

2022-06-28 Thread Murthy, Arun R
> void intel_fbdev_unregister(struct drm_i915_private *dev_priv) { > struct intel_fbdev *ifbdev = dev_priv->fbdev; @@ -573,6 +594,8 @@ > void intel_fbdev_unregister(struct drm_i915_private *dev_priv) > if (!ifbdev) > return; > > + intel_fbdev_hpd_set_suspend(dev_pri

RE: [PATCH v2 2/2] drm/i915/fbdev: suspend HPD before fbdev unregistration

2022-06-30 Thread Murthy, Arun R
> HPD event after fbdev unregistration can cause registration of deferred fbdev > which will not be unregistered later, causing use-after-free. > To avoid it HPD handling should be suspended before fbdev unregistration. > > It should fix following GPF: > [272.634530] general protection fault, prob

RE: [Intel-gfx] [V2 1/3] drm/debug: Expose connector's max supported bpc via debugfs

2022-04-11 Thread Murthy, Arun R
> +static int output_bpc_show(struct seq_file *m, void *data) { Would it be better to have this function name as drm_output_bpc_show() Thanks and Regards, Arun R Murthy

RE: [Intel-gfx] [V2 2/3] drm/i915/display/debug: Expose crtc current bpc via debugfs

2022-04-11 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of > Bhanuprakash Modem > Sent: Monday, April 11, 2022 3:21 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; amd- > g...@lists.freedesktop.org; jani.nik...@linux.intel.com; > ville.syrj...@linux.intel.com; harry.wen

RE: [PATCH v3 2/3] drm/i915/fbdev: suspend HPD before fbdev unregistration

2022-07-13 Thread Murthy, Arun R
> -Original Message- > From: Hajda, Andrzej > Sent: Wednesday, July 13, 2022 8:50 PM > To: Jani Nikula ; Ville Syrjälä > ; Murthy, Arun R > Cc: Hajda, Andrzej ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; Daniel Vetter > ; intel-...@lists

RE: [PATCH v3 3/3] drm/i915/display: add hotplug.suspended flag

2022-07-13 Thread Murthy, Arun R
> -Original Message- > From: Hajda, Andrzej > Sent: Wednesday, July 13, 2022 8:50 PM > To: Jani Nikula ; Ville Syrjälä > ; Murthy, Arun R > Cc: Hajda, Andrzej ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; Daniel Vetter > ; intel-...@lists

RE: [PATCH v6 4/4] drm/i915/fbdev: do not create fbdev if HPD is suspended

2022-07-25 Thread Murthy, Arun R
> -Original Message- > From: Hajda, Andrzej > Sent: Friday, July 22, 2022 6:22 PM > To: Jani Nikula ; Ville Syrjälä > ; Murthy, Arun R > Cc: Hajda, Andrzej ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; Daniel Vetter > ; intel-...@lists

RE: [PATCH 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer

2023-01-18 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Friday, January 13, 2023 1:49 PM > To: Murthy, Arun R ; intel- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: Re: [PATCH 2/2] i915/display/dp: SDP CRC16 for 128b132b l

RE: [PATCHv2 2/2] i915/display/dp: SDP CRC16 for 128b132b link layer

2023-01-24 Thread Murthy, Arun R
Any comments? Thanks and Regards, Arun R Murthy > -Original Message- > From: Murthy, Arun R > Sent: Thursday, January 19, 2023 5:17 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Nikula, > Jani > Cc: Murthy, Arun R >

RE: [Intel-gfx] [PATCH] drm/i915/xelpg: Fix write to MTL_MCR_SELECTOR

2022-10-20 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Matt > Roper > Sent: Thursday, October 20, 2022 3:55 AM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH] drm/i915/xelpg: Fix write to MTL_MCR_SELECTOR > > A misplaced closing pare

RE: [Intel-gfx] [PATCH 02/19] drm/i915/dp: Move compressed bpp check with 420 format inside the helper

2023-07-13 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Ankit > Nautiyal > Sent: Thursday, July 13, 2023 4:03 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 02/19] drm/i915/dp: Move compressed bpp check > with 420 format inside the hel

RE: [Intel-gfx] [PATCH 08/19] drm/i915/dp: Remove extra logs for printing DSC info

2023-07-13 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Ankit > Nautiyal > Sent: Thursday, July 13, 2023 4:04 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Subject: [Intel-gfx] [PATCH 08/19] drm/i915/dp: Remove extra logs for > printing DSC info > > DSC compresse

RE: [1/5] drm: Introduce sharpness mode property

2024-08-29 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Nemesa > Garg > Sent: Monday, July 8, 2024 1:39 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Garg, Nemesa > Subject: [1/5] drm: Introduce sharpness mode property > > Introduces the new crtc property "S

RE: [v4 2/5] drm/i915/display: Compute the scaler filter coefficients

2024-08-29 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Nemesa > Garg > Sent: Monday, July 8, 2024 1:39 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Garg, Nemesa > Subject: [v4 2/5] drm/i915/display: Compute the scaler filter coefficients > > The sharpness

RE: [3/5] drm/i915/display: Enable the second scaler for sharpness

2024-08-29 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Nemesa > Garg > Sent: Monday, July 8, 2024 1:39 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Garg, Nemesa > Subject: [3/5] drm/i915/display: Enable the second scaler for sharpness > > As only second sc

RE: [4/5] drm/i915/display: Add registers and compute the strength

2024-08-30 Thread Murthy, Arun R
> -Original Message- > From: Intel-gfx On Behalf Of Nemesa > Garg > Sent: Monday, July 8, 2024 1:39 PM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Garg, Nemesa > Subject: [4/5] drm/i915/display: Add registers and compute the strength > > Add new registers

RE: [PATCHv2 3/5] Add crtc properties for global histogram

2024-09-03 Thread Murthy, Arun R
> > > +static int > > > +intel_atomic_replace_property_blob_from_id(struct drm_device *dev, > > > +struct drm_property_blob **blob, > > > +u64 blob_id, > > > +ssize_t expected_size, > > > +

RE: [PATCH v7 3/6] drm/i915/panelreplay: Initializaton and compute config for panel replay

2023-10-15 Thread Murthy, Arun R
> -Original Message- > From: Manna, Animesh > Sent: Wednesday, October 11, 2023 4:40 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Manna, Animesh > ; Hogander, Jouni ; > Murthy, Arun R ; Nikula, Jani > > Subject: [PATCH v

RE: [PATCH v7 4/6] drm/i915/panelreplay: Enable panel replay dpcd initialization for DP

2023-10-15 Thread Murthy, Arun R
> -Original Message- > From: Manna, Animesh > Sent: Wednesday, October 11, 2023 4:40 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Manna, Animesh > ; Hogander, Jouni ; > Murthy, Arun R ; Nikula, Jani > > Subject: [PATCH v

RE: [PATCH v7 5/6] drm/i915/panelreplay: enable/disable panel replay

2023-10-15 Thread Murthy, Arun R
> -Original Message- > From: Manna, Animesh > Sent: Wednesday, October 11, 2023 4:40 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Manna, Animesh > ; Hogander, Jouni ; > Murthy, Arun R ; Nikula, Jani > > Subject: [PATCH v

RE: [PATCH v7 6/6] drm/i915/panelreplay: Debugfs support for panel replay

2023-10-15 Thread Murthy, Arun R
> -Original Message- > From: Manna, Animesh > Sent: Wednesday, October 11, 2023 4:40 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Manna, Animesh > ; Hogander, Jouni ; > Murthy, Arun R ; Nikula, Jani > > Subject: [PATCH v

RE: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperability

2024-07-28 Thread Murthy, Arun R
Gentle Reminder! Any comments? Thanks and Regards, Arun R Murthy > -Original Message- > From: Murthy, Arun R > Sent: Tuesday, July 9, 2024 1:17 PM > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org > Cc: Murthy, Arun R > Su

RE: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperability

2024-07-29 Thread Murthy, Arun R
> -Original Message- > From: Dmitry Baryshkov > Sent: Tuesday, July 30, 2024 4:21 AM > To: Murthy, Arun R > Cc: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org > Subject: Re: [PATCH] RFC: drm/drm_plane: Expose the plane capability and > interoperabi

RE: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperability

2024-07-31 Thread Murthy, Arun R
> -Original Message- > From: Dmitry Baryshkov > Sent: Wednesday, July 31, 2024 2:04 PM > To: Murthy, Arun R > Cc: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org > Subject: Re: [PATCH] RFC: drm/drm_plane: Expose the plane capability and > interoperab

RE: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperability

2024-08-01 Thread Murthy, Arun R
> -Original Message- > From: Dmitry Baryshkov > Sent: Wednesday, July 31, 2024 2:51 PM > To: Murthy, Arun R > Cc: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org > Subject: Re: [PATCH] RFC: drm/drm_plane: Expose the plane capability and > interop

RE: [PATCH v6 1/6] drm/panelreplay: dpcd register definition for panelreplay

2023-10-04 Thread Murthy, Arun R
> -Original Message- > From: Manna, Animesh > Sent: Thursday, September 21, 2023 11:44 AM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Nikula, Jani ; > Hogander, Jouni ; Murthy, Arun R > ; Manna, Animesh > Subject: [PATCH v6 1/

RE: [PATCH v6 2/6] drm/i915/psr: Move psr specific dpcd init into own function

2023-10-04 Thread Murthy, Arun R
> -Original Message- > From: Manna, Animesh > Sent: Thursday, September 21, 2023 11:44 AM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Nikula, Jani ; > Hogander, Jouni ; Murthy, Arun R > > Subject: [PATCH v6 2/6] drm/i915/psr: Mov

RE: [PATCH v6 5/6] drm/i915/panelreplay: enable/disable panel replay

2023-10-04 Thread Murthy, Arun R
> -Original Message- > From: Manna, Animesh > Sent: Thursday, September 21, 2023 11:44 AM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Nikula, Jani ; > Hogander, Jouni ; Murthy, Arun R > ; Manna, Animesh > Subject: [PATCH v6 5

RE: [PATCH v6 6/6] drm/i915/panelreplay: Debugfs support for panel replay

2023-10-04 Thread Murthy, Arun R
> -Original Message- > From: Manna, Animesh > Sent: Thursday, September 21, 2023 11:44 AM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Nikula, Jani ; > Hogander, Jouni ; Murthy, Arun R > ; Manna, Animesh > Subject: [PATCH v6 6

RE: [PATCH v6 3/6] drm/i915/panelreplay: Initializaton and compute config for panel replay

2023-10-04 Thread Murthy, Arun R
> -Original Message- > From: Manna, Animesh > Sent: Thursday, September 21, 2023 11:44 AM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Nikula, Jani ; > Hogander, Jouni ; Murthy, Arun R > ; Manna, Animesh > Subject: [PATCH v6 3

RE: [PATCH v7 4/6] drm/i915/panelreplay: Enable panel replay dpcd initialization for DP

2023-10-30 Thread Murthy, Arun R
> -Original Message- > From: Manna, Animesh > Sent: Tuesday, October 17, 2023 1:52 PM > To: Murthy, Arun R ; intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Hogander, Jouni > ; Nikula, Jani > Subject: RE: [PATCH v7 4/6] drm/i915/panelreplay

RE: [PATCH v7 6/6] drm/i915/panelreplay: Debugfs support for panel replay

2023-10-30 Thread Murthy, Arun R
> -Original Message- > From: Manna, Animesh > Sent: Wednesday, October 11, 2023 4:40 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Manna, Animesh > ; Hogander, Jouni ; > Murthy, Arun R ; Nikula, Jani > > Subject: [PATCH v

RE: [PATCH v2 1/6] drm/mst: read sideband messaging cap

2024-02-13 Thread Murthy, Arun R
> -Original Message- > From: Nikula, Jani > Sent: Tuesday, February 13, 2024 5:01 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; intel...@lists.freedesktop.org; Nikula, > Jani > ; Murthy, Arun R ; Ville > Syrjälä > Subject: [

RE: [v4 2/5] drm/i915/display: Compute the scaler filter coefficients

2024-09-10 Thread Murthy, Arun R
> > > The sharpness property requires the use of one of the scaler so need > > > to set the sharpness scaler coefficient values. > > > These values are based on experiments and vary for different tap > > > value/win size. These values are normalized by taking the sum of all > > > values and then di

RE: [PATCH] drm/i915/display: plane property for async supported modifiers

2024-10-16 Thread Murthy, Arun R
> -Original Message- > From: Ville Syrjälä > Sent: Wednesday, October 16, 2024 7:31 PM > To: Murthy, Arun R > Cc: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Subject: Re: [PATCH] drm/i915/display: pla

RE: [PATCH 1/7] drm/i915/histogram: Define registers for histogram

2024-10-22 Thread Murthy, Arun R
> -Original Message- > From: Jani Nikula > Sent: Thursday, September 26, 2024 3:44 PM > To: Murthy, Arun R ; intel...@lists.freedesktop.org; > intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: Re: [PATCH 1/7] drm/i

RE: [PATCH] drm/i915/display: plane property for async supported modifiers

2024-10-24 Thread Murthy, Arun R
> > Subject: Re: [PATCH] drm/i915/display: plane property for async > > supported modifiers > > > > On Wed, Oct 16, 2024 at 04:54:09PM +0300, Ville Syrjälä wrote: > > > On Wed, Oct 16, 2024 at 04:30:19PM +0300, Ville Syrjälä wrote: > > > > On Wed, Oct 16, 2024 at 11:06:26AM +0530, Arun R Murthy wro

RE: [PATCHv3 1/6] drm/i915/histogram: Add support for histogram

2024-09-24 Thread Murthy, Arun R
> > +struct intel_histogram { > > + struct intel_crtc *crtc; > > + struct delayed_work histogram_int_work; > > I think I mentioned this in my previous comment but naming this just work > should be fine since I don’t see any other work for histogram So itll be > called as > histogram->work whi

RE: [PATCHv3 6/6] drm/i915/histogram: Histogram changes for Display 20+

2024-09-25 Thread Murthy, Arun R
> > .../gpu/drm/i915/display/intel_histogram.c| 111 +- > > .../drm/i915/display/intel_histogram_reg.h| 25 > > 2 files changed, 105 insertions(+), 31 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_histogram.c > > b/drivers/gpu/drm/i915/display/i

RE: [PATCHv3 1/6] drm/i915/histogram: Add support for histogram

2024-09-25 Thread Murthy, Arun R
> > > +static int intel_histogram_enable(struct intel_crtc *intel_crtc) { > > > + struct intel_display *display = to_intel_display(intel_crtc); > > > + struct intel_histogram *histogram = intel_crtc->histogram; > > > + int pipe = intel_crtc->pipe; > > > + u64 res; > > > + u32 gbandthreshold; > > >

RE: [PATCHv3 6/6] drm/i915/histogram: Histogram changes for Display 20+

2024-09-25 Thread Murthy, Arun R
> >> > +static __inline__ void set_bin_index_0(struct intel_display > >> > +*display, enum pipe pipe) > >> ^^ > >> > >> Why? > >> > > Sorry, didn't get your question. Is it why "enum pipe pipe" > > No, why __inline__? What's the point? > > (I tried to underline it with ^

RE: [PATCH 1/4] drm/plane: Add new plane property IN_FORMATS_ASYNC

2024-11-06 Thread Murthy, Arun R
> -Original Message- > From: Ville Syrjälä > Sent: Wednesday, November 6, 2024 7:31 PM > To: Murthy, Arun R > Cc: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Subject: Re: [PATCH 1/4] drm/plane: A

RE: [PATCHv2 2/3] drm/plane: Expose function to create format/modifier blob

2024-11-25 Thread Murthy, Arun R
> On Mon, Nov 18, 2024 at 01:23:14PM +0530, Arun R Murthy wrote: > > Expose drm plane function to create formats/modifiers blob. This > > function can be used to expose list of supported formats/modifiers for > > sync/async flips. > > > > Signed-off-by: Arun R Murthy > > --- > > drivers/gpu/drm/d

RE: [PATCHv4 7/8] drm/i915/histogram: Histogram changes for Display 20+

2024-11-21 Thread Murthy, Arun R
> -Original Message- > From: Kandpal, Suraj > Sent: Wednesday, November 20, 2024 3:55 PM > To: Murthy, Arun R ; intel...@lists.freedesktop.org; > intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: RE: [PATCHv4 7/

RE: [PATCH 8/8] drm/i915/histogram: Enable pipe dithering

2024-11-21 Thread Murthy, Arun R
> > -Original Message- > > From: Intel-gfx On Behalf Of > > Arun R Murthy > > Sent: Tuesday, November 19, 2024 4:15 PM > > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; > > dri- de...@lists.freedesktop.org > > Cc: Murthy,

RE: [PATCHv6 5/8] drm/i915/histogram: Add crtc properties for global histogram

2024-11-22 Thread Murthy, Arun R
> > > On Thu, Nov 21, 2024 at 05:56:00PM +0530, Arun R Murthy wrote: > > > > CRTC properties have been added for enable/disable histogram, > > > > reading the histogram data and writing the IET data. > > > > "HISTOGRAM_EN" is the crtc property to enable/disable the global > > > > histogram and take

RE: [PATCHv6 7/8] drm/i915/histogram: Histogram changes for Display 20+

2024-11-22 Thread Murthy, Arun R
> > > > +static void write_iet(struct intel_display *display, enum pipe pipe, > > > > + u32 *data) > > > > +{ > > > > + int i; > > > > + > > > > + for (i = 0; i < HISTOGRAM_IET_LENGTH; i++) { > > > > + if (DISPLAY_VER(display) >= 20) > > > > +

RE: [PATCHv5 0/8] Display Global Histogram

2024-11-19 Thread Murthy, Arun R
> On Tue, 19 Nov 2024 at 10:55, Arun R Murthy > wrote: > > The corresponding mutter changes to enable/disable histogram, read the > > histogram data, communicate with the library and write the enhanced > > data back to the KMD is also pushed for review at > > https://gitlab.gnome.org/GNOME/mutter/

RE: [PATCHv4 4/7] drm/i915/histogram: histogram interrupt handling

2024-11-18 Thread Murthy, Arun R
> > Upon enabling histogram an interrupt is trigerred after the generation > > of the statistics. This patch registers the histogram interrupt and > > handles the interrupt. > > > > v2: Added intel_crtc backpointer to intel_histogram struct (Jani) > > Removed histogram_wq and instead use dev_pr

RE: [PATCHv4 2/8] drm/i915/histogram: Add support for histogram

2024-11-21 Thread Murthy, Arun R
> > Statistics is generated from the image frame that is coming to display > > and an event is sent to user after reading this histogram data. > > This statistics/histogram is then shared with the user upon getting a > > request from user. User can then use this histogram and generate an > > enhanc

RE: [PATCHv4 4/8] drm/i915/histogram: histogram interrupt handling

2024-11-20 Thread Murthy, Arun R
> On Tue, 19 Nov 2024, Arun R Murthy wrote: > > Upon enabling histogram an interrupt is trigerred after the generation > > of the statistics. This patch registers the histogram interrupt and > > handles the interrupt. > > > > v2: Added intel_crtc backpointer to intel_histogram struct (Jani) > >

RE: [PATCHv6 5/8] drm/i915/histogram: Add crtc properties for global histogram

2024-11-25 Thread Murthy, Arun R
> > > > On Thu, Nov 21, 2024 at 05:56:00PM +0530, Arun R Murthy wrote: > > > > > CRTC properties have been added for enable/disable histogram, > > > > > reading the histogram data and writing the IET data. > > > > > "HISTOGRAM_EN" is the crtc property to enable/disable the global > > > > > histogra

RE: [PATCHv2 01/10] drm/crtc: Add histogram properties

2024-12-05 Thread Murthy, Arun R
> > > -Original Message- > > > From: Dmitry Baryshkov > > > Sent: Wednesday, December 4, 2024 5:17 PM > > > To: Murthy, Arun R > > > Cc: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; > > > dri- de...@lists.freed

RE: [PATCHv2 01/10] drm/crtc: Add histogram properties

2024-12-04 Thread Murthy, Arun R
> -Original Message- > From: Dmitry Baryshkov > Sent: Wednesday, December 4, 2024 5:17 PM > To: Murthy, Arun R > Cc: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Subject: Re: [PATCHv2 01/10] drm/crtc: Add

RE: [PATCHv2 01/10] drm/crtc: Add histogram properties

2024-12-06 Thread Murthy, Arun R
> On Thu, Dec 05, 2024 at 04:29:55PM +0000, Murthy, Arun R wrote: > > > > > -Original Message- > > > > > From: Dmitry Baryshkov > > > > > Sent: Wednesday, December 4, 2024 5:17 PM > > > > > To: Murthy, Arun R

RE: [PATCHv3 01/10] drm/crtc: Add histogram properties

2025-01-05 Thread Murthy, Arun R
> On Tue, Dec 10, 2024 at 05:52:38PM +0000, Murthy, Arun R wrote: > > > On Tue, Dec 10, 2024 at 08:42:36AM +0000, Murthy, Arun R wrote: > > > > > On Mon, Dec 09, 2024 at 09:54:55PM +0530, Arun R Murthy wrote: > > > > > > Add variables

RE: [PATCH 1/7] drm/dp: Add eDP 1.5 bit definition

2025-02-04 Thread Murthy, Arun R
> -Original Message- > From: Kandpal, Suraj > Sent: Friday, January 24, 2025 11:16 AM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Shankar, Uma ; Murthy, Arun R > ; Kao, Ben ; Kandpal, Suraj > &g

RE: [PATCH 4/7] drm/i915/backlight: Modify function to get VESA brightness in Nits

2025-02-05 Thread Murthy, Arun R
> Modify vesa_get_brightness function to take into account > luminance_control_support and based on that read the appropriate register > and return the value. > > --v2 > -Changes since we now use luminance instead of nits > > Signed-off-by: Suraj Kandpal > Tested-by: Ben Kao > --- > .../drm/i9

RE: [PATCH 3/8] drm/i915/backlight: Use proper interface based on eDP version

2025-02-05 Thread Murthy, Arun R
> eDP is supposed to use VESA interface when using revision 1.5 and above, use > Intel interface for backlight control otherwise. Add check to use correct > interface. > > Signed-off-by: Suraj Kandpal > Tested-by: Ben Kao > --- Reviewed-by: Arun R Murthy Thanks and Regards, Arun R Murthy -

RE: [PATCH 4/8] drm/i915/backlight: Check Luminance based brightness control for VESA

2025-02-05 Thread Murthy, Arun R
> Check if we are capable of controlling brightness via luminance which is > dependent on PANEL_LUMINANCE_CONTROL_CAPABLE bit being set on > EDP_GENERAL_CAPABILITY_2 register. > > --v2 > -Prefer using luminance rather than nits [Jani] -Fix commit message > > --v3 > -Fix the bit name used in commi

RE: [PATCH 2/8] drm/dp: Increase eDP display control capability size

2025-02-05 Thread Murthy, Arun R
> Increase the eDP display control capability size to take into account the > general > capability register 703 and 704 that have recently been added. > > Signed-off-by: Suraj Kandpal > --- Reviewed-by: Arun R Murthy Thanks and Regards, Arun R Murthy > include/drm/display

RE: [PATCH 2/7] drm/i915/backlight: Use proper interface based on eDP version

2025-02-05 Thread Murthy, Arun R
> eDP is supposed to use VESA interface when using revision 1.5 and above, use > Intel interface for backlight control otherwise. Add check to use correct > interface. > > Signed-off-by: Suraj Kandpal > Tested-by: Ben Kao > --- Reviewed-by: Arun R Murthy Thanks and Regards, Arun R Murthy -

RE: [PATCH 3/7] drm/i915/backlight: Check Luminance based brightness control for VESA

2025-02-05 Thread Murthy, Arun R
> Check if we are capable of controlling brightness via luminance which is > dependent on PANEL_LUMINANCE_OVERRIDE being set. > Is PANEL_LUMINANCE_OVERRIDE a macro? I don't see this definition! > --v2 > -Prefer using luminance rather than nits [Jani] -Fix commit message > > Signed-off-by: Suraj

RE: [PATCH 5/7] drm/i915/backlight: Add function to change brightness in nits for VESA

2025-02-05 Thread Murthy, Arun R
> Create a function that fills in the value for PANEL_TARGET_LUMINANCE_VALUE > which helps in changing the luminance in nits using VESA interface. > > --v2 > -Prefer using luminance over nits [Jani] > > Signed-off-by: Suraj Kandpal > Tested-by: Ben Kao > --- Reviewed-by: Arun R Murthy Thanks

RE: [PATCH 5/7] drm/i915/backlight: Add function to change brightness in nits for VESA

2025-02-05 Thread Murthy, Arun R
> > Create a function that fills in the value for > > PANEL_TARGET_LUMINANCE_VALUE which helps in changing the luminance > in nits using VESA interface. > > > > --v2 > > -Prefer using luminance over nits [Jani] > > > > Signed-off-by: Suraj Kandpal > > Tested-by: Ben Kao > > --- > Reviewed-by: Aru

RE: [PATCH 7/7] drm/i915/backlight: Enable nits based luminance

2025-02-05 Thread Murthy, Arun R
> Enable nits based luminance by writing the PANEL_LUMINANCE_CONTROL bit > and set the correct register to change brightness. > > Signed-off-by: Suraj Kandpal > Tested-by: Ben Kao > --- Reviewed-by; Arun R Murthy Thanks and Regards, Arun R Murthy --- > .../gpu/drm/i915/display

RE: [PATCH 6/7] drm/i915/backlight: Setup nits based luminance via VESA

2025-02-05 Thread Murthy, Arun R
> Modify backlight setup function for VESA interface to take into account the > nits > based luminance. > > --v2 > -Prefer using luminance over nits [Jani] > > Signed-off-by: Suraj Kandpal > Tested-by: Ben Kao > --- Reviewed-by: Arun R Murthy Thanks and Regards, Arun R Murthy ---

Re: [PATCH v4 3/3] drm/i915/display: Add i915 hook for format_mod_supported_async

2025-02-12 Thread Murthy, Arun R
On 12-02-2025 13:02, Borah, Chaitanya Kumar wrote: -Original Message- From: Murthy, Arun R Sent: Wednesday, February 5, 2025 3:57 PM To:dri-devel@lists.freedesktop.org;intel-...@lists.freedesktop.org; intel- x...@lists.freedesktop.org Cc: Borah, Chaitanya Kumar; Syrjala, Ville; Murthy

RE: [PATCHv3 01/10] drm/crtc: Add histogram properties

2024-12-10 Thread Murthy, Arun R
> On Tue, Dec 10, 2024 at 08:42:36AM +0000, Murthy, Arun R wrote: > > > On Mon, Dec 09, 2024 at 09:54:55PM +0530, Arun R Murthy wrote: > > > > Add variables for histogram drm_property, its corrsponding > > > > crtc_state variables and define the structure p

RE: [PATCHv3 01/10] drm/crtc: Add histogram properties

2024-12-10 Thread Murthy, Arun R
> On Mon, Dec 09, 2024 at 09:54:55PM +0530, Arun R Murthy wrote: > > Add variables for histogram drm_property, its corrsponding crtc_state > > variables and define the structure pointed by the blob property. > > > > struct drm_histogram and drm_iet defined in > > include/uapi/drm/drm_mode.h > > > >

RE: [PATCHv10 00/10] Display Global Histogram

2024-12-10 Thread Murthy, Arun R
> On Mon, Dec 09, 2024 at 09:54:54PM +0530, Arun R Murthy wrote: > > Display histogram is a hardware functionality where a statistics for 'x' > > number of frames is generated to form a histogram data. This is > > notified to the user via histogram event. Compositor will then upon > > sensing the h

RE: [PATCHv2 2/3] drm/plane: Expose function to create format/modifier blob

2024-12-13 Thread Murthy, Arun R
> > On Mon, Nov 18, 2024 at 01:23:14PM +0530, Arun R Murthy wrote: > > > Expose drm plane function to create formats/modifiers blob. This > > > function can be used to expose list of supported formats/modifiers > > > for sync/async flips. > > > > > > Signed-off-by: Arun R Murthy > > > --- > > > d

RE: [PATCH 6/8] drm/i915/histogram: histogram delay counter doesnt reset

2024-11-21 Thread Murthy, Arun R
> > -Original Message- > > From: Intel-xe On Behalf Of > > Arun R Murthy > > Sent: Tuesday, November 19, 2024 4:15 PM > > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; > > dri- de...@lists.freedesktop.org > > Cc: Murthy,

RE: [PATCHv5 5/8] drm/i915/histogram: Add crtc properties for global histogram

2024-11-21 Thread Murthy, Arun R
> > CRTC properties have been added for enable/disable histogram, reading > > the histogram data and writing the IET data. > > "HISTOGRAM_EN" is the crtc property to enable/disable the global > > histogram and takes a value 0/1 accordingly. > > "Histogram" is a crtc property to read the binary hist

RE: [PATCHv5 2/8] drm/i915/histogram: Add support for histogram

2024-11-21 Thread Murthy, Arun R
> > -Original Message- > > From: Intel-xe On Behalf Of > > Arun R Murthy > > Sent: Thursday, November 21, 2024 5:56 PM > > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; > > dri- de...@lists.freedesktop.org > > Cc: Murthy, A

RE: [PATCHv6 7/8] drm/i915/histogram: Histogram changes for Display 20+

2024-11-21 Thread Murthy, Arun R
> > -Original Message- > > From: dri-devel On Behalf Of > > Arun R Murthy > > Sent: Thursday, November 21, 2024 5:56 PM > > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; > > dri- de...@lists.freedesktop.org > > Cc: Murthy, A

RE: [PATCH 0/8] Display Global Histogram

2024-11-21 Thread Murthy, Arun R
Of Arun R > Murthy > Sent: Thursday, November 21, 2024 5:56 PM > To: intel...@lists.freedesktop.org; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org > Cc: Murthy, Arun R > Subject: [PATCHv5 2/8] drm/i915/histogram: Add support for histogram > > Statistic

RE: [PATCHv6 5/8] drm/i915/histogram: Add crtc properties for global histogram

2024-11-21 Thread Murthy, Arun R
> On Thu, Nov 21, 2024 at 05:56:00PM +0530, Arun R Murthy wrote: > > CRTC properties have been added for enable/disable histogram, reading > > the histogram data and writing the IET data. > > "HISTOGRAM_EN" is the crtc property to enable/disable the global > > histogram and takes a value 0/1 accord

RE: [PATCH v3 2/5] drm/plane: Expose function to create format/modifier blob

2025-01-22 Thread Murthy, Arun R
> On Wed, Jan 08, 2025 at 11:09:00AM +0530, Arun R Murthy wrote: > > Expose drm plane function to create formats/modifiers blob. This > > function can be used to expose list of supported formats/modifiers for > > sync/async flips. > > > > Signed-off-by: Arun R Murthy > > --- > > drivers/gpu/drm/d

RE: [PATCH v3 4/5] drm/i915/display: Populate list of async supported formats/modifiers

2025-01-20 Thread Murthy, Arun R
> On Wed, Jan 08, 2025 at 11:09:02AM +0530, Arun R Murthy wrote: > > Populate the list of formats/modifiers supported by async flip. > > Register a async property and expose the same to user through blob. > > > > Signed-off-by: Arun R Murthy > > --- > > drivers/gpu/drm/i915/display/skl_universal_

RE: [PATCH 1/3] drm/dp: Add the DPCD register required for Extended wake timeout

2025-01-20 Thread Murthy, Arun R
> Add DPCD registers required to configure Extended Wake Timeout for LTTPR. > > Signed-off-by: Suraj Kandpal > --- Reviewed-by: Arun R Murthy Thanks and Regards, Arun R Murthy > include/drm/display/drm_dp.h | 14 ++ > 1 file changed, 14 insertions(+) > > diff

RE: [PATCH v7 01/14] drm: Define histogram structures exposed to user

2025-01-20 Thread Murthy, Arun R
> > On Thu, Jan 16, 2025 at 01:33:43PM +, Murthy, Arun R wrote: > > > > On Thu, Jan 16, 2025 at 12:33:20PM +0000, Murthy, Arun R wrote: > > > > > > > > On Fri, Jan 10, 2025 at 01:15:29AM +0530, Arun R Murthy wrote: > > > > >

RE: [PATCH v3 2/5] drm/plane: Expose function to create format/modifier blob

2025-01-22 Thread Murthy, Arun R
> > On Wed, Jan 08, 2025 at 11:09:00AM +0530, Arun R Murthy wrote: > > > Expose drm plane function to create formats/modifiers blob. This > > > function can be used to expose list of supported formats/modifiers > > > for sync/async flips. > > > > > > Signed-off-by: Arun R Murthy > > > --- > > > d

RE: [PATCH v3 2/5] drm/plane: Expose function to create format/modifier blob

2025-01-24 Thread Murthy, Arun R
> On Thu, Jan 23, 2025 at 07:47:14AM +0000, Murthy, Arun R wrote: > > > > On Wed, Jan 08, 2025 at 11:09:00AM +0530, Arun R Murthy wrote: > > > > > Expose drm plane function to create formats/modifiers blob. This > > > > > function can be used to expose

RE: [PATCH 3/3] drm/i915/lttpr: Enable Extended Wake Timeout

2025-01-21 Thread Murthy, Arun R
> Usually retimers take around 30 to 40ms to exit all devices from sleep state. > Extended wake timeout mechanism helps to give that additional time. > > --v2 > -Grant the requested time only if greater than 1ms [Arun/Jani] -Reframe > commit message [Arun] > > --v3 > -Move the function to drm_cor

RE: [PATCH v3 2/5] drm/plane: Expose function to create format/modifier blob

2025-01-13 Thread Murthy, Arun R
> > -Original Message- > > From: Intel-gfx On Behalf Of > > Arun R Murthy > > Sent: Wednesday, January 8, 2025 11:09 AM > > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org; > > intel- x...@lists.freedesktop.org > > Cc: Murth

RE: [PATCH v3 1/5] drm/plane: Add new plane property IN_FORMATS_ASYNC

2025-01-13 Thread Murthy, Arun R
> > -Original Message- > > From: dri-devel On Behalf Of > > Arun R Murthy > > Sent: Wednesday, January 8, 2025 11:09 AM > > To: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org; > > intel- x...@lists.freedesktop.org > > Cc: Murth

RE: [PATCH v7 07/14] drm/xe: Add histogram support to Xe builds

2025-01-15 Thread Murthy, Arun R
> On Fri, Jan 10, 2025 at 01:15:35AM +0530, Arun R Murthy wrote: > > Histogram added as part of i915/display driver. Adding the same for xe > > as well. > > > > Signed-off-by: Arun R Murthy > > Reviewed-by: Suraj Kandpal > > Is building of the Xe driver broken between the previous commit and thi

RE: [PATCH v7 01/14] drm: Define histogram structures exposed to user

2025-01-15 Thread Murthy, Arun R
> On Fri, Jan 10, 2025 at 01:15:29AM +0530, Arun R Murthy wrote: > > Display Histogram is an array of bins and can be generated in many > > ways referred to as modes. > > Ex: HSV max(RGB), Wighted RGB etc. > > > > Understanding the histogram data format(Ex: HSV max(RGB)) Histogram is > > just the p

RE: [PATCH v7 02/14] drm: Define ImageEnhancemenT LUT structures exposed to user

2025-01-15 Thread Murthy, Arun R
> On Fri, Jan 10, 2025 at 01:15:30AM +0530, Arun R Murthy wrote: > > ImageEnhancemenT(IET) hardware interpolates the LUT value to generate > > the enhanced output image. LUT takes an input value, outputs a new > > value based on the data within the LUT. 1D LUT can remap individual > > input values

RE: [PATCH v3 1/5] drm/plane: Add new plane property IN_FORMATS_ASYNC

2025-01-16 Thread Murthy, Arun R
> > > > -Original Message- > > > > From: dri-devel On > > > > Behalf Of Arun R Murthy > > > > Sent: Wednesday, January 8, 2025 11:09 AM > > > > To: dri-devel@lists.freedesktop.org; > > > > intel-...@lists.freedesktop

RE: [PATCH v3 2/5] drm/plane: Expose function to create format/modifier blob

2025-01-16 Thread Murthy, Arun R
> > > > 68b31c0563a4c0 100644 > > > > --- a/drivers/gpu/drm/drm_plane.c > > > > +++ b/drivers/gpu/drm/drm_plane.c > > > > @@ -191,7 +191,10 @@ modifiers_ptr(struct drm_format_modifier_blob > > > > *blob) > > > > return (struct drm_format_modifier *)(((char *)blob) + blob- > > > > >modifiers

RE: [PATCH v7 02/14] drm: Define ImageEnhancemenT LUT structures exposed to user

2025-01-16 Thread Murthy, Arun R
> > > On Fri, Jan 10, 2025 at 01:15:30AM +0530, Arun R Murthy wrote: > > > > ImageEnhancemenT(IET) hardware interpolates the LUT value to > > > > generate the enhanced output image. LUT takes an input value, > > > > outputs a new value based on the data within the LUT. 1D LUT can > > > > remap indi

RE: [PATCH v7 01/14] drm: Define histogram structures exposed to user

2025-01-16 Thread Murthy, Arun R
> > > On Fri, Jan 10, 2025 at 01:15:29AM +0530, Arun R Murthy wrote: > > > > Display Histogram is an array of bins and can be generated in many > > > > ways referred to as modes. > > > > Ex: HSV max(RGB), Wighted RGB etc. > > > > > > > > Understanding the histogram data format(Ex: HSV max(RGB)) > >

RE: [PATCH v7 02/14] drm: Define ImageEnhancemenT LUT structures exposed to user

2025-01-16 Thread Murthy, Arun R
> On Thu, Jan 16, 2025 at 12:33:30PM +0000, Murthy, Arun R wrote: > > > > > On Fri, Jan 10, 2025 at 01:15:30AM +0530, Arun R Murthy wrote: > > > > > > ImageEnhancemenT(IET) hardware interpolates the LUT value to > > > > > > genera

RE: [PATCH v7 01/14] drm: Define histogram structures exposed to user

2025-01-16 Thread Murthy, Arun R
> On Thu, Jan 16, 2025 at 12:33:20PM +0000, Murthy, Arun R wrote: > > > > > On Fri, Jan 10, 2025 at 01:15:29AM +0530, Arun R Murthy wrote: > > > > > > Display Histogram is an array of bins and can be generated in > > > > > > many ways referred

RE: [PATCH v7 01/14] drm: Define histogram structures exposed to user

2025-01-16 Thread Murthy, Arun R
> On Thu, Jan 16, 2025 at 01:33:43PM +0000, Murthy, Arun R wrote: > > > On Thu, Jan 16, 2025 at 12:33:20PM +0000, Murthy, Arun R wrote: > > > > > > > On Fri, Jan 10, 2025 at 01:15:29AM +0530, Arun R Murthy wrote: > > > > > > > > D

  1   2   >