[PATCH 0/8] Add DSC fractional bpp support

2023-09-12 Thread Mitul Golani
This patch series adds support for DSC fractional compressed bpp for MTL+. The series starts with some fixes, followed by patches that lay groundwork to iterate over valid compressed bpps to select the 'best' compressed bpp with optimal link configuration (taken from upstream series: https://patchw

[PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp prescision

2023-09-12 Thread Mitul Golani
From: Ankit Nautiyal Add helper to get the DSC bits_per_pixel precision for the DP sink. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/display/drm_dp_helper.c | 27 + include/drm/display/drm_dp_helper.h | 1 + 2 files changed, 28 insertions(+) diff --git a/dri

[PATCH 3/8] drm/i915/display: Consider fractional vdsc bpp while computing m_n values

2023-09-12 Thread Mitul Golani
From: Ankit Nautiyal MTL+ supports fractional compressed bits_per_pixel, with precision of 1/16. This compressed bpp is stored in U6.4 format. Accommodate this precision while computing m_n values. Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel

[PATCH 4/8] drm/i915/audio : Consider fractional vdsc bpp while computing tu_data

2023-09-12 Thread Mitul Golani
From: Ankit Nautiyal MTL+ supports fractional compressed bits_per_pixel, with precision of 1/16. This compressed bpp is stored in U6.4 format. Accommodate the precision during calculation of transfer unit data for hblank_early calculation. v2: -Fixed tu_data calculation while dealing with U6.4 f

[PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 format

2023-09-12 Thread Mitul Golani
file for 6.4 fixed point helper(Jani, Nikula) -Add comment for magic values(Suraj) Signed-off-by: Ankit Nautiyal Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/icl_dsi.c| 11 +++--- drivers/gpu/drm/i915/display/intel_audio.c| 3 +- drivers

[PATCH 6/8] drm/i915/dp: Iterate over output bpp with fractional step size

2023-09-12 Thread Mitul Golani
From: Ankit Nautiyal This patch adds support to iterate over compressed output bpp as per the fractional step, supported by DP sink. v2: -Avoid ending up with compressed bpp, same as pipe bpp. (Stan) Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/in

[PATCH 8/8] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs

2023-09-12 Thread Mitul Golani
From: Swati Sharma If force_dsc_fractional_bpp_en is set through debugfs allow DSC iff compressed bpp is fractional. Continue if the computed compressed bpp turns out to be a integer. v2: -Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) -Fix comment (Suraj) Signed-off-by: S

[PATCH 5/8] drm/i915/dsc/mtl: Add support for fractional bpp

2023-09-12 Thread Mitul Golani
From: Vandita Kulkarni Consider the fractional bpp while reading the qp values. v2: Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) Signed-off-by: Vandita Kulkarni Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal --- .../gpu/drm/i915/display/intel_qp_tables.c

[PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-12 Thread Mitul Golani
ue if output_bpp is computed as integer. With this approach, we will be able to validate DSC with fractional bpp. v2: Add drm_modeset_unlock to new line(Suraj) Signed-off-by: Swati Sharma Signed-off-by: Ankit Nautiyal Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal --- .../drm/i915/di

[PATCH 0/8] Add DSC fractional bpp support

2023-09-12 Thread Mitul Golani
his patch series adds support for DSC fractional compressed bpp for MTL+. The series starts with some fixes, followed by patches that lay groundwork to iterate over valid compressed bpps to select the 'best' compressed bpp with optimal link configuration (taken from upstream series: https://patchwo

[PATCH 3/8] drm/i915/display: Consider fractional vdsc bpp while computing m_n values

2023-09-12 Thread Mitul Golani
From: Ankit Nautiyal MTL+ supports fractional compressed bits_per_pixel, with precision of 1/16. This compressed bpp is stored in U6.4 format. Accommodate this precision while computing m_n values. Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel

[PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp prescision

2023-09-12 Thread Mitul Golani
From: Ankit Nautiyal Add helper to get the DSC bits_per_pixel precision for the DP sink. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/display/drm_dp_helper.c | 27 + include/drm/display/drm_dp_helper.h | 1 + 2 files changed, 28 insertions(+) diff --git a/dri

[PATCH 6/8] drm/i915/dp: Iterate over output bpp with fractional step size

2023-09-12 Thread Mitul Golani
From: Ankit Nautiyal This patch adds support to iterate over compressed output bpp as per the fractional step, supported by DP sink. v2: -Avoid ending up with compressed bpp, same as pipe bpp. (Stan) Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/in

[PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 format

2023-09-12 Thread Mitul Golani
file for 6.4 fixed point helper(Jani, Nikula) -Add comment for magic values(Suraj) v4: -Fix checkpatch caused due to renaming(Suraj) Signed-off-by: Ankit Nautiyal Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/icl_dsi.c| 11 +++--- drivers/gpu

[PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-12 Thread Mitul Golani
ue if output_bpp is computed as integer. With this approach, we will be able to validate DSC with fractional bpp. v2: Add drm_modeset_unlock to new line(Suraj) Signed-off-by: Swati Sharma Signed-off-by: Ankit Nautiyal Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal --- .../drm/i915/di

[PATCH 5/8] drm/i915/dsc/mtl: Add support for fractional bpp

2023-09-12 Thread Mitul Golani
From: Vandita Kulkarni Consider the fractional bpp while reading the qp values. v2: Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) Signed-off-by: Vandita Kulkarni Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal --- .../gpu/drm/i915/display/intel_qp_tables.c

[PATCH 8/8] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs

2023-09-12 Thread Mitul Golani
From: Swati Sharma If force_dsc_fractional_bpp_en is set through debugfs allow DSC iff compressed bpp is fractional. Continue if the computed compressed bpp turns out to be a integer. v2: -Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) -Fix comment (Suraj) Signed-off-by: S

[PATCH 4/8] drm/i915/audio : Consider fractional vdsc bpp while computing tu_data

2023-09-12 Thread Mitul Golani
From: Ankit Nautiyal MTL+ supports fractional compressed bits_per_pixel, with precision of 1/16. This compressed bpp is stored in U6.4 format. Accommodate the precision during calculation of transfer unit data for hblank_early calculation. v2: -Fixed tu_data calculation while dealing with U6.4 f

[PATCH v16 0/9] Enable Adaptive Sync SDP Support for DP

2024-03-06 Thread Mitul Golani
longer required. - Use VRR_SYNC_START/END macros correctly. - Update commit message for Patch#9 Signed-off-by: Mitul Golani Mitul Golani (9): drm/dp: Add support to indicate if sink supports AS SDP drm: Add Adaptive Sync SDP logging drm/i915/display: Add crtc state dump for Adaptive Sync SDP drm/i

[PATCH v16 1/9] drm/dp: Add support to indicate if sink supports AS SDP

2024-03-06 Thread Mitul Golani
Add an API that indicates support for Adaptive Sync SDP in the sink, which can be utilized by the rest of the DP programming. --v1: - Format commit message properly. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/display/drm_dp_helper.c | 25

[PATCH v16 2/9] drm: Add Adaptive Sync SDP logging

2024-03-06 Thread Mitul Golani
anges to commit message. --v6: - Add correct place holder and name change for AS_SDP_OP_MODE. - Separate i915 changes from drm changes. - Remove extra lines. --v7: - Add drm/i915/display in subject line. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/display/drm_dp_hel

[PATCH v16 3/9] drm/i915/display: Add crtc state dump for Adaptive Sync SDP

2024-03-06 Thread Mitul Golani
Add crtc state dump for Adaptive Sync SDP to know which crtc specifically caused the failure. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- .../gpu/drm/i915/display/intel_crtc_state_dump.c| 13 + drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 2 files

[PATCH v16 5/9] drm/i915/dp: Add wrapper function to check AS SDP

2024-03-06 Thread Mitul Golani
Add a wrapper function to check if both the source and sink support Adaptive Sync SDP. --v1: Just use drm/i915/dp in subject line. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 8 drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2

[PATCH v16 4/9] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-03-06 Thread Mitul Golani
sdp->target_rr & 0xFF. - Shift by 8 instead of 32, and drop casting to u64. - Remove changes which are does not belong to this patch. Signed-off-by: Mitul Golani --- .../drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 92 +++ drive

[PATCH v16 7/9] drm/i915/display: Add state checker for Adaptive Sync SDP

2024-03-06 Thread Mitul Golani
Enable infoframe and add state checker for Adaptive Sync SDP enablement. --v1: - crtc_state->infoframes.enable, to add on correct place holder. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display.c | 46 1 file chan

[PATCH v16 9/9] drm/i915/display: Read/Write Adaptive Sync SDP

2024-03-06 Thread Mitul Golani
Add read/write calls for Adaptive Sync SDP. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display

[PATCH v16 8/9] drm/i915/display: Compute vrr_vsync params

2024-03-06 Thread Mitul Golani
(vrr.vsync_start/end). - Read/write vrr_vsync params only when we intend to send adaptive_sync sdp. --v4: - Use VRR_SYNC_START/END macros correctly. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 2 ++ .../drm/i915/display/intel_display_types.h| 1 + drivers

[PATCH v16 6/9] drm/i915/display: Compute AS SDP parameters

2024-03-06 Thread Mitul Golani
conn_state from intel_dp_compute_as_sdp, as not used. - Remove fullstop in subject line. --v9: - Add vrr.enable instead of is_in_vrr_range. --v10: - remove vrefresh and connector, as they are no longer required. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display

[PATCH v17 0/9] Enable Adaptive Sync SDP Support for DP

2024-03-11 Thread Mitul Golani
longer required. - Use VRR_SYNC_START/END macros correctly. - Update commit message for Patch#9 --v17: - Relocate vrr vsync params. Signed-off-by: Mitul Golani Mitul Golani (9): drm/dp: Add support to indicate if sink supports AS SDP drm: Add Adaptive Sync SDP logging drm/i915/display: Add crtc s

[PATCH v17 1/9] drm/dp: Add support to indicate if sink supports AS SDP

2024-03-11 Thread Mitul Golani
Add an API that indicates support for Adaptive Sync SDP in the sink, which can be utilized by the rest of the DP programming. --v1: - Format commit message properly. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/display/drm_dp_helper.c | 25

[PATCH v17 2/9] drm: Add Adaptive Sync SDP logging

2024-03-11 Thread Mitul Golani
anges to commit message. --v6: - Add correct place holder and name change for AS_SDP_OP_MODE. - Separate i915 changes from drm changes. - Remove extra lines. --v7: - Add drm/i915/display in subject line. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/display/drm_dp_hel

[PATCH v17 4/9] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-03-11 Thread Mitul Golani
sdp->target_rr & 0xFF. - Shift by 8 instead of 32, and drop casting to u64. - Remove changes which are does not belong to this patch. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- .../drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c

[PATCH v17 3/9] drm/i915/display: Add crtc state dump for Adaptive Sync SDP

2024-03-11 Thread Mitul Golani
Add crtc state dump for Adaptive Sync SDP to know which crtc specifically caused the failure. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- .../gpu/drm/i915/display/intel_crtc_state_dump.c| 13 + drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 2 files

[PATCH v17 7/9] drm/i915/display: Add state checker for Adaptive Sync SDP

2024-03-11 Thread Mitul Golani
Enable infoframe and add state checker for Adaptive Sync SDP enablement. --v1: - crtc_state->infoframes.enable, to add on correct place holder. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display.c | 46 1 file chan

[PATCH v17 5/9] drm/i915/dp: Add wrapper function to check AS SDP

2024-03-11 Thread Mitul Golani
Add a wrapper function to check if both the source and sink support Adaptive Sync SDP. --v1: Just use drm/i915/dp in subject line. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_dp.c | 8 drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2

[PATCH v17 6/9] drm/i915/display: Compute AS SDP parameters

2024-03-11 Thread Mitul Golani
conn_state from intel_dp_compute_as_sdp, as not used. - Remove fullstop in subject line. --v9: - Add vrr.enable instead of is_in_vrr_range. --v10: - remove vrefresh and connector, as they are no longer required. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display

[PATCH v17 8/9] drm/i915/display: Compute vrr_vsync params

2024-03-11 Thread Mitul Golani
(vrr.vsync_start/end). - Read/write vrr_vsync params only when we intend to send adaptive_sync sdp. --v4: - Use VRR_SYNC_START/END macros correctly. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 2 ++ .../drm/i915/display/intel_display_types.h| 1 + drivers

[PATCH v17 9/9] drm/i915/display: Read/Write Adaptive Sync SDP

2024-03-11 Thread Mitul Golani
Add read/write calls for Adaptive Sync SDP. Signed-off-by: Mitul Golani Reviewed-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b

[PATCH v18 8/9] drm/i915/display: Compute vrr_vsync params

2024-03-12 Thread Mitul Golani
(vrr.vsync_start/end). - Read/write vrr_vsync params only when we intend to send adaptive_sync sdp. --v4: - Use VRR_SYNC_START/END macros correctly. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 2 ++ .../drm/i915/display/intel_display_types.h| 1 + drivers

[PATCH 0/8] Add DSC fractional bpp support

2023-09-26 Thread Mitul Golani
This patch series adds support for DSC fractional compressed bpp for MTL+. The series starts with some fixes, followed by patches that lay groundwork to iterate over valid compressed bpps to select the 'best' compressed bpp with optimal link configuration (taken from upstream series: https://patchw

[PATCH 3/8] drm/i915/display: Consider fractional vdsc bpp while computing m_n values

2023-09-26 Thread Mitul Golani
(data_clock, 16).' (Sui Jingfeng). Signed-off-by: Ankit Nautiyal Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/intel_display.c | 6 +- drivers/gpu/drm/i915/display/intel_display.h | 2 +- drivers/gpu/drm/i915/display/intel_dp.c | 5 +++--

[PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 format

2023-09-26 Thread Mitul Golani
file for 6.4 fixed point helper(Jani, Nikula) -Add comment for magic values(Suraj) v4: Fix checkpatch warnings caused by renaming(Suraj) Signed-off-by: Ankit Nautiyal Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/icl_dsi.c| 11 +++--- drivers

[PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp precision

2023-09-26 Thread Mitul Golani
From: Ankit Nautiyal Add helper to get the DSC bits_per_pixel precision for the DP sink. Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal Acked-by: Maxime Ripard --- drivers/gpu/drm/display/drm_dp_helper.c | 27 + include/drm/display/drm_dp_helper.h | 1 +

[PATCH 4/8] drm/i915/audio : Consider fractional vdsc bpp while computing tu_data

2023-09-26 Thread Mitul Golani
From: Ankit Nautiyal MTL+ supports fractional compressed bits_per_pixel, with precision of 1/16. This compressed bpp is stored in U6.4 format. Accommodate the precision during calculation of transfer unit data for hblank_early calculation. v2: -Fixed tu_data calculation while dealing with U6.4 f

[PATCH 5/8] drm/i915/dsc/mtl: Add support for fractional bpp

2023-09-26 Thread Mitul Golani
From: Vandita Kulkarni Consider the fractional bpp while reading the qp values. v2: Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) Signed-off-by: Vandita Kulkarni Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal --- .../gpu/drm/i915/display/intel_qp_tables.c

[PATCH 6/8] drm/i915/dp: Iterate over output bpp with fractional step size

2023-09-26 Thread Mitul Golani
From: Ankit Nautiyal This patch adds support to iterate over compressed output bpp as per the fractional step, supported by DP sink. v2: -Avoid ending up with compressed bpp, same as pipe bpp. (Stan) Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal --- drivers/gpu/drm/i915/display/in

[PATCH 8/8] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs

2023-09-26 Thread Mitul Golani
From: Swati Sharma If force_dsc_fractional_bpp_en is set through debugfs allow DSC iff compressed bpp is fractional. Continue if the computed compressed bpp turns out to be a integer. v2: -Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) -Fix comment (Suraj) Signed-off-by: S

[PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-26 Thread Mitul Golani
ue if output_bpp is computed as integer. With this approach, we will be able to validate DSC with fractional bpp. v2: Add drm_modeset_unlock to new line(Suraj) Signed-off-by: Swati Sharma Signed-off-by: Ankit Nautiyal Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal --- .../drm/i915/di

[PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp precision

2023-09-29 Thread Mitul Golani
From: Ankit Nautiyal Add helper to get the DSC bits_per_pixel precision for the DP sink. Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal Reviewed-by: Sui Jingfeng Acked-by: Maxime Ripard --- drivers/gpu/drm/display/drm_dp_helper.c | 27 + include/drm/display

[PATCH 0/8] Add DSC fractional bpp support

2023-09-29 Thread Mitul Golani
This patch series adds support for DSC fractional compressed bpp for MTL+. The series starts with some fixes, followed by patches that lay groundwork to iterate over valid compressed bpps to select the 'best' compressed bpp with optimal link configuration (taken from upstream series: https://patchw

[PATCH 3/8] drm/i915/display: Consider fractional vdsc bpp while computing m_n values

2023-09-29 Thread Mitul Golani
(data_clock, 16).' (Sui Jingfeng). Signed-off-by: Ankit Nautiyal Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal Reviewed-by: Sui Jingfeng --- drivers/gpu/drm/i915/display/intel_display.c | 6 +- drivers/gpu/drm/i915/display/intel_display.h | 2 +- drivers/gpu/drm/i915/display

[PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 format

2023-09-29 Thread Mitul Golani
file for 6.4 fixed point helper(Jani, Nikula) -Add comment for magic values(Suraj) v4: Fix checkpatch warnings caused by renaming(Suraj) Signed-off-by: Ankit Nautiyal Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal Reviewed-by: Sui Jingfeng --- drivers/gpu/drm/i915/display/icl_dsi.c

[PATCH 6/8] drm/i915/dp: Iterate over output bpp with fractional step size

2023-09-29 Thread Mitul Golani
From: Ankit Nautiyal This patch adds support to iterate over compressed output bpp as per the fractional step, supported by DP sink. v2: -Avoid ending up with compressed bpp, same as pipe bpp. (Stan) Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal Reviewed-by: Sui Jingfeng --- driv

[PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp

2023-09-29 Thread Mitul Golani
ue if output_bpp is computed as integer. With this approach, we will be able to validate DSC with fractional bpp. v2: Add drm_modeset_unlock to new line(Suraj) Signed-off-by: Swati Sharma Signed-off-by: Ankit Nautiyal Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal Reviewed-by: Sui Jin

[PATCH 8/8] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs

2023-09-29 Thread Mitul Golani
From: Swati Sharma If force_dsc_fractional_bpp_en is set through debugfs allow DSC iff compressed bpp is fractional. Continue if the computed compressed bpp turns out to be a integer. v2: -Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) -Fix comment (Suraj) Signed-off-by: S

[PATCH 5/8] drm/i915/dsc/mtl: Add support for fractional bpp

2023-09-29 Thread Mitul Golani
From: Vandita Kulkarni Consider the fractional bpp while reading the qp values. v2: Use helpers for fractional, integral bits of bits_per_pixel. (Suraj) Signed-off-by: Vandita Kulkarni Signed-off-by: Ankit Nautiyal Reviewed-by: Suraj Kandpal Reviewed-by: Sui Jingfeng --- .../gpu/drm/i915/d

[PATCH 4/8] drm/i915/audio : Consider fractional vdsc bpp while computing tu_data

2023-09-29 Thread Mitul Golani
From: Ankit Nautiyal MTL+ supports fractional compressed bits_per_pixel, with precision of 1/16. This compressed bpp is stored in U6.4 format. Accommodate the precision during calculation of transfer unit data for hblank_early calculation. v2: -Fixed tu_data calculation while dealing with U6.4 f

[PATCH 0/6] Enable Adaptive Sync SDP Support for DP

2024-02-22 Thread Mitul Golani
Add variables in crtc state->vrr for ad sdp enable and operation mode. (Ankit) - Use above variables for tracking AS SDP. (Ankit) - Revert unused changes. (Ankit) -v10: - Send Patches to dri-devel (Ankit). Mitul Golani (6): drm/dp: Add an support to indicate if sink supports AS SDP drm: Add Ad

[PATCH 1/6] drm/dp: Add an support to indicate if sink supports AS SDP

2024-02-22 Thread Mitul Golani
Add an API which indicates the sink support Adaptive Sync SDP, which can be used by the rest of the DP programming. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 25 + include/drm/display/drm_dp_helper.h | 2 ++ 2 files changed, 27

[PATCH 4/6] drm/i915/display: Compute AS SDP parameters.

2024-02-22 Thread Mitul Golani
before read as sdp. --v6: Use Adaptive Sync sink status, which can be used as a check for read/write sdp. (Ankit) Signed-off-by: Mitul Golani --- .../drm/i915/display/intel_display_types.h| 1 + drivers/gpu/drm/i915/display/intel_dp.c | 28 +++ drivers/gpu/drm/i915

[PATCH 3/6] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-02-22 Thread Mitul Golani
] - Correct code indent. [Jani] --v3: - Update definition names for AS SDP which are starting from HSW, as these defines are applicable for ADLP+.(Ankit) Signed-off-by: Mitul Golani --- .../drm/i915/display/intel_display_types.h| 1 + drivers/gpu/drm/i915/display/intel_dp.c | 89

[PATCH 2/6] drm: Add Adaptive Sync SDP logging

2024-02-22 Thread Mitul Golani
. [Jani] - Update members in as_sdp structure and make it uniform. [Jani] --v3: - Add changes dri-devel mail list. No code changes. --v4: - Instead of directly using operation mode, use enum to accommodate all operation modes (Ankit). Signed-off-by: Mitul Golani --- drivers/gpu/drm/display

[PATCH 6/6] drm/i915/display: Read/Write AS sdp only when sink/source has enabled

2024-02-22 Thread Mitul Golani
Write/Read Adaptive sync SDP only when Sink and Source is enabled for the same. Also along with write TRANS_VRR_VSYNC values. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c| 5 + drivers/gpu/drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm

[PATCH 5/6] drm/i915/display: Compute vrr_vsync params

2024-02-22 Thread Mitul Golani
Compute vrr_vsync_start/end which sets the position for hardware to send the Vsync at a fixed position relative to the end of the Vblank. --v2: - Update, VSYNC_START/END macros to VRR_VSYNC_START/END.(Ankit) - Update bit fields of VRR_VSYNC_START/END.(Ankit) Signed-off-by: Mitul Golani

[PATCH v11 0/8] Enable Adaptive Sync SDP Support for DP

2024-02-28 Thread Mitul Golani
fix or post fix as required. - Add a comment mentioning current support of DP_AS_SDP_AVT_FIXED_VTOTAL. - Add state checker for AS_SDP infoframe enable. - Add PIPE_CONF_CHECK_I(vrr.vsync_start/end). - Read/write vrr_vsync params only when we intend to send adaptive_sync sdp. Signed-off-by: Mitul

[PATCH v11 1/8] drm/dp: Add support to indicate if sink supports AS SDP

2024-02-28 Thread Mitul Golani
Add an API that indicates support for Adaptive Sync SDP in the sink, which can be utilized by the rest of the DP programming. --v1: - Format commit message properly. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 25 + include/drm/display

[PATCH v11 3/8] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-02-28 Thread Mitul Golani
: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 88 ++- drivers/gpu/drm/i915/display/intel_hdmi.c | 12 +++- drivers/gpu/drm/i915/i915_reg.h | 8 +++ include/drm/display/drm_dp_helper.h | 1 + 4 files changed, 106 insertions(+), 3 deletions

[PATCH v11 2/8] drm: Add Adaptive Sync SDP logging

2024-02-28 Thread Mitul Golani
to commit message. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 12 +++ .../drm/i915/display/intel_crtc_state_dump.c | 12 +++ .../drm/i915/display/intel_display_types.h| 1 + include/drm/display/drm_dp.h | 9 + inclu

[PATCH v11 6/8] drm/i915/display: Add state checker for Adaptive Sync SDP

2024-02-28 Thread Mitul Golani
Enable infoframe and add state checker for Adaptive Sync SDP enablement. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 46 drivers/gpu/drm/i915/display/intel_dp.c | 2 + 2 files changed, 48 insertions(+) diff --git a/drivers/gpu/drm

[PATCH v11 4/8] drm/i915/display/dp: Add wrapper function to check AS SDP

2024-02-28 Thread Mitul Golani
Add a wrapper function to check if both the source and sink support Adaptive Sync SDP. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 8 drivers/gpu/drm/i915/display/intel_dp.h

[PATCH v11 5/8] drm/i915/display: Compute AS SDP parameters.

2024-02-28 Thread Mitul Golani
check before reading AS SDP. --v6: - Used Adaptive Sync sink status as a check for read/write SDP. (Ankit) --v7: - Remove as_sdp_enable from crtc_state. - Add a comment mentioning current support of DP_AS_SDP_AVT_FIXED_VTOTAL. - Add state checker for AS_SDP infoframe enable. Signed-off-by: Mitul

[PATCH v11 8/8] drm/i915/display: Read/Write AS sdp only when sink/source has enabled

2024-02-28 Thread Mitul Golani
Write/Read Adaptive sync SDP only when Sink and Source is enabled for the same. Also along with write TRANS_VRR_VSYNC values. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 4 drivers/gpu/drm/i915/display/intel_dp.c | 4 drivers/gpu/drm/i915/display

[PATCH v11 7/8] drm/i915/display: Compute vrr_vsync params

2024-02-28 Thread Mitul Golani
(vrr.vsync_start/end). - Read/write vrr_vsync params only when we intend to send adaptive_sync sdp. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 2 ++ .../drm/i915/display/intel_display_types.h| 1 + drivers/gpu/drm/i915/display/intel_vrr.c | 25

[PATCH v12 0/8] Enable Adaptive Sync SDP Support for DP

2024-02-28 Thread Mitul Golani
oframe enable. - Add PIPE_CONF_CHECK_I(vrr.vsync_start/end). - Read/write vrr_vsync params only when we intend to send adaptive_sync sdp. -v12: - Update cover letter Signed-off-by: Mitul Golani Mitul Golani (8): drm/dp: Add support to indicate if sink supports AS SDP drm: Add Adaptive Sy

[PATCH v12 2/8] drm: Add Adaptive Sync SDP logging

2024-02-28 Thread Mitul Golani
to commit message. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 12 +++ .../drm/i915/display/intel_crtc_state_dump.c | 12 +++ .../drm/i915/display/intel_display_types.h| 1 + include/drm/display/drm_dp.h | 9 + inclu

[PATCH v12 1/8] drm/dp: Add support to indicate if sink supports AS SDP

2024-02-28 Thread Mitul Golani
Add an API that indicates support for Adaptive Sync SDP in the sink, which can be utilized by the rest of the DP programming. --v1: - Format commit message properly. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 25 + include/drm/display

[PATCH v12 3/8] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-02-28 Thread Mitul Golani
: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 88 ++- drivers/gpu/drm/i915/display/intel_hdmi.c | 12 +++- drivers/gpu/drm/i915/i915_reg.h | 8 +++ include/drm/display/drm_dp_helper.h | 1 + 4 files changed, 106 insertions(+), 3 deletions

[PATCH v12 4/8] drm/i915/display/dp: Add wrapper function to check AS SDP

2024-02-28 Thread Mitul Golani
Add a wrapper function to check if both the source and sink support Adaptive Sync SDP. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 8 drivers/gpu/drm/i915/display/intel_dp.h

[PATCH v12 5/8] drm/i915/display: Compute AS SDP parameters.

2024-02-28 Thread Mitul Golani
check before reading AS SDP. --v6: - Used Adaptive Sync sink status as a check for read/write SDP. (Ankit) --v7: - Remove as_sdp_enable from crtc_state. - Add a comment mentioning current support of DP_AS_SDP_AVT_FIXED_VTOTAL. - Add state checker for AS_SDP infoframe enable. Signed-off-by: Mitul

[PATCH v12 7/8] drm/i915/display: Compute vrr_vsync params

2024-02-28 Thread Mitul Golani
(vrr.vsync_start/end). - Read/write vrr_vsync params only when we intend to send adaptive_sync sdp. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 2 ++ .../drm/i915/display/intel_display_types.h| 1 + drivers/gpu/drm/i915/display/intel_vrr.c | 25

[PATCH v12 6/8] drm/i915/display: Add state checker for Adaptive Sync SDP

2024-02-28 Thread Mitul Golani
Enable infoframe and add state checker for Adaptive Sync SDP enablement. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 46 drivers/gpu/drm/i915/display/intel_dp.c | 2 + 2 files changed, 48 insertions(+) diff --git a/drivers/gpu/drm

[PATCH v12 8/8] drm/i915/display: Read/Write AS sdp only when sink/source has enabled

2024-02-28 Thread Mitul Golani
Write/Read Adaptive sync SDP only when Sink and Source is enabled for the same. Also along with write TRANS_VRR_VSYNC values. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 4 drivers/gpu/drm/i915/display/intel_dp.c | 4 drivers/gpu/drm/i915/display

[PATCH v13 0/8] Enable Adaptive Sync SDP Support for DP

2024-02-29 Thread Mitul Golani
rtc_state->infoframes.enable, to add on correct place holder. Signed-off-by: Mitul Golani Mitul Golani (8): drm: Add Adaptive Sync SDP logging drm: Add crtc state dump for Adaptive Sync SDP drm/i915/dp: Add Read/Write support for Adaptive Sync SDP drm/i915/dp: Add wrapper function to check

[PATCH v13 1/8] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Mitul Golani
to commit message. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 12 ++ include/drm/display/drm_dp.h| 10 + include/drm/display/drm_dp_helper.h | 29 + 3 files changed, 51 insertions(+) diff --git a/drivers/gpu/

[PATCH v13 2/8] drm: Add crtc state dump for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
Add crtc state dump for Adaptive Sync SDP to know which crtc specifically caused the failure. --v2: - Add correct place holder and name change for AS_SDP_OP_MODE. - Separate i915 changes from drm changes. - Remove extra lines. Signed-off-by: Mitul Golani --- .../gpu/drm/i915/display

[PATCH v13 3/8] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
if AS_SDP bit is set in crtc_state->infoframes.enable. If not return. - Check for HAS_AS_SDP() before setting VIDEO_DIP_ENABLE_AS_ADL mask. Signed-off-by: Mitul Golani --- .../drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c |

[PATCH v13 5/8] drm/i915/display: Compute AS SDP parameters

2024-02-29 Thread Mitul Golani
conn_state from intel_dp_compute_as_sdp, as not used. - Remove fullstop in subject line. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 26 + 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915

[PATCH v13 4/8] drm/i915/dp: Add wrapper function to check AS SDP

2024-02-29 Thread Mitul Golani
Add a wrapper function to check if both the source and sink support Adaptive Sync SDP. --v1: Just use drm/i915/dp in subject line. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 8 drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2 files changed, 9 insertions

[PATCH v13 8/8] drm/i915/display: Read/Write AS sdp only when sink/source has enabled

2024-02-29 Thread Mitul Golani
Write/Read Adaptive sync SDP only when Sink and Source is enabled for the same. Also along with write TRANS_VRR_VSYNC values. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + 2 files changed, 2 insertions(+) diff

[PATCH v13 6/8] drm/i915/display: Add state checker for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
Enable infoframe and add state checker for Adaptive Sync SDP enablement. --v1: - crtc_state->infoframes.enable, to add on correct place holder. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 46 1 file changed, 46 insertions(+) diff --gi

[PATCH v13 7/8] drm/i915/display: Compute vrr_vsync params

2024-02-29 Thread Mitul Golani
(vrr.vsync_start/end). - Read/write vrr_vsync params only when we intend to send adaptive_sync sdp. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 2 ++ .../drm/i915/display/intel_display_types.h| 1 + drivers/gpu/drm/i915/display/intel_vrr.c | 29

[PATCH v14 0/9] Enable Adaptive Sync SDP Support for DP

2024-02-29 Thread Mitul Golani
rtc_state->infoframes.enable, to add on correct place holder. --v14: Mistakenly dropped first patch, adding back. Signed-off-by: Mitul Golani i Mitul Golani (9): drm/dp: Add support to indicate if sink supports AS SDP drm: Add Adaptive Sync SDP logging drm: Add crtc state dump for Adaptive Sy

[PATCH v14 2/9] drm: Add Adaptive Sync SDP logging

2024-02-29 Thread Mitul Golani
anges to commit message. --v6: - Add correct place holder and name change for AS_SDP_OP_MODE. - Separate i915 changes from drm changes. - Remove extra lines. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 12 ++ include/drm/display/drm_dp.h| 10

[PATCH v14 1/9] drm/dp: Add support to indicate if sink supports AS SDP

2024-02-29 Thread Mitul Golani
Add an API that indicates support for Adaptive Sync SDP in the sink, which can be utilized by the rest of the DP programming. --v1: - Format commit message properly. Signed-off-by: Mitul Golani --- drivers/gpu/drm/display/drm_dp_helper.c | 25 + include/drm/display

[PATCH v14 3/9] drm: Add crtc state dump for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
Add crtc state dump for Adaptive Sync SDP to know which crtc specifically caused the failure. Signed-off-by: Mitul Golani --- .../gpu/drm/i915/display/intel_crtc_state_dump.c| 13 + drivers/gpu/drm/i915/display/intel_display_types.h | 1 + 2 files changed, 14 insertions

[PATCH v14 5/9] drm/i915/dp: Add wrapper function to check AS SDP

2024-02-29 Thread Mitul Golani
Add a wrapper function to check if both the source and sink support Adaptive Sync SDP. --v1: Just use drm/i915/dp in subject line. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 8 drivers/gpu/drm/i915/display/intel_dp.h | 1 + 2 files changed, 9 insertions

[PATCH v14 7/9] drm/i915/display: Add state checker for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
Enable infoframe and add state checker for Adaptive Sync SDP enablement. --v1: - crtc_state->infoframes.enable, to add on correct place holder. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 46 1 file changed, 46 insertions(+) diff --gi

[PATCH v14 9/9] drm/i915/display: Read/Write AS sdp only when sink/source has enabled

2024-02-29 Thread Mitul Golani
Write/Read Adaptive sync SDP only when Sink and Source is enabled for the same. Also along with write TRANS_VRR_VSYNC values. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + drivers/gpu/drm/i915/display/intel_dp.c | 1 + 2 files changed, 2 insertions(+) diff

[PATCH v14 4/9] drm/i915/dp: Add Read/Write support for Adaptive Sync SDP

2024-02-29 Thread Mitul Golani
if AS_SDP bit is set in crtc_state->infoframes.enable. If not return. - Check for HAS_AS_SDP() before setting VIDEO_DIP_ENABLE_AS_ADL mask. Signed-off-by: Mitul Golani --- .../drm/i915/display/intel_display_device.h | 1 + drivers/gpu/drm/i915/display/intel_dp.c |

[PATCH v14 8/9] drm/i915/display: Compute vrr_vsync params

2024-02-29 Thread Mitul Golani
(vrr.vsync_start/end). - Read/write vrr_vsync params only when we intend to send adaptive_sync sdp. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_display.c | 2 ++ .../drm/i915/display/intel_display_types.h| 1 + drivers/gpu/drm/i915/display/intel_vrr.c | 29

  1   2   >