[PATCH v4 05/11] drm: Helper to read max bits per component

On Thu, 2016-06-09 at 11:02 +0300, Ville Syrjälä wrote: > On Mon, Jun 06, 2016 at 04:29:07PM +0300, Mika Kahola wrote: > > Helper routine to read out maximum supported bits per > > component for DisplayPort legay converters. > > > > Signed-off-by: Mika Kahola &

[PATCH v5 00/10] drm/i915: DP branch devices

aniel) v4: Use of drm_dp_helper routines to collect data (Ville) v5: Remove duplicate code and unnecessary functions from drm_dp_helper (Ville) Mika Kahola (10): drm: Add missing DP downstream port types drm: Drop VGA from bpc definitions drm: Helper to read max clock rate drm: Helper to

[PATCH v5 03/10] drm: Helper to read max clock rate

) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 33 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 35 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index eeaf5a7..1199a02 100644 --- a

[PATCH v5 05/10] drm: Read DP branch device id

Read DisplayPort branch device id string. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 12 include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 3dab8a4

[PATCH v5 06/10] drm: Read DP branch device HW revision

HW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x509. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 21 + include/drm/drm_dp_helper.h | 7 +++ 2 files changed, 28 insertions(+) diff --git a

[PATCH v5 07/10] drm: Read DP branch device SW revision

SW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x50A. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 21 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 23 insertions(+) diff --git a

[PATCH v5 09/10] drm/i915: Update bits per component for display info

DisplayPort branch device may define max supported bits per component. Update display info based on this value if bpc is defined. v2: cleanup to match the drm_dp_helper.c patches introduced earlier in this series Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 9

[PATCH v5 10/10] drm/i915: Add DP branch device info on debugfs

Read DisplayPort branch device info from through debugfs interface. v2: use drm_dp_helper routines to collect data v3: cleanup to match the drm_dp_helper.c patches introduced earlier in this series Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/i915_debugfs.c | 72

[PATCH v5 01/10] drm: Add missing DP downstream port types

Add missing DisplayPort downstream port types. The introduced new port types are DP++ and Wireless. Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 5a848e7..e384c7f

[PATCH v5 02/10] drm: Drop VGA from bpc definitions

Drop "VGA" from bits per component definitions as these are also used by other standards such as DVI, HDMI, DP++. Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/drm/drm_dp_helper.h b/i

[PATCH v5 04/10] drm: Helper to read max bits per component

Helper routine to read out maximum supported bits per component for DisplayPort legay converters. v2: Return early if detailed port cap info is not available. Replace if-else ladder with switch-case (Ville) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 42

[PATCH v5 08/10] drm/i915: Check pixel rate for DP to VGA dongle

lle) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index f97cd53..3b09230 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/

[PATCH v6 05/10] drm: Read DP branch device id

Read DisplayPort branch device id string. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 12 include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 95d624a

[PATCH v6 00/10] drm/i915: DP branch devices

rate computation moved to drm (Daniel) v4: Use of drm_dp_helper routines to collect data (Ville) v5: Remove duplicate code and unnecessary functions from drm_dp_helper (Ville) v6: Rebase and i915_debugfs cleanup Mika Kahola (10): drm: Add missing DP downstream port types drm: Drop VGA fro

[PATCH v6 01/10] drm: Add missing DP downstream port types

Add missing DisplayPort downstream port types. The introduced new port types are DP++ and Wireless. Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index 4d85cf2..6e8b92e

[PATCH v6 02/10] drm: Drop VGA from bpc definitions

Drop "VGA" from bits per component definitions as these are also used by other standards such as DVI, HDMI, DP++. Signed-off-by: Mika Kahola --- include/drm/drm_dp_helper.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/drm/drm_dp_helper.h b/i

[PATCH v6 03/10] drm: Helper to read max clock rate

) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 33 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 35 insertions(+) diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 091053e..0d4117c 100644 --- a

[PATCH v6 04/10] drm: Helper to read max bits per component

Helper routine to read out maximum supported bits per component for DisplayPort legay converters. v2: Return early if detailed port cap info is not available. Replace if-else ladder with switch-case (Ville) Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 42

[PATCH v6 06/10] drm: Read DP branch device HW revision

HW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x509. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 21 + include/drm/drm_dp_helper.h | 7 +++ 2 files changed, 28 insertions(+) diff --git a

[PATCH v6 07/10] drm: Read DP branch device SW revision

SW revision is mandatory field for DisplayPort branch devices. This is defined in DPCD register field 0x50A. Signed-off-by: Mika Kahola --- drivers/gpu/drm/drm_dp_helper.c | 21 + include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 23 insertions(+) diff --git a

[PATCH v6 08/10] drm/i915: Check pixel rate for DP to VGA dongle

lle) Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index ffa43ec..76a654e 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/

[PATCH v6 09/10] drm/i915: Update bits per component for display info

DisplayPort branch device may define max supported bits per component. Update display info based on this value if bpc is defined. v2: cleanup to match the drm_dp_helper.c patches introduced earlier in this series Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 9

[PATCH v6 10/10] drm/i915: Add DP branch device info on debugfs

Read DisplayPort branch device info from through debugfs interface. v2: use drm_dp_helper routines to collect data v3: cleanup to match the drm_dp_helper.c patches introduced earlier in this series v4: move DP branch device info to function 'intel_dp_branch_device_info()' Signed-of

Re: [Intel-gfx] [v3] drm/i915: Add detection of changing of edid on between suspend and resume

work) > >  { > >   struct drm_i915_private *dev_priv = > > @@ -552,7 +634,7 @@ static void i915_hpd_poll_init_work(struct > > work_struct *work) > >    * in the middle of disabling polling > >    */ > >   if (!enabled) > > - drm_helper_hpd_irq_event(dev); > > + intel_hpd_irq_event(dev); > >  } > Just wondering, as I saw previously drm_helper_hpd_irq_event function > was used, which basically does the same thing, except doing memcmp > for detecting the edid change. Is it only Intel specific change? As > we > could just add this modification to existing helper function or add > another helper function to the drm (drm_probe_helper.c), so that it > is > also usable elsewhere.. I second Stanislav's proposal to add this feature as part of drm. This edid check could be part of existing drm_helper_hpd_irq_event() function. Other drivers might find this change useful. > > > > >   > >  /** > --  > Best Regards, > > Lisovskiy Stanislav > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Mika Kahola - Intel OTC ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [igt-dev] [PATCH v2 1/3] lib/igt_kms: Add try_prop_enum and set_prop_enum for mode objects, v2.

Looks ok to me. Reviewed-by: Mika Kahola On Wed, 2018-08-15 at 12:08 +0200, Maarten Lankhorst wrote: > This adds the possibility to test arbitrary enumerations in IGT > without > having to define mappings for each and every one. > > Changes since v1: > - Add commit de

Re: [igt-dev] [PATCH v2 2/3] lib/kms: Remove special enum handling and replace with call to igt_plane_set_prop_enum, v2.

ersion by accident. > Reviewed-by: Mika Kahola > Signed-off-by: Maarten Lankhorst > --- >  lib/igt_color_encoding.c | 20 +++ >  lib/igt_color_encoding.h |  3 ++ >  lib/igt_kms.c| 77 +- > -- >  3 files changed, 32 insertions

Re: [PATCH v2] drm/i915/bxt: use NULL for GPIO connection ID

Tested with GLK + MIPI/DSI panel (AU Optronics B101UAN01) Tested-by: Mika Kahola On Thu, 2017-08-17 at 13:55 +0300, Andy Shevchenko wrote: > The commit 213e08ad60ba > ("drm/i915/bxt: add bxt dsi gpio element support") > enables GPIO support for Broxton based platform

Re: [PATCH v2] drm/i915/bxt: use NULL for GPIO connection ID

On Thu, 2017-08-17 at 14:06 +0300, Mika Kahola wrote: > Tested with GLK + MIPI/DSI panel (AU Optronics B101UAN01) Tested also with APL + MIPI/DSI setup. > > Tested-by: Mika Kahola > > On Thu, 2017-08-17 at 13:55 +0300, Andy Shevchenko wrote: > > > > The commit 213e

<    1   2