Hi Lowry,
On Thursday, 1 August 2019 12:37:15 BST Lowry Li (Arm Technology China) wrote:
> From: "Lowry Li (Arm Technology China)"
>
> Adds to print the event message when error happens and the same event
> will not be printed until next vsync.
>
> Changes since v1:
> 1. Handling the event prin
fine komeda_sprintf();
> 2. Not using STR_SZ macro for the string size in komeda_print_events().
>
> Changes since v1:
> 1. Handling the event print by CONFIG_KOMEDA_ERROR_PRINT;
> 2. Changing the max string size to 256.
>
> Signed-off-by: Lowry Li (Arm Technology
The 'memory-region' property of the komeda display driver DT binding
allows the use of a 'reserved-memory' node for buffer allocations. Add
the requisite of_reserved_mem_device_{init,release} calls to actually
make use of the memory if present.
Signed-off-by: Mihail Atanass
On Wednesday, 9 October 2019 09:57:11 GMT james qian wang (Arm Technology
China) wrote:
> On Sat, Sep 21, 2019 at 07:50:46PM +0200, Markus Elfring wrote:
> > From: Markus Elfring
> > Date: Sat, 21 Sep 2019 19:43:51 +0200
> >
> > Simplify this function implementation by using a known wrapper func
Now that there's a debugfs node to control the same, remove the
config option.
Reviewed-by: James Qian Wang (Arm Technology China)
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/arm/display/Kconfig | 6 --
drivers/gpu/drm/arm/display/komeda/Makefile | 5 ++---
dr
Named 'err_verbosity', currently with only 1 active bit in that
replicates the existing level - print error events once per flip.
Reviewed-by: James Qian Wang (Arm Technology China)
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 4
drive
ly once per pageflip, but sometimes it's
useful to see them all as they come in.
These patches are overall quite tiny, and I was considering just
squashing them into one, but I opted to keep them separate for an easier
review experience; please let me know whether you prefer a single patch.
Tha
It's possible to get multiple events in a single frame/flip, so add an
option to print them all.
Reviewed-by: James Qian Wang (Arm Technology China)
Signed-off-by: Mihail Atanassov
---
v2: Clean up continuation line warning from checkpatch.
drivers/gpu/drm/arm/display/komeda/komeda_
Extra detail (normally off) almost never hurts.
Reviewed-by: James Qian Wang (Arm Technology China)
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 11 +++
drivers/gpu/drm/arm/display/komeda/komeda_event.c | 4
2 files changed, 15
swamp the log.
Reviewed-by: James Qian Wang (Arm Technology China)
Signed-off-by: Mihail Atanassov
---
v2: Clean up continuation line warning from checkpatch.
drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 5 -
drivers/gpu/drm/arm/display/komeda/komeda_event.c | 8 +++-
2 file
Hi James,
On Tuesday, 12 November 2019 11:09:50 GMT james qian wang (Arm Technology
China) wrote:
> This series actually are regrouped from:
> - drm/komeda: Enable layer/plane color-mgmt:
> https://patchwork.freedesktop.org/series/60893/
>
> - drm/komeda: Enable CRTC color-mgmt
> https://pat
On Monday, 11 November 2019 15:53:14 GMT Liviu Dudau wrote:
> On Thu, Nov 07, 2019 at 11:42:44AM +0000, Mihail Atanassov wrote:
> > It's possible to get multiple events in a single frame/flip, so add an
> > option to print them all.
> >
> > Reviewed-by: James
On Tuesday, 12 November 2019 18:24:16 GMT Daniel Vetter wrote:
> On Tue, Nov 12, 2019 at 2:00 PM Mihail Atanassov
> wrote:
> >
> > On Monday, 11 November 2019 15:53:14 GMT Liviu Dudau wrote:
> > > On Thu, Nov 07, 2019 at 11:42:44AM +, Mihail Atanassov wrote:
&
Hi James,
On Thursday, 14 November 2019 07:18:56 GMT james qian wang (Arm Technology
China) wrote:
> komeda/komeda_pipeline.c: In function ‘komeda_component_add’:
> komeda/komeda_pipeline.c:213:3: warning: function ‘komeda_component_add’
> might be a candidate for ‘gnu_printf’ format attribute
On Thursday, 14 November 2019 08:37:31 GMT james qian wang (Arm Technology
China) wrote:
> On side by side mode, The full display frame will be split into two parts
> (Left/Right), and each part will be handled by a single pipeline separately
> master pipeline for left part, slave for right.
>
>
gt; @@ -17,6 +17,7 @@ struct komeda_str {
>
> /* return 0 on success, < 0 on no space.
> */
> +__printf(2, 3)
> static int komeda_sprintf(struct komeda_str *str, const char *fmt, ...)
> {
> va_list args;
> --
> 2.20.1
>
>
Reviewed-by: Mihail A
Hi James,
On Thursday, 14 November 2019 08:37:24 GMT james qian wang (Arm Technology
China) wrote:
> Komeda HW can support side by side, which splits the internal display
> processing to two single halves (LEFT/RIGHT) and handle them by two
> pipelines separately.
> komeda "side by side" is enabl
Hi Laurent,
On Tuesday, 10 December 2019 22:57:04 GMT Laurent Pinchart wrote:
> To support implementation of DRM connectors on top of DRM bridges
> instead of by bridges, the drm_bridge needs to expose new operations and
> data:
>
> - Output detection, hot-plug notification, mode retrieval and ED
Hi,
On Wednesday, 11 December 2019 07:38:29 GMT Thomas Zimmermann wrote:
> Hi
>
> Am 10.12.19 um 16:11 schrieb Mihail Atanassov:
> > As suggested in [1], the 'dev' field is a bit repetitive, since it 1:1
> > follows the setting and NULLing of the 'encoder&#
ix checkpatch complaint about unnecessary parentheses in
drm_bridge.c. I've left the other two in since they're in the patch
context rather than in a touched line.
Cc: Daniel Vetter
Suggested-by: Thomas Zimmermann
Acked-by: Thomas Zimmermann
Signed-off-by: Mihail Atanassov
---
drive
+428,9 @@ static int d71_enum_resources(struct komeda_dev *mdev)
> err = d71_probe_block(d71, &blk, blk_base);
> if (err)
> goto err_cleanup;
> - i++;
>
Hi Tiannan,
Thanks for the patch.
On Wednesday, 11 December 2019 10:30:09 GMT Tiannan Zhu (Arm Technology China)
wrote:
> Make komeda driver can recongise D77, D77 is arm latest display
> product, compare with D71, D77 support some new features:
> 1. Crossbar: adjust every plane's zorder
> 2. AT
patch
I would've expected the fix to be a part of this series as 2/3 and this
patch as 3/3.
Otherwise, this patch is
Reviewed-by: Mihail Atanassov
>
> Signed-off-by: James Qian Wang (Arm Technology China)
>
> ---
> .../drm/arm/display/include/malidp_product.h | 3 +-
> .
eda_kms.c
> index e30a5b43caa9..9a7dcf92591a 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
> @@ -307,10 +307,6 @@ struct komeda_kms_dev *komeda_kms_attach(struct
> komeda_dev *mdev)
> if (err)
> goto free_component_binding;
>
> - err = mdev->funcs->enable_irq(mdev);
> - if (err)
> - goto free_component_binding;
> -
> drm->irq_enabled = true;
>
> drm_kms_helper_poll_init(drm);
> @@ -324,7 +320,6 @@ struct komeda_kms_dev *komeda_kms_attach(struct
> komeda_dev *mdev)
> free_interrupts:
> drm_kms_helper_poll_fini(drm);
> drm->irq_enabled = false;
> - mdev->funcs->disable_irq(mdev);
> free_component_binding:
> component_unbind_all(mdev->dev, drm);
> cleanup_mode_config:
> @@ -346,7 +341,6 @@ void komeda_kms_detach(struct komeda_kms_dev *kms)
> drm_kms_helper_poll_fini(drm);
> drm_atomic_helper_shutdown(drm);
> drm->irq_enabled = false;
> - mdev->funcs->disable_irq(mdev);
> component_unbind_all(mdev->dev, drm);
> drm_mode_config_cleanup(drm);
> komeda_kms_cleanup_private_objs(kms);
>
Reviewed-by: Mihail Atanassov
--
Mihail
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
evt_sprintf(str, events & KOMEDA_EVENT_IBSY, "IBSY|");
> + evt_sprintf(str, events & KOMEDA_EVENT_EMPTY, "EMPTY|");
> + evt_sprintf(str, events & KOMEDA_EVENT_FULL, "FULL|");
> evt_sprintf(str, events & KOMEDA_ERR_AXIE, "AXIE|");
> evt_sprintf(str, events & KOMEDA_ERR_ACE0, "ACE0|");
> evt_sprintf(str, events & KOMEDA_ERR_ACE1, "ACE1|");
>
Thanks for the patch,
Reviewed-by: Mihail Atanassov
--
Mihail
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
No functional change.
v3:
- drop driver_private argument (Laurent)
v2:
- Also apply drm_bridge_init() in sti_hdmi.c and sti_hda.c (Sam,
Benjamin)
Reviewed-by: Benjamin Gaignard
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/sti/sti_dvo.c | 3
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge
It's unused.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/thc63lvd1024.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c
b/drivers/gpu/drm/bridge/thc63lvd1024.c
index 3d74129b2995..784f4e4eea05 100644
--- a/drivers/gpu/drm/b
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/i2c/tda998x_drv.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
b/drivers/gpu/drm
dw_hdmi: The drm_bridge struct is already embedded, so use
a container_of wrapper to access it.
dw-mipi-dsi: The field is unused, remove it.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 15 ---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/tc358764.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358764.c
b/drivers/gpu/drm
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/lvds-codec.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/lvds-codec.c
b/drivers
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/sii902x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm
Instead, embed the drm_bridge structure in the originally-pointed-to
struct and use a container_of wrapper to access it.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/sti/sti_dvo.c | 20
drivers/gpu/drm/sti/sti_hda.c | 17 -
drivers/gpu/drm/sti
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/parade-ps8622.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c
b/drivers
No functional change.
v3:
- drop driver_private argument (Laurent)
Acked-by: Linus Walleij
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/mcde/mcde_dsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c
nd as part of drm_bridge_init() series
v2:
- fix checkpatch complaint about unnecessary parentheses in
drm_bridge.c
Cc: Daniel Vetter
Suggested-by: Thomas Zimmermann
Acked-by: Thomas Zimmermann
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +-
dr
It's unused.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c
b/drivers/gpu/drm/rcar-du/rcar_lvds.c
index 83538125a722..1d6dfae8a200 100644
--- a/drivers/gpu/drm/rcar-du/rcar_l
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi
Use a container_of wrapper instead. Note that no logic depends on
driver_private being NULL or not, so the cleanup in exynos_mic_bind is
safe to apply.
Cc: Inki Dae
Signed-off-by: Mihail Atanassov
---
Reviewer note: the driver_private cleanup used to be part of the
relevant drm_bridge_init
evice pointer to drm_bridge_init (Laurent)
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 5 ++---
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 8 ++--
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 8
3 files changed, 8 insertions(+), 13 de
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
b/drivers
Instead, embed the drm_bridge structure into analogix_dp_core and use
a container_of wrapper to access the latter.
Signed-off-by: Mihail Atanassov
---
.../drm/bridge/analogix/analogix_dp_core.c| 40 +++
.../drm/bridge/analogix/analogix_dp_core.h| 8 +++-
2 files changed
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/dumb-vga-dac.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c
b
uash all analogix changes into
one patch
Mihail Atanassov (35):
drm: Remove drm_bridge->dev
drm/bridge: analogix_dp: Stop using drm_bridge->driver_private
drm/bridge/synopsys: Stop using drm_bridge->driver_private
drm/bridge: thc63lvd1024: Don't set drm_bridge->dr
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/adv7511
No functional change.
v3:
- drop driver_private argument (Laurent)
Cc: Inki Dae
Cc: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/exynos/exynos_drm_mic.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c
b
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/nxp-ptn3460.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c
b/drivers/gpu
tyle updates to docs (Laurent)
- don't set drm_bridge->dev (field removed)
v2:
- s/WARN_ON(!funcs)/WARN_ON(!funcs || !dev)/ as suggested by Daniel
- expand on some kerneldoc comments as suggested by Daniel
- update commit message as suggested by Daniel
Reviewed-by: Daniel Vetter
Signed-of
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
b
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/cdns-dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c
b/drivers/gpu/drm
nd as part of drm_bridge_init() series
v2:
- fix checkpatch complaint about unnecessary parentheses in
drm_bridge.c
Cc: Daniel Vetter
Suggested-by: Thomas Zimmermann
Acked-by: Thomas Zimmermann
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +-
dr
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/panel.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm
No functional change.
v3:
- drop driver_private argument (Laurent)
- update commit title prefix (Neil)
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/sii9234.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm
No functional change.
v3:
- drop driver_private argument (Laurent)
Acked-by: CK Hu
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek
No functional change.
v3:
- drop driver_private argument (Laurent)
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/thc63lvd1024.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c
b/drivers/gpu/drm/bridge/thc63lvd1024.c
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/sil-sii8620.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c
b/drivers/gpu
No functional change.
v3:
- drop driver_private argument (Laurent)
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/rcar-du/rcar_lvds.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c
b/drivers/gpu/drm/rcar-du/rcar_lvds.c
index
It's no longer used, all drivers have been converted to an embedded
drm_bridge struct.
Signed-off-by: Mihail Atanassov
---
include/drm/drm_bridge.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index 695d0898df38..ee175a2f95e6 1
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/ti-tfp410.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c
b/drivers/gpu/drm
No functional change.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/bridge/tc358767.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/tc358767.c
b/drivers/gpu/drm
No functional change: drm_bridge_init() sets bridge->of_node, but that's
not used by msm anywhere, and the bridges aren't published with
drm_bridge_add() for it to matter.
v3:
- drop driver_private argument (Laurent)
Reviewed-by: Laurent Pinchart
Signed-off-by: Mihail Atanassov
r
our feet.
Signed-off-by: Mihail Atanassov
---
.../gpu/drm/arm/display/komeda/komeda_dev.h | 5 +
.../gpu/drm/arm/display/komeda/komeda_drv.c | 58 ++--
.../gpu/drm/arm/display/komeda/komeda_kms.c | 133 +-
.../gpu/drm/arm/display/komeda/komeda_kms.h | 5 +
4
.
Signed-off-by: Mihail Atanassov
---
.../gpu/drm/arm/display/komeda/komeda_dev.c | 21 ---
.../gpu/drm/arm/display/komeda/komeda_dev.h | 4 +--
.../gpu/drm/arm/display/komeda/komeda_drv.c | 36 +--
.../gpu/drm/arm/display/komeda/komeda_kms.c | 26 --
r rmmod'ed while in use would be Bad(tm).
[1] https://lore.kernel.org/lkml/20180426223139.16740-1-p...@axentia.se/
Cc: Liviu Dudau
Cc: Brian Starkey
Cc: James (Qian) Wang
Cc: Daniel Vetter
Cc: David Airlie
Cc: Maxime Ripard
Cc: Maarten Lankhorst
Cc: Sean Paul
Mihail Atanassov (3)
Some fields of komeda_drv members will be useful very early
in probe code, so make sure an instance is available.
Signed-off-by: Mihail Atanassov
---
.../gpu/drm/arm/display/komeda/komeda_drv.c | 30 +++
1 file changed, 17 insertions(+), 13 deletions(-)
diff --git a/drivers
Hi Lowry,
On Tuesday, 8 October 2019 10:17:52 BST Lowry Li (Arm Technology China) wrote:
> Set color_depth according to connector->bpc.
>
> Signed-off-by: Lowry Li (Arm Technology China)
> ---
> .../arm/display/komeda/d71/d71_component.c| 1 +
> .../gpu/drm/arm/display/komeda/komeda_crtc.c
On Tuesday, 8 October 2019 11:28:24 BST Lowry Li (Arm Technology China) wrote:
> Hi Brian,
> On Tue, Oct 08, 2019 at 09:36:09AM +, Brian Starkey wrote:
> > Hi Lowry,
> >
> > On Tue, Oct 08, 2019 at 09:17:52AM +, Lowry Li (Arm Technology China)
> > wrote:
> > > Set color_depth according to
HW doesn't allow flushing inactive pipes and raises an MERR interrupt
if you try to do so. Stop triggering the MERR interrupt in the
middle of a commit by calling drm_atomic_helper_commit_planes
with the ACTIVE_ONLY flag.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/arm/display/k
Hi James,
On Friday, 11 October 2019 06:45:27 BST james qian wang (Arm Technology China)
wrote:
> Add a new helper function drm_color_ctm_s31_32_to_qm_n() for driver to
> convert S31.32 sign-magnitude to Qm.n 2's complement that supported by
> hardware.
>
> Signed-off-by: james qian wang (Arm Te
efine KOMEDA_COLOR_LUT_SIZEBIT(KOMEDA_COLOR_PRECISION)
> +#define KOMEDA_N_CTM_COEFFS 9
[nit] The alignment with the group above seems a bit off.
> +
> +void drm_lut_to_fgamma_coeffs(struct drm_property_blob *lut_blob, u32
> *coeffs);
>
> const s32 *komeda_sele
; *coeffs);
> +void drm_ctm_to_coeffs(struct drm_property_blob *ctm_blob, u32 *coeffs);
>
> const s32 *komeda_select_yuv2rgb_coeffs(u32 color_encoding, u32 color_range);
>
>
...
Reviewed-by: Mihail Atanassov
--
Mihail
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi James, Lowry,
On Friday, 11 October 2019 06:45:50 BST james qian wang (Arm Technology China)
wrote:
> From: "Lowry Li (Arm Technology China)"
>
> Adds gamma and color-transform support for DOU-IPS.
> Adds two caps members fgamma_coeffs and ctm_coeffs to komeda_improc_state.
> If color manage
On Friday, 11 October 2019 11:12:51 BST Lowry Li (Arm Technology China) wrote:
> Hi Mihail,
> On Fri, Oct 11, 2019 at 08:54:03AM +, Mihail Atanassov wrote:
> > Hi James, Lowry,
> >
> > On Friday, 11 October 2019 06:45:50 BST james qian wang (Arm Technology
>
/arm/display/komeda/komeda_wb_connector.c
> @@ -142,6 +142,7 @@ static int komeda_wb_connector_add(struct komeda_kms_dev
> *kms,
> struct komeda_dev *mdev = kms->base.dev_private;
> struct komeda_wb_connector *kwb_conn;
> struct drm_writeback_connector *wb_conn;
> + struct drm_display_info *info;
> u32 *formats, n_formats = 0;
> int err;
>
> @@ -171,6 +172,9 @@ static int komeda_wb_connector_add(struct komeda_kms_dev
> *kms,
>
> drm_connector_helper_add(&wb_conn->base, &komeda_wb_conn_helper_funcs);
>
> + info = &kwb_conn->base.base.display_info;
> + info->bpc = __fls(kcrtc->master->improc->supported_color_depths);
> +
> kcrtc->wb_conn = kwb_conn;
>
> return 0;
>
Reviewed-by: Mihail Atanassov
--
Mihail
On Monday, 14 October 2019 10:43:39 BST james qian wang (Arm Technology China)
wrote:
> On Fri, Oct 11, 2019 at 08:26:53AM +0000, Mihail Atanassov wrote:
> > Hi James,
> >
> > On Friday, 11 October 2019 06:45:27 BST james qian wang (Arm Technology
> > China) wr
On Tuesday, 15 October 2019 02:16:11 BST james qian wang (Arm Technology China)
wrote:
> On Mon, Oct 14, 2019 at 11:58:48AM -0400, Ilia Mirkin wrote:
> > On Fri, Oct 11, 2019 at 1:43 AM james qian wang (Arm Technology China)
> > wrote:
> > >
> > > Add a new helper function drm_color_ctm_s31_32_to
Signed-off-by: Mihail Atanassov
---
.../gpu/drm/arm/display/komeda/d71/d71_component.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
b/drivers/gpu/drm/arm/display/komeda/d71/d71_component.c
index
el and Ilia's review comments.
> V5: Includes the sign bit in the value of m (Qm.n).
>
> Signed-off-by: james qian wang (Arm Technology China)
>
> Reviewed-by: Mihail Atanassov
> Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/drm_color_mgmt.c | 27 ++
drm_lut_to_fgamma_coeffs(kcrtc_st->base.gamma_lut,
> + st->fgamma_coeffs);
> + drm_ctm_to_coeffs(kcrtc_st->base.ctm, st->ctm_coeffs);
> + }
> +
> komeda_component_add_input(&st->base, &dflow->input, 0);
> komeda_component_set_output(&dflow->input, &improc->base, 0);
>
>
You must've missed it, but I had a
Reviewed-by: Mihail Atanassov
(granted, it was deeper in a thread and quite informally written
as 'r-b me')
--
Mihail
Hi James,
On Wednesday, 9 October 2019 06:54:15 BST james qian wang (Arm Technology
China) wrote:
> On Fri, Oct 04, 2019 at 02:34:42PM +0000, Mihail Atanassov wrote:
> > To support transmitters other than the tda998x, we need to allow
> > non-component framework bridges to be atta
On Friday, 18 October 2019 08:51:09 BST james qian wang (Arm Technology China)
wrote:
> On Wed, Oct 16, 2019 at 11:02:03AM +0000, Mihail Atanassov wrote:
> > On Wednesday, 16 October 2019 11:34:08 BST james qian wang (Arm Technology
> > China) wrote:
> > > A
On Friday, 18 October 2019 07:38:59 BST james qian wang (Arm Technology China)
wrote:
> On Thu, Oct 17, 2019 at 10:48:12AM +, Brian Starkey wrote:
> > On Thu, Oct 17, 2019 at 10:21:03AM +, james qian wang (Arm Technology
> > China) wrote:
> > > On Thu, Oct 17, 2019 at 08:20:56AM +, Br
On Wednesday, 16 October 2019 09:17:39 BST james qian wang (Arm Technology
China) wrote:
> On Tue, Oct 15, 2019 at 11:00:01AM +0000, Mihail Atanassov wrote:
> > Signed-off-by: Mihail Atanassov
> > ---
> > .../gpu/drm/arm/display/komeda/d71/d71_component.c | 14 +
On Wednesday, 16 October 2019 09:23:03 BST james qian wang (Arm Technology
China) wrote:
> On Mon, Sep 30, 2019 at 12:23:07PM +0000, Mihail Atanassov wrote:
> > Fix both the string and the struct member being printed.
> >
> > Changes since v1:
> > - Now wi
On Wednesday, 16 October 2019 09:21:24 BST james qian wang (Arm Technology
China) wrote:
> On Thu, Oct 10, 2019 at 10:30:07AM +0000, Mihail Atanassov wrote:
> > HW doesn't allow flushing inactive pipes and raises an MERR interrupt
> > if you try to do so. Stop triggering the M
Hi Andrzej,
On Monday, 21 October 2019 14:50:14 BST Ayan Halder wrote:
> On Fri, Oct 11, 2019 at 01:18:10PM +0200, Andrzej Pietrasiewicz wrote:
> > These are useful for other users of afbc, e.g. rockchip.
> >
> > Signed-off-by: Andrzej Pietrasiewicz
>
> Hi Andrzej,
>
> Thanks a lot for doing t
I'll be the main point of contact.
Cc: James Qian Wang (Arm Technology China)
Cc: Liviu Dudau
Signed-off-by: Mihail Atanassov
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 94fb077c0817..d32f263f0022 100644
--- a/MAINTAINERS
Now that there's a debugfs node to control the same, remove the
config option.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/arm/display/Kconfig | 6 --
drivers/gpu/drm/arm/display/komeda/Makefile | 5 ++---
drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 6
; please let me know whether you prefer a single patch.
Thanks!
Mihail Atanassov (5):
drm/komeda: Add debugfs node to control error verbosity
drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT
drm/komeda: Optionally dump DRM state on interrupts
drm/komeda: Add option to print WARN- and INFO-le
Named 'err_verbosity', currently with only 1 active bit in that
replicates the existing level - print error events once per flip.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 4
drivers/gpu/drm/arm/display/komeda/komeda_de
It's possible to get multiple events in a single frame/flip, so add an
option to print them all.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 2 ++
drivers/gpu/drm/arm/display/komeda/komeda_event.c | 3 ++-
2 files changed, 4 insertions(+), 1 del
swamp the log.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 5 -
drivers/gpu/drm/arm/display/komeda/komeda_event.c | 8 +++-
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
b/driver
Extra detail (normally off) almost never hurts.
Signed-off-by: Mihail Atanassov
---
drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 11 +++
drivers/gpu/drm/arm/display/komeda/komeda_event.c | 4
2 files changed, 15 insertions(+)
diff --git a/drivers/gpu/drm/arm/display/komeda
Hi Shashank,
On Tuesday, 22 October 2019 10:59:44 BST Shashank Sharma wrote:
> This patch adds a scaling filter mode porperty
> to allow:
> - A driver/HW to showcase it's scaling filter capabilities.
> - A userspace to pick a desired effect while scaling.
>
> This option will be particularly usefu
On Tuesday, 22 October 2019 14:26:38 BST Mihail Atanassov wrote:
> Hi Shashank,
>
> On Tuesday, 22 October 2019 10:59:44 BST Shashank Sharma wrote:
> > This patch adds a scaling filter mode porperty
> > to allow:
> > - A driver/HW to showcase it's scaling filter ca
ely drm_atomic_helper_shutdown plus making sure that
> drm_mode_config_cleanup is not called too early (i.e. not in driver
> unload, but only in the final drm_device release callback).
>
> Cc: Mihail Atanassov
> Reported-by: Mihail Atanassov
> Signed-off-by: Daniel Vetter
this - it's based off an older kernel, so may be missing
> some of the bridge drivers, but should be sufficient for people to test
> with.
Thanks for the patch, I tested to the limit that our driver allows at
the moment -- rmmod'ing the bridge while the driver is not in use --
and
ts.
>
> Signed-off-by: james qian wang (Arm Technology China)
>
> Reviewed-by: Mihail Atanassov
> Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/drm/drm_color_mgmt.c | 36
> include/drm/drm_color_mgmt.h | 2 ++
> 2 files chang
Provide a dummy static inline function in the header instead.
Cc: Daniel Vetter
Cc: Lowry Li (Arm Technology China)
Cc: james qian wang (Arm Technology China)
Fixes: 4d74b25ee395 ("drm/komeda: Adds error event print functionality")
Signed-off-by: Mihail Atanassov
---
drivers/g
1 - 100 of 243 matches
Mail list logo
