TILCDC driver - Array to keep register values during PM suspend is too small

2015-07-01 Thread Michael Bode
Hi, i currently try to write a LIDD version of the TILCDC driver in driver/gpu/drm. During my investigations I found the function "tilcdc_pm_suspend" in tilcdc_drv.c: #ifdef CONFIG_PM_SLEEP static int tilcdc_pm_suspend(struct device *dev) { . /* Save register state: */ for (i

[PATCH] drm/tilcdc: Allocate register storage based on the actual number registers

2015-07-03 Thread Michael Bode
Reviewed-By: Michael Bode Jyri, good idea to allocate the space for registers dynamically. This eliminates the need of synchronizing driver and header file in an elegant way. Only thing I personally don't like, is potentially passing a NULL pointer to kfree. But I learned that th