[PATCH 00/10] drm/bridge: Make panel and bridge probe order consistent

2021-07-20 Thread Maxime Ripard
the new attach and detach hooks. If the general approach is agreed upon, other drivers will obviously be converted to drm_of_get_next. Let me know what you think, Maxime Maxime Ripard (10): Revert "drm/vc4: dsi: Only register our component once a DSI device is attached" drm/br

[PATCH 01/10] Revert "drm/vc4: dsi: Only register our component once a DSI device is attached"

2021-07-20 Thread Maxime Ripard
Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_dsi.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c index a55256ed0955..6dfcbd9e234e 100644 --- a/drivers/gpu/drm/vc4/vc4_dsi.c ++

[PATCH 02/10] drm/bridge: Add a function to abstract away panels

2021-07-20 Thread Maxime Ripard
the boilerplate and hopefully create a path of least resistance towards using the DRM panel bridge layer, let's create the function devm_drm_of_get_next to reduce that boilerplate. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_bridge.c | 62 +--- driver

[PATCH 03/10] drm/bridge: Add documentation sections

2021-07-20 Thread Maxime Ripard
The bridge documentation overview is quite packed already, and we'll add some more documentation that isn't part of an overview at all. Let's add some sections to the documentation to separare each bits. Signed-off-by: Maxime Ripard --- Documentation/gpu/drm-kms-h

[PATCH 04/10] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-07-20 Thread Maxime Ripard
Interactions between bridges, panels, MIPI-DSI host and the component framework are not trivial and can lead to probing issues when implementing a display driver. Let's document the various cases we need too consider, and the solution to support all the cases. Signed-off-by: Maxime R

[PATCH 05/10] drm/panel: Create attach and detach callbacks

2021-07-20 Thread Maxime Ripard
In order to make the probe order expectation more consistent between bridges, let's create attach and detach hooks for the panels as well to match what is there for bridges. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_panel.c | 20 include/drm/drm_panel.h

[PATCH 06/10] drm/bridge: panel: Call attach and detach for the panel

2021-07-20 Thread Maxime Ripard
Now that we have additional attach and detach hooks for panels, make sure that the panel bridge driver calls them when relevant. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/bridge/panel.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu

[PATCH 07/10] drm/vc4: dsi: Switch to drm_of_get_next

2021-07-20 Thread Maxime Ripard
The new drm_of_get_next removes most of the boilerplate we have to deal with. Let's switch to it. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_drv.c | 2 ++ drivers/gpu/drm/vc4/vc4_dsi.c | 28 2 files changed, 6 insertions(+), 24 deletions(-)

[PATCH 08/10] drm/panel: raspberrypi-touchscreen: Prevent double-free

2021-07-20 Thread Maxime Ripard
The mipi_dsi_device allocated by mipi_dsi_device_register_full() is already free'd on release. Fixes: 2f733d6194bd ("drm/panel: Add support for the Raspberry Pi 7" Touchscreen.") Signed-off-by: Maxime Ripard --- drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 1

[PATCH 09/10] drm/panel: raspberrypi-touchscreen: Use the attach hook

2021-07-20 Thread Maxime Ripard
Now that we have an attach hook available for panels as well, let's use it for the RaspberryPi 7" DSI panel. This now mimics what all the other bridges in a similar situation are doing, and we avoid our probe order issue entirely. Signed-off-by: Maxime Ripard --- .../drm/p

[PATCH 10/10] drm/panel: raspberrypi-touchscreen: Remove MIPI-DSI driver

2021-07-20 Thread Maxime Ripard
entirely though, resulting in a completely empty MIPI-DSI device probe. Let's simplify the driver by removing it entirely and just behave as a normal i2c driver. Signed-off-by: Maxime Ripard --- .../drm/panel/panel-raspberrypi-touchscreen.c | 25 +-- 1 file changed, 1 inse

[PATCH v6] Documentation: gpu: Mention the requirements for new properties

2021-07-20 Thread Maxime Ripard
lumenstingl Cc: Matthias Brugger Cc: Maxime Coquelin Cc: Maxime Ripard Cc: Melissa Wen Cc: Neil Armstrong Cc: Nicolas Ferre Cc: "Noralf Trønnes" Cc: NXP Linux Team Cc: Oleksandr Andrushchenko Cc: Patrik Jakobsson Cc: Paul Cercueil Cc: Pekka Paalanen Cc: Pengutronix Kernel Team Cc

[PATCH 10/54] dt-bindings: display: panel-lvds: Document panel compatibles

2021-07-21 Thread Maxime Ripard
dri-devel@lists.freedesktop.org Cc: Laurent Pinchart Cc: Sam Ravnborg Cc: Thierry Reding Signed-off-by: Maxime Ripard --- .../bindings/display/panel/lvds.yaml | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel

[PATCH 11/54] dt-bindings: display: simple-bridge: Add corpro, gm7123 compatible

2021-07-21 Thread Maxime Ripard
The corpro,gm7123 was in use in a DT but was never properly documented, let's add it. Cc: dri-devel@lists.freedesktop.org Reviewed-by: Laurent Pinchart Signed-off-by: Maxime Ripard --- Changes from v1: - Removed the dumb-vga-dac compatible from the list --- .../devicetree/bindings/di

Re: [PATCH v1 1/7] drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs

2021-07-22 Thread Maxime Ripard
atomic variants. > > Signed-off-by: Sam Ravnborg > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Robert Foss > Cc: Laurent Pinchart > Cc: Jonas Karlman > Cc: Jernej Skrabec Reviewed-by: Maxime Ripard Maxime

Re: [PATCH v1 2/7] drm/bridge: Drop unused drm_bridge_chain functions

2021-07-22 Thread Maxime Ripard
ferences to the dropped functions. > > Signed-off-by: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Robert Foss > Cc: Daniel Vetter Reviewed-by: Maxime Ripard Maxime

Re: [PATCH v1 3/7] drm/bridge: Add drm_bridge_new_crtc_state() helper

2021-07-22 Thread Maxime Ripard
rm_bridge_funcs. > > Signed-off-by: Sam Ravnborg > Suggested-by: Laurent Pinchart > Cc: Laurent Pinchart > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Robert Foss > Cc: Daniel Ve

Re: [PATCH v1 5/7] drm/mediatek: Drop chain_mode_fixup call in mode_valid()

2021-07-22 Thread Maxime Ripard
> were added and is seems safe to remove the call now. > > Signed-off-by: Sam Ravnborg > Cc: Chun-Kuang Hu > Cc: Philipp Zabel > Cc: Matthias Brugger > Cc: Dafna Hirschfeld > Cc: linux-media...@lists.infradead.org > Cc: linux-arm-ker...@lists.infradead.org Reviewed-by: Maxime Ripard Maxime

Re: [PATCH v1 6/7] drm/bridge: Drop drm_bridge_chain_mode_fixup

2021-07-22 Thread Maxime Ripard
ic_bridge_check(). > Drop it. > > Signed-off-by: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter Reviewed-by: Maxime Ripard Maxime

Re: [PATCH v1 7/7] drm/todo: Add bridge related todo items

2021-07-22 Thread Maxime Ripard
On Thu, Jul 22, 2021 at 08:22:46AM +0200, Sam Ravnborg wrote: > - deprecated callbacks in drm_bridge_funcs > - move connector creation to display drivers > > Signed-off-by: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas

Re: [PATCH v1 4/7] drm/bridge: lontium-lt9611: Use atomic variants of drm_bridge_funcs

2021-07-22 Thread Maxime Ripard
Hi, On Thu, Jul 22, 2021 at 08:22:43AM +0200, Sam Ravnborg wrote: > The atomic variants of enable/disable in drm_bridge_funcs are the > preferred operations - introduce these. > > Use of mode_set is deprecated - merge the functionality with > atomic_enable() > > Signed-off-by: Sam Ravnborg > Cc

Re: [PATCH 08/10] drm/panel: raspberrypi-touchscreen: Prevent double-free

2021-07-22 Thread Maxime Ripard
On Tue, Jul 20, 2021 at 07:19:40PM +0200, Sam Ravnborg wrote: > Hi Maxime, > On Tue, Jul 20, 2021 at 03:45:23PM +0200, Maxime Ripard wrote: > > The mipi_dsi_device allocated by mipi_dsi_device_register_full() is > > already free'd on release. > > > > Fixes: 2f

Re: [PATCH 11/54] dt-bindings: display: simple-bridge: Add corpro, gm7123 compatible

2021-07-22 Thread Maxime Ripard
On Wed, Jul 21, 2021 at 04:16:13PM +0200, Sam Ravnborg wrote: > On Wed, Jul 21, 2021 at 04:03:41PM +0200, Maxime Ripard wrote: > > The corpro,gm7123 was in use in a DT but was never properly documented, > > let's add it. > > > > Cc: dri-devel@lists.freedesk

Re: [PATCH v6] Documentation: gpu: Mention the requirements for new properties

2021-07-23 Thread Maxime Ripard
On Tue, Jul 20, 2021 at 04:35:44PM +0200, Maxime Ripard wrote: > New KMS properties come with a bunch of requirements to avoid each > driver from running their own, inconsistent, set of properties, > eventually leading to issues like property conflicts, inconsistencies > between

Re: [PATCH 04/10] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-07-26 Thread Maxime Ripard
Hi Daniel, On Wed, Jul 21, 2021 at 02:05:01PM +0200, Daniel Vetter wrote: > On Tue, Jul 20, 2021 at 03:45:19PM +0200, Maxime Ripard wrote: > > Interactions between bridges, panels, MIPI-DSI host and the component > > framework are not trivial and can lead to probing issues when >

Re: [PATCH 2/2] drm/vc4: hdmi: Remove unused struct

2021-07-28 Thread Maxime Ripard
On Wed, Jul 28, 2021 at 12:01:34PM +0100, Dave Stevenson wrote: > On Wed, 7 Jul 2021 at 10:36, Maxime Ripard wrote: > > > > Commit 91e99e113929 ("drm/vc4: hdmi: Register HDMI codec") removed the > > references to the vc4_hdmi_audio_component_drv structure, b

Re: [PATCH] drm/vc4: hdmi: Add debugfs prefix

2021-07-28 Thread Maxime Ripard
Hi, On Fri, Jul 23, 2021 at 09:24:14AM +0200, Ivan T. Ivanov wrote: > Without prefix debugfs can't properly create component > debug information tree when driver register more than > one component per device, in this case two. Fix this. > > debugfs: Directory 'fef00700.hdmi' with parent 'vc4-hdmi

Re: [PATCH 04/10] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-07-28 Thread Maxime Ripard
Hi, On Tue, Jul 27, 2021 at 11:20:54AM +0200, Daniel Vetter wrote: > On Mon, Jul 26, 2021 at 05:16:57PM +0200, Maxime Ripard wrote: > > Hi Daniel, > > > > On Wed, Jul 21, 2021 at 02:05:01PM +0200, Daniel Vetter wrote: > > > On Tue, Jul 20, 2021 at 03:45:1

[PATCH v2 0/8] drm/bridge: Make panel and bridge probe order consistent

2021-07-28 Thread Maxime Ripard
bf6 and squash the two patches that were reverting that commit - Add some documentation - Make drm_panel_attach and _detach succeed when no callback is there Maxime Ripard (8): Revert "drm/vc4: dsi: Only register our component once a DSI device is attached" drm/bridge: A

[PATCH v2 1/8] Revert "drm/vc4: dsi: Only register our component once a DSI device is attached"

2021-07-28 Thread Maxime Ripard
Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_dsi.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c index a55256ed0955..6dfcbd9e234e 100644 --- a/drivers/gpu/drm/vc4/vc4_dsi.c ++

[PATCH v2 2/8] drm/bridge: Add a function to abstract away panels

2021-07-28 Thread Maxime Ripard
the boilerplate and hopefully create a path of least resistance towards using the DRM panel bridge layer, let's create the function devm_drm_of_get_next to reduce that boilerplate. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_bridge.c | 42 driver

[PATCH v2 3/8] drm/bridge: Add documentation sections

2021-07-28 Thread Maxime Ripard
The bridge documentation overview is quite packed already, and we'll add some more documentation that isn't part of an overview at all. Let's add some sections to the documentation to separate each bits. Reviewed-by: Sam Ravnborg Signed-off-by: Maxime Ripard --- Documentat

[PATCH v2 4/8] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-07-28 Thread Maxime Ripard
Interactions between bridges, panels, MIPI-DSI host and the component framework are not trivial and can lead to probing issues when implementing a display driver. Let's document the various cases we need too consider, and the solution to support all the cases. Signed-off-by: Maxime R

[PATCH v2 6/8] drm/vc4: dsi: Switch to drm_of_get_bridge

2021-07-28 Thread Maxime Ripard
The new drm_of_get_bridge removes most of the boilerplate we have to deal with. Let's switch to it. Signed-off-by: Maxime Ripard fixup! drm/vc4: dsi: Switch to drm_of_get_bridge --- drivers/gpu/drm/vc4/vc4_drv.c | 2 ++ drivers/gpu/drm/vc4/vc4_dsi.c | 28 2

[PATCH v2 5/8] drm/panel: Create attach and detach callbacks

2021-07-28 Thread Maxime Ripard
. Most drivers have changed significantly since the reverted commit, so we only brought back the calls in the panel bridge to lessen the risk of regressions, and since panel bridge is what we're converging to these days, it's not a big deal anyway. Signed-off-by: Maxime Ripard --- drive

[PATCH v2 8/8] drm/panel: raspberrypi-touchscreen: Remove MIPI-DSI driver

2021-07-28 Thread Maxime Ripard
entirely though, resulting in a completely empty MIPI-DSI device probe. Let's simplify the driver by removing it entirely and just behave as a normal i2c driver. Signed-off-by: Maxime Ripard --- .../drm/panel/panel-raspberrypi-touchscreen.c | 25 +-- 1 file changed, 1 inse

[PATCH v2 7/8] drm/panel: raspberrypi-touchscreen: Use the attach hook

2021-07-28 Thread Maxime Ripard
Now that we have an attach hook available for panels as well, let's use it for the RaspberryPi 7" DSI panel. This now mimics what all the other bridges in a similar situation are doing, and we avoid our probe order issue entirely. Signed-off-by: Maxime Ripard --- .../drm/p

Re: [PATCH 04/10] drm/bridge: Document the probe issue with MIPI-DSI bridges

2021-07-28 Thread Maxime Ripard
Hi Jagan, On Tue, Jul 27, 2021 at 03:12:09PM +0530, Jagan Teki wrote: > On Tue, Jul 20, 2021 at 7:15 PM Maxime Ripard wrote: > > > > Interactions between bridges, panels, MIPI-DSI host and the component > > framework are not trivial and can lead to probing issues when >

Re: [Regression] No framebuffer console on Rpi since 5.14-rc1

2021-07-29 Thread Maxime Ripard
Hi Stefan, On Wed, Jul 28, 2021 at 05:14:38PM +0200, Stefan Wahren wrote: > Hi, > > Am 15.07.21 um 18:35 schrieb Stefan Wahren: > > Hi guys, > > > > starting with Linux 5.14-rc1 the framebuffer console on Raspberry Pi 3/4 > > (no U-Boot, multi_v7_defconfig) isn't available anymore. The display >

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-07 Thread Maxime Ripard
Hi, Adding Jörg, Will and Robin, On Wed, Mar 31, 2021 at 09:21:19AM +0800, Kevin Tang wrote: > > > +static u32 check_mmu_isr(struct sprd_dpu *dpu, u32 reg_val) > > > +{ > > > + struct dpu_context *ctx = &dpu->ctx; > > > + u32 mmu_mask = BIT_DPU_INT_MMU_VAOR_RD | > > > +

Re: [PATCH v4 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2021-04-07 Thread Maxime Ripard
On Wed, Mar 31, 2021 at 09:49:14AM +0800, Kevin Tang wrote: > Hi Maxime, > > Maxime Ripard 于2021年3月24日周三 下午7:13写道: > > > On Mon, Feb 22, 2021 at 09:28:21PM +0800, Kevin Tang wrote: > > > From: Kevin Tang > > > > > > Adds MIPI DSI Controller

Re: [PATCH v4 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver

2021-04-07 Thread Maxime Ripard
On Wed, Mar 31, 2021 at 09:47:12AM +0800, Kevin Tang wrote: > > > diff --git a/drivers/gpu/drm/sprd/Makefile > > b/drivers/gpu/drm/sprd/Makefile > > > index 6c25bfa99..d49f4977b 100644 > > > --- a/drivers/gpu/drm/sprd/Makefile > > > +++ b/drivers/gpu/drm/sprd/Makefile > > > @@ -1,5 +1,8 @@ > > > #

Re: [PATCH 0/4] drm: Generic dumb_map_offset for TTM-based drivers

2021-04-08 Thread Maxime Ripard
On Tue, Apr 06, 2021 at 10:29:38AM +0200, Thomas Zimmermann wrote: > The implementation of drm_driver.dumb_map_offset is the same for several > TTM-based drivers. Provide a common function in GEM-TTM helpers. For the series: Acked-by: Maxime Ripard Maxime signature.asc Descriptio

Re: [PATCH v2 08/10] drm/simpledrm: Acquire clocks from DT device node

2021-04-08 Thread Maxime Ripard
Hi, On Thu, Mar 18, 2021 at 11:29:19AM +0100, Thomas Zimmermann wrote: > Make sure required hardware clocks are enabled while the firmware > framebuffer is in use. > > The basic code has been taken from the simplefb driver and adapted > to DRM. Clocks are released automatically via devres helpers

Re: [PATCH v3 10/11] drm: Use state helper instead of the plane state pointer

2021-04-08 Thread Maxime Ripard
Hi Stephen, On Tue, Mar 30, 2021 at 11:56:15AM -0700, Stephen Boyd wrote: > Quoting Maxime Ripard (2021-03-30 08:35:27) > > Hi Stephen, > > > > On Mon, Mar 29, 2021 at 06:52:01PM -0700, Stephen Boyd wrote: > > > Trimming Cc list way down, sorry if that's to

[PULL] drm-misc-next

2021-04-09 Thread Maxime Ripard
Hi Dave, Daniel, Like you asked, here's this week drm-misc-next PR Maxime drm-misc-next-2021-04-09: drm-misc-next for 5.13: UAPI Changes: Cross-subsystem Changes: Core Changes: - bridge: Fix Kconfig dependency - cmdline: Refuse zero width/height mode - ttm: Ignore signaled move fences,

Re: [PATCH v2 4/5] drm/vc4: hdmi: Enable the scrambler

2021-04-09 Thread Maxime Ripard
Hi Dave, On Thu, Apr 01, 2021 at 12:30:45PM +0100, Dave Stevenson wrote: > > Signed-off-by: Maxime Ripard > > --- > > drivers/gpu/drm/vc4/vc4_hdmi.c | 56 + > > drivers/gpu/drm/vc4/vc4_hdmi_regs.h | 3 ++ > > 2 files changed, 59 in

[PATCH 2/2] drm/vc4: hdmi: Convert to the new clock request API

2021-04-13 Thread Maxime Ripard
The new clock request API allows us to increase the rate of the HSM clock to match our pixel rate requirements while decreasing it when we're done, resulting in a better power-efficiency. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 19 --- drivers/gp

[PATCH 1/2] clk: Introduce a clock request API

2021-04-13 Thread Maxime Ripard
ll the requests are done. * Similarly, clk_round_rate has been adjusted to take the requests into account and return a rate that will be greater or equal to the requested rates. Signed-off-by: Maxime Ripard --- drivers/clk/clk.c | 121 include/li

[PATCH 0/2] clk: Implement a clock request API

2021-04-13 Thread Maxime Ripard
x27;t have an use-case for something else, this should maybe be made more flexible? Let me know what you think Maxime Maxime Ripard (2): clk: Introduce a clock request API drm/vc4: hdmi: Convert to the new clock request API drivers/clk/clk.c

[PATCH v2 2/5] drm/connector: Add helper to compare HDR metadata

2021-04-13 Thread Maxime Ripard
those drivers. Reviewed-by: Harry Wentland Reviewed-by: Jernej Skrabec Signed-off-by: Maxime Ripard --- Changes from v1: - Rebased on latest drm-misc-next tag - Added the tags - Fix build breakage on amdgpu --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 23 ++- drivers/gp

[PATCH v2 4/5] drm/connector: Add a helper to attach the colorspace property

2021-04-13 Thread Maxime Ripard
The intel driver uses the same logic to attach the Colorspace property in multiple places and we'll need it in vc4 too. Let's move that common code in a helper. Signed-off-by: Maxime Ripard --- Changes from v1: - New patch --- drivers/gpu/drm/drm_connector.c

[PATCH v2 1/5] drm/connector: Create a helper to attach the hdr_output_metadata property

2021-04-13 Thread Maxime Ripard
-by: Jernej Skrabec Signed-off-by: Maxime Ripard --- Changes from v1: - Rebased on latest drm-misc-next tag - Added the tags --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +--- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +-- drivers/gpu/drm/drm_connector.c

[PATCH v2 5/5] drm/vc4: hdmi: Signal the proper colorimetry info in the infoframe

2021-04-13 Thread Maxime Ripard
Our driver while supporting HDR didn't send the proper colorimetry info in the AVI infoframe. Let's add the property needed so that the userspace can let us know what the colorspace is supposed to be. Signed-off-by: Maxime Ripard --- Changes from v1: - New patch --- drivers/g

[PATCH v2 3/5] drm/vc4: Add HDR metadata property to the VC5 HDMI connectors

2021-04-13 Thread Maxime Ripard
From: Dave Stevenson Now that we can export deeper colour depths, add in the signalling for HDR metadata. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- Changes from v1: - Rebased on latest drm-misc-next tag --- drivers/gpu/drm/vc4/vc4_hdmi.c | 53

[PATCH v3 0/9] drm/vc4: hdmi: Support the 4k @ 60Hz modes

2021-04-13 Thread Maxime Ripard
ly if there's some modes that can't be reached - Rework the BVB clock computation Maxime Ripard (9): drm/vc4: txp: Properly set the possible_crtcs mask drm/vc4: crtc: Skip the TXP drm/vc4: Rework the encoder retrieval code drm/vc4: hdmi: Prevent clock unbalance drm/vc4: hvs: Ma

[PATCH v3 1/9] drm/vc4: txp: Properly set the possible_crtcs mask

2021-04-13 Thread Maxime Ripard
The current code does a binary OR on the possible_crtcs variable of the TXP encoder, while we want to set it to that value instead. Cc: # v5.9+ Fixes: 39fcb2808376 ("drm/vc4: txp: Turn the TXP into a CRTC of its own") Acked-by: Thomas Zimmermann Signed-off-by: Maxime Ripard --- d

[PATCH v3 4/9] drm/vc4: hdmi: Prevent clock unbalance

2021-04-13 Thread Maxime Ripard
v5.10+ Fixes: 09c438139b8f ("drm/vc4: hdmi: Implement finer-grained hooks") Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 1fda574579af..9c91

[PATCH v3 5/9] drm/vc4: hvs: Make the HVS bind first

2021-04-13 Thread Maxime Ripard
We'll need to have the HVS binding before the HDMI controllers so that we can check whether the firmware allows to run in 4kp60. Reorder a bit the component list, and document the current constraints we're aware of. Acked-by: Dave Stevenson Acked-by: Thomas Zimmermann Signed-off-

[PATCH v3 3/9] drm/vc4: Rework the encoder retrieval code

2021-04-13 Thread Maxime Ripard
d, we can iterate over all the encoders to find their associated CRTC and set the pointer. This is similar to what we're doing to set the possible_crtcs field. Fixes: 875a4d536842 ("drm/vc4: drv: Disable the CRTC at boot time") Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4

[PATCH v3 9/9] drm/vc4: hdmi: Raise the maximum clock rate

2021-04-13 Thread Maxime Ripard
Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index bda12fea0dce..aecda5766a9c 100644 --- a/drivers/gpu/drm/vc4

[PATCH v3 6/9] drm/vc4: hdmi: Properly compute the BVB clock rate

2021-04-13 Thread Maxime Ripard
The BVB clock rate computation doesn't take into account a mode clock of 594MHz that we're going to need to support 4k60. Acked-by: Thomas Zimmermann Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 17 + 1 file

[PATCH v3 7/9] drm/vc4: hdmi: Check and warn if we can't reach 4kp60 frequencies

2021-04-13 Thread Maxime Ripard
Acked-by: Thomas Zimmermann Reviewed-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 31 +++ drivers/gpu/drm/vc4/vc4_hdmi.h | 8 2 files changed, 39 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/g

[PATCH v3 8/9] drm/vc4: hdmi: Enable the scrambler

2021-04-13 Thread Maxime Ripard
The HDMI controller on the BCM2711 includes a scrambler in order to reach the HDMI 2.0 modes that require it. Let's add the support for it. Acked-by: Thomas Zimmermann Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 64 + drivers/gpu/dr

[PATCH v3 2/9] drm/vc4: crtc: Skip the TXP

2021-04-13 Thread Maxime Ripard
# v5.9+ Fixes: 39fcb2808376 ("drm/vc4: txp: Turn the TXP into a CRTC of its own") Acked-by: Thomas Zimmermann Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_

Re: [PATCH 11/12] drm/vc4: Don't set allow_fb_modifiers explicitly

2021-04-14 Thread Maxime Ripard
nit > > this is done automatically as part of plane init, if drivers set the > modifier list correctly. Which is the case here. > > Signed-off-by: Daniel Vetter > Cc: Eric Anholt > Cc: Maxime Ripard Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH 12/12] drm/modifiers: Enforce consistency between the cap an IN_FORMATS

2021-04-14 Thread Maxime Ripard
alanen > Signed-off-by: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature ___ dri-

Re: [PATCH 07/18] drm/vc4: hdmi: Add full range RGB helper

2021-04-14 Thread Maxime Ripard
Hi Thomas, On Mon, Apr 12, 2021 at 11:44:05AM +0200, Thomas Zimmermann wrote: > > > Am 17.03.21 um 16:43 schrieb Maxime Ripard: > > We're going to need to tell whether we want to run with a full or > > limited range RGB output in multiple places in the code, so let&

Re: [PATCH v4 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2021-04-15 Thread Maxime Ripard
On Fri, Apr 09, 2021 at 08:23:19AM +0800, Kevin Tang wrote: > Maxime Ripard 于2021年4月7日周三 下午6:46写道: > > > On Wed, Mar 31, 2021 at 09:49:14AM +0800, Kevin Tang wrote: > > > Hi Maxime, > > > > > > Maxime Ripard 于2021年3月24日周三 下午7:13写道: > > > > &g

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-15 Thread Maxime Ripard
Hi, On Thu, Apr 15, 2021 at 08:18:52AM +0800, Kevin Tang wrote: > Maxime Ripard 于2021年3月24日周三 下午7:10写道: > > > +static struct sprd_dpu *sprd_crtc_init(struct drm_device *drm, > > > + struct drm_plane *primary) > > > +{ > > > + struc

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-15 Thread Maxime Ripard
Hi, On Fri, Apr 09, 2021 at 09:35:07PM +0800, Kevin Tang wrote: > > > > > + } > > > > > + > > > > > + return MODE_OK; > > > > > +} > > > > > + > > > > > +static void sprd_crtc_atomic_enable(struct drm_crtc *crtc, > > > > > +struct drm_atomic_state *state) >

Re: [PATCH v2 08/10] drm/simpledrm: Acquire clocks from DT device node

2021-04-15 Thread Maxime Ripard
Hi, On Thu, Apr 15, 2021 at 09:31:01AM +0200, Thomas Zimmermann wrote: > Am 08.04.21 um 10:13 schrieb Maxime Ripard: > > Hi, > > > > On Thu, Mar 18, 2021 at 11:29:19AM +0100, Thomas Zimmermann wrote: > > > Make sure required hardware clocks are enabled while the fi

Re: [PATCH 2/2] drm/ingenic: Don't request full modeset if property is not modified

2021-04-15 Thread Maxime Ripard
Hi, On Mon, Mar 29, 2021 at 06:50:46PM +0100, Paul Cercueil wrote: > Avoid requesting a full modeset if the sharpness property is not > modified, because then we don't actually need it. > > Fixes: fc1acf317b01 ("drm/ingenic: Add support for the IPU") > Cc: # 5.8+ > Signed-off-by: Paul Cercueil

Re: [PATCH] drm/vc4: remove unused function

2021-04-21 Thread Maxime Ripard
On Thu, Apr 15, 2021 at 04:45:25PM +0800, Jiapeng Chong wrote: > Fix the following clang warning: > > drivers/gpu/drm/vc4/vc4_vec.c:201:1: warning: unused function > 'to_vc4_vec_connector' [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Merged, thanks! Maxime

Re: [PATCH v4 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2021-04-21 Thread Maxime Ripard
Hi, On Mon, Apr 19, 2021 at 12:33:42AM +0800, Kevin Tang wrote: > Maxime Ripard 于2021年4月15日周四 下午4:42写道: > > > > On Fri, Apr 09, 2021 at 08:23:19AM +0800, Kevin Tang wrote: > > > Maxime Ripard 于2021年4月7日周三 下午6:46写道: > > > > > > > On Wed, Mar 3

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-21 Thread Maxime Ripard
On Mon, Apr 19, 2021 at 07:01:00AM +0800, Kevin Tang wrote: > Maxime Ripard 于2021年4月15日周四 下午5:03写道: > > On Thu, Apr 15, 2021 at 08:18:52AM +0800, Kevin Tang wrote: > > > Maxime Ripard 于2021年3月24日周三 下午7:10写道: > > > > > +static struct sprd_dpu *sprd

[PULL] drm-misc-next-fixes

2021-04-22 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week drm-misc-next-fixes PR, for the next merge window Thanks! Maxime drm-misc-next-fixes-2021-04-22: A few fixes for the next merge window, with some build fixes for anx7625 and lt8912b bridges, incorrect error handling for lt8912b and TTM, and one fix for TTM page

Re: [PULL] drm-misc-next-fixes

2021-04-26 Thread Maxime Ripard
Hi Alex, On Thu, Apr 22, 2021 at 12:40:10PM -0400, Alex Deucher wrote: > On Thu, Apr 22, 2021 at 12:33 PM Maxime Ripard wrote: > > > > Hi Dave, Daniel, > > > > Here's this week drm-misc-next-fixes PR, for the next merge window > > > >

[PULL] drm-misc-next-fixes

2021-04-29 Thread Maxime Ripard
Hi Dave, Daniel, Here's this week drm-misc-next-fixes PR Maxime drm-misc-next-fixes-2021-04-29: Two patches in drm-misc-next-fixes this week, one to fix the error handling in TTM when a BO can't be swapped out and one to prevent a wrong dereference in efifb. The following changes since commit a4

Re: [PULL] drm-misc-next-fixes

2021-04-29 Thread Maxime Ripard
On Wed, Apr 28, 2021 at 04:57:26PM -0400, Alex Deucher wrote: > On Mon, Apr 26, 2021 at 3:35 AM Maxime Ripard wrote: > > > > Hi Alex, > > > > On Thu, Apr 22, 2021 at 12:40:10PM -0400, Alex Deucher wrote: > > > On Thu, Apr 22, 2021 at 12:33 PM Maxime Ripard wr

Re: [PATCH] drm/vc4: fix argument ordering in vc4_crtc_get_margins()

2021-04-29 Thread Maxime Ripard
On Wed, Apr 21, 2021 at 01:18:03PM +0300, Dan Carpenter wrote: > Cppcheck complains that the declaration doesn't match the function > definition. Obviously "left" should come before "right". The caller > and the function implementation are done this way, it's just the > declaration which is wrong

Re: [PATCH v4 0/9] drm: Support simple-framebuffer devices and firmware fbs

2021-04-29 Thread Maxime Ripard
card0 and the > native driver's device file is card1. After simpledrm has been kicked out, > only card1 is left. This does not seem to be a practical problem however. Provided that patches 4 to 8 are squashed when merged: Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/2] clk: Implement a clock request API

2021-04-30 Thread Maxime Ripard
Hi Mike, Stephen, On Tue, Apr 13, 2021 at 12:13:18PM +0200, Maxime Ripard wrote: > Hi, > > This is a follow-up of the discussion here: > https://lore.kernel.org/linux-clk/20210319150355.xzw7ikwdaga2dwhv@gilmour/ > > This implements a mechanism to raise and lower clock rates

Re: [PATCH v5 1/6] dt-bindings: display: add Unisoc's drm master bindings

2021-04-30 Thread Maxime Ripard
On Sun, Apr 25, 2021 at 08:36:02PM +0800, Kevin Tang wrote: > From: Kevin Tang > > The Unisoc DRM master device is a virtual device needed to list all > DPU devices or other display interface nodes that comprise the > graphics subsystem > > Unisoc's display pipeline have several components as be

Re: [PATCH v5 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-30 Thread Maxime Ripard
On Sun, Apr 25, 2021 at 08:36:05PM +0800, Kevin Tang wrote: > Adds DPU(Display Processor Unit) support for the Unisoc's display > subsystem. > It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. > > v2: > - Use drm_xxx to replace all DRM_XXX. > - Use kzalloc to replace d

Re: [PATCH v5 6/6] drm/sprd: add Unisoc's drm mipi dsi&dphy driver

2021-04-30 Thread Maxime Ripard
Hi, On Sun, Apr 25, 2021 at 08:36:07PM +0800, Kevin Tang wrote: > Adds dsi host controller support for the Unisoc's display subsystem. > Adds dsi phy support for the Unisoc's display subsystem. > Only MIPI DSI Displays supported, DP/TV/HMDI will be support > in the feature. > > v1: > - Remove d

[PATCH v3 1/5] drm/connector: Create a helper to attach the hdr_output_metadata property

2021-04-30 Thread Maxime Ripard
-by: Jernej Skrabec Signed-off-by: Maxime Ripard --- Changes from v2: - Rebased on current drm-misc-next - Fixed a merge conflict with i915 Changes from v1: - Rebased on latest drm-misc-next tag - Added the tags --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +--- drivers/gpu

[PATCH v3 2/5] drm/connector: Add helper to compare HDR metadata

2021-04-30 Thread Maxime Ripard
those drivers. Reviewed-by: Harry Wentland Reviewed-by: Jernej Skrabec Signed-off-by: Maxime Ripard --- Changes from v2: - Rebased on current drm-misc-next Changes from v1: - Rebased on latest drm-misc-next tag - Added the tags - Fix build breakage on amdgpu --- .../gpu/drm/amd/di

[PATCH v3 3/5] drm/vc4: Add HDR metadata property to the VC5 HDMI connectors

2021-04-30 Thread Maxime Ripard
From: Dave Stevenson Now that we can export deeper colour depths, add in the signalling for HDR metadata. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- Changes from v2: - Rebased on current drm-misc-next Changes from v1: - Rebased on latest drm-misc-next tag

[PATCH v3 4/5] drm/connector: Add a helper to attach the colorspace property

2021-04-30 Thread Maxime Ripard
The intel driver uses the same logic to attach the Colorspace property in multiple places and we'll need it in vc4 too. Let's move that common code in a helper. Signed-off-by: Maxime Ripard --- Changes from v2: - Rebased on current drm-misc-next Changes from v1: - New patch --

[PATCH v3 5/5] drm/vc4: hdmi: Signal the proper colorimetry info in the infoframe

2021-04-30 Thread Maxime Ripard
Our driver while supporting HDR didn't send the proper colorimetry info in the AVI infoframe. Let's add the property needed so that the userspace can let us know what the colorspace is supposed to be. Signed-off-by: Maxime Ripard --- Changes from v2: - Rebased on current drm

Re: [PATCH] drm/msm/dpu: Delete bonkers code

2021-05-03 Thread Maxime Ripard
Hi, On Fri, Apr 30, 2021 at 10:44:53AM -0700, Stephen Boyd wrote: > Quoting Rob Clark (2021-04-30 10:17:39) > > From: Rob Clark > > > > dpu_crtc_atomic_flush() was directly poking it's attached planes in a > > code path that ended up in dpu_plane_atomic_update(), even if the plane > > was not inv

Re: [PATCH 0/2] clk: Implement a clock request API

2021-05-03 Thread Maxime Ripard
Hi Stephen, On Fri, Apr 30, 2021 at 01:59:39PM -0700, Stephen Boyd wrote: > Quoting Maxime Ripard (2021-04-13 03:13:18) > > Hi, > > > > This is a follow-up of the discussion here: > > https://lore.kernel.org/linux-clk/20210319150355.xzw7ikwdaga2dwhv@gilmour/ > >

Re: [PATCH 0/7] drm: Completely remove struct drm_device.pdev

2021-05-03 Thread Maxime Ripard
or > userspace modesetting. Reviewed-by: Maxime Ripard Thanks! Maxime signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/vc4: hdmi: make vc4_hdmi_codec_pdata static

2021-08-18 Thread Maxime Ripard
On Fri, Jul 30, 2021 at 06:26:34PM +0800, Jiapeng Chong wrote: > This symbol is not used outside of vc4_hdmi.c, so marks it static. > > Fix the following sparse warning: > > drivers/gpu/drm/vc4/vc4_hdmi.c:1479:25: warning: symbol > 'vc4_hdmi_codec_pdata' was not declared. Should it be static? >

Re: [PATCH 10/54] dt-bindings: display: panel-lvds: Document panel compatibles

2021-08-18 Thread Maxime Ripard
Hi Rob, Sam, On Wed, Jul 21, 2021 at 08:29:47PM -0600, Rob Herring wrote: > On Wed, Jul 21, 2021 at 04:03:40PM +0200, Maxime Ripard wrote: > > The binding mentions that all the drivers using that driver must use a > > vendor-specific compatible but never enforces it, nor documents

[PATCH v7 00/10] drm/vc4: hdmi: Support the 4k @ 60Hz modes

2021-08-19 Thread Maxime Ripard
about enable_hdmi_4kp60 only if there's some modes that can't be reached - Rework the BVB clock computation Maxime Ripard (10): drm/vc4: hdmi: Remove the DDC probing for status detection drm/vc4: hdmi: Fix HPD GPIO detection drm/vc4: Make vc4_crtc_get_encoder public drm/vc4: crtc:

[PATCH v7 01/10] drm/vc4: hdmi: Remove the DDC probing for status detection

2021-08-19 Thread Maxime Ripard
both, the display during the HPD pulse will clear its scrambler status, and since we won't detect the disconnect/reconnect cycle we will never enable the scrambler back. As our main reason for that DDC probing is gone, let's just remove it. Signed-off-by: Maxime Ripard --- drivers/gp

[PATCH v7 03/10] drm/vc4: Make vc4_crtc_get_encoder public

2021-08-19 Thread Maxime Ripard
We'll need that function in vc4_kms to compute the core clock rate requirements. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 8 drivers/gpu/drm/vc4/vc4_drv.h | 5 + 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_c

[PATCH v7 02/10] drm/vc4: hdmi: Fix HPD GPIO detection

2021-08-19 Thread Maxime Ripard
high, and would fall back to the other methods otherwise. Since we can read the EDIDs when the HPD signal is low on some displays, we changed the detection status from disconnected to connected, and we would ignore an HPD pulse. Fixes: 6800234ceee0 ("drm/vc4: hdmi: Convert to gpiod") S

  1   2   3   4   5   6   7   8   9   10   >