ost
> *host,
> struct exynos_dsi *dsi = host_to_dsi(host);
> struct drm_device *drm = dsi->drm;
>
> - if (dsi->panel) {
> - mutex_lock(&drm->mode_config.mutex);
> - exynos_dsi_bridge_disable(&dsi->bridge);
> - dsi->panel = NULL;
> - dsi->connector.status = connector_status_disconnected;
> - mutex_unlock(&drm->mode_config.mutex);
> - } else {
> - if (dsi->out_bridge->funcs->detach)
> - dsi->out_bridge->funcs->detach(dsi->out_bridge);
> - dsi->out_bridge = NULL;
> - INIT_LIST_HEAD(&dsi->bridge_chain);
> - }
> -
> if (drm->mode_config.poll_enabled)
> drm_kms_helper_hotplug_event(drm);
>
> @@ -1770,7 +1650,6 @@ static int exynos_dsi_probe(struct platform_device
> *pdev)
> init_completion(&dsi->completed);
> spin_lock_init(&dsi->transfer_lock);
> INIT_LIST_HEAD(&dsi->transfer_list);
> - INIT_LIST_HEAD(&dsi->bridge_chain);
>
> dsi->dsi_host.ops = &exynos_dsi_ops;
> dsi->dsi_host.dev = dev;
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
On 05.07.2021 14:00, Jagan Teki wrote:
> On Mon, Jul 5, 2021 at 5:18 PM Marek Szyprowski
> wrote:
>> On 04.07.2021 11:02, Jagan Teki wrote:
>>> Use drm_panel_bridge to replace manual panel and
>>> bridge_chain handling code.
>>>
>>> This makes the d
ay the Exynos
will continue to use it in the current form, while iMX can start using
it as DRM bridge. A bit similar approach is used with exynos_dp driver
and analogix_dp bridge shared with other SoCs.
I hope that later, when the bridge related issue are resolved, the
Exynos can be converted too, so the encoder creation moved to FIMD and
Decon.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
d at (1282): [] __do_softirq+0x528/0x674
softirqs last disabled at (1269): [] irq_exit+0x1dc/0x1e8
---[ end trace 6f32a2fb4294655f ]---
I can do more tests to help fixing this issue. Just let me know what to do.
...
Best regards
--
Marek Szyprowski, PhD
(or as first)
> the dts and drm/exynos patches are applied.
>
> Hmm, maybe it's better to hold on with the drm patch, INTERCONNECT
> is disabled in arch/arm/configs/{multi_v7_defconfig, exynos_defconfig}
> but it is enabled in arch/arm64/configs/defconfig.
I don't think we ne
nnector state %p\n",
> - conn_state);
> + drm_dbg_atomic(conn->dev,
> +"Set [NOFB] for connector state %p\n",
> +conn_state);
>
> return 0;
> }
> @@ -782,9 +800,10 @@ static int drm_atomic_connector_set_property(struct
> drm_connector *connector,
> return connector->funcs->atomic_set_property(connector,
> state, property, val);
> } else {
> - DRM_DEBUG_ATOMIC("[CONNECTOR:%d:%s] unknown property
> [PROP:%d:%s]]\n",
> - connector->base.id, connector->name,
> - property->base.id, property->name);
> + drm_dbg_atomic(connector->dev,
> +"[CONNECTOR:%d:%s] unknown property
> [PROP:%d:%s]]\n",
> +connector->base.id, connector->name,
> +property->base.id, property->name);
> return -EINVAL;
> }
>
> @@ -1282,7 +1301,7 @@ static void complete_signaling(struct drm_device *dev,
> /* If this fails log error to the user */
> if (fence_state[i].out_fence_ptr &&
> put_user(-1, fence_state[i].out_fence_ptr))
> - DRM_DEBUG_ATOMIC("Couldn't clear out_fence_ptr\n");
> + drm_dbg_atomic(dev, "Couldn't clear out_fence_ptr\n");
> }
>
> kfree(fence_state);
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
FB_WRITEL(colortab[(*src >> 5) & bit_mask],
> dst++);
> + FB_WRITEL(colortab[(*src >> 4) & bit_mask],
> dst++);
> + FB_WRITEL(colortab[(*src >> 3) & bit_mask],
> dst++);
> + FB_WRITEL(colortab[(*src >> 2) & bit_mask],
> dst++);
> + FB_WRITEL(colortab[(*src >> 1) & bit_mask],
> dst++);
> + FB_WRITEL(colortab[(*src >> 0) & bit_mask],
> dst++);
> + }
> + break;
> }
> +
> dst1 += p->fix.line_length;
> s += spitch;
> }
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Hi,
On 09.03.2022 09:22, Thomas Zimmermann wrote:
> Am 08.03.22 um 23:52 schrieb Marek Szyprowski:
>> On 23.02.2022 20:38, Thomas Zimmermann wrote:
>>> Improve the performance of cfb_imageblit() by manually unrolling
>>> the inner blitting loop and moving some i
ately. The performance improvements in the original commit do not
> regress by this change.
>
> Signed-off-by: Thomas Zimmermann
> Fixes: 0d03011894d2 ("fbdev: Improve performance of cfb_imageblit()")
> Reported-by: Marek Szyprowski
> Cc: Thomas Zimmermann
> Cc: Javier Ma
rm/exynos/exynos_drm_dsi.c | 241 ++--
> drivers/gpu/drm/exynos/exynos_drm_mic.c | 22 +++
> 4 files changed, 93 insertions(+), 277 deletions(-)
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
tachment.
>
> - Drops panel pointer and panel healpers.
>
> This simplifies the driver and allows all components in the display
> pipeline to be treated as bridges.
>
> Signed-off-by: Jagan Teki
Acked-by: Marek Szyprowski
Tested-by: Marek Szyprowski
> ---
> Changes for v
connector by freeing the state pointer
> and allocate a new empty state object. This can be done using connector
> funcs->reset helper and has to be done before the hotplug even calls.
>
> This patch calls the connector->funcs->reset in panel_bridge_attach.
>
> Sign
bridge attachment more meaningful and avoids the races
> during bridge function calls.
>
> So, move the bridge finding and drm_bridge_attach from DSI to MIC.
>
> Signed-off-by: Jagan Teki
Acked-by: Marek Szyprowski
Tested-by: Marek Szyprowski
> ---
> Changes for v6:
>
tachment.
>
> - Drops panel pointer and iterate the bridge, so-that it can operate
>the normal bridge and panel_bridge in constitutive callbacks.
>
> This simplifies the driver and allows all components in the display
> pipeline to be treated as bridges.
>
> Signed-off-by: Jag
ate pre_enable from enable function.
>
> - Separate post_disable from disable function.
>
> Convert it.
>
> Signed-off-by: Jagan Teki
Acked-by: Marek Szyprowski
Tested-by: Marek Szyprowski
> ---
> Changes for v6, v5:
> - none
> Changes for v4:
> - add pre_en
On 03.03.2022 17:36, Jagan Teki wrote:
> The new support drm bridges are moving towards atomic functions.
>
> Replace atomic version of functions to continue the transition
> to the atomic API.
>
> Signed-off-by: Jagan Teki
Acked-by: Marek Szyprowski
Tested-by
NT, 0);
> - system_freezable_power_efficient_wq =
> alloc_workqueue("events_freezable_power_efficient",
> - WQ_FREEZABLE | WQ_POWER_EFFICIENT,
> - 0);
> + system_freezable_wq =
> + alloc_workqueu
gt;> How about reverting it until this patch series is merged after fixing the
>> real user problem?
> The Exynos5433 DECON bindings were already merged by Rob, so someone
> would need to send a revert. However this does not answer the actual
> question - whether the "dsd&quo
but it adds/removes panel/bridge
> dynamically, so it creates drm_device without waiting for downstream sink.
Right, this patch breaks Exynos DSI driver operation. Without it, the
whole series works fine on all Exynos based test boards.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
ION (G2D) SUPPORT
> -M: Andrzej Hajda
> +M: Łukasz Stelmach
> L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers)
> L: linux-me...@vger.kernel.org
> S: Maintained
> @@ -2570,7 +2570,8 @@ S: Maintained
> F: drivers/media/platform/s5p-jpeg/
>
Hi Maxime,
On 22.09.2021 10:53, Maxime Ripard wrote:
> On Fri, Sep 17, 2021 at 02:35:05PM +0200, Marek Szyprowski wrote:
>> On 13.09.2021 12:30, Andrzej Hajda wrote:
>>> W dniu 10.09.2021 o 12:12, Maxime Ripard pisze:
>>>> Without proper care and an agreement bet
() if no
TE-gpio is found.
Fixes: ee6c8b5afa62 ("drm/exynos: Replace legacy gpio interface for gpiod
interface")
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/
is the only difference between v4 and v5 and updated 'drm: of: Lookup if
child node has panel or bridge'. In such case the board freezes during
the drm initialization.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Hi Jagan,
On 21.01.2022 12:40, Jagan Teki wrote:
> On Fri, Jan 21, 2022 at 5:06 PM Marek Szyprowski
> wrote:
>> On 17.01.2022 09:42, Jagan Teki wrote:
>>> Updated series about drm bridge conversion of exynos dsi.
>>>
>>> Previous version can be accessibl
g the conversion to gpiod API.
Fixes: ee6c8b5afa62 ("drm/exynos: Replace legacy gpio interface for gpiod
interface")
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exyn
rr_unregister_audio;
> + }
> +
> return 0;
>
> +err_unregister_audio:
> + adv7511_audio_exit(adv7511);
> + drm_bridge_remove(&adv7511->bridge);
> err_unregister_cec:
> i2c_unregister_device(adv7511->i2c_cec);
> clk_disable_unprepare(adv7511->cec_clk);
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Hi Mexime,
On 29.10.2021 10:05, Maxime Ripard wrote:
> On Fri, Oct 29, 2021 at 08:23:45AM +0200, Marek Szyprowski wrote:
>> On 25.10.2021 17:15, Maxime Ripard wrote:
>>> In order to avoid any probe ordering issue, the best practice is to move
>>> the secondary MIPI-
handle drm bridge functionalities in order to DSI
> Host to Interface bridge.
>
> This patch convert the existing to a drm bridge driver with a
> built-in encoder support for compatibility with existing
> component drivers.
>
> Signed-off-by: Jagan Teki
> ---
> Note:
> Hi Mar
Hi Jagan,
On 22.11.2021 15:21, Jagan Teki wrote:
> On Mon, Nov 22, 2021 at 7:45 PM Marek Szyprowski
> wrote:
>> On 22.11.2021 08:06, Jagan Teki wrote:
>>> Some display panels would come up with a non-DSI output, those
>>> can have an option to connect the
e.dts
> which includes arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi.
>
> In this dtsi there is a "sil,sii8620" bridge.
Sii8620 bridge is attached to the HDMI display path. That's completely
different from the DSI display path modified by this patchset.
Best regar
On 22.11.2021 15:55, Jagan Teki wrote:
> On Mon, Nov 22, 2021 at 7:59 PM Jagan Teki wrote:
>> On Mon, Nov 22, 2021 at 7:51 PM Jagan Teki
>> wrote:
>>> On Mon, Nov 22, 2021 at 7:45 PM Marek Szyprowski
>>> wrote:
>>>> On 22.11.2021 08:06, Jagan Teki w
On 22.11.2021 16:07, Marek Szyprowski wrote:
> On 22.11.2021 15:55, Jagan Teki wrote:
>> On Mon, Nov 22, 2021 at 7:59 PM Jagan Teki
>> wrote:
>>> On Mon, Nov 22, 2021 at 7:51 PM Jagan Teki
>>> wrote:
>>>> On Mon, Nov 22, 2021 at 7:45 PM Marek Szyp
Hi Jagan,
On 24.11.2021 06:32, Jagan Teki wrote:
> On Mon, Nov 22, 2021 at 9:34 PM Marek Szyprowski
> wrote:
>> On 22.11.2021 16:07, Marek Szyprowski wrote:
>>> On 22.11.2021 15:55, Jagan Teki wrote:
>>>> On Mon, Nov 22, 2021 at 7:59 PM Jagan Teki
>>>&g
exynos: dsi: Separate pre_enable, post_disable code
>drm: exynos: dsi: Switch to atomic funcs
>drm: exynos: dsi: Get the mode from bridge
>drm: exynos: dsi: Move DSI init in bridge enable
>
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 240
> 1 file changed, 75 insertions(+), 165 deletions(-)
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Hi Jagan,
On 13.12.2021 13:08, Jagan Teki wrote:
> On Mon, Dec 13, 2021 at 5:34 PM Marek Szyprowski
> wrote:
>> On 12.12.2021 19:14, Jagan Teki wrote:
>>> Updated series about drm bridge conversion of exynos dsi.
>>>
>>> Patch 1: panel checker
>>&g
Hi Jagan,
On 13.12.2021 13:31, Jagan Teki wrote:
> On Mon, Dec 13, 2021 at 5:42 PM Marek Szyprowski
> wrote:
>> On 13.12.2021 13:08, Jagan Teki wrote:
>>> On Mon, Dec 13, 2021 at 5:34 PM Marek Szyprowski
>>> wrote:
>>>> On 12.12.2021 19:14, Jagan
Hi Jagan,
On 13.12.2021 14:56, Jagan Teki wrote:
> On Mon, Dec 13, 2021 at 6:51 PM Marek Szyprowski
> wrote:
>> On 13.12.2021 13:31, Jagan Teki wrote:
>>> On Mon, Dec 13, 2021 at 5:42 PM Marek Szyprowski
>>> wrote:
>>>> On 13.12.2021 13:08, Jagan Teki
Hi Jagan,
On 14.12.2021 11:47, Jagan Teki wrote:
> On Mon, Dec 13, 2021 at 7:42 PM Marek Szyprowski
> wrote:
>> On 13.12.2021 14:56, Jagan Teki wrote:
>>> On Mon, Dec 13, 2021 at 6:51 PM Marek Szyprowski
>>> wrote:
>>>> On 13.12.2021 13:31, Jagan Teki
ust after applying the "[PATCH v2] drm: bridge:
tc358764: Use drm panel_bridge API" patch on top of linux-next.
In all cases the I had "drm: of: Lookup if child node has panel or
bridge" patch applied.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Hi Jagan,
On 15.12.2021 13:57, Jagan Teki wrote:
> On Wed, Dec 15, 2021 at 5:31 PM Marek Szyprowski
> wrote:
>> On 15.12.2021 11:15, Jagan Teki wrote:
>>> Updated series about drm bridge conversion of exynos dsi.
>>> Previous version can be accessible, here [1].
&g
Hi Jagan,
On 15.12.2021 15:56, Jagan Teki wrote:
> On Wed, Dec 15, 2021 at 7:49 PM Marek Szyprowski
> wrote:
>> On 15.12.2021 13:57, Jagan Teki wrote:
>>> On Wed, Dec 15, 2021 at 5:31 PM Marek Szyprowski
>>> wrote:
>>>> On 15.12.2021 11:15, Jagan
Hi Jagan,
On 18.12.2021 00:16, Marek Szyprowski wrote:
> On 15.12.2021 15:56, Jagan Teki wrote:
>> On Wed, Dec 15, 2021 at 7:49 PM Marek Szyprowski
>> wrote:
>>> On 15.12.2021 13:57, Jagan Teki wrote:
>>>> On Wed, Dec 15, 2021 at 5:31 PM Marek Szyprowski
&g
in the following
thread:
http://thread.gmane.org/gmane.linux.kernel.samsung-soc/49743
I plan to propose an API based on DRM object/properties, which will be
similar to KMS atomic API. I will let you know when I have it ready for
presenting in public.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
example
blending).
Signed-off-by: Marek Szyprowski
---
drivers/gpu/drm/Makefile| 3 +-
drivers/gpu/drm/drm_atomic.c| 5 +
drivers/gpu/drm/drm_crtc.c | 6 +
drivers/gpu/drm/drm_crtc_internal.h | 12 +
drivers/gpu/drm/drm_fbproc.c| 754
-off-by: Marek Szyprowski
---
drivers/gpu/drm/exynos/Kconfig | 1 -
drivers/gpu/drm/exynos/exynos_drm_drv.c | 3 +-
drivers/gpu/drm/exynos/exynos_drm_rotator.c | 353 +++-
drivers/gpu/drm/exynos/exynos_drm_rotator.h | 19 --
4 files changed, 194
example
blending).
Signed-off-by: Marek Szyprowski
---
include/drm/drm.h | 13 ++
include/drm/drm_mode.h | 39 ++
xf86drmMode.c | 345 +
xf86drmMode.h | 37 ++
4 files changed, 434 insertions(+)
diff --git a/include
2. add more documentation, especially to the kernel docs
3. add more userspace examples
Best regards
Marek Szyprowski
Samsung R&D Institute Poland
Marek Szyprowski (2):
drm: add support for framebuffer processor objects
drm/exynos: register rotator as fbproc instead of custom ipp framewo
This is simple example how DRM FBProc API can be used from
userspace. The code allocates 2 dumb framebuffers, fill first with
test pattern and then performs 180 degree rotation of the image data.
TODO: add code to release all allocated resources
Signed-off-by: Marek Szyprowski
---
rotate.c
eat work!
>
> With best wishes,
> Tobias
>
>
> Marek Szyprowski wrote:
>> Dear all,
>>
>> This is the initial proposal for extending DRM API with generic support for
>> hardware modules, which can be used for processing image data from the one
>>
;
>
> - regmap_read(ctx->sysreg, SYSREG_GSCBLK_CFG1, &gscblk_cfg);
> + ret = regmap_read(ctx->sysreg, SYSREG_GSCBLK_CFG1, &gscblk_cfg);
> + if (ret) {
> + DRM_ERROR("gsc: Fail to read system register\n");
> + return;
>
7251/
https://patchwork.kernel.org/patch/4677941/
https://patchwork.kernel.org/patch/4677401/
It looks that my idea was a bit ahead of its time ;)
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Hi Linus,
On 2019-06-10 01:13, Linus Walleij wrote:
> This converts the Analogix display port to use GPIO descriptors
> instead of DT-extracted numbers.
>
> Cc: Douglas Anderson
> Cc: Sean Paul
> Cc: Marek Szyprowski
> Cc: Enric Balletbo i Serra
> Signed-off-by: L
+17,7 @@ Required properties:
> + amlogic,meson8b-mali
> + amlogic,meson-gxbb-mali
> + amlogic,meson-gxl-mali
> + + samsung,exynos3250-mali
I would prefer 'samsung,exynos4-mali', because historically Exynos4 was
the first SoC with Mali400 and such prefix is
Hi Krzysztof,
On 2019-06-19 12:08, Krzysztof Kozlowski wrote:
> On Wed, 19 Jun 2019 at 12:01, Marek Szyprowski
> wrote:
>> Hi Krzysztof,
>>
>> On 2019-06-18 21:05, Krzysztof Kozlowski wrote:
>>> Add vendor compatibles for specific implementation of Mali Utgar
lock_is_held_type+0x44/0x64
...
Reported-by: Marian Mihailescu
Fixes: 5d99cc59a3c6 ("ARM: dts: exynos: Move Exynos5250 and Exynos5420 nodes
under soc")
Fixes: b04a62d3ade3 ("ARM: dts: exynos: Add bus nodes using VDD_INT for
Exynos542x SoC")
Signed-off-by: Marek Szyprowski
--
nterrupt
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos4412.dtsi | 16
1 file changed, 16 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4412.dtsi
b/arch/arm/boot/dts/exynos4412.dtsi
index e5c041ec0756..f01c57cc895e 100644
--- a/arch/arm/boot/dts/exynos4412
l not happen anymore ;)
> With this patch modetest worked well.
> BTW, this change may affect Exynos4 series - which have different
> synchronization way to update shadow registers - so could you or someone else
> who has Exynos4xxx based board check it on Odroid-u3 board? I have no
clock CLK_ACLK133>;
>> clock-names = "bus";
>> operating-points-v2 = <&bus_fsys_opp_table>;
>> + #interconnect-cells = <0>;
>> status = "disabled";
>> };
>>
>> @@ -491,6 +498,7 @@
>> clocks = <&clock CLK_ACLK100>;
>> clock-names = "bus";
>> operating-points-v2 = <&bus_peri_opp_table>;
>> + #interconnect-cells = <0>;
>> status = "disabled";
>> };
>>
>> @@ -499,6 +507,7 @@
>> clocks = <&clock CLK_SCLK_MFC>;
>> clock-names = "bus";
>> operating-points-v2 = <&bus_leftbus_opp_table>;
>> + #interconnect-cells = <0>;
>> status = "disabled";
>> };
>>
>> --
>> 2.17.1
>>
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
> on atomic API then atomic_check is the proper helper.
>
>> 2. Where this requirement comes from? As Marek says it breaks Samsung
>> platforms and is against DSIM specification[1]:
> At least the bridge chain starting from LCDIF+DSIM requires active high sync.
Then please make this specific to the imx variant. The current version
breaks DSI operation on all Exynos based boards.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
On 13.06.2022 13:34, Jagan Teki wrote:
> On Mon, Jun 13, 2022 at 5:02 PM Marek Szyprowski
> wrote:
>> On 13.06.2022 13:17, Jagan Teki wrote:
>>> On Wed, May 11, 2022 at 4:01 PM Andrzej Hajda
>>> wrote:
>>>> On 04.05.2022 13:40, Jagan Teki wrote:
>
Hi Laurent,
On 19.04.2022 19:37, Laurent Pinchart wrote:
> On Tue, Apr 19, 2022 at 06:16:07PM +0200, Robert Foss wrote:
>> On Tue, 19 Apr 2022 at 11:41, Jagan Teki wrote:
>>> On Tue, Apr 19, 2022 at 2:44 PM Marek Szyprowski
>>> wrote:
>>>> If panel_b
;> I really don't have a clear idea of which driver would need to be switched
>>> over though. Could someone (Jagan?) let me know where it would be needed?
>> sun6i_mipi_dsi
> It doesn't look like sun6i_mipi_dsi is using devm_drm_of_get_bridge at all?
>
>> exynos_drm_dsi
> If you reference 711c7adc4687, I don't see why we would need to switch
> it back to the old behaviour. It wasn't iterating over its child node
> before, so what does the switch to drm_of_get_bridge broke exactly?
It broke getting the panel if it is a direct child of the DSI device
node. It worked before because it used following code:
dsi->panel = of_drm_find_panel(device->dev.of_node);
which got replaced by devm_drm_of_get_bridge().
>> mcde_dsi (as of now)
> Yeah, we do need to revert 3730bc6147b0 and 3d7039e1e649
>
> Maxime
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
ff-by: Jagan Teki
This restores Exynos DSI driver operation in linux-next after the
mentioned commits went via drm-misc-fixes tree.
Tested-by: Marek Szyprowski
> ---
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 12 +++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
a bridge attached next to DSI. See devm_drm_of_get_bridge()
function, it does exactly the same things (managed panel_bridge or
simple pointer to the real next bridge). I agree that this is not very
obvious at the first sight, but that's how the code is now structured.
Please queue this to drm-misc-next, so the Exynos DSI will be again
operational after merging the drm-misc-fixes and drm-misc-next.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Hi Jagan,
On 04.05.2022 11:16, Jagan Teki wrote:
> Hi Marek,
>
> On Tue, Apr 12, 2022 at 3:15 PM Marek Szyprowski
> wrote:
>> Hi Jagan,
>>
>> On 08.04.2022 18:20, Jagan Teki wrote:
>>> Samsung MIPI DSIM controller is common DSI IP that can be used in va
t this insane per-order call chain of the pre_enable()
operations is completely useless for the DSI hardware and noone pointed
how to solve this. Exynos DSI (and VC4) called those operations directly
to achieve proper order. So what happened? Now Exynos DSI got converted
to the generic bridge call chain. To get it working with existing hw,
the order of the bridges has been hacked. Probably in the next few
releases more mess will come to get around this known issue, especially
when support for the next set of imx boards is added.
I'm really open to help fixing this issue. I've spent a lot of time
analyzing this code and I have boards to test. Just please give me some
advice how to avoid this reverse-order call chain of the pre_enable()
operations in the widely accepted, non-hacky way.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Hi Dave,
On 06.05.2022 12:50, Dave Stevenson wrote:
> On Fri, 6 May 2022 at 09:57, Marek Szyprowski
> wrote:
>> On 05.05.2022 13:55, Alexander Stein wrote:
>>> Am Donnerstag, 5. Mai 2022, 09:38:48 CEST schrieb Jagan Teki:
>>>> On Thu, May 5, 2022 at 12:57 PM
+{
> + platform_driver_unregister(&dsi_driver);
> +}
> +module_exit(samsung_mipi_dsim_exit);
> +
> MODULE_AUTHOR("Jagan Teki ");
> MODULE_DESCRIPTION("Samsung MIPI DSIM controller bridge");
> MODULE_LICENSE("GPL");
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
pecific operations and other glue calls will invoke
>on associate code areas.
>
> v2:
> * fixed exynos dsi driver conversion (Marek Szyprowski)
> * updated commit message
> * updated MAINTAINERS file
>
> v1:
> * Don't maintain component_ops in bridge driver
> * Don&
per_bridge_destroy_state,
> .atomic_reset = drm_atomic_helper_bridge_reset,
> + .atomic_check = samsung_dsim_atomic_check,
> .atomic_pre_enable = samsung_dsim_atomic_pre_enable,
> .atomic_enable = samsung_dsim_atomic_enable,
> .atomic_disable = samsung_dsim_atomic_disable,
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
pecific operations and other glue calls will invoke
>on associate code areas.
>
> v2:
> * fixed exynos dsi driver conversion (Marek Szyprowski)
> * updated commit message
> * updated MAINTAINERS file
>
> v1:
> * Don't maintain component_ops in bridge driver
> * Don&
ything works fine
without the bridge chain order hacks.
Feel free to add:
Tested-by: Marek Szyprowski
The only remaining thing to resolve is the moment of enabling DSI host.
The proper sequence is:
1. host power on, 2. device power on, 3. host init, 4. device init, 5.
video enable.
#1 is do
ret;
> - dsi->state |= DSIM_STATE_INITIALIZED;
> - }
> + ret = samsung_dsim_init(dsi);
> + if (ret)
> + return ret;
>
> ret = mipi_dsi_create_packet(&xfer.packet, msg);
> if (ret < 0)
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
On 11.05.2022 17:47, Marek Vasut wrote:
> On 5/11/22 16:58, Marek Szyprowski wrote:
>> Hi Dave,
>>
>> On 05.04.2022 13:43, Dave Stevenson wrote:
>>> On Fri, 18 Mar 2022 at 12:25, Dave Stevenson
>>> wrote:
>>>> On Fri, 4 Mar 2022 at 15:18, Dave
rm: dsi: Attach in_bridge in MIC driver")
Signed-off-by: Marek Szyprowski
---
A few words of comment. The mentioned commit has my Tested-by tag and
indeed I gave it. However that time due to remote work and incorrect
camera configuration in the office I was not able to check if the board
r
Hi Dave,
On 11.05.2022 17:47, Dave Stevenson wrote:
> On Wed, 11 May 2022 at 15:58, Marek Szyprowski
> wrote:
>> On 05.04.2022 13:43, Dave Stevenson wrote:
>>> On Fri, 18 Mar 2022 at 12:25, Dave Stevenson
>>> wrote:
>>>> On Fri, 4 Mar 2022 at 15:18,
On 11.05.2022 17:02, Marek Szyprowski wrote:
> On 04.05.2022 13:40, Jagan Teki wrote:
>> Host transfer() in DSI master will invoke only when the DSI commands
>> are sent from DSI devices like DSI Panel or DSI bridges and this
>> host transfer wouldn't invoke for I2
Dear All,
On 31.03.2022 16:22, Robert Foss wrote:
> On Fri, 25 Mar 2022 at 17:04, Adam Ford wrote:
>> On Fri, Mar 25, 2022 at 10:00 AM Marek Szyprowski
>> wrote:
>>> On 03.03.2022 17:36, Jagan Teki wrote:
>>>> Updated series about drm bridge conversion of ex
ynos_drm_dsi.c | 1704 +---
> include/drm/bridge/samsung-dsim.h | 97 +
> 8 files changed, 1982 insertions(+), 1649 deletions(-)
> create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c
> create mode 100644 include/drm/bridge/samsung-dsim.h
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
On 11.04.2022 16:39, Adam Ford wrote:
> On Mon, Apr 11, 2022 at 8:56 AM Marek Szyprowski
> wrote:
>> On 08.04.2022 18:20, Jagan Teki wrote:
>>> This series supports common bridge support for Samsung MIPI DSIM
>>> which is used in Exynos and i.MX8MM SoC's.
&g
to get it to the same working state as
before this patch (the next patches however break it even further):
commit e358ee6239305744062713c5aa2e8d44f740b81a (HEAD)
Author: Marek Szyprowski
Date: Tue Apr 12 11:30:26 2022 +0200
drm: exynos: dsi: fixup driver after conversion
Signed-off-by: Marek Szyprows
samsung_dsim_plat_remove(dsi);
> + else
> + mipi_dsi_host_unregister(&dsi->dsi_host);
>
> return 0;
> }
> diff --git a/include/drm/bridge/samsung-dsim.h
> b/include/drm/bridge/samsung-dsim.h
> index 59a43f9c4477..eca7eacb5910 100644
> --- a/include/drm/bridge/samsung-dsim.h
> +++ b/include/drm/bridge/samsung-dsim.h
> @@ -39,6 +39,7 @@ struct samsung_dsim_driver_data {
> unsigned int wait_for_reset;
> unsigned int num_bits_resol;
> const unsigned int *reg_values;
> + bool platform_init;
> };
>
> struct samsung_dsim_host_ops {
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Dear All,
On 07.04.2022 13:24, Marek Szyprowski wrote:
> On 31.03.2022 16:22, Robert Foss wrote:
>> On Fri, 25 Mar 2022 at 17:04, Adam Ford wrote:
>>> On Fri, Mar 25, 2022 at 10:00 AM Marek Szyprowski
>>> wrote:
>>>> On 03.03.2022 17:36, Jagan Teki wrote
needed.
Fixes: 934aef885f9d ("drm: bridge: panel: Reset the connector state pointer")
Signed-off-by: Marek Szyprowski
---
Here is a bit more backgroud on this issue is available in this thread:
https://lore.kernel.org/all/f0474a95-4ba3-a74f-d7de-ef7aab12b...@samsung.com/
---
drivers/gpu/
k initialization issue
> * fix header includes in proper way
>
> v2:
> * fixed exynos dsi driver conversion (Marek Szyprowski)
> * updated commit message
> * updated MAINTAINERS file
>
> v1:
> * don't maintain component_ops in bridge driver
> * don't maintain pla
Hi All,
On 02.09.2022 12:47, Marek Szyprowski wrote:
> On 29.08.2022 20:40, Jagan Teki wrote:
>> Samsung MIPI DSIM controller is common DSI IP that can be used in
>> various
>> SoCs like Exynos, i.MX8M Mini/Nano.
>>
>> In order to access this DSI controller betw
Hi Jagan,
On 06.09.2022 21:07, Jagan Teki wrote:
> On Mon, Sep 5, 2022 at 4:54 PM Marek Szyprowski
> wrote:
>> On 02.09.2022 12:47, Marek Szyprowski wrote:
>>> On 29.08.2022 20:40, Jagan Teki wrote:
>>>> Samsung MIPI DSIM controller is common DSI IP that can
Hi Jagan,
On 13.09.2022 19:29, Jagan Teki wrote:
> On Wed, Sep 7, 2022 at 3:34 PM Marek Szyprowski
> wrote:
>> On 06.09.2022 21:07, Jagan Teki wrote:
>>> On Mon, Sep 5, 2022 at 4:54 PM Marek Szyprowski
>>> wrote:
>>>> On 02.09.2022 12:47, Marek Szyprows
Hi Jagan,
On 14.09.2022 11:39, Jagan Teki wrote:
> On Wed, Sep 14, 2022 at 2:51 PM Marek Szyprowski
> wrote:
>> On 13.09.2022 19:29, Jagan Teki wrote:
>>> On Wed, Sep 7, 2022 at 3:34 PM Marek Szyprowski
>>> wrote:
>>>> On 06.09.2022 21:07, Jagan Teki w
Hi Jagan,
On 16.09.2022 12:21, Jagan Teki wrote:
> On Fri, Sep 16, 2022 at 1:58 PM Marek Szyprowski
> wrote:
>> On 14.09.2022 11:39, Jagan Teki wrote:
>>> On Wed, Sep 14, 2022 at 2:51 PM Marek Szyprowski
>>> wrote:
>>>> On 13.09.2022 19:29, Jagan Teki w
zation
>drm: bridge: samsung-dsim: Add atomic_check
>drm: bridge: samsung-dsim: Add platform PLL_P (PMS_P) offset
>drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts
>drm: bridge: samsung-dsim: Add input_bus_flags
>dt-bindings: display:
lways register
exynos_dsi driver first (even if the kernel is booted on non-exynos board).
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
sim_init(dsi);
> - if (ret)
> - return ret;
> - dsi->state |= DSIM_STATE_INITIALIZED;
> - }
> + ret = samsung_dsim_init(dsi);
> + if (ret)
> + return ret;
>
> ret = mipi_dsi_create_packet(&xfer.packet, msg);
> if (ret < 0)
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
On 18.11.2019 11:35, Daniel Vetter wrote:
> No in-tree users left.
>
> Signed-off-by: Daniel Vetter
> Cc: Pawel Osciak
> Cc: Marek Szyprowski
> Cc: Kyungmin Park
> Cc: Tomasz Figa
> Cc: linux-me...@vger.kernel.org
Acked-by: Marek Szyprowski
> --
> Ack for
> + /*
> + * Restore the bridge_chain so the bridge detach procedure can happen
> + * normally.
> + */
> + list_splice(&dsi->bridge_chain, &dsi->encoder->bridge_chain);
> vc4_dsi_encoder_destroy(dsi->encoder);
>
> if
Hi Boris,
On 16.12.2019 15:55, Boris Brezillon wrote:
> On Mon, 16 Dec 2019 14:54:25 +0100
> Marek Szyprowski wrote:
>> On 03.12.2019 15:15, Boris Brezillon wrote:
>>> So that each element in the chain can easily access its predecessor.
>>> This will be needed to
Hi Boris,
On 16.12.2019 16:25, Boris Brezillon wrote:
> On Mon, 16 Dec 2019 16:02:36 +0100
> Marek Szyprowski wrote:
>> Hi Boris,
>>
>> On 16.12.2019 15:55, Boris Brezillon wrote:
>>> On Mon, 16 Dec 2019 14:54:25 +0100
>>> Marek Szyprowski wrote:
>&
Hi Boris,
On 24.12.2019 11:03, Boris Brezillon wrote:
> On Tue, 24 Dec 2019 10:49:36 +0100
> Boris Brezillon wrote:
>> On Tue, 24 Dec 2019 10:44:22 +0100
>> Boris Brezillon wrote:
>>> On Tue, 24 Dec 2019 10:16:49 +0100
>>> Andrzej Hajda wrote:
>>>
drm_bridge_chain_*() operations.
Signed-off-by: Marek Szyprowski
Fixes: 05193dc38197 ("drm/bridge: Make the bridge chain a double-linked list")
---
This patch is a result of the following discussion:
https://www.spinics.net/lists/dri-devel/msg239256.html
---
drivers/gpu/drm/exynos/exynos_drm_
Hi All,
On 27.12.2019 11:25, Marek Szyprowski wrote:
> On 24.12.2019 11:03, Boris Brezillon wrote:
>> On Tue, 24 Dec 2019 10:49:36 +0100
>> Boris Brezillon wrote:
>>> On Tue, 24 Dec 2019 10:44:22 +0100
>>> Boris Brezillon wrote:
>>>> On Tue, 24 Dec
1 - 100 of 1071 matches
Mail list logo
