[PATCH] drm mode: fix drmIoctl wrapper

2011-06-05 Thread Marcin Slusarz
Both drmIoctl and ioctl define second argument as unigned long, but DRM_IOCTL do not. Debugging/tracing tools (like strace or valgrind) on 64-bit machines see different request value for ioctls with 32nd bit set, because casting signed int to unsigned long extends 32nd bit to upper word, so 0x8000

[PATCH] drm mode: fix drmIoctl wrapper

2011-06-19 Thread Marcin Slusarz
On Sun, Jun 05, 2011 at 07:28:20PM +0200, Marcin Slusarz wrote: > Both drmIoctl and ioctl define second argument as unigned long, but > DRM_IOCTL do not. > > Debugging/tracing tools (like strace or valgrind) on 64-bit machines see > different request value for ioctls with 32nd b

Reverting rc6 by default

2011-06-21 Thread Marcin Slusarz
On Tue, Jun 21, 2011 at 08:48:55PM +0200, Francesco Allertsen wrote: > On Tue, Jun 21, 2011 at 11:29:41AM -0700, Jesse Barnes wrote: > > Use netconsole. Documentation/networking/netconsole.txt has all the > > gory details. > > I have used netconsole, with that documentation, but it doesn't show m

nouveau_fan_update: possible circular locking dependency detected

2014-03-09 Thread Marcin Slusarz
[ 326.168487] == [ 326.168491] [ INFO: possible circular locking dependency detected ] [ 326.168496] 3.13.6 #1270 Not tainted [ 326.168500] --- [ 326.168504] ldconfig/22297 is trying to acqu

nouveau_fan_update: possible circular locking dependency detected

2014-03-13 Thread Marcin Slusarz
On Thu, Mar 13, 2014 at 09:38:45AM -0400, Ilia Mirkin wrote: > On Sun, Mar 9, 2014 at 10:51 AM, Marcin Slusarz > wrote: > > [ 326.168487] == > > [ 326.168491] [ INFO: possible circular locking dependency detected ] > &g

libdrm: Fix some warnings reported by clang's scan-build tool

2012-07-13 Thread Marcin Slusarz
On Fri, Jul 13, 2012 at 05:49:12PM +0200, Johannes Obermayr wrote: > > Patches 1 to 4 were sent to mesa-dev. And you chose to ignore most of my comments. Fine. Don't expect further reviews from me. Marcin

drm/nouveau: crash regression in 3.5

2012-07-24 Thread Marcin Slusarz
On Mon, Jul 23, 2012 at 08:01:14PM +0200, Ortwin Gl?ck wrote: > Hi, > > My HP Elitebook 8540w now crashes on boot with 3.5. All works fine with > 3.4. Bisected to the following commit: > > 20abd1634a6e2eedb84ca977adea56b8aa06cc3e is the first bad commit > commit 20abd1634a6e2eedb84ca977adea56b8a

drm/nouveau: crash regression in 3.5

2012-07-24 Thread Marcin Slusarz
On Tue, Jul 24, 2012 at 07:22:52PM +0200, Ortwin Gl?ck wrote: > On 24.07.2012 19:00, Marcin Slusarz wrote: > > Please post the crash log. > > Sorry, I was not precise: it boots until drm performs modesetting (so it > seems). The screen goes black and the machine is dead. So the

drm/nouveau: crash regression in 3.5

2012-07-25 Thread Marcin Slusarz
nic. Note that you can hit an oops in drm_handle_vblank because patch from http://lists.freedesktop.org/archives/dri-devel/2012-May/023498.html has not been applied (yet?). -- From: Marcin Slusarz Date: Wed, 25 Jul 2012 20:07:22 +0200 Subject: [PATCH] drm/nouveau: init vblank requests list Fixes kern

drm/nouveau: crash regression in 3.5

2012-07-26 Thread Marcin Slusarz
On Thu, Jul 26, 2012 at 02:56:22PM +0200, Ortwin Gl?ck wrote: > On 25.07.2012 20:42, Marcin Slusarz wrote: > > Good, below patch should fix this panic. > > > > Note that you can hit an oops in drm_handle_vblank because patch from > > http://lists.freedesktop.org/archive

drm/nouveau: crash regression in 3.5

2012-07-29 Thread Marcin Slusarz
On Thu, Jul 26, 2012 at 02:56:22PM +0200, Ortwin Gl?ck wrote: > On 25.07.2012 20:42, Marcin Slusarz wrote: > > Good, below patch should fix this panic. > > > > Note that you can hit an oops in drm_handle_vblank because patch from > > http://lists.freedesktop.org/archive

drm/nouveau: crash regression in 3.5

2012-07-30 Thread Marcin Slusarz
On Mon, Jul 30, 2012 at 01:16:37PM +0200, Ortwin Gl?ck wrote: > On 29.07.2012 22:15, Marcin Slusarz wrote: > > No, the real problem is: with "noaccel" we don't register "software engine", > > but vblank ISR relies on its existance and happily derefences NULL

[PATCH] drm: do not expose vblank data before drm_vblank_init completes

2012-06-08 Thread Marcin Slusarz
On Sun, May 27, 2012 at 10:25:21PM +0200, Marcin Slusarz wrote: > On Thu, May 24, 2012 at 08:09:41PM +0200, Bruno Pr?mont wrote: > > I can easily trigger a crash in nouveau interrupt handler by unbinding > > and rebinding the GPU. > > > > The command used: > >

[Mesa-dev] [libdrm PATCH 4/4] xf86drm.c: Make more code UDEV unrelevant and fix a memory leak.

2012-06-29 Thread Marcin Slusarz
On Thu, Jun 28, 2012 at 09:51:58PM +0200, Johannes Obermayr wrote: These patches should be sent to dri-devel, not mesa-dev. > --- > xf86drm.c | 15 ++- > 1 files changed, 10 insertions(+), 5 deletions(-) > > diff --git a/xf86drm.c b/xf86drm.c > index 6ea068f..798f1fd 100644 > ---

[PATCH] drm/nouveau: add lockdep annotations

2013-02-04 Thread Marcin Slusarz
class. Reported-by: Arend van Spriel Reported-by: Peter Hurley Reported-by: Maarten Lankhorst Reported-by: Daniel J Blueman Signed-off-by: Marcin Slusarz Cc: stable at vger.kernel.org [3.7, but needs s/const ofuncs/ofuncs/ to build] --- Lightly tested, only on NV4B and NVC1. --- drivers/gpu

3.8.0-rc7, nouveau, possible recursive locking, nouveau_instobj_create_ and nv50_disp_data_ctor

2013-02-16 Thread Marcin Slusarz
On Sat, Feb 16, 2013 at 12:57:07AM +0200, Denys Fedoryshchenko wrote: > Hi > > Booted on Toshiba laptop, x86_64, NVIDIA Corporation GT218 [GeForce > 310M], latest rc, and got this. > Please let me know if you need additional information. It's harmless and already quieted down in Linus' tree (pos

WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242

2013-02-19 Thread Marcin Slusarz
On Mon, Feb 18, 2013 at 11:27:43AM +0100, Jiri Slaby wrote: > Hi, > > we have a report of WARNING from 3.7.6 in nouveau at > drivers/gpu/drm/nouveau/core/core/mm.c:242 here: > https://bugzilla.novell.com/show_bug.cgi?id=802347#c11 > > There is an order 4 allocation failure in nouveau_drm_open ->

WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242

2013-02-19 Thread Marcin Slusarz
On Tue, Feb 19, 2013 at 12:43:06AM +0100, Jiri Slaby wrote: > On 02/19/2013 12:23 AM, Marcin Slusarz wrote: > > On Mon, Feb 18, 2013 at 11:27:43AM +0100, Jiri Slaby wrote: > >> Hi, > >> > >> we have a report of WARNING from 3.7.6 in nouveau at > >> dr

[PATCH] drm/nouveau: fix suspend bug in nvc0 fence implementation

2013-02-19 Thread Marcin Slusarz
bably fix https://bugs.freedesktop.org/show_bug.cgi?id=59168. (note: it doesn't apply on top of nouveau/master) Reviewed-by: Marcin Slusarz > --- > > diff --git a/drivers/gpu/drm/nouveau/nvc0_fence.c > b/drivers/gpu/drm/nouveau/nvc0_fence.c > index 85a0e78..4f46d8b 100644 > ---

[Nouveau] [PATCH] drm/nouveau: fix suspend bug in nvc0 fence implementation

2013-02-19 Thread Marcin Slusarz
On Tue, Feb 19, 2013 at 10:09:12PM +0100, Michael Weirauch wrote: > 2013/2/19 Marcin Slusarz : > > Yay. It will probably fix > > https://bugs.freedesktop.org/show_bug.cgi?id=59168. > > (note: it doesn't apply on top of nouveau/master) > > Please correct me if I a

WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242

2013-02-19 Thread Marcin Slusarz
On Tue, Feb 19, 2013 at 08:07:44AM +0100, Marcin Slusarz wrote: > On Tue, Feb 19, 2013 at 12:43:06AM +0100, Jiri Slaby wrote: > > On 02/19/2013 12:23 AM, Marcin Slusarz wrote: > > > On Mon, Feb 18, 2013 at 11:27:43AM +0100, Jiri Slaby wrote: > > >> Hi, > > &

[stable request] fix for nouveau mem corruption [was: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242]

2013-02-20 Thread Marcin Slusarz
On Wed, Feb 20, 2013 at 03:47:05PM +0100, Jiri Slaby wrote: > On 02/19/2013 08:07 AM, Marcin Slusarz wrote: > >>> Crash/warning should be fixed by commit > >>> cfd376b6bfccf33782a0748a9c70f7f752f8b869 > >>> "drm/nouveau/vm: fix memory corruption when

Resume regression with nouveau 3.8rc1 (bisected)

2013-01-03 Thread Marcin Slusarz
On Wed, Jan 02, 2013 at 04:19:35PM +0100, Pontus Fuchs wrote: > Hi, > > Starting with 3.8rc1 I get a black screen when resuming after suspend. > The kernel is alive because I can switch to VT1 and reboot with > ctrl-alt-delete. > > I bisected the problem down to this commit: > > 186ecad21: drm

Resume regression with nouveau 3.8rc1 (bisected)

2013-01-03 Thread Marcin Slusarz
On Thu, Jan 03, 2013 at 01:58:10PM +0100, Marcin Slusarz wrote: > On Wed, Jan 02, 2013 at 04:19:35PM +0100, Pontus Fuchs wrote: > > Hi, > > > > Starting with 3.8rc1 I get a black screen when resuming after suspend. > > The kernel is alive because I can switch to VT1 an

Resume regression with nouveau 3.8rc1 (bisected)

2013-01-05 Thread Marcin Slusarz
On Sat, Jan 05, 2013 at 10:10:06AM +0100, Pontus Fuchs wrote: > On 01/03/2013 08:12 PM, Marcin Slusarz wrote: > > On Thu, Jan 03, 2013 at 01:58:10PM +0100, Marcin Slusarz wrote: > >> I bisected the problem down to this commit: > >> > >> 186ecad21: drm/nv50/dis

[PATCH] dma-buf: add vmap interface (v2)

2012-05-17 Thread Marcin Slusarz
On Thu, May 17, 2012 at 06:32:19AM -0600, Rob Clark wrote: > On Thu, May 17, 2012 at 4:31 AM, Dave Airlie wrote: > > From: Dave Airlie > > > > The main requirement I have for this interface is for scanning out > > using the USB gpu devices. Since these devices have to read the > > framebuffer on

[PATCH] drm: do not expose vblank data before drm_vblank_init completes

2012-05-27 Thread Marcin Slusarz
crashed because Nouveau failed to disable vblank interrupt on unbind and this interrupt triggered while drm was initializing vblank data. Nouveau side was fixed by "drm/nv04/disp: disable vblank interrupts when disabling display" by Ben Skeggs (3.5 merge window), drm side can be fixed

[PATCH 1/4] drm/ttm: remove ttm_buffer_object->buffer_start

2012-11-06 Thread Marcin Slusarz
All drivers set it to 0 and nothing uses it. Signed-off-by: Marcin Slusarz Cc: Thomas Hellstrom --- drivers/gpu/drm/ast/ast_ttm.c| 2 +- drivers/gpu/drm/cirrus/cirrus_ttm.c | 2 +- drivers/gpu/drm/mgag200/mgag200_ttm.c| 2 +- drivers/gpu/drm/nouveau/nouveau_bo.c | 2

[PATCH 2/4] drm/ttm: remove persistent_swap_storage argument from ttm_bo_init/ttm_bo_create

2012-11-06 Thread Marcin Slusarz
All drivers pass NULL here. ttm_buffer_object's field can still be set after init, just like nouveau does. Signed-off-by: Marcin Slusarz Cc: Thomas Hellstrom --- drivers/gpu/drm/ast/ast_ttm.c| 7 +++ drivers/gpu/drm/cirrus/cirrus_ttm.c | 2 +- drivers/gpu/drm/mg

[PATCH 3/4] drm/ttm: remove ttm_bo_device->nice_mode

2012-11-06 Thread Marcin Slusarz
It's unused. Signed-off-by: Marcin Slusarz Cc: Thomas Hellstrom --- drivers/gpu/drm/ttm/ttm_bo.c| 1 - include/drm/ttm/ttm_bo_driver.h | 3 --- 2 files changed, 4 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 412486c..da7a985 100644

[PATCH 4/4] drm/ttm: remove ttm_mem_global->queue

2012-11-06 Thread Marcin Slusarz
It's unused. Signed-off-by: Marcin Slusarz Cc: Thomas Hellstrom --- drivers/gpu/drm/ttm/ttm_memory.c | 1 - include/drm/ttm/ttm_memory.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_memory.c b/drivers/gpu/drm/ttm/ttm_memory.c index 479c6b0..dbc2def 1

[PATCH] nouveau: Fix crash after D3

2012-11-07 Thread Marcin Slusarz
On Tue, Nov 06, 2012 at 10:03:40PM +0800, Daniel J Blueman wrote: > In 3.7-rc4, when starting X with the integrated GPU and suspending the > discrete GPU, > after one or more 32-bit applications are used (eg Skype) and X is stopped, > we hit a panic. > > Prevent this by testing if the fini functi

Fix for vblank on nvc0

2012-11-11 Thread Marcin Slusarz
On Tue, Nov 06, 2012 at 07:30:00PM +0100, Maarten Lankhorst wrote: > > > Op 06-11-12 15:48, Kelly Doran schreef: > > The vblank on nvc0 was not working correctly and would freeze X, I managed > > to track it down and fix it with some help from m.b.lankhorst, see > > https://bugs.freedesktop.org/s

Fix for vblank on nvc0

2012-11-11 Thread Marcin Slusarz
On Sun, Nov 11, 2012 at 07:26:17PM +0100, Marcin Slusarz wrote: > On Tue, Nov 06, 2012 at 07:30:00PM +0100, Maarten Lankhorst wrote: > > > > > > Op 06-11-12 15:48, Kelly Doran schreef: > > > The vblank on nvc0 was not working correctly and would freeze X, I managed

Fix for vblank on nvc0

2012-11-13 Thread Marcin Slusarz
On Mon, Nov 12, 2012 at 06:14:05AM -0600, Kelly Doran wrote: > Okay I have added two patches, one of them should fix the problem... > vblank-fix1.patch works, thanks. Marcin

[Nouveau] [PATCH] drm/nouveau: Ack interrupts for some fuc engines

2013-03-25 Thread Marcin Slusarz
On Mon, Mar 25, 2013 at 10:22:37AM +0100, Maarten Lankhorst wrote: > Fixes 100% cpu usage when the exit interrupt never got acked. > > Signed-off-by: Maarten Lankhorst > --- > diff --git a/drivers/gpu/drm/nouveau/core/core/falcon.c > b/drivers/gpu/drm/nouveau/core/core/falcon.c > index e05c157..

[Nouveau] [PATCH] drm/nouveau: Ack interrupts for some fuc engines

2013-03-26 Thread Marcin Slusarz
On Tue, Mar 26, 2013 at 07:29:24AM +0100, Maarten Lankhorst wrote: > Op 25-03-13 19:14, Marcin Slusarz schreef: > > On Mon, Mar 25, 2013 at 10:22:37AM +0100, Maarten Lankhorst wrote: > >> Fixes 100% cpu usage when the exit interrupt never got acked. > >> > >&

[PATCH] drm/nouveau: fix regression in vblanking

2013-03-05 Thread Marcin Slusarz
(event->priv, 0x61002c, (1 << head), (0 << head)); > + nv_mask(event->priv, 0x61002c, (4 << head), 0); > } > > static int > It fixes vblank on my NVA8, thanks. Tested-by: Marcin Slusarz

nouveau lockdep splat

2013-03-06 Thread Marcin Slusarz
On Wed, Mar 06, 2013 at 01:04:29AM +0100, Borislav Petkov wrote: > On Tue, Mar 05, 2013 at 05:30:52PM +0100, Lucas Stach wrote: > > Dropping Tegra ML, it's not the place where Nouveau mails should go. > > $ ./scripts/get_maintainer.pl -f drivers/gpu/drm/nouveau/nv50_display.c > ... > linux-tegra a

<    1   2   3