[PATCH 01/11] drm: add drm_send_vblank_event() helper

2012-10-08 Thread Marcin Slusarz
On Mon, Oct 08, 2012 at 02:50:39PM -0500, Rob Clark wrote: > From: Rob Clark > > A helper that drivers can use to send vblank event after a pageflip. > If the driver doesn't support proper vblank irq based time/seqn then > just pass -1 for the pipe # to get do_gettimestamp() behavior (since > the

[PATCH 00/11] page-flip cleanups and fixes

2012-10-09 Thread Marcin Slusarz
On Mon, Oct 08, 2012 at 02:50:38PM -0500, Rob Clark wrote: > From: Rob Clark > > Add a helper fxn to send vblank event after pageflip, plus a handful > of fixes for other issues that I noticed in the process. FWIW, patches 1-5 and 7 (with a fix to 1st) are: Reviewed-by: Ma

[PATCH 01/11] drm: add drm_send_vblank_event() helper (v3)

2012-10-12 Thread Marcin Slusarz
On Thu, Oct 11, 2012 at 07:29:15PM -0500, Rob Clark wrote: > From: Rob Clark > > A helper that drivers can use to send vblank event after a pageflip. > If the driver doesn't support proper vblank irq based time/seqn then > just pass -1 for the pipe # to get do_gettimestamp() behavior (since > the

[PATCH] drm/debugfs: remove redundant info from gem_names

2012-10-16 Thread Marcin Slusarz
It's a relic of "drm: Convert proc files to seq_file and introduce debugfs", which wrongly converted DRM_INFO + sprintf to 2 seq_printfs. Signed-off-by: Marcin Slusarz Cc: Ben Gamari Cc: Eric Anholt --- drivers/gpu/drm/drm_info.c | 2 -- 1 file changed, 2 deletions(-) diff

Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-20 Thread Marcin Slusarz
; Tried it. Unfortunately, the crash remains the same as reported. Try this one. Now, the question is: could 3.6 kernel get VBIOS by ACPI? If yes, please mount debugfs and send vbios.rom to me please. (cat /sys/kernel/debug/dri/0/vbios.rom > vbios.rom) --- From: Marcin Slusarz Subject: [PATCH]

Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-20 Thread Marcin Slusarz
On Sat, Oct 20, 2012 at 10:28:46PM +0200, Marcin Slusarz wrote: > On Sat, Oct 20, 2012 at 12:42:38PM +0200, Heinz Diehl wrote: > > On 20.10.2012, Martin Peres wrote: > > > > > Can you test the attached patch too ? I rebased the previous one I sent on > > > top

Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-20 Thread Marcin Slusarz
On Sat, Oct 20, 2012 at 11:20:36PM +0200, Heinz Diehl wrote: > On 20.10.2012, Marcin Slusarz wrote: > > > Try this one. > > It works, now I can boot again. However, nouveau seems to be dead now. > The dmesg output with your patch on top of 3.7-rc1 is: > > [3.685

Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-20 Thread Marcin Slusarz
On Sat, Oct 20, 2012 at 11:42:17PM +0200, Marcin Slusarz wrote: > On Sat, Oct 20, 2012 at 11:20:36PM +0200, Heinz Diehl wrote: > > On 20.10.2012, Marcin Slusarz wrote: > > > > > Try this one. > > > > It works, now I can boot again. However, nouveau seems

Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-21 Thread Marcin Slusarz
On Sat, Oct 20, 2012 at 11:20:36PM +0200, Heinz Diehl wrote: > On 20.10.2012, Marcin Slusarz wrote: > > > Try this one. > > It works, now I can boot again. However, nouveau seems to be dead now. > The dmesg output with your patch on top of 3.7-rc1 is: > > [3.685

Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-21 Thread Marcin Slusarz
On Sun, Oct 21, 2012 at 08:58:07AM +0200, Pawe? Sikora wrote: > On Sunday 21 of October 2012 00:19:48 Marcin Slusarz wrote: > > On Sat, Oct 20, 2012 at 11:20:36PM +0200, Heinz Diehl wrote: > > > On 20.10.2012, Marcin Slusarz wrote: > > > > > > > Try thi

Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-21 Thread Marcin Slusarz
On Sun, Oct 21, 2012 at 07:38:58AM -0700, Linus Torvalds wrote: > On Sun, Oct 21, 2012 at 5:09 AM, Marcin Slusarz > wrote: > > > > This looks like ACPI bug... > > I'm _shocked_ to hear that firmware would be fragile. > > Anyway, here's the

[PATCH] libkms: link against libdrm

2012-09-08 Thread Marcin Slusarz
Signed-off-by: Marcin Slusarz --- libkms/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libkms/Makefile.am b/libkms/Makefile.am index fa379a4..215450a 100644 --- a/libkms/Makefile.am +++ b/libkms/Makefile.am @@ -6,7 +6,7 @@ AM_CFLAGS = \ libkms_la_LTLIBRARIES

[PATCH 1/3] fbmem: fix aperture overlapping check

2010-04-10 Thread marcin . slusarz
fb_do_apertures_overlap is returning wrong value when one aperture is completely whithin the other. Add generic ranges_overlap macro (probably kernel.h candidate) and use it here. Signed-off-by: Marcin Slusarz Cc: Dave Airlie Cc: Peter Jones Cc: Andrew Morton --- drivers/video/fbmem.c | 24

[PATCH 3/3] fbmem, drm/nouveau: kick firmware framebuffers as soon as possible

2010-04-10 Thread marcin . slusarz
uveau initialisation. Fix it by kicking firmware driver(s) before we start touching the hardware. Reported-by: Didier Spaier Signed-off-by: Marcin Slusarz Cc: Ben Skeggs Cc: Dave Airlie Cc: Peter Jones Cc: Andrew Morton --- drivers/gpu/drm/nouveau/nouveau_drv.h |2 + drivers/gpu/drm/no

[PATCH 2/3] fbdev: allow passing more than one aperture for handoff

2010-04-11 Thread marcin . slusarz
It simplifies nouveau code by removal of detection which region to pass to kick vesafb/efifb. Signed-off-by: Marcin Slusarz Cc: Eric Anholt Cc: Ben Skeggs Cc: Thomas Hellstrom Cc: Dave Airlie Cc: Peter Jones Cc: Andrew Morton Cc: Benjamin Herrenschmidt --- drivers/gpu/drm/i915/intel_fb.c

Re: [PATCH 3/3] fbmem, drm/nouveau: kick firmware framebuffers as soon as possible

2010-04-11 Thread Marcin Slusarz
r registration when > two drivers touch the hardware. Unfortunately sometimes it breaks nouveau > initialisation. > > Fix it by kicking firmware driver(s) before we start touching the hardware. > > Reported-by: Didier Spaier > Signed-off-by: Marcin Slusarz > Cc: Ben Skeggs

Re: [PATCH 1/3] fbmem: fix aperture overlapping check

2010-04-12 Thread Marcin Slusarz
t code? > Have you got a pointer to a machine where it fails? No, it failed with an artifical test while I was working on vga16fb handoff (unfinished). > Dave. > > > > Signed-off-by: Marcin Slusarz > > Cc: Dave Airlie > > Cc: Peter Jones > > Cc: Andre

Re: [PATCH 1/3] fbmem: fix aperture overlapping check

2010-04-12 Thread Marcin Slusarz
On Tue, Apr 13, 2010 at 06:28:21AM +1000, Dave Airlie wrote: > On Mon, 2010-04-12 at 13:34 +0200, Marcin Slusarz wrote: > > On Mon, Apr 12, 2010 at 09:54:28AM +1000, Dave Airlie wrote: > > > On Sat, 2010-04-10 at 21:55 +0200, marcin.slus...@gmail.com wrote: > > > &

[PATCHv2 2/2] fbmem, drm/nouveau: kick firmware framebuffers as soon as possible

2010-04-12 Thread marcin . slusarz
uveau initialisation. Fix it by kicking firmware driver(s) before we start touching the hardware. Reported-by: Didier Spaier Tested-by: Didier Spaier Signed-off-by: Marcin Slusarz Cc: Ben Skeggs Cc: Dave Airlie Cc: Peter Jones Cc: Andrew Morton --- v2 - rebase after drop of patch 1/3 + compil

[PATCHv2 1/2] fbdev: allow passing more than one aperture for handoff

2010-04-12 Thread marcin . slusarz
It simplifies nouveau code by removal of detection which region to pass to kick vesafb/efifb. Signed-off-by: Marcin Slusarz Cc: Eric Anholt Cc: Ben Skeggs Cc: Thomas Hellstrom Cc: Dave Airlie Cc: Peter Jones Cc: Andrew Morton Cc: Benjamin Herrenschmidt --- v2 - rebase after drop of patch

[PATCH] vga16fb, drm/nouveau: vga16fb->nouveau handoff

2010-04-13 Thread Marcin Slusarz
On Mon, Apr 12, 2010 at 11:33:27PM +0200, Marcin Slusarz wrote: > > > > Have you got a pointer to a machine where it fails? > > > > > > No, it failed with an artifical test while I was working on vga16fb > > > handoff > > > (unfinished). > >

Re: DRM NOUVEAU: cannot boot with kernel >=3.7

2012-12-24 Thread Marcin Slusarz
On Mon, Dec 24, 2012 at 09:26:17PM +0100, baldu...@units.it wrote: > hello everybody, > > apologies if I am missing any blatant point; my knowledge about > KMS/DRM etc. is very poor, so I am asking for help here (hoping to be > at the right place) > > Starting with kernel-3.7 I am not able to boo

Re: [RESEND PATCH] drm/nouveau: fix init with agpgart-uninorth

2012-12-31 Thread Marcin Slusarz
On Mon, Dec 31, 2012 at 03:34:59AM +0200, Aaro Koskinen wrote: > Check that the AGP aperture can be mapped. This follows a similar change > done for Radeon (commit 365048ff, drm/radeon: AGP memory is only I/O if > the aperture can be mapped by the CPU.). > > The patch fixes the following error see

Re: Resume regression with nouveau 3.8rc1 (bisected)

2013-01-03 Thread Marcin Slusarz
On Wed, Jan 02, 2013 at 04:19:35PM +0100, Pontus Fuchs wrote: > Hi, > > Starting with 3.8rc1 I get a black screen when resuming after suspend. > The kernel is alive because I can switch to VT1 and reboot with > ctrl-alt-delete. > > I bisected the problem down to this commit: > > 186ecad21: drm

Re: Resume regression with nouveau 3.8rc1 (bisected)

2013-01-03 Thread Marcin Slusarz
On Thu, Jan 03, 2013 at 01:58:10PM +0100, Marcin Slusarz wrote: > On Wed, Jan 02, 2013 at 04:19:35PM +0100, Pontus Fuchs wrote: > > Hi, > > > > Starting with 3.8rc1 I get a black screen when resuming after suspend. > > The kernel is alive because I can switch to VT1 an

Re: Resume regression with nouveau 3.8rc1 (bisected)

2013-01-05 Thread Marcin Slusarz
On Sat, Jan 05, 2013 at 10:10:06AM +0100, Pontus Fuchs wrote: > On 01/03/2013 08:12 PM, Marcin Slusarz wrote: > > On Thu, Jan 03, 2013 at 01:58:10PM +0100, Marcin Slusarz wrote: > >> I bisected the problem down to this commit: > >> > >> 186ecad21: drm/nv50/dis

[PATCH] libkms: link against libdrm

2012-09-07 Thread Marcin Slusarz
Signed-off-by: Marcin Slusarz --- libkms/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libkms/Makefile.am b/libkms/Makefile.am index fa379a4..215450a 100644 --- a/libkms/Makefile.am +++ b/libkms/Makefile.am @@ -6,7 +6,7 @@ AM_CFLAGS = \ libkms_la_LTLIBRARIES

Re: [PATCH 01/11] drm: add drm_send_vblank_event() helper

2012-10-08 Thread Marcin Slusarz
On Mon, Oct 08, 2012 at 02:50:39PM -0500, Rob Clark wrote: > From: Rob Clark > > A helper that drivers can use to send vblank event after a pageflip. > If the driver doesn't support proper vblank irq based time/seqn then > just pass -1 for the pipe # to get do_gettimestamp() behavior (since > the

Re: [PATCH 00/11] page-flip cleanups and fixes

2012-10-08 Thread Marcin Slusarz
On Mon, Oct 08, 2012 at 02:50:38PM -0500, Rob Clark wrote: > From: Rob Clark > > Add a helper fxn to send vblank event after pageflip, plus a handful > of fixes for other issues that I noticed in the process. FWIW, patches 1-5 and 7 (with a fix to 1st) are: Reviewed-by: Ma

Re: [PATCH 01/11] drm: add drm_send_vblank_event() helper (v3)

2012-10-12 Thread Marcin Slusarz
On Thu, Oct 11, 2012 at 07:29:15PM -0500, Rob Clark wrote: > From: Rob Clark > > A helper that drivers can use to send vblank event after a pageflip. > If the driver doesn't support proper vblank irq based time/seqn then > just pass -1 for the pipe # to get do_gettimestamp() behavior (since > the

[PATCH] drm/debugfs: remove redundant info from gem_names

2012-10-16 Thread Marcin Slusarz
It's a relic of "drm: Convert proc files to seq_file and introduce debugfs", which wrongly converted DRM_INFO + sprintf to 2 seq_printfs. Signed-off-by: Marcin Slusarz Cc: Ben Gamari Cc: Eric Anholt --- drivers/gpu/drm/drm_info.c | 2 -- 1 file changed, 2 deletions(-) diff

Re: Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-20 Thread Marcin Slusarz
; Tried it. Unfortunately, the crash remains the same as reported. Try this one. Now, the question is: could 3.6 kernel get VBIOS by ACPI? If yes, please mount debugfs and send vbios.rom to me please. (cat /sys/kernel/debug/dri/0/vbios.rom > vbios.rom) --- From: Marcin Slusarz Subject: [PATCH]

Re: Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-20 Thread Marcin Slusarz
On Sat, Oct 20, 2012 at 10:28:46PM +0200, Marcin Slusarz wrote: > On Sat, Oct 20, 2012 at 12:42:38PM +0200, Heinz Diehl wrote: > > On 20.10.2012, Martin Peres wrote: > > > > > Can you test the attached patch too ? I rebased the previous one I sent on > > > top

Re: Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-20 Thread Marcin Slusarz
On Sat, Oct 20, 2012 at 11:20:36PM +0200, Heinz Diehl wrote: > On 20.10.2012, Marcin Slusarz wrote: > > > Try this one. > > It works, now I can boot again. However, nouveau seems to be dead now. > The dmesg output with your patch on top of 3.7-rc1 is: > > [3.685

Re: Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-20 Thread Marcin Slusarz
On Sat, Oct 20, 2012 at 11:42:17PM +0200, Marcin Slusarz wrote: > On Sat, Oct 20, 2012 at 11:20:36PM +0200, Heinz Diehl wrote: > > On 20.10.2012, Marcin Slusarz wrote: > > > > > Try this one. > > > > It works, now I can boot again. However, nouveau seems

Re: Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-20 Thread Marcin Slusarz
On Sat, Oct 20, 2012 at 11:20:36PM +0200, Heinz Diehl wrote: > On 20.10.2012, Marcin Slusarz wrote: > > > Try this one. > > It works, now I can boot again. However, nouveau seems to be dead now. > The dmesg output with your patch on top of 3.7-rc1 is: > > [3.685

Re: Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-21 Thread Marcin Slusarz
On Sun, Oct 21, 2012 at 08:58:07AM +0200, Paweł Sikora wrote: > On Sunday 21 of October 2012 00:19:48 Marcin Slusarz wrote: > > On Sat, Oct 20, 2012 at 11:20:36PM +0200, Heinz Diehl wrote: > > > On 20.10.2012, Marcin Slusarz wrote: > > > > > > > Try thi

Re: Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-21 Thread Marcin Slusarz
On Sun, Oct 21, 2012 at 07:38:58AM -0700, Linus Torvalds wrote: > On Sun, Oct 21, 2012 at 5:09 AM, Marcin Slusarz > wrote: > > > > This looks like ACPI bug... > > I'm _shocked_ to hear that firmware would be fragile. > > Anyway, here's the

[PATCH 1/4] drm/ttm: remove ttm_buffer_object->buffer_start

2012-11-06 Thread Marcin Slusarz
All drivers set it to 0 and nothing uses it. Signed-off-by: Marcin Slusarz Cc: Thomas Hellstrom --- drivers/gpu/drm/ast/ast_ttm.c| 2 +- drivers/gpu/drm/cirrus/cirrus_ttm.c | 2 +- drivers/gpu/drm/mgag200/mgag200_ttm.c| 2 +- drivers/gpu/drm/nouveau/nouveau_bo.c | 2

[PATCH 2/4] drm/ttm: remove persistent_swap_storage argument from ttm_bo_init/ttm_bo_create

2012-11-06 Thread Marcin Slusarz
All drivers pass NULL here. ttm_buffer_object's field can still be set after init, just like nouveau does. Signed-off-by: Marcin Slusarz Cc: Thomas Hellstrom --- drivers/gpu/drm/ast/ast_ttm.c| 7 +++ drivers/gpu/drm/cirrus/cirrus_ttm.c | 2 +- drivers/gpu/drm/mg

[PATCH 3/4] drm/ttm: remove ttm_bo_device->nice_mode

2012-11-06 Thread Marcin Slusarz
It's unused. Signed-off-by: Marcin Slusarz Cc: Thomas Hellstrom --- drivers/gpu/drm/ttm/ttm_bo.c| 1 - include/drm/ttm/ttm_bo_driver.h | 3 --- 2 files changed, 4 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 412486c..da7a985 100644

[PATCH 4/4] drm/ttm: remove ttm_mem_global->queue

2012-11-06 Thread Marcin Slusarz
It's unused. Signed-off-by: Marcin Slusarz Cc: Thomas Hellstrom --- drivers/gpu/drm/ttm/ttm_memory.c | 1 - include/drm/ttm/ttm_memory.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_memory.c b/drivers/gpu/drm/ttm/ttm_memory.c index 479c6b0..dbc2def 1

Re: [PATCH] nouveau: Fix crash after D3

2012-11-07 Thread Marcin Slusarz
On Tue, Nov 06, 2012 at 10:03:40PM +0800, Daniel J Blueman wrote: > In 3.7-rc4, when starting X with the integrated GPU and suspending the > discrete GPU, > after one or more 32-bit applications are used (eg Skype) and X is stopped, > we hit a panic. > > Prevent this by testing if the fini functi

Re: Fix for vblank on nvc0

2012-11-11 Thread Marcin Slusarz
On Tue, Nov 06, 2012 at 07:30:00PM +0100, Maarten Lankhorst wrote: > > > Op 06-11-12 15:48, Kelly Doran schreef: > > The vblank on nvc0 was not working correctly and would freeze X, I managed > > to track it down and fix it with some help from m.b.lankhorst, see > > https://bugs.freedesktop.org/s

Re: Fix for vblank on nvc0

2012-11-11 Thread Marcin Slusarz
On Sun, Nov 11, 2012 at 07:26:17PM +0100, Marcin Slusarz wrote: > On Tue, Nov 06, 2012 at 07:30:00PM +0100, Maarten Lankhorst wrote: > > > > > > Op 06-11-12 15:48, Kelly Doran schreef: > > > The vblank on nvc0 was not working correctly and would freeze X, I managed

Re: Fix for vblank on nvc0

2012-11-12 Thread Marcin Slusarz
On Mon, Nov 12, 2012 at 06:14:05AM -0600, Kelly Doran wrote: > Okay I have added two patches, one of them should fix the problem... > vblank-fix1.patch works, thanks. Marcin ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freede

[PATCH] drm: fix messages about failed procfs/debugfs file registration

2011-10-09 Thread Marcin Slusarz
It printed garbage from stack: [drm:drm_debugfs_create_files] *ERROR* Cannot create /sys/kernel/debug/dri/!.wy/2 Reported-by: Daniel Yek Signed-off-by: Marcin Slusarz Cc: sta...@kernel.org --- drivers/gpu/drm/drm_debugfs.c |3 +-- drivers/gpu/drm/drm_proc.c|3 +-- 2 files changed

[PATCH 1/2] drm: fix error message about failed procfs file registration

2011-10-10 Thread Marcin Slusarz
It printed garbage. Signed-off-by: Marcin Slusarz --- drivers/gpu/drm/drm_proc.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_proc.c b/drivers/gpu/drm/drm_proc.c index 9e5b07e..0f3c4e3 100644 --- a/drivers/gpu/drm/drm_proc.c +++ b/drivers/gpu

[PATCH 2/2] drm: simplify error printing in drm_debugfs_create_files

2011-10-10 Thread Marcin Slusarz
There's no need to copy d_name.name. Signed-off-by: Marcin Slusarz --- drivers/gpu/drm/drm_debugfs.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c index 9d2668a..b9dc262 100644 --- a/drivers/gp

[PATCH] drm: serialize access to debugs_nodes.list

2011-10-30 Thread Marcin Slusarz
le of xterms with looped glxinfo. Signed-off-by: Marcin Slusarz --- drivers/gpu/drm/drm_debugfs.c |5 + include/drm/drmP.h|1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c index 9d2668a..1144fbe 1

Re: [PATCH] drm: serialize access to debugs_nodes.list

2011-10-31 Thread Marcin Slusarz
On Mon, Oct 31, 2011 at 09:06:57AM +0100, Daniel Vetter wrote: > This is just ugly, you're adding a mutex to every drm_info_node, but only > use the one embedded into the minor. On a quick grep we're only ever using > the list in there, so I suggest to > - replace minor->debugfs_node.list with mino

[PATCH] drm: serialize access to list of debugfs files

2011-10-31 Thread Marcin Slusarz
le of xterms with looped glxinfo. Signed-off-by: Marcin Slusarz --- drivers/gpu/drm/drm_debugfs.c | 12 +--- drivers/gpu/drm/i915/i915_debugfs.c |5 - include/drm/drmP.h |4 +++- 3 files changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/gp

[PATCH] drm: serialize access to list of debugfs files

2011-11-09 Thread Marcin Slusarz
le of xterms with looped glxinfo. Signed-off-by: Marcin Slusarz Reviewed-by: Daniel Vetter --- Updated changelog. --- drivers/gpu/drm/drm_debugfs.c | 12 +--- drivers/gpu/drm/i915/i915_debugfs.c |5 - include/drm/drmP.h |4 +++- 3 files changed, 16 inser

Re: i915_driver_irq_handler: irq 42: nobody cared

2012-04-10 Thread Marcin Slusarz
On Tue, Apr 10, 2012 at 10:52:06AM +0200, Jiri Slaby wrote: > On 04/06/2012 11:31 PM, Jiri Slaby wrote: > > On 03/30/2012 02:24 PM, Chris Wilson wrote: > >> On Fri, 30 Mar 2012 14:11:47 +0200, Jiri Slaby wrote: > >>> On 03/30/2012 12:45 PM, Chris Wilson wrote: > On Fri, 30 Mar 2012 11:59:28 +

[PATCH 1/5] drm: add optional per device rwsem for all ioctls

2012-04-22 Thread Marcin Slusarz
Nouveau, in normal circumstances, does not need device lock for every ioctl, but incoming "gpu reset" code needs exclusive access to the device. This commit adds drm_driver flag which turns on read lock ioctl encapsulation. Signed-off-by: Marcin Slusarz --- drivers/gpu/drm/drm_drv

[PATCH 2/5] drm/nouveau: base fence timeout on time of emission

2012-04-22 Thread Marcin Slusarz
Wait loop can be interrupted by signal, so if signals are raised periodically (e.g. SIGALRM) this loop may never finish. Use emission time as a base for fence timeout. Signed-off-by: Marcin Slusarz --- drivers/gpu/drm/nouveau/nouveau_fence.c |5 - 1 files changed, 4 insertions(+), 1

[PATCH 3/5] drm/nouveau: propagate errors from vm flushes

2012-04-22 Thread Marcin Slusarz
We need this for lockup recovery. Signed-off-by: Marcin Slusarz --- drivers/gpu/drm/nouveau/nouveau_bo.c |9 +++-- drivers/gpu/drm/nouveau/nouveau_drv.h |6 +++--- drivers/gpu/drm/nouveau/nouveau_vm.c | 20 ++-- drivers/gpu/drm/nouveau/nouveau_vm.h | 18

[PATCH 4/5] drm/nv50: let applications hanging on vm flush to be killed

2012-04-22 Thread Marcin Slusarz
Signed-off-by: Marcin Slusarz --- drivers/gpu/drm/nouveau/nv50_graph.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nv50_graph.c b/drivers/gpu/drm/nouveau/nv50_graph.c index 6899547..a61853f 100644 --- a/drivers/gpu/drm/nouveau

[RFC PATCH 5/5] drm/nouveau: gpu lockup recovery

2012-04-22 Thread Marcin Slusarz
waits Signed-off-by: Marcin Slusarz --- Tested only on nv92. --- drivers/gpu/drm/nouveau/Makefile |2 +- drivers/gpu/drm/nouveau/nouveau_bo.c |2 +- drivers/gpu/drm/nouveau/nouveau_channel.c |5 +- drivers/gpu/drm/nouveau/nouveau_drv.c |3 +- drivers/gpu/drm

Re: [RFC PATCH 5/5] drm/nouveau: gpu lockup recovery

2012-04-23 Thread Marcin Slusarz
On Mon, Apr 23, 2012 at 10:43:08AM +0200, Martin Peres wrote: > Le 23/04/2012 00:18, Marcin Slusarz a écrit : > > Overall idea: > > Detect lockups by watching for timeouts (vm flush / fence), return -EIOs, > > handle them at ioctl level, reset the GPU and repeat last ioctl.

Re: [PATCH 1/5] drm: add optional per device rwsem for all ioctls

2012-04-23 Thread Marcin Slusarz
On Mon, Apr 23, 2012 at 09:51:48AM +0200, Daniel Vetter wrote: > On Mon, Apr 23, 2012 at 12:18:28AM +0200, Marcin Slusarz wrote: > > Nouveau, in normal circumstances, does not need device lock for every ioctl, > > but incoming "gpu reset" code needs exclusive access to th

Re: [Nouveau] [PATCH 4/5] drm/nv50: let applications hanging on vm flush to be killed

2012-04-23 Thread Marcin Slusarz
On Mon, Apr 23, 2012 at 07:09:57PM +0200, Martin Peres wrote: > Le 23/04/2012 00:18, Marcin Slusarz a écrit : > > Signed-off-by: Marcin Slusarz > > --- > > drivers/gpu/drm/nouveau/nv50_graph.c |5 + > > 1 files changed, 5 insertions(+), 0 deletions(-) >

Re: [RFC PATCH 5/5] drm/nouveau: gpu lockup recovery

2012-04-23 Thread Marcin Slusarz
On Mon, Apr 23, 2012 at 06:46:41PM +0200, Martin Peres wrote: > Hey, > > Just a minor mistake spotted while skimming through the patch. > > Le 23/04/2012 00:18, Marcin Slusarz a écrit : > > +static inline uint64_t nv_timeout(struct drm_device *dev) > > +{ > >

Re: [Nouveau] [PATCH 2/5] drm/nouveau: base fence timeout on time of emission

2012-04-24 Thread Marcin Slusarz
On Tue, Apr 24, 2012 at 12:37:34PM +1000, Ben Skeggs wrote: > On Mon, 2012-04-23 at 00:18 +0200, Marcin Slusarz wrote: > > Wait loop can be interrupted by signal, so if signals are raised > > periodically (e.g. SIGALRM) this loop may never finish. Use > > emission time as a b

Re: [PATCH 1/5] drm: add optional per device rwsem for all ioctls

2012-04-24 Thread Marcin Slusarz
On Mon, Apr 23, 2012 at 09:51:48AM +0200, Daniel Vetter wrote: > On Mon, Apr 23, 2012 at 12:18:28AM +0200, Marcin Slusarz wrote: > > Nouveau, in normal circumstances, does not need device lock for every ioctl, > > but incoming "gpu reset" code needs exclusive access to th

Re: [RFC PATCH 5/5] drm/nouveau: gpu lockup recovery

2012-04-24 Thread Marcin Slusarz
On Mon, Apr 23, 2012 at 06:56:44PM +0200, Martin Peres wrote: > Le 23/04/2012 18:32, Marcin Slusarz a écrit : > > > > Just run piglit. Even "quick" tests can cause ~5 lockups (it eventually > > messes > > up DDX channel, but this patchset can't fix thi

[PATCH v2 1/4] drm/nouveau: base fence timeout on time of emission

2012-04-25 Thread Marcin Slusarz
Wait loop can be interrupted by signal, so if signals are raised periodically (e.g. SIGALRM) this loop may never finish. Use emission time as a base for fence timeout. Signed-off-by: Marcin Slusarz --- drivers/gpu/drm/nouveau/nouveau_fence.c |5 - 1 files changed, 4 insertions(+), 1

[PATCH v2 2/4] drm/nouveau: propagate errors from vm flushes

2012-04-25 Thread Marcin Slusarz
We need this for lockup recovery. Signed-off-by: Marcin Slusarz --- drivers/gpu/drm/nouveau/nouveau_bo.c |9 +++-- drivers/gpu/drm/nouveau/nouveau_drv.h |6 +++--- drivers/gpu/drm/nouveau/nouveau_vm.c | 20 ++-- drivers/gpu/drm/nouveau/nouveau_vm.h | 18

[PATCH v2 3/4] drm/nv50: let applications hanging on vm flush to be killed

2012-04-25 Thread Marcin Slusarz
Signed-off-by: Marcin Slusarz --- drivers/gpu/drm/nouveau/nv50_graph.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nv50_graph.c b/drivers/gpu/drm/nouveau/nv50_graph.c index 6899547..a61853f 100644 --- a/drivers/gpu/drm/nouveau

[PATCH v2 4/4] drm/nouveau: gpu lockup recovery

2012-04-25 Thread Marcin Slusarz
waits Signed-off-by: Marcin Slusarz --- drivers/gpu/drm/nouveau/Makefile |2 +- drivers/gpu/drm/nouveau/nouveau_bo.c |2 +- drivers/gpu/drm/nouveau/nouveau_channel.c |5 +- drivers/gpu/drm/nouveau/nouveau_drv.c | 56 ++- drivers/gpu/drm/nouveau

Re: [PATCH v2 4/4] drm/nouveau: gpu lockup recovery

2012-04-25 Thread Marcin Slusarz
On Wed, Apr 25, 2012 at 11:20:36PM +0200, Marcin Slusarz wrote: > Overall idea: > Detect lockups by watching for timeouts (vm flush / fence), return -EIOs, > handle them at ioctl level, reset the GPU and repeat last ioctl. > > GPU reset is done by doing suspend / resume cycle

Re: [Nouveau] [PATCH v2 4/4] drm/nouveau: gpu lockup recovery

2012-04-28 Thread Marcin Slusarz
On Thu, Apr 26, 2012 at 05:32:29PM +1000, Ben Skeggs wrote: > On Wed, 2012-04-25 at 23:20 +0200, Marcin Slusarz wrote: > > Overall idea: > > Detect lockups by watching for timeouts (vm flush / fence), return -EIOs, > > handle them at ioctl level, reset the GPU and repeat las

Re: [PATCH] dma-buf: add vmap interface (v2)

2012-05-17 Thread Marcin Slusarz
On Thu, May 17, 2012 at 06:32:19AM -0600, Rob Clark wrote: > On Thu, May 17, 2012 at 4:31 AM, Dave Airlie wrote: > > From: Dave Airlie > > > > The main requirement I have for this interface is for scanning out > > using the USB gpu devices. Since these devices have to read the > > framebuffer on

[PATCH] drm: do not expose vblank data before drm_vblank_init completes

2012-05-27 Thread Marcin Slusarz
crashed because Nouveau failed to disable vblank interrupt on unbind and this interrupt triggered while drm was initializing vblank data. Nouveau side was fixed by "drm/nv04/disp: disable vblank interrupts when disabling display" by Ben Skeggs (3.5 merge window), drm side can be fixed

Re: [PATCH] drm: do not expose vblank data before drm_vblank_init completes

2012-06-08 Thread Marcin Slusarz
On Sun, May 27, 2012 at 10:25:21PM +0200, Marcin Slusarz wrote: > On Thu, May 24, 2012 at 08:09:41PM +0200, Bruno Prémont wrote: > > I can easily trigger a crash in nouveau interrupt handler by unbinding > > and rebinding the GPU. > > > > The command used: > >

Re: [Mesa-dev] [libdrm PATCH 4/4] xf86drm.c: Make more code UDEV unrelevant and fix a memory leak.

2012-06-28 Thread Marcin Slusarz
On Thu, Jun 28, 2012 at 09:51:58PM +0200, Johannes Obermayr wrote: These patches should be sent to dri-devel, not mesa-dev. > --- > xf86drm.c | 15 ++- > 1 files changed, 10 insertions(+), 5 deletions(-) > > diff --git a/xf86drm.c b/xf86drm.c > index 6ea068f..798f1fd 100644 > ---

Re: libdrm: Fix some warnings reported by clang's scan-build tool

2012-07-13 Thread Marcin Slusarz
On Fri, Jul 13, 2012 at 05:49:12PM +0200, Johannes Obermayr wrote: > > Patches 1 to 4 were sent to mesa-dev. And you chose to ignore most of my comments. Fine. Don't expect further reviews from me. Marcin ___ dri-devel mailing list dri-devel@lists.free

Re: drm/nouveau: crash regression in 3.5

2012-07-24 Thread Marcin Slusarz
On Mon, Jul 23, 2012 at 08:01:14PM +0200, Ortwin Glück wrote: > Hi, > > My HP Elitebook 8540w now crashes on boot with 3.5. All works fine with > 3.4. Bisected to the following commit: > > 20abd1634a6e2eedb84ca977adea56b8aa06cc3e is the first bad commit > commit 20abd1634a6e2eedb84ca977adea56b8a

Re: drm/nouveau: crash regression in 3.5

2012-07-24 Thread Marcin Slusarz
On Tue, Jul 24, 2012 at 07:22:52PM +0200, Ortwin Glück wrote: > On 24.07.2012 19:00, Marcin Slusarz wrote: > > Please post the crash log. > > Sorry, I was not precise: it boots until drm performs modesetting (so it > seems). The screen goes black and the machine is dead. So the

Re: drm/nouveau: crash regression in 3.5

2012-07-25 Thread Marcin Slusarz
nic. Note that you can hit an oops in drm_handle_vblank because patch from http://lists.freedesktop.org/archives/dri-devel/2012-May/023498.html has not been applied (yet?). -- From: Marcin Slusarz Date: Wed, 25 Jul 2012 20:07:22 +0200 Subject: [PATCH] drm/nouveau: init vblank requests list Fixes kern

Re: drm/nouveau: crash regression in 3.5

2012-07-26 Thread Marcin Slusarz
On Thu, Jul 26, 2012 at 02:56:22PM +0200, Ortwin Glück wrote: > On 25.07.2012 20:42, Marcin Slusarz wrote: > > Good, below patch should fix this panic. > > > > Note that you can hit an oops in drm_handle_vblank because patch from > > http://lists.freedesktop.org/archive

Re: drm/nouveau: crash regression in 3.5

2012-07-29 Thread Marcin Slusarz
On Thu, Jul 26, 2012 at 02:56:22PM +0200, Ortwin Glück wrote: > On 25.07.2012 20:42, Marcin Slusarz wrote: > > Good, below patch should fix this panic. > > > > Note that you can hit an oops in drm_handle_vblank because patch from > > http://lists.freedesktop.org/archive

Re: drm/nouveau: crash regression in 3.5

2012-07-30 Thread Marcin Slusarz
On Mon, Jul 30, 2012 at 01:16:37PM +0200, Ortwin Glück wrote: > On 29.07.2012 22:15, Marcin Slusarz wrote: > > No, the real problem is: with "noaccel" we don't register "software engine", > > but vblank ISR relies on its existance and happily derefences NULL

Re: drm/nouveau: crash regression in 3.5

2012-08-02 Thread Marcin Slusarz
On Thu, Aug 02, 2012 at 01:26:55PM +0200, Ortwin Glück wrote: > I have managed to turn the crash into a WARN_ON, by adding this to the > begin of nouveau_software_vblank(): > > if (!psw) { > WARN_ON(1); > return; > } Yes, I know about it, but t

[PATCH] drm/nouveau: add lockdep annotations

2013-02-04 Thread Marcin Slusarz
class. Reported-by: Arend van Spriel Reported-by: Peter Hurley Reported-by: Maarten Lankhorst Reported-by: Daniel J Blueman Signed-off-by: Marcin Slusarz Cc: sta...@vger.kernel.org [3.7, but needs s/const ofuncs/ofuncs/ to build] --- Lightly tested, only on NV4B and NVC1. --- drivers/gpu/drm

Re: 3.8.0-rc7, nouveau, possible recursive locking, nouveau_instobj_create_ and nv50_disp_data_ctor

2013-02-16 Thread Marcin Slusarz
On Sat, Feb 16, 2013 at 12:57:07AM +0200, Denys Fedoryshchenko wrote: > Hi > > Booted on Toshiba laptop, x86_64, NVIDIA Corporation GT218 [GeForce > 310M], latest rc, and got this. > Please let me know if you need additional information. It's harmless and already quieted down in Linus' tree (pos

Re: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242

2013-02-18 Thread Marcin Slusarz
On Mon, Feb 18, 2013 at 11:27:43AM +0100, Jiri Slaby wrote: > Hi, > > we have a report of WARNING from 3.7.6 in nouveau at > drivers/gpu/drm/nouveau/core/core/mm.c:242 here: > https://bugzilla.novell.com/show_bug.cgi?id=802347#c11 > > There is an order 4 allocation failure in nouveau_drm_open ->

Re: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242

2013-02-18 Thread Marcin Slusarz
On Tue, Feb 19, 2013 at 12:43:06AM +0100, Jiri Slaby wrote: > On 02/19/2013 12:23 AM, Marcin Slusarz wrote: > > On Mon, Feb 18, 2013 at 11:27:43AM +0100, Jiri Slaby wrote: > >> Hi, > >> > >> we have a report of WARNING from 3.7.6 in nouveau at > >> dr

Re: [PATCH] drm/nouveau: fix suspend bug in nvc0 fence implementation

2013-02-19 Thread Marcin Slusarz
bably fix https://bugs.freedesktop.org/show_bug.cgi?id=59168. (note: it doesn't apply on top of nouveau/master) Reviewed-by: Marcin Slusarz > --- > > diff --git a/drivers/gpu/drm/nouveau/nvc0_fence.c > b/drivers/gpu/drm/nouveau/nvc0_fence.c > index 85a0e78..4f46d8b 100644 > ---

Re: [Nouveau] [PATCH] drm/nouveau: fix suspend bug in nvc0 fence implementation

2013-02-19 Thread Marcin Slusarz
On Tue, Feb 19, 2013 at 10:09:12PM +0100, Michael Weirauch wrote: > 2013/2/19 Marcin Slusarz : > > Yay. It will probably fix > > https://bugs.freedesktop.org/show_bug.cgi?id=59168. > > (note: it doesn't apply on top of nouveau/master) > > Please correct me if I a

Re: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242

2013-02-19 Thread Marcin Slusarz
On Tue, Feb 19, 2013 at 08:07:44AM +0100, Marcin Slusarz wrote: > On Tue, Feb 19, 2013 at 12:43:06AM +0100, Jiri Slaby wrote: > > On 02/19/2013 12:23 AM, Marcin Slusarz wrote: > > > On Mon, Feb 18, 2013 at 11:27:43AM +0100, Jiri Slaby wrote: > > >> Hi, > > &

Re: [stable request] fix for nouveau mem corruption [was: WARNING: at drivers/gpu/drm/nouveau/core/core/mm.c:242]

2013-02-20 Thread Marcin Slusarz
On Wed, Feb 20, 2013 at 03:47:05PM +0100, Jiri Slaby wrote: > On 02/19/2013 08:07 AM, Marcin Slusarz wrote: > >>> Crash/warning should be fixed by commit > >>> cfd376b6bfccf33782a0748a9c70f7f752f8b869 > >>> "drm/nouveau/vm: fix memory corruption when

Re: [PATCH] drm/nouveau: fix regression in vblanking

2013-03-05 Thread Marcin Slusarz
(event->priv, 0x61002c, (1 << head), (0 << head)); > + nv_mask(event->priv, 0x61002c, (4 << head), 0); > } > > static int > It fixes vblank on my NVA8, thanks. Tested-by: Marcin Slusarz ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: nouveau lockdep splat

2013-03-06 Thread Marcin Slusarz
On Wed, Mar 06, 2013 at 01:04:29AM +0100, Borislav Petkov wrote: > On Tue, Mar 05, 2013 at 05:30:52PM +0100, Lucas Stach wrote: > > Dropping Tegra ML, it's not the place where Nouveau mails should go. > > $ ./scripts/get_maintainer.pl -f drivers/gpu/drm/nouveau/nv50_display.c > ... > linux-te...@v

Re: [Nouveau] [PATCH] drm/nouveau: Ack interrupts for some fuc engines

2013-03-25 Thread Marcin Slusarz
On Mon, Mar 25, 2013 at 10:22:37AM +0100, Maarten Lankhorst wrote: > Fixes 100% cpu usage when the exit interrupt never got acked. > > Signed-off-by: Maarten Lankhorst > --- > diff --git a/drivers/gpu/drm/nouveau/core/core/falcon.c > b/drivers/gpu/drm/nouveau/core/core/falcon.c > index e05c157..

Re: [Nouveau] [PATCH] drm/nouveau: Ack interrupts for some fuc engines

2013-03-26 Thread Marcin Slusarz
On Tue, Mar 26, 2013 at 07:29:24AM +0100, Maarten Lankhorst wrote: > Op 25-03-13 19:14, Marcin Slusarz schreef: > > On Mon, Mar 25, 2013 at 10:22:37AM +0100, Maarten Lankhorst wrote: > >> Fixes 100% cpu usage when the exit interrupt never got acked. > >> > >&

Re: 2.6.39-rc1 nouveau regression (bisected)

2011-04-14 Thread Marcin Slusarz
On Thu, Apr 14, 2011 at 07:05:59PM +0200, Dominik Brodowski wrote: > Thought about CCing Linus to show him that 2.6.39-rcX isn't as "calm" > to everyone, but then chose to CC Maciej instead: Would you be so kind and > add this to your regression list? Thanks! > > Since commit 38f1cff > > From

Re: 2.6.39-rc1 nouveau regression (bisected)

2011-04-17 Thread Marcin Slusarz
r 14, 2011 at 09:02:01PM +0200, Marcin Slusarz wrote: > > > >> On Thu, Apr 14, 2011 at 07:05:59PM +0200, Dominik Brodowski wrote: > > > >>> Thought about CCing Linus to show him that 2.6.39-rcX isn't as "calm" > > > >>> to everyone, but

Re: 2.6.39-rc1 nouveau regression (bisected)

2011-04-17 Thread Marcin Slusarz
Dominik Brodowski wrote: > > > > On Thu, Apr 14, 2011 at 09:02:01PM +0200, Marcin Slusarz wrote: > > > >> On Thu, Apr 14, 2011 at 07:05:59PM +0200, Dominik Brodowski wrote: > > > >>> Thought about CCing Linus to show him that 2.6.39-rcX isn't as "cal

Re: 2.6.39-rc1 nouveau regression (bisected)

2011-04-17 Thread Marcin Slusarz
On Sun, Apr 17, 2011 at 12:24:27PM -0400, Kyle Spaans wrote: > On Sun, Apr 17, 2011 at 05:45:57PM +0200, Marcin Slusarz wrote: > > On Sun, Apr 17, 2011 at 11:12:04AM -0400, Kyle Spaans wrote: > > > On Sat, Apr 16, 2011 at 07:50:28PM -0400, Kyle Spaans wrote: > > > >

  1   2   3   >