Hi Maxime,
On 2021-02-10 14:40, Maxime Ripard wrote:
Hi Dave,
On Tue, Feb 09, 2021 at 09:49:05AM +, Dave Stevenson wrote:
On Mon, 11 Jan 2021 at 14:23, Maxime Ripard wrote:
>
> The BSC controllers used for the HDMI DDC have an interrupt controller
> shared between both instances. Let's ad
On 2020-11-23 14:03, Jerome Brunet wrote:
On Fri 20 Nov 2020 at 10:42, Marc Zyngier wrote:
The HDMI driver request clocks early, but never disable them, leaving
the clocks on even when the driver is removed.
Fix it by slightly refactoring the clock code, and register a devm
action that will
Hi Maxime,
On 2020-12-10 13:46, Maxime Ripard wrote:
The BCM2711 uses a number of instances of the bcmstb-l2 controller in
its
display engine. Let's allow the driver to be enabled through KConfig.
Signed-off-by: Maxime Ripard
---
drivers/irqchip/Kconfig | 2 +-
1 file changed, 1 insertion(+)
not always
enabled by the time we enter meson_dw_hdmi_init(). Moving this call
*after* dw_hdmi_probe() ensures that the clocks are enabled.
Signed-off-by: Marc Zyngier
---
drivers/gpu/drm/meson/meson_dw_hdmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm
as getting a working display. Total dedication.
Feedback much appreciated.
M.
Marc Zyngier (4):
drm/meson: Free RDMA resources after tearing down DRM
drm/meson: Unbind all connectors on module removal
drm/meson: dw-hdmi: Register a callback to disable the regulator
drm/meson: dw-hdmi
.
Signed-off-by: Marc Zyngier
---
drivers/gpu/drm/meson/meson_drv.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/meson/meson_drv.c
b/drivers/gpu/drm/meson/meson_drv.c
index 8b9c8dd788c4..324fa489f1c4 100644
--- a/drivers/gpu/drm/meson/meson_drv.c
still enabled on release.
In order to address this, register a callback that will deal with
the disabling when the driver is unbound, solving the problem.
Signed-off-by: Marc Zyngier
---
drivers/gpu/drm/meson/meson_dw_hdmi.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu
esult in the connectors being torn down.
Call drm_atomic_helper_shutdown() and component_unbind_all() to safely
tear the module down.
Signed-off-by: Marc Zyngier
---
drivers/gpu/drm/meson/meson_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/
Hi Neil,
On 2020-11-17 08:49, Neil Armstrong wrote:
Hi Marc,
On 16/11/2020 21:07, Marc Zyngier wrote:
Hi all,
Having recently moved over to a top-of-the-tree u-boot on one of my
VIM3L systems in order to benefit from unrelated improvements
(automatic PCIe detection, EFI...), I faced the
On 2020-11-19 08:50, Guillaume Tucker wrote:
Please see the automated bisection report below about some kernel
errors on meson-gxbb-p200.
Reports aren't automatically sent to the public while we're
trialing new bisection features on kernelci.org, however this one
looks valid.
The bisection star
On 2020-11-19 10:26, Neil Armstrong wrote:
On 19/11/2020 11:20, Marc Zyngier wrote:
On 2020-11-19 08:50, Guillaume Tucker wrote:
Please see the automated bisection report below about some kernel
errors on meson-gxbb-p200.
Reports aren't automatically sent to the public while we'r
On 2020-11-19 10:26, Neil Armstrong wrote:
On 19/11/2020 11:20, Marc Zyngier wrote:
On 2020-11-19 08:50, Guillaume Tucker wrote:
Please see the automated bisection report below about some kernel
errors on meson-gxbb-p200.
Reports aren't automatically sent to the public while we'r
On 2020-11-19 18:13, Jerome Brunet wrote:
On Thu 19 Nov 2020 at 19:04, Guillaume Tucker
wrote:
Hi Marc,
On 19/11/2020 11:58, Marc Zyngier wrote:
On 2020-11-19 10:26, Neil Armstrong wrote:
On 19/11/2020 11:20, Marc Zyngier wrote:
On 2020-11-19 08:50, Guillaume Tucker wrote:
Please see the
.
Marc Zyngier (2):
drm/meson: dw-hdmi: Disable clocks on driver teardown
drm/meson: dw-hdmi: Enable the iahb clock early enough
drivers/gpu/drm/meson/meson_dw_hdmi.c | 51 ++-
1 file changed, 35 insertions(+), 16 deletions(-)
--
2.28.0
The HDMI driver request clocks early, but never disable them, leaving
the clocks on even when the driver is removed.
Fix it by slightly refactoring the clock code, and register a devm
action that will eventually disable/unprepare the enabled clocks.
Signed-off-by: Marc Zyngier
---
drivers/gpu
dw-hdmi: Ensure that clocks are enabled before
touching the TOP registers")
Reported-by: Guillaume Tucker
Tested-by: Guillaume Tucker
Signed-off-by: Marc Zyngier
---
drivers/gpu/drm/meson/meson_dw_hdmi.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/d
On 2020-11-20 09:26, Neil Armstrong wrote:
On 19/11/2020 19:35, Marc Zyngier wrote:
diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c
b/drivers/gpu/drm/meson/meson_dw_hdmi.c
index 7f8eea494147..52af8ba94311 100644
--- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
+++ b/drivers/gpu/drm/meson
On 2020-11-20 10:54, Guillaume Tucker wrote:
On 20/11/2020 09:42, Marc Zyngier wrote:
Instead of moving meson_dw_hdmi_init() around which breaks existing
platform, let's enable the clock meson_dw_hdmi_init() depends on.
This means we don't have to worry about this clock being enab
On Wed, 20 Oct 2021 08:45:02 +0100,
Krzysztof Kozlowski wrote:
>
> On 20/10/2021 08:50, patrice.chot...@foss.st.com wrote:
> > From: Patrice Chotard
> >
> > Not all @st.com email address are concerned, only people who have
> > a specific @foss.st.com email will see their entry updated.
> > For
On Wed, 27 Oct 2021 14:56:35 +0100,
Patrice CHOTARD wrote:
>
> Hi Marc
>
> +Joe Perches
>
> On 10/27/21 8:11 AM, Patrice CHOTARD wrote:
> > Hi Marc
> >
> > On 10/20/21 1:39 PM, Marc Zyngier wrote:
> >> On Wed, 20 Oct 2021 08:45:02 +0100,
> >
Hi all,
On 2021-12-22 19:31, Dmitry Osipenko wrote:
22.12.2021 22:30, Jon Hunter пишет:
On 22/12/2021 19:01, Dmitry Osipenko wrote:
...
diff --git a/drivers/gpu/host1x/syncpt.c
b/drivers/gpu/host1x/syncpt.c
index e08e331e46ae..8194826c9ce3 100644
--- a/drivers/gpu/host1x/syncpt.c
+++ b/dri
On Thu, 10 Dec 2020 19:25:46 +,
Thomas Gleixner wrote:
>
> The irq descriptor is already there, no need to look it up again.
>
> Signed-off-by: Thomas Gleixner
> Cc: Mark Rutland
> Cc: Catalin Marinas
> Cc: Will Deacon
> Cc: Marc Zyngier
> Cc: linux-arm
On Thu, 10 Dec 2020 19:25:45 +,
Thomas Gleixner wrote:
>
> The irq descriptor is already there, no need to look it up again.
>
> Signed-off-by: Thomas Gleixner
> Cc: Marc Zyngier
> Cc: Russell King
> Cc: linux-arm-ker...@lists.infradead.org
> ---
> arch/arm/
Hi Maxime,
On 2020-12-14 15:27, Maxime Ripard wrote:
Hi Marc,
On Thu, Dec 10, 2020 at 05:59:09PM +, Marc Zyngier wrote:
[...]
I'm always sceptical of making interrupt controllers user-selectable.
Who is going to know that they need to pick that one?
I'd be much more in
try is resurrecting Vicentes shutdown change which should
> achieve the same result but in a less drastic way.
>
> Fixes: 63238173b2fa ("Revert drm/rockchip: Allow driver to be shutdown on
> reboot/kexec")
> Cc: Jeffy Chen
> Cc: Robin Murphy
> Cc: Marc Zyng
++
> 9 files changed, 54 insertions(+), 48 deletions(-)
For the irqchip side:
Acked-by: Marc Zyngier
M.
--
Without deviation from the norm, progress is not possible.
On Fri, 18 Jun 2021 20:57:34 +0100,
Yury Norov wrote:
>
> The macros iterate thru all set/clear bits in a bitmap. They search a
> first bit using find_first_bit(), and the rest bits using find_next_bit().
>
> Since find_next_bit() is called shortly after find_first_bit(), we can
> save few lines
Hi David,
On Thu, 24 Jun 2021 04:57:45 +0100,
David Stevens wrote:
>
> From: David Stevens
>
> Return a struct kvm_pfn_page containing both a pfn and an optional
> struct page from the gfn_to_pfn family of functions. This differentiates
> the gup and follow_fault_pfn cases, which allows caller
On Thu, 24 Jun 2021 09:58:00 +0100,
Nicholas Piggin wrote:
>
> Excerpts from David Stevens's message of June 24, 2021 1:57 pm:
> > From: David Stevens
> > out_unlock:
> > if (is_tdp_mmu_root(vcpu->kvm, vcpu->arch.mmu->root_hpa))
> > read_unlock(&vcpu->kvm->mmu_lock);
> > els
On Thu, 24 Jun 2021 04:57:47 +0100,
David Stevens wrote:
>
> From: David Stevens
>
> Avoid converting pfns returned by follow_fault_pfn to struct pages to
> transiently take a reference. The reference was originally taken to
> match the reference taken by gup. However, pfns returned by
> follow
On 2023-05-30 19:21, kernel test robot wrote:
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
branch HEAD: 8c33787278ca8db73ad7d23f932c8c39b9f6e543 Add linux-next
specific files for 20230530
Error/Warning reports:
https://lore.kernel.org/oe-kbuild-all/20
On 2016-05-30 23:58, Javier Martinez Canillas wrote:
> Hello Inki,
>
> On 04/05/2016 04:27 AM, Inki Dae wrote:
>> This patch adds HW trigger support on i80 mode.
>>
>> Until now, Exynos DRM only supported SW trigger which was set
>> SWTRGCMD bit of TRIGCON register by CPU to transfer scanout
>> buf
/0x180
[9.680324] ---[ end trace 90f6c89d62d85ff6 ]---
Instead, let's register a callback that will disable the regulators
on teardown. This allows for the removal of the .remove callbacks,
which are not needed anymore.
Signed-off-by: Marc Zyngier
---
drivers/gpu/drm/tegra/sor.c
> hwtracing/coresight/Kconfig
> Signed-off-by: Mauro Carvalho Chehab
> ---
> Documentation/virt/kvm/arm/pvtime.rst| 2 +-
> virt/kvm/arm/vgic/vgic-mmio-v3.c | 2 +-
> virt/kvm/arm/vgic/vgic.h | 4 ++--
Acked-b
On 2016-06-01 06:53, Inki Dae wrote:
> This patch fixes a regression that Display panel doesn't work
> since HW trigger mode was supported.
>
> The trigger mode should be changed on PSR(Panel Self Refresh)
> mode of Panel device according to HW guy's saying. However,
> with previous HW trigger supp
onnector;
> + struct drm_connector *connector = dp->connector;
> struct drm_display_mode *mode;
> int num_modes = 0;
>
> @@ -103,6 +103,7 @@ static int exynos_dp_bridge_attach(struct
> analogix_dp_plat_data *plat_data,
> int ret;
>
&g
[Thanks Robin for pointing me to that patch.]
Hi Heiko,
On 24/05/18 23:06, Heiko Stübner wrote:
> From: Sandy Huang
>
> The vop irq is shared between vop and iommu and irq probing in the
> iommu driver moved to the probe function recently. This can in some
> cases lead to a stall if the irq is
Hi Heiko,
On 28/05/18 14:20, Heiko Stuebner wrote:
> From: Sandy Huang
>
> The vop irq is shared between vop and iommu and irq probing in the
> iommu driver moved to the probe function recently. This can in some
> cases lead to a stall if the irq is triggered while the vop driver
> still has it
Hi Heiko,
On 12/06/18 13:15, Heiko Stuebner wrote:
> From: Sandy Huang
>
> The vop irq is shared between vop and iommu and irq probing in the
> iommu driver moved to the probe function recently. This can in some
> cases lead to a stall if the irq is triggered while the vop driver
> still has it
ain
> changes in v4:
> - address Marc's comments (clk-enable WARN_ON and style improvement)
>
> Fixes: d0b912bd4c23 ("iommu/rockchip: Request irqs in rk_iommu_probe()")
> Cc: sta...@vger.kernel.org
> Signed-off-by: Sandy Huang
> Signed-off-by: Heiko Stuebner
>
On 18/06/18 09:19, Heiko Stübner wrote:
> Hi Marc,
>
> Am Mittwoch, 13. Juni 2018, 15:01:27 CEST schrieb Marc Zyngier:
>> On 12/06/18 14:20, Heiko Stuebner wrote:
>>> From: Sandy Huang
>>>
>>> The vop irq is shared between vop and iommu and irq probing
Hi all,
On 05/12/2018 14:11, Heiko Stübner wrote:
> Hi Brian,
>
> Am Mittwoch, 5. Dezember 2018, 04:01:34 CET schrieb Brian Norris:
>> + others
>>
>> Hi,
>>
>> On Sun, Aug 05, 2018 at 01:48:07PM +0100, Marc Zyngier wrote:
>>> Leaving the DRM dr
kernel in the kexec case (nothing is expected on that
front).
A cheap way of ensuring that things are nicely shut down is to
register a shutdown callback in the platform driver.
Signed-off-by: Marc Zyngier
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 ++
1 file changed, 6 insertions
behaving correctly, users already know that
because they can see some video output.
Let's keep these messages for cases where we need to actually
debug the driver (we have dynamic debug to enable them at runtime
if need be), and let's keep the kernel quiet otherwise.
Signed-off-by: Ma
On Sat, 07 Sep 2024 10:32:20 +0100,
"Daniel Gomez (Samsung)" wrote:
>
> On Sat, Sep 7, 2024 at 10:33 AM Masahiro Yamada wrote:
> >
> > On Fri, Sep 6, 2024 at 8:01 PM Daniel Gomez via B4 Relay
> > wrote:
> > >
> > > From: Daniel Gomez
> > >
> > > Add documentation under kbuild/llvm to inform ab
Hi Heiko,
On 10/02/18 16:23, Heiko Stuebner wrote:
> Hi Marc,
>
> Am Samstag, 10. Februar 2018, 15:35:01 CET schrieb Marc Zyngier:
>> The rockchip DRM driver is quite careful to disable interrupts
>> when taking a lock that is also taken in interrupt context,
>> which
On 10/02/18 14:20, Marc Zyngier wrote:
> Calling request_irq() followed by disable_irq() is usually a bad idea,
> specially if the interrupt can be pending, and you're not yet in a
> position to handle it.
>
> This is exactly what happens on my kevin system when rebooting
memcpy is only meant to be used for memory, and only that.
MMIO accessors should be used to access MMIO regions, preferably
the ones that correspond to the size of the register accessed.
Let's convert the bulk register copy to writel/readl_relaxed,
which is the correct API.
Signed-off-by:
t kexec to work. There is still
some funny issues at the iommu level, but that's for another day.
Patches on top of 4.16-rc2.
Marc Zyngier (3):
drm/rockchip: Clear all interrupts before requesting the IRQ
drm/rockchip: Do not use memcpy for MMIO addresses
drm/rockchip: Don't use spin_
interrupt is just pure
overhead.
Switching to the non _irqsave version in interrupt context is
more logical, and less heavy handed.
Signed-off-by: Marc Zyngier
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu
rnel.org
Signed-off-by: Marc Zyngier
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index ba7505292b78..7b22
On 28/02/18 14:37, Heiko Stübner wrote:
> Am Dienstag, 30. Januar 2018, 21:28:35 CET schrieb Thierry Escande:
>> From: zain wang
>>
>> The bridge does not need to be powered in analogix_dp_bind(), so
>> remove the calls to pm_runtime_get()/phy_power_on()/analogix_dp_init_dp()
>> as well as their p
m
the previous kernel, and we take it too early, before disable_irq()
could do anything.
A better way of ensuring safety is to set the IRQ_NOAUTOEN flag
on the irq before requesting it.
Cc: sta...@vger.kernel.org
Signed-off-by: Marc Zyngier
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 ++-
interrupt is just pure
overhead.
Switching to the non _irqsave version in interrupt context is
more logical, and less heavy handed.
Signed-off-by: Marc Zyngier
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu
On Sun, 10 Dec 2017 03:05:07 +,
Stefan Schake wrote:
>
> On Fri, Dec 8, 2017 at 11:44 PM, Stefan Wahren wrote:
> > Hi,
> >
> > the commit 253696ccd613 ("drm/vc4: Account for interrupts in flight")
> > triggers a warning during boot of Raspberry Pi 2 with multi_v7_defconfig:
> >
> > [7.96
On Sat, 09 Dec 2017 14:17:58 +,
Stefan Schake wrote:
>
> On Sat, Dec 9, 2017 at 1:34 PM, Marc Zyngier wrote:
> > On Fri, 08 Dec 2017 22:44:27 +,
> > Stefan Wahren wrote:
> >>
> >> Hi,
> >>
> >> the commit 253696ccd613 ("drm/vc4:
On Fri, 08 Dec 2017 22:44:27 +,
Stefan Wahren wrote:
>
> Hi,
>
> the commit 253696ccd613 ("drm/vc4: Account for interrupts in
> flight") triggers a warning during boot of Raspberry Pi 2 with
> multi_v7_defconfig:
>
> [7.962699] vc4_hdmi 3f902000.hdmi: vc4-hdmi-hifi <-> 3f902000.hdmi
> m
, let's use the
pm_runtime framework and take a reference on the device when we're about
to poke it. That is a fairly big hammer, but one that allows the system
to stay alive across dozens of X start/stop sequences.
Signed-off-by: Marc Zyngier
---
drivers/gpu/drm/rockchip/analogix_dp-rock
unnecessary, and only serves as a way
to pointlessly reduce the performance of unsuspecting platforms.
Switch the driver to the _relaxed accessors, making my kevin platform
a slightly better machine.
Signed-off-by: Marc Zyngier
---
drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 488
On 19/12/17 08:53, Andrzej Hajda wrote:
> On 18.12.2017 12:39, Marc Zyngier wrote:
>> The analogix DP bridge is entierely driven via MMIO accesses, and
>> does not do any DMA that requires coherency with the CPU. Yet, the
>> driver uses the non-relaxed accessors, forcing str
On 19/12/17 07:55, Andrzej Hajda wrote:
> On 18.12.2017 12:28, Marc Zyngier wrote:
>> Stopping the X display manager on a kevin platform results in the
>> following crash:
>>
>> [ 674.833536] Synchronous External Abort: synchronous external abort
>> (
On Wed, 11 Dec 2024 00:37:34 +,
Pavan Kondeti wrote:
>
> On Tue, Dec 10, 2024 at 09:24:03PM +, Marc Zyngier wrote:
> > > +static int a6xx_switch_secure_mode(struct msm_gpu *gpu)
> > > +{
> > > + int ret;
> > > +
> > > +#ifd
On Mon, 09 Dec 2024 08:19:15 +,
Akhil P Oommen wrote:
>
> When kernel is booted in EL2, SECVID registers are accessible to the
> KMD. So we can use that to switch GPU's secure mode to avoid dependency
> on Zap firmware. Also, we can't load a secure firmware without a
> hypervisor that support
On Thu, 12 Dec 2024 05:31:00 +,
Pavan Kondeti wrote:
>
> On Wed, Dec 11, 2024 at 10:40:02AM +, Marc Zyngier wrote:
> > On Wed, 11 Dec 2024 00:37:34 +,
> > Pavan Kondeti wrote:
> > >
> > > On Tue, Dec 10, 2024 at 09:24:03PM +, Marc
64 matches
Mail list logo
