[PATCH RFC 8/8] drm/i915: Add support for DP link training compliance

2016-10-19 Thread Manasi Navare
sent in order to trigger another modeset during which the pipe is configured and link is enabled for link parameters requested by the test. Signed-off-by: Manasi Navare Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala --- drivers/gpu/drm/i915/intel_dp.c | 72

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-03-30 Thread Manasi Navare
On Thu, Mar 30, 2017 at 05:37:55PM -0700, Eric Anholt wrote: > Martin Peres writes: > > > On 26/01/17 14:37, Martin Peres wrote: > >> Despite all the careful planing of the kernel, a link may become > >> insufficient to handle the currently-set mode. At this point, the > >> kernel should mark thi

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-03-31 Thread Manasi Navare
On Fri, Mar 31, 2017 at 01:08:41PM -0700, Eric Anholt wrote: > Manasi Navare writes: > > > On Thu, Mar 30, 2017 at 05:37:55PM -0700, Eric Anholt wrote: > >> Martin Peres writes: > >> > >> > On 26/01/17 14:37, Martin Peres wrote: > >> >>

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-02 Thread Manasi Navare
On Sun, Apr 02, 2017 at 07:21:09PM -0700, Eric Anholt wrote: > Daniel Vetter writes: > > > On Fri, Mar 31, 2017 at 05:22:09PM -0700, Eric Anholt wrote: > >> Manasi Navare writes: > >> > >> > On Fri, Mar 31, 2017 at 01:08:41PM -0700, Eric A

Re: [Intel-gfx] [PATCH v3] drm: Add DPCD definitions for DP 1.4 DSC feature

2017-04-03 Thread Manasi Navare
On Thu, Mar 16, 2017 at 03:47:46PM +0200, Ander Conselvan De Oliveira wrote: > On Tue, 2017-03-14 at 13:01 -0700, Manasi Navare wrote: > > From: "Navare, Manasi D" > > > > Display stream compression is supported on DP 1.4 DP > > devices. This patch add

[PATCH v4] drm: Add DPCD definitions for DP 1.4 DSC feature

2017-04-03 Thread Manasi Navare
on drm-tip Signed-off-by: Manasi Navare Cc: Jani Nikula Cc: Paulo Zanoni Cc: dri-devel@lists.freedesktop.org --- include/drm/drm_dp_helper.h | 107 1 file changed, 107 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h ind

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-05 Thread Manasi Navare
On Mon, Apr 03, 2017 at 09:19:35AM +0200, Daniel Vetter wrote: > On Mon, Apr 3, 2017 at 8:25 AM, Manasi Navare > wrote: > >> So in that case you do need userspace to re-request the same mode at the > >> same bpp? > > > > So yes because when userspac

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-04-06 Thread Manasi Navare
On Sun, Apr 02, 2017 at 07:21:09PM -0700, Eric Anholt wrote: > Daniel Vetter writes: > > > On Fri, Mar 31, 2017 at 05:22:09PM -0700, Eric Anholt wrote: > >> Manasi Navare writes: > >> > >> > On Fri, Mar 31, 2017 at 01:08:41PM -0700, Eric A

Re: [PATCH v4] drm: Add DPCD definitions for DP 1.4 DSC feature

2017-04-06 Thread Manasi Navare
Hi Ander, Could you take a look at this? Manasi On Mon, Apr 03, 2017 at 03:51:10PM -0700, Manasi Navare wrote: > From: "Navare, Manasi D" > > Display stream compression is supported on DP 1.4 DP > devices. This patch adds the corersponding DPCD > register definitions

Re: [PATCH v6 01/12] drm/atomic: Handle picture_aspect_ratio in atomic core

2017-05-01 Thread Manasi Navare
On Mon, May 01, 2017 at 03:37:53PM +0200, Maarten Lankhorst wrote: > This is only used in i915, which had used its own non-taomic way to > deal with the picture aspect ratio. Move selected aspect_ratio to > atomic state and use the atomic state in the affected i915 connectors. > Please correct the

Re: [PATCH v2 1/2] drm: Introduce crtc->mode_valid() callback

2017-05-03 Thread Manasi Navare
On Fri, Apr 28, 2017 at 02:47:11PM +0100, Jose Abreu wrote: > Some crtc's may have restrictions in the mode they can display. In > this patch a new callback (crtc->mode_valid()) is introduced that > is called at the same stage of connector->mode_valid() callback. > > This shall be implemented if t

[PATCH v5 1/4] drm/i915: Add support for DP link training compliance

2017-01-24 Thread Manasi Navare
(Jani Nikula) Signed-off-by: Manasi Navare Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala --- drivers/gpu/drm/i915/intel_dp.c | 65 drivers/gpu/drm/i915/intel_drv.h | 2 ++ 2 files changed, 61 insertions(+), 6 deletions(-) diff --git a/drivers/gpu

[PATCH v4 4/4] drm/i915: Add support for DP Video pattern compliance tests

2017-01-24 Thread Manasi Navare
ction (Jani Nikula) v4: *Return TEST_NAK on read failures and invalid values (Jani Nikula) * Address CRC mismatch errors v3: * Use the updated properly shifted bit definitions (Jani Nikula) * Force dithering to be disabled on 18bpp compliance test request (Manasi Navare) v2: * Updated the DPCD Reg

Re: [Intel-gfx] [PATCH 0/4] Add automation support for DP Compliance (Rev 6)

2017-01-24 Thread Manasi Navare
On Tue, Jan 24, 2017 at 06:40:51PM +0200, Jani Nikula wrote: > On Mon, 23 Jan 2017, Manasi Navare wrote: > > As far as I know, I have addressed the review comments from previous > > round and answered the questions/concerns that you had either in the > > M-L or in IRC. May

Re: [Intel-gfx] [PATCH 0/2] drm: link status property and DP link training failure handling

2017-01-24 Thread Manasi Navare
On Fri, Jan 20, 2017 at 06:27:29PM +0200, Martin Peres wrote: > On 19/01/17 13:34, Ville Syrjälä wrote: > >On Wed, Jan 18, 2017 at 11:05:18PM +0200, Martin Peres wrote: > >>On 16/12/16 15:48, Daniel Vetter wrote: > >>>On Fri, Dec 16, 2016 at 12:29:05PM +0200, Jani Nikula wrote: > The two remain

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-01-31 Thread Manasi Navare
On Thu, Jan 26, 2017 at 06:21:20PM +0100, Daniel Vetter wrote: > On Thu, Jan 26, 2017 at 02:37:28PM +0200, Martin Peres wrote: > > Despite all the careful planing of the kernel, a link may become > > insufficient to handle the currently-set mode. At this point, the > > kernel should mark this parti

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-01 Thread Manasi Navare
On Thu, Jan 26, 2017 at 02:37:28PM +0200, Martin Peres wrote: > Despite all the careful planing of the kernel, a link may become > insufficient to handle the currently-set mode. At this point, the > kernel should mark this particular configuration as being broken > and potentially prune the mode be

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-01 Thread Manasi Navare
On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote: > Jani Nikula writes: > > > On Tue, 31 Jan 2017, Eric Anholt wrote: > >> Martin Peres writes: > >> > >>> Despite all the careful planing of the kernel, a link may become > >>> insufficient to handle the currently-set mode. At this poi

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-02 Thread Manasi Navare
On Fri, Feb 03, 2017 at 01:30:14AM +0200, Martin Peres wrote: > On 01/02/17 22:05, Manasi Navare wrote: > >On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote: > >>Jani Nikula writes: > >> > >>>On Tue, 31 Jan 2017, Eric Anholt wrote: > >>&

Do no reset the max link parameters when userspace reprobes modes

2017-02-06 Thread Manasi Navare
Hi, I am working on a solution for handling link failures during or after the modeset. In case of link failure, the max link rate/lane count values are updated to lower link rate/lane count as per the spec and uevent is sent to the userspace with link-status BAD. The userspace is expected to fir

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-13 Thread Manasi Navare
On Mon, Feb 13, 2017 at 01:05:17PM -0800, Eric Anholt wrote: > Martin Peres writes: > > > On 06/02/17 17:50, Martin Peres wrote: > >> On 03/02/17 10:04, Daniel Vetter wrote: > >>> On Fri, Feb 03, 2017 at 01:30:14AM +0200, Martin Peres wrote: > >>

[PATCH] drm: Add DPCD definitions for DP 1.4 DSC feature

2017-02-15 Thread Manasi Navare
Display stream compression is supported on DP 1.4 DP devices. This patch adds the corersponding DPCD register definitions for DSC. Signed-off-by: Manasi Navare Cc: Jani Nikula Cc: Paulo Zanoni Cc: dri-devel@lists.freedesktop.org --- include/drm/drm_dp_helper.h | 102

[PATCH v2] drm: Add DPCD definitions for DP 1.4 DSC feature

2017-02-16 Thread Manasi Navare
Display stream compression is supported on DP 1.4 DP devices. This patch adds the corersponding DPCD register definitions for DSC. v2: * Rebased on drm-tip Signed-off-by: Manasi Navare Cc: Jani Nikula Cc: Paulo Zanoni Cc: dri-devel@lists.freedesktop.org --- include/drm/drm_dp_helper.h | 102

Re: [RFC PATCH xserver] modesetting: re-set the crtc's mode when link-status goes BAD

2017-02-24 Thread Manasi Navare
n Peres wrote: > >>>> On 01/02/17 22:05, Manasi Navare wrote: > >>>>> On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote: > >>>>>> Jani Nikula writes: > >>>>>> > >>>>>>> On Tue, 31 Jan 2017, E

[Intel-gfx] [PATCH 5/5] drm/i915: Implement Link Rate fallback on Link training failure

2016-11-11 Thread Manasi Navare
On Fri, Nov 11, 2016 at 04:08:26PM +0200, Ville Syrjälä wrote: > On Thu, Nov 10, 2016 at 09:58:31PM +0100, Daniel Vetter wrote: > > On Wed, Nov 09, 2016 at 08:42:08PM -0800, Manasi Navare wrote: > > > @@ -5692,6 +5751,39 @@ static bool intel_edp_init_connector(struct > &

[Intel-gfx] [PATCH 5/5] drm/i915: Implement Link Rate fallback on Link training failure

2016-11-11 Thread Manasi Navare
On Fri, Nov 11, 2016 at 11:41:22AM +0200, Jani Nikula wrote: > On Thu, 10 Nov 2016, Daniel Vetter wrote: > > On Wed, Nov 09, 2016 at 08:42:08PM -0800, Manasi Navare wrote: > >> @@ -5692,6 +5751,39 @@ static bool intel_edp_init_connector(struct > >> intel_dp *int

[PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-09 Thread Manasi Navare
: Manasi Navare --- drivers/gpu/drm/drm_atomic_helper.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 5007796..aeecf2f 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm

[PATCH 0/5] Handle Link Training Failure during modeset

2016-11-09 Thread Manasi Navare
status property to BAD. Userspace should triiger another modeset on a uevent and if link status property is BAD. This will retrain the link at fallback values. This is repeated until the link is successfully trained. This has been validated to pass DP compliance. Manasi Navare (5): drm: Add a new

[PATCH 5/5] drm/i915: Implement Link Rate fallback on Link training failure

2016-11-09 Thread Manasi Navare
shed a few patches (Jani Nikula) Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/intel_ddi.c | 21 +- drivers/gpu/drm/i915/intel_dp.c | 104 +- drivers/gpu/drm/i915/intel_dp_lin

[PATCH 1/5] drm: Add a new connector property for link status

2016-11-09 Thread Manasi Navare
le Syrjala) v2: * Make this a default connector property (Daniel Vetter) Cc: dri-devel at lists.freedesktop.org Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Cc: Chris Wilson Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_connector.c | 17 + include/drm/drm_c

[PATCH 2/5] drm/i915: Set link status property for DP connector

2016-11-09 Thread Manasi Navare
Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Cc: Chris Wilson Signed-off-by: Manasi Navare Reviewed-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dp.c | 12 drivers/gpu/drm/i915/intel_drv.h | 2 ++ 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/i

[PATCH 4/5] drm/i915: Find fallback link rate/lane count

2016-11-09 Thread Manasi Navare
Nikula) Cc: Ville Syrjala Cc: Jani Nikula Cc: Daniel Vetter Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/intel_dp.c | 42 drivers/gpu/drm/i915/intel_drv.h | 6 ++ 2 files changed, 48 insertions(+) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 0/5] Handle Link Training Failure during modeset

2016-11-13 Thread Manasi Navare
y > Cc: Deucher, Alexander ; 'Jani Nikula' > ; Manasi Navare intel.com>; dri-devel at lists.freedesktop.org; intel-gfx at > lists.freedesktop.org; Wentland, Harry ; Peres, > Martin > Subject: Re: [Intel-gfx] [PATCH 0/5] Handle Link Training Failure during > modeset >

[Intel-gfx] [PATCH 0/5] Handle Link Training Failure during modeset

2016-11-14 Thread Manasi Navare
so going to just hide unsupported mode by doing pre-train. > > -Original Message- > From: Daniel Vetter [mailto:daniel.vetter at ffwll.ch] On Behalf Of Daniel > Vetter > Sent: Monday, November 14, 2016 3:04 AM > To: Manasi Navare > Cc: Cheng, Tony ; intel-gfx at lis

[PATCH 0/5] Handle Link Training Failure during modeset

2016-11-14 Thread Manasi Navare
> Thanks for the review. I am already moving Patch 2 set_link_status to the drm core as per Daniel and Ville's suggestion. I will make those changes and submit the new patches by EOD today. Regards Manasi > On 2016-11-09 11:42 PM, Manasi Navare wrote: > >Link training failure is

[PATCH 1/5] drm: Add a new connector property for link status

2016-11-14 Thread Manasi Navare
le Syrjala) v2: * Make this a default connector property (Daniel Vetter) Reviewed-by: Harry Wentland Cc: dri-devel at lists.freedesktop.org Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Cc: Chris Wilson Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_connec

[PATCH 2/5] drm: Set DRM connector link status property

2016-11-14 Thread Manasi Navare
handle link training failures, but it is not limited to DP or link training. For example, if we implement asynchronous setcrtc, we can use this to report any failures in that. Cc: dri-devel at lists.freedesktop.org Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare

[PATCH 5/5] drm/i915: Implement Link Rate fallback on Link training failure

2016-11-14 Thread Manasi Navare
ed and link_status to indicate same thing (Jani Nikula) v2: * Squashed a few patches (Jani Nikula) Acked-by: Tony Cheng Acked-by: Harry Wentland Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/intel_ddi.c | 21 +- dr

[PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-14 Thread Manasi Navare
: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_atomic_helper.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 5007796..aeecf2f 100644 --- a/drivers/gpu/drm

[PATCH 4/5] drm/i915: Find fallback link rate/lane count

2016-11-14 Thread Manasi Navare
Nikula) Acked-by: Tony Cheng Acked-by: Harry Wentland Cc: Ville Syrjala Cc: Jani Nikula Cc: Daniel Vetter Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/intel_dp.c | 42 drivers/gpu/drm/i915/intel_drv.h | 6 ++ 2 files changed, 48

[PATCH 0/5] Handle link training failure during modeset

2016-11-14 Thread Manasi Navare
improving user experience on link training failures, by avoiding black screens. Acked-by: Tony Cheng Acked-by: Harry Wentland Manasi Navare (5): drm: Add a new connector property for link status drm: Set DRM connector link status property drm/i915: Update CRTC state if connector link status pr

[PATCH 2/5] drm: Set DRM connector link status property

2016-11-14 Thread Manasi Navare
property. Manasi On Mon, Nov 14, 2016 at 07:13:20PM -0800, Manasi Navare wrote: > In the usual working scenarios, this property is "Good". > If something fails during modeset, the DRM driver can > set the link status to "Bad", prune the mode list based on the > link

[Intel-gfx] [PATCH 2/5] drm: Set DRM connector link status property

2016-11-15 Thread Manasi Navare
On Tue, Nov 15, 2016 at 08:49:21AM +0100, Daniel Vetter wrote: > On Mon, Nov 14, 2016 at 07:13:20PM -0800, Manasi Navare wrote: > > In the usual working scenarios, this property is "Good". > > If something fails during modeset, the DRM driver can > > set the link

[Intel-gfx] [PATCH 2/5] drm: Set DRM connector link status property

2016-11-15 Thread Manasi Navare
On Tue, Nov 15, 2016 at 08:53:27AM +0100, Daniel Vetter wrote: > On Mon, Nov 14, 2016 at 07:13:20PM -0800, Manasi Navare wrote: > > In the usual working scenarios, this property is "Good". > > If something fails during modeset, the DRM driver can > > set the link

[PATCH v2 2/5] drm: Set DRM connector link status property

2016-11-15 Thread Manasi Navare
el Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_connector.c | 36 include/drm/drm_connector.h | 2 ++ 2 files changed, 38 insertions(+) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c in

[PATCH 4/5] drm/i915: Find fallback link rate/lane count

2016-11-16 Thread Manasi Navare
Manasi On Mon, Nov 14, 2016 at 07:13:22PM -0800, Manasi Navare wrote: > If link training fails, then we need to fallback to lower > link rate first and if link training fails at RBR, then > fallback to lower lane count. > This function finds the next lower link rate/lane count > v

[PATCH 5/5] drm/i915: Implement Link Rate fallback on Link training failure

2016-11-16 Thread Manasi Navare
Jani/Ville could you please review this patch? This has been ACKed by DRM and is good from DRM point fo view. But I need r-b from either of you for this to get merged. Regards Manasi On Mon, Nov 14, 2016 at 07:13:23PM -0800, Manasi Navare wrote: > If link training at a link rate optimal fo

[PATCH] drm: document standard connector properties

2016-11-16 Thread Manasi Navare
? Also do I need to explicitly add this subsection in Documentation/gpu/drm-kms.rst file? Other than that looks good. Manasi Reviewed-by: Manasi Navare > Cc: Manasi Navare > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_connector.c | 42 > +

[PATCH 4/5] drm/i915: Find fallback link rate/lane count

2016-11-17 Thread Manasi Navare
On Thu, Nov 17, 2016 at 02:58:46PM +0200, Jani Nikula wrote: > On Tue, 15 Nov 2016, Manasi Navare wrote: > > If link training fails, then we need to fallback to lower > > link rate first and if link training fails at RBR, then > > fallback to lower lane count. > > T

[Intel-gfx] [PATCH 0/5] Handle link training failure during modeset

2016-11-17 Thread Manasi Navare
On Thu, Nov 17, 2016 at 02:29:30PM +0200, Jani Nikula wrote: > On Tue, 15 Nov 2016, Manasi Navare wrote: > > Submitting new series that adds proper commit messages/cover letter > > and kernel documentation. It also moved the set_link_status function > > to drm core so oth

[PATCH 5/5] drm/i915: Implement Link Rate fallback on Link training failure

2016-11-17 Thread Manasi Navare
On Thu, Nov 17, 2016 at 02:49:02PM +0200, Jani Nikula wrote: > On Tue, 15 Nov 2016, Manasi Navare wrote: > > If link training at a link rate optimal for a particular > > mode fails during modeset's atomic commit phase, then we > > let the modeset complete and then re

[Intel-gfx] [PATCH 3/3] drm/dp/mst: Track available time slots in DP Multi-Stream Transport Packet

2016-11-17 Thread Manasi Navare
On Thu, Nov 17, 2016 at 06:03:48PM -0800, Dhinakaran Pandiyan wrote: > The avail_slots member in struct drm_dp_mst_topology_mgr does not really > track the available time slots in a MTP(Multi-Stream Transport Packet). It > is assigned an initial value when the topology manager is setup but not > up

[PATCH] drm: document standard connector properties

2016-11-17 Thread Manasi Navare
t; start. > > I typed this to give Manasi a place to add her new link status > property documentation. > > v2: forgot to git add all the bits (Manasi). > > v3: Be more epxlicit about integrated tiled panels (Archit) > Reviewed-by: Manasi Navare > Cc: Manasi Nav

[PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-17 Thread Manasi Navare
: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_atomic_helper.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 0b16587..2125fd1 100644 --- a/drivers/gpu/drm

[PATCH 0/5] Link Training failure handling during modeset

2016-11-17 Thread Manasi Navare
to report any failures in that. Finally, while DP CTS compliance is advertized (which is great, and could be made to work similarly for all drm drivers), this can be used for the more important goal of improving user experience on link training failures, by avoiding black screens. Manasi Navare (5):

[PATCH 4/5] drm/i915: Find fallback link rate/lane count

2016-11-17 Thread Manasi Navare
that using the helper intel_dp_link_rate_index (Jani Nikula) v2: Squash the patch that returns the link rate index (Jani Nikula) Acked-by: Tony Cheng Acked-by: Harry Wentland Cc: Ville Syrjala Cc: Jani Nikula Cc: Daniel Vetter Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/intel_dp.c

[PATCH 5/5] drm/i915: Implement Link Rate fallback on Link training failure

2016-11-17 Thread Manasi Navare
g Acked-by: Harry Wentland Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/intel_dp.c | 63 ++- drivers/gpu/drm/i915/intel_dp_link_training.c | 28 +++- drivers/gpu/drm/i915/intel_drv.h

[PATCH 2/5] drm: Set DRM connector link status property

2016-11-17 Thread Manasi Navare
er) Cc: dri-devel at lists.freedesktop.org Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_connector.c | 37 + include/drm/drm_connector.h | 2 ++ 2 files changed, 39 insertions(+) diff --git a/drivers/gpu/drm/drm_c

[PATCH 1/5] drm: Add a new connector property for link status

2016-11-17 Thread Manasi Navare
i Nikula) * Add link status member to store property value locally (Ville Syrjala) v2: * Make this a default connector property (Daniel Vetter) Reviewed-by: Harry Wentland Cc: dri-devel at lists.freedesktop.org Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Cc: Chris Wilson Signed-off-by: Ma

[PATCH 4/5] drm/i915: Find fallback link rate/lane count

2016-11-17 Thread Manasi Navare
: Manasi Navare --- drivers/gpu/drm/i915/intel_dp.c | 40 drivers/gpu/drm/i915/intel_drv.h | 4 2 files changed, 44 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 90283ed..4fb89e1 100644 --- a

[PATCH 5/5] drm/i915: Implement Link Rate fallback on Link training failure

2016-11-17 Thread Manasi Navare
shed a few patches (Jani Nikula) Acked-by: Tony Cheng Acked-by: Harry Wentland Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/intel_dp.c | 63 ++- drivers/gpu/drm/i915/intel_dp_li

[PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-18 Thread Manasi Navare
On Fri, Nov 18, 2016 at 04:11:47PM +0200, Ville Syrjälä wrote: > On Fri, Nov 18, 2016 at 02:50:52PM +0100, Maarten Lankhorst wrote: > > Op 18-11-16 om 08:13 schreef Manasi Navare: > > > CRTC state connector_changed needs to be set to true > > > if connector link status

[PATCH 5/5] drm/i915: Implement Link Rate fallback on Link training failure

2016-11-18 Thread Manasi Navare
On Fri, Nov 18, 2016 at 03:31:48PM +0200, Jani Nikula wrote: > On Fri, 18 Nov 2016, Manasi Navare wrote: > > If link training at a link rate optimal for a particular > > mode fails during modeset's atomic commit phase, then we > > let the modeset complete and then re

[PATCH 4/5] drm/i915: Find fallback link rate/lane count

2016-11-18 Thread Manasi Navare
On Fri, Nov 18, 2016 at 03:22:49PM +0200, Jani Nikula wrote: > On Fri, 18 Nov 2016, Manasi Navare wrote: > > If link training fails, then we need to fallback to lower > > link rate first and if link training fails at RBR, then > > fallback to lower lane count. > > T

[Intel-gfx] [PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-18 Thread Manasi Navare
t; > > Op 18-11-16 om 15:11 schreef Ville Syrjälä: > > > > > On Fri, Nov 18, 2016 at 02:50:52PM +0100, Maarten Lankhorst wrote: > > > > >> Op 18-11-16 om 08:13 schreef Manasi Navare: > > > > >>> CRTC state connector_changed needs to be s

[Intel-gfx] [PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-18 Thread Manasi Navare
ri, Nov 18, 2016 at 02:50:52PM +0100, Maarten Lankhorst wrote: > > > >> Op 18-11-16 om 08:13 schreef Manasi Navare: > > > >>> CRTC state connector_changed needs to be set to true > > > >>> if connector link status property has changed. This will tell

[Intel-gfx] [PATCH 4/5] drm/i915: Find fallback link rate/lane count

2016-11-18 Thread Manasi Navare
On Fri, Nov 18, 2016 at 07:39:50AM -0800, Manasi Navare wrote: > On Fri, Nov 18, 2016 at 03:22:49PM +0200, Jani Nikula wrote: > > On Fri, 18 Nov 2016, Manasi Navare wrote: > > > If link training fails, then we need to fallback to lower > > > link rate first and if link

[PATCH v5 1/5] drm: Add a new connector property for link status

2016-11-18 Thread Manasi Navare
ot;link training" from description since this is not specific to DP (Jani Nikula) * Add link status member to store property value locally (Ville Syrjala) v2: * Make this a default connector property (Daniel Vetter) Reviewed-by: Harry Wentland Cc: dri-devel at lists.freedesktop.org Cc: Jani

[PATCH v3 2/5] drm: Set DRM connector link status property

2016-11-18 Thread Manasi Navare
er) Cc: dri-devel at lists.freedesktop.org Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_connector.c | 37 + include/drm/drm_connector.h | 2 ++ 2 files changed, 39 insertions(+) diff --git a/drivers/gpu/drm/drm_c

[PATCH v6 4/56 4/56 4/56 4/56 4/56 4/5] drm/i915: Find fallback link rate/lane count

2016-11-18 Thread Manasi Navare
Acked-by: Harry Wentland Cc: Ville Syrjala Cc: Jani Nikula Cc: Daniel Vetter Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/intel_dp.c | 40 drivers/gpu/drm/i915/intel_drv.h | 4 2 files changed, 44 insertions(+) diff --git a/drivers/gpu/drm

[PATCH v8 5/5] drm/i915: Implement Link Rate fallback on Link training failure

2016-11-18 Thread Manasi Navare
k_train_failed and link_status to indicate same thing (Jani Nikula) v2: * Squashed a few patches (Jani Nikula) Acked-by: Tony Cheng Acked-by: Harry Wentland Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/intel_dp.c

[PATCH 0/5] Clean series for Link training failure handling

2016-11-18 Thread Manasi Navare
and could be made to work similarly for all drm drivers), this can be used for the more important goal of improving user experience on link training failures, by avoiding black screens. Manasi Navare (5): drm: Add a new connector property for link status drm: Set DRM connector link status property

[PATCH 2/5] drm: Set DRM connector link status property

2016-11-18 Thread Manasi Navare
er) Cc: dri-devel at lists.freedesktop.org Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_connector.c | 37 + include/drm/drm_connector.h | 2 ++ 2 files changed, 39 insertions(+) diff --git a/drivers/gpu/drm/drm_c

[PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-18 Thread Manasi Navare
: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_atomic_helper.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 0b16587..2125fd1 100644 --- a/drivers/gpu/drm

[PATCH 5/5] drm/i915: Implement Link Rate fallback on Link training failure

2016-11-18 Thread Manasi Navare
k_train_failed and link_status to indicate same thing (Jani Nikula) v2: * Squashed a few patches (Jani Nikula) Acked-by: Tony Cheng Acked-by: Harry Wentland Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/intel_dp.c

[PATCH 1/5] drm: Add a new connector property for link status

2016-11-18 Thread Manasi Navare
ot;link training" from description since this is not specific to DP (Jani Nikula) * Add link status member to store property value locally (Ville Syrjala) v2: * Make this a default connector property (Daniel Vetter) Reviewed-by: Harry Wentland Cc: dri-devel at lists.freedesktop.org Cc: Jani

[PATCH 4/5] drm/i915: Find fallback link rate/lane count

2016-11-18 Thread Manasi Navare
Acked-by: Harry Wentland Cc: Ville Syrjala Cc: Jani Nikula Cc: Daniel Vetter Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/intel_dp.c | 40 drivers/gpu/drm/i915/intel_drv.h | 4 2 files changed, 44 insertions(+) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-21 Thread Manasi Navare
gt; On Fri, Nov 18, 2016 at 09:44:49AM -0800, Manasi Navare wrote: > > > > > On Fri, Nov 18, 2016 at 06:21:21PM +0200, Ville Syrjälä wrote: > > > > > > On Fri, Nov 18, 2016 at 04:35:25PM +0100, Daniel Vetter wrote: > > > > > > > On Fri, Nov

[Intel-gfx] [PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-21 Thread Manasi Navare
On Mon, Nov 21, 2016 at 08:46:19PM +, Chris Wilson wrote: > On Mon, Nov 21, 2016 at 11:00:52AM -0800, Manasi Navare wrote: > > On Mon, Nov 21, 2016 at 04:48:07PM +0100, Daniel Vetter wrote: > > > On Mon, Nov 21, 2016 at 11:10:45AM +0100, Daniel Vetter wrote: > > > &

[PATCH 2/5] drm/i915: Fixes to support DP Compliance EDID tests

2016-11-22 Thread Manasi Navare
This patch addresses a few issues from the original patch for DP Compliance EDID test support submitted by Todd Previte Video Mode requested in the EDID test handler for the EDID Read test (CTS 4.2.2.3) should be set to PREFERRED as per the CTS spec. Signed-off-by: Manasi Navare Cc: Jani Nikula

[PATCH 3/5] Add support for forcing 6 bpc on DP pipes.

2016-11-22 Thread Manasi Navare
BPC value in intel_dp structure has a non-zero value and we're on a display port connector, then we use the value to calculate the bpp for the pipe. For cases where we are not on DP or there has not been an overridden value then we behave as normal. Signed-off-by: Jim Bride Signed-off-by: M

[PATCH 5/5] drm/i915: Add support for DP Video pattern compliance tests

2016-11-22 Thread Manasi Navare
operations can be completed without the risk of interruption from the userspace app that is polling on that flag. Signed-off-by: Manasi Navare Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala --- drivers/gpu/drm/i915/i915_debugfs.c | 14 +++- drivers/gpu/drm/i915/intel_dp.c | 68

[PATCH 0/5] Add Automation support for DP compliance testing

2016-11-22 Thread Manasi Navare
ffers and triggers a modeset. Jim Bride (1): Add support for forcing 6 bpc on DP pipes. Manasi Navare (4): drm/i915: Add support for DP link training compliance drm/i915: Fixes to support DP Compliance EDID tests drm: Add definitions for DP compliance Video pattern tests drm/i915: Add su

[PATCH 4/5] drm: Add definitions for DP compliance Video pattern tests

2016-11-22 Thread Manasi Navare
Cc: dri-devel at lists.freedesktop.org Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- include/drm/drm_dp_helper.h | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_dp_helper.h b/include/drm

[PATCH 1/5] drm/i915: Add support for DP link training compliance

2016-11-22 Thread Manasi Navare
sent in order to trigger another modeset during which the pipe is configured and link is retrained and enabled for link parameters requested by the test. Signed-off-by: Manasi Navare Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala --- drivers/gpu/drm/i915/intel_dp.c | 73

[Intel-gfx] [PATCH 3/5] drm/i915: Update CRTC state if connector link status property changed

2016-11-22 Thread Manasi Navare
gt; On Fri, Nov 18, 2016 at 09:44:49AM -0800, Manasi Navare wrote: > > > > > On Fri, Nov 18, 2016 at 06:21:21PM +0200, Ville Syrjälä wrote: > > > > > > On Fri, Nov 18, 2016 at 04:35:25PM +0100, Daniel Vetter wrote: > > > > > > > On Fri, Nov

[PATCH RFC] drm: Add a new connector atomic property for link status

2016-11-22 Thread Manasi Navare
Syrjala Cc: Chris Wilson Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_atomic.c| 5 drivers/gpu/drm/drm_connector.c | 65 +++-- include/drm/drm_connector.h | 12 +++- include/drm/drm_mode_config.h | 5 include/uapi/drm

[PATCH RFC] drm: Add a new connector atomic property for link status

2016-11-23 Thread Manasi Navare
On Wed, Nov 23, 2016 at 11:00:59AM +0100, Daniel Vetter wrote: > On Tue, Nov 22, 2016 at 05:30:21PM -0800, Manasi Navare wrote: > > This is RFC patch for adding a connector link-status property > > and making it atomic by adding it to the drm_connector_state. > > This is t

[PATCH 1/5] drm/i915: Add support for DP link training compliance

2016-11-23 Thread Manasi Navare
On Wed, Nov 23, 2016 at 03:07:30PM +0200, Jani Nikula wrote: > On Tue, 22 Nov 2016, Manasi Navare wrote: > > This patch adds support to handle automated DP compliance > > link training test requests. This patch has been tested with > > Unigraf DPR-120 DP Compliance de

[PATCH RFC v2] drm: Add a new connector atomic property for link status

2016-11-23 Thread Manasi Navare
set link status from Good To Bad (Daniel Vetter) Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Cc: Sean Paul Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_atomic.c| 10 ++ drivers/gpu/drm/drm_atomic_helper.c | 8 + drivers/gpu/drm/drm_conne

[PATCH RFC v3] drm: Add a new connector atomic property for link status

2016-11-23 Thread Manasi Navare
(Daniel Vetter) * Never allow userspace to set link status from Good To Bad (Daniel Vetter) Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Cc: Chris Wilson Cc: Sean Paul Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_atomic.c| 10 ++ drivers/gpu/drm/drm_atomi

[PATCH RFC v3] drm: Add a new connector atomic property for link status

2016-11-28 Thread Manasi Navare
On Thu, Nov 24, 2016 at 08:51:35AM +0100, Daniel Vetter wrote: > On Wed, Nov 23, 2016 at 11:28:21PM -0800, Manasi Navare wrote: > > This is RFC patch for adding a connector link-status property > > and making it atomic by adding it to the drm_connector_state. > > This is t

[PATCH RFC] drm: Add a new connector atomic property for link status

2016-11-28 Thread Manasi Navare
On Wed, Nov 23, 2016 at 09:09:28AM +0100, Daniel Vetter wrote: > On Tue, Nov 22, 2016 at 09:27:35PM -0500, Sean Paul wrote: > > On Tue, Nov 22, 2016 at 8:30 PM, Manasi Navare > > wrote: > > > This is RFC patch for adding a connector link-status property > > > and

[PATCH RFC v3] drm: Add a new connector atomic property for link status

2016-11-28 Thread Manasi Navare
On Thu, Nov 24, 2016 at 08:51:35AM +0100, Daniel Vetter wrote: > On Wed, Nov 23, 2016 at 11:28:21PM -0800, Manasi Navare wrote: > > This is RFC patch for adding a connector link-status property > > and making it atomic by adding it to the drm_connector_state. > > This is t

[PATCH RFC v3] drm: Add a new connector atomic property for link status

2016-11-29 Thread Manasi Navare
On Tue, Nov 29, 2016 at 09:59:14AM +0100, Daniel Vetter wrote: > On Mon, Nov 28, 2016 at 05:07:52PM -0800, Manasi Navare wrote: > > On Thu, Nov 24, 2016 at 08:51:35AM +0100, Daniel Vetter wrote: > > > On Wed, Nov 23, 2016 at 11:28:21PM -0800, Manasi Navare wrote: > > &

[PATCH RFC] drm: Add a new connector atomic property for link status

2016-11-29 Thread Manasi Navare
On Tue, Nov 29, 2016 at 02:43:55PM -0500, Sean Paul wrote: > On Tue, Nov 29, 2016 at 9:45 AM, Sean Paul wrote: > > On Mon, Nov 28, 2016 at 7:59 PM, Manasi Navare > > wrote: > >> On Wed, Nov 23, 2016 at 09:09:28AM +0100, Daniel Vetter wrote: > >>> On Tue, No

[PATCH 1/3] drm: Add a new connector atomic property for link status

2016-11-29 Thread Manasi Navare
n update_output_state (Daniel Vetter) * Never allow userspace to set link status from Good To Bad (Daniel Vetter) Acked-by: Tony Cheng Acked-by: Harry Wentland Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Cc: Chris Wilson Cc: Sean Paul Signed-off-by: Manasi Navare ---

[PATCH 3/3] drm/i915: Implement Link Rate fallback on Link training failure

2016-11-29 Thread Manasi Navare
le Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/intel_dp.c | 44 +++ drivers/gpu/drm/i915/intel_dp_link_training.c | 25 +-- drivers/gpu/drm/i915/intel_drv.h | 3 ++ 3 files changed, 70 insertions(+), 2 deletion

[PATCH 2/3] drm/i915: Find fallback link rate/lane count

2016-11-29 Thread Manasi Navare
fallback_link_rate_index variable, just obtain that using the helper intel_dp_link_rate_index (Jani Nikula) v2: Squash the patch that returns the link rate index (Jani Nikula) Acked-by: Tony Cheng Acked-by: Harry Wentland Cc: Ville Syrjala Cc: Jani Nikula Cc: Daniel Vetter Signed-off-by: Manasi Navare

[PATCH] drm: Fix the kernel doc warning for drm_link_status

2017-03-01 Thread Manasi Navare
This fixes the kernel doc warning that was introduced in the 'commit 40ee6fbef75fe6 ("drm: Add a new connector atomic property for link status")'. Description has been added for the enum values. Signed-off-by: Manasi Navare Cc: Jani Nikula Cc: Daniel Vetter Cc: dri-devel@l

<    1   2   3   4   5   6   7   >