[PATCH] Revert "drm/atomic: document and enforce rules around "spurious" EBUSY"

2021-02-09 Thread Manasi Navare
. Cc: Ville Syrjala Cc: Daniel Vetter Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_atomic.c | 29 - 1 file changed, 29 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index b1efa9322be2..48b2262d69f6 100644 --- a/drivers

[PATCH] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-03-02 Thread Manasi Navare
: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_atomic.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 5b4547e0f775..d7acd6bbd97e 100644 --- a/drivers

[PATCH v6 1/2] drm/vrr: Set VRR capable prop only if it is attached to connector

2022-02-24 Thread Manasi Navare
Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_connector.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index a50c82bc2b2f..76a8c707c34b 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c

[PATCH v2] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-10-04 Thread Manasi Navare
review comments because the crtc gets stolen only after the atomic_check call. Cc: Ville Syrjälä Cc: Simon Ser Cc: Pekka Paalanen Cc: Daniel Stone Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_atomic.c | 6 -- 1 file changed, 4

[PATCH v3] drm/atomic: Add the crtc to affected crtc only if uapi.enable = true

2021-10-04 Thread Manasi Navare
lle) Cc: Ville Syrjälä Cc: Simon Ser Cc: Pekka Paalanen Cc: Daniel Stone Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_atomic.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/

Re: [Intel-gfx] [PATCH v6 04/28] drm/dp: DRM DP helper/macros to get DP sink DSC parameters

2019-01-30 Thread Manasi Navare
On Wed, Jan 30, 2019 at 12:06:45PM +0100, Daniel Vetter wrote: > On Wed, Dec 19, 2018 at 7:54 PM Daniel Vetter wrote: > > > > On Wed, Oct 24, 2018 at 03:28:16PM -0700, Manasi Navare wrote: > > > This patch adds inline functions and helpers for obtaining > > > D

Re: [Intel-gfx] [PATCH v6 04/28] drm/dp: DRM DP helper/macros to get DP sink DSC parameters

2019-01-30 Thread Manasi Navare
On Wed, Jan 30, 2019 at 01:06:57PM -0500, Sean Paul wrote: > On Wed, Jan 30, 2019 at 12:06:45PM +0100, Daniel Vetter wrote: > > On Wed, Dec 19, 2018 at 7:54 PM Daniel Vetter wrote: > > > > > > On Wed, Oct 24, 2018 at 03:28:16PM -0700, Manasi Navare wrote: > > >

[PATCH] drm/dsc: Add kernel documentation for DRM DP DSC helpers

2019-02-04 Thread Manasi Navare
and structures in the documentation. Suggested-by: Daniel Vetter Suggested-by: Sean Paul Cc: Daniel Vetter Cc: Sean Paul Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_dp_helper.c | 42 +- drivers/gpu/drm/drm_dsc.c | 13 ++- include/drm/drm_dp_helper.h | 15

Re: [PATCH] drm/dsc: Add kernel documentation for DRM DP DSC helpers

2019-02-05 Thread Manasi Navare
On Tue, Feb 05, 2019 at 10:55:12AM +0100, Daniel Vetter wrote: > On Mon, Feb 04, 2019 at 03:40:22PM -0800, Manasi Navare wrote: > > This patch adds appropiate kernel documentation for DRM DP helpers > > used for enabling Display Stream compression functionality in > >

[PATCH v2] drm/dsc: Add kernel documentation for DRM DP DSC helpers

2019-02-05 Thread Manasi Navare
and structures in the documentation. v2: * Add inline comments for longer structs (Daniel Vetter) * Split the summary and description (Daniel Vetter) Suggested-by: Daniel Vetter Suggested-by: Sean Paul Cc: Daniel Vetter Cc: Sean Paul Signed-off-by: Manasi Navare --- drivers/gpu/drm

[PATCH v3] drm/dsc: Add kernel documentation for DRM DP DSC helpers

2019-02-06 Thread Manasi Navare
-by: Manasi Navare Acked-by: Sean Paul Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_dp_helper.c | 47 ++- drivers/gpu/drm/drm_dsc.c | 30 +++- include/drm/drm_dp_helper.h | 15 +- include/drm/drm_dsc.h | 233 4 files changed, 259

Re: [PATCH v3] drm/dsc: Add kernel documentation for DRM DP DSC helpers

2019-02-08 Thread Manasi Navare
Pushed to drm-misc thanks for the reviews. Regards Manasi On Wed, Feb 06, 2019 at 01:31:48PM -0800, Manasi Navare wrote: > This patch adds appropriate kernel documentation for DRM DP helpers > used for enabling Display Stream compression functionality in > drm_dp_helper.h and drm_dp_he

Re: [PATCH v2 3/3] drm/dsc: Split DSC PPS and SDP header initialisations

2019-02-25 Thread Manasi Navare
omponents they operate on, not drm_dsc_pps_infoframe, > > Signed-off-by: David Francis The corresponding changes for the header init and payload init now look good to me. Reviewed-by: Manasi Navare Manasi > --- > drivers/gpu/drm/drm_dsc.c | 117 +++---

[PATCH] drm/dp: Set the connector's TILE property even for DP SST connectors

2019-03-12 Thread Manasi Navare
Airlie Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjälä Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_connector.c | 13 - drivers/gpu/drm/drm_dp_mst_topology.c | 1 - 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_connector.c b

Re: [PATCH] drm/dp: Set the connector's TILE property even for DP SST connectors

2019-03-14 Thread Manasi Navare
Pushed to drm-misc, thanks for the patch and the review! Regards Manasi On Wed, Mar 13, 2019 at 02:48:36PM -0400, Alex Deucher wrote: > On Tue, Mar 12, 2019 at 10:15 PM Manasi Navare > wrote: > > > > Current driver sets the tile property only for DP MST connectors. > >

[PATCH 1/2] drm/edid: Add a EDID edp panel quirk for forcing max lane count

2019-04-02 Thread Manasi Navare
-by: Emanuele Panigati Tested-by: Ralgor Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109959 Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_edid.c | 10 ++ include/drm/drm_connector.h | 5 + 2 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c

[PATCH 2/2] drm/i915/edp: Use max link rate and lane count if eDP EDID quirk

2019-04-02 Thread Manasi Navare
forces the max lane count in compute_config() hook to use max lane count for link training. Cc: Clint Taylor Cc: Ville Syrjälä Tested-by: Albert Astals Cid Tested-by: Emanuele Panigati Tested-by: Ralgor Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109959 Signed-off-by: Manasi Navare

Re: [PATCH 1/2] drm/edid: Add a EDID edp panel quirk for forcing max lane count

2019-04-03 Thread Manasi Navare
On Wed, Apr 03, 2019 at 03:14:51PM +0300, Ville Syrjälä wrote: > On Tue, Apr 02, 2019 at 02:52:34PM -0700, Manasi Navare wrote: > > For certain eDP 1.4 panels, we need to use max lane count for the > > link training to succeed. > > > > This patch adds a EDID quir

Re: [PATCH 1/2] drm/edid: Add a EDID edp panel quirk for forcing max lane count

2019-04-03 Thread Manasi Navare
On Wed, Apr 03, 2019 at 09:55:56PM +0300, Ville Syrjälä wrote: > On Wed, Apr 03, 2019 at 11:37:21AM -0700, Manasi Navare wrote: > > On Wed, Apr 03, 2019 at 03:14:51PM +0300, Ville Syrjälä wrote: > > > On Tue, Apr 02, 2019 at 02:52:34PM -0700, Manasi Navare wrote: > > > &

Re: [PATCH 1/2] drm/edid: Add a EDID edp panel quirk for forcing max lane count

2019-04-03 Thread Manasi Navare
On Wed, Apr 03, 2019 at 10:22:16PM +0300, Ville Syrjälä wrote: > On Wed, Apr 03, 2019 at 12:07:35PM -0700, Manasi Navare wrote: > > On Wed, Apr 03, 2019 at 09:55:56PM +0300, Ville Syrjälä wrote: > > > On Wed, Apr 03, 2019 at 11:37:21AM -0700, Manasi Navare wrote: > > > &

Re: [PATCH] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2019-10-25 Thread Manasi Navare
On Thu, Oct 24, 2019 at 03:06:37PM +, Harry Wentland wrote: > On 2019-10-23 8:00 p.m., Manasi Navare wrote: > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > the EDID's detailed descritors to obtain the adaptive sync monitor range. > >

[PATCH] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-10-31 Thread Manasi Navare
connectors for all tiles, then on a connector with one tile, just fallback to the first available non tiled mode to display over a single connector. Suggested-by: Ville Syrjälä Suggested-by: Dave Airlie Cc: Ville Syrjälä Cc: Dave Airlie Signed-off-by: Manasi Navare --- drivers/gpu/drm

Re: [PATCH] drm/vkms: Fix typo in function documentation

2019-11-01 Thread Manasi Navare
On Fri, Nov 01, 2019 at 03:21:02PM -0300, Gabriela Bittencourt wrote: > Fix typo in word 'blend' in function 'compute_crc' documentation. > > Signed-off-by: Gabriela Bittencourt Reviewed-by: Manasi Navare Manasi > --- > drivers/gpu/drm/vkms/vkms_com

Re: [Intel-gfx] [PATCH] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-11-04 Thread Manasi Navare
On Mon, Nov 04, 2019 at 07:48:26PM +1000, David Airlie wrote: > On Mon, Nov 4, 2019 at 7:18 PM Daniel Vetter wrote: > > > > On Thu, Oct 31, 2019 at 02:48:39PM -0700, Manasi Navare wrote: > > > In case of tiled displays, if we hotplug just one connector, > > >

Re: [Intel-gfx] [PATCH] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-11-06 Thread Manasi Navare
On Wed, Nov 06, 2019 at 12:47:16PM +1000, Dave Airlie wrote: > On Fri, 1 Nov 2019 at 07:46, Manasi Navare wrote: > > > > In case of tiled displays, if we hotplug just one connector, > > fbcon currently just selects the preferred mode and if it is > > tiled mode then tha

Re: [Intel-gfx] [PATCH] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-11-06 Thread Manasi Navare
On Wed, Nov 06, 2019 at 12:50:21PM +1000, Dave Airlie wrote: > On Tue, 5 Nov 2019 at 07:00, Manasi Navare wrote: > > > > On Mon, Nov 04, 2019 at 07:48:26PM +1000, David Airlie wrote: > > > On Mon, Nov 4, 2019 at 7:18 PM Daniel Vetter wrote: > > > > > &

[PATCH v2] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-11-08 Thread Manasi Navare
hotplug case * v1 Reviewed-by: Dave Airlie Suggested-by: Ville Syrjälä Suggested-by: Dave Airlie Cc: Ville Syrjälä Cc: Dave Airlie Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_client_modeset.c | 70 1 file changed, 70 insertions(+) diff --git a/drivers/gpu

[CI v2] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-11-13 Thread Manasi Navare
hotplug case * v1 Reviewed-by: Dave Airlie Suggested-by: Ville Syrjälä Suggested-by: Dave Airlie Cc: Ville Syrjälä Cc: Dave Airlie Signed-off-by: Manasi Navare Reviewed-by: Dave Airlie --- drivers/gpu/drm/drm_client_modeset.c | 70 1 file changed, 70 insertions

Re: [CI v2] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-11-17 Thread Manasi Navare
Pushed tod rm-misc-next, thanks a lot Dave all the feedback and reviews. Regards Manasi On Wed, Nov 13, 2019 at 02:29:52PM -0800, Manasi Navare wrote: > In case of tiled displays, if we hotplug just one connector, > fbcon currently just selects the preferred mode and if it is > tiled

[PATCH 2/2] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-12-11 Thread Manasi Navare
is pruned (Dave) v1: * Just handle the 1st connector hotplug case * v1 Reviewed-by: Dave Airlie Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/5 Suggested-by: Ville Syrjälä Suggested-by: Dave Airlie Cc: Ville Syrjälä Cc: Dave Airlie Signed-off-by: Manasi Navare Reviewed-by: Dave

[PATCH 1/2] drm: Handle connector tile support only for modes that match tile size

2019-12-11 Thread Manasi Navare
the check to match the tile size with requested mode to handle the tile support. Cc: Ville Syrjälä Cc: Maarten Lankhorst Cc: Jani Nikula Cc: Dave Airlie Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_fb_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/

Re: [PATCH 1/1] drm/dp: get/set phy compliance pattern

2019-12-11 Thread Manasi Navare
On Mon, Nov 18, 2019 at 11:55:55PM +0530, Animesh Manna wrote: > During phy compliance auto test mode source need to read > requested test pattern from sink through DPCD. After processing > the request source need to set the pattern. So set/get method > added in drm layer as it is DP protocol. You

Re: [PATCH 1/1] drm/dp: get/set phy compliance pattern

2019-12-11 Thread Manasi Navare
Did you look at the build failure here? The build fails for amdgpu that uses the old #define of DP_TEST_PHY_PATTERN So you will have to send a patch for the amdgpu wherever they are using the older #define along with this with correct explanation that name changed to match the spec. Manasi On Mo

Re: [PATCH 1/2] drm: Handle connector tile support only for modes that match tile size

2019-12-17 Thread Manasi Navare
On Wed, Dec 11, 2019 at 01:24:32PM -0800, Manasi Navare wrote: > DRM Fb driver expects multiple CRTCs if it sees connector->has_tile > is set, but we need to handle tile support and look for multiple CRTCs > only for the modes that match the tile size. The other modes should >

Re: [PATCH v2 2/9] drm/amd/display: Fix compilation issue.

2019-12-18 Thread Manasi Navare
On Wed, Dec 18, 2019 at 09:43:49PM +0530, Manna, Animesh wrote: > > On 18-12-2019 21:12, Harry Wentland wrote: > >On 2019-12-18 10:13 a.m., Animesh Manna wrote: > >>[Why]: > >>Aligh with DP spec wanted to follow same naming convention. > >> > >>[How]: > >>Changed the macro name of the dpcd address

Re: [PATCH v3 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation

2020-01-03 Thread Manasi Navare
On Thu, Jan 02, 2020 at 03:56:09PM +0530, Manna, Animesh wrote: > On 02-01-2020 14:48, Jani Nikula wrote: > >On Mon, 30 Dec 2019, Animesh Manna wrote: > >>vswing/pre-emphasis adjustment calculation is needed in processing > >>of auto phy compliance request other than link training, so moved > >>th

Re: [Intel-gfx] [PATCH v3 8/9] drm/i915/dp: Update the pattern as per request

2020-01-03 Thread Manasi Navare
On Thu, Jan 02, 2020 at 11:23:14AM +0200, Jani Nikula wrote: > On Mon, 30 Dec 2019, Animesh Manna wrote: > > As per request from DP phy compliance test few special > > test pattern need to set by source. Added function > > to set pattern in DP_COMP_CTL register. It will be > > called along with ot

Re: [PATCH v3 1/9] drm/amd/display: Align macro name as per DP spec

2020-01-03 Thread Manasi Navare
Harry, Jani - Since this also updates the AMD driver file, should this be merged through AMD tree and then backmerged to drm-misc ? Manasi On Mon, Dec 30, 2019 at 09:45:15PM +0530, Animesh Manna wrote: > [Why]: > Aligh with DP spec wanted to follow same naming convention. > > [How]: > Changed t

[PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-07 Thread Manasi Navare
Kazlauskas Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_edid.c | 51 + include/drm/drm_connector.h | 22 include/drm/drm_edid.h | 2 ++ 3 files changed, 75 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-08 Thread Manasi Navare
so I would leave the usage of this to you and Nicholas depending on what works better in your driver. Regards Manasi On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: > Adaptive Sync is a VESA feature so add a DRM core helper to parse > the EDID's detailed descritors

[PATCH] drm/dp: Remove the unused drm_device to get rid of build warning

2019-10-10 Thread Manasi Navare
We no longer use the connection mutex and hence no need to define drm_device *dev, it causes a unused variable build warning Fixes: 83fa9842afe7 ("drm/dp-mst: Drop connection_mutex check") Cc: Sean Paul Cc: Lyude Paul Cc: Daniel Vetter Signed-off-by: Manasi Navare --- drive

[PATCH] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2019-10-23 Thread Manasi Navare
s function amdgpu_dm_update_freesync_caps() to make it generic and be used across all DRM drivers Cc: Ville Syrjälä Cc: Harry Wentland Cc: Clinton A Taylor Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_edid.c | 49 + include/drm/drm_connector.h | 25 ++

Re: [Intel-gfx] [PATCH] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2019-10-24 Thread Manasi Navare
On Thu, Oct 24, 2019 at 12:31:06PM +0200, Thierry Reding wrote: > On Wed, Oct 23, 2019 at 05:00:41PM -0700, Manasi Navare wrote: > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > the EDID's detailed descritors to obtain the adaptive sync monitor range.

Re: [Intel-gfx] [PATCH] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2019-10-24 Thread Manasi Navare
; > On Wed, Oct 23, 2019 at 05:00:41PM -0700, Manasi Navare wrote: > > > > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > > > > the EDID's detailed descritors to obtain the adaptive sync monitor > > > > > range. > >

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-02-28 Thread Manasi Navare
On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: > On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > the EDID's detailed descritors to obtain the adaptive sync monitor range. &g

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-02-28 Thread Manasi Navare
On Fri, Feb 28, 2020 at 01:18:45PM -0800, Manasi Navare wrote: > On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: > > On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: > > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > &g

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-03-02 Thread Manasi Navare
On Mon, Mar 02, 2020 at 09:15:27AM -0500, Kazlauskas, Nicholas wrote: > On 2020-02-28 9:38 p.m., Manasi Navare wrote: > >On Fri, Feb 28, 2020 at 01:18:45PM -0800, Manasi Navare wrote: > >>On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: > >>>On Tue, Ja

[PATCH v3] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-03-02 Thread Manasi Navare
le) * Dont store pixel clock since that is just a max dotclock and not related to VRR mode (Manasi) Cc: Ville Syrjälä Cc: Harry Wentland Cc: Clinton A Taylor Cc: Kazlauskas, Nicholas Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_edid.c | 44 + i

Re: [PATCH v3] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-03-04 Thread Manasi Navare
On Tue, Mar 03, 2020 at 03:42:12PM +0200, Ville Syrjälä wrote: > On Mon, Mar 02, 2020 at 04:08:59PM -0800, Manasi Navare wrote: > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > the EDID's detailed descritors to obtain the adaptive sync monitor range. &g

[PATCH v4 1/2] drm/edid: Name the detailed monitor range flags

2020-03-05 Thread Manasi Navare
This patch adds defines for the detailed monitor range flags as per the EDID specification. Suggested-by: Ville Syrjälä Cc: Ville Syrjälä Cc: Harry Wentland Cc: Clinton A Taylor Cc: Kazlauskas Nicholas Signed-off-by: Manasi Navare --- include/drm/drm_edid.h | 5 + 1 file changed, 5

[PATCH v4 2/2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-03-05 Thread Manasi Navare
sync_range function static (Harry, Jani) v2: * Change vmin and vmax to use u8 (Ville) * Dont store pixel clock since that is just a max dotclock and not related to VRR mode (Manasi) Cc: Ville Syrjälä Cc: Harry Wentland Cc: Clinton A Taylor Cc: Kazlauskas Nicholas Signed-off-by: Manasi Navare --

Re: [Intel-gfx] [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags

2020-03-06 Thread Manasi Navare
On Fri, Mar 06, 2020 at 12:30:46PM +0200, Jani Nikula wrote: > On Thu, 05 Mar 2020, Manasi Navare wrote: > > This patch adds defines for the detailed monitor > > range flags as per the EDID specification. > > > > Suggested-by: Ville Syrjälä > > Cc: Ville Syrjäl

Re: [Intel-gfx] [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags

2020-03-09 Thread Manasi Navare
On Mon, Mar 09, 2020 at 10:35:52AM +0200, Jani Nikula wrote: > On Fri, 06 Mar 2020, Manasi Navare wrote: > > On Fri, Mar 06, 2020 at 12:30:46PM +0200, Jani Nikula wrote: > >> On Thu, 05 Mar 2020, Manasi Navare wrote: > >> > This patch adds defines for the detailed

[PATCH v5 2/2] drm/edid: Add function to parse EDID descriptors for adaptive sync limits

2020-03-09 Thread Manasi Navare
ned-off-by: Manasi Navare Reviewed-by: Nicholas Kazlauskas --- drivers/gpu/drm/drm_edid.c | 44 + include/drm/drm_connector.h | 22 +++ 2 files changed, 66 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_ed

[PATCH v5 1/2] drm/edid: Name the detailed monitor range flags

2020-03-09 Thread Manasi Navare
This patch adds defines for the detailed monitor range flags as per the EDID specification. v2: * Rename the flags with DRM_EDID_ (Jani N) Suggested-by: Ville Syrjälä Cc: Ville Syrjälä Cc: Harry Wentland Cc: Clinton A Taylor Cc: Kazlauskas Nicholas Cc: Jani Nikula Signed-off-by: Manasi

Re: [PATCH v5 2/2] drm/edid: Add function to parse EDID descriptors for adaptive sync limits

2020-03-10 Thread Manasi Navare
Hi Ville, Please find answers to your concerns below: On Mon, Mar 09, 2020 at 02:39:40PM -0700, Manasi Navare wrote: > Adaptive Sync is a VESA feature so add a DRM core helper to parse > the EDID's detailed descritors to obtain the adaptive sync monitor range. > Store this i

Re: [PATCH v5 1/2] drm/edid: Name the detailed monitor range flags

2020-03-10 Thread Manasi Navare
On Tue, Mar 10, 2020 at 06:20:27PM +0200, Ville Syrjälä wrote: > On Mon, Mar 09, 2020 at 02:39:39PM -0700, Manasi Navare wrote: > > This patch adds defines for the detailed monitor > > range flags as per the EDID specification. > > > > v2: > > * Rename

Re: [PATCH v5 2/2] drm/edid: Add function to parse EDID descriptors for adaptive sync limits

2020-03-10 Thread Manasi Navare
On Tue, Mar 10, 2020 at 09:13:30PM +0200, Ville Syrjälä wrote: > On Tue, Mar 10, 2020 at 12:08:33PM -0700, Manasi Navare wrote: > > Hi Ville, > > > > Please find answers to your concerns below: > > > > On Mon, Mar 09, 2020 at 02:39:40PM -0700, Manasi Navare wro

[PATCH v6 1/2] drm/edid: Name the detailed monitor range flags

2020-03-10 Thread Manasi Navare
This patch adds defines for the detailed monitor range flags as per the EDID specification. v2: * Rename the flags with DRM_EDID_ (Jani N) Suggested-by: Ville Syrjälä Cc: Ville Syrjälä Cc: Harry Wentland Cc: Clinton A Taylor Cc: Kazlauskas Nicholas Cc: Jani Nikula Signed-off-by: Manasi

[PATCH v6 2/2] drm/edid: Add function to parse EDID descriptors for monitor range

2020-03-10 Thread Manasi Navare
Taylor Cc: Kazlauskas Nicholas Signed-off-by: Manasi Navare Reviewed-by: Nicholas Kazlauskas --- drivers/gpu/drm/drm_edid.c | 44 + include/drm/drm_connector.h | 22 +++ 2 files changed, 66 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c

[PATCH 1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-03-17 Thread Manasi Navare
that it is Adaptive sync capable. Cc: Jani Nikula Cc: Ville Syrjälä Cc: Harry Wentland Cc: Nicholas Kazlauskas Signed-off-by: Manasi Navare --- include/drm/drm_dp_helper.h | 8 1 file changed, 8 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h

[PATCH 3/3] drm/i915/dp: intel_dp connector hook for VRR support

2020-03-17 Thread Manasi Navare
This defines the get_vrr_support hook for intel DP connector VRR support is set to true based on the DPCD ignore MSA and EDID monitor range Cc: Jani Nikula Cc: Ville Syrjälä Cc: Harry Wentland Cc: Nicholas Kazlauskas Cc: Aditya Swarup Signed-off-by: Manasi Navare --- .../drm/i915/display

[PATCH 2/3] drm: Create a drm_connector_helper_funcs hook for Adaptive Sync support

2020-03-17 Thread Manasi Navare
Nikula Cc: Ville Syrjälä Cc: Harry Wentland Cc: Nicholas Kazlauskas Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_probe_helper.c | 4 include/drm/drm_modeset_helper_vtables.h | 16 2 files changed, 20 insertions(+) diff --git a/drivers/gpu/drm

Re: [PATCH 3/3] drm/i915/dp: intel_dp connector hook for VRR support

2020-03-19 Thread Manasi Navare
On Thu, Mar 19, 2020 at 12:14:28PM +0200, Jani Nikula wrote: > On Tue, 17 Mar 2020, Manasi Navare wrote: > > This defines the get_vrr_support hook for intel DP connector > > VRR support is set to true based on the DPCD ignore MSA and > > EDID monitor range > > Yeah...

Re: [PATCH 2/3] drm: Create a drm_connector_helper_funcs hook for Adaptive Sync support

2020-03-19 Thread Manasi Navare
On Thu, Mar 19, 2020 at 12:07:37PM +0200, Jani Nikula wrote: > On Tue, 17 Mar 2020, Manasi Navare wrote: > > This patch adds a hook in drm_connector_helper_funcs to get the > > support of the driver for adaptive sync functionality. > > > > This can be called in the conn

Re: [PATCH 1/3] drm/dp: DRM DP helper for reading Ignore MSA from DPCD

2020-03-19 Thread Manasi Navare
On Thu, Mar 19, 2020 at 11:59:38AM +0200, Jani Nikula wrote: > On Tue, 17 Mar 2020, Manasi Navare wrote: > > DP sink device sets the Ignore MSA bit in its > > DP_DOWNSTREAM_PORT_COUNT register to indicate its ability to > > ignore the MSA video timing paramaters and i

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-10 Thread Manasi Navare
On Thu, Jan 09, 2020 at 05:24:30PM +0200, Jani Nikula wrote: > On Tue, 07 Jan 2020, Manasi Navare wrote: > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > the EDID's detailed descritors to obtain the adaptive sync monitor range. > >

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-10 Thread Manasi Navare
On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: > On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: > > Adaptive Sync is a VESA feature so add a DRM core helper to parse > > the EDID's detailed descritors to obtain the adaptive sync monitor range. &g

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-13 Thread Manasi Navare
? Manasi On Fri, Jan 10, 2020 at 03:17:43PM -0800, Manasi Navare wrote: > On Thu, Jan 09, 2020 at 03:08:52PM +0200, Ville Syrjälä wrote: > > On Tue, Jan 07, 2020 at 04:32:08PM -0800, Manasi Navare wrote: > > > Adaptive Sync is a VESA feature so add a DRM core helper to pars

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-14 Thread Manasi Navare
On Tue, Jan 14, 2020 at 03:07:56PM +0200, Ville Syrjälä wrote: > On Mon, Jan 13, 2020 at 04:39:00PM -0800, Manasi Navare wrote: > > Hi Ville, > > > > So the two major changes you would like to see here are: > > > > use version_greate(ed

Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits

2020-01-14 Thread Manasi Navare
On Tue, Jan 14, 2020 at 08:31:22AM -0500, Harry Wentland wrote: > Fixing Nick's email. > > On 2020-01-10 5:43 p.m., Manasi Navare wrote: > > On Thu, Jan 09, 2020 at 05:24:30PM +0200, Jani Nikula wrote: > >> On Tue, 07 Jan 2020, Manasi Navare wrote: > >>>

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/connector: Share with non-atomic drivers the function to get the single encoder

2019-09-16 Thread Manasi Navare
On Mon, Sep 16, 2019 at 07:34:32PM +, Souza, Jose wrote: > Someone with drm-misc commit access could push this? > Sure will push this series. Manasi > Thanks > > On Sun, 2019-09-15 at 11:36 +, Patchwork wrote: > > == Series Details == > > > > Series: series starting with [CI,1/2] drm/

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/connector: Share with non-atomic drivers the function to get the single encoder

2019-09-16 Thread Manasi Navare
Thanks for the patch and reviews, pushed to drm-misc Regards Manasi On Mon, Sep 16, 2019 at 02:12:14PM -0700, Souza, Jose wrote: > On Mon, 2019-09-16 at 12:39 -0700, Manasi Navare wrote: > > On Mon, Sep 16, 2019 at 07:34:32PM +, Souza, Jose wrote: > > > Someone with drm-

[PATCH] drm: Handle connector tile support only for modes that match tile size

2019-09-16 Thread Manasi Navare
the check to match the tile size with requested mode to handle the tile support. Cc: Ville Syrjälä Cc: Maarten Lankhorst Cc: Jani Nikula Cc: Dave Airlie Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_fb_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/

Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable

2019-09-18 Thread Manasi Navare
On Wed, Sep 18, 2019 at 07:09:43AM +0530, srinivasa...@intel.com wrote: > From: Srinivasan S > > This patch avoids DP MST payload error message in dmesg, as it is trying > to read the payload from the disconnected DP MST device. After the unplug > the connector status is disconnected and we shoul

Re: [PATCH] drm/i915/dp: Fix DP MST error after unplugging TypeC cable

2019-09-18 Thread Manasi Navare
On Wed, Sep 18, 2019 at 09:11:36PM +0300, Ville Syrjälä wrote: > On Wed, Sep 18, 2019 at 10:50:39AM -0700, Manasi Navare wrote: > > On Wed, Sep 18, 2019 at 07:09:43AM +0530, srinivasa...@intel.com wrote: > > > From: Srinivasan S > > > > > > This patch avoids D

Re: [PATCH v3 2/4] drm/edid: Add CTA-861-G modes with VIC >= 193

2019-09-27 Thread Manasi Navare
A spec, but the logic to add these new modes looks good to me. So, Reviewed-by: Manasi Navare Manasi > --- > drivers/gpu/drm/drm_edid.c | 151 - > 1 file changed, 149 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid

Re: [PATCH v3 4/4] drm/edid: Make sure the CEA mode arrays have the correct amount of modes

2019-09-27 Thread Manasi Navare
he excpected ^^^expected > size to make sure we've not accidentally left holes in them. > > v2: Pimp the BUILD_BUG_ON()s > > Cc: Hans Verkuil > Cc: Shashank Sharma > Signed-off-by: Ville Syrjälä With the typo fixed, Reviewed-by: Manasi Navare Manasi > --- >

[PATCH 1/5] drm: Handle connector tile support only for modes that match tile size

2019-12-10 Thread Manasi Navare
the check to match the tile size with requested mode to handle the tile support. Cc: Ville Syrjälä Cc: Maarten Lankhorst Cc: Jani Nikula Cc: Dave Airlie Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_fb_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/

[PATCH 3/5] drm/i915/dp: Make sure all tiled connectors get added to the state with full modeset

2019-12-10 Thread Manasi Navare
Syrjälä Cc: Ville Syrjälä Cc: José Roberto de Souza Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/5 Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/display/intel_display.c | 78 1 file changed, 78 insertions(+) diff --git a/drivers/gpu/drm/i915/display

[PATCH 4/5] drm/i915/dp: Make port sync mode assignments only if all tiles present

2019-12-10 Thread Manasi Navare
://gitlab.freedesktop.org/drm/intel/issues/5 Cc: Ville Syrjälä Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/display/intel_display.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display

[PATCH 2/5] drm/fbdev: Fallback to non tiled mode if all tiles not present

2019-12-10 Thread Manasi Navare
is pruned (Dave) v1: * Just handle the 1st connector hotplug case * v1 Reviewed-by: Dave Airlie Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/5 Suggested-by: Ville Syrjälä Suggested-by: Dave Airlie Cc: Ville Syrjälä Cc: Dave Airlie Signed-off-by: Manasi Navare Reviewed-by: Dave

[PATCH 5/5] drm/i915/dp: Disable Port sync mode correctly on teardown

2019-12-10 Thread Manasi Navare
("drm/i915/display/icl: Disable transcoder port sync as part of crtc_disable() sequence") Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/display/intel_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drive

[PATCH 0/5] DRM and i915 fixes to handle hotplug/unplug for 8K tiled displays

2019-12-10 Thread Manasi Navare
: Unplug master/slave: It does a full modeset and displays next lower mode Case5: Hotplug second port back in: It now does a full modeset again to display full 8K Manasi Navare (5): drm: Handle connector tile support only for modes that match tile size drm/fbdev: Fallback to non tiled mode if all

Re: [PATCH] drm/i915: add port info to debugfs

2019-08-21 Thread Manasi Navare
On Wed, Aug 21, 2019 at 05:15:54PM +0300, Simon Ser wrote: > This patch adds a line with the port name to connectors in > debugfs/i916_display_info. A hint is printed if the port is type-C. Typo here, should be i915_display_info Manasi > > Signed-off-by: Simon Ser > Cc: Imre Deak > --- > dri

Re: [PATCH v5 1/5] drm/dp_mst: Add PBN calculation for DSC modes

2019-08-23 Thread Manasi Navare
ons to intel-gfx mailing list as well Reviewed-by: Manasi Navare Manasi > --- > .../amd/display/amdgpu_dm/amdgpu_dm_helpers.c| 2 +- > drivers/gpu/drm/drm_dp_mst_topology.c| 16 > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- >

Re: [PATCH] drm: include: fix W=1 warnings in struct drm_dsc_config

2019-09-10 Thread Manasi Navare
On Tue, Sep 10, 2019 at 12:58:24PM +, Harry Wentland wrote: > +Manasi, Gaurav > > On 2019-09-09 9:52 a.m., Benjamin Gaignard wrote: > > Change scale_increment_interval and nfl_bpg_offset fields to > > u32 to avoid W=1 warnings because we are testing them against > > 65535. > > > > Signed-off-

Re: [PATCH] drm/sysfs: Expose DRM connector id in each connector sysfs

2023-04-17 Thread Manasi Navare
tell which port is deriving which displays even with > a MST hub. Chromium patch for parsing DRM connector id from the kernel > is at http://crrev.com/c/4317207. > > Signed-off-by: Won Chung Exposing connector id in device sysfs looks good to me. Reviewed-by: Manasi Navare Manasi

Re: [PATCH v5] drm/sysfs: Link DRM connectors to corresponding Type-C connectors

2023-04-24 Thread Manasi Navare
, > +}; > + > static CLASS_ATTR_STRING(version, S_IRUGO, "drm 1.1.0 20060810"); > > /** > @@ -353,9 +383,16 @@ int drm_sysfs_connector_add(struct drm_connector > *connector) > > connector->kdev = kdev; > > + if (dev_fwnode(kdev)) { &

Re: [PATCH v6] drm/sysfs: Link DRM connectors to corresponding Type-C connectors

2023-04-28 Thread Manasi Navare
i.kroge...@linux.intel.com/ > USB4: > https://lore.kernel.org/all/20220418175932.1809770-3-wonch...@google.com/ > So, we follow the same pattern in this patch. > > Signed-off-by: Won Chung > Acked-by: Heikki Krogerus > Reviewed-by: Manasi Navare > --- > Changes fro

Re: [PATCH] drm/sysfs: Expose DRM connector id in each connector sysfs

2023-04-28 Thread Manasi Navare
Hi Won, Thanks for the patch, I have now merged to drm-misc-next Regards Manasi On Mon, Apr 17, 2023 at 3:52 PM Manasi Navare wrote: > > On Tue, Mar 28, 2023 at 6:45 PM Won Chung wrote: > > > > Expose DRM connector id in device sysfs so that we can map the connector >

Re: [PATCH 1/3] drm/i915/dp_link_training: Add a final failing state to link training fallback

2023-08-18 Thread Manasi Navare
y are marked as connected. > > Cc: Jani Nikula > Cc: Manasi Navare > Cc: Sean Paul > Signed-off-by: Gil Dekel > --- > drivers/gpu/drm/i915/display/intel_dp.c | 18 -- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/

[PATCH RFC 1/8] drm: Add a link_train_retry field to drm_connector

2016-10-19 Thread Manasi Navare
: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- include/drm/drm_connector.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index ac9d7d8..d499466 100644 --- a/include/drm/drm_connector.h +++ b

[PATCH RFC 0/8] Hotplug Uevent on Link training failure on DP

2016-10-19 Thread Manasi Navare
modeset retry, the modes are validated based on link rate lower than the failed link rate and link is retrained at lower link rate. Manasi Navare (7): drm: Add a link_train_retry field to drm_connector drm: Define a work struct for scheduling a uevent for modeset retry drm: Trigger a complete

[PATCH RFC 7/8] drm/i915: Link Rate fallback on Link training failure

2016-10-19 Thread Manasi Navare
e the pipe at lower link rate and retrian at lower link rate. This is also required to pass DP CTS tests 4.3.1.3, 4.3.1.4, 4.3.1.6. Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/intel_ddi.c | 14 ++- drivers/gp

[PATCH RFC 6/8] drm/i915: Define the modeset retry work function

2016-10-19 Thread Manasi Navare
Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/intel_dp.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index a60bef8..aae7f82 100644 --- a/drivers/gpu/drm

[PATCH RFC 3/8] drm: Trigger a complete modeset if link_train_retry is set

2016-10-19 Thread Manasi Navare
modeset. Cc: dri-devel at lists.freedesktop.org Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/drm_atomic_helper.c | 9 + drivers/gpu/drm/drm_fb_helper.c | 3 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH RFC 2/8] drm: Define a work struct for scheduling a uevent for modeset retry

2016-10-19 Thread Manasi Navare
. Cc: dri-devel at lists.freedesktop.org Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- include/drm/drm_connector.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index d499466..9218a24

[PATCH RFC 4/8] drm/i915: Change the placement of some static functions in intel_dp.c

2016-10-19 Thread Manasi Navare
Vivi) Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare Reviewed-by: Mika Kahola --- drivers/gpu/drm/i915/intel_dp.c | 150 1 file changed, 75 insertions(+), 75 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/d

[PATCH RFC 5/8] drm/i915; Add a function to return index of link rate

2016-10-19 Thread Manasi Navare
This is required to return the index of link rate into common_rates array. This gets used to retry the link training at lower link rate. Cc: Jani Nikula Cc: Daniel Vetter Cc: Ville Syrjala Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/intel_dp.c | 15 +++ 1 file changed

  1   2   3   4   5   6   7   >