[PATCH 00/10] Fix multiple compilation warnings

2022-02-22 Thread Maíra Canal
This patchset intends to deal with a couple of warnings in the AMD graphic drivers. All warnings were generated with Clang and W=1 flag. Maíra Canal (10): drm/amdgpu: Change amdgpu_ras_block_late_init_default function scope drm/amdgpu: Remove tmp unused variable drm/amdgpu: Remove unused

[PATCH 01/10] drm/amdgpu: Change amdgpu_ras_block_late_init_default function scope

2022-02-22 Thread Maíra Canal
ult(struct amdgpu_device *adev, ^ drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2459:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int amdgpu_ras_block_late_init_default(struct amdgpu_device *adev, ^ static Signed-off-by: Maíra Canal ---

[PATCH 02/10] drm/amdgpu: Remove tmp unused variable

2022-02-22 Thread Maíra Canal
u32 tmp; ^ drivers/gpu/drm/amd/amdgpu/dce_v8_0.c:325:6: warning: variable 'tmp' set but not used [-Wunused-but-set-variable] u32 tmp; ^ Signed-off-by: Maíra Canal --- drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 4 +--- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 4 +---

[PATCH 03/10] drm/amdgpu: Remove unused get_umc_v8_7_channel_index function

2022-02-22 Thread Maíra Canal
e uint32_t get_umc_v8_7_channel_index(struct amdgpu_device *adev, ^ Signed-off-by: Maíra Canal --- drivers/gpu/drm/amd/amdgpu/umc_v8_7.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/umc_v8_7.c b/drivers/gpu/drm/amd/amdgpu/umc_v8_7.c index de85a998ef99..f3

[PATCH 04/10] drm/amd/display: Remove unused temp variable

2022-02-22 Thread Maíra Canal
' set but not used [-Wunused-but-set-variable] uint64_t temp; ^ Signed-off-by: Maíra Canal --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/g

[PATCH 06/10] drm/amd/display: Remove vupdate_int_entry definition

2022-02-22 Thread Maíra Canal
SOURCE_VUPDATE1 + reg_num] = {\ ^~ 6 warnings generated. fixes: 688f97ed ("drm/amd/display: Add vupdate_no_lock interrupts for DCN2.1") Signed-off-by: Maíra Canal --- .../amd/display/dc/irq/dcn21/irq_service_dcn21.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/

[PATCH 07/10] drm/amd/display: Remove unused dmub_outbox_irq_info_funcs variable

2022-02-22 Thread Maíra Canal
'dmub_outbox_irq_info_funcs' [-Wunused-const-variable] static const struct irq_source_info_funcs dmub_outbox_irq_info_funcs = { ^ Signed-off-by: Maíra Canal --- .../gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c | 5 - 1 file changed, 5

[PATCH 08/10] drm/amd/display: Remove unused variable

2022-02-22 Thread Maíra Canal
t-variable] bool clamshell_closed = false; ^ Signed-off-by: Maíra Canal --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/displa

[PATCH 09/10] drm/amd/display: Add missing prototypes to dcn201_init

2022-02-22 Thread Maíra Canal
(struct dc *dc) ^ Signed-off-by: Maíra Canal --- drivers/gpu/drm/amd/display/dc/dcn201/dcn201_init.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_init.c b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_init.c index f1f89f93603f..1826dd7f3

[PATCH 10/10] drm/amd/display: Turn global functions into static functions

2022-02-22 Thread Maíra Canal
u/../display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c:488:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void dcn316_clk_mgr_helper_populate_bw_params( ^ static 1 warning generated. Signed-off-by: Maíra Canal --- drivers/gpu/drm/amd/displ

[PATCH] drm/i915: replacing drm_modeset_lock_all for DRM_MODESET_LOCK_ALL_*

2021-10-10 Thread Maíra Canal
As requested in GPU Driver Developers Guide TODO list, replaces all drm_lock boilerplates for DRM_MODESET_LOCK_ALL_* helpers. Signed-off-by: Maíra Canal --- drivers/gpu/drm/i915/display/intel_display.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers

[PATCH] backlight: lp855x: Switch to atomic PWM API

2021-10-23 Thread Maíra Canal
Remove legacy PWM interface (pwm_config, pwm_enable, pwm_disable) and replace it for the atomic PWM API. Signed-off-by: Maíra Canal --- drivers/video/backlight/lp855x_bl.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/video/backlight

[PATCH v2] backlight: lp855x: Switch to atomic PWM API

2021-10-27 Thread Maíra Canal
Remove legacy PWM interface (pwm_config, pwm_enable, pwm_disable) and replace it for the atomic PWM API. Signed-off-by: Maíra Canal Reported-by: kernel test robot --- V1 -> V2: Initializing variable and simplyfing conditional loop --- drivers/video/backlight/lp855x_bl.c |

[PATCH v3] backlight: lp855x: Switch to atomic PWM API

2021-10-30 Thread Maíra Canal
Remove legacy PWM interface (pwm_config, pwm_enable, pwm_disable) and replace it for the atomic PWM API. Signed-off-by: Maíra Canal --- V1 -> V2: Initialize variable and simply conditional loop V2 -> V3: Fix assignment of NULL variable --- drivers/video/backlight/lp855x_bl.

[PATCH v4] backlight: lp855x: Switch to atomic PWM API

2021-11-01 Thread Maíra Canal
Remove legacy PWM interface (pwm_config, pwm_enable, pwm_disable) and replace it for the atomic PWM API. Signed-off-by: Maíra Canal --- V1 -> V2: Initialize variable and simply conditional loop V2 -> V3: Fix assignment of NULL variable V3 -> V4: Replace division for pwm_set_relative_d

[PATCH] drm/exynos: Replace legacy gpio interface for gpiod interface

2021-11-01 Thread Maíra Canal
Considering the current transition of the GPIO subsystem, remove all dependencies of the legacy GPIO interface (linux/gpio.h and linux /of_gpio.h) and replace it with the descriptor-based GPIO approach. Signed-off-by: Maíra Canal --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 42

Re: [PATCH v3] backlight: lp855x: Switch to atomic PWM API

2021-11-03 Thread Maíra Canal
Em ter., 2 de nov. de 2021 às 05:39, Geert Uytterhoeven escreveu: > > Hi Maíra, > > On Sat, Oct 30, 2021 at 3:35 PM Maíra Canal wrote: > > Remove legacy PWM interface (pwm_config, pwm_enable, pwm_disable) and > > replace it for the atomic PWM API. > > > > Si

[PATCH v5] backlight: lp855x: Switch to atomic PWM API

2021-11-03 Thread Maíra Canal
Remove legacy PWM interface (pwm_config, pwm_enable, pwm_disable) and replace it for the atomic PWM API. Signed-off-by: Maíra Canal --- V1 -> V2: Initialize variable and simplify conditional loop V2 -> V3: Fix assignment of NULL variable V3 -> V4: Replace division for pwm_set_relative_d

[PATCH v6] backlight: lp855x: Switch to atomic PWM API

2021-11-04 Thread Maíra Canal
Remove legacy PWM interface (pwm_config, pwm_enable, pwm_disable) and replace it for the atomic PWM API. Signed-off-by: Maíra Canal --- V1 -> V2: Initialize variable and simplify conditional loop V2 -> V3: Fix assignment of NULL variable V3 -> V4: Replace division for pwm_set_relative_d

[RFC 0/3] drm/amd/display: Introduce KUnit to Display Mode Library

2022-06-07 Thread Maíra Canal
This RFC is a preview of the work being developed by Isabella Basso [1], Maíra Canal [2], and Tales Lelo [3], as part of their Google Summer of Code projects [4], and Magali Lemes [5], as part of her capstone project. Our main goal is to bring unit testing to the AMDPGU driver; in particular

[RFC 1/3] drm/amd/display: Introduce KUnit to DML

2022-06-07 Thread Maíra Canal
one part of the Display Mode Library: display_mode_lib, in order to introduce the basic structure of the tests on the DML. Signed-off-by: Maíra Canal --- drivers/gpu/drm/amd/display/Kconfig | 1 + .../gpu/drm/amd/display/amdgpu_dm/Makefile| 5 ++ .../gpu/drm/amd/display/amdgpu_dm

[RFC 2/3] drm/amd/display: Move bw_fixed macros to header file

2022-06-07 Thread Maíra Canal
, making it accessible to future unit tests. Signed-off-by: Maíra Canal --- .../gpu/drm/amd/display/dc/dml/calcs/bw_fixed.c| 14 +- drivers/gpu/drm/amd/display/dc/inc/bw_fixed.h | 14 ++ 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/gpu

[RFC 3/3] drm/amd/display: Introduce KUnit tests to the bw_fixed library

2022-06-07 Thread Maíra Canal
the proper functioning of the basic mathematical operations of fixed-point arithmetic, such as multiplication, conversion from fractional to fixed-point number, and more. Co-developed-by: Tales Aparecida Signed-off-by: Tales Aparecida Signed-off-by: Magali Lemes Co-developed-by: Maíra Canal

[PATCH 00/10] drm: selftest: Convert to KUnit

2022-06-15 Thread Maíra Canal
Grillo, Isabella Basso, and Maíra Canal Arthur Grillo (2): drm: selftest: refactor drm_cmdline_parser drm: selftest: convert drm_mm selftest to KUnit Maíra Canal (8): drm: selftest: convert drm_damage_helper selftest to KUnit drm: selftest: convert drm_cmdline_parser selftest to KUnit drm

[PATCH 01/10] drm: selftest: convert drm_damage_helper selftest to KUnit

2022-06-15 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM damage helper selftest to the KUnit API. Co-developed-by: Arthur Grillo Signed-off-by: Arthur Grillo Signed-off-by: Maíra Canal --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile

[PATCH 02/10] drm: selftest: refactor drm_cmdline_parser

2022-06-15 Thread Maíra Canal
From: Arthur Grillo Refactor the tests by modularizing the functions to avoid code repetition. Co-developed-by: Maíra Canal Signed-off-by: Arthur Grillo Signed-off-by: Maíra Canal --- .../drm/selftests/test-drm_cmdline_parser.c | 579 +- 1 file changed, 156 insertions

[PATCH 03/10] drm: selftest: convert drm_cmdline_parser selftest to KUnit

2022-06-15 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM cmdline parser selftest to the KUnit API. Co-developed-by: Arthur Grillo Signed-off-by: Arthur Grillo Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 2 +- .../gpu/drm/selftests

[PATCH 04/10] drm: selftest: convert drm_rect selftest to KUnit

2022-06-15 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM rect selftest to the KUnit API. Co-developed-by: Carlos Veras Signed-off-by: Carlos Veras Co-developed-by: Matheus Vieira Signed-off-by: Matheus Vieira Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile

[PATCH 05/10] drm: selftest: convert drm_format selftest to KUnit

2022-06-15 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM format selftest to the KUnit API. Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 3 +- .../gpu/drm/selftests/drm_modeset_selftests.h | 3 - drivers/gpu/drm/selftests/test-drm_format.c

[PATCH 06/10] drm: selftest: convert drm_plane_helper selftest to KUnit

2022-06-15 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM plane helper selftest to the KUnit API. Co-developed-by: Djakson C. G. Filho Signed-off-by: Djakson C. G. Filho Co-developed-by: Anderson Fraga Signed-off-by: Anderson Fraga Signed-off-by: Maíra Canal --- drivers/gpu

[PATCH 07/10] drm: selftest: convert drm_dp_mst_helper selftest to KUnit

2022-06-15 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM DP MST helper selftest to the KUnit API. Co-developed-by: Rubens Gomes Neto Signed-off-by: Rubens Gomes Neto Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 3 +- .../gpu/drm/selftests

[PATCH 08/10] drm: selftest: convert drm_framebuffer selftest to KUnit

2022-06-15 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM framebuffer selftest to the KUnit API. Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 5 +-- .../gpu/drm/selftests/drm_modeset_selftests.h | 9 -- .../drm/selftests/test

[PATCH 09/10] drm: selftest: convert drm_buddy selftest to KUnit

2022-06-15 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM buddy selftest to the KUnit API. Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 2 +- .../gpu/drm/selftests/drm_buddy_selftests.h | 15 - drivers/gpu/drm/selftests/test-drm_buddy.c

[PATCH 02/10] drm: selftest: refactor drm_cmdline_parser

2022-06-15 Thread Maíra Canal
From: Arthur Grillo Refactor the tests by modularizing the functions to avoid code repetition. Co-developed-by: Maíra Canal Signed-off-by: Arthur Grillo Signed-off-by: Maíra Canal --- .../drm/selftests/test-drm_cmdline_parser.c | 579 +- 1 file changed, 156 insertions

[PATCH 10/10] drm: selftest: convert drm_mm selftest to KUnit

2022-06-15 Thread Maíra Canal
From: Arthur Grillo Considering the current adoption of the KUnit framework, convert the DRM mm selftest to the KUnit API. Signed-off-by: Arthur Grillo Signed-off-by: Maíra Canal --- drivers/gpu/drm/Kconfig | 20 - drivers/gpu/drm/Makefile |1

Re: [RFC 1/3] drm/amd/display: Introduce KUnit to DML

2022-06-15 Thread Maíra Canal
Hi Daniel Thank you for your feedback! We are working on the comments you pointed out. On 6/7/22 23:36, Daniel Latypov wrote: > On Tue, Jun 7, 2022 at 6:09 PM Maíra Canal wrote: >> diff --git >> a/drivers/gpu/drm/amd/display/amdgpu_dm/tests/display_mode_lib_test.c >>

Re: [RFC 0/3] drm/amd/display: Introduce KUnit to Display Mode Library

2022-06-16 Thread Maíra Canal
Hi David, Thank you for your feedback! On 6/16/22 11:39, David Gow wrote: > On Wed, Jun 8, 2022 at 9:08 AM Maíra Canal wrote: >> >> As kunit_test_suites() defines itself as an init_module(), it conflicts with >> the existing one at amdgpu_drv. So, if we use kunit_test_sui

Re: [RFC 0/3] drm/amd/display: Introduce KUnit to Display Mode Library

2022-06-17 Thread Maíra Canal
On 6/17/22 04:55, David Gow wrote: > On Fri, Jun 17, 2022 at 6:41 AM Maíra Canal wrote: >> >> Hi David, >> >> Thank you for your feedback! >> >> On 6/16/22 11:39, David Gow wrote: >>> On Wed, Jun 8, 2022 at 9:08 AM Maíra Canal wrote: >>

[PATCH v2 0/9] drm: selftest: Convert to KUnit

2022-06-21 Thread Maíra Canal
of the tests was made without any functional changes. Thanks for your attention and any feedback is welcomed! Best Regards, - Maíra Canal v1 -> v2: https://lore.kernel.org/dri-devel/20220615135824.15522-1-maira.ca...@usp.br/T/ - The suites no longer end in _tests (David Gow). - Remove the T

[PATCH v2 1/9] drm: selftest: convert drm_damage_helper selftest to KUnit

2022-06-21 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM damage helper selftest to the KUnit API. Tested-by: David Gow Co-developed-by: Arthur Grillo Signed-off-by: Arthur Grillo Signed-off-by: Maíra Canal --- drivers/gpu/drm/Kconfig | 19 + drivers/gpu

[PATCH v2 2/9] drm: selftest: convert drm_cmdline_parser selftest to KUnit

2022-06-21 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM cmdline parser selftest to the KUnit API. Tested-by: David Gow Co-developed-by: Arthur Grillo Signed-off-by: Arthur Grillo Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile|2 +- .../gpu

[PATCH v2 3/9] drm: selftest: convert drm_rect selftest to KUnit

2022-06-21 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM rect selftest to the KUnit API. Tested-by: David Gow Co-developed-by: Carlos Veras Signed-off-by: Carlos Veras Co-developed-by: Matheus Vieira Signed-off-by: Matheus Vieira Signed-off-by: Maíra Canal --- drivers/gpu

[PATCH v2 4/9] drm: selftest: convert drm_format selftest to KUnit

2022-06-21 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM format selftest to the KUnit API. Tested-by: David Gow Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 3 +- .../gpu/drm/selftests/drm_modeset_selftests.h | 3 - drivers/gpu/drm

[PATCH v2 5/9] drm: selftest: convert drm_plane_helper selftest to KUnit

2022-06-21 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM plane helper selftest to the KUnit API. Tested-by: David Gow Co-developed-by: Djakson C. G. Filho Signed-off-by: Djakson C. G. Filho Co-developed-by: Anderson Fraga Signed-off-by: Anderson Fraga Signed-off-by: Maíra

[PATCH v2 6/9] drm: selftest: convert drm_dp_mst_helper selftest to KUnit

2022-06-21 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM DP MST helper selftest to the KUnit API. Tested-by: David Gow Co-developed-by: Rubens Gomes Neto Signed-off-by: Rubens Gomes Neto Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 3

[PATCH v2 7/9] drm: selftest: convert drm_framebuffer selftest to KUnit

2022-06-21 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM framebuffer selftest to the KUnit API. Tested-by: David Gow Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 5 +-- .../gpu/drm/selftests/drm_modeset_selftests.h | 9 -- .../drm

[PATCH v2 8/9] drm: selftest: convert drm_buddy selftest to KUnit

2022-06-21 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM buddy selftest to the KUnit API. Tested-by: David Gow Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 2 +- .../gpu/drm/selftests/drm_buddy_selftests.h | 15 - drivers/gpu/drm/selftests

[PATCH v2 9/9] drm: selftest: convert drm_mm selftest to KUnit

2022-06-21 Thread Maíra Canal
From: Arthur Grillo Considering the current adoption of the KUnit framework, convert the DRM mm selftest to the KUnit API. Tested-by: David Gow Signed-off-by: Arthur Grillo Signed-off-by: Maíra Canal --- Documentation/gpu/todo.rst| 11 - drivers/gpu/drm/Kconfig

[PATCH] drm/amd/pm: add missing prototypes to amdgpu_dpm_internal

2022-02-02 Thread Maíra Canal
xes: 6ddbd37f ("drm/amd/pm: optimize the amdgpu_pm_compute_clocks() implementations") Signed-off-by: Maíra Canal --- drivers/gpu/drm/amd/pm/amdgpu_dpm_internal.c | 1 + drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h | 1 - drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 1 + 3 files changed, 2

Re: [PATCH 2/2] drm/cmdline-parser: Use assert when needed

2022-08-10 Thread Maíra Canal
lete a line. > > static void drm_cmdline_test_force_D_only_hdmi(struct kunit *test) > { > struct drm_cmdline_mode mode = { }; > + const struct drm_connector connector_hdmi = { > + .connector_type = DRM_MODE_CONNECTOR_HDMIB, > + }; As the kernel

Re: [PATCH 1/2] drm/cmdline-parser: Merge negative tests

2022-08-10 Thread Maíra Canal
roves readability. > > Signed-off-by: Michał Winiarski Tested-by: Maíra Canal Best Regards, - Maíra Canal > --- > .../gpu/drm/tests/drm_cmdline_parser_test.c | 293 ++ > 1 file changed, 103 insertions(+), 190 deletions(-) > > diff --git a/drivers/gpu/dr

[PATCH 0/5] Drop of_gpio header

2022-08-12 Thread Maíra Canal
, with the OF header. Best Regards, - Maíra Canal Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: Matthias Brugger Cc: Rob Clark Cc: Abhinav Kumar Cc: Dmitry Baryshkov Cc: Sean Paul Cc

[PATCH 1/5] drm/bridge: anx7625: Drop of_gpio header

2022-08-12 Thread Maíra Canal
This driver includes the deprecated OF GPIO header yet fail to use symbols from it, so drop the include. Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Signed-off-by: Maíra Canal --- drivers/gpu/drm/bridge/analogix/anx7625.c

[PATCH 2/5] drm/mediatek: Drop of_gpio header

2022-08-12 Thread Maíra Canal
These drivers include the deprecated OF GPIO header yet fail to use symbols from it, so drop the include. Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: Matthias Brugger Cc: linux-media...@lists.infradead.org Signed-off-by: Maíra Canal --- drivers/gpu/drm/mediatek/mtk_dpi.c | 1 - drivers/gpu/drm

[PATCH 5/5] drm/vc4: Drop of_gpio header

2022-08-12 Thread Maíra Canal
This driver includes the deprecated OF GPIO header yet fail to use symbols from it, so drop the include. Cc: Emma Anholt Cc: Maxime Ripard Signed-off-by: Maíra Canal --- drivers/gpu/drm/vc4/vc4_hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers

[PATCH 4/5] drm/sti: Drop of_gpio header

2022-08-12 Thread Maíra Canal
This driver includes the deprecated OF GPIO header yet fail to use symbols from it, so drop this include. Cc: Alain Volmat Signed-off-by: Maíra Canal --- drivers/gpu/drm/sti/sti_dvo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers

[PATCH 3/5] drm/msm: Drop of_gpio header

2022-08-12 Thread Maíra Canal
These drivers include the deprecated OF GPIO header yet fail to use symbols from it, so drop the include. Cc: Rob Clark Cc: Abhinav Kumar Cc: Dmitry Baryshkov Cc: Sean Paul Signed-off-by: Maíra Canal --- drivers/gpu/drm/msm/dp/dp_parser.c | 2 +- drivers/gpu/drm/msm/hdmi/hdmi.c| 1 - 2

Re: [BUG][5.20] refcount_t: underflow; use-after-free

2022-08-14 Thread Maíra Canal
ext/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes: 90af0ca047f3 ("drm/amdgpu: Protect the amdgpu_bo_list list with a mutex v2") Reported-by: Mikhail Gavrilov Signed-off-by: Maíra Canal --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 9 +++-- 1 file changed, 3 insertions(+)

[PATCH] drm/amdgpu: Fix use-after-free on amdgpu_bo_list mutex

2022-08-15 Thread Maíra Canal
, remove the mutex_unlock from the amdgpu_cs_vm_handling function, so that amdgpu_cs_submit and amdgpu_cs_parser_fini can handle the unlock. Fixes: 90af0ca047f3 ("drm/amdgpu: Protect the amdgpu_bo_list list with a mutex v2") Reported-by: Mikhail Gavrilov Signed-off-by: Maíra Canal --- Thanks

Re: [PATCH 0/3] KUnit tests for RGB888, XRGB2101010 and grayscale

2022-08-16 Thread Maíra Canal
Hi José, Tested the whole series on UML, x86, i386 and PPC. All looks fine! Tested-by: Maíra Canal Best Regards, - Maíra Canal On 8/16/22 07:29, José Expósito wrote: Hello everyone, This series is a follow up on my work adding KUnit test to the XRGB conversion functions. This time

Re: [BUG][5.20] refcount_t: underflow; use-after-free

2022-08-17 Thread Maíra Canal
it and check if the use-after-free still happens. Best Regards, - Maíra Canal [ 297.834779] [ cut here ] [ 297.834818] refcount_t: underflow; use-after-free. [ 297.834831] WARNING: CPU: 30 PID: 2377 at lib/refcount.c:28 refcount_warn_saturate+0xba/0x110 [ 297.834838

[PATCH] drm/amd/display: Include missing header

2022-08-18 Thread Maíra Canal
m_plane.c:992:5: warning: no previous prototype for 'dm_plane_helper_check_state' [-Wmissing-prototypes] Therefore, include the missing header on the file and turn global functions that are not used outside of the file into static functions. Fixes: 5d945cbcd4b1 ("drm/amd/display:

Re: [PATCH v2 2/2] drm/cmdline-parser: Use assert when needed

2022-08-18 Thread Maíra Canal
(whitespace). v2: Leave out the locals (drm_connector is huge) (lkp) Signed-off-by: Michał Winiarski Reviewed-by: Maíra Canal Best Regards, - Maíra Canal --- .../gpu/drm/tests/drm_cmdline_parser_test.c | 80 +-- 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a

Re: [PATCH v2 1/2] drm/cmdline-parser: Merge negative tests

2022-08-18 Thread Maíra Canal
In order to be consistent to the change on the testcases, you could s/negative/invalid on the commit message also. Best Regards, - Maíra Canal v2: s/negative/invalid to be consistent with other testcases in DRM Signed-off-by: Michał Winiarski Tested-by: Maíra Canal --- .../gpu/drm/

Re: [PATCH] drm/amd/display: fix i386 frame size warning

2022-08-19 Thread Maíra Canal
me-larger-than] void dml30_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_lib) ^ 1 error generated. Best Regards, - Maíra Canal > > UseMinimumDCFCLK() is eating away at > dml30_ModeSupportAndSystemConfigurationFull()'s stack space, so use a > pointer to struct v

Re: [BUG][5.20] refcount_t: underflow; use-after-free

2022-08-19 Thread Maíra Canal
On 8/17/22 17:57, Mikhail Gavrilov wrote: > On Wed, Aug 17, 2022 at 11:43 PM Maíra Canal wrote: >> >> Hi Mikhail, >> >> Looks like 45ecaea738830b9d521c93520c8f201359dcbd95 ("drm/sched: Partial >> revert of 'drm/sched: Keep s_fence->parent pointe

Re: [PATCH v2 1/2] drm/cmdline-parser: Merge negative tests

2022-08-19 Thread Maíra Canal
On 8/18/22 13:19, Michał Winiarski wrote: > On Thu, Aug 18, 2022 at 11:15:39AM -0300, Maíra Canal wrote: >> >> >> On 8/17/22 18:12, Michał Winiarski wrote: >>> Negative tests can be expressed as a single parameterized test case, >>> which highlights t

dri-devel@lists.freedesktop.org

2022-08-23 Thread Maíra Canal
argument to && or || drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c: 3680:8-55: duplicated argument to && or || Signed-off-by: Bernard Zhao Also, it would be nice to have a changelog between the versions. Other than those small nits, Reviewed-by: Maíra Cana

Re: [PATCH 1/3] drm: Use original src rect while initializing damage iterator

2022-08-24 Thread Maíra Canal
PCI_OVER_VIRTIO=y \ --kconfig_add CONFIG_VIRTIO_UML=y There is also some documentation on the DRM KUnit Tests on [1]. [1] https://docs.kernel.org/gpu/drm-internals.html#unit-testing Best Regards, - Maíra Canal > Signed-off-by: Jouni Högander > --- > drivers/gpu/drm/drm_damage_help

Re: [PATCH] drm: Remove the unused param "struct drm_buddy *mm"

2022-08-25 Thread Maíra Canal
Hi Cai, On 6/27/22 05:54, Cai Huoqing wrote: > Remove the param "struct drm_buddy *mm" which is unused in > the function drm_block_alloc()/drm_block_free(). > > Signed-off-by: Cai Huoqing Reviewed-by: Maíra Canal Best Regards, - Maíra Canal > --- > driv

[PATCH v3 0/9] drm: selftest: Convert to KUnit

2022-06-29 Thread Maíra Canal
rebased on top of the recently applied patches for drm_format_helper tests (8f456104915f), in order to avoid conflicts when applying the tests. Thanks for your attention and any feedback is welcomed! Best Regards, - Maíra Canal v1 -> v2: https://lore.kernel.org/dri-devel/20220615135824.1552

[PATCH v3 1/9] drm: selftest: convert drm_damage_helper selftest to KUnit

2022-06-29 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM damage helper selftest to the KUnit API. Acked-by: Daniel Latypov Tested-by: David Gow Co-developed-by: Arthur Grillo Signed-off-by: Arthur Grillo Signed-off-by: Maíra Canal --- drivers/gpu/drm/Kconfig

[PATCH v3 2/9] drm: selftest: convert drm_cmdline_parser selftest to KUnit

2022-06-29 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM cmdline parser selftest to the KUnit API. Acked-by: Daniel Latypov Tested-by: David Gow Co-developed-by: Arthur Grillo Signed-off-by: Arthur Grillo Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile

[PATCH v3 3/9] drm: selftest: convert drm_rect selftest to KUnit

2022-06-29 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM rect selftest to the KUnit API. Acked-by: Daniel Latypov Tested-by: David Gow Co-developed-by: Carlos Veras Signed-off-by: Carlos Veras Co-developed-by: Matheus Vieira Signed-off-by: Matheus Vieira Signed-off-by: Maíra

[PATCH v3 4/9] drm: selftest: convert drm_format selftest to KUnit

2022-06-29 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM format selftest to the KUnit API. Acked-by: Daniel Latypov Tested-by: David Gow Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 3 +- .../gpu/drm/selftests/drm_modeset_selftests.h | 3

[PATCH v3 5/9] drm: selftest: convert drm_plane_helper selftest to KUnit

2022-06-29 Thread Maíra Canal
Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 4 +- .../gpu/drm/selftests/drm_modeset_selftests.h | 1 - .../drm/selftests/test-drm_modeset_common.h | 1 - drivers/gpu/drm/tests/Makefile| 2 +- .../drm_plane_helper_test.c

[PATCH v3 6/9] drm: selftest: convert drm_dp_mst_helper selftest to KUnit

2022-06-29 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM DP MST helper selftest to the KUnit API. Acked-by: Daniel Latypov Tested-by: David Gow Co-developed-by: Rubens Gomes Neto Signed-off-by: Rubens Gomes Neto Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests

[PATCH v3 7/9] drm: selftest: convert drm_framebuffer selftest to KUnit

2022-06-29 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM framebuffer selftest to the KUnit API. Acked-by: Daniel Latypov Tested-by: David Gow Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 5 +-- .../gpu/drm/selftests/drm_modeset_selftests.h

[PATCH v3 8/9] drm: selftest: convert drm_buddy selftest to KUnit

2022-06-29 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM buddy selftest to the KUnit API. Acked-by: Daniel Latypov Tested-by: David Gow Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 2 +- .../gpu/drm/selftests/drm_buddy_selftests.h | 15

[PATCH v3 9/9] drm: selftest: convert drm_mm selftest to KUnit

2022-06-29 Thread Maíra Canal
From: Arthur Grillo Considering the current adoption of the KUnit framework, convert the DRM mm selftest to the KUnit API. Acked-by: Daniel Latypov Tested-by: David Gow Signed-off-by: Arthur Grillo Signed-off-by: Maíra Canal --- Documentation/gpu/todo.rst| 11

[PATCH] drm/amd/display: Remove return value of Calculate256BBlockSizes

2022-06-30 Thread Maíra Canal
The function Calculate256BBlockSizes always returns true, regardless of the parameters. As any file checks the return of the function, this commit changes the return value to void. Signed-off-by: Maíra Canal --- drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c | 3 +-- drivers/gpu/drm/amd

[PATCH] drm/amd/display: Remove duplicate code across dcn30 and dcn31

2022-06-30 Thread Maíra Canal
used across dcn30 and dcn31. Signed-off-by: Maíra Canal --- .../dc/dml/dcn30/display_mode_vba_30.c| 21 +--- .../dc/dml/dcn30/display_mode_vba_30.h| 11 ++ .../dc/dml/dcn30/display_rq_dlg_calc_30.c | 93 +-- .../dc/dml/dcn31/display_mode_vba_31.c| 106

[PATCH] drm/amd/display: Remove unused variables from vba_vars_st

2022-06-30 Thread Maíra Canal
Some variables from the struct vba_vars_st are not referenced in any other place on the codebase. As they are not used, this commit removes those variables. Signed-off-by: Maíra Canal --- Unused variables from structs are not warned by compilers, so they are a bit harder to find. In order to

[PATCH v4 0/9] drm: selftest: Convert to KUnit

2022-07-02 Thread Maíra Canal
Hi everyone, Here is the v4 of the conversion of selftests to KUnit. Since the v3, there have been minor fixes, asked by Javier. Basically, fixes on the SoB chain and addition of Copywrites. Thanks for your attention and any feedback is welcomed! Best Regards, - Maíra Canal v1 -> v2: ht

[PATCH v4 1/9] drm: selftest: convert drm_damage_helper selftest to KUnit

2022-07-02 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM damage helper selftest to the KUnit API. Co-developed-by: Arthur Grillo Signed-off-by: Arthur Grillo Tested-by: David Gow Acked-by: Daniel Latypov Reviewed-by: Javier Martinez Canillas Signed-off-by: Maíra Canal

[PATCH v4 2/9] drm: selftest: convert drm_cmdline_parser selftest to KUnit

2022-07-02 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM cmdline parser selftest to the KUnit API. Co-developed-by: Arthur Grillo Signed-off-by: Arthur Grillo Tested-by: David Gow Acked-by: Daniel Latypov Reviewed-by: Javier Martinez Canillas Signed-off-by: Maíra Canal

[PATCH v4 3/9] drm: selftest: convert drm_rect selftest to KUnit

2022-07-02 Thread Maíra Canal
Martinez Canillas Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 2 +- .../gpu/drm/selftests/drm_modeset_selftests.h | 4 - .../drm/selftests/test-drm_modeset_common.h | 4 - drivers/gpu/drm/tests/Makefile| 2 +- .../test-drm_rect.c

[PATCH v4 4/9] drm: selftest: convert drm_format selftest to KUnit

2022-07-02 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM format selftest to the KUnit API. Tested-by: David Gow Acked-by: Daniel Latypov Reviewed-by: Javier Martinez Canillas Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 3 +- .../gpu/drm

[PATCH v4 5/9] drm: selftest: convert drm_plane_helper selftest to KUnit

2022-07-02 Thread Maíra Canal
Reviewed-by: Javier Martinez Canillas Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 4 +- .../gpu/drm/selftests/drm_modeset_selftests.h | 1 - .../drm/selftests/test-drm_modeset_common.h | 1 - drivers/gpu/drm/tests/Makefile| 2

[PATCH v4 6/9] drm: selftest: convert drm_dp_mst_helper selftest to KUnit

2022-07-02 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM DP MST helper selftest to the KUnit API. Co-developed-by: Rubens Gomes Neto Signed-off-by: Rubens Gomes Neto Tested-by: David Gow Acked-by: Daniel Latypov Reviewed-by: Javier Martinez Canillas Signed-off-by: Maíra Canal

[PATCH v4 7/9] drm: selftest: convert drm_framebuffer selftest to KUnit

2022-07-02 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM framebuffer selftest to the KUnit API. Tested-by: David Gow Acked-by: Daniel Latypov Reviewed-by: Javier Martinez Canillas Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 5 +-- .../gpu

[PATCH v4 8/9] drm: selftest: convert drm_buddy selftest to KUnit

2022-07-02 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM buddy selftest to the KUnit API. Tested-by: David Gow Acked-by: Daniel Latypov Reviewed-by: Javier Martinez Canillas Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 2 +- .../gpu/drm

[PATCH v4 9/9] drm: selftest: convert drm_mm selftest to KUnit

2022-07-02 Thread Maíra Canal
From: Arthur Grillo Considering the current adoption of the KUnit framework, convert the DRM mm selftest to the KUnit API. Signed-off-by: Arthur Grillo Tested-by: David Gow Acked-by: Daniel Latypov Reviewed-by: Javier Martinez Canillas Signed-off-by: Maíra Canal --- Documentation/gpu

[PATCH] drm/amd/display: Drop dm_sw_gfx7_2d_thin_l_vp and dm_sw_gfx7_2d_thin_gl

2022-07-07 Thread Maíra Canal
As the enum dm_sw_gfx7_2d_thin_gl and dm_sw_gfx7_2d_thin_l_vp are not used on the codebase, this commit drops those entries from enum dm_swizzle_mode. Signed-off-by: Maíra Canal --- .../dc/dml/dcn20/display_mode_vba_20.c| 26 +- .../dc/dml/dcn20/display_mode_vba_20v2.c

[PATCH v5 0/9] drm: selftest: Convert to KUnit

2022-07-08 Thread Maíra Canal
Hi everyone, Here is the v5 of the conversion of selftests to KUnit. Since the v4, the only fix was checking the checkpatch warnings and checks (Thank you Javier). Thanks for your attention and any feedback is welcomed! Best Regards, - Maíra Canal v1 -> v2: https://lore.kernel.org/dri-de

[PATCH v5 1/9] drm: selftest: convert drm_damage_helper selftest to KUnit

2022-07-08 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM damage helper selftest to the KUnit API. Co-developed-by: Arthur Grillo Signed-off-by: Arthur Grillo Tested-by: David Gow Acked-by: Daniel Latypov Reviewed-by: Javier Martinez Canillas Signed-off-by: Maíra Canal

[PATCH v5 2/9] drm: selftest: convert drm_cmdline_parser selftest to KUnit

2022-07-08 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM cmdline parser selftest to the KUnit API. Co-developed-by: Arthur Grillo Signed-off-by: Arthur Grillo Tested-by: David Gow Acked-by: Daniel Latypov Reviewed-by: Javier Martinez Canillas Signed-off-by: Maíra Canal

[PATCH v5 3/9] drm: selftest: convert drm_rect selftest to KUnit

2022-07-08 Thread Maíra Canal
Martinez Canillas Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 2 +- .../gpu/drm/selftests/drm_modeset_selftests.h | 4 - .../drm/selftests/test-drm_modeset_common.h | 4 - drivers/gpu/drm/selftests/test-drm_rect.c | 223 -- drivers

[PATCH v5 4/9] drm: selftest: convert drm_format selftest to KUnit

2022-07-08 Thread Maíra Canal
Considering the current adoption of the KUnit framework, convert the DRM format selftest to the KUnit API. Tested-by: David Gow Acked-by: Daniel Latypov Reviewed-by: Javier Martinez Canillas Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 3 +- .../gpu/drm

[PATCH v5 5/9] drm: selftest: convert drm_plane_helper selftest to KUnit

2022-07-08 Thread Maíra Canal
Reviewed-by: Javier Martinez Canillas Signed-off-by: Maíra Canal --- drivers/gpu/drm/selftests/Makefile| 4 +- .../gpu/drm/selftests/drm_modeset_selftests.h | 1 - .../drm/selftests/test-drm_modeset_common.h | 1 - drivers/gpu/drm/tests/Makefile| 2

  1   2   3   4   5   6   7   8   9   10   >