Re: [PATCH 2/2] drm/nouveau: DRM_NOUVEAU_SET_ZCULL_CTXSW_BUFFER

2025-03-21 Thread M Henning
This is a pointer in the gpu's virtual address space. It must be aligned according to ctxsw_align and be at least ctxsw_size bytes (where those values come from the nouveau_abi16_ioctl_get_zcull_info structure). I'll change the description to say that much. Yes, this is GEM-backed. I'm actually no

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-21 Thread M Henning
On Thu, Mar 20, 2025 at 2:18 PM Danilo Krummrich wrote: > > Hi Mel, Hi, thanks for the review. > On Wed, Mar 12, 2025 at 05:36:14PM -0400, Mel Henning wrote: > > Userspace needs this information to set up zcull correctly. > > This is a very brief motivation for the commit, please also describe w

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-25 Thread M Henning
Okay, that sounds reasonable since I don't expect this to change very quickly. Since I don't fully understand, is the suggestion here to: 1) add the interface as a function on nvkm_gr using the nvkm_gr_func vtable and store the actual data on r535_gr or 2) add the interface to NVIF (which IF?) and

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-27 Thread M Henning
On Thu, Mar 27, 2025 at 9:51 AM Danilo Krummrich wrote: > > On Fri, Mar 21, 2025 at 06:06:34PM -0400, M Henning wrote: > > On Thu, Mar 20, 2025 at 2:18 PM Danilo Krummrich wrote: > > > On Wed, Mar 12, 2025 at 05:36:14PM -0400, Mel Henning wrote: > > > &g

Re: [PATCH 1/2] drm/nouveau: Add DRM_IOCTL_NOUVEAU_GET_ZCULL_INFO

2025-03-27 Thread M Henning
On Thu, Mar 27, 2025 at 8:56 AM Danilo Krummrich wrote: > > On Tue, Mar 25, 2025 at 07:40:56PM -0400, M Henning wrote: > > Okay, that sounds reasonable since I don't expect this to change very > > quickly. > > > > Since I don't fully understand, i

Re: [PATCH 2/2] drm/nouveau: DRM_NOUVEAU_SET_ZCULL_CTXSW_BUFFER

2025-03-27 Thread M Henning
On Thu, Mar 27, 2025 at 9:58 AM Danilo Krummrich wrote: > > On Fri, Mar 21, 2025 at 07:00:57PM -0400, M Henning wrote: > > This is a pointer in the gpu's virtual address space. It must be > > aligned according to ctxsw_align and be at least ctxsw_size bytes > > (whe

Re: [PATCH 2/2] drm/nouveau: Remove nvkm_gsp_fwif.enable

2025-06-24 Thread M Henning
On Tue, Jun 24, 2025 at 1:28 PM Timur Tabi wrote: > Instead of removing it, I think we should rename it to indicate whether > GSP-RM is required. You > cannot boot Ada or later without GSP-RM, so on those platforms, > nouveau.config=NvGspRm=0 should be > ignored, and a pr_warn should be issued

Re: [PATCH 2/2] drm/nouveau: Remove nvkm_gsp_fwif.enable

2025-07-14 Thread M Henning
On Sun, Jul 13, 2025 at 11:19 PM Ben Skeggs wrote: > Yeah, the GPUs that don't support GSP-RM can't hit the code that used > fwif.enable anyway, so the series should be fine as it is. We're actually talking about the reverse case. That is, on Ada what happens if you set nouveau.config=NvGspRm=0 o

Re: [PATCH 2/2] drm/nouveau: Remove nvkm_gsp_fwif.enable

2025-06-26 Thread M Henning
On Tue, Jun 24, 2025 at 3:13 PM Timur Tabi wrote: > You have a good point, but I think your change, in effect, necessitates my > request. Previously, the > default was no GSP-RM unless needed. Now it's yes GSP-RM, and the concept of > "need" has been > removed. So there's no indication any mo

Re: [PATCH 2/2] drm/nouveau: DRM_NOUVEAU_SET_ZCULL_CTXSW_BUFFER

2025-07-31 Thread M Henning
On Fri, Mar 28, 2025 at 7:48 AM Danilo Krummrich wrote: > > On Thu, Mar 27, 2025 at 03:01:54PM -0400, M Henning wrote: > > On Thu, Mar 27, 2025 at 9:58 AM Danilo Krummrich wrote: > > > > > > On Fri, Mar 21, 2025 at 07:00:57PM -0400, M Henning wrote: > > > &