Re: [PATCH][next] video: fbdev: atmel_lcdfb: remove redundant initialization to variable ret

2019-06-12 Thread Ludovic Desroches
> value is never read and ret is being re-assigned later on. Hence this > > assignment is redundant and can be removed. > > > > Addresses-Coverity: ("Unused value") > > Signed-off-by: Colin Ian King > > Indeed: > Acked-by: Nicola

[PATCH] video: fbdev: convert to use GPIO descriptors

2018-02-05 Thread Ludovic Desroches
Use GPIO descriptors instead of relying on the old method. Signed-off-by: Ludovic Desroches --- drivers/video/fbdev/atmel_lcdfb.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev

[RESEND][PATCH] video: fbdev: atmel_lcdfb: convert to use GPIO descriptors

2018-02-05 Thread Ludovic Desroches
Use GPIO descriptors instead of relying on the old method. Signed-off-by: Ludovic Desroches --- drivers/video/fbdev/atmel_lcdfb.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev

Re: [RESEND][PATCH] video: fbdev: atmel_lcdfb: convert to use GPIO descriptors

2018-02-05 Thread Ludovic Desroches
On Mon, Feb 05, 2018 at 03:06:33PM +0200, Andy Shevchenko wrote: > On Mon, Feb 5, 2018 at 10:47 AM, Ludovic Desroches > wrote: > > Use GPIO descriptors instead of relying on the old method. > > Reviewed-by: Andy Shevchenko > > Though few nitpicks below. > >

[PATCH V2] video: fbdev: atmel_lcdfb: convert to use GPIO descriptors

2018-02-05 Thread Ludovic Desroches
Use GPIO descriptors instead of relying on the old method. Signed-off-by: Ludovic Desroches Acked-by: Nicolas Ferre Reviewed-by: Linus Walleij Reviewed-by: Andy Shevchenko --- Changes - V2: - remove of_gpio.h. - move gpiod declaration to preserve reversed tree style. - use

Re: [RESEND][PATCH] video: fbdev: atmel_lcdfb: convert to use GPIO descriptors

2018-02-05 Thread Ludovic Desroches
On Mon, Feb 05, 2018 at 12:56:04PM +0100, Linus Walleij wrote: > On Mon, Feb 5, 2018 at 9:47 AM, Ludovic Desroches > wrote: > > > Use GPIO descriptors instead of relying on the old method. > > > > Signed-off-by: Ludovic Desroches > > Ah there it is :D > Revi

[PATCH v4 00/11] drm: add support for Atmel HLCDC Display Controller

2014-08-21 Thread Ludovic Desroches
Hi Boris, You can add Tested-by: Ludovic Desroches Only one issue but not related to your patches, you can't display quickly the bootup logo since the panel detection takes too much time. Regards Ludovic On Tue, Jul 22, 2014 at 03:11:24PM +0200, Boris BREZILLON wrote: > Hello, &