Re: [PATCH] drm/msm/mdp5: Fix wait-for-commit for cmd panels

2021-02-01 Thread Luca Weiss
Suggested-by: Rob Clark > Fixes: 2d99ced787e3d ("drm/msm: async commit support") > --- I've tested this now on fairphone-fp2 and lge-nexus5-hammerhead, works great! Tested-by: Luca Weiss Regards Luca ___ dri-de

Re: [PATCH] drm: add missing dependency to DRM_PANEL_EDP

2022-02-26 Thread Luca Weiss
Hi, any feedback on this patch? On Sonntag, 23. Jänner 2022 21:43:23 CET Luca Weiss wrote: > With CONFIG_DRM_PANEL_EDP=y and CONFIG_DRM_KMS_HELPER=m the compilation > fails: > > drivers/gpu/drm/panel/panel-edp.c:843: undefined reference to > `drm_panel_dp_aux_backlight' &

[PATCH] dt-bindings: display: add missing simple-framebuffer formats

2021-08-28 Thread Luca Weiss
Document all formats currently present in include/linux/platform_data/ simplefb.h Signed-off-by: Luca Weiss --- .../bindings/display/simple-framebuffer.yaml | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/display/simple

Re: [PATCH] dt-bindings: display: add missing simple-framebuffer formats

2021-09-01 Thread Luca Weiss
Hi Rob, On Dienstag, 31. August 2021 23:30:15 CEST Rob Herring wrote: > On Sat, Aug 28, 2021 at 01:02:05PM +0200, Luca Weiss wrote: > > Document all formats currently present in include/linux/platform_data/ > > simplefb.h > > > > Signed-off-by: Luca Weiss > > -

[PATCH] drm: add missing dependency to DRM_PANEL_EDP

2022-01-23 Thread Luca Weiss
With CONFIG_DRM_PANEL_EDP=y and CONFIG_DRM_KMS_HELPER=m the compilation fails: drivers/gpu/drm/panel/panel-edp.c:843: undefined reference to `drm_panel_dp_aux_backlight' Add a dependency on DRM_KMS_HELPER to fix this. Signed-off-by: Luca Weiss --- I briefly tried "select DRM_KMS_H

Re: [PATCH] drm: add missing dependency to DRM_PANEL_EDP

2022-01-23 Thread Luca Weiss
On Sonntag, 23. Jänner 2022 21:43:23 CET Luca Weiss wrote: > With CONFIG_DRM_PANEL_EDP=y and CONFIG_DRM_KMS_HELPER=m the compilation > fails: > > drivers/gpu/drm/panel/panel-edp.c:843: undefined reference to > `drm_panel_dp_aux_backlight' > > Add a dependency on

[PATCH 00/10] dt-binding patches for sm6350

2021-12-13 Thread Luca Weiss
x27;t picked up when sent to the lists in August 2021. Konrad Dybcio (1): dt-bindings: arm: msm: Add LLCC for SM6350 Luca Weiss (9): dt-bindings: firmware: scm: Add SM6350 compatible dt-bindings: qcom,pdc: Add SM6350 compatible dt-bindings: phy: qcom,qusb2: Add SM6350 compatible dt-bin

[PATCH 09/10] dt-bindings: simple-framebuffer: allow standalone compatible

2021-12-13 Thread Luca Weiss
Qualcomm platforms use "simple-framebuffer" without a more specific compatible. Allow that in the binding doc. Signed-off-by: Luca Weiss --- .../bindings/display/simple-framebuffer.yaml | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/Doc

[PATCH 0/4] Enable display backlight on Fairphone 4

2021-12-29 Thread Luca Weiss
Add and enable PM6150L wled which is used for controlling the display backlight on Fairphone 4. This series depends on the recent wled series by Marijn Suijten, currently applied in the for-backlight-next branch of kernel/git/lee/backlight.git (or linux-next). Luca Weiss (4): dt-bindings

[PATCH 1/4] dt-bindings: backlight: qcom-wled: Add PM6150L compatible

2021-12-29 Thread Luca Weiss
Document the compatible for the wled block found in PM6150L. Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml b/Documentation

[PATCH 2/4] backlight: qcom-wled: Add PM6150L compatible

2021-12-29 Thread Luca Weiss
PM6150L contains WLED of version 5. Add support ofr it to the driver. Signed-off-by: Luca Weiss --- drivers/video/backlight/qcom-wled.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c index 306bcc6ccb92..527210e85795

[PATCH] drm/msm: Fix NULL pointer dereference

2019-03-03 Thread Luca Weiss
) [4.294933] ---[ end trace 18729cc2bca2b4b3 ]--- Signed-off-by: Luca Weiss --- drivers/gpu/drm/msm/msm_gem_vma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c index 49c04829cf34..fcf7a83f0e6f 100644

[PATCH] drm/msm/dsi: Use single function for reset

2022-06-10 Thread Luca Weiss
. However this assumtion is not true mobile devices which have boot splash set up by boot-loader. This patch removes dsi_sw_reset_restore and makes dsi_sw_reset disable DSI controller during reset sequence if it's enabled. Signed-off-by: Vladimir Lypak Signed-off-by: Luca Weiss --- drivers/gp

[PATCH 1/2] drm/msm/mdp5: Add perf data for MDP v1.16

2022-06-10 Thread Luca Weiss
From: Vladimir Lypak Add the perf data for the mdp found in msm8953. Signed-off-by: Vladimir Lypak Signed-off-by: Luca Weiss --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c b/drivers/gpu/drm/msm

[PATCH v2 0/4] MDSS support for MSM8953

2022-06-12 Thread Luca Weiss
This series adds the APPS IOMMU and the MDSS block for display that is found on msm8953 SoCs. Luca Weiss (1): dt-bindings: qcom-iommu: Add Qualcomm MSM8953 compatible Vladimir Lypak (3): arm64: dts: qcom: msm8953: add APPS IOMMU drm/msm/mdp5: Add perf data for MDP v1.16 arm64: dts: qcom

[PATCH v2 3/4] drm/msm/mdp5: Add perf data for MDP v1.16

2022-06-12 Thread Luca Weiss
From: Vladimir Lypak Add the perf data for the mdp found in msm8953. Signed-off-by: Vladimir Lypak Signed-off-by: Luca Weiss Reviewed-by: Dmitry Baryshkov --- Changes from v1: - pick up R-b tag drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [PATCH 2/5] drm/msm/mdss: enable optional core clock for MDP5 MDSS

2022-06-18 Thread Luca Weiss
Hi Dmitry, On Mittwoch, 15. Juni 2022 15:59:32 CEST Dmitry Baryshkov wrote: > Enable (optional) core (MDP_CLK) clock that allows accessing HW_REV > registers during the platform init. > I believe you also need to update Documentation/devicetree/bindings/display/ msm/mdp5.txt with the new clock.

[PATCH] drm/msm: Fix null pointer dereferences without iommu

2022-04-21 Thread Luca Weiss
Check if 'aspace' is set before using it as it will stay null without IOMMU, such as on msm8974. Fixes: bc2112583a0b ("drm/msm/gpu: Track global faults per address-space") Signed-off-by: Luca Weiss --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 5 - drivers/g

Re: [PATCH] i2c: qcom-geni: Fix GPI DMA buffer sync-back

2022-08-08 Thread Luca Weiss
d-off-by: Robin Reckmann This makes I2C with GPI DMA work on sm6350/sm7725 fairphone-fp4! Thanks for fixing this! Tested-by: Luca Weiss Regards Luca > --- > drivers/i2c/busses/i2c-qcom-geni.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/driver

Re: [PATCH v3 2/4] drm/msm/adreno: Add A619 support

2022-06-28 Thread Luca Weiss
Hi all, any comment on this patch series? Would be great to get this into 5.20 Regards Luca On Samstag, 28. Mai 2022 18:03:49 CEST Konrad Dybcio wrote: > Add support for the Adreno 619 GPU, as found in Snapdragon 690 (SM6350), > 480 (SM4350) and 750G (SM7225). > > Signed-off-by: Konrad Dybcio

Re: [PATCH v1 1/4] drm/msm/mdp5: stop overriding drvdata

2022-09-22 Thread Luca Weiss
Hi Dmitry, On Montag, 20. Juni 2022 23:30:51 CEST Dmitry Baryshkov wrote: > The rest of the code expects that master's device drvdata is the > struct msm_drm_private instance. Do not override the mdp5's drvdata. > > Fixes: 6874f48bb8b0 ("drm/msm: make mdp5/dpu devices master components") > Signed

[PATCH] backlight: qcom-wled: Add PMI8950 compatible

2023-02-06 Thread Luca Weiss
PMI8950 contains WLED of version 4. Add support for it to the driver. Signed-off-by: Luca Weiss --- While adding dt-bindings and dts in a previous series I forgot to add the compatible to the driver. Fix that now. --- drivers/video/backlight/qcom-wled.c | 1 + 1 file changed, 1 insertion

[PATCH v3 1/2] dt-bindings: backlight: qcom-wled: Add PMI8950 compatible

2022-11-01 Thread Luca Weiss
Document the compatible for the wled block found in PMI8950. Signed-off-by: Luca Weiss --- Changes since v2: * New patch Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom

Re: [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node

2023-03-24 Thread Luca Weiss
Hi Eric, On Fri Mar 24, 2023 at 7:52 AM CET, Eric Biggers wrote: > Hi Neil, > > On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote: > > Hi, > > > > On 23/03/2023 11:49, Krzysztof Kozlowski wrote: > > > On 23/03/2023 11:25, Neil Armstrong wrote: > > > > Fixes the following DT bindings

[PATCH 3/7] dt-bindings: display/msm: qcom,mdp5: Add msm8226 compatible

2023-05-29 Thread Luca Weiss
Add the compatible for the MDP5 found on MSM8226. Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml b/Documentation/devicetree/bindings

[PATCH 4/7] drm/msm/mdp5: Add MDP5 configuration for MSM8226

2023-05-29 Thread Luca Weiss
Add the required config for the v1.1 MDP5 found on MSM8226. Signed-off-by: Luca Weiss --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 82 1 file changed, 82 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c b/drivers/gpu/drm/msm/disp/mdp5

[PATCH 6/7] drm/msm/dsi: Add phy configuration for MSM8226

2023-05-29 Thread Luca Weiss
eqs[5] = dsi_pll_enable_seq_c, .pll_enable_seqs[6] = dsi_pll_enable_seq_e, We may need to expand this in the future. Signed-off-by: Luca Weiss --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 + drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 3 +- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c

[PATCH 7/7] ARM: dts: qcom: msm8226: Add mdss nodes

2023-05-29 Thread Luca Weiss
Add the nodes that describe the mdss so that display can work on MSM8226. Signed-off-by: Luca Weiss --- arch/arm/boot/dts/qcom-msm8226.dtsi | 118 1 file changed, 118 insertions(+) diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom

[PATCH 0/7] Display support for MSM8226

2023-05-29 Thread Luca Weiss
This series adds the required configs for MDP5 and DSI blocks that are needed for MDSS on MSM8226. Finally we can add the new nodes into the dts. Tested on apq8026-lg-lenok and msm8926-htc-memul. Signed-off-by: Luca Weiss --- Luca Weiss (7): dt-bindings: msm: dsi-phy-28nm: Document

[PATCH 2/7] dt-bindings: display/msm: dsi-controller-main: Add msm8226 compatible

2023-05-29 Thread Luca Weiss
Add the compatible for the DSI found on MSM8226. Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation

[PATCH 5/7] drm/msm/dsi: Add configuration for MSM8226

2023-05-29 Thread Luca Weiss
Add the config for the v1.0.2 DSI found on MSM8226. We can reuse existing bits from other revisions that are identical for v1.0.2. Signed-off-by: Luca Weiss --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 ++ drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + 2 files changed, 3 insertions(+) diff --git a

[PATCH 1/7] dt-bindings: msm: dsi-phy-28nm: Document msm8226 compatible

2023-05-29 Thread Luca Weiss
The MSM8226 SoC uses a slightly different 28nm dsi phy. Add a new compatible for it. Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml | 1 + Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml| 1 + 2 files changed, 2 insertions(+) diff

[PATCH v2 1/7] dt-bindings: msm: dsi-phy-28nm: Document msm8226 compatible

2023-05-30 Thread Luca Weiss
The MSM8226 SoC uses a slightly different 28nm dsi phy. Add a new compatible for it. And while we're at it, in the dsi-phy-28nm.yaml move the 8960 compatible to its correct place so its sorted alphabetically. Acked-by: Conor Dooley Signed-off-by: Luca Weiss --- Documentation/devic

[PATCH v2 0/7] Display support for MSM8226

2023-05-30 Thread Luca Weiss
This series adds the required configs for MDP5 and DSI blocks that are needed for MDSS on MSM8226. Finally we can add the new nodes into the dts. Tested on apq8026-lg-lenok and msm8926-htc-memul. Signed-off-by: Luca Weiss --- Changes in v2: - In dsi-phy-28nm.yaml fix the order of the

[PATCH v2 6/7] drm/msm/dsi: Add phy configuration for MSM8226

2023-05-30 Thread Luca Weiss
eqs[5] = dsi_pll_enable_seq_c, .pll_enable_seqs[6] = dsi_pll_enable_seq_e, We may need to expand this in the future. Signed-off-by: Luca Weiss --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 + drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 3 +- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c

[PATCH v2 3/7] dt-bindings: display/msm: qcom,mdp5: Add msm8226 compatible

2023-05-30 Thread Luca Weiss
Add the compatible for the MDP5 found on MSM8226. Acked-by: Conor Dooley Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml b/Documentation

[PATCH v2 2/7] dt-bindings: display/msm: dsi-controller-main: Add msm8226 compatible

2023-05-30 Thread Luca Weiss
Add the compatible for the DSI found on MSM8226. Acked-by: Conor Dooley Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller

[PATCH v2 4/7] drm/msm/mdp5: Add MDP5 configuration for MSM8226

2023-05-30 Thread Luca Weiss
Add the required config for the v1.1 MDP5 found on MSM8226. Reviewed-by: Dmitry Baryshkov Signed-off-by: Luca Weiss --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 82 1 file changed, 82 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c b

[PATCH v2 5/7] drm/msm/dsi: Add configuration for MSM8226

2023-05-30 Thread Luca Weiss
Add the config for the v1.0.2 DSI found on MSM8226. We can reuse existing bits from other revisions that are identical for v1.0.2. Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio Signed-off-by: Luca Weiss --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 ++ drivers/gpu/drm/msm/dsi/dsi_cfg.h

[PATCH v2 7/7] ARM: dts: qcom: msm8226: Add mdss nodes

2023-05-30 Thread Luca Weiss
Add the nodes that describe the mdss so that display can work on MSM8226. Signed-off-by: Luca Weiss --- arch/arm/boot/dts/qcom-msm8226.dtsi | 127 1 file changed, 127 insertions(+) diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom

[PATCH v3 3/7] dt-bindings: display/msm: qcom,mdp5: Add msm8226 compatible

2023-06-01 Thread Luca Weiss
Add the compatible for the MDP5 found on MSM8226. Acked-by: Conor Dooley Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml b/Documentation

[PATCH v3 2/7] dt-bindings: display/msm: dsi-controller-main: Add msm8226 compatible

2023-06-01 Thread Luca Weiss
Add the compatible for the DSI found on MSM8226. Acked-by: Conor Dooley Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller

[PATCH v3 5/7] drm/msm/dsi: Add configuration for MSM8226

2023-06-01 Thread Luca Weiss
Add the config for the v1.0.2 DSI found on MSM8226. We can reuse existing bits from other revisions that are identical for v1.0.2. Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio Signed-off-by: Luca Weiss --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 ++ drivers/gpu/drm/msm/dsi/dsi_cfg.h

[PATCH v3 6/7] drm/msm/dsi: Add phy configuration for MSM8226

2023-06-01 Thread Luca Weiss
eqs[5] = dsi_pll_enable_seq_c, .pll_enable_seqs[6] = dsi_pll_enable_seq_e, We may need to expand this in the future. Signed-off-by: Luca Weiss --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 + drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 3 +- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c

[PATCH v3 4/7] drm/msm/mdp5: Add MDP5 configuration for MSM8226

2023-06-01 Thread Luca Weiss
Add the required config for the v1.1 MDP5 found on MSM8226. Reviewed-by: Dmitry Baryshkov Signed-off-by: Luca Weiss --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 82 1 file changed, 82 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c b

[PATCH v3 1/7] dt-bindings: msm: dsi-phy-28nm: Document msm8226 compatible

2023-06-01 Thread Luca Weiss
The MSM8226 SoC uses a slightly different 28nm dsi phy. Add a new compatible for it. And while we're at it, in the dsi-phy-28nm.yaml move the 8960 compatible to its correct place so its sorted alphabetically. Acked-by: Conor Dooley Signed-off-by: Luca Weiss --- Documentation/devic

[PATCH v3 0/7] Display support for MSM8226

2023-06-01 Thread Luca Weiss
This series adds the required configs for MDP5 and DSI blocks that are needed for MDSS on MSM8226. Finally we can add the new nodes into the dts. Tested on apq8026-lg-lenok and msm8926-htc-memul. Signed-off-by: Luca Weiss --- Changes in v3: - Adjust mdss labels to new style (Stephan) - Link to

[PATCH v3 7/7] ARM: dts: qcom: msm8226: Add mdss nodes

2023-06-01 Thread Luca Weiss
Add the nodes that describe the mdss so that display can work on MSM8226. Signed-off-by: Luca Weiss --- arch/arm/boot/dts/qcom-msm8226.dtsi | 127 1 file changed, 127 insertions(+) diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom

Re: [Freedreno] [PATCH v3 6/7] drm/msm/dsi: Add phy configuration for MSM8226

2023-06-07 Thread Luca Weiss
On Mittwoch, 7. Juni 2023 21:46:31 CEST Jeykumar Sankaran wrote: > On 6/1/2023 10:00 AM, Luca Weiss wrote: > > MSM8226 uses a modified PLL lock sequence compared to MSM8974, which is > > based on the function dsi_pll_enable_seq_m in the msm-3.10 kernel. > > > > Wor

[PATCH] drm/msm/adreno: fix probe without iommu

2020-09-14 Thread Luca Weiss
The function iommu_domain_alloc returns NULL on platforms without IOMMU such as msm8974. This resulted in PTR_ERR(-ENODEV) being assigned to gpu->aspace so the correct code path wasn't taken. Fixes: ccac7ce373c1 ("drm/msm: Refactor address space initialization") Signed-

Re: [PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-03-08 Thread Luca Weiss
On Sun Mar 3, 2024 at 9:37 PM CET, Dmitry Baryshkov wrote: > On Thu, 29 Feb 2024 at 11:27, Luca Weiss wrote: > > > > On Wed Jan 17, 2024 at 9:59 AM CET, Luca Weiss wrote: > > > On Mon Jan 15, 2024 at 9:43 AM CET, Neil Armstrong wrote: > > > > Hi Luca, >

Re: [PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-03-18 Thread Luca Weiss
On Mon Mar 18, 2024 at 11:59 AM CET, Jani Nikula wrote: > On Mon, 18 Mar 2024, Jani Nikula wrote: > > On Mon, 18 Mar 2024, Neil Armstrong wrote: > >> Hi, > >> > >> On Thu, 11 Jan 2024 13:38:04 +0100, Luca Weiss wrote: > >>> Since the kconfig symbol

Re: [RFC PATCH 1/3] drm/msm/dpu: add support for MSM8953

2023-10-06 Thread Luca Weiss
On Freitag, 6. Oktober 2023 15:38:51 CEST Dmitry Baryshkov wrote: > On 29/09/2023 23:52, Luca Weiss wrote: > > On Samstag, 23. September 2023 23:49:10 CEST Dmitry Baryshkov wrote: > >> Experimental support for MSM8953, which has MDP5 v1.16. It looks like > >> trimmed do

Re: [RFC PATCH 1/3] drm/msm/dpu: add support for MSM8953

2023-09-29 Thread Luca Weiss
On Samstag, 23. September 2023 23:49:10 CEST Dmitry Baryshkov wrote: > Experimental support for MSM8953, which has MDP5 v1.16. It looks like > trimmed down version of MSM8996. Less SSPP, LM and PP blocks. No DSC, > etc. > Hi Dmitry, As written on IRC, on sdm632-fairphone-fp3 with this DPU patche

[PATCH 2/4] backlight: lm3630a: Don't set bl->props.brightness in get_brightness

2024-02-19 Thread Luca Weiss
driver for lm3630 chip") Signed-off-by: Luca Weiss --- drivers/video/backlight/lm3630a_bl.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c index 8e275275b808..26ff4178cc16 100644 -

[PATCH 4/4] ARM: dts: qcom: msm8974-hammerhead: Hook up backlight

2024-02-19 Thread Luca Weiss
Connect the panel with the backlight nodes so that the backlight can be turned off when the display is blanked. Signed-off-by: Luca Weiss --- arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts

[PATCH 0/4] Various fixes for the lm3630a backlight driver

2024-02-19 Thread Luca Weiss
rking on this. As last commit, we can finally hook up the panel and backlight on the Nexus 5 so blanking the screen actually turns off the backlight. Signed-off-by: Luca Weiss --- Luca Weiss (4): backlight: lm3630a: Initialize backlight_properties on init backlight: lm3630a: Don

[PATCH 1/4] backlight: lm3630a: Initialize backlight_properties on init

2024-02-19 Thread Luca Weiss
The backlight_properties struct should be initialized to zero before using, otherwise there will be some random values in the struct. Fixes: 0c2a665a648e ("backlight: add Backlight driver for lm3630 chip") Signed-off-by: Luca Weiss --- drivers/video/backlight/lm3630a_bl.c | 1 + 1 fi

[PATCH 3/4] backlight: lm3630a: Use backlight_get_brightness helper in update_status

2024-02-19 Thread Luca Weiss
As per documentation "drivers are expected to use this function in their update_status() operation to get the brightness value.". With this we can also drop the manual backlight_is_blank() handling since backlight_get_brightness() is already handling this correctly. Signed-off-by:

Re: [PATCH 3/4] backlight: lm3630a: Use backlight_get_brightness helper in update_status

2024-02-20 Thread Luca Weiss
On Dienstag, 20. Februar 2024 15:11:07 CET Daniel Thompson wrote: > On Tue, Feb 20, 2024 at 12:11:21AM +0100, Luca Weiss wrote: > > As per documentation "drivers are expected to use this function in their > > update_status() operation to get the brightness value.". >

Re: [PATCH 4/4] ARM: dts: qcom: msm8974-hammerhead: Hook up backlight

2024-02-20 Thread Luca Weiss
On Dienstag, 20. Februar 2024 15:12:10 CET Daniel Thompson wrote: > On Tue, Feb 20, 2024 at 12:11:22AM +0100, Luca Weiss wrote: > > Connect the panel with the backlight nodes so that the backlight can be > > turned off when the display is blanked. > > > > Signed-off-by

Re: [PATCH RESEND 0/4] Ensure all backlight drivers zero the properties structure

2024-02-20 Thread Luca Weiss
On Dienstag, 20. Februar 2024 16:35:23 CET Daniel Thompson wrote: > [Sorry for the RESEND so soon... embarrassingly I got Lee's e-mail > address wrong the first time!] > > Luca Weiss recently shared a patch to zero the properties structure for > lm3630a... and shortly aft

Re: [PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-02-29 Thread Luca Weiss
On Wed Jan 17, 2024 at 9:59 AM CET, Luca Weiss wrote: > On Mon Jan 15, 2024 at 9:43 AM CET, Neil Armstrong wrote: > > Hi Luca, > > > > On 11/01/2024 13:38, Luca Weiss wrote: > > > Since the kconfig symbol of DRM_PANEL_BRIDGE is only adding > > > bridge/panel

Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-02-14 Thread Luca Weiss
On Mon Jan 22, 2024 at 12:27 PM CET, Luca Weiss wrote: > On Fri Jan 12, 2024 at 11:26 AM CET, wrote: > > On 12/01/2024 11:23, Linus Walleij wrote: > > > On Fri, Jan 12, 2024 at 10:52 AM Luca Weiss > > > wrote: > > > > > >> Since there's

[PATCH v3 0/4] Add display support for Fairphone 4

2024-02-16 Thread Luca Weiss
Introduce the bindings and panel driver for the LCD panel with the model number 9A-3R063-1102B from DJN which is using the HX83112A driver IC. It is used on the Fairphone 4 smartphone. Then we can add the panel to the device dts and also enable the GPU. Signed-off-by: Luca Weiss --- Changes in

[PATCH v3 1/4] dt-bindings: display: panel: Add Himax HX83112A

2024-02-16 Thread Luca Weiss
Himax HX83112A is a display driver IC used to drive LCD DSI panels. Describe it and the DJN 9A-3R063-1102B using it. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Luca Weiss --- .../bindings/display/panel/himax,hx83112a.yaml | 74 ++ 1 file changed, 74 insertions

[PATCH v3 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-02-16 Thread Luca Weiss
Add support for the 2340x1080 LCD panel (DJN 9A-3R063-1102B) bundled with a HX83112A driver IC, as found on the Fairphone 4 smartphone. Signed-off-by: Luca Weiss --- drivers/gpu/drm/panel/Kconfig| 10 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel

[PATCH v3 4/4] arm64: dts: qcom: sm7225-fairphone-fp4: Enable display and GPU

2024-02-16 Thread Luca Weiss
onrad Dybcio Signed-off-by: Luca Weiss --- arch/arm64/boot/dts/qcom/sm6350.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 53 +++ 2 files changed, 54 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64

[PATCH v3 3/4] arm64: dts: qcom: sm6350: Remove "disabled" state of GMU

2024-02-16 Thread Luca Weiss
The GMU won't probe without GPU being enabled, so we can remove the disabled status so we don't have to explicitly enable the GMU in all the devices that enable GPU. Reviewed-by: Konrad Dybcio Signed-off-by: Luca Weiss --- arch/arm64/boot/dts/qcom/sm6350.dtsi | 2 -- 1 file

Re: [RFT PATCH v2 01/48] drm/panel: raydium-rm692e5: Stop tracking prepared

2024-05-09 Thread Luca Weiss
enabled state. Even if someone was relying on the > double-check before, that double-check is now in the core and not > needed in individual drivers. > > Cc: Luca Weiss > Cc: Konrad Dybcio > Signed-off-by: Douglas Anderson Seems to match with the changes I did for another (generat

[PATCH 3/3] ARM: dts: qcom: msm8226: Add GPU

2023-11-30 Thread Luca Weiss
The msm8226 SoC contains an Adreno 305B. Add a node to configure it. Signed-off-by: Luca Weiss --- arch/arm/boot/dts/qcom/qcom-msm8226.dtsi | 40 1 file changed, 40 insertions(+) diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom

[PATCH 0/3] Add GPU support for MSM8226 (Adreno A305B)

2023-11-30 Thread Luca Weiss
Add the necessary bits to bring up the GPU on msm8226. Tested on apq8026-lg-lenok. Signed-off-by: Luca Weiss --- Luca Weiss (3): dt-bindings: display/msm: gpu: Allow multiple digits for patchid drm/msm/adreno: Add A305B support ARM: dts: qcom: msm8226: Add GPU .../devicetree

[PATCH 1/3] dt-bindings: display/msm: gpu: Allow multiple digits for patchid

2023-11-30 Thread Luca Weiss
Some GPUs like the Adreno A305B has a patchid higher than 9, in this case 18. Make sure the regexes can account for that. Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation

[PATCH 2/3] drm/msm/adreno: Add A305B support

2023-11-30 Thread Luca Weiss
e for testing this is not added. Signed-off-by: Luca Weiss --- drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 15 --- drivers/gpu/drm/msm/adreno/adreno_device.c | 15 +++ drivers/gpu/drm/msm/adreno/adreno_gpu.h| 5 + 3 files changed, 28 insertions(+), 7 deletions(-)

[PATCH] drm/msm/adreno: Set highest_bank_bit for A619

2024-03-28 Thread Luca Weiss
's no screen corruption. [0] commit 6a0dbcd20ef2 ("drm/msm/a6xx: set highest_bank_bit to 13 for a610") Fixes: b7616b5c69e6 ("drm/msm/adreno: Add A619 support") Signed-off-by: Luca Weiss --- @Akhil: Dmitry & Abhinav said I should ping you specifically to take a look if

[PATCH 0/3] DisplayPort support for SM6350/SM7225

2024-03-28 Thread Luca Weiss
Add the required changes to support DisplayPort (normally(?) available via the USB-C connector) on the SM6350/SM7225 SoC. This has been tested on a Fairphone 4 smartphone with additional changes not included in this series (mostly just wiring up TCPM and the SBU mux). Signed-off-by: Luca Weiss

[PATCH 1/3] dt-bindings: display: msm: dp-controller: document SM8250 compatible

2024-03-28 Thread Luca Weiss
Add the compatible string for the DisplayPort controller on SM6350 which is compatible with the one on SM8350. Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings

[PATCH 2/3] dt-bindings: display: msm: sm6350-mdss: document DP controller subnode

2024-03-28 Thread Luca Weiss
Document the displayport controller subnode of the SM6350 MDSS. Signed-off-by: Luca Weiss --- .../devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml b

[PATCH 3/3] arm64: dts: qcom: sm6350: Add DisplayPort controller

2024-03-28 Thread Luca Weiss
Add the node for the DisplayPort controller found on the SM6350 SoC. Signed-off-by: Luca Weiss --- arch/arm64/boot/dts/qcom/sm6350.dtsi | 88 1 file changed, 88 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom

Re: [PATCH 1/3] dt-bindings: display: msm: dp-controller: document SM8250 compatible

2024-03-28 Thread Luca Weiss
Stupid typo in subject, should of course be SM6350, not SM8250. On Thu Mar 28, 2024 at 10:42 AM CET, Luca Weiss wrote: > Add the compatible string for the DisplayPort controller on SM6350 which > is compatible with the one on SM8350. > > Signed-off-by: Luca Weiss > --- &

[PATCH v2 0/3] DisplayPort support for SM6350/SM7225

2024-03-29 Thread Luca Weiss
Add the required changes to support DisplayPort (normally(?) available via the USB-C connector) on the SM6350/SM7225 SoC. This has been tested on a Fairphone 4 smartphone with additional changes not included in this series (mostly just wiring up TCPM and the SBU mux). Signed-off-by: Luca Weiss

[PATCH v2 1/3] dt-bindings: display: msm: dp-controller: document SM6350 compatible

2024-03-29 Thread Luca Weiss
Add the compatible string for the DisplayPort controller on SM6350 which is compatible with the one on SM8350. Acked-by: Rob Herring Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation

[PATCH v2 2/3] dt-bindings: display: msm: sm6350-mdss: document DP controller subnode

2024-03-29 Thread Luca Weiss
Document the displayport controller subnode of the SM6350 MDSS. Signed-off-by: Luca Weiss --- .../devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml| 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml b

[PATCH v2 3/3] arm64: dts: qcom: sm6350: Add DisplayPort controller

2024-03-29 Thread Luca Weiss
Add the node for the DisplayPort controller found on the SM6350 SoC. Reviewed-by: Dmitry Baryshkov Signed-off-by: Luca Weiss --- arch/arm64/boot/dts/qcom/sm6350.dtsi | 88 1 file changed, 88 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi

Re: [PATCH] drm/msm/dpu: fix vblank IRQ handling for command panels

2024-05-03 Thread Luca Weiss
On Sun Apr 7, 2024 at 5:15 AM CEST, Dmitry Baryshkov wrote: > On Sat, 30 Mar 2024 at 18:49, Marijn Suijten > wrote: > > > > On 2024-03-30 05:52:29, Dmitry Baryshkov wrote: > > > In case of CMD DSI panels, the vblank IRQ can be used outside of > > > irq_enable/irq_disable pair. This results in the

[PATCH 0/3] Add display support for Fairphone 4

2024-01-05 Thread Luca Weiss
Introduce the bindings and panel driver for the DJN LCD panel using HX83112A driver IC. Then we can add the panel to the device dts and also enable the GPU. Signed-off-by: Luca Weiss --- Luca Weiss (3): dt-bindings: display: panel: Add Himax HX83112A drm/panel: Add driver for DJN

[PATCH 1/3] dt-bindings: display: panel: Add Himax HX83112A

2024-01-05 Thread Luca Weiss
Himax HX83112A is a display driver IC used to drive LCD DSI panels. Describe it. Signed-off-by: Luca Weiss --- .../bindings/display/panel/himax,hx83112a.yaml | 75 ++ 1 file changed, 75 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/himax

[PATCH 3/3] arm64: dts: qcom: sm7225-fairphone-fp4: Enable display and GPU

2024-01-05 Thread Luca Weiss
e the GPU. Signed-off-by: Luca Weiss --- arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 62 +++ 1 file changed, 53 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts

[PATCH 2/3] drm/panel: Add driver for DJN HX83112A LCD panel

2024-01-05 Thread Luca Weiss
Add support for the 2340x1080 LCD DJN panel bundled with a HX83112A driver IC, as found on the Fairphone 4 smartphone. Signed-off-by: Luca Weiss --- drivers/gpu/drm/panel/Kconfig| 9 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-himax

Re: [PATCH 3/3] arm64: dts: qcom: sm7225-fairphone-fp4: Enable display and GPU

2024-01-10 Thread Luca Weiss
On Wed Jan 10, 2024 at 11:58 AM CET, Konrad Dybcio wrote: > > > On 1/5/24 15:29, Luca Weiss wrote: > > Add the description for the display panel found on this phone and remove > > the simple-framebuffer that was in place until now > > Why? They should be able to coexis

Re: [PATCH 3/3] arm64: dts: qcom: sm7225-fairphone-fp4: Enable display and GPU

2024-01-10 Thread Luca Weiss
On Wed Jan 10, 2024 at 12:23 PM CET, Maxime Ripard wrote: > On Wed, Jan 10, 2024 at 12:00:23PM +0100, Luca Weiss wrote: > > On Wed Jan 10, 2024 at 11:58 AM CET, Konrad Dybcio wrote: > > > > > > > > > On 1/5/24 15:29, Luca Weiss wrote: > > > > Add the

[PATCH v2 0/4] Add display support for Fairphone 4

2024-01-10 Thread Luca Weiss
Introduce the bindings and panel driver for the DJN LCD panel using HX83112A driver IC. Then we can add the panel to the device dts and also enable the GPU. Signed-off-by: Luca Weiss --- Changes in v2: - Driver: - Drop "bool prepared" from driver (Dmitr

[PATCH v2 3/4] arm64: dts: qcom: sm6350: Remove "disabled" state of GMU

2024-01-10 Thread Luca Weiss
The GMU won't probe without GPU being enabled, so we can remove the disabled status so we don't have to explicitly enable the GMU in all the devices that enable GPU. Signed-off-by: Luca Weiss --- arch/arm64/boot/dts/qcom/sm6350.dtsi | 2 -- 1 file changed, 2 deletions(-) diff --

[PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-01-10 Thread Luca Weiss
Add support for the 2340x1080 LCD DJN panel bundled with a HX83112A driver IC, as found on the Fairphone 4 smartphone. Signed-off-by: Luca Weiss --- drivers/gpu/drm/panel/Kconfig| 10 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-himax

[PATCH v2 4/4] arm64: dts: qcom: sm7225-fairphone-fp4: Enable display and GPU

2024-01-10 Thread Luca Weiss
Add the description for the display panel found on this phone. Unfortunately the LCDB module on PM6150L isn't yet supported upstream so we need to use a dummy regulator-fixed in the meantime. And with this done we can also enable the GPU and set the zap shader firmware path. Signed-off-by:

[PATCH v2 1/4] dt-bindings: display: panel: Add Himax HX83112A

2024-01-10 Thread Luca Weiss
Himax HX83112A is a display driver IC used to drive LCD DSI panels. Describe it. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Luca Weiss --- .../bindings/display/panel/himax,hx83112a.yaml | 75 ++ 1 file changed, 75 insertions(+) diff --git a/Documentation

[PATCH] drm/bridge: Select DRM_KMS_HELPER for DRM_PANEL_BRIDGE

2024-01-11 Thread Luca Weiss
-ld: drivers/phy/qualcomm/phy-qcom-qmp-combo.o: in function `qmp_combo_bridge_attach': drivers/phy/qualcomm/phy-qcom-qmp-combo.c:3204:(.text+0x8f4): undefined reference to `devm_drm_of_get_bridge' Signed-off-by: Luca Weiss --- I can see "depends on DRM_KMS_HELPER" was

Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-01-11 Thread Luca Weiss
On Thu Jan 11, 2024 at 3:57 PM CET, Linus Walleij wrote: > On Wed, Jan 10, 2024 at 4:14 PM Luca Weiss wrote: > > > Add support for the 2340x1080 LCD DJN panel bundled with a HX83112A > > driver IC, as found on the Fairphone 4 smartphone. > > > > Signed-off-by: Luca

Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-01-12 Thread Luca Weiss
On Thu Jan 11, 2024 at 8:05 PM CET, Linus Walleij wrote: > On Thu, Jan 11, 2024 at 4:28 PM Luca Weiss wrote: > > > In some internal documentation it says "LCD Driver IC" "HX83112A" and I > > don't see any reference to Truly 5P65 anywhere. > > In t

Re: [PATCH v2 2/4] drm/panel: Add driver for DJN HX83112A LCD panel

2024-01-12 Thread Luca Weiss
On Fri Jan 12, 2024 at 10:14 AM CET, Neil Armstrong wrote: > On 12/01/2024 10:00, Luca Weiss wrote: > > On Thu Jan 11, 2024 at 8:05 PM CET, Linus Walleij wrote: > >> On Thu, Jan 11, 2024 at 4:28 PM Luca Weiss > >> wrote: > >> > >>> In some internal

  1   2   >